Repository navigation
[backport core/1.54] fix: materialize insert_workflow links with numeric ids - #18548
Conversation
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1941 passed, 0 failed📊 Browser Reports
🌐 Website E2ETip All tests passed.
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.54 #18548 +/- ##
=============================================
- Coverage 83.62% 82.11% -1.51%
=============================================
Files 2097 2527 +430
Lines 123850 131532 +7682
Branches 31549 35267 +3718
=============================================
+ Hits 103568 108006 +4438
- Misses 20103 23012 +2909
- Partials 179 514 +335
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Exact-head self-review: no blocking findings. The core/1.54 backport preserves branch-native code and uses published 0.3.4; hosted CI remains the final gate.
Full context for agent readers
Reviewed head e96b050 against core/1.54. The final tree retains the regression test for numeric, safe-integer link IDs and follower projection, removes the temporary codeload dependency/build allowance, and locks npm 0.3.4 to the published integrity. No unresolved review threads were present. This is COMMENT-only because the PR is self-authored; Huang's approval is the independent review.
Summary
Release-native backport of the merged main fix:
insert_workflownodes no longer materialize without their links.Full context for agent readers
Changes
@comfyorg/comfy-multi-playerto published npm version0.3.4, which mints numeric link IDs forinsert_workflow.Review focus
This intentionally omits the main-branch-only
AgentCrdtProjectionandparseLinkIdchanges that made the generated core backport fail to compile. The version 1.54 adapter already accepts the upstream numeric IDs.The original branch-native targeted integration suite, ESLint, formatting, typecheck, and pre-push Knip passed before the npm-source correction. Hosted checks are requalifying the corrected exact head.
Backport of the merged main fix. Supersedes the generated core backport.