Skip to content

[backport core/1.54] fix: materialize insert_workflow links with numeric ids - #18548

Merged
christian-byrne merged 2 commits into
core/1.54from
backport-18458-to-core-1.54-v2
Sep 23, 2026
Merged

christian-byrne merged 2 commits into
core/1.54from
backport-18458-to-core-1.54-v2

Conversation

@christian-byrne

@christian-byrne christian-byrne commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Release-native backport of the merged main fix: insert_workflow nodes no longer materialize without their links.

Full context for agent readers

Changes

  • Pins @comfyorg/comfy-multi-player to published npm version 0.3.4, which mints numeric link IDs for insert_workflow.
  • Adds a version 1.54-native integration regression proving a three-node inserted workflow stores canonical numeric IDs and projects both links.
  • Removes the obsolete codeload build allowance; no GitHub tarball remains in the effective dependency path.

Review focus

This intentionally omits the main-branch-only AgentCrdtProjection and parseLinkId changes that made the generated core backport fail to compile. The version 1.54 adapter already accepts the upstream numeric IDs.

The original branch-native targeted integration suite, ESLint, formatting, typecheck, and pre-push Knip passed before the npm-source correction. Hosted checks are requalifying the corrected exact head.

Backport of the merged main fix. Supersedes the generated core backport.

@coderabbitai

coderabbitai Bot commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: 688c82cd-1c5c-49cf-b707-d3c1496258b6

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@vercel

vercel Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
billing-web Ignored Ignored Sep 23, 2026 5:33am UTC

Request Review

@github-actions

github-actions Bot commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/23/2026, 05:46:19 AM UTC

Links

🎭 Playwright: ✅ 1941 passed, 0 failed

📊 Browser Reports
  • chromium: View Report (✅ 1920 / ❌ 0 / ⚠️ 0 / ⏭️ 13)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🌐 Website E2E

Tip

All tests passed.

Status ✅ Passed
Report View Report

@socket-security

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatednpm/​@​comfyorg/​comfy-multi-player@​0.3.2 ⏵ 0.3.4100 +1100100 +196 +170

View full report

@codecov

codecov Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@              Coverage Diff              @@
##           core/1.54   #18548      +/-   ##
=============================================
- Coverage      83.62%   82.11%   -1.51%     
=============================================
  Files           2097     2527     +430     
  Lines         123850   131532    +7682     
  Branches       31549    35267    +3718     
=============================================
+ Hits          103568   108006    +4438     
- Misses         20103    23012    +2909     
- Partials         179      514     +335     
Flag Coverage Δ
unit 78.62% <ø> (-0.01%) ⬇️
website-unit 57.82% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 431 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@christian-byrne christian-byrne left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exact-head self-review: no blocking findings. The core/1.54 backport preserves branch-native code and uses published 0.3.4; hosted CI remains the final gate.

Full context for agent readers

Reviewed head e96b050 against core/1.54. The final tree retains the regression test for numeric, safe-integer link IDs and follower projection, removes the temporary codeload dependency/build allowance, and locks npm 0.3.4 to the published integrity. No unresolved review threads were present. This is COMMENT-only because the PR is self-authored; Huang's approval is the independent review.

@github-actions github-actions Bot added the risk:xhigh PR risk grade (advisory shadow check; grader-owned) label Sep 23, 2026
@christian-byrne
christian-byrne enabled auto-merge (squash) September 23, 2026 05:51
@christian-byrne
christian-byrne merged commit 563c4a7 into core/1.54 Sep 23, 2026
93 checks passed
@christian-byrne
christian-byrne deleted the backport-18458-to-core-1.54-v2 branch September 23, 2026 06:10
@DrJKL DrJKL added agent Comfy Agent product, integration, tests or product documentation agent-backport Agent changes targeting a stable cloud/core release branch agent-crdt Agent document synchronization, graph projection or CRDT operations agent-test-unit Touches Agent-related unit/component tests or their support labels Sep 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent Comfy Agent product, integration, tests or product documentation agent-backport Agent changes targeting a stable cloud/core release branch agent-crdt Agent document synchronization, graph projection or CRDT operations agent-test-unit Touches Agent-related unit/component tests or their support risk:xhigh PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants