Skip to content

chore: replace comfy-multi-player tarball pin with published 0.3.4 - #18544

Closed
claude[bot] wants to merge 3 commits into
mainfrom
chore/comfy-multi-player-npm-pin
Closed

claude[bot] wants to merge 3 commits into
mainfrom
chore/comfy-multi-player-npm-pin

Conversation

@claude

@claude claude Bot commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

Requested by Christian Byrne · Slack thread

Why

#18458 pinned @comfyorg/comfy-multi-player in pnpm-workspace.yaml's catalog to a codeload.github.com git-tarball URL as a temporary measure, since the fix hadn't been published to npm yet. That wasn't supposed to stay — @comfyorg/comfy-multi-player@0.3.4 (comfy-multi-player#246) is now published to npm, so this cleans up the tarball pin per Christian's request.

What

  • pnpm-workspace.yaml: pin @comfyorg/comfy-multi-player to the exact version 0.3.4 instead of the codeload tarball URL, matching the exact-pin convention already used for sibling @comfyorg/* catalog entries (@comfyorg/sdk, @comfyorg/comfyui-desktop-bridge-types).
  • Removed the now-unused allowBuilds entry keyed to the tarball URL — the published npm package has no install/postinstall script requiring build-script approval.
  • Added 0.3.4 to minimumReleaseAgeExclude (pnpm added this automatically on pnpm install since the version was published minutes before this PR).
  • pnpm-lock.yaml regenerated via pnpm install (not hand-edited). It now resolves @comfyorg/comfy-multi-player@0.3.4 from the npm registry (integrity-only resolution, no tarball/git fields).

Verification

  • Confirmed @comfyorg/comfy-multi-player@0.3.4 is live on the npm registry (dist-tags.latest = 0.3.4) before making this change.
  • pnpm install regenerated the lockfile cleanly; pnpm-lock.yaml entry for the package now carries only an integrity resolution (registry-resolved), not a git/tarball reference.
  • pnpm lint — 0 errors.
  • pnpm typecheck — passes (vue-tsc + the package sub-typechecks).
  • pnpm test:unit src/workbench/extensions/agent/crdt/ — 59 test files, 887 passed / 15 expected-fail (902 total), including agentInsertWorkflowLinks.regression.test.ts (15/15).
  • Checked .github/workflows/multiplayer-pin-currency.yaml: it reads the literal dependencies["@comfyorg/comfy-multi-player"] spec out of root package.json, which is "catalog:" here (not the resolved version), so it can't currently establish source currency regardless of the pin style — its last 3 scheduled runs all failed the same way before this PR. Pre-existing and orthogonal to this change; flagging as a possible follow-up rather than fixing here.

🤖 Generated with Claude Code

https://claude.ai/code/session_01UqyourCBfi97xzpBx2W7oY


Generated by Claude Code

PR #18458 pinned @comfyorg/comfy-multi-player to a codeload.github.com
git-tarball URL as a temporary measure because the fix hadn't been
published to npm yet. @comfyorg/comfy-multi-player@0.3.4 is now live on
npm (published via comfy-multi-player#246 + the auto-tag-release/release
workflows), so switch the catalog entry to a normal exact version pin,
matching the convention used for sibling @comfyorg/* catalog entries.

- pnpm-workspace.yaml: pin '@comfyorg/comfy-multi-player' to 0.3.4
  instead of the codeload tarball URL; drop the now-unused allowBuilds
  entry keyed to that tarball URL (the npm package has no
  install/postinstall script requiring build approval); add 0.3.4 to
  minimumReleaseAgeExclude (pnpm added this automatically since the
  version was just published).
- pnpm-lock.yaml: regenerated via `pnpm install` so the dependency now
  resolves from the npm registry instead of a git tarball.

Claude-Session: https://claude.ai/code/session_01UqyourCBfi97xzpBx2W7oY
@claude
claude Bot requested a review from a team September 23, 2026 04:57
@coderabbitai

coderabbitai Bot commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 0e91a9cd-a2c9-4286-8429-8b1c81c76f39

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@socket-security

socket-security Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addednpm/​@​comfyorg/​comfy-multi-player@​0.3.41001001009670

View full report

DrJKL
DrJKL previously approved these changes Sep 23, 2026
Comment thread pnpm-workspace.yaml Outdated
minimumReleaseAgeExclude:
- '@comfyorg/comfyui-desktop-bridge-types@0.2.0'
- '@comfyorg/comfy-multi-player@0.2.0 || 0.2.1 || 0.3.0 || 0.3.2 || 0.3.3'
- '@comfyorg/comfy-multi-player@0.2.0 || 0.2.1 || 0.3.0 || 0.3.2 || 0.3.3 || 0.3.4'

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can probably remove the older versions here.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in e53322c...(updated) — trimmed minimumReleaseAgeExclude down to just @comfyorg/comfy-multi-player@0.3.4. Verified with pnpm install: the lockfile still passes the supply-chain/release-age check with only the current pin listed, so the older 0.2.0/0.2.1/0.3.0/0.3.2/0.3.3 entries weren't needed (they were never being resolved against). Also generalized the comment above the list since it now covers two packages' worth of drop-when-stale entries.

@github-actions

github-actions Bot commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

No new findings in the changed files.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since d68e6634ff053fc893c21817ecabf3d5972d3898

Full docs: ADR-DEVEX-LINT-0015

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/23/2026, 05:42:57 AM UTC

Links

🎭 Playwright: ✅ 2118 passed, 0 failed · 1 flaky

📊 Browser Reports
  • chromium: View Report (✅ 2097 / ❌ 0 / ⚠️ 1 / ⏭️ 13)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🧩 Custom Nodes Ecosystem Matrix: ✅ Passed

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

Stage Result What a failure here means
pin-status success Informational. It never fails the build; it warns when the corpus snapshot is over 30 days old.
corpus success Infrastructure: the pack mirror could not be fetched, validated or cached. Not your diff.
shards success Harness integrity, not pack breakage. A shard only checks that every built spec wrote its row; vitest's own exit code is deliberately ignored because pack code leaks unhandled rejections.
verdicts success The population verdict per renderer. This is the stage that judges packs. Exit 1 is FAIL; exit 2 is withheld — rows were missing, so nothing was measured, which is not the same as your change breaking packs.
detection-proofs success The instrument self-test: the matrix must FAIL on a deliberately poisoned corpus. A failure here means the gate cannot be trusted this run, in either direction.

On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff.

Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

🌐 Website E2E

Tip

All tests passed.

Status ✅ Passed
Report View Report

…ayer

Per DrJKL's review on #18544: only the active 0.3.4 pin needs a
release-age exclusion. The 0.2.0/0.2.1/0.3.0/0.3.2/0.3.3 entries were
never being resolved against and pnpm install passes identically
without them.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01UqyourCBfi97xzpBx2W7oY
@github-actions github-actions Bot added the risk:xhigh PR risk grade (advisory shadow check; grader-owned) label Sep 23, 2026
@christian-byrne

Copy link
Copy Markdown
Contributor

Superseded by a clean replacement. No history rewrite.

Full context for agent readers

The replacement pull request has the same reviewed dependency tree, starts from current main, and contains no rejected co-author trailer.

@codecov

codecov Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@            Coverage Diff             @@
##             main   #18544      +/-   ##
==========================================
- Coverage   83.51%   83.51%   -0.01%     
==========================================
  Files        2989     2989              
  Lines      147961   147961              
  Branches    38217    38217              
==========================================
- Hits       123567   123563       -4     
- Misses      23109    23113       +4     
  Partials     1285     1285              
Flag Coverage Δ
billing-web-unit 80.06% <ø> (ø)
unit 80.30% <ø> (-0.01%) ⬇️
website-unit 75.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

christian-byrne added a commit that referenced this pull request Sep 23, 2026
## Summary

Use published `@comfyorg/comfy-multi-player@0.3.5`; replace [the blocked
predecessor](#18544),
whose commit trailer cannot pass policy without rewriting history.

<details>
<summary>Full context for agent readers</summary>

- Replaces the temporary codeload tarball pin from [the numeric-link
fix](#18458) with
exact npm version `0.3.5`.
- Removes the tarball-specific `allowBuilds` entry.
- Keeps only the active `0.3.5` release-age exclusion, addressing
[DrJKL's
review](#18544 (comment)).
- Starts from current `main` and contains one clean commit with no
rejected co-author trailer.
- Was originally opened against `0.3.4`, then bumped to `0.3.5` once
[comfy-multi-player#248](Comfy-Org/comfy-multi-player#248)
published it — 0.3.5 fixes a `structuredClone`/`TS2304` typing gap in
comfy-multi-player's own build
([comfy-multi-player#247](Comfy-Org/comfy-multi-player#247))
that 0.3.4 did not fix.
- Also bumps the frontend's own `yjs` catalog pin to `^13.6.32`:
comfy-multi-player@0.3.5's own `yjs ^13.6.27` dependency resolved to
`13.6.32`, which coexisted with the frontend's previously-pinned
`13.6.31` as two separate package instances and broke `vue-tsc`
(`TS2345`, incompatible `Doc`/`AbstractType`/`Item` types) in
`schemaGuard.ts` and `useAgentCrdtFollower.integration.test.ts`.
Deduping to one `yjs` instance fixes it.

npm reports the lockfile integrity for `0.3.5` as
`sha512-stsag63SdKI/EFzdbEFPO3IhGzftyDcuJnT0WyPLMc08nEWkwg0M8kmVHAc4akRsIeWoj7mXSLzbHxpcbCm3lg==`.

</details>

---------

Co-authored-by: Claude <noreply@anthropic.com>
@DrJKL DrJKL added agent Comfy Agent product, integration, tests or product documentation agent-crdt Agent document synchronization, graph projection or CRDT operations labels Sep 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent Comfy Agent product, integration, tests or product documentation agent-crdt Agent document synchronization, graph projection or CRDT operations risk:xhigh PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants