Repository navigation
chore: replace comfy-multi-player tarball pin with published 0.3.4 - #18544
claude[bot] wants to merge 3 commits into
Conversation
PR #18458 pinned @comfyorg/comfy-multi-player to a codeload.github.com git-tarball URL as a temporary measure because the fix hadn't been published to npm yet. @comfyorg/comfy-multi-player@0.3.4 is now live on npm (published via comfy-multi-player#246 + the auto-tag-release/release workflows), so switch the catalog entry to a normal exact version pin, matching the convention used for sibling @comfyorg/* catalog entries. - pnpm-workspace.yaml: pin '@comfyorg/comfy-multi-player' to 0.3.4 instead of the codeload tarball URL; drop the now-unused allowBuilds entry keyed to that tarball URL (the npm package has no install/postinstall script requiring build approval); add 0.3.4 to minimumReleaseAgeExclude (pnpm added this automatically since the version was just published). - pnpm-lock.yaml: regenerated via `pnpm install` so the dependency now resolves from the npm registry instead of a git tarball. Claude-Session: https://claude.ai/code/session_01UqyourCBfi97xzpBx2W7oY
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
| minimumReleaseAgeExclude: | ||
| - '@comfyorg/comfyui-desktop-bridge-types@0.2.0' | ||
| - '@comfyorg/comfy-multi-player@0.2.0 || 0.2.1 || 0.3.0 || 0.3.2 || 0.3.3' | ||
| - '@comfyorg/comfy-multi-player@0.2.0 || 0.2.1 || 0.3.0 || 0.3.2 || 0.3.3 || 0.3.4' |
There was a problem hiding this comment.
We can probably remove the older versions here.
There was a problem hiding this comment.
Addressed in e53322c...(updated) — trimmed minimumReleaseAgeExclude down to just @comfyorg/comfy-multi-player@0.3.4. Verified with pnpm install: the lockfile still passes the supply-chain/release-age check with only the current pin listed, so the older 0.2.0/0.2.1/0.3.0/0.3.2/0.3.3 entries weren't needed (they were never being resolved against). Also generalized the comment above the list since it now covers two packages' worth of drop-when-stale entries.
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since d68e6634ff053fc893c21817ecabf3d5972d3898
Full docs: ADR-DEVEX-LINT-0015 🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 2118 passed, 0 failed · 1 flaky📊 Browser Reports
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌐 Website E2ETip All tests passed.
|
…ayer Per DrJKL's review on #18544: only the active 0.3.4 pin needs a release-age exclusion. The 0.2.0/0.2.1/0.3.0/0.3.2/0.3.3 entries were never being resolved against and pnpm install passes identically without them. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UqyourCBfi97xzpBx2W7oY
|
Superseded by a clean replacement. No history rewrite. Full context for agent readersThe replacement pull request has the same reviewed dependency tree, starts from current |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #18544 +/- ##
==========================================
- Coverage 83.51% 83.51% -0.01%
==========================================
Files 2989 2989
Lines 147961 147961
Branches 38217 38217
==========================================
- Hits 123567 123563 -4
- Misses 23109 23113 +4
Partials 1285 1285
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
## Summary Use published `@comfyorg/comfy-multi-player@0.3.5`; replace [the blocked predecessor](#18544), whose commit trailer cannot pass policy without rewriting history. <details> <summary>Full context for agent readers</summary> - Replaces the temporary codeload tarball pin from [the numeric-link fix](#18458) with exact npm version `0.3.5`. - Removes the tarball-specific `allowBuilds` entry. - Keeps only the active `0.3.5` release-age exclusion, addressing [DrJKL's review](#18544 (comment)). - Starts from current `main` and contains one clean commit with no rejected co-author trailer. - Was originally opened against `0.3.4`, then bumped to `0.3.5` once [comfy-multi-player#248](Comfy-Org/comfy-multi-player#248) published it — 0.3.5 fixes a `structuredClone`/`TS2304` typing gap in comfy-multi-player's own build ([comfy-multi-player#247](Comfy-Org/comfy-multi-player#247)) that 0.3.4 did not fix. - Also bumps the frontend's own `yjs` catalog pin to `^13.6.32`: comfy-multi-player@0.3.5's own `yjs ^13.6.27` dependency resolved to `13.6.32`, which coexisted with the frontend's previously-pinned `13.6.31` as two separate package instances and broke `vue-tsc` (`TS2345`, incompatible `Doc`/`AbstractType`/`Item` types) in `schemaGuard.ts` and `useAgentCrdtFollower.integration.test.ts`. Deduping to one `yjs` instance fixes it. npm reports the lockfile integrity for `0.3.5` as `sha512-stsag63SdKI/EFzdbEFPO3IhGzftyDcuJnT0WyPLMc08nEWkwg0M8kmVHAc4akRsIeWoj7mXSLzbHxpcbCm3lg==`. </details> --------- Co-authored-by: Claude <noreply@anthropic.com>
Requested by Christian Byrne · Slack thread
Why
#18458 pinned
@comfyorg/comfy-multi-playerinpnpm-workspace.yaml's catalog to acodeload.github.comgit-tarball URL as a temporary measure, since the fix hadn't been published to npm yet. That wasn't supposed to stay —@comfyorg/comfy-multi-player@0.3.4(comfy-multi-player#246) is now published to npm, so this cleans up the tarball pin per Christian's request.What
pnpm-workspace.yaml: pin@comfyorg/comfy-multi-playerto the exact version0.3.4instead of the codeload tarball URL, matching the exact-pin convention already used for sibling@comfyorg/*catalog entries (@comfyorg/sdk,@comfyorg/comfyui-desktop-bridge-types).allowBuildsentry keyed to the tarball URL — the published npm package has noinstall/postinstallscript requiring build-script approval.0.3.4tominimumReleaseAgeExclude(pnpm added this automatically onpnpm installsince the version was published minutes before this PR).pnpm-lock.yamlregenerated viapnpm install(not hand-edited). It now resolves@comfyorg/comfy-multi-player@0.3.4from the npm registry (integrity-only resolution, notarball/git fields).Verification
@comfyorg/comfy-multi-player@0.3.4is live on the npm registry (dist-tags.latest=0.3.4) before making this change.pnpm installregenerated the lockfile cleanly;pnpm-lock.yamlentry for the package now carries only anintegrityresolution (registry-resolved), not a git/tarball reference.pnpm lint— 0 errors.pnpm typecheck— passes (vue-tsc + the package sub-typechecks).pnpm test:unit src/workbench/extensions/agent/crdt/— 59 test files, 887 passed / 15 expected-fail (902 total), includingagentInsertWorkflowLinks.regression.test.ts(15/15)..github/workflows/multiplayer-pin-currency.yaml: it reads the literaldependencies["@comfyorg/comfy-multi-player"]spec out of rootpackage.json, which is"catalog:"here (not the resolved version), so it can't currently establish source currency regardless of the pin style — its last 3 scheduled runs all failed the same way before this PR. Pre-existing and orthogonal to this change; flagging as a possible follow-up rather than fixing here.🤖 Generated with Claude Code
https://claude.ai/code/session_01UqyourCBfi97xzpBx2W7oY
Generated by Claude Code