Repository navigation
[backport cloud/1.54] fix: materialize insert_workflow links with numeric ids - #18549
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1940 passed, 0 failed📊 Browser Reports
🌐 Website E2ETip All tests passed.
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-23T06:01:49.497Z",
"gitSha": "6168bb7bada084dccc49e132f10cc6ad6ab8c8a4",
"branch": "backport-18458-to-cloud-1.54-v2",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2070.686999999907,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.363999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 439.20599999999996,
"heapDeltaBytes": 7063308,
"heapUsedBytes": 76826668,
"domNodes": -279,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 11.046,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2024.8729999999568,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.452,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 433.22399999999993,
"heapDeltaBytes": -11210676,
"heapUsedBytes": 59019392,
"domNodes": -281,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 10.798,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1719.6689999999535,
"styleRecalcs": 73,
"styleRecalcDurationMs": 25.938000000000002,
"layouts": 14,
"layoutDurationMs": 4.388999999999999,
"taskDurationMs": 650.476,
"heapDeltaBytes": -6098832,
"heapUsedBytes": 63531204,
"domNodes": -279,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 122.07399999999998,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1728.315000000066,
"styleRecalcs": 73,
"styleRecalcDurationMs": 26.369000000000003,
"layouts": 14,
"layoutDurationMs": 4.009,
"taskDurationMs": 642.582,
"heapDeltaBytes": -4830004,
"heapUsedBytes": 65108052,
"domNodes": -281,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 106.909,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1657.9610000000002,
"styleRecalcs": 31,
"styleRecalcDurationMs": 14.150999999999998,
"layouts": 6,
"layoutDurationMs": 1.1059999999999999,
"taskDurationMs": 261.441,
"heapDeltaBytes": 4325844,
"heapUsedBytes": 74657328,
"domNodes": 75,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 11.551,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1707.0139999999583,
"styleRecalcs": 31,
"styleRecalcDurationMs": 14.918000000000001,
"layouts": 6,
"layoutDurationMs": 1.145,
"taskDurationMs": 269.347,
"heapDeltaBytes": 4615724,
"heapUsedBytes": 75325520,
"domNodes": 76,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 12.433000000000002,
"eventListeners": 21,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 521.2669999999662,
"styleRecalcs": 13,
"styleRecalcDurationMs": 7.683,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 322.38800000000003,
"heapDeltaBytes": -7858604,
"heapUsedBytes": 63169700,
"domNodes": 22,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 103.864,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666682,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 509.56299999995736,
"styleRecalcs": 13,
"styleRecalcDurationMs": 7.848000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 318.848,
"heapDeltaBytes": 18706240,
"heapUsedBytes": 88339392,
"domNodes": 22,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 104.888,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2024.8540000000048,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.350999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 460.835,
"heapDeltaBytes": 7011660,
"heapUsedBytes": 83513224,
"domNodes": -274,
"jsHeapTotalBytes": -1155072,
"scriptDurationMs": 27.806000000000004,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2008.2929999999806,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.200999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 519.1479999999999,
"heapDeltaBytes": 4345956,
"heapUsedBytes": 80074068,
"domNodes": -275,
"jsHeapTotalBytes": -1941504,
"scriptDurationMs": 32.755,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2486.393000000021,
"styleRecalcs": 66,
"styleRecalcDurationMs": 12.438999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1146.3039999999999,
"heapDeltaBytes": 22602928,
"heapUsedBytes": 88731620,
"domNodes": 8,
"jsHeapTotalBytes": 749568,
"scriptDurationMs": 534.52,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 3042.5880000000234,
"styleRecalcs": 67,
"styleRecalcDurationMs": 13.971,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1275.0539999999999,
"heapDeltaBytes": 26418368,
"heapUsedBytes": 93139644,
"domNodes": 10,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 607.413,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3372.6709999999684,
"styleRecalcs": 64,
"styleRecalcDurationMs": 14.613999999999999,
"layouts": 60,
"layoutDurationMs": 13.459,
"taskDurationMs": 1202.671,
"heapDeltaBytes": 10391764,
"heapUsedBytes": 76441392,
"domNodes": -273,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 514.63,
"eventListeners": -186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3500.407999999993,
"styleRecalcs": 64,
"styleRecalcDurationMs": 16.979999999999997,
"layouts": 60,
"layoutDurationMs": 13.749,
"taskDurationMs": 1297.0249999999999,
"heapDeltaBytes": -2124688,
"heapUsedBytes": 75754932,
"domNodes": -276,
"jsHeapTotalBytes": -1941504,
"scriptDurationMs": 540.578,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "legacy-node-drag",
"durationMs": 2569.8260000000346,
"styleRecalcs": 43,
"styleRecalcDurationMs": 7.565000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1423.442,
"heapDeltaBytes": 18724596,
"heapUsedBytes": 85483276,
"domNodes": -277,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 679.8219999999999,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2855.6499999999687,
"styleRecalcs": 40,
"styleRecalcDurationMs": 6.007999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1460.325,
"heapDeltaBytes": 17954952,
"heapUsedBytes": 86007456,
"domNodes": 0,
"jsHeapTotalBytes": 2252800,
"scriptDurationMs": 701.017,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2012.1049999999059,
"styleRecalcs": 6,
"styleRecalcDurationMs": 4.583000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 416.495,
"heapDeltaBytes": 9957604,
"heapUsedBytes": 86678336,
"domNodes": -271,
"jsHeapTotalBytes": -1417216,
"scriptDurationMs": 29.093,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2026.958000000036,
"styleRecalcs": 6,
"styleRecalcDurationMs": 4.799999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 562.8870000000002,
"heapDeltaBytes": 9674404,
"heapUsedBytes": 87313176,
"domNodes": -270,
"jsHeapTotalBytes": -2727936,
"scriptDurationMs": 33.574999999999996,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 425.7479999999987,
"styleRecalcs": 48,
"styleRecalcDurationMs": 10.324,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 289.305,
"heapDeltaBytes": 14767656,
"heapUsedBytes": 87798712,
"domNodes": 22,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 94.38499999999999,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 525.6170000000111,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.184000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 309.549,
"heapDeltaBytes": 14770200,
"heapUsedBytes": 87994956,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 101.102,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666682,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2010.0809999999,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.521,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 348.084,
"heapDeltaBytes": -5562740,
"heapUsedBytes": 67631756,
"domNodes": -295,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 8.71,
"eventListeners": -238,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2008.895999999936,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.447000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 406.86599999999993,
"heapDeltaBytes": -9656464,
"heapUsedBytes": 62531468,
"domNodes": -298,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 10.326,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1692.3810000000685,
"styleRecalcs": 77,
"styleRecalcDurationMs": 26.218,
"layouts": 18,
"layoutDurationMs": 5.4319999999999995,
"taskDurationMs": 623.0880000000001,
"heapDeltaBytes": -8845620,
"heapUsedBytes": 63258236,
"domNodes": -297,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 89.67,
"eventListeners": -238,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1728.5420000000613,
"styleRecalcs": 78,
"styleRecalcDurationMs": 26.63,
"layouts": 18,
"layoutDurationMs": 5.1370000000000005,
"taskDurationMs": 749.204,
"heapDeltaBytes": -13098632,
"heapUsedBytes": 59690276,
"domNodes": -295,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 107.20100000000001,
"eventListeners": -208,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 818.1049999999459,
"styleRecalcs": 20,
"styleRecalcDurationMs": 22.224,
"layouts": 16,
"layoutDurationMs": 10.875000000000002,
"taskDurationMs": 647.084,
"heapDeltaBytes": -7306160,
"heapUsedBytes": 84592980,
"domNodes": 13751,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 20.735000000000003,
"eventListeners": 2385,
"totalBlockingTimeMs": 70,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 10405.01000000006,
"styleRecalcs": 249,
"styleRecalcDurationMs": 43.772000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4619.643,
"heapDeltaBytes": -5483524,
"heapUsedBytes": 97668580,
"domNodes": -265,
"jsHeapTotalBytes": 909312,
"scriptDurationMs": 2139.967,
"eventListeners": -140,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 10536.574999999972,
"styleRecalcs": 249,
"styleRecalcDurationMs": 46.70199999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4773.441,
"heapDeltaBytes": 10993960,
"heapUsedBytes": 86675188,
"domNodes": -241,
"jsHeapTotalBytes": 610304,
"scriptDurationMs": 2114.057,
"eventListeners": -170,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 12691.037000000051,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12209.684,
"heapDeltaBytes": -54193820,
"heapUsedBytes": 170040236,
"domNodes": -8068,
"jsHeapTotalBytes": -6332416,
"scriptDurationMs": 188.55099999999996,
"eventListeners": -14933,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 12988.81199999994,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12609.794000000002,
"heapDeltaBytes": -56619020,
"heapUsedBytes": 180320200,
"domNodes": -8068,
"jsHeapTotalBytes": -19312640,
"scriptDurationMs": 196.352,
"eventListeners": -14935,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 15164.399000000003,
"styleRecalcs": 78,
"styleRecalcDurationMs": 15.125,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14682.323999999999,
"heapDeltaBytes": -26023860,
"heapUsedBytes": 193033404,
"domNodes": -8068,
"jsHeapTotalBytes": -14761984,
"scriptDurationMs": 655.497,
"eventListeners": -14931,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 15208.244000000035,
"styleRecalcs": 75,
"styleRecalcDurationMs": 15.062999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14799.026000000002,
"heapDeltaBytes": -47735744,
"heapUsedBytes": 165022120,
"domNodes": -8068,
"jsHeapTotalBytes": -18288640,
"scriptDurationMs": 650.988,
"eventListeners": -14931,
"totalBlockingTimeMs": 2,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 4471.210000000042,
"styleRecalcs": 20,
"styleRecalcDurationMs": 54.13499999999999,
"layouts": 20,
"layoutDurationMs": 22.085000000000008,
"taskDurationMs": 4376.762,
"heapDeltaBytes": -46252648,
"heapUsedBytes": 185236572,
"domNodes": -8068,
"jsHeapTotalBytes": 5591040,
"scriptDurationMs": 102.86099999999999,
"eventListeners": -14931,
"totalBlockingTimeMs": 101,
"frameDurationMs": 17.220000000000013,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 4584.951000000046,
"styleRecalcs": 20,
"styleRecalcDurationMs": 55.22000000000002,
"layouts": 20,
"layoutDurationMs": 23.653999999999993,
"taskDurationMs": 4518.3460000000005,
"heapDeltaBytes": -29307696,
"heapUsedBytes": 189373388,
"domNodes": -8068,
"jsHeapTotalBytes": 20697088,
"scriptDurationMs": 75.919,
"eventListeners": -14931,
"totalBlockingTimeMs": 141,
"frameDurationMs": 17.220000000000013,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6318.86899999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6050.391999999999,
"heapDeltaBytes": 703296,
"heapUsedBytes": 185212428,
"domNodes": 0,
"jsHeapTotalBytes": -20447232,
"scriptDurationMs": 94.941,
"eventListeners": -8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6563.033000000019,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6349.926,
"heapDeltaBytes": 12554012,
"heapUsedBytes": 183364864,
"domNodes": 0,
"jsHeapTotalBytes": -18612224,
"scriptDurationMs": 102.385,
"eventListeners": -8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 82.37799999994877,
"styleRecalcs": 6,
"styleRecalcDurationMs": 11.17,
"layouts": 3,
"layoutDurationMs": 1.4660000000000002,
"taskDurationMs": 55.537000000000006,
"heapDeltaBytes": 3062260,
"heapUsedBytes": 72031452,
"domNodes": 127,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 5.542,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 64.13899999995465,
"styleRecalcs": 5,
"styleRecalcDurationMs": 9.385000000000002,
"layouts": 2,
"layoutDurationMs": 0.6719999999999999,
"taskDurationMs": 45.89,
"heapDeltaBytes": 3006524,
"heapUsedBytes": 71459188,
"domNodes": 102,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 3.351999999999999,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
}
]
} |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.54 #18549 +/- ##
=============================================
Coverage ? 77.33%
=============================================
Files ? 2439
Lines ? 118826
Branches ? 35432
=============================================
Hits ? 91897
Misses ? 26415
Partials ? 514
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Exact-head self-review: no blocking findings. The cloud/1.54 backport preserves version 1.54.14 and uses published 0.3.4; hosted CI remains the final gate.
Full context for agent readers
Reviewed head 4b892da against cloud/1.54. The final tree corrects the generated backport's accidental 1.54.14 to 1.54.8 downgrade, retains the numeric-link regression test, removes the temporary codeload dependency/build allowance, and locks npm 0.3.4 to the published integrity. No unresolved review threads were present. This is COMMENT-only because the PR is self-authored; Huang's approval is the independent review.
…ric ids (#18559) <!-- ccr-slack-attribution --> _Requested by **Christian Byrne** · [Slack thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1790058330774449?thread_ts=1790058330.774449&cid=C0BGH348Z0C)_ ## Summary Manual backport of the merged main fix (#18458): `insert_workflow` nodes no longer materialize without their links, on `core/1.54`. <details> <summary>Full context for agent readers</summary> ## Changes - Pins `@comfyorg/comfy-multi-player` to published npm version `0.3.4` (was `0.3.2`), which mints numeric link IDs for `insert_workflow` (Comfy-Org/comfy-multi-player#245). - Removes the now-obsolete `allowBuilds` codeload tarball entry from `pnpm-workspace.yaml` and adds `0.3.4` to `minimumReleaseAgeExclude`. - Adds a `core/1.54`-native regression test to the existing `ecsFollowerAdapter.integration.test.ts` proving a three-node inserted workflow batch stores canonical numeric link IDs and both links project onto the canvas. - Regenerated `pnpm-lock.yaml` via `pnpm install` (integrity hash for `0.3.4` matches the one already reviewed in #18549/#18552). ## Review focus This intentionally omits the main-branch-only `ecsFollowerAdapter.ts`/`resolveLinkId`/`resolveLinkMapKey`/`parseLinkId` hardening from #18458. That hardening depends on `parseLinkId`, which was introduced by the unrelated #18361 and is not present on `core/1.54`. It is not required to fix this bug: `core/1.54`'s `readSemanticLink` already accepts a genuine numeric link ID via its existing `Number(tuple[0])` / `Number.isInteger` check, so once `comfy-multi-player` mints real numeric IDs (0.3.4), the bug is fixed by the dependency bump alone. This mirrors the approach #18549 already took for `cloud/1.54` (see that PR's own "Review focus" section), which hit and resolved the identical conflict. Backport of #18458. Companion PRs doing the same dependency-pin cleanup: #18549 (`cloud/1.54`, already covers that branch) and #18552 (`main`). Verified locally: targeted regression test passes (16/16 in `ecsFollowerAdapter.integration.test.ts`), `pnpm typecheck` clean, `pnpm exec eslint`/`pnpm oxlint` on changed files clean. </details> Claude-Session: https://claude.ai/code/session_01UqyourCBfi97xzpBx2W7oY --- _Generated by [Claude Code](https://claude.ai/code/session_01UqyourCBfi97xzpBx2W7oY)_ --------- Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
Summary
Release-native backport of the merged main fix:
insert_workflownodes no longer materialize without their links.Full context for agent readers
Changes
@comfyorg/comfy-multi-playerto published npm version0.3.4, which mints numeric link IDs forinsert_workflow.cloud/1.54package version (1.54.14) and removes the obsolete codeload build allowance.Review focus
This intentionally omits the main-branch-only
AgentCrdtProjectionandparseLinkIdchanges that made the generated cloud backport fail to compile. The version 1.54 adapter already accepts the upstream numeric IDs.The original branch-native targeted integration suite, ESLint, formatting, typecheck, and pre-push Knip passed before the npm-source/version correction. Hosted checks are requalifying the corrected exact head.
Backport of the merged main fix. Supersedes the generated cloud backport.