Repository navigation
[backport cloud/1.54] fix(agent): preserve fresher live widget values during CRDT reconcile - #18423
Conversation
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
🎭 Playwright: ✅ 1937 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-22T11:31:42.746Z",
"gitSha": "77af579b98e63e5eb590a7ca1f14e7d6da814fb0",
"branch": "backport-18361-to-cloud-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2042.9399999999873,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.915999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 581.955,
"heapDeltaBytes": -12640444,
"heapUsedBytes": 56387488,
"domNodes": 16,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 10.269,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2013.3280000000013,
"styleRecalcs": 9,
"styleRecalcDurationMs": 10.275,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 532.436,
"heapDeltaBytes": 1584024,
"heapUsedBytes": 70871632,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 11.290999999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1983.6779999999976,
"styleRecalcs": 78,
"styleRecalcDurationMs": 37.08599999999999,
"layouts": 14,
"layoutDurationMs": 4.783,
"taskDurationMs": 970.0039999999999,
"heapDeltaBytes": -263656,
"heapUsedBytes": 69937604,
"domNodes": -279,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 177.649,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1934.9349999999959,
"styleRecalcs": 79,
"styleRecalcDurationMs": 35.16,
"layouts": 14,
"layoutDurationMs": 4.38,
"taskDurationMs": 921.2550000000001,
"heapDeltaBytes": 9213732,
"heapUsedBytes": 79917292,
"domNodes": -279,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 170.715,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1740.555000000029,
"styleRecalcs": 31,
"styleRecalcDurationMs": 18.312,
"layouts": 6,
"layoutDurationMs": 1.287,
"taskDurationMs": 407.09900000000005,
"heapDeltaBytes": 4673800,
"heapUsedBytes": 75608564,
"domNodes": 76,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 13.953,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1733.3680000000413,
"styleRecalcs": 31,
"styleRecalcDurationMs": 16.657,
"layouts": 6,
"layoutDurationMs": 1.232,
"taskDurationMs": 365.473,
"heapDeltaBytes": 4566384,
"heapUsedBytes": 75218624,
"domNodes": 75,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 11.828999999999999,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 684.6110000000181,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.211,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 460.849,
"heapDeltaBytes": 18769068,
"heapUsedBytes": 88330300,
"domNodes": 18,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 163.23800000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 683.3689999999706,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.158,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 449.00700000000006,
"heapDeltaBytes": -7862408,
"heapUsedBytes": 62766316,
"domNodes": 18,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 162.14199999999997,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2073.464999999999,
"styleRecalcs": 6,
"styleRecalcDurationMs": 6.577999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 683.567,
"heapDeltaBytes": 4980164,
"heapUsedBytes": 81100160,
"domNodes": -281,
"jsHeapTotalBytes": -1155072,
"scriptDurationMs": 35.977,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2032.5209999999743,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.988,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 631.011,
"heapDeltaBytes": 4111052,
"heapUsedBytes": 79580300,
"domNodes": -282,
"jsHeapTotalBytes": -1679360,
"scriptDurationMs": 35.922,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2346.4480000000094,
"styleRecalcs": 66,
"styleRecalcDurationMs": 11.633000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1685.37,
"heapDeltaBytes": 19356424,
"heapUsedBytes": 85264472,
"domNodes": -269,
"jsHeapTotalBytes": 1798144,
"scriptDurationMs": 831.3689999999999,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2347.757999999999,
"styleRecalcs": 65,
"styleRecalcDurationMs": 10.552000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1697.864,
"heapDeltaBytes": 10964048,
"heapUsedBytes": 87911620,
"domNodes": -274,
"jsHeapTotalBytes": 380928,
"scriptDurationMs": 838.2460000000001,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3651.1319999999614,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.294,
"layouts": 60,
"layoutDurationMs": 12.461,
"taskDurationMs": 1762.922,
"heapDeltaBytes": 7768408,
"heapUsedBytes": 76032204,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 783.702,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3617.6229999999805,
"styleRecalcs": 62,
"styleRecalcDurationMs": 12.975,
"layouts": 60,
"layoutDurationMs": 12.087999999999997,
"taskDurationMs": 1791.009,
"heapDeltaBytes": -2999480,
"heapUsedBytes": 75201224,
"domNodes": -280,
"jsHeapTotalBytes": -1417216,
"scriptDurationMs": 781.732,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3180.4180000000315,
"styleRecalcs": 41,
"styleRecalcDurationMs": 6.211999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2028.435,
"heapDeltaBytes": 13253776,
"heapUsedBytes": 93639196,
"domNodes": -285,
"jsHeapTotalBytes": -999424,
"scriptDurationMs": 980.1899999999999,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666636,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3079.5460000000503,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.014000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1962.1430000000003,
"heapDeltaBytes": 21029048,
"heapUsedBytes": 89294916,
"domNodes": 0,
"jsHeapTotalBytes": 679936,
"scriptDurationMs": 987.6499999999999,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666636,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2057.755000000043,
"styleRecalcs": 4,
"styleRecalcDurationMs": 4.281,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 681.4299999999998,
"heapDeltaBytes": 6171332,
"heapUsedBytes": 82921376,
"domNodes": -285,
"jsHeapTotalBytes": -1155072,
"scriptDurationMs": 39.37499999999999,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2062.898999999902,
"styleRecalcs": 5,
"styleRecalcDurationMs": 5.342,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 661.338,
"heapDeltaBytes": 7900516,
"heapUsedBytes": 85675316,
"domNodes": -272,
"jsHeapTotalBytes": -1155072,
"scriptDurationMs": 36.056000000000004,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 640.2470000000449,
"styleRecalcs": 47,
"styleRecalcDurationMs": 12.506,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 435.52600000000007,
"heapDeltaBytes": 14088196,
"heapUsedBytes": 79664492,
"domNodes": 20,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 146.898,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 596.7249999999922,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.891,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 409.4049999999999,
"heapDeltaBytes": 15060584,
"heapUsedBytes": 88248744,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 142.955,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2022.8350000000432,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.03,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 538.6300000000001,
"heapDeltaBytes": -13344116,
"heapUsedBytes": 59629140,
"domNodes": -297,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 11.136,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2037.862999999959,
"styleRecalcs": 10,
"styleRecalcDurationMs": 14.084999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 530.9459999999999,
"heapDeltaBytes": 4541516,
"heapUsedBytes": 77667096,
"domNodes": -293,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 8.988,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1722.1250000000055,
"styleRecalcs": 78,
"styleRecalcDurationMs": 31.097999999999995,
"layouts": 18,
"layoutDurationMs": 5.535,
"taskDurationMs": 896.352,
"heapDeltaBytes": -9333608,
"heapUsedBytes": 62684932,
"domNodes": -295,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 121.49200000000002,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1740.171000000032,
"styleRecalcs": 79,
"styleRecalcDurationMs": 31.719000000000005,
"layouts": 18,
"layoutDurationMs": 5.859000000000001,
"taskDurationMs": 871.6700000000001,
"heapDeltaBytes": 11029100,
"heapUsedBytes": 83845896,
"domNodes": -294,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 115.04299999999999,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1417.6699999999869,
"styleRecalcs": 20,
"styleRecalcDurationMs": 34.37799999999999,
"layouts": 16,
"layoutDurationMs": 16.559,
"taskDurationMs": 1033.9740000000002,
"heapDeltaBytes": -5307872,
"heapUsedBytes": 85282496,
"domNodes": 13751,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 34.285,
"eventListeners": 2387,
"totalBlockingTimeMs": 159,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 9276.749999999993,
"styleRecalcs": 248,
"styleRecalcDurationMs": 46.083999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6284.965999999999,
"heapDeltaBytes": 15040648,
"heapUsedBytes": 90706260,
"domNodes": -270,
"jsHeapTotalBytes": 1658880,
"scriptDurationMs": 2842.84,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8539.401999999995,
"styleRecalcs": 249,
"styleRecalcDurationMs": 37.004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5985.77,
"heapDeltaBytes": -8378104,
"heapUsedBytes": 68111308,
"domNodes": -280,
"jsHeapTotalBytes": 679936,
"scriptDurationMs": 2752.3950000000004,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999952,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17914.981999999953,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17192.954999999998,
"heapDeltaBytes": -40155876,
"heapUsedBytes": 176523348,
"domNodes": -8068,
"jsHeapTotalBytes": -11546624,
"scriptDurationMs": 328.013,
"eventListeners": -14935,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17827.863999999976,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17102.645,
"heapDeltaBytes": -46235140,
"heapUsedBytes": 180281736,
"domNodes": -8068,
"jsHeapTotalBytes": -17502208,
"scriptDurationMs": 303.195,
"eventListeners": -14929,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.330000000000048,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 21997.259999999984,
"styleRecalcs": 173,
"styleRecalcDurationMs": 21.326999999999984,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21607.929,
"heapDeltaBytes": -41898316,
"heapUsedBytes": 189826144,
"domNodes": -8068,
"jsHeapTotalBytes": -18595840,
"scriptDurationMs": 971.8800000000001,
"eventListeners": -14927,
"totalBlockingTimeMs": 97,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 21917.53799999992,
"styleRecalcs": 170,
"styleRecalcDurationMs": 20.71400000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21622.170000000002,
"heapDeltaBytes": -15825292,
"heapUsedBytes": 192560644,
"domNodes": -8068,
"jsHeapTotalBytes": -15896576,
"scriptDurationMs": 949.373,
"eventListeners": -14925,
"totalBlockingTimeMs": 169,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 6369.304,
"styleRecalcs": 20,
"styleRecalcDurationMs": 85.07699999999996,
"layouts": 20,
"layoutDurationMs": 26.596000000000007,
"taskDurationMs": 6280.162999999999,
"heapDeltaBytes": -43833916,
"heapUsedBytes": 174670796,
"domNodes": -8068,
"jsHeapTotalBytes": 15409152,
"scriptDurationMs": 118.91499999999999,
"eventListeners": -14927,
"totalBlockingTimeMs": 485,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6431.771000000026,
"styleRecalcs": 20,
"styleRecalcDurationMs": 87.32699999999998,
"layouts": 20,
"layoutDurationMs": 25.913999999999994,
"taskDurationMs": 6305.307999999999,
"heapDeltaBytes": -27646168,
"heapUsedBytes": 197498764,
"domNodes": -8068,
"jsHeapTotalBytes": 13545472,
"scriptDurationMs": 117.03200000000001,
"eventListeners": -14929,
"totalBlockingTimeMs": 547,
"frameDurationMs": 18.329999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9050.530999999977,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8587.76,
"heapDeltaBytes": 1854272,
"heapUsedBytes": 179036928,
"domNodes": 0,
"jsHeapTotalBytes": -20971520,
"scriptDurationMs": 158.37199999999996,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9081.121000000054,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8641.374000000003,
"heapDeltaBytes": 19387312,
"heapUsedBytes": 178831572,
"domNodes": 0,
"jsHeapTotalBytes": -8388608,
"scriptDurationMs": 143.00800000000004,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 102.17099999999846,
"styleRecalcs": 7,
"styleRecalcDurationMs": 16.619999999999997,
"layouts": 2,
"layoutDurationMs": 0.782,
"taskDurationMs": 75.46900000000001,
"heapDeltaBytes": 3005236,
"heapUsedBytes": 70984488,
"domNodes": 106,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 5.376999999999998,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 459.24200000001747,
"styleRecalcs": 14,
"styleRecalcDurationMs": 19.146000000000004,
"layouts": 3,
"layoutDurationMs": 0.723,
"taskDurationMs": 101.114,
"heapDeltaBytes": 4755076,
"heapUsedBytes": 73034412,
"domNodes": 119,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 7.953999999999999,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.699999999999818
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cloud/1.54 #18423 +/- ##
=============================================
Coverage ? 83.62%
=============================================
Files ? 2097
Lines ? 124046
Branches ? 31404
=============================================
Hits ? 103730
Misses ? 20138
Partials ? 178
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
…during CRDT reconcile (#18536) Backports the [reported stale prompt reconciliation bug](https://linear.app/comfyorg/issue/PM-1524) fix to `core/1.54`. - Preserves fresher live widget values during CRDT catch-up. - Reuses the qualified `cloud/1.54` adaptation. - Local unit and type checks are green. <details><summary>Full context for agent readers</summary> Backport of [source PR 18361](#18361) via the target-adapted [Cloud carrier PR 18423](#18423). `core/1.54` contains the Agent panel and CRDT reconciliation path, and lacked this fix. The carrier preserves named and positional widget reconciliation, repeated stale replay handling, object-valued acknowledgements, explicit writes, deletions, structural replay, and graph-load success/failure cleanup. The only content difference from the merged Cloud carrier is the target branch's current import ordering in `graphMutations.test.ts`. Verification at head: - full unit suite: 21,375 passed, 7 expected failures, 7 skipped - focused affected suites: 235 passed, 1 expected failure, 1 skipped - `pnpm typecheck`: passed - oxfmt, type-aware Oxlint, and ESLint on changed files: no errors - `git diff --check`: passed This PR does not claim deployment or served-environment acceptance. </details> Co-authored-by: Amp <amp@ampcode.com>
…s multiple autogrow groups (#18512) <!-- ccr-slack-attribution --> _Requested by **Christian Byrne** · [Slack thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1790128455751879?thread_ts=1789965317.152049&cid=C0BGH348Z0C)_ ## Summary Manual backport of #18275 to `core/1.54`, following the same pattern proven for the `cloud/1.54` backport (#18479). **STACKED ON #18509 — do not merge this before #18509 merges.** This branch is based on `backport-17221-to-core-1.54` (#18509's head), not on `origin/core/1.54` directly, because `core/1.54` proper still resolves agent CRDT inputs positionally and lacks the name-based input-targeting architecture from #17221 that #18275 builds directly on top of (`mergeInputSlotsByName`/`hasNonGrowthInputSetChange` in `graphMutations.ts`). Once #18509 merges into `core/1.54`, this PR's base should be retargeted/rebased onto `core/1.54` before merging. ## Conflict resolution notes - `browser_tests/fixtures/agentConversationFixture.ts`: dropped. Doesn't exist on this branch (added by still-unbackported #17875); nothing here imports it, including the new `agentCrdtMultiAutogrowRealign.spec.ts` (only comment references, no real import). - `src/lib/litegraph/src/LGraphCanvas.ts` (`selectItems`): kept this branch's existing body. The only diff was an unrelated `Array.from` → spread refactor from #17048's `ownsSelectable` filter, which isn't on this branch (`ownsSelectable` doesn't exist anywhere in `src/`). - `src/core/graph/widgets/dynamicWidgets.ts`, `AgentPanelRoot.vue`: additive conflicts, took the incoming side. Dropped an incoming `useSettingStore` import in `AgentPanelRoot.vue` (belongs to unbackported #17730, unused here). - `src/workbench/extensions/agent/crdt/graphMutations.ts`: took the new by-name `connect`/`commitUpsertNode` handlers wholesale (the actual fix). Uncovered missing dependency: `linkPresentationStore` (from unbackported #17875). Ported `src/types/linkPresentation.ts` and `src/stores/linkPresentationStore.ts` (+ unit test) from `main`, and wired `const linkPresentationStore = useLinkPresentationStore()`. - `graphMutations.test.ts`: same missing-dependency shape; `useLinkPresentationStore` import ended up unused in the test file, removed it. ## Additional gaps beyond the cloud/1.54 backport's notes (found and verified, not just copied) - `browser_tests/fixtures/agentFollowerHostSocket.ts` was missing (needed by the new `MultiAutogrowRealignHarness.ts`). Ported verbatim from `main`, which required exporting `DOC_PROTOCOL_VERSION` from `docFrameClient.ts` (it was a local `const`). - `commitUpsertNode`'s call to `applyWidgetValues` used a 5th `guardLocalEdits` argument that only exists on `main` via unbackported PR #18361 (the "local-edit guard" feature, already on `cloud/1.54` via #18423 but not on `core/1.54`). Dropped the extra argument to match this branch's existing 4-parameter `applyWidgetValues` — this guard is unrelated to #18275's actual fix (named-link realignment), so dropping it doesn't affect this PR's mechanism; it just means core/1.54 doesn't yet get #18361's separate improvement. - `zAutogrowOptions` import in `graphMutations.ts`: verified this already resolves fine — `@/schemas/nodeDefSchema` re-exports `@comfyorg/object-info-parser`, which already defines it. Not a gap. - `zComfyApiWorkflow` in `workflowSchema.ts` (used by the new `MultiAutogrowRealignHarness.ts`): wasn't exported on this branch (only `ComfyApiWorkflow` the type was). Exported it, matching how `main` already exports it. - `MultiAutogrowRealignHarness.ts` / `savedWorkflowPersistence.ts` imported `PromptResponse`/`UserDataFullInfo` from `@/platform/remote/comfyui/types`, a module that doesn't exist on this older branch. Both types live in `@/schemas/apiSchema` here; fixed the import paths. - `reconcileAutogrowInputs` (new additive export in `dynamicWidgets.ts`) has no caller on this branch — its only call site on `main` is in `agentNodeMaterializer.ts`, added by a separate, unbackported PR (not #18275's own diff, and not #17221's either). Dropped it as dead code rather than smuggling in that unrelated PR's wiring. ## Verification - `pnpm typecheck` — clean - `pnpm exec eslint` on all changed files — clean - `pnpm exec oxfmt --check` on all changed files — clean, all correctly formatted - `pnpm knip` — clean - `pnpm vitest run` on `graphMutations.test.ts`, `dynamicWidgets.test.ts`, `linkStore.test.ts`, `nodeDataStore.test.ts`, `linkPresentationStore.test.ts`, `crdtSession.test.ts`, `agentNodeMaterializer.multiAutogrow.test.ts` — 7 files, 198 passed / 1 expected fail - `pnpm exec playwright test --list` — collects cleanly, no `@e2e/fixtures` resolution errors (2237 tests / 367 files total, including the 2 new specs in `agentCrdtMultiAutogrowRealign.spec.ts`) --------- Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XqLXka9Jsg8EMTYmsnZjjv 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01XqLXka9Jsg8EMTYmsnZjjv --- _Generated by [Claude Code](https://claude.ai/code/session_01XqLXka9Jsg8EMTYmsnZjjv)_ --------- Co-authored-by: Ryan Di <ryan.weihao.di@gmail.com> Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> Co-authored-by: bymyself <cbyrne@comfy.org> Co-authored-by: Amp <amp@ampcode.com> Co-authored-by: Claude <noreply@anthropic.com>
Backport of source PR 18361 to
cloud/1.54.Summary
Preserves a fresher live widget value when a stale CRDT catch-up reconcile arrives, and reliably closes local-dirty suppression after graph-load success or failure.
Cloud adaptation
onGraphLoadErrorand resolvefalse.clean !== falsebehavior, asset resets, validation, reroute migration, subgraph loading, node replacement, missing-node collection, graph configuration, scaling, and final navigation-hash repair.AgentCrdtProjectionandFollowerDocharness does not exist oncloud/1.54; the backported direct named and positional mutation regressions exercise the same stale-value guard on this target.Verification
cloud/1.54target at publication time.This carrier does not claim deployment, runtime acceptance, or restored authenticated reload acceptance.