Skip to content

[backport cloud/1.54] fix(agent): preserve fresher live widget values during CRDT reconcile - #18423

Merged
christian-byrne merged 1 commit into
cloud/1.54from
backport-18361-to-cloud-1.54
Sep 22, 2026
Merged

christian-byrne merged 1 commit into
cloud/1.54from
backport-18361-to-cloud-1.54

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

Backport of source PR 18361 to cloud/1.54.

Summary

Preserves a fresher live widget value when a stale CRDT catch-up reconcile arrives, and reliably closes local-dirty suppression after graph-load success or failure.

Cloud adaptation

  • Applies local-dirty tracking to the release branch's separate widget-state and widget-render-state maps.
  • Preserves named, positional, repeated-stale-reconcile, object-value, explicit-write, deletion, and structural-replay regressions.
  • Wraps the release branch's full target-native pre-configure lifecycle so validation, extension, replacement-load, and related failures notify onGraphLoadError and resolve false.
  • Preserves the release branch's clean !== false behavior, asset resets, validation, reroute migration, subgraph loading, node replacement, missing-node collection, graph configuration, scaling, and final navigation-hash repair.
  • Omits the source branch's pre-existing Yjs projection integration test because its AgentCrdtProjection and FollowerDoc harness does not exist on cloud/1.54; the backported direct named and positional mutation regressions exercise the same stale-value guard on this target.

Verification

  • Full unit suite: 21,421 passed, 6 expected failures, 7 skipped across 1,552 files.
  • Focused affected suites: 234 passed, 1 expected failure, 1 skipped.
  • Typecheck passed.
  • Normal commit hooks passed formatting, type-aware Oxlint, ESLint, and typecheck.
  • Normal pre-push Knip passed.
  • Working tree is clean, and the commit's parent is the current cloud/1.54 target at publication time.

This carrier does not claim deployment, runtime acceptance, or restored authenticated reload acceptance.

…lue (#18361)

Adapt the merged source fix to cloud/1.54's split widget-state stores and target-native load lifecycle. Preserve the named and positional reconcile regressions, local-dirty suppression, overlapping-load cleanup, and pre-configure failure handling.

(cherry picked from commit 944f8cd)
@christian-byrne christian-byrne added backport Backporting a PR onto a release candidate risk:xhigh PR risk grade (advisory shadow check; grader-owned) labels Sep 22, 2026
@coderabbitai

coderabbitai Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: 56518e4d-349a-4981-b401-2dcf65a86c27

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@vercel

vercel Bot commented Sep 22, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
billing-web Ignored Ignored Sep 22, 2026 11:20am UTC

Request Review

@github-actions

github-actions Bot commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 1937 passed, 0 failed

📊 Browser Reports
  • chromium: View Report (✅ 1916 / ❌ 0 / ⚠️ 0 / ⏭️ 13)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/22/2026, 11:22:12 AM UTC

Links

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 60.7 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.5 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.9 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.0 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 76.6 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.6 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.1 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 87.2 MB heap
minimap-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 80.4 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 80.1 MB heap
subgraph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.5 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.9 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 159ms TBT · 81.3 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 75.7 MB heap
vue-large-graph-idle: · 55.4 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 170.1 MB heap
vue-large-graph-pan: · 56.3 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 133ms TBT · 182.3 MB heap
vue-node-resize-workload: · 55.4 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 516ms TBT · 177.5 MB heap
vue-zoom-out-idle: · 56.2 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 170.6 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.7 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 10ms
canvas-idle: layout count 0
canvas-idle: style recalc count 9
canvas-idle: task duration 557ms
canvas-idle: script duration 11ms
canvas-idle: TBT 0ms
canvas-idle: heap used 60.7 MB
canvas-idle: DOM nodes 17
canvas-idle: event listeners 6
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 5ms
canvas-mouse-sweep: style recalc duration 36ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 79
canvas-mouse-sweep: task duration 946ms
canvas-mouse-sweep: script duration 174ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 71.5 MB
canvas-mouse-sweep: DOM nodes -279
canvas-mouse-sweep: event listeners -181
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 17ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 31
canvas-zoom-sweep: task duration 386ms
canvas-zoom-sweep: script duration 13ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 71.9 MB
canvas-zoom-sweep: DOM nodes 76
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 8ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 11
dom-widget-clipping: task duration 455ms
dom-widget-clipping: script duration 163ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 72.0 MB
dom-widget-clipping: DOM nodes 18
dom-widget-clipping: event listeners 1
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 6ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 6
large-graph-idle: task duration 657ms
large-graph-idle: script duration 36ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 76.6 MB
large-graph-idle: DOM nodes -282
large-graph-idle: event listeners -192
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 11ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 66
large-graph-pan: task duration 1692ms
large-graph-pan: script duration 835ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 82.6 MB
large-graph-pan: DOM nodes -272
large-graph-pan: event listeners -177
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 12ms
large-graph-zoom: style recalc duration 12ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 61
large-graph-zoom: task duration 1777ms
large-graph-zoom: script duration 783ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 72.1 MB
large-graph-zoom: DOM nodes -140
large-graph-zoom: event listeners -89
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 6ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 41
legacy-node-drag: task duration 1995ms
legacy-node-drag: script duration 984ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 87.2 MB
legacy-node-drag: DOM nodes -143
legacy-node-drag: event listeners 89
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 5ms
minimap-idle: layout count 0
minimap-idle: style recalc count 5
minimap-idle: task duration 671ms
minimap-idle: script duration 38ms
minimap-idle: TBT 0ms
minimap-idle: heap used 80.4 MB
minimap-idle: DOM nodes -279
minimap-idle: event listeners -192
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 12ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 47
subgraph-dom-widget-clipping: task duration 422ms
subgraph-dom-widget-clipping: script duration 145ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 80.1 MB
subgraph-dom-widget-clipping: DOM nodes 19
subgraph-dom-widget-clipping: event listeners 7
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 12ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 10
subgraph-idle: task duration 535ms
subgraph-idle: script duration 10ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 65.5 MB
subgraph-idle: DOM nodes -295
subgraph-idle: event listeners -210
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 6ms
subgraph-mouse-sweep: style recalc duration 31ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 79
subgraph-mouse-sweep: task duration 884ms
subgraph-mouse-sweep: script duration 118ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 69.9 MB
subgraph-mouse-sweep: DOM nodes -295
subgraph-mouse-sweep: event listeners -226
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 17ms
subgraph-transition-enter: style recalc duration 34ms
subgraph-transition-enter: layout count 16
subgraph-transition-enter: style recalc count 20
subgraph-transition-enter: task duration 1034ms
subgraph-transition-enter: script duration 34ms
subgraph-transition-enter: TBT 159ms
subgraph-transition-enter: heap used 81.3 MB
subgraph-transition-enter: DOM nodes 13751
subgraph-transition-enter: event listeners 2387
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 42ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 249
viewport-pan-sweep: task duration 6135ms
viewport-pan-sweep: script duration 2798ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 75.7 MB
viewport-pan-sweep: DOM nodes -275
viewport-pan-sweep: event listeners -160
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 17148ms
vue-large-graph-idle: script duration 316ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 170.1 MB
vue-large-graph-idle: DOM nodes -8068
vue-large-graph-idle: event listeners -14932
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 21ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 172
vue-large-graph-pan: task duration 21615ms
vue-large-graph-pan: script duration 961ms
vue-large-graph-pan: TBT 133ms
vue-large-graph-pan: heap used 182.3 MB
vue-large-graph-pan: DOM nodes -8068
vue-large-graph-pan: event listeners -14926
vue-node-resize-workload: avg frame time 18ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 26ms
vue-node-resize-workload: style recalc duration 86ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 6293ms
vue-node-resize-workload: script duration 118ms
vue-node-resize-workload: TBT 516ms
vue-node-resize-workload: heap used 177.5 MB
vue-node-resize-workload: DOM nodes -8068
vue-node-resize-workload: event listeners -14928
vue-zoom-out-idle: avg frame time 18ms
vue-zoom-out-idle: p95 frame time 17ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 8615ms
vue-zoom-out-idle: script duration 151ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 170.6 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners -12
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 18ms
workflow-execution: layout count 3
workflow-execution: style recalc count 11
workflow-execution: task duration 88ms
workflow-execution: script duration 7ms
workflow-execution: TBT 0ms
workflow-execution: heap used 68.7 MB
workflow-execution: DOM nodes 113
workflow-execution: event listeners 50
Raw data
{
  "timestamp": "2026-09-22T11:31:42.746Z",
  "gitSha": "77af579b98e63e5eb590a7ca1f14e7d6da814fb0",
  "branch": "backport-18361-to-cloud-1.54",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2042.9399999999873,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 8.915999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 581.955,
      "heapDeltaBytes": -12640444,
      "heapUsedBytes": 56387488,
      "domNodes": 16,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 10.269,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2013.3280000000013,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 10.275,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 532.436,
      "heapDeltaBytes": 1584024,
      "heapUsedBytes": 70871632,
      "domNodes": 18,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 11.290999999999999,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1983.6779999999976,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 37.08599999999999,
      "layouts": 14,
      "layoutDurationMs": 4.783,
      "taskDurationMs": 970.0039999999999,
      "heapDeltaBytes": -263656,
      "heapUsedBytes": 69937604,
      "domNodes": -279,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 177.649,
      "eventListeners": -198,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1934.9349999999959,
      "styleRecalcs": 79,
      "styleRecalcDurationMs": 35.16,
      "layouts": 14,
      "layoutDurationMs": 4.38,
      "taskDurationMs": 921.2550000000001,
      "heapDeltaBytes": 9213732,
      "heapUsedBytes": 79917292,
      "domNodes": -279,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 170.715,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1740.555000000029,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 18.312,
      "layouts": 6,
      "layoutDurationMs": 1.287,
      "taskDurationMs": 407.09900000000005,
      "heapDeltaBytes": 4673800,
      "heapUsedBytes": 75608564,
      "domNodes": 76,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 13.953,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1733.3680000000413,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 16.657,
      "layouts": 6,
      "layoutDurationMs": 1.232,
      "taskDurationMs": 365.473,
      "heapDeltaBytes": 4566384,
      "heapUsedBytes": 75218624,
      "domNodes": 75,
      "jsHeapTotalBytes": 6029312,
      "scriptDurationMs": 11.828999999999999,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 684.6110000000181,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 8.211,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 460.849,
      "heapDeltaBytes": 18769068,
      "heapUsedBytes": 88330300,
      "domNodes": 18,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 163.23800000000003,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 683.3689999999706,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 8.158,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 449.00700000000006,
      "heapDeltaBytes": -7862408,
      "heapUsedBytes": 62766316,
      "domNodes": 18,
      "jsHeapTotalBytes": 7340032,
      "scriptDurationMs": 162.14199999999997,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2073.464999999999,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 6.577999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 683.567,
      "heapDeltaBytes": 4980164,
      "heapUsedBytes": 81100160,
      "domNodes": -281,
      "jsHeapTotalBytes": -1155072,
      "scriptDurationMs": 35.977,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2032.5209999999743,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 5.988,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 631.011,
      "heapDeltaBytes": 4111052,
      "heapUsedBytes": 79580300,
      "domNodes": -282,
      "jsHeapTotalBytes": -1679360,
      "scriptDurationMs": 35.922,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2346.4480000000094,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 11.633000000000004,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1685.37,
      "heapDeltaBytes": 19356424,
      "heapUsedBytes": 85264472,
      "domNodes": -269,
      "jsHeapTotalBytes": 1798144,
      "scriptDurationMs": 831.3689999999999,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2347.757999999999,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 10.552000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1697.864,
      "heapDeltaBytes": 10964048,
      "heapUsedBytes": 87911620,
      "domNodes": -274,
      "jsHeapTotalBytes": 380928,
      "scriptDurationMs": 838.2460000000001,
      "eventListeners": -162,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3651.1319999999614,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 10.294,
      "layouts": 60,
      "layoutDurationMs": 12.461,
      "taskDurationMs": 1762.922,
      "heapDeltaBytes": 7768408,
      "heapUsedBytes": 76032204,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 783.702,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3617.6229999999805,
      "styleRecalcs": 62,
      "styleRecalcDurationMs": 12.975,
      "layouts": 60,
      "layoutDurationMs": 12.087999999999997,
      "taskDurationMs": 1791.009,
      "heapDeltaBytes": -2999480,
      "heapUsedBytes": 75201224,
      "domNodes": -280,
      "jsHeapTotalBytes": -1417216,
      "scriptDurationMs": 781.732,
      "eventListeners": -188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333338,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3180.4180000000315,
      "styleRecalcs": 41,
      "styleRecalcDurationMs": 6.211999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 2028.435,
      "heapDeltaBytes": 13253776,
      "heapUsedBytes": 93639196,
      "domNodes": -285,
      "jsHeapTotalBytes": -999424,
      "scriptDurationMs": 980.1899999999999,
      "eventListeners": -10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666636,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3079.5460000000503,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 5.014000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1962.1430000000003,
      "heapDeltaBytes": 21029048,
      "heapUsedBytes": 89294916,
      "domNodes": 0,
      "jsHeapTotalBytes": 679936,
      "scriptDurationMs": 987.6499999999999,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666636,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2057.755000000043,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 4.281,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 681.4299999999998,
      "heapDeltaBytes": 6171332,
      "heapUsedBytes": 82921376,
      "domNodes": -285,
      "jsHeapTotalBytes": -1155072,
      "scriptDurationMs": 39.37499999999999,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "minimap-idle",
      "durationMs": 2062.898999999902,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 5.342,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 661.338,
      "heapDeltaBytes": 7900516,
      "heapUsedBytes": 85675316,
      "domNodes": -272,
      "jsHeapTotalBytes": -1155072,
      "scriptDurationMs": 36.056000000000004,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 640.2470000000449,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 12.506,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 435.52600000000007,
      "heapDeltaBytes": 14088196,
      "heapUsedBytes": 79664492,
      "domNodes": 20,
      "jsHeapTotalBytes": 6029312,
      "scriptDurationMs": 146.898,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 596.7249999999922,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 10.891,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 409.4049999999999,
      "heapDeltaBytes": 15060584,
      "heapUsedBytes": 88248744,
      "domNodes": 18,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 142.955,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2022.8350000000432,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 9.03,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 538.6300000000001,
      "heapDeltaBytes": -13344116,
      "heapUsedBytes": 59629140,
      "domNodes": -297,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 11.136,
      "eventListeners": -210,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2037.862999999959,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 14.084999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 530.9459999999999,
      "heapDeltaBytes": 4541516,
      "heapUsedBytes": 77667096,
      "domNodes": -293,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 8.988,
      "eventListeners": -210,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1722.1250000000055,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 31.097999999999995,
      "layouts": 18,
      "layoutDurationMs": 5.535,
      "taskDurationMs": 896.352,
      "heapDeltaBytes": -9333608,
      "heapUsedBytes": 62684932,
      "domNodes": -295,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 121.49200000000002,
      "eventListeners": -242,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1740.171000000032,
      "styleRecalcs": 79,
      "styleRecalcDurationMs": 31.719000000000005,
      "layouts": 18,
      "layoutDurationMs": 5.859000000000001,
      "taskDurationMs": 871.6700000000001,
      "heapDeltaBytes": 11029100,
      "heapUsedBytes": 83845896,
      "domNodes": -294,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 115.04299999999999,
      "eventListeners": -210,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1417.6699999999869,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 34.37799999999999,
      "layouts": 16,
      "layoutDurationMs": 16.559,
      "taskDurationMs": 1033.9740000000002,
      "heapDeltaBytes": -5307872,
      "heapUsedBytes": 85282496,
      "domNodes": 13751,
      "jsHeapTotalBytes": 10485760,
      "scriptDurationMs": 34.285,
      "eventListeners": 2387,
      "totalBlockingTimeMs": 159,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 9276.749999999993,
      "styleRecalcs": 248,
      "styleRecalcDurationMs": 46.083999999999996,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6284.965999999999,
      "heapDeltaBytes": 15040648,
      "heapUsedBytes": 90706260,
      "domNodes": -270,
      "jsHeapTotalBytes": 1658880,
      "scriptDurationMs": 2842.84,
      "eventListeners": -144,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8539.401999999995,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 37.004,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5985.77,
      "heapDeltaBytes": -8378104,
      "heapUsedBytes": 68111308,
      "domNodes": -280,
      "jsHeapTotalBytes": 679936,
      "scriptDurationMs": 2752.3950000000004,
      "eventListeners": -176,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.669999999999952,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17914.981999999953,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17192.954999999998,
      "heapDeltaBytes": -40155876,
      "heapUsedBytes": 176523348,
      "domNodes": -8068,
      "jsHeapTotalBytes": -11546624,
      "scriptDurationMs": 328.013,
      "eventListeners": -14935,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17827.863999999976,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17102.645,
      "heapDeltaBytes": -46235140,
      "heapUsedBytes": 180281736,
      "domNodes": -8068,
      "jsHeapTotalBytes": -17502208,
      "scriptDurationMs": 303.195,
      "eventListeners": -14929,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 18.330000000000048,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21997.259999999984,
      "styleRecalcs": 173,
      "styleRecalcDurationMs": 21.326999999999984,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 21607.929,
      "heapDeltaBytes": -41898316,
      "heapUsedBytes": 189826144,
      "domNodes": -8068,
      "jsHeapTotalBytes": -18595840,
      "scriptDurationMs": 971.8800000000001,
      "eventListeners": -14927,
      "totalBlockingTimeMs": 97,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21917.53799999992,
      "styleRecalcs": 170,
      "styleRecalcDurationMs": 20.71400000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 21622.170000000002,
      "heapDeltaBytes": -15825292,
      "heapUsedBytes": 192560644,
      "domNodes": -8068,
      "jsHeapTotalBytes": -15896576,
      "scriptDurationMs": 949.373,
      "eventListeners": -14925,
      "totalBlockingTimeMs": 169,
      "frameDurationMs": 17.776666666666763,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6369.304,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 85.07699999999996,
      "layouts": 20,
      "layoutDurationMs": 26.596000000000007,
      "taskDurationMs": 6280.162999999999,
      "heapDeltaBytes": -43833916,
      "heapUsedBytes": 174670796,
      "domNodes": -8068,
      "jsHeapTotalBytes": 15409152,
      "scriptDurationMs": 118.91499999999999,
      "eventListeners": -14927,
      "totalBlockingTimeMs": 485,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6431.771000000026,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 87.32699999999998,
      "layouts": 20,
      "layoutDurationMs": 25.913999999999994,
      "taskDurationMs": 6305.307999999999,
      "heapDeltaBytes": -27646168,
      "heapUsedBytes": 197498764,
      "domNodes": -8068,
      "jsHeapTotalBytes": 13545472,
      "scriptDurationMs": 117.03200000000001,
      "eventListeners": -14929,
      "totalBlockingTimeMs": 547,
      "frameDurationMs": 18.329999999999927,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 9050.530999999977,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8587.76,
      "heapDeltaBytes": 1854272,
      "heapUsedBytes": 179036928,
      "domNodes": 0,
      "jsHeapTotalBytes": -20971520,
      "scriptDurationMs": 158.37199999999996,
      "eventListeners": -12,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 9081.121000000054,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8641.374000000003,
      "heapDeltaBytes": 19387312,
      "heapUsedBytes": 178831572,
      "domNodes": 0,
      "jsHeapTotalBytes": -8388608,
      "scriptDurationMs": 143.00800000000004,
      "eventListeners": -12,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.779999999999927,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 102.17099999999846,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 16.619999999999997,
      "layouts": 2,
      "layoutDurationMs": 0.782,
      "taskDurationMs": 75.46900000000001,
      "heapDeltaBytes": 3005236,
      "heapUsedBytes": 70984488,
      "domNodes": 106,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 5.376999999999998,
      "eventListeners": 33,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 459.24200000001747,
      "styleRecalcs": 14,
      "styleRecalcDurationMs": 19.146000000000004,
      "layouts": 3,
      "layoutDurationMs": 0.723,
      "taskDurationMs": 101.114,
      "heapDeltaBytes": 4755076,
      "heapUsedBytes": 73034412,
      "domNodes": 119,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 7.953999999999999,
      "eventListeners": 67,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.699999999999818
    }
  ]
}

🔬 E2E Coverage

Metric Covered Total Pct
Lines 50294 75446 66.7% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.5% 1156
src/LGraphNode.ts 69.5% 390
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/platform/workspace/stores/billingOperationStore.ts 7.9% 313
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/LGraph.ts 78.3% 264
src/platform/workspace/stores/teamWorkspaceStore.ts 37.7% 261
src/scripts/app.ts 71.4% 260
src/scripts/pnginfo.ts 21.4% 221

@codecov

codecov Bot commented Sep 22, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.47619% with 14 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/scripts/app.ts 82.19% 13 Missing ⚠️
src/stores/widgetValueStore.ts 95.23% 1 Missing ⚠️
@@              Coverage Diff              @@
##             cloud/1.54   #18423   +/-   ##
=============================================
  Coverage              ?   83.62%           
=============================================
  Files                 ?     2097           
  Lines                 ?   124046           
  Branches              ?    31404           
=============================================
  Hits                  ?   103730           
  Misses                ?    20138           
  Partials              ?      178           
Flag Coverage Δ
e2e 66.67% <75.34%> (?)
unit 78.59% <79.45%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/extensions/core/agentPanel.ts 100.00% <100.00%> (ø)
...nch/extensions/agent/crdt/agentNodeMaterializer.ts 99.25% <100.00%> (ø)
.../workbench/extensions/agent/crdt/graphMutations.ts 95.42% <100.00%> (ø)
src/stores/widgetValueStore.ts 95.37% <95.23%> (ø)
src/scripts/app.ts 78.26% <82.19%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@christian-byrne
christian-byrne merged commit 163773d into cloud/1.54 Sep 22, 2026
112 of 114 checks passed
@christian-byrne
christian-byrne deleted the backport-18361-to-cloud-1.54 branch September 22, 2026 20:15
christian-byrne added a commit that referenced this pull request Sep 23, 2026
…during CRDT reconcile (#18536)

Backports the [reported stale prompt reconciliation
bug](https://linear.app/comfyorg/issue/PM-1524) fix to `core/1.54`.

- Preserves fresher live widget values during CRDT catch-up.
- Reuses the qualified `cloud/1.54` adaptation.
- Local unit and type checks are green.

<details><summary>Full context for agent readers</summary>

Backport of [source PR
18361](#18361) via the
target-adapted [Cloud carrier PR
18423](#18423).
`core/1.54` contains the Agent panel and CRDT reconciliation path, and
lacked this fix.

The carrier preserves named and positional widget reconciliation,
repeated stale replay handling, object-valued acknowledgements, explicit
writes, deletions, structural replay, and graph-load success/failure
cleanup. The only content difference from the merged Cloud carrier is
the target branch's current import ordering in `graphMutations.test.ts`.

Verification at head:
- full unit suite: 21,375 passed, 7 expected failures, 7 skipped
- focused affected suites: 235 passed, 1 expected failure, 1 skipped
- `pnpm typecheck`: passed
- oxfmt, type-aware Oxlint, and ESLint on changed files: no errors
- `git diff --check`: passed

This PR does not claim deployment or served-environment acceptance.

</details>

Co-authored-by: Amp <amp@ampcode.com>
@DrJKL DrJKL added agent Comfy Agent product, integration, tests or product documentation agent-backport Agent changes targeting a stable cloud/core release branch agent-crdt Agent document synchronization, graph projection or CRDT operations agent-test-unit Touches Agent-related unit/component tests or their support agent-ui Agent panel, composer, transcript or other user-interface components labels Sep 24, 2026
christian-byrne added a commit that referenced this pull request Sep 25, 2026
…s multiple autogrow groups (#18512)

&lt;!-- ccr-slack-attribution --&gt;
_Requested by **Christian Byrne** · [Slack
thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1790128455751879?thread_ts=1789965317.152049&cid=C0BGH348Z0C)_

## Summary

Manual backport of #18275 to `core/1.54`, following the same pattern
proven for the `cloud/1.54` backport (#18479).

**STACKED ON #18509 — do not merge this before #18509 merges.** This
branch is based on `backport-17221-to-core-1.54` (#18509's head), not on
`origin/core/1.54` directly, because `core/1.54` proper still resolves
agent CRDT inputs positionally and lacks the name-based input-targeting
architecture from #17221 that #18275 builds directly on top of
(`mergeInputSlotsByName`/`hasNonGrowthInputSetChange` in
`graphMutations.ts`). Once #18509 merges into `core/1.54`, this PR's
base should be retargeted/rebased onto `core/1.54` before merging.

## Conflict resolution notes

- `browser_tests/fixtures/agentConversationFixture.ts`: dropped. Doesn't
exist on this branch (added by still-unbackported #17875); nothing here
imports it, including the new `agentCrdtMultiAutogrowRealign.spec.ts`
(only comment references, no real import).
- `src/lib/litegraph/src/LGraphCanvas.ts` (`selectItems`): kept this
branch's existing body. The only diff was an unrelated `Array.from` →
spread refactor from #17048's `ownsSelectable` filter, which isn't on
this branch (`ownsSelectable` doesn't exist anywhere in `src/`).
- `src/core/graph/widgets/dynamicWidgets.ts`, `AgentPanelRoot.vue`:
additive conflicts, took the incoming side. Dropped an incoming
`useSettingStore` import in `AgentPanelRoot.vue` (belongs to
unbackported #17730, unused here).
- `src/workbench/extensions/agent/crdt/graphMutations.ts`: took the new
by-name `connect`/`commitUpsertNode` handlers wholesale (the actual
fix). Uncovered missing dependency: `linkPresentationStore` (from
unbackported #17875). Ported `src/types/linkPresentation.ts` and
`src/stores/linkPresentationStore.ts` (+ unit test) from `main`, and
wired `const linkPresentationStore = useLinkPresentationStore()`.
- `graphMutations.test.ts`: same missing-dependency shape;
`useLinkPresentationStore` import ended up unused in the test file,
removed it.

## Additional gaps beyond the cloud/1.54 backport's notes (found and
verified, not just copied)

- `browser_tests/fixtures/agentFollowerHostSocket.ts` was missing
(needed by the new `MultiAutogrowRealignHarness.ts`). Ported verbatim
from `main`, which required exporting `DOC_PROTOCOL_VERSION` from
`docFrameClient.ts` (it was a local `const`).
- `commitUpsertNode`'s call to `applyWidgetValues` used a 5th
`guardLocalEdits` argument that only exists on `main` via unbackported
PR #18361 (the "local-edit guard" feature, already on `cloud/1.54` via
#18423 but not on `core/1.54`). Dropped the extra argument to match this
branch's existing 4-parameter `applyWidgetValues` — this guard is
unrelated to #18275's actual fix (named-link realignment), so dropping
it doesn't affect this PR's mechanism; it just means core/1.54 doesn't
yet get #18361's separate improvement.
- `zAutogrowOptions` import in `graphMutations.ts`: verified this
already resolves fine — `@/schemas/nodeDefSchema` re-exports
`@comfyorg/object-info-parser`, which already defines it. Not a gap.
- `zComfyApiWorkflow` in `workflowSchema.ts` (used by the new
`MultiAutogrowRealignHarness.ts`): wasn't exported on this branch (only
`ComfyApiWorkflow` the type was). Exported it, matching how `main`
already exports it.
- `MultiAutogrowRealignHarness.ts` / `savedWorkflowPersistence.ts`
imported `PromptResponse`/`UserDataFullInfo` from
`@/platform/remote/comfyui/types`, a module that doesn't exist on this
older branch. Both types live in `@/schemas/apiSchema` here; fixed the
import paths.
- `reconcileAutogrowInputs` (new additive export in `dynamicWidgets.ts`)
has no caller on this branch — its only call site on `main` is in
`agentNodeMaterializer.ts`, added by a separate, unbackported PR (not
#18275's own diff, and not #17221's either). Dropped it as dead code
rather than smuggling in that unrelated PR's wiring.

## Verification

- `pnpm typecheck` — clean
- `pnpm exec eslint` on all changed files — clean
- `pnpm exec oxfmt --check` on all changed files — clean, all correctly
formatted
- `pnpm knip` — clean
- `pnpm vitest run` on `graphMutations.test.ts`,
`dynamicWidgets.test.ts`, `linkStore.test.ts`, `nodeDataStore.test.ts`,
`linkPresentationStore.test.ts`, `crdtSession.test.ts`,
`agentNodeMaterializer.multiAutogrow.test.ts` — 7 files, 198 passed / 1
expected fail
- `pnpm exec playwright test --list` — collects cleanly, no
`@e2e/fixtures` resolution errors (2237 tests / 367 files total,
including the 2 new specs in `agentCrdtMultiAutogrowRealign.spec.ts`)

---------

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XqLXka9Jsg8EMTYmsnZjjv

🤖 Generated with [Claude Code](https://claude.com/claude-code)

https://claude.ai/code/session_01XqLXka9Jsg8EMTYmsnZjjv

---
_Generated by [Claude
Code](https://claude.ai/code/session_01XqLXka9Jsg8EMTYmsnZjjv)_

---------

Co-authored-by: Ryan Di <ryan.weihao.di@gmail.com>
Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
Co-authored-by: bymyself <cbyrne@comfy.org>
Co-authored-by: Amp <amp@ampcode.com>
Co-authored-by: Claude <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent Comfy Agent product, integration, tests or product documentation agent-backport Agent changes targeting a stable cloud/core release branch agent-crdt Agent document synchronization, graph projection or CRDT operations agent-test-unit Touches Agent-related unit/component tests or their support agent-ui Agent panel, composer, transcript or other user-interface components backport Backporting a PR onto a release candidate risk:xhigh PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants