Repository navigation
[backport core/1.54] fix: avoid TDZ crash restoring saved multiline widget value - #18354
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1933 passed, 0 failed · 1 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-22T04:55:04.831Z",
"gitSha": "766de4d396ab676a9d359c07be31b4fd515b9700",
"branch": "backport-18324-to-core-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2044.100999999955,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.086999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 592.9610000000001,
"heapDeltaBytes": 4615528,
"heapUsedBytes": 74757040,
"domNodes": -282,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 12.560999999999996,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2104.966999999988,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.278,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 584.6569999999999,
"heapDeltaBytes": 3812596,
"heapUsedBytes": 74937596,
"domNodes": -282,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 12.888999999999998,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2180.201000000011,
"styleRecalcs": 79,
"styleRecalcDurationMs": 38.756,
"layouts": 14,
"layoutDurationMs": 4.863,
"taskDurationMs": 1095.4419999999998,
"heapDeltaBytes": -7312324,
"heapUsedBytes": 62044892,
"domNodes": -279,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 189.483,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1857.8069999999798,
"styleRecalcs": 75,
"styleRecalcDurationMs": 31.138000000000005,
"layouts": 14,
"layoutDurationMs": 4.407,
"taskDurationMs": 958.963,
"heapDeltaBytes": -4940868,
"heapUsedBytes": 66088272,
"domNodes": -281,
"jsHeapTotalBytes": 7593984,
"scriptDurationMs": 170.28900000000002,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1686.5320000000565,
"styleRecalcs": 32,
"styleRecalcDurationMs": 17.840000000000003,
"layouts": 6,
"layoutDurationMs": 1.1629999999999998,
"taskDurationMs": 434.58200000000005,
"heapDeltaBytes": 4306440,
"heapUsedBytes": 74181840,
"domNodes": 77,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 16.116000000000003,
"eventListeners": 21,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1683.6329999999862,
"styleRecalcs": 29,
"styleRecalcDurationMs": 18.593,
"layouts": 6,
"layoutDurationMs": 1.2619999999999998,
"taskDurationMs": 449.58000000000004,
"heapDeltaBytes": 4393780,
"heapUsedBytes": 74819796,
"domNodes": 76,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 16.167000000000005,
"eventListeners": 21,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 711.7200000000139,
"styleRecalcs": 11,
"styleRecalcDurationMs": 11.575999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 486.6569999999999,
"heapDeltaBytes": 17744572,
"heapUsedBytes": 88453816,
"domNodes": 18,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 166.274,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 726.0549999999739,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.988999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 476.348,
"heapDeltaBytes": -7547384,
"heapUsedBytes": 63344460,
"domNodes": 18,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 167.825,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2041.5160000000014,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.893999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 708.122,
"heapDeltaBytes": -15648488,
"heapUsedBytes": 87302204,
"domNodes": -268,
"jsHeapTotalBytes": -331776,
"scriptDurationMs": 38.581,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2054.4589999999516,
"styleRecalcs": 5,
"styleRecalcDurationMs": 5.667999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 781.533,
"heapDeltaBytes": 10990708,
"heapUsedBytes": 86850396,
"domNodes": -272,
"jsHeapTotalBytes": -1679360,
"scriptDurationMs": 43.935,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 3121.650999999929,
"styleRecalcs": 62,
"styleRecalcDurationMs": 8.565,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1941.982,
"heapDeltaBytes": 28223248,
"heapUsedBytes": 94557980,
"domNodes": -281,
"jsHeapTotalBytes": 749568,
"scriptDurationMs": 994.3910000000001,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2817.117000000053,
"styleRecalcs": 63,
"styleRecalcDurationMs": 9.471,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1852.743,
"heapDeltaBytes": 26880592,
"heapUsedBytes": 93652808,
"domNodes": 2,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 910.958,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666636,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 4024.8960000000125,
"styleRecalcs": 61,
"styleRecalcDurationMs": 11.831999999999999,
"layouts": 60,
"layoutDurationMs": 12.715999999999998,
"taskDurationMs": 1961.221,
"heapDeltaBytes": -2969304,
"heapUsedBytes": 75889688,
"domNodes": -285,
"jsHeapTotalBytes": -1417216,
"scriptDurationMs": 841.877,
"eventListeners": -186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3803.9159999999583,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.266999999999998,
"layouts": 60,
"layoutDurationMs": 12.712000000000002,
"taskDurationMs": 1809.3780000000002,
"heapDeltaBytes": 11725424,
"heapUsedBytes": 80124336,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 812.493,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3096.0469999999987,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.312999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2044.048,
"heapDeltaBytes": 26251984,
"heapUsedBytes": 94163772,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 997.57,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3218.705,
"styleRecalcs": 41,
"styleRecalcDurationMs": 6.498999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2166.3620000000005,
"heapDeltaBytes": 5437524,
"heapUsedBytes": 86132148,
"domNodes": -290,
"jsHeapTotalBytes": 49152,
"scriptDurationMs": 1065.5140000000001,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2004.73199999999,
"styleRecalcs": 3,
"styleRecalcDurationMs": 2.631999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 693.234,
"heapDeltaBytes": 21801424,
"heapUsedBytes": 88191900,
"domNodes": -272,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 38.41700000000001,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2049.2329999999583,
"styleRecalcs": 5,
"styleRecalcDurationMs": 6.062000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 790.5119999999998,
"heapDeltaBytes": 5322648,
"heapUsedBytes": 82053480,
"domNodes": -284,
"jsHeapTotalBytes": -1941504,
"scriptDurationMs": 39.97500000000001,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 734.9739999999656,
"styleRecalcs": 45,
"styleRecalcDurationMs": 11.34,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 472.9390000000001,
"heapDeltaBytes": 14655304,
"heapUsedBytes": 86664472,
"domNodes": 16,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 154.108,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 644.3719999999757,
"styleRecalcs": 45,
"styleRecalcDurationMs": 11.237,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 443.102,
"heapDeltaBytes": 15068552,
"heapUsedBytes": 87963796,
"domNodes": 16,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 149.49499999999998,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2022.0369999999548,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.124,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 583.0079999999999,
"heapDeltaBytes": -9320804,
"heapUsedBytes": 62376612,
"domNodes": -297,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 11.705,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2032.7519999999595,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.118,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 597.737,
"heapDeltaBytes": -12358540,
"heapUsedBytes": 60396760,
"domNodes": -296,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 12.043999999999999,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1756.9100000000617,
"styleRecalcs": 79,
"styleRecalcDurationMs": 32.28,
"layouts": 18,
"layoutDurationMs": 5.448,
"taskDurationMs": 871.7439999999999,
"heapDeltaBytes": -8189976,
"heapUsedBytes": 64168712,
"domNodes": -295,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 115.749,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1823.8870000000134,
"styleRecalcs": 79,
"styleRecalcDurationMs": 32.078,
"layouts": 18,
"layoutDurationMs": 5.62,
"taskDurationMs": 965.6920000000001,
"heapDeltaBytes": 11003304,
"heapUsedBytes": 84003836,
"domNodes": -297,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 124.376,
"eventListeners": -212,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-transition-enter",
"durationMs": 1415.6699999999773,
"styleRecalcs": 17,
"styleRecalcDurationMs": 33.532,
"layouts": 13,
"layoutDurationMs": 16.510000000000005,
"taskDurationMs": 1025.2949999999998,
"heapDeltaBytes": 20803656,
"heapUsedBytes": 104043804,
"domNodes": 13751,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 33.673,
"eventListeners": 2385,
"totalBlockingTimeMs": 164,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 10237.41999999993,
"styleRecalcs": 246,
"styleRecalcDurationMs": 38.616,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6577.018,
"heapDeltaBytes": 13371268,
"heapUsedBytes": 89583112,
"domNodes": -271,
"jsHeapTotalBytes": -1224704,
"scriptDurationMs": 2916.143,
"eventListeners": -172,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 9479.058000000008,
"styleRecalcs": 247,
"styleRecalcDurationMs": 36.959,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6372.587,
"heapDeltaBytes": 9684708,
"heapUsedBytes": 85936668,
"domNodes": -245,
"jsHeapTotalBytes": 86016,
"scriptDurationMs": 2859.34,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17707.317999999985,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17146.633,
"heapDeltaBytes": -39163496,
"heapUsedBytes": 178408360,
"domNodes": -8068,
"jsHeapTotalBytes": -11284480,
"scriptDurationMs": 294.78,
"eventListeners": -14935,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17899.90399999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17337.613,
"heapDeltaBytes": -38874948,
"heapUsedBytes": 178836804,
"domNodes": -8068,
"jsHeapTotalBytes": -6828032,
"scriptDurationMs": 289.59000000000003,
"eventListeners": -14935,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21874.476999999955,
"styleRecalcs": 166,
"styleRecalcDurationMs": 22.413000000000018,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21619.291,
"heapDeltaBytes": -17579332,
"heapUsedBytes": 192368208,
"domNodes": -8068,
"jsHeapTotalBytes": -13856768,
"scriptDurationMs": 957.043,
"eventListeners": -14927,
"totalBlockingTimeMs": 85,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 21678.38699999993,
"styleRecalcs": 160,
"styleRecalcDurationMs": 21.601999999999954,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21493.574,
"heapDeltaBytes": -47688992,
"heapUsedBytes": 169305900,
"domNodes": -8068,
"jsHeapTotalBytes": -11284480,
"scriptDurationMs": 1000.5489999999999,
"eventListeners": -14929,
"totalBlockingTimeMs": 112,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6500.14699999997,
"styleRecalcs": 20,
"styleRecalcDurationMs": 81.18400000000004,
"layouts": 20,
"layoutDurationMs": 25.759000000000004,
"taskDurationMs": 6449.724,
"heapDeltaBytes": -37927664,
"heapUsedBytes": 183805980,
"domNodes": -8068,
"jsHeapTotalBytes": 15912960,
"scriptDurationMs": 119.487,
"eventListeners": -14929,
"totalBlockingTimeMs": 489,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 6289.325999999846,
"styleRecalcs": 20,
"styleRecalcDurationMs": 78.92299999999996,
"layouts": 20,
"layoutDurationMs": 24.177000000000003,
"taskDurationMs": 6246.579000000001,
"heapDeltaBytes": -31189712,
"heapUsedBytes": 188148260,
"domNodes": -8068,
"jsHeapTotalBytes": 19480576,
"scriptDurationMs": 120.383,
"eventListeners": -14929,
"totalBlockingTimeMs": 432,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9048.156000000063,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8792.137999999999,
"heapDeltaBytes": 8568832,
"heapUsedBytes": 185692692,
"domNodes": 0,
"jsHeapTotalBytes": -20185088,
"scriptDurationMs": 149.67300000000006,
"eventListeners": -14,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8854.489999999942,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8657.760000000002,
"heapDeltaBytes": 10226900,
"heapUsedBytes": 178324660,
"domNodes": 0,
"jsHeapTotalBytes": -6029312,
"scriptDurationMs": 139.1650000000001,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 456.70499999994263,
"styleRecalcs": 17,
"styleRecalcDurationMs": 21.773,
"layouts": 3,
"layoutDurationMs": 1.727,
"taskDurationMs": 114.431,
"heapDeltaBytes": 5012420,
"heapUsedBytes": 73686768,
"domNodes": 147,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 14.022000000000002,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 112.94900000007146,
"styleRecalcs": 8,
"styleRecalcDurationMs": 14.877,
"layouts": 2,
"layoutDurationMs": 1.1620000000000001,
"taskDurationMs": 76.541,
"heapDeltaBytes": 2969540,
"heapUsedBytes": 71021320,
"domNodes": 127,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 5.596999999999998,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.799999999999272
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.54 #18354 +/- ##
=============================================
- Coverage 83.55% 83.54% -0.01%
=============================================
Files 2094 2094
Lines 123520 123521 +1
Branches 33296 33296
=============================================
- Hits 103202 103197 -5
- Misses 20139 20145 +6
Partials 179 179
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 5 files with indirect coverage changes 🚀 New features to boost your workflow:
|
…Image node bypassing upload (#18464) Automated backport of #18180 to `core/1.54`. The bot's auto-backport (`comfy-pr-bot`) failed on this branch with merge conflicts in: - `src/extensions/core/load3d/Load3DConfiguration.test.ts` - `src/extensions/core/load3d/Load3DConfiguration.ts` - `src/utils/createAnnotatedPath.test.ts` ## Root cause of the conflict Not a stacking conflict against any of the PRs the bot listed as still-open on `core/1.54` (#18417, #18410, #18407, #18369, #18354, #18334, #17872) — none of them touch these files. The real cause is that `core/1.54` never received an **already-merged, unrelated** PR: #17537 ("Load3D preview capture stale after agent-driven model_file change"), which is not on the bot's open-PR list and is not itself labeled for backport. That PR: - added a `DEFAULT_GIZMO`/`GizmoConfig` block to `Load3DConfiguration.ts` right next to the `parseAnnotatedFilename` helper that #18180 deletes (textual adjacency, not a real dependency — I did not port the gizmo code, since it's out of scope here and `core/1.54` has no other reference to it), and added `ComfyApi`/`ComfyApp` test imports unused on this branch (dropped), - moved the `ResultItem` type from `@/schemas/apiSchema` to `@/platform/remote/comfyui/execution/types` on `main`, which `core/1.54` hasn't picked up (kept the branch's existing `@/schemas/apiSchema` import), and - added an `app.getRandParam()` call inside `nodeOutputStore.ts` (already present on `core/1.54` from an earlier point, unrelated to #18180) whose test mock in `nodeOutputStore.test.ts` was missing `getRandParam`, only surfaced now because #18180's new test is the first to exercise `getNodeImageUrls()` on this file — added the missing mock entry. Resolved by taking #18180's actual change (removing the local `parseAnnotatedFilename` in favor of the shared `parseAnnotatedPath` util) while leaving everything from #17537 out, since it isn't part of this branch. ## Verification - `pnpm exec vitest run` on the touched spec files (`Load3DConfiguration.test.ts`, `createAnnotatedPath.test.ts`, `nodeOutputStore.test.ts`, `imageUtil.test.ts`) — all pass (113/113) - `pnpm typecheck` — clean - `pnpm exec eslint` on changed files — no errors (2 pre-existing `apiSchema` deprecation warnings, unrelated to this change) - `pnpm exec oxfmt --check` on changed files — clean - The new Playwright e2e (`assetPanelDragOntoLoadImageWidget.spec.ts`) was not run locally (no backend available), consistent with the original PR's own review notes. <!-- ccr-slack-attribution --> _Requested by **Christian Byrne** · [Slack thread](https://comfy-org.slack.com/archives/C0BGH348Z0C/p1789875316334739)_ --- _Generated by [Claude Code](https://claude.ai/code/session_01Ws2BqUcMwaeUuPpKdYNxPV)_ Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> Co-authored-by: bymyself <cbyrne@comfy.org>
Requested via Slack thread
Manual backport of #18324 to
core/1.54. The automatedpr-backport.yamlbot never reached this target (it errored out after processingcore/1.53andcloud/1.53, and never attemptedcore/1.54orcloud/1.54), even though #18324 carries thecore/1.54label. No bot failure comment exists for this target, so this was cherry-picked manually following the same pattern used for thecore/1.53(#18352) andcloud/1.53(#18350) backports.Fix
Fixes a
ReferenceError(temporal-dead-zone) crash when a workflow with a saved multiline STRING widget value is loaded.setValueinuseStringWidget.ts'saddMultilineWidget()closed over the outerwidgetconst to readwidget.options, butnode.addDOMWidget(...)can invokesetValuesynchronously (while restoring a saved value during workflow load) before thatconst widget = node.addDOMWidget(...)assignment completes. The fix hoists the widget's options into their ownwidgetOptionsconst, declared and initialized beforeaddDOMWidgetis called, and hassetValueread that instead of the outerwidgetbinding.Conflict resolution
The cherry-pick of
eefd88f4f424803e102c367d296106ecd749d798(single-parent commit, plaingit cherry-pick) applied cleanly with no conflicts in eitheruseStringWidget.tsoruseStringWidget.test.ts— git's auto-merge resolved both files without manual intervention.Verification
useStringWidget.test.ts: 5/5 tests passpnpm typecheck: cleanpnpm-lock.yamlorpackage.jsonchanges needed🤖 Generated with Claude Code
https://claude.ai/code/session_01KQEWS3P3LxaJx8jVvy5TUb
Generated by Claude Code