Repository navigation
[backport cloud/1.54] fix: stop agent turn on Escape after submitting via mouse click on Send - #18333
Conversation
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
…nd (#18296) <!-- ccr-slack-attribution --> _Requested by **Jo Zhang** · [Slack thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1790013777983039?thread_ts=1790013777.983039&cid=C0BGH348Z0C)_ Escape now stops an in-progress agent turn even when the turn was started by clicking the Send button with the mouse, not just when it was started by pressing Enter. - **What**: Before, pressing Escape stopped the agent turn only if the composer's prompt editor still had keyboard focus. Submitting with Enter never moves focus away, so Escape worked there. Clicking Send with the mouse moves focus to the button instead, and the Escape-to-stop handler was wired only to the editor's own keydown event, so it never saw the keypress and the turn kept running. Added a keydown handler on the composer's outer container that also catches Escape while focus is anywhere else inside the composer (including the Send/Stop button), without changing any focus behavior. The existing editor-scoped handler is unchanged, and it still stops propagation before this new handler runs, so nothing fires twice. Escape still does nothing once focus has left the composer entirely (e.g. the user clicked elsewhere on the page) — that behavior is intentional and unchanged. - **Breaking**: none - **Dependencies**: none - `src/workbench/extensions/agent/components/agent/Composer.vue`: the new `onContainerKeydown` handler and its `@keydown` binding on the `#agent-composer` wrapper. - `src/workbench/extensions/agent/components/agent/Composer.test.ts`: new coverage for (1) Escape stopping a run after submitting via a mouse click on Send, and (2) Escape *not* stopping a run once focus has left the composer for an unrelated element on the page. Existing Enter+Escape tests were re-run unmodified and still pass. - [x] Added a unit test that clicks Send with the mouse, then presses Escape, and asserts the turn is stopped — confirmed it fails against the pre-fix code and passes after the fix. - [x] Re-ran the full `Composer.test.ts` suite (93 tests) — all pass, including the existing Enter-then-Escape and mention-picker-Escape cases. - [x] Re-ran the full `src/workbench/extensions/agent` unit test suite (122 files) — all pass, no regressions. - [x] `eslint`, `oxlint`, and `vue-tsc --noEmit` all pass on the changed files/repo. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_017F6NfYxdCmZEFy9ut4cdUN
0482143 to
71c874f
Compare
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1933 passed, 0 failed📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-22T02:44:08.357Z",
"gitSha": "ff6fce8b60953f692319bf3cd4769f95bbb4b17b",
"branch": "backport-18296-to-cloud-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2055.273999999997,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.205,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 532.536,
"heapDeltaBytes": -11280816,
"heapUsedBytes": 58774304,
"domNodes": -276,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 8.733,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2020.0629999999364,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.887,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 495.471,
"heapDeltaBytes": -3031924,
"heapUsedBytes": 67345976,
"domNodes": -282,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 8.014999999999997,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2000.409999999988,
"styleRecalcs": 78,
"styleRecalcDurationMs": 34.831999999999994,
"layouts": 14,
"layoutDurationMs": 4.425,
"taskDurationMs": 941.3310000000001,
"heapDeltaBytes": 7822284,
"heapUsedBytes": 77665964,
"domNodes": -279,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 180.331,
"eventListeners": -168,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1874.4749999999613,
"styleRecalcs": 77,
"styleRecalcDurationMs": 28.493000000000002,
"layouts": 14,
"layoutDurationMs": 4.118,
"taskDurationMs": 878.31,
"heapDeltaBytes": -3923292,
"heapUsedBytes": 65702280,
"domNodes": -278,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 159.067,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1717.5029999999651,
"styleRecalcs": 30,
"styleRecalcDurationMs": 16.503,
"layouts": 6,
"layoutDurationMs": 1.029,
"taskDurationMs": 370.41299999999995,
"heapDeltaBytes": 4686548,
"heapUsedBytes": 75267704,
"domNodes": 75,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 11.983999999999998,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1740.1549999999588,
"styleRecalcs": 33,
"styleRecalcDurationMs": 17.898999999999997,
"layouts": 6,
"layoutDurationMs": 1.211,
"taskDurationMs": 367.973,
"heapDeltaBytes": 4648676,
"heapUsedBytes": 75320800,
"domNodes": 78,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 15.215000000000003,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 683.1540000000018,
"styleRecalcs": 12,
"styleRecalcDurationMs": 9.200000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 458.974,
"heapDeltaBytes": 18079364,
"heapUsedBytes": 88358252,
"domNodes": 20,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 164.934,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 628.3219999999119,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.945999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 444.05000000000007,
"heapDeltaBytes": -7855864,
"heapUsedBytes": 63055668,
"domNodes": 18,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 157.95100000000002,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2032.466999999997,
"styleRecalcs": 6,
"styleRecalcDurationMs": 6.6309999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 601.3230000000001,
"heapDeltaBytes": -16368012,
"heapUsedBytes": 86431504,
"domNodes": -265,
"jsHeapTotalBytes": 1503232,
"scriptDurationMs": 33.587,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2030.3820000000314,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.385,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 577.3069999999999,
"heapDeltaBytes": -15225208,
"heapUsedBytes": 87795508,
"domNodes": -269,
"jsHeapTotalBytes": -1642496,
"scriptDurationMs": 36.543000000000006,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2248.7259999999765,
"styleRecalcs": 66,
"styleRecalcDurationMs": 11.030999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1637.9869999999999,
"heapDeltaBytes": 18198236,
"heapUsedBytes": 84331720,
"domNodes": -271,
"jsHeapTotalBytes": 487424,
"scriptDurationMs": 836.434,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2337.1379999999817,
"styleRecalcs": 63,
"styleRecalcDurationMs": 8.676,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1648.274,
"heapDeltaBytes": 22745488,
"heapUsedBytes": 88848020,
"domNodes": -279,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 832.488,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3668.653000000006,
"styleRecalcs": 62,
"styleRecalcDurationMs": 12.641,
"layouts": 60,
"layoutDurationMs": 12.766000000000002,
"taskDurationMs": 1806.6219999999998,
"heapDeltaBytes": -2624544,
"heapUsedBytes": 75847968,
"domNodes": -287,
"jsHeapTotalBytes": 3825664,
"scriptDurationMs": 793.37,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3537.384999999972,
"styleRecalcs": 60,
"styleRecalcDurationMs": 9.233000000000006,
"layouts": 60,
"layoutDurationMs": 11.566999999999997,
"taskDurationMs": 1660.978,
"heapDeltaBytes": 8504740,
"heapUsedBytes": 76048176,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 756.746,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3153.864999999996,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.636000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1953.631,
"heapDeltaBytes": 22128692,
"heapUsedBytes": 90346136,
"domNodes": 0,
"jsHeapTotalBytes": 1466368,
"scriptDurationMs": 972.884,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666636,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3173.031999999921,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.794,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1975.8990000000001,
"heapDeltaBytes": 27176680,
"heapUsedBytes": 95428548,
"domNodes": 0,
"jsHeapTotalBytes": 1990656,
"scriptDurationMs": 1005.716,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "minimap-idle",
"durationMs": 2015.2420000000006,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.6450000000000022,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 567.1859999999999,
"heapDeltaBytes": 21800136,
"heapUsedBytes": 87731208,
"domNodes": -270,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 32.821000000000005,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2072.0119999999724,
"styleRecalcs": 6,
"styleRecalcDurationMs": 6.495999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 639.345,
"heapDeltaBytes": 5726068,
"heapUsedBytes": 83020988,
"domNodes": -277,
"jsHeapTotalBytes": -1941504,
"scriptDurationMs": 33.629999999999995,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 619.7459999999637,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.8,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 427.38499999999993,
"heapDeltaBytes": 14604000,
"heapUsedBytes": 86600560,
"domNodes": 20,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 145.741,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 584.604000000013,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.529,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 412.97499999999997,
"heapDeltaBytes": 14775600,
"heapUsedBytes": 87550692,
"domNodes": 20,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 143.435,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2023.3029999999985,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.135999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 488.85999999999996,
"heapDeltaBytes": -10611252,
"heapUsedBytes": 61089688,
"domNodes": -293,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 7.194000000000001,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2022.6940000000013,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.105,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 487.769,
"heapDeltaBytes": -13122260,
"heapUsedBytes": 59609052,
"domNodes": -294,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 7.459999999999998,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1773.7510000000043,
"styleRecalcs": 76,
"styleRecalcDurationMs": 26.506999999999994,
"layouts": 18,
"layoutDurationMs": 4.886,
"taskDurationMs": 816.3340000000001,
"heapDeltaBytes": -8461324,
"heapUsedBytes": 63179636,
"domNodes": -297,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 111.364,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1735.3469999999334,
"styleRecalcs": 77,
"styleRecalcDurationMs": 26.586,
"layouts": 18,
"layoutDurationMs": 4.391000000000001,
"taskDurationMs": 810.825,
"heapDeltaBytes": 7239420,
"heapUsedBytes": 79752608,
"domNodes": -294,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 110.31299999999999,
"eventListeners": -212,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1415.5869999999595,
"styleRecalcs": 19,
"styleRecalcDurationMs": 32.654999999999994,
"layouts": 15,
"layoutDurationMs": 15.897000000000002,
"taskDurationMs": 952.375,
"heapDeltaBytes": -7133860,
"heapUsedBytes": 82442668,
"domNodes": 13751,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 31.990999999999993,
"eventListeners": 2385,
"totalBlockingTimeMs": 142,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8688.406999999985,
"styleRecalcs": 250,
"styleRecalcDurationMs": 38.141,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6073.8730000000005,
"heapDeltaBytes": 10009360,
"heapUsedBytes": 85805460,
"domNodes": -240,
"jsHeapTotalBytes": 1167360,
"scriptDurationMs": 2812.437,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8568.736999999943,
"styleRecalcs": 248,
"styleRecalcDurationMs": 38.796,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5896.69,
"heapDeltaBytes": -17579912,
"heapUsedBytes": 85243436,
"domNodes": -268,
"jsHeapTotalBytes": 155648,
"scriptDurationMs": 2732.424,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17607.699000000026,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16961.16,
"heapDeltaBytes": -57272956,
"heapUsedBytes": 182085480,
"domNodes": -8068,
"jsHeapTotalBytes": -13021184,
"scriptDurationMs": 286.75800000000004,
"eventListeners": -14931,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16994.324000000008,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16590.244,
"heapDeltaBytes": -47611792,
"heapUsedBytes": 178100328,
"domNodes": -8068,
"jsHeapTotalBytes": -10526720,
"scriptDurationMs": 276.01599999999996,
"eventListeners": -14931,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 20919.45999999996,
"styleRecalcs": 159,
"styleRecalcDurationMs": 18.340999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20565.519,
"heapDeltaBytes": -35325248,
"heapUsedBytes": 182431368,
"domNodes": -8072,
"jsHeapTotalBytes": -12595200,
"scriptDurationMs": 925.0529999999999,
"eventListeners": -14927,
"totalBlockingTimeMs": 36,
"frameDurationMs": 17.773333333333238,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 20906.949000000055,
"styleRecalcs": 172,
"styleRecalcDurationMs": 16.981999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20541.106,
"heapDeltaBytes": -41312708,
"heapUsedBytes": 188640520,
"domNodes": -8068,
"jsHeapTotalBytes": -19382272,
"scriptDurationMs": 903.3149999999999,
"eventListeners": -14929,
"totalBlockingTimeMs": 43,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 6271.4659999999185,
"styleRecalcs": 20,
"styleRecalcDurationMs": 80.569,
"layouts": 20,
"layoutDurationMs": 23.394,
"taskDurationMs": 6131.3150000000005,
"heapDeltaBytes": -48417952,
"heapUsedBytes": 183063948,
"domNodes": -8068,
"jsHeapTotalBytes": 13193216,
"scriptDurationMs": 117.28899999999999,
"eventListeners": -14929,
"totalBlockingTimeMs": 412,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6296.192999999903,
"styleRecalcs": 20,
"styleRecalcDurationMs": 93.10499999999999,
"layouts": 20,
"layoutDurationMs": 34.64399999999999,
"taskDurationMs": 6184.82,
"heapDeltaBytes": -35163596,
"heapUsedBytes": 176067120,
"domNodes": -8068,
"jsHeapTotalBytes": 3268608,
"scriptDurationMs": 114.76599999999999,
"eventListeners": -14929,
"totalBlockingTimeMs": 441,
"frameDurationMs": 18.886666666666617,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8686.508000000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8384.623999999998,
"heapDeltaBytes": 19103216,
"heapUsedBytes": 178268924,
"domNodes": 0,
"jsHeapTotalBytes": -15204352,
"scriptDurationMs": 139.63800000000003,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8560.296999999991,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8343.307,
"heapDeltaBytes": -9660836,
"heapUsedBytes": 178174804,
"domNodes": 0,
"jsHeapTotalBytes": -12320768,
"scriptDurationMs": 132.266,
"eventListeners": -14,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 455.2170000000615,
"styleRecalcs": 13,
"styleRecalcDurationMs": 19.173000000000002,
"layouts": 3,
"layoutDurationMs": 0.843,
"taskDurationMs": 101.85,
"heapDeltaBytes": 4782872,
"heapUsedBytes": 73790924,
"domNodes": 122,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 8.242999999999999,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 461.4559999999983,
"styleRecalcs": 18,
"styleRecalcDurationMs": 21.361,
"layouts": 2,
"layoutDurationMs": 1.2360000000000002,
"taskDurationMs": 104.823,
"heapDeltaBytes": 4875092,
"heapUsedBytes": 73933504,
"domNodes": 144,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.078000000000001,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cloud/1.54 #18333 +/- ##
=============================================
Coverage ? 83.56%
=============================================
Files ? 2095
Lines ? 123644
Branches ? 33417
=============================================
Hits ? 103321
Misses ? 20145
Partials ? 178
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Exact-head adaptation accepted; human approval still required.
- Source behavior and release adaptation are supported at
71c874f157d370b6e32b56935e4b00d7bc0367e5. - Hosted checks are terminal: 78 successful, 12 skipped, 0 pending, 0 adverse.
- No code finding; served-environment acceptance remains separate.
Full context for agent readers
Requirement coverage:
- Mouse-click Send then Escape stops the active turn: covered in
Composer.test.ts. - Chrome button focus and Safari/Firefox body focus: both paths are covered.
- Focus moved elsewhere does not stop the turn: covered.
- Menu and dialog Escape ownership precedes the Agent override: covered in
keybindingService.escape.test.ts. - Repeated Escape is contained without duplicate stop; IME Escape is ignored: covered.
- Registration ordering and unregistration are covered in
escapeOverride.test.ts. - The virtual merge onto current
cloud/1.54is clean, with zero review threads. - Exact-head hosted evidence includes unit, lint/format, type checks, all 16 Chromium shards, Cloud Playwright, mobile/scaled Playwright, E2E aggregate, and both custom-node matrices.
The new escapeOverride.ts production file is byte-identical to source merge c23a1e69cd1de8264ae108fa9f0acd3e33ca48e7; the remaining production changes are the source behavior applied in the release line's surrounding code. Source PR 18296 had exact-head Christian approval before merge. This COMMENT review does not substitute for target human approval, authorize merge, or establish served-environment acceptance.
…eir real slot after an agent slot sync (PM-1449) (#18279) (#18340) Backport of #18279 to `cloud/1.54`. Manual cherry-pick — the automated backport reported a merge conflict. ## Summary (from #18279) A hand-wired connection into an autogrow port could be serialized against the wrong input after an agent slot sync. `updateNodeSlots` replaced the store's slot arrays even though the live `LGraphNode` retained the original arrays, leaving serialization and the canvas with different slot layouts. The fix preserves the registered input/output arrays and patches matching slot objects in place instead of replacing them, matching duplicate names occurrence by occurrence. ## Conflict resolution Conflicts were in `src/stores/nodeDataStore.ts` and `src/stores/nodeDataStore.test.ts`: - `src/stores/nodeDataStore.ts`: `updateNodeSlots` on `cloud/1.54` still had the pre-fix naive assignment (`state.inputs = slots.inputs`; `state.outputs = slots.outputs`). Took the incoming version, which calls the new `mergeSlotsByName` helper (added earlier in the same diff, which applied cleanly) for both inputs and outputs. - `src/stores/nodeDataStore.test.ts`: two conflicts. The import line conflicted because `cloud/1.54`'s test file already pulls in `createTestingPinia`/`setActivePinia`/`beforeEach` (used by describe blocks not present on `main`), while the incoming diff needed `vi` for its new spies. Resolved by keeping both sets of imports. The second conflict was a pure addition (a new `'keeps live slot edits visible after a remote slot sync'` test) with no `cloud/1.54`-side change, so it was taken as-is. **Is this a real conflict, or a stacking conflict?** I checked the three other PRs the backport bot flagged as still open against `cloud/1.54` (#18336, #18333, #18330). None of them touch `src/stores/nodeDataStore.ts` or `src/stores/nodeDataStore.test.ts`, so this is not a stacking conflict with those PRs — it's a genuine divergence: `cloud/1.54` simply hadn't yet picked up the array-mutation-in-place semantics that #18279 introduces on `main`. ## Verification - `pnpm vitest run src/stores/nodeDataStore.test.ts` — 31 passed. - `pnpm vitest run src/workbench/extensions/agent/crdt/graphMutations.test.ts` — 48 passed, 1 expected failure (matches #18279's own reported result). - `pnpm typecheck` — passed. - `pnpm oxlint` (on changed files) — no new warnings/errors. - `oxfmt --check` on changed files — all correctly formatted. <!-- ccr-slack-attribution --> _Requested by **Christian Byrne** · [Slack thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1789965308493739)_ 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01PqHg3D8o2RbujF1t4dz4J6 --- _Generated by [Claude Code](https://claude.ai/code/session_01PqHg3D8o2RbujF1t4dz4J6)_ Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> Co-authored-by: Amp <amp@ampcode.com>
|
Qualified for necessary Cloud backport integration at exact head Full context for agent readersThe source behavior and target adaptation were substantively reviewed at this exact head. All 91 check records are terminal: 78 successful and 13 skipped, with no adverse result. GraphQL review threads, submitted-review pagination, REST inline comments, and issue comments contain no unresolved human objection. Current Christian explicitly authorized necessary Cloud backports to be admin-merged after substantive review, exact-head checks, target compatibility, and no-objection gates. |
Requested by Christian Byrne · Slack thread
Backport of #18296 to
cloud/1.54.Before/After
Before: pressing Escape stopped an in-progress agent turn only if the composer's prompt editor still had keyboard focus. Submitting with Enter never moves focus away, so Escape worked there, but clicking Send with the mouse moves focus to the button instead, and the Escape-to-stop handler was wired only to the editor's own keydown event — it never saw the keypress, so the turn kept running.
After: a new
platform/keybindings/escapeOverridehook lets the agent composer register a runtime override thatkeybindingService'skeybindHandlerconsults (after menus/dialogs, before the defaultComfy.Graph.ExitSubgraphkeybinding) whenever bare Escape is pressed. The composer registers a handler that stops the run while focus is anywhere inside the composer (including the Send/Stop button) or nowhere in particular (Safari/Firefox leave focus on<body>after a plain click), and declines once focus has genuinely moved elsewhere on the page.Conflict resolution notes
Cherry-picked the squash-merge commit
c23a1e69cd1de8264ae108fa9f0acd3e33ca48e7ontocloud/1.54. Two test files conflicted, both resolved by keeping both sides' intent:src/platform/keybindings/keybindingService.escape.test.ts: import-only conflict. Keptcloud/1.54's existingpinia/reactiveimports (needed by its own pre-existing "legacy modal" test, which isn't onmain) and addedafterEachfrom the PR for the newclearEscapeOverrides()hook.src/workbench/extensions/agent/components/agent/Composer.test.ts: content conflicts. Took the PR's replacement of the old raw-dispatch repeated-Escape assertion, and inserted the PR's three new tests (mouse-click Send, Safari/Firefox no-focus-move, focus-left-composer) ahead ofcloud/1.54's pre-existing "does not stop on Escape during IME composition" test, which was preserved unchanged. Dropped one piece of unrelated context ("shows the Stop tooltip while submitting and stops on Escape while streaming") that the PR's diff carried only as surrounding context frommain— that test isn't part of PR fix: stop agent turn on Escape after submitting via mouse click on Send #18296 and isn't present oncloud/1.54(added by a different, not-yet-backported PR), so pulling it in here would have been out of scope.Verified:
pnpm typecheck(via pre-commit hook) and targetedvitest runonescapeOverride.test.ts,keybindingService.escape.test.ts, andComposer.test.ts— 109/109 passing.🤖 Generated with Claude Code
https://claude.ai/code/session_017F6NfYxdCmZEFy9ut4cdUN
Generated by Claude Code