Repository navigation
[backport cloud/1.54] fix: keep hand-wired autogrow connections on their real slot after an agent slot sync (PM-1449) (#18279) - #18340
Conversation
… agent slot sync (PM-1449) (#18279) <!-- ccr-slack-attribution --> _Requested by **Christian Byrne** · [Slack thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1789985885071859)_ A hand-wired connection into an autogrow port could be serialized against the wrong input after an agent slot sync. `updateNodeSlots` replaced the store's slot arrays even though the live `LGraphNode` retained the original arrays, leaving serialization and the canvas with different slot layouts. - Preserve the registered input and output arrays and patch matching slot objects in place. - Match duplicate names occurrence by occurrence. Insert incoming-only slots before the next matching live slot while retaining existing-only slots and their order. - Treat `NodeInputSlot` and `NodeOutputSlot` connectivity as link-store-owned explicitly, without probing prototypes or reading deprecated `link`/`links` accessors. - Reduce CRDT slot records to supported serialized fields before they reach live slot objects. - Cover the PM-1449 serialization path, middle insertion, duplicate input/output names, external runtime fields, live output identity/reactivity, partial snapshots, and self-aliased live slots. The `updateNodeSlots` signature is unchanged. `LGraphNode` binds its slot arrays to the registered `NodeState` when it is constructed. Reassigning `state.inputs` or `state.outputs` later detached the store from the live node. Subsequent local autogrow and connection changes updated the canvas array, while `LGraph.serialize()` read the stale store array and associated positional topology with the wrong slot. The fix keeps the shared arrays stable. Existing slot objects also remain stable so Vue dependents continue to invalidate through the reactive object. Connectivity remains authoritative in `linkStore` for live slot classes and in the descriptor for plain store records. - #18021 addresses the same array-detachment root cause for queued execution. - #18101 covers a separate dynamic-widget slot-offset issue. - #18275 changes agent input reconciliation and may overlap when either PR rebases onto the other. - `pnpm vitest run src/stores/nodeDataStore.test.ts` — 29 passed. - `pnpm vitest run src/workbench/extensions/agent/crdt/graphMutations.test.ts` — 50 passed, 1 expected failure. - `pnpm vitest run src/workbench/extensions/agent src/stores/nodeDataStore.test.ts src/core/graph/widgets/dynamicWidgets.test.ts` — 123 files, 1,919 passed, 7 expected failures. - `pnpm typecheck` — passed. - Scoped ESLint, type-aware oxlint, and oxfmt checks — passed. - Commit hook checks and pre-push `knip --cache` — passed. Fixes PM-1449 (child of PM-1442). --------- Co-authored-by: Amp <amp@ampcode.com>
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
|
Hold: exact-head policy failure; owner action needed.
Full context for agent readersThe failing check is Check for AI agent co-author trailers. It identifies both trailers in the carrier's sole commit. The existing branch owner needs to remove those commit-message trailers and publish the settled head through its authorized route; this release lane will not rewrite or overwrite the branch. After the head settles, require fresh terminal exact-head checks and human review before merge consideration. Current GraphQL state is |
0eb4264 to
89c69cb
Compare
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1933 passed, 0 failed📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-22T03:35:18.803Z",
"gitSha": "5cc4148e4180658abb4fb2e392fe3ee50fe381e2",
"branch": "backport-18279-to-cloud-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2039.512000000002,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.141,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 491.901,
"heapDeltaBytes": -9457908,
"heapUsedBytes": 60110508,
"domNodes": -282,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 8.746,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2063.902999999982,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.503999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 518.152,
"heapDeltaBytes": 10242636,
"heapUsedBytes": 80887536,
"domNodes": -279,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 9.388999999999998,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2003.2690000000457,
"styleRecalcs": 76,
"styleRecalcDurationMs": 31.157000000000004,
"layouts": 14,
"layoutDurationMs": 4.725,
"taskDurationMs": 986.459,
"heapDeltaBytes": 6193108,
"heapUsedBytes": 70018664,
"domNodes": -285,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 178.574,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1806.5990000000056,
"styleRecalcs": 75,
"styleRecalcDurationMs": 27.378,
"layouts": 14,
"layoutDurationMs": 4.037,
"taskDurationMs": 844.351,
"heapDeltaBytes": 13972996,
"heapUsedBytes": 84264716,
"domNodes": -278,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 155.109,
"eventListeners": -166,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1707.8859999999736,
"styleRecalcs": 31,
"styleRecalcDurationMs": 15.248000000000001,
"layouts": 6,
"layoutDurationMs": 1.0970000000000002,
"taskDurationMs": 352.347,
"heapDeltaBytes": 4602180,
"heapUsedBytes": 75441868,
"domNodes": 76,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 10.757,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1724.6099999999842,
"styleRecalcs": 32,
"styleRecalcDurationMs": 15.521000000000003,
"layouts": 6,
"layoutDurationMs": 1.2,
"taskDurationMs": 352.418,
"heapDeltaBytes": 4376684,
"heapUsedBytes": 74893364,
"domNodes": 76,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 10.682,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 655.4590000000076,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.241999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 451.94899999999996,
"heapDeltaBytes": -8183672,
"heapUsedBytes": 62800268,
"domNodes": 18,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 160.84699999999998,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 651.9030000000043,
"styleRecalcs": 13,
"styleRecalcDurationMs": 9.472999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 451.539,
"heapDeltaBytes": 18691096,
"heapUsedBytes": 88514124,
"domNodes": 22,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 163.69400000000002,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2048.322999999982,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.683000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 627.2529999999999,
"heapDeltaBytes": 5374604,
"heapUsedBytes": 81264252,
"domNodes": -276,
"jsHeapTotalBytes": -368640,
"scriptDurationMs": 37.276999999999994,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2068.2789999999613,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.895999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 632.0640000000001,
"heapDeltaBytes": 4842476,
"heapUsedBytes": 80931276,
"domNodes": -283,
"jsHeapTotalBytes": -1679360,
"scriptDurationMs": 35.156000000000006,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2311.6240000000516,
"styleRecalcs": 68,
"styleRecalcDurationMs": 12.399000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1673.566,
"heapDeltaBytes": -7335304,
"heapUsedBytes": 69224844,
"domNodes": -280,
"jsHeapTotalBytes": 942080,
"scriptDurationMs": 819.7289999999999,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2271.194000000037,
"styleRecalcs": 65,
"styleRecalcDurationMs": 10.352,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1616.5610000000004,
"heapDeltaBytes": 21626060,
"heapUsedBytes": 88037252,
"domNodes": -272,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 813.2270000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3543.461999999977,
"styleRecalcs": 62,
"styleRecalcDurationMs": 15.016000000000002,
"layouts": 60,
"layoutDurationMs": 11.903,
"taskDurationMs": 1772.4370000000001,
"heapDeltaBytes": -6894180,
"heapUsedBytes": 71866716,
"domNodes": -255,
"jsHeapTotalBytes": -630784,
"scriptDurationMs": 785.898,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3549.523000000022,
"styleRecalcs": 61,
"styleRecalcDurationMs": 10.571,
"layouts": 60,
"layoutDurationMs": 11.981,
"taskDurationMs": 1713.788,
"heapDeltaBytes": -10138208,
"heapUsedBytes": 68134060,
"domNodes": -289,
"jsHeapTotalBytes": 4349952,
"scriptDurationMs": 764.436,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3197.9560000000333,
"styleRecalcs": 42,
"styleRecalcDurationMs": 6.547000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1998.0090000000002,
"heapDeltaBytes": 5748692,
"heapUsedBytes": 86175296,
"domNodes": -285,
"jsHeapTotalBytes": 49152,
"scriptDurationMs": 975.2579999999999,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666636,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3043.4830000000375,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.871,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1937.8899999999999,
"heapDeltaBytes": 18012140,
"heapUsedBytes": 86293176,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 979.678,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666636,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2059.2100000000073,
"styleRecalcs": 6,
"styleRecalcDurationMs": 9.162,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 614.047,
"heapDeltaBytes": 8063196,
"heapUsedBytes": 85422884,
"domNodes": -271,
"jsHeapTotalBytes": -1679360,
"scriptDurationMs": 31.705,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2048.0680000000575,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.6259999999999972,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 579.0249999999999,
"heapDeltaBytes": 10099716,
"heapUsedBytes": 87296420,
"domNodes": -273,
"jsHeapTotalBytes": -1941504,
"scriptDurationMs": 34.098000000000006,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 572.5970000000302,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.327,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 407.11999999999995,
"heapDeltaBytes": 15040256,
"heapUsedBytes": 88163072,
"domNodes": 20,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 140.815,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 596.2920000000622,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.131,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 396.519,
"heapDeltaBytes": 15003528,
"heapUsedBytes": 87963812,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 136.53699999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2023.477000000014,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.758999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 488.187,
"heapDeltaBytes": -7159144,
"heapUsedBytes": 64946552,
"domNodes": -295,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 7.8900000000000015,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2015.8089999999902,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.801000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 487.18500000000006,
"heapDeltaBytes": -9371332,
"heapUsedBytes": 62647036,
"domNodes": -296,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 7.8039999999999985,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1706.6469999999754,
"styleRecalcs": 77,
"styleRecalcDurationMs": 28.337999999999997,
"layouts": 18,
"layoutDurationMs": 5.247,
"taskDurationMs": 808.55,
"heapDeltaBytes": 6101500,
"heapUsedBytes": 71920768,
"domNodes": -296,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 109.77000000000001,
"eventListeners": -212,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1724.5320000000106,
"styleRecalcs": 78,
"styleRecalcDurationMs": 27.352,
"layouts": 18,
"layoutDurationMs": 5.114,
"taskDurationMs": 832.7379999999999,
"heapDeltaBytes": -894064,
"heapUsedBytes": 72072388,
"domNodes": -296,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 114.059,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1417.3069999999939,
"styleRecalcs": 18,
"styleRecalcDurationMs": 32.24999999999999,
"layouts": 14,
"layoutDurationMs": 15.208000000000002,
"taskDurationMs": 941.3450000000001,
"heapDeltaBytes": 22011316,
"heapUsedBytes": 105837024,
"domNodes": 13751,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 31.073999999999998,
"eventListeners": 2385,
"totalBlockingTimeMs": 142,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8500.13899999999,
"styleRecalcs": 249,
"styleRecalcDurationMs": 35.768,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5791.374999999999,
"heapDeltaBytes": 13121772,
"heapUsedBytes": 89522084,
"domNodes": -266,
"jsHeapTotalBytes": -1978368,
"scriptDurationMs": 2680.065,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8333.169999999995,
"styleRecalcs": 247,
"styleRecalcDurationMs": 33.527,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5844.6810000000005,
"heapDeltaBytes": -18239120,
"heapUsedBytes": 85103376,
"domNodes": -267,
"jsHeapTotalBytes": -1417216,
"scriptDurationMs": 2687.855,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17079.117999999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16584.305999999997,
"heapDeltaBytes": -34103268,
"heapUsedBytes": 177052168,
"domNodes": -8068,
"jsHeapTotalBytes": -15368192,
"scriptDurationMs": 316.381,
"eventListeners": -14931,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17365.77299999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16739.644,
"heapDeltaBytes": -39399064,
"heapUsedBytes": 177599412,
"domNodes": -8068,
"jsHeapTotalBytes": -11022336,
"scriptDurationMs": 281.31500000000005,
"eventListeners": -14933,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20647.223000000053,
"styleRecalcs": 170,
"styleRecalcDurationMs": 16.670999999999992,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20292.911,
"heapDeltaBytes": -28855992,
"heapUsedBytes": 188976692,
"domNodes": -8068,
"jsHeapTotalBytes": -13471744,
"scriptDurationMs": 877.163,
"eventListeners": -14925,
"totalBlockingTimeMs": 21,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 21352.593999999954,
"styleRecalcs": 177,
"styleRecalcDurationMs": 17.311999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21012.183999999997,
"heapDeltaBytes": -59048440,
"heapUsedBytes": 168655964,
"domNodes": -8068,
"jsHeapTotalBytes": -18767872,
"scriptDurationMs": 956.0240000000001,
"eventListeners": -14927,
"totalBlockingTimeMs": 69,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6215.495999999974,
"styleRecalcs": 20,
"styleRecalcDurationMs": 76.73200000000003,
"layouts": 20,
"layoutDurationMs": 22.650000000000002,
"taskDurationMs": 6101.856000000001,
"heapDeltaBytes": -52286932,
"heapUsedBytes": 175863384,
"domNodes": -8068,
"jsHeapTotalBytes": 4562944,
"scriptDurationMs": 115.815,
"eventListeners": -14927,
"totalBlockingTimeMs": 452,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6226.419000000078,
"styleRecalcs": 20,
"styleRecalcDurationMs": 77.22099999999999,
"layouts": 20,
"layoutDurationMs": 21.98199999999999,
"taskDurationMs": 6107.167,
"heapDeltaBytes": -38162992,
"heapUsedBytes": 179218136,
"domNodes": -8068,
"jsHeapTotalBytes": 12623872,
"scriptDurationMs": 108.742,
"eventListeners": -14929,
"totalBlockingTimeMs": 419,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8490.470999999958,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8322.53,
"heapDeltaBytes": 19303568,
"heapUsedBytes": 178146588,
"domNodes": 0,
"jsHeapTotalBytes": -12058624,
"scriptDurationMs": 134.9389999999999,
"eventListeners": -14,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8610.125999999924,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8397.989000000001,
"heapDeltaBytes": 12440060,
"heapUsedBytes": 176768708,
"domNodes": 0,
"jsHeapTotalBytes": -18612224,
"scriptDurationMs": 180.728,
"eventListeners": -16,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 459.63599999998905,
"styleRecalcs": 18,
"styleRecalcDurationMs": 25.103,
"layouts": 3,
"layoutDurationMs": 1.262,
"taskDurationMs": 111.57600000000001,
"heapDeltaBytes": 4889452,
"heapUsedBytes": 72810296,
"domNodes": 147,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.869999999999998,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 89.34799999997267,
"styleRecalcs": 6,
"styleRecalcDurationMs": 12.907,
"layouts": 2,
"layoutDurationMs": 0.8920000000000001,
"taskDurationMs": 67.408,
"heapDeltaBytes": 3117188,
"heapUsedBytes": 71471156,
"domNodes": 130,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 6.069999999999999,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cloud/1.54 #18340 +/- ##
=============================================
Coverage ? 83.56%
=============================================
Files ? 2094
Lines ? 123683
Branches ? 31302
=============================================
Hits ? 103357
Misses ? 20148
Partials ? 178
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
…t workflow connections after dynamic input reordering (#18393) ## Summary Backport #17221 to `cloud/1.54` so agent-loaded workflows keep connections on their named inputs after dynamic input reordering. Fixes [PM-993](https://linear.app/comfy-org/issue/PM-993). ## Changes - Preserve the original runtime patch and its CRDT/store regressions. Prerequisite #18340 is already merged into the release base (`64fe8c172f`). - Adapt the MiniMax-style browser regression to the release branch's existing `HostDoc` and agent boot fixtures, retaining the connect/save/reopen assertions without importing main's conversation replay harness. - Resolve release-specific imports and keep its ADR index entries. No package or lockfile changes. ## Review Focus Release test-fixture adaptation. Original limitations remain: authoritative snapshots can replace runtime slot objects; producer-side addressing is out of scope. Validation: input-order regressions fail 2/2 on the release baseline and pass with the backport; related CRDT/store suites pass (50 files, 770 passed, 2 expected failures). App/browser typechecks, full lint, formatting, Knip, ADR validation and commit hooks passed. Browser tests were not executed locally. CI on `80fb9c3cb3` completed with no failures or pending checks. Cloud browser suite: 215 passed, 2 skipped, 0 flaky; `minimaxAutogrowReload.spec.ts` passed on its first attempt (retry 0). Unit coverage, browser matrix, ecosystem and lint checks passed.
Backport of #18279 to
cloud/1.54. Manual cherry-pick — the automated backport reported a merge conflict.Summary (from #18279)
A hand-wired connection into an autogrow port could be serialized against the wrong input after an agent slot sync.
updateNodeSlotsreplaced the store's slot arrays even though the liveLGraphNoderetained the original arrays, leaving serialization and the canvas with different slot layouts.The fix preserves the registered input/output arrays and patches matching slot objects in place instead of replacing them, matching duplicate names occurrence by occurrence.
Conflict resolution
Conflicts were in
src/stores/nodeDataStore.tsandsrc/stores/nodeDataStore.test.ts:src/stores/nodeDataStore.ts:updateNodeSlotsoncloud/1.54still had the pre-fix naive assignment (state.inputs = slots.inputs;state.outputs = slots.outputs). Took the incoming version, which calls the newmergeSlotsByNamehelper (added earlier in the same diff, which applied cleanly) for both inputs and outputs.src/stores/nodeDataStore.test.ts: two conflicts. The import line conflicted becausecloud/1.54's test file already pulls increateTestingPinia/setActivePinia/beforeEach(used by describe blocks not present onmain), while the incoming diff neededvifor its new spies. Resolved by keeping both sets of imports. The second conflict was a pure addition (a new'keeps live slot edits visible after a remote slot sync'test) with nocloud/1.54-side change, so it was taken as-is.Is this a real conflict, or a stacking conflict? I checked the three other PRs the backport bot flagged as still open against
cloud/1.54(#18336, #18333, #18330). None of them touchsrc/stores/nodeDataStore.tsorsrc/stores/nodeDataStore.test.ts, so this is not a stacking conflict with those PRs — it's a genuine divergence:cloud/1.54simply hadn't yet picked up the array-mutation-in-place semantics that #18279 introduces onmain.Verification
pnpm vitest run src/stores/nodeDataStore.test.ts— 31 passed.pnpm vitest run src/workbench/extensions/agent/crdt/graphMutations.test.ts— 48 passed, 1 expected failure (matches fix: keep hand-wired autogrow connections on their real slot after an agent slot sync (PM-1449) #18279's own reported result).pnpm typecheck— passed.pnpm oxlint(on changed files) — no new warnings/errors.oxfmt --checkon changed files — all correctly formatted.Requested by Christian Byrne · Slack thread
🤖 Generated with Claude Code
https://claude.ai/code/session_01PqHg3D8o2RbujF1t4dz4J6
Generated by Claude Code