Skip to content

[backport cloud/1.54] fix: keep hand-wired autogrow connections on their real slot after an agent slot sync (PM-1449) (#18279) - #18340

Merged
christian-byrne merged 1 commit into
cloud/1.54from
backport-18279-to-cloud-1.54
Sep 22, 2026
Merged

christian-byrne merged 1 commit into
cloud/1.54from
backport-18279-to-cloud-1.54

Conversation

@claude

@claude claude Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

Backport of #18279 to cloud/1.54. Manual cherry-pick — the automated backport reported a merge conflict.

Summary (from #18279)

A hand-wired connection into an autogrow port could be serialized against the wrong input after an agent slot sync. updateNodeSlots replaced the store's slot arrays even though the live LGraphNode retained the original arrays, leaving serialization and the canvas with different slot layouts.

The fix preserves the registered input/output arrays and patches matching slot objects in place instead of replacing them, matching duplicate names occurrence by occurrence.

Conflict resolution

Conflicts were in src/stores/nodeDataStore.ts and src/stores/nodeDataStore.test.ts:

  • src/stores/nodeDataStore.ts: updateNodeSlots on cloud/1.54 still had the pre-fix naive assignment (state.inputs = slots.inputs; state.outputs = slots.outputs). Took the incoming version, which calls the new mergeSlotsByName helper (added earlier in the same diff, which applied cleanly) for both inputs and outputs.
  • src/stores/nodeDataStore.test.ts: two conflicts. The import line conflicted because cloud/1.54's test file already pulls in createTestingPinia/setActivePinia/beforeEach (used by describe blocks not present on main), while the incoming diff needed vi for its new spies. Resolved by keeping both sets of imports. The second conflict was a pure addition (a new 'keeps live slot edits visible after a remote slot sync' test) with no cloud/1.54-side change, so it was taken as-is.

Is this a real conflict, or a stacking conflict? I checked the three other PRs the backport bot flagged as still open against cloud/1.54 (#18336, #18333, #18330). None of them touch src/stores/nodeDataStore.ts or src/stores/nodeDataStore.test.ts, so this is not a stacking conflict with those PRs — it's a genuine divergence: cloud/1.54 simply hadn't yet picked up the array-mutation-in-place semantics that #18279 introduces on main.

Verification

Requested by Christian Byrne · Slack thread

🤖 Generated with Claude Code

https://claude.ai/code/session_01PqHg3D8o2RbujF1t4dz4J6


Generated by Claude Code

… agent slot sync (PM-1449) (#18279)

<!-- ccr-slack-attribution -->
_Requested by **Christian Byrne** · [Slack
thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1789985885071859)_

A hand-wired connection into an autogrow port could be serialized
against the wrong input after an agent slot sync. `updateNodeSlots`
replaced the store's slot arrays even though the live `LGraphNode`
retained the original arrays, leaving serialization and the canvas with
different slot layouts.

- Preserve the registered input and output arrays and patch matching
slot objects in place.
- Match duplicate names occurrence by occurrence. Insert incoming-only
slots before the next matching live slot while retaining existing-only
slots and their order.
- Treat `NodeInputSlot` and `NodeOutputSlot` connectivity as
link-store-owned explicitly, without probing prototypes or reading
deprecated `link`/`links` accessors.
- Reduce CRDT slot records to supported serialized fields before they
reach live slot objects.
- Cover the PM-1449 serialization path, middle insertion, duplicate
input/output names, external runtime fields, live output
identity/reactivity, partial snapshots, and self-aliased live slots.

The `updateNodeSlots` signature is unchanged.

`LGraphNode` binds its slot arrays to the registered `NodeState` when it
is constructed. Reassigning `state.inputs` or `state.outputs` later
detached the store from the live node. Subsequent local autogrow and
connection changes updated the canvas array, while `LGraph.serialize()`
read the stale store array and associated positional topology with the
wrong slot.

The fix keeps the shared arrays stable. Existing slot objects also
remain stable so Vue dependents continue to invalidate through the
reactive object. Connectivity remains authoritative in `linkStore` for
live slot classes and in the descriptor for plain store records.

- #18021 addresses the same array-detachment root cause for queued
execution.
- #18101 covers a separate dynamic-widget slot-offset issue.
- #18275 changes agent input reconciliation and may overlap when either
PR rebases onto the other.

- `pnpm vitest run src/stores/nodeDataStore.test.ts` — 29 passed.
- `pnpm vitest run
src/workbench/extensions/agent/crdt/graphMutations.test.ts` — 50 passed,
1 expected failure.
- `pnpm vitest run src/workbench/extensions/agent
src/stores/nodeDataStore.test.ts
src/core/graph/widgets/dynamicWidgets.test.ts` — 123 files, 1,919
passed, 7 expected failures.
- `pnpm typecheck` — passed.
- Scoped ESLint, type-aware oxlint, and oxfmt checks — passed.
- Commit hook checks and pre-push `knip --cache` — passed.

Fixes PM-1449 (child of PM-1442).

---------

Co-authored-by: Amp <amp@ampcode.com>
@claude claude Bot added backport Backporting a PR onto a release candidate cloud/1.54 Backport PRs for cloud 1.54 labels Sep 22, 2026
@coderabbitai

coderabbitai Bot commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 7da17e73-7abc-493d-82bd-b2aba1755652

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@vercel

vercel Bot commented Sep 22, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
billing-web Ignored Ignored Sep 22, 2026 2:59am UTC

Request Review

@christian-byrne

Copy link
Copy Markdown
Contributor

Hold: exact-head policy failure; owner action needed.

  • 0eb4264d021e3f23ce64e1fb73e01b70eaab7500 contains prohibited Claude and Amp Co-authored-by trailers.
  • Hosted checks are still non-terminal, and there is no human review.
  • The virtual merge onto current cloud/1.54 is clean; src/stores/nodeDataStore.ts is byte-identical to source merge 566c343fb95e77ee04c4dc3aa02ea40bcb416e66.
Full context for agent readers

The failing check is Check for AI agent co-author trailers. It identifies both trailers in the carrier's sole commit. The existing branch owner needs to remove those commit-message trailers and publish the settled head through its authorized route; this release lane will not rewrite or overwrite the branch.

After the head settles, require fresh terminal exact-head checks and human review before merge consideration. Current GraphQL state is MERGEABLE / BLOCKED / REVIEW_REQUIRED, with zero review threads. The conflict adaptation keeps the release line's existing test setup while applying the source behavior; no competing carrier or rerun is requested here.

@claude
claude Bot force-pushed the backport-18279-to-cloud-1.54 branch from 0eb4264 to 89c69cb Compare September 22, 2026 02:59
@github-actions

github-actions Bot commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/22/2026, 03:09:51 AM UTC

Links

🎭 Playwright: ✅ 1933 passed, 0 failed

📊 Browser Reports
  • chromium: View Report (✅ 1912 / ❌ 0 / ⚠️ 0 / ⏭️ 13)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.2 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.6 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.7 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.2 MB heap
large-graph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 77.3 MB heap
large-graph-pan: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 75.0 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.8 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.2 MB heap
minimap-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.4 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 84.0 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 60.8 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.7 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 142ms TBT · 100.9 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.3 MB heap
vue-large-graph-idle: · 56.3 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 169.1 MB heap
vue-large-graph-pan: · 56.3 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 45ms TBT · 170.5 MB heap
vue-node-resize-workload: · 56.3 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 436ms TBT · 169.3 MB heap
vue-zoom-out-idle: · 56.3 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 169.2 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.8 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 8ms
canvas-idle: layout count 0
canvas-idle: style recalc count 9
canvas-idle: task duration 505ms
canvas-idle: script duration 9ms
canvas-idle: TBT 0ms
canvas-idle: heap used 67.2 MB
canvas-idle: DOM nodes -281
canvas-idle: event listeners -180
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 29ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 76
canvas-mouse-sweep: task duration 915ms
canvas-mouse-sweep: script duration 167ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 73.6 MB
canvas-mouse-sweep: DOM nodes -282
canvas-mouse-sweep: event listeners -165
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 15ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 32
canvas-zoom-sweep: task duration 352ms
canvas-zoom-sweep: script duration 11ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 71.7 MB
canvas-zoom-sweep: DOM nodes 76
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 9ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 12
dom-widget-clipping: task duration 452ms
dom-widget-clipping: script duration 162ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 72.2 MB
dom-widget-clipping: DOM nodes 20
dom-widget-clipping: event listeners 2
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 6ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 7
large-graph-idle: task duration 630ms
large-graph-idle: script duration 36ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 77.3 MB
large-graph-idle: DOM nodes -280
large-graph-idle: event listeners -192
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 11ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 67
large-graph-pan: task duration 1645ms
large-graph-pan: script duration 816ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 75.0 MB
large-graph-pan: DOM nodes -276
large-graph-pan: event listeners -93
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 12ms
large-graph-zoom: style recalc duration 13ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 62
large-graph-zoom: task duration 1743ms
large-graph-zoom: script duration 775ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 66.8 MB
large-graph-zoom: DOM nodes -272
large-graph-zoom: event listeners -193
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 6ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 41
legacy-node-drag: task duration 1968ms
legacy-node-drag: script duration 977ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 82.2 MB
legacy-node-drag: DOM nodes -143
legacy-node-drag: event listeners 89
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 6ms
minimap-idle: layout count 0
minimap-idle: style recalc count 5
minimap-idle: task duration 597ms
minimap-idle: script duration 33ms
minimap-idle: TBT 0ms
minimap-idle: heap used 82.4 MB
minimap-idle: DOM nodes -272
minimap-idle: event listeners -178
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 10ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 47
subgraph-dom-widget-clipping: task duration 402ms
subgraph-dom-widget-clipping: script duration 139ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 84.0 MB
subgraph-dom-widget-clipping: DOM nodes 19
subgraph-dom-widget-clipping: event listeners 7
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 8ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 9
subgraph-idle: task duration 488ms
subgraph-idle: script duration 8ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 60.8 MB
subgraph-idle: DOM nodes -296
subgraph-idle: event listeners -240
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 5ms
subgraph-mouse-sweep: style recalc duration 28ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 78
subgraph-mouse-sweep: task duration 821ms
subgraph-mouse-sweep: script duration 112ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 68.7 MB
subgraph-mouse-sweep: DOM nodes -296
subgraph-mouse-sweep: event listeners -227
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 15ms
subgraph-transition-enter: style recalc duration 32ms
subgraph-transition-enter: layout count 14
subgraph-transition-enter: style recalc count 18
subgraph-transition-enter: task duration 941ms
subgraph-transition-enter: script duration 31ms
subgraph-transition-enter: TBT 142ms
subgraph-transition-enter: heap used 100.9 MB
subgraph-transition-enter: DOM nodes 13751
subgraph-transition-enter: event listeners 2385
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 35ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 248
viewport-pan-sweep: task duration 5818ms
viewport-pan-sweep: script duration 2684ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 83.3 MB
viewport-pan-sweep: DOM nodes -267
viewport-pan-sweep: event listeners -162
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 16662ms
vue-large-graph-idle: script duration 299ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 169.1 MB
vue-large-graph-idle: DOM nodes -8068
vue-large-graph-idle: event listeners -14932
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 17ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 174
vue-large-graph-pan: task duration 20653ms
vue-large-graph-pan: script duration 917ms
vue-large-graph-pan: TBT 45ms
vue-large-graph-pan: heap used 170.5 MB
vue-large-graph-pan: DOM nodes -8068
vue-large-graph-pan: event listeners -14926
vue-node-resize-workload: avg frame time 18ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 22ms
vue-node-resize-workload: style recalc duration 77ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 6105ms
vue-node-resize-workload: script duration 112ms
vue-node-resize-workload: TBT 436ms
vue-node-resize-workload: heap used 169.3 MB
vue-node-resize-workload: DOM nodes -8068
vue-node-resize-workload: event listeners -14928
vue-zoom-out-idle: avg frame time 18ms
vue-zoom-out-idle: p95 frame time 17ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 8360ms
vue-zoom-out-idle: script duration 158ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 169.2 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners -15
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 19ms
workflow-execution: layout count 3
workflow-execution: style recalc count 12
workflow-execution: task duration 89ms
workflow-execution: script duration 7ms
workflow-execution: TBT 0ms
workflow-execution: heap used 68.8 MB
workflow-execution: DOM nodes 139
workflow-execution: event listeners 49
Raw data
{
  "timestamp": "2026-09-22T03:35:18.803Z",
  "gitSha": "5cc4148e4180658abb4fb2e392fe3ee50fe381e2",
  "branch": "backport-18279-to-cloud-1.54",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2039.512000000002,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 7.141,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 491.901,
      "heapDeltaBytes": -9457908,
      "heapUsedBytes": 60110508,
      "domNodes": -282,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 8.746,
      "eventListeners": -196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-idle",
      "durationMs": 2063.902999999982,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.503999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 518.152,
      "heapDeltaBytes": 10242636,
      "heapUsedBytes": 80887536,
      "domNodes": -279,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 9.388999999999998,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 2003.2690000000457,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 31.157000000000004,
      "layouts": 14,
      "layoutDurationMs": 4.725,
      "taskDurationMs": 986.459,
      "heapDeltaBytes": 6193108,
      "heapUsedBytes": 70018664,
      "domNodes": -285,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 178.574,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1806.5990000000056,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 27.378,
      "layouts": 14,
      "layoutDurationMs": 4.037,
      "taskDurationMs": 844.351,
      "heapDeltaBytes": 13972996,
      "heapUsedBytes": 84264716,
      "domNodes": -278,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 155.109,
      "eventListeners": -166,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1707.8859999999736,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 15.248000000000001,
      "layouts": 6,
      "layoutDurationMs": 1.0970000000000002,
      "taskDurationMs": 352.347,
      "heapDeltaBytes": 4602180,
      "heapUsedBytes": 75441868,
      "domNodes": 76,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 10.757,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1724.6099999999842,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 15.521000000000003,
      "layouts": 6,
      "layoutDurationMs": 1.2,
      "taskDurationMs": 352.418,
      "heapDeltaBytes": 4376684,
      "heapUsedBytes": 74893364,
      "domNodes": 76,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 10.682,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 655.4590000000076,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 8.241999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 451.94899999999996,
      "heapDeltaBytes": -8183672,
      "heapUsedBytes": 62800268,
      "domNodes": 18,
      "jsHeapTotalBytes": 6815744,
      "scriptDurationMs": 160.84699999999998,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 651.9030000000043,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 9.472999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 451.539,
      "heapDeltaBytes": 18691096,
      "heapUsedBytes": 88514124,
      "domNodes": 22,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 163.69400000000002,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2048.322999999982,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 6.683000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 627.2529999999999,
      "heapDeltaBytes": 5374604,
      "heapUsedBytes": 81264252,
      "domNodes": -276,
      "jsHeapTotalBytes": -368640,
      "scriptDurationMs": 37.276999999999994,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2068.2789999999613,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 5.895999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 632.0640000000001,
      "heapDeltaBytes": 4842476,
      "heapUsedBytes": 80931276,
      "domNodes": -283,
      "jsHeapTotalBytes": -1679360,
      "scriptDurationMs": 35.156000000000006,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2311.6240000000516,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 12.399000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1673.566,
      "heapDeltaBytes": -7335304,
      "heapUsedBytes": 69224844,
      "domNodes": -280,
      "jsHeapTotalBytes": 942080,
      "scriptDurationMs": 819.7289999999999,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2271.194000000037,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 10.352,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1616.5610000000004,
      "heapDeltaBytes": 21626060,
      "heapUsedBytes": 88037252,
      "domNodes": -272,
      "jsHeapTotalBytes": 225280,
      "scriptDurationMs": 813.2270000000001,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3543.461999999977,
      "styleRecalcs": 62,
      "styleRecalcDurationMs": 15.016000000000002,
      "layouts": 60,
      "layoutDurationMs": 11.903,
      "taskDurationMs": 1772.4370000000001,
      "heapDeltaBytes": -6894180,
      "heapUsedBytes": 71866716,
      "domNodes": -255,
      "jsHeapTotalBytes": -630784,
      "scriptDurationMs": 785.898,
      "eventListeners": -188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3549.523000000022,
      "styleRecalcs": 61,
      "styleRecalcDurationMs": 10.571,
      "layouts": 60,
      "layoutDurationMs": 11.981,
      "taskDurationMs": 1713.788,
      "heapDeltaBytes": -10138208,
      "heapUsedBytes": 68134060,
      "domNodes": -289,
      "jsHeapTotalBytes": 4349952,
      "scriptDurationMs": 764.436,
      "eventListeners": -198,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3197.9560000000333,
      "styleRecalcs": 42,
      "styleRecalcDurationMs": 6.547000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1998.0090000000002,
      "heapDeltaBytes": 5748692,
      "heapUsedBytes": 86175296,
      "domNodes": -285,
      "jsHeapTotalBytes": 49152,
      "scriptDurationMs": 975.2579999999999,
      "eventListeners": -10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666636,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3043.4830000000375,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 4.871,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1937.8899999999999,
      "heapDeltaBytes": 18012140,
      "heapUsedBytes": 86293176,
      "domNodes": 0,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 979.678,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666636,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2059.2100000000073,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 9.162,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 614.047,
      "heapDeltaBytes": 8063196,
      "heapUsedBytes": 85422884,
      "domNodes": -271,
      "jsHeapTotalBytes": -1679360,
      "scriptDurationMs": 31.705,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2048.0680000000575,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 3.6259999999999972,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 579.0249999999999,
      "heapDeltaBytes": 10099716,
      "heapUsedBytes": 87296420,
      "domNodes": -273,
      "jsHeapTotalBytes": -1941504,
      "scriptDurationMs": 34.098000000000006,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 572.5970000000302,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 10.327,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 407.11999999999995,
      "heapDeltaBytes": 15040256,
      "heapUsedBytes": 88163072,
      "domNodes": 20,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 140.815,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 596.2920000000622,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 10.131,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 396.519,
      "heapDeltaBytes": 15003528,
      "heapUsedBytes": 87963812,
      "domNodes": 18,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 136.53699999999998,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2023.477000000014,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.758999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 488.187,
      "heapDeltaBytes": -7159144,
      "heapUsedBytes": 64946552,
      "domNodes": -295,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 7.8900000000000015,
      "eventListeners": -240,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2015.8089999999902,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.801000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 487.18500000000006,
      "heapDeltaBytes": -9371332,
      "heapUsedBytes": 62647036,
      "domNodes": -296,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 7.8039999999999985,
      "eventListeners": -240,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1706.6469999999754,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 28.337999999999997,
      "layouts": 18,
      "layoutDurationMs": 5.247,
      "taskDurationMs": 808.55,
      "heapDeltaBytes": 6101500,
      "heapUsedBytes": 71920768,
      "domNodes": -296,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 109.77000000000001,
      "eventListeners": -212,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1724.5320000000106,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 27.352,
      "layouts": 18,
      "layoutDurationMs": 5.114,
      "taskDurationMs": 832.7379999999999,
      "heapDeltaBytes": -894064,
      "heapUsedBytes": 72072388,
      "domNodes": -296,
      "jsHeapTotalBytes": 6545408,
      "scriptDurationMs": 114.059,
      "eventListeners": -242,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1417.3069999999939,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 32.24999999999999,
      "layouts": 14,
      "layoutDurationMs": 15.208000000000002,
      "taskDurationMs": 941.3450000000001,
      "heapDeltaBytes": 22011316,
      "heapUsedBytes": 105837024,
      "domNodes": 13751,
      "jsHeapTotalBytes": 10747904,
      "scriptDurationMs": 31.073999999999998,
      "eventListeners": 2385,
      "totalBlockingTimeMs": 142,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8500.13899999999,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 35.768,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5791.374999999999,
      "heapDeltaBytes": 13121772,
      "heapUsedBytes": 89522084,
      "domNodes": -266,
      "jsHeapTotalBytes": -1978368,
      "scriptDurationMs": 2680.065,
      "eventListeners": -176,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8333.169999999995,
      "styleRecalcs": 247,
      "styleRecalcDurationMs": 33.527,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5844.6810000000005,
      "heapDeltaBytes": -18239120,
      "heapUsedBytes": 85103376,
      "domNodes": -267,
      "jsHeapTotalBytes": -1417216,
      "scriptDurationMs": 2687.855,
      "eventListeners": -148,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17079.117999999995,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16584.305999999997,
      "heapDeltaBytes": -34103268,
      "heapUsedBytes": 177052168,
      "domNodes": -8068,
      "jsHeapTotalBytes": -15368192,
      "scriptDurationMs": 316.381,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17365.77299999999,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16739.644,
      "heapDeltaBytes": -39399064,
      "heapUsedBytes": 177599412,
      "domNodes": -8068,
      "jsHeapTotalBytes": -11022336,
      "scriptDurationMs": 281.31500000000005,
      "eventListeners": -14933,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.77333333333336,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 20647.223000000053,
      "styleRecalcs": 170,
      "styleRecalcDurationMs": 16.670999999999992,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20292.911,
      "heapDeltaBytes": -28855992,
      "heapUsedBytes": 188976692,
      "domNodes": -8068,
      "jsHeapTotalBytes": -13471744,
      "scriptDurationMs": 877.163,
      "eventListeners": -14925,
      "totalBlockingTimeMs": 21,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21352.593999999954,
      "styleRecalcs": 177,
      "styleRecalcDurationMs": 17.311999999999994,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 21012.183999999997,
      "heapDeltaBytes": -59048440,
      "heapUsedBytes": 168655964,
      "domNodes": -8068,
      "jsHeapTotalBytes": -18767872,
      "scriptDurationMs": 956.0240000000001,
      "eventListeners": -14927,
      "totalBlockingTimeMs": 69,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6215.495999999974,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 76.73200000000003,
      "layouts": 20,
      "layoutDurationMs": 22.650000000000002,
      "taskDurationMs": 6101.856000000001,
      "heapDeltaBytes": -52286932,
      "heapUsedBytes": 175863384,
      "domNodes": -8068,
      "jsHeapTotalBytes": 4562944,
      "scriptDurationMs": 115.815,
      "eventListeners": -14927,
      "totalBlockingTimeMs": 452,
      "frameDurationMs": 17.776666666666703,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6226.419000000078,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 77.22099999999999,
      "layouts": 20,
      "layoutDurationMs": 21.98199999999999,
      "taskDurationMs": 6107.167,
      "heapDeltaBytes": -38162992,
      "heapUsedBytes": 179218136,
      "domNodes": -8068,
      "jsHeapTotalBytes": 12623872,
      "scriptDurationMs": 108.742,
      "eventListeners": -14929,
      "totalBlockingTimeMs": 419,
      "frameDurationMs": 17.776666666666703,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8490.470999999958,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8322.53,
      "heapDeltaBytes": 19303568,
      "heapUsedBytes": 178146588,
      "domNodes": 0,
      "jsHeapTotalBytes": -12058624,
      "scriptDurationMs": 134.9389999999999,
      "eventListeners": -14,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8610.125999999924,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8397.989000000001,
      "heapDeltaBytes": 12440060,
      "heapUsedBytes": 176768708,
      "domNodes": 0,
      "jsHeapTotalBytes": -18612224,
      "scriptDurationMs": 180.728,
      "eventListeners": -16,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 459.63599999998905,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 25.103,
      "layouts": 3,
      "layoutDurationMs": 1.262,
      "taskDurationMs": 111.57600000000001,
      "heapDeltaBytes": 4889452,
      "heapUsedBytes": 72810296,
      "domNodes": 147,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 7.869999999999998,
      "eventListeners": 65,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 89.34799999997267,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 12.907,
      "layouts": 2,
      "layoutDurationMs": 0.8920000000000001,
      "taskDurationMs": 67.408,
      "heapDeltaBytes": 3117188,
      "heapUsedBytes": 71471156,
      "domNodes": 130,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 6.069999999999999,
      "eventListeners": 33,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    }
  ]
}

🔬 E2E Coverage

Metric Covered Total Pct
Lines 50275 75372 66.7% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.4% 1159
src/LGraphNode.ts 69.5% 390
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/platform/workspace/stores/billingOperationStore.ts 7.9% 313
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/LGraph.ts 78.3% 264
src/platform/workspace/stores/teamWorkspaceStore.ts 37.7% 261
src/scripts/app.ts 71.6% 257
src/scripts/pnginfo.ts 21.4% 221

@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Sep 22, 2026
@codecov

codecov Bot commented Sep 22, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.36145% with 8 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/stores/nodeDataStore.ts 88.67% 6 Missing ⚠️
.../workbench/extensions/agent/crdt/graphMutations.ts 93.33% 2 Missing ⚠️
@@              Coverage Diff              @@
##             cloud/1.54   #18340   +/-   ##
=============================================
  Coverage              ?   83.56%           
=============================================
  Files                 ?     2094           
  Lines                 ?   123683           
  Branches              ?    31302           
=============================================
  Hits                  ?   103357           
  Misses                ?    20148           
  Partials              ?      178           
Flag Coverage Δ
e2e 66.71% <2.50%> (?)
unit 78.50% <97.40%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../workbench/extensions/agent/crdt/graphMutations.ts 94.38% <93.33%> (ø)
src/stores/nodeDataStore.ts 93.10% <88.67%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@christian-byrne
christian-byrne merged commit a90d087 into cloud/1.54 Sep 22, 2026
91 checks passed
@christian-byrne
christian-byrne deleted the backport-18279-to-cloud-1.54 branch September 22, 2026 06:31
christian-byrne pushed a commit that referenced this pull request Sep 22, 2026
…t workflow connections after dynamic input reordering (#18393)

## Summary

Backport #17221 to `cloud/1.54` so agent-loaded workflows keep
connections on their named inputs after dynamic input reordering. Fixes
[PM-993](https://linear.app/comfy-org/issue/PM-993).

## Changes

- Preserve the original runtime patch and its CRDT/store regressions.
Prerequisite #18340 is already merged into the release base
(`64fe8c172f`).
- Adapt the MiniMax-style browser regression to the release branch's
existing `HostDoc` and agent boot fixtures, retaining the
connect/save/reopen assertions without importing main's conversation
replay harness.
- Resolve release-specific imports and keep its ADR index entries. No
package or lockfile changes.

## Review Focus

Release test-fixture adaptation. Original limitations remain:
authoritative snapshots can replace runtime slot objects; producer-side
addressing is out of scope.

Validation: input-order regressions fail 2/2 on the release baseline and
pass with the backport; related CRDT/store suites pass (50 files, 770
passed, 2 expected failures). App/browser typechecks, full lint,
formatting, Knip, ADR validation and commit hooks passed. Browser tests
were not executed locally.

CI on `80fb9c3cb3` completed with no failures or pending checks. Cloud
browser suite: 215 passed, 2 skipped, 0 flaky;
`minimaxAutogrowReload.spec.ts` passed on its first attempt (retry 0).
Unit coverage, browser matrix, ecosystem and lint checks passed.
@DrJKL DrJKL added agent Comfy Agent product, integration, tests or product documentation agent-backport Agent changes targeting a stable cloud/core release branch agent-crdt Agent document synchronization, graph projection or CRDT operations agent-test-unit Touches Agent-related unit/component tests or their support labels Sep 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent Comfy Agent product, integration, tests or product documentation agent-backport Agent changes targeting a stable cloud/core release branch agent-crdt Agent document synchronization, graph projection or CRDT operations agent-test-unit Touches Agent-related unit/component tests or their support backport Backporting a PR onto a release candidate cloud/1.54 Backport PRs for cloud 1.54 risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants