Repository navigation
test: cover the connected widget row keeping its label in Vue nodes - #18123
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 2039 passed, 0 failed · 2 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle: 9.92 MB gzip ⚪ 0 BDetailsSummary
Category Glance App Entry Points — 3.77 kB (baseline 3.77 kB) • ⚪ 0 BMain entry bundles and manifests Status: 1 unchanged Graph Workspace — 1.45 MB (baseline 1.45 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration Status: 3 unchanged Views & Navigation — 132 kB (baseline 132 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 18 unchanged Panels & Settings — 637 kB (baseline 637 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 27 unchanged User & Accounts — 37.9 kB (baseline 37.9 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 11 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 8 unchanged UI Components — 124 kB (baseline 124 kB) • ⚪ 0 BReusable component library chunks Status: 16 unchanged Data & Services — 3.86 MB (baseline 3.86 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 16 unchanged Utilities & Hooks — 566 kB (baseline 566 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 38 unchanged Vendor & Third-Party — 17.4 MB (baseline 17.4 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 17.7 MB (baseline 17.7 MB) • ⚪ 0 BBundles that do not match a named category Status: 298 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-19T21:47:01.421Z",
"gitSha": "14219f7c05da6f17b95f9d86de9d5c933d0691f6",
"branch": "fix/widget-grid-standalone-row-label",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2036.4400000000273,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.962999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 500.904,
"heapDeltaBytes": 11086616,
"heapUsedBytes": 72687072,
"domNodes": -266,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 8.795000000000003,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2001.7350000000533,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.947,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 474.75499999999994,
"heapDeltaBytes": 7368000,
"heapUsedBytes": 69451080,
"domNodes": -266,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 9.917000000000002,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1799.4669999999928,
"styleRecalcs": 75,
"styleRecalcDurationMs": 28.067,
"layouts": 14,
"layoutDurationMs": 4.126,
"taskDurationMs": 845.237,
"heapDeltaBytes": 11257008,
"heapUsedBytes": 73230620,
"domNodes": -262,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 164.15,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1808.4460000000036,
"styleRecalcs": 74,
"styleRecalcDurationMs": 28.580000000000002,
"layouts": 14,
"layoutDurationMs": 4.2170000000000005,
"taskDurationMs": 772.467,
"heapDeltaBytes": 13839276,
"heapUsedBytes": 75446668,
"domNodes": -266,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 166.568,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1709.399000000019,
"styleRecalcs": 30,
"styleRecalcDurationMs": 16.916,
"layouts": 6,
"layoutDurationMs": 1.194,
"taskDurationMs": 373.90000000000003,
"heapDeltaBytes": 2075400,
"heapUsedBytes": 63303912,
"domNodes": 74,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 14.043,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1724.6900000000096,
"styleRecalcs": 32,
"styleRecalcDurationMs": 15.564,
"layouts": 6,
"layoutDurationMs": 1.2010000000000003,
"taskDurationMs": 325.03499999999997,
"heapDeltaBytes": 2107128,
"heapUsedBytes": 64307916,
"domNodes": 75,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 11.024,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 616.0029999999779,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.547999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 437.11199999999997,
"heapDeltaBytes": 18181348,
"heapUsedBytes": 80231712,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 163.382,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 637.7559999999676,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.240000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 444.33199999999994,
"heapDeltaBytes": 17453404,
"heapUsedBytes": 78360648,
"domNodes": 16,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 164.77700000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2042.2940000000267,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.359999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 586.5530000000001,
"heapDeltaBytes": 2448160,
"heapUsedBytes": 82496868,
"domNodes": -248,
"jsHeapTotalBytes": -794624,
"scriptDurationMs": 38.785,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2016.1679999999933,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.772999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 546.501,
"heapDeltaBytes": 2287964,
"heapUsedBytes": 82223876,
"domNodes": -253,
"jsHeapTotalBytes": -1318912,
"scriptDurationMs": 34.899000000000015,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2365.7380000000217,
"styleRecalcs": 63,
"styleRecalcDurationMs": 9.028,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1676.1390000000001,
"heapDeltaBytes": 18046636,
"heapUsedBytes": 82629832,
"domNodes": 2,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 857,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2220.5690000000686,
"styleRecalcs": 65,
"styleRecalcDurationMs": 10.004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1583.7719999999997,
"heapDeltaBytes": 14776592,
"heapUsedBytes": 78533168,
"domNodes": -254,
"jsHeapTotalBytes": 749568,
"scriptDurationMs": 819.8240000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-zoom",
"durationMs": 3718.4090000000083,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.664000000000003,
"layouts": 60,
"layoutDurationMs": 14.033,
"taskDurationMs": 1797.5079999999998,
"heapDeltaBytes": 8276788,
"heapUsedBytes": 73987584,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 834.203,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3523.2039999999643,
"styleRecalcs": 60,
"styleRecalcDurationMs": 9.836999999999998,
"layouts": 60,
"layoutDurationMs": 13.153000000000002,
"taskDurationMs": 1683.5389999999998,
"heapDeltaBytes": 8110740,
"heapUsedBytes": 73893712,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 790.331,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3175.2449999999612,
"styleRecalcs": 41,
"styleRecalcDurationMs": 5.958999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1991.7420000000002,
"heapDeltaBytes": 18175388,
"heapUsedBytes": 84090268,
"domNodes": 2,
"jsHeapTotalBytes": 942080,
"scriptDurationMs": 1006.9430000000001,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3122.8760000000193,
"styleRecalcs": 41,
"styleRecalcDurationMs": 6.076000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1908.9850000000001,
"heapDeltaBytes": 22726412,
"heapUsedBytes": 88981880,
"domNodes": 2,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 982.8330000000001,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2005.1579999999944,
"styleRecalcs": 2,
"styleRecalcDurationMs": 2.0680000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 555.335,
"heapDeltaBytes": 19710108,
"heapUsedBytes": 83997548,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 38.289,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2057.199999999966,
"styleRecalcs": 6,
"styleRecalcDurationMs": 6.254,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 586.836,
"heapDeltaBytes": -5690668,
"heapUsedBytes": 81327552,
"domNodes": -255,
"jsHeapTotalBytes": -233472,
"scriptDurationMs": 38.188,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 560.1399999999899,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.752,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 380.398,
"heapDeltaBytes": 13670128,
"heapUsedBytes": 76831836,
"domNodes": 20,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 147.06900000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 568.7189999999873,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.559000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 397.60100000000006,
"heapDeltaBytes": 13105028,
"heapUsedBytes": 76427904,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 142.69,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 1995.9089999999833,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.194000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 446.66900000000004,
"heapDeltaBytes": 15865992,
"heapUsedBytes": 79331384,
"domNodes": -278,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 7.117000000000002,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2001.3270000000603,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.424,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 452.6170000000001,
"heapDeltaBytes": 7961116,
"heapUsedBytes": 71292268,
"domNodes": -278,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 7.893999999999998,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1706.2779999999975,
"styleRecalcs": 76,
"styleRecalcDurationMs": 27.781,
"layouts": 18,
"layoutDurationMs": 5.439,
"taskDurationMs": 822.673,
"heapDeltaBytes": -61900,
"heapUsedBytes": 63178940,
"domNodes": -278,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 117.79799999999999,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1691.4560000000165,
"styleRecalcs": 76,
"styleRecalcDurationMs": 27.907,
"layouts": 18,
"layoutDurationMs": 5.640000000000001,
"taskDurationMs": 784.6310000000001,
"heapDeltaBytes": -1429084,
"heapUsedBytes": 61204544,
"domNodes": -280,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 111.619,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1366.4530000000923,
"styleRecalcs": 17,
"styleRecalcDurationMs": 30.823999999999998,
"layouts": 5,
"layoutDurationMs": 13.574,
"taskDurationMs": 921.0450000000001,
"heapDeltaBytes": -6401748,
"heapUsedBytes": 81207848,
"domNodes": 13587,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 32.30800000000001,
"eventListeners": 2383,
"totalBlockingTimeMs": 149,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8570.470000000001,
"styleRecalcs": 248,
"styleRecalcDurationMs": 38.290000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6058.615000000001,
"heapDeltaBytes": -9934488,
"heapUsedBytes": 75335780,
"domNodes": -249,
"jsHeapTotalBytes": -270336,
"scriptDurationMs": 2857.926,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8359.700999999972,
"styleRecalcs": 248,
"styleRecalcDurationMs": 36.224000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5885.512000000001,
"heapDeltaBytes": -12028796,
"heapUsedBytes": 68285172,
"domNodes": -249,
"jsHeapTotalBytes": 3923968,
"scriptDurationMs": 2904.8399999999997,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17206.106999999975,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16766.722999999998,
"heapDeltaBytes": -51874604,
"heapUsedBytes": 183494840,
"domNodes": -8061,
"jsHeapTotalBytes": -14483456,
"scriptDurationMs": 269.31,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17599.72800000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16876.501,
"heapDeltaBytes": -59353764,
"heapUsedBytes": 172428404,
"domNodes": -8061,
"jsHeapTotalBytes": -9285632,
"scriptDurationMs": 272.55800000000005,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 21002.76500000001,
"styleRecalcs": 165,
"styleRecalcDurationMs": 17.691999999999986,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20741.694,
"heapDeltaBytes": -26648440,
"heapUsedBytes": 189906208,
"domNodes": -8065,
"jsHeapTotalBytes": -13770752,
"scriptDurationMs": 905.152,
"eventListeners": -14928,
"totalBlockingTimeMs": 118,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 20552.485000000048,
"styleRecalcs": 161,
"styleRecalcDurationMs": 16.960000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20194.108,
"heapDeltaBytes": -41136344,
"heapUsedBytes": 190278312,
"domNodes": -8061,
"jsHeapTotalBytes": -13287424,
"scriptDurationMs": 857.629,
"eventListeners": -14928,
"totalBlockingTimeMs": 98,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 6236.960999999951,
"styleRecalcs": 20,
"styleRecalcDurationMs": 76.19600000000001,
"layouts": 20,
"layoutDurationMs": 23.261000000000003,
"taskDurationMs": 6165.017,
"heapDeltaBytes": -54330828,
"heapUsedBytes": 175697416,
"domNodes": -8061,
"jsHeapTotalBytes": 10948608,
"scriptDurationMs": 127.029,
"eventListeners": -14928,
"totalBlockingTimeMs": 433,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 6243.242000000009,
"styleRecalcs": 20,
"styleRecalcDurationMs": 98.587,
"layouts": 20,
"layoutDurationMs": 29.51899999999999,
"taskDurationMs": 6084.682000000001,
"heapDeltaBytes": -55935592,
"heapUsedBytes": 174645344,
"domNodes": -8061,
"jsHeapTotalBytes": 8581120,
"scriptDurationMs": 107.757,
"eventListeners": -14927,
"totalBlockingTimeMs": 601,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8582.248999999934,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8368.124,
"heapDeltaBytes": -17661644,
"heapUsedBytes": 170084164,
"domNodes": 0,
"jsHeapTotalBytes": -15466496,
"scriptDurationMs": 135.11699999999993,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8830.553000000009,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8443.574999999999,
"heapDeltaBytes": -11464204,
"heapUsedBytes": 169572716,
"domNodes": 0,
"jsHeapTotalBytes": -25952256,
"scriptDurationMs": 134.30199999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 494.20500000007905,
"styleRecalcs": 18,
"styleRecalcDurationMs": 24.512,
"layouts": 5,
"layoutDurationMs": 2.183,
"taskDurationMs": 139.5,
"heapDeltaBytes": 5253236,
"heapUsedBytes": 66866392,
"domNodes": 147,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 17.616,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 108.80799999995361,
"styleRecalcs": 7,
"styleRecalcDurationMs": 15.662000000000003,
"layouts": 3,
"layoutDurationMs": 1.65,
"taskDurationMs": 84.13700000000001,
"heapDeltaBytes": 3012676,
"heapUsedBytes": 64610104,
"domNodes": 126,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 8.102,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #18123 +/- ##
==========================================
+ Coverage 82.78% 83.81% +1.03%
==========================================
Files 2940 2245 -695
Lines 144690 127683 -17007
Branches 37236 32488 -4748
==========================================
- Hits 119778 107022 -12756
+ Misses 23638 20372 -3266
+ Partials 1274 289 -985
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Playwright videos for new testsDownload the recorded videos and HTML report Recorded projects: chromium Recorded test titles:
|
|
Updating Playwright Expectations |
ad7fcdc to
c06170e
Compare
In Vue nodes, wiring a PrimitiveInt into a widget input used to collapse the row to a bare slot dot, on plain nodes and subgraph hosts alike, while the legacy canvas keeps the row and its name. #17576 restored the label; this Playwright test pins it for a plain EmptyLatentImage and a promoted subgraph host input.
The link interactions test asserts a vue-io-highlight.png screenshot but carried no @screenshot tag, so the expectation-update workflow, which selects tests by that tag, could not regenerate its baseline.
c06170e to
d614674
Compare
christian-byrne
left a comment
There was a problem hiding this comment.
The connected-row regression cases pass for plain nodes and promoted subgraph inputs. This is test coverage for an already-landed fix, not a new product fix.
Full context for agent readers
Reviewed the fixture, both real slot-drag cases, connection polling, visible label/dot assertions and the screenshot tag change at the submitted head. No blocking findings. Independently ran both new Chromium cases on Node 26.8.2 against the isolated frontend and existing test backend: two passed. Browser typechecking, targeted formatting and lint passed in the earlier run; the neighboring link-interaction screenshot case passed against the unchanged baseline. The earlier broad browser attempt failed during settings setup with HTTP 405 and is not acceptance evidence.
The source behavior landed in the connected-row fix. The closed original reproduction also described textarea suppression and undo/redo drift; this PR does not claim to fix those separate behaviors. Release qualification and native provenance remain owned by the completion lane in the program task board, task claude-handoff-12 (connected-label acceptance and releases). Neither release target is qualified by this review.
Glossary: promoted input is an inner-node control exposed on its containing subgraph; regression coverage checks that an existing fix stays fixed.
## Summary Seventeen non-billing Agent sources are carried for `core/1.54`. Exact-head hosted checks and target-native replay acceptance pass; review remains. <details><summary>Full context for agent readers</summary> ## Changes - **Sources**: [18113](#18113), [18096](#18096), [18122](#18122), [18164](#18164), [18121](#18121), [18148](#18148), [18111](#18111), [18174](#18174), [17912](#17912), [18081](#18081), [16936](#16936), [18183](#18183), [18197](#18197), [18070](#18070), [18084](#18084), [18071](#18071), and [18107](#18107). - **New in this head**: PR 18107 rejects incompatible Agent-created links, retires incompatible retained links from the local projection, and keeps one bad link from blocking unrelated later edits. Main-only Load3D coverage is adapted onto the release-local unit, `HostDoc`, and tab-return harnesses. - **Dependencies**: no new package dependency; release lockfile pins are preserved. - **Exclusions**: billing/account work, protected source [17730](#17730), target-specific screenshot source [18168](#18168), separately owned focused carriers, and [18123](#18123), whose generic Vue-node test depends on [17576](#17576), absent from this release line. ## Review focus - PR 16936 adapts widget-state rebinding to the 1.54 store API without importing `main`'s newer visibility architecture. - PR 18070 runs target-local live widget projection callbacks with the canvas and owner node while retaining the release projection boundary. - PR 18084 adds placement as a renderer-owned port; resync materializations retain document coordinates, while new offscreen batches move together beside existing content. - The release browser harness seeds the same client-only API-node colors that normal node registration owns before testing whether a later CRDT reconcile preserves them. - This is not behavioral acceptance, deployment authorization, or a merge-check waiver. ## Exact-head verification Current head: `2bd4dace2e6207fede11d2ac219d691a811769dc`, verified under Node 25.9.0 and pnpm 11.13.1. - main typecheck passed with an 8 GiB heap at the production-identical parent; this head changes only the browser harness lifecycle; - the prior 146-test selection passed with 1 expected failure; - after repairing idempotent replay, 119 focused tests passed with 1 expected failure; - the exact head passes browser typecheck and adds a target-native check that the missing checkpoint value and `aria-invalid=true` survive tab return; - ancestor head `bd7da3cffd6dc349e1c48c5a277bc112cabd0e41` passed one zero-retry target-native warning-retention case with an inspected final frame; its [durable QA receipt](https://github.com/christian-byrne/in-app-agent-program/blob/7fa0ba4d731f00684388a45f1aeb1d24dc6f2280/reports/pr-ownership/2026-09-20-missing-model-tab-warning.md#1145-utc-exact-core-native-case-passes-final-warning-frame-inspected) is ancestry evidence, not acceptance of this newer head; - frozen installation and main typecheck pass at the production-identical parent; browser typecheck, target-native browser collection, formatting, ESLint, fixture mint/projection, and diff checks pass at this exact head; - the extended browser case commits pasted-node operations through the real `HostDoc` and asserts the pasted position survives another tab retarget; - parent head `389a3718bd2f637f704bde349068cbfd87cd9542` passed warning, node-presentation, and viewport assertions but stopped before paste because the zoom popup backdrop intercepted node selection; this head closes the popup through its real toggle and asserts it hidden before selection; - the first PR 18107 browser head stopped before app boot because the force-input string sink serialized one widget value while declaring no widgets; this head removes that non-widget value, and the exact fixture contract now mints and projects successfully; - parent head `366e0287095876351377f873688fece88eb90397` reached local paste but had already closed the Agent panel, which unmounted `AgentPanelRoot`, detached mint-port wiring, and disposed the CRDT follower; this head preserves the closed-panel screenshot, then reopens the panel and requires a fresh workflow subscription before mutation while retaining the unchanged `HostDoc` assertion; - one zero-retry target-native invocation passed the complete case at 13:44:02 UTC: warning retention, node presentation, popup closure, fresh subscription, local and host paste position after a second retarget, incompatible-link retirement, and the subsequent Agent edit; the [durable QA receipt](https://github.com/christian-byrne/in-app-agent-program/blob/28f5a4bb05318cc4e1a95d819951f7924bf9d2c2/reports/pr-ownership/2026-09-20-missing-model-tab-warning.md#1345-utc-both-lifecycle-corrected-candidates-pass-the-complete-native-case) includes inspected frames and cleanup; - PR 18107's exact-head focused coverage passes 63 tests with 1 expected failure; main and browser typechecks, targeted formatting and ESLint, and three affected Cloud-project browser cases also collect successfully; - targeted format and ESLint passed; - three affected Cloud-project browser cases collected successfully. Exact-head hosted checks and target-native replay acceptance pass. Review and the release-target merge-readiness gate remain required before merge. No deployment or check waiver is authorized. </details> Justification: Authorized Agent 1.54 release backport aggregate merged without standing human approval under the published release-backport authority; exact-head hosted checks, target-native replay acceptance, target-aware merge guard, adaptation review, and absence of unresolved human objections limit risk. --------- Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> Co-authored-by: uytieu <uytieu@users.noreply.github.com> Co-authored-by: jaeone94 <89377375+jaeone94@users.noreply.github.com>
## Summary Seventeen non-billing Agent sources are carried for `cloud/1.54`. The candidate now contains release `1.54.12`; fresh hosted checks and target-native replay acceptance passed. <details><summary>Full context for agent readers</summary> ## Changes - **Sources**: [18113](#18113), [18096](#18096), [18122](#18122), [18164](#18164), [18121](#18121), [18148](#18148), [18111](#18111), [18174](#18174), [17912](#17912), [18081](#18081), [16936](#16936), [18183](#18183), [18197](#18197), [18070](#18070), [18084](#18084), [18071](#18071), and [18107](#18107). - **New in this head**: PR 18107 rejects incompatible Agent-created links, retires incompatible retained links from the local projection, and keeps one bad link from blocking unrelated later edits. Main-only Load3D coverage is adapted onto the release-local unit, `HostDoc`, and tab-return harnesses. - **Dependencies**: no new package dependency; release lockfile pins are preserved. - **Exclusions**: billing/account work, protected source [17730](#17730), target-specific screenshot source [18168](#18168), separately owned focused carriers, and [18123](#18123), whose generic Vue-node test depends on [17576](#17576), absent from this release line. ## Review focus - PR 16936 adapts widget-state rebinding to the 1.54 store API without importing `main`'s newer visibility architecture. - PR 18070 runs target-local live widget projection callbacks with the canvas and owner node while retaining the release projection boundary. - PR 18084 adds placement as a renderer-owned port; resync materializations retain document coordinates, while new offscreen batches move together beside existing content. - The release browser harness seeds the same client-only API-node colors that normal node registration owns before testing whether a later CRDT reconcile preserves them. - This is not behavioral acceptance, deployment authorization, or a merge-check waiver. ## Exact-head verification Current head: `aabd82168d2d7b2f1b9f685a5477dcdc491d3b02`, verified locally under Node 25.9.0 and pnpm 11.13.1. - merged current `cloud/1.54` tip `d2667baf6bdb8664821b4bed7a7f5a1df65f9f49` cleanly; the imported release delta is limited to the package version and locale data; - frozen installation, 174 focused Agent/missing-model tests with 1 expected failure, main and browser typechecks, formatting, full ESLint with zero errors, the Cloud production build, target ancestry, and diff checks pass locally; - fresh exact-head hosted checks and one zero-retry target-native replay passed after the release target changed; - main typecheck passed with an 8 GiB heap at the production-identical parent; this head changes only the browser harness lifecycle; - the prior 146-test selection passed with 1 expected failure; - after repairing idempotent replay, 119 focused tests passed with 1 expected failure; - the exact head passes browser typecheck and adds a target-native check that the missing checkpoint value and `aria-invalid=true` survive tab return; - frozen installation and main typecheck pass at the production-identical parent; browser typecheck, target-native browser collection, formatting, ESLint, fixture mint/projection, and diff checks pass at this exact head; - the extended browser case commits pasted-node operations through the real `HostDoc` and asserts the pasted position survives another tab retarget; - parent head `dfe99947cffb5f31c5f4750113eb9770720e5eac` passed warning, node-presentation, and viewport assertions but stopped before paste because the zoom popup backdrop intercepted node selection; this head closes the popup through its real toggle and asserts it hidden before selection; - the first PR 18107 browser head stopped before app boot because the force-input string sink serialized one widget value while declaring no widgets; this head removes that non-widget value, and the exact fixture contract now mints and projects successfully; - parent head `5ec6c64e9b78b56b12350ae732dc1e1ea20052e0` reached local paste but had already closed the Agent panel, which unmounted `AgentPanelRoot`, detached mint-port wiring, and disposed the CRDT follower; this head preserves the closed-panel screenshot, then reopens the panel and requires a fresh workflow subscription before mutation while retaining the unchanged `HostDoc` assertion; - one zero-retry target-native invocation passed the complete case at 13:45:15 UTC: warning retention, node presentation, popup closure, fresh subscription, local and host paste position after a second retarget, incompatible-link retirement, and the subsequent Agent edit; the [durable QA receipt](https://github.com/christian-byrne/in-app-agent-program/blob/28f5a4bb05318cc4e1a95d819951f7924bf9d2c2/reports/pr-ownership/2026-09-20-missing-model-tab-warning.md#1345-utc-both-lifecycle-corrected-candidates-pass-the-complete-native-case) includes inspected frames and cleanup; - PR 18107's exact-head focused coverage passes 63 tests with 1 expected failure; main and browser typechecks, targeted formatting and ESLint, and three affected Cloud-project browser cases also collect successfully; - targeted format and ESLint passed; - three affected Cloud-project browser cases collected successfully. The prior replay receipt remains historical evidence for parent head `516f6b5f71e251b25985fb61715432f05249c4bd`. Fresh hosted checks and the fresh target-native replay passed at current head `aabd82168d2d7b2f1b9f685a5477dcdc491d3b02`; adaptation review and the release-target merge-readiness gate also passed. </details> Justification: Author-owned release aggregate merged under the published Agent 1.54 backport grant after exact-head hosted checks, target-native replay, adaptation review, target ancestry, and the target-aware merge guard passed; no independent approval was available. --------- Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> Co-authored-by: uytieu <uytieu@users.noreply.github.com> Co-authored-by: jaeone94 <89377375+jaeone94@users.noreply.github.com>
Requested by Christian Byrne · Slack thread
ELI5
When a wire takes over a node's input, the input's own control steps aside, but its name tag should stay so you can still tell which input the wire feeds. Vue nodes used to take the name tag away too, leaving a bare dot. #17576 fixed that on main; this PR adds the browser test that proves it stays fixed, and lets the screenshot workflow regenerate the one baseline that moved.
Motivation
In Vue nodes, wiring a
PrimitiveIntinto thewidthinput of a subgraph host or a plainEmptyLatentImagecollapsed the row to an unlabeled dot, so the node readtext, then straight toheight, and the report described the widget as having vanished. The legacy canvas keeps the row and its name for a connection-suppressed widget (occupiesCanvasRow), so this was a renderer parity gap on every plain node, not a subgraph bug. The repro landed astest.fail()rows in #18085; this PR converts them into a real regression test.What is in this PR after rebasing onto #17576
This PR originally patched
WidgetGrid.vuewith:dot-only="!row.standalone". #17576 landed first with:dot-only="row.showsControl"plus the forwardedlabel; sincestandaloneis!showsControl && suppressedByConnection, that already covers the connection-suppressed row (and additionally labels converted-widget rows), and its unit test asserts the label text directly. Both source commits were dropped in the rebase as already upstream. What remains:browser_tests/tests/vueNodes/widgets/connectedWidgetRowLabel.spec.ts+ fixturesubgraph-promoted-int-text-with-primitives.json: wires aPrimitiveIntintowidthon a promoted subgraph host and on a plainEmptyLatentImage, then asserts thewidthlabel and the slot dot both stay visible.subgraphSlots.spec.ts"link interactions": tagged@screenshotso theNew Browser Test Expectationsworkflow can regenerate itsvue-io-highlight.pngbaseline. The baseline this branch regenerated was byte-identical to the one fix: retain labels for connected Vue node inputs #17576 merged, so that commit dropped too and the test runs against main's image.Provenance
pnpm typecheck(root plus account-core, billing-web, account-ui, billing-contract) exit 0;WidgetGrid.test.ts+InputSlot.test.ts: 2 files, 10 passed;oxfmt --checkandeslinton the changed files clean; pre-pushpnpm knippassed. Playwright coverage runs in CI on this head.fix:and unit-test commits were superseded by fix: retain labels for connected Vue node inputs #17576 during the rebase; the PR is test-only now.Reviewer context
test.fail()repros this replaces)Test plan
connectedWidgetRowLabel.spec.tspasses on both rows,vue-io-highlight.pngholds against main's baselinePrimitiveIntintoEmptyLatentImage.width: thewidthlabel stays next to the dot, the number control is gone, the wire lands on the dot; disconnect restores the control🤖 Generated with Claude Code
https://claude.ai/code/session_01JwD8PkozfznCoUwAG46WAg