Repository navigation
fix: hide the promoted textarea when its host input is connected - #18114
claude[bot] wants to merge 2 commits into
Conversation
Wiring a parent-graph String into a subgraph host's promoted multiline input leaves the textarea visible and editable, while the same wire into a plain CLIPTextEncode hides the control and leaves only the slot. The Vitest case pins the seam: the host DOM widget's connectionSuppressed flag never reaches the widget value store entry the Vue renderer reads.
The promoted multiline host widget is a DOMWidgetImpl that never goes through BaseWidget.setNodeId, so its visibility component stayed private and the connectionSuppressed flag set on link changes never reached the widget value store entry the Vue renderer reads. Bind the host widget to the store-owned visibility component after creation, the same swap setNodeId performs for ordinary widgets.
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ❌ 2025 passed, 8 failed · 1 flaky❌ Failed Tests📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle: 9.92 MB gzip 🔴 +163 BDetailsSummary
Category Glance App Entry Points — 3.77 kB (baseline 3.77 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.45 MB (baseline 1.45 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 132 kB (baseline 132 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 14 added / 14 removed / 4 unchanged Panels & Settings — 637 kB (baseline 637 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 17 unchanged User & Accounts — 37.9 kB (baseline 37.9 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 6 added / 6 removed / 5 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 1 unchanged UI Components — 124 kB (baseline 124 kB) • ⚪ 0 BReusable component library chunks
Status: 7 added / 7 removed / 9 unchanged Data & Services — 3.86 MB (baseline 3.86 MB) • 🔴 +340 BStores, services, APIs, and repositories
Status: 13 added / 13 removed / 3 unchanged Utilities & Hooks — 565 kB (baseline 565 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 19 added / 19 removed / 19 unchanged Vendor & Third-Party — 17.4 MB (baseline 17.4 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 17.7 MB (baseline 17.7 MB) • ⚪ 0 BBundles that do not match a named category
Status: 73 added / 73 removed / 224 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-19T06:14:39.637Z",
"gitSha": "fe0ee00d943d8d51be3ead6a0be9d30bb086b383",
"branch": "fix/promoted-textarea-connection-suppression",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2013.2399999999961,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.340999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 524.047,
"heapDeltaBytes": 8239020,
"heapUsedBytes": 70277748,
"domNodes": -264,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 11.552,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 1998.7059999999701,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.414999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 439.894,
"heapDeltaBytes": 3786164,
"heapUsedBytes": 65738084,
"domNodes": -263,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 7.8709999999999996,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2107.765000000029,
"styleRecalcs": 78,
"styleRecalcDurationMs": 39.491,
"layouts": 14,
"layoutDurationMs": 5.183,
"taskDurationMs": 1106.5100000000002,
"heapDeltaBytes": 12872700,
"heapUsedBytes": 74057364,
"domNodes": -266,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 211.787,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1762.1299999999565,
"styleRecalcs": 74,
"styleRecalcDurationMs": 26.905,
"layouts": 14,
"layoutDurationMs": 4.569,
"taskDurationMs": 832.5590000000001,
"heapDeltaBytes": -6436416,
"heapUsedBytes": 55417248,
"domNodes": -261,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 162.128,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1713.6610000000019,
"styleRecalcs": 31,
"styleRecalcDurationMs": 15.031,
"layouts": 6,
"layoutDurationMs": 1.035,
"taskDurationMs": 320.036,
"heapDeltaBytes": 1876804,
"heapUsedBytes": 63697136,
"domNodes": 76,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 10.587,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1723.194000000035,
"styleRecalcs": 32,
"styleRecalcDurationMs": 17.669999999999998,
"layouts": 6,
"layoutDurationMs": 1.2750000000000001,
"taskDurationMs": 379.24500000000006,
"heapDeltaBytes": 2011256,
"heapUsedBytes": 63188660,
"domNodes": 76,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 14.429,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 692.2190000000228,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.914000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 468.15399999999994,
"heapDeltaBytes": 18047484,
"heapUsedBytes": 79254700,
"domNodes": 16,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 170.326,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 620.1430000000983,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.348000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 441.73199999999997,
"heapDeltaBytes": 17837124,
"heapUsedBytes": 80208348,
"domNodes": 16,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 167.74699999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2032.4190000000044,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.771,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 545.4190000000001,
"heapDeltaBytes": 4129744,
"heapUsedBytes": 83667776,
"domNodes": -249,
"jsHeapTotalBytes": -270336,
"scriptDurationMs": 33.956,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2036.6720000000669,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.169,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 551.7979999999999,
"heapDeltaBytes": 1454600,
"heapUsedBytes": 82091508,
"domNodes": -247,
"jsHeapTotalBytes": -1806336,
"scriptDurationMs": 31.007000000000005,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2210.6359999999654,
"styleRecalcs": 67,
"styleRecalcDurationMs": 11.900000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1612.4099999999999,
"heapDeltaBytes": 14960928,
"heapUsedBytes": 78774924,
"domNodes": -250,
"jsHeapTotalBytes": 1011712,
"scriptDurationMs": 848.668,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2339.030999999977,
"styleRecalcs": 64,
"styleRecalcDurationMs": 9.977999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1549.6299999999999,
"heapDeltaBytes": 16365032,
"heapUsedBytes": 80401812,
"domNodes": -254,
"jsHeapTotalBytes": 1011712,
"scriptDurationMs": 907.661,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3513.2130000000075,
"styleRecalcs": 61,
"styleRecalcDurationMs": 10.394999999999998,
"layouts": 60,
"layoutDurationMs": 13.087,
"taskDurationMs": 1676.4999999999998,
"heapDeltaBytes": 9483424,
"heapUsedBytes": 74559480,
"domNodes": 2,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 780.654,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3632.3360000000093,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.209000000000003,
"layouts": 60,
"layoutDurationMs": 13.715000000000002,
"taskDurationMs": 1742.504,
"heapDeltaBytes": 11643008,
"heapUsedBytes": 78021552,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 805.434,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3044.3950000000086,
"styleRecalcs": 41,
"styleRecalcDurationMs": 5.952999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1856.4139999999998,
"heapDeltaBytes": 15287520,
"heapUsedBytes": 80722596,
"domNodes": -259,
"jsHeapTotalBytes": 942080,
"scriptDurationMs": 950.3190000000002,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3086.546999999996,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.919,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1930.7669999999998,
"heapDeltaBytes": 18623416,
"heapUsedBytes": 84422620,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 997.8159999999999,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2015.6600000000253,
"styleRecalcs": 5,
"styleRecalcDurationMs": 7.568000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 522.015,
"heapDeltaBytes": 19715496,
"heapUsedBytes": 83567656,
"domNodes": -252,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 32.885,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2016.4089999999533,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.2120000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 537.173,
"heapDeltaBytes": -4014648,
"heapUsedBytes": 83863640,
"domNodes": -249,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 36.026,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 579.9780000000396,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.797,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 398.97700000000003,
"heapDeltaBytes": 13499192,
"heapUsedBytes": 76741216,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 143.341,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 585.3670000000193,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.642,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 398.38300000000004,
"heapDeltaBytes": 13132988,
"heapUsedBytes": 76323128,
"domNodes": 18,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 138.763,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2015.7489999999711,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.508999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 471.29600000000005,
"heapDeltaBytes": -3404056,
"heapUsedBytes": 60103752,
"domNodes": -277,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 9.449000000000003,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2000.844999999913,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.598999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 451.009,
"heapDeltaBytes": 3152864,
"heapUsedBytes": 66356176,
"domNodes": -273,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 7.380000000000001,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1706.532999999979,
"styleRecalcs": 78,
"styleRecalcDurationMs": 28.070000000000004,
"layouts": 18,
"layoutDurationMs": 6.062,
"taskDurationMs": 792.2439999999999,
"heapDeltaBytes": 14028448,
"heapUsedBytes": 76932568,
"domNodes": -277,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 112.82400000000001,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1690.780000000018,
"styleRecalcs": 77,
"styleRecalcDurationMs": 26.299000000000003,
"layouts": 18,
"layoutDurationMs": 5.286,
"taskDurationMs": 790.1339999999999,
"heapDeltaBytes": 778748,
"heapUsedBytes": 64064864,
"domNodes": -275,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 110.36500000000001,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1401.510999999914,
"styleRecalcs": 18,
"styleRecalcDurationMs": 29.482000000000003,
"layouts": 5,
"layoutDurationMs": 13.380000000000003,
"taskDurationMs": 906.2509999999999,
"heapDeltaBytes": -6446204,
"heapUsedBytes": 81200760,
"domNodes": 13587,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 30.283000000000005,
"eventListeners": 2383,
"totalBlockingTimeMs": 147,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8363.801999999963,
"styleRecalcs": 248,
"styleRecalcDurationMs": 35.304,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5885.49,
"heapDeltaBytes": -2582076,
"heapUsedBytes": 77236912,
"domNodes": -245,
"jsHeapTotalBytes": -339968,
"scriptDurationMs": 2892.036,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8619.488000000047,
"styleRecalcs": 247,
"styleRecalcDurationMs": 35.607,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5917.312,
"heapDeltaBytes": -145608,
"heapUsedBytes": 78846312,
"domNodes": -247,
"jsHeapTotalBytes": -864256,
"scriptDurationMs": 2828.055,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16888.933000000008,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16375.108,
"heapDeltaBytes": -52888952,
"heapUsedBytes": 169524524,
"domNodes": -8061,
"jsHeapTotalBytes": -16277504,
"scriptDurationMs": 255.063,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 13294.040999999994,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12721.748,
"heapDeltaBytes": -50011136,
"heapUsedBytes": 180753028,
"domNodes": -8061,
"jsHeapTotalBytes": -8708096,
"scriptDurationMs": 232.603,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333237,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20321.682000000008,
"styleRecalcs": 166,
"styleRecalcDurationMs": 16.25399999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19927.173000000003,
"heapDeltaBytes": -58834524,
"heapUsedBytes": 176558800,
"domNodes": -8061,
"jsHeapTotalBytes": -15409152,
"scriptDurationMs": 870.6740000000001,
"eventListeners": -14928,
"totalBlockingTimeMs": 26,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 21079.849999999966,
"styleRecalcs": 161,
"styleRecalcDurationMs": 18.430000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20774.043999999998,
"heapDeltaBytes": -45562828,
"heapUsedBytes": 189873336,
"domNodes": -8065,
"jsHeapTotalBytes": -18747392,
"scriptDurationMs": 939.3799999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 65,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6109.475999999972,
"styleRecalcs": 20,
"styleRecalcDurationMs": 76.47199999999998,
"layouts": 20,
"layoutDurationMs": 22.479,
"taskDurationMs": 5980.776,
"heapDeltaBytes": -66458004,
"heapUsedBytes": 179924736,
"domNodes": -8061,
"jsHeapTotalBytes": 9379840,
"scriptDurationMs": 118.275,
"eventListeners": -14928,
"totalBlockingTimeMs": 425,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6367.572999999993,
"styleRecalcs": 20,
"styleRecalcDurationMs": 79.71900000000004,
"layouts": 20,
"layoutDurationMs": 24.428000000000004,
"taskDurationMs": 6265.019999999999,
"heapDeltaBytes": -46284540,
"heapUsedBytes": 175612704,
"domNodes": -8061,
"jsHeapTotalBytes": 6877184,
"scriptDurationMs": 122.189,
"eventListeners": -14928,
"totalBlockingTimeMs": 405,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8643.606999999975,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8345.198999999999,
"heapDeltaBytes": -5151644,
"heapUsedBytes": 183600288,
"domNodes": 0,
"jsHeapTotalBytes": -22020096,
"scriptDurationMs": 141.36299999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8486.585999999988,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8236.351,
"heapDeltaBytes": 6071968,
"heapUsedBytes": 173407188,
"domNodes": 0,
"jsHeapTotalBytes": -23330816,
"scriptDurationMs": 133.596,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 115.37500000008549,
"styleRecalcs": 8,
"styleRecalcDurationMs": 17.238,
"layouts": 3,
"layoutDurationMs": 1.4760000000000002,
"taskDurationMs": 96.743,
"heapDeltaBytes": 3321528,
"heapUsedBytes": 64541816,
"domNodes": 135,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 13.683,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 113.78500000000713,
"styleRecalcs": 8,
"styleRecalcDurationMs": 17.076,
"layouts": 4,
"layoutDurationMs": 1.6380000000000001,
"taskDurationMs": 81.706,
"heapDeltaBytes": 3052024,
"heapUsedBytes": 64620128,
"domNodes": 106,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 7.203999999999999,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
c7d4d75 to
7d20f28
Compare
Playwright videos for new testsDownload the recorded videos and HTML report Recorded projects: chromium Recorded test titles:
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #18114 +/- ##
==========================================
+ Coverage 82.77% 83.80% +1.02%
==========================================
Files 2936 2242 -694
Lines 144482 127638 -16844
Branches 39021 34339 -4682
==========================================
- Hits 119593 106964 -12629
+ Misses 23632 20384 -3248
+ Partials 1257 290 -967
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 700 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
Closing without merging: product decision. The fix commit c7d4d75 hides an externally wired promoted textarea, but the existing suite encodes the opposite contract for exactly that wire. Conflicting tests (confirmed locally at c7d4d75, all pass without the fix):
Decision (Christian Byrne): externally wired promoted textareas keep the existing visible + disabled behavior, so this PR is closed and the branch left in place for reference. The labeled-slot consistency for connection-suppressed rows is carried by #18123 — fix: keep the widget label on a connection-suppressed row in Vue nodes. 🤖 Generated with Claude Code https://claude.ai/code/session_01JwD8PkozfznCoUwAG46WAg Generated by Claude Code |
…omfy-Org#18123) <!-- ccr-slack-attribution --> _Requested by **Christian Byrne** · [Slack thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1789592320785689?thread_ts=1789592320.785689&cid=C0BGH348Z0C)_ ## ELI5 When a wire takes over a node's input, the input's own control steps aside, but its name tag should stay so you can still tell which input the wire feeds. Vue nodes used to take the name tag away too, leaving a bare dot. Comfy-Org#17576 fixed that on main; this PR adds the browser test that proves it stays fixed, and lets the screenshot workflow regenerate the one baseline that moved. ## Motivation In Vue nodes, wiring a `PrimitiveInt` into the `width` input of a subgraph host or a plain `EmptyLatentImage` collapsed the row to an unlabeled dot, so the node read `text`, then straight to `height`, and the report described the widget as having vanished. The legacy canvas keeps the row and its name for a connection-suppressed widget (`occupiesCanvasRow`), so this was a renderer parity gap on every plain node, not a subgraph bug. The repro landed as `test.fail()` rows in Comfy-Org#18085; this PR converts them into a real regression test. ## What is in this PR after rebasing onto Comfy-Org#17576 This PR originally patched `WidgetGrid.vue` with `:dot-only="!row.standalone"`. Comfy-Org#17576 landed first with `:dot-only="row.showsControl"` plus the forwarded `label`; since `standalone` is `!showsControl && suppressedByConnection`, that already covers the connection-suppressed row (and additionally labels converted-widget rows), and its unit test asserts the label text directly. Both source commits were dropped in the rebase as already upstream. What remains: - `browser_tests/tests/vueNodes/widgets/connectedWidgetRowLabel.spec.ts` + fixture `subgraph-promoted-int-text-with-primitives.json`: wires a `PrimitiveInt` into `width` on a promoted subgraph host and on a plain `EmptyLatentImage`, then asserts the `width` label and the slot dot both stay visible. - `subgraphSlots.spec.ts` "link interactions": tagged `@screenshot` so the `New Browser Test Expectations` workflow can regenerate its `vue-io-highlight.png` baseline. The baseline this branch regenerated was byte-identical to the one Comfy-Org#17576 merged, so that commit dropped too and the test runs against main's image. ## Provenance - **Authored by:** interactive session - **Verified:** `pnpm typecheck` (root plus account-core, billing-web, account-ui, billing-contract) exit 0; `WidgetGrid.test.ts` + `InputSlot.test.ts`: 2 files, 10 passed; `oxfmt --check` and `eslint` on the changed files clean; pre-push `pnpm knip` passed. Playwright coverage runs in CI on this head. - **Deviations:** the `fix:` and unit-test commits were superseded by Comfy-Org#17576 during the rebase; the PR is test-only now. ## Reviewer context - **Type:** test-only, Playwright regression coverage for connection-suppressed widget rows in Vue nodes - **Slots into:** Comfy-Org#17576 (the fix), Comfy-Org#18085 (the original `test.fail()` repros this replaces) - **Not in scope:** the promoted textarea behavior on connect (Comfy-Org#18114, closed), the redo wire drift (separate PR) ## Test plan - [ ] CI green: `connectedWidgetRowLabel.spec.ts` passes on both rows, `vue-io-highlight.png` holds against main's baseline - [ ] In Vue nodes, wire `PrimitiveInt` into `EmptyLatentImage.width`: the `width` label stays next to the dot, the number control is gone, the wire lands on the dot; disconnect restores the control 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01JwD8PkozfznCoUwAG46WAg --------- Co-authored-by: Claude <noreply@anthropic.com>
Requested by Christian Byrne · Slack thread
ELI5
When you plug a wire into a text box's input, the text box is supposed to step aside, because the wire now decides the value. A subgraph's promoted text box kept a private copy of its "am I hidden?" note, so the wire flipped a note nobody read and the text box stayed editable. This PR makes the promoted text box share the same note as everyone else.
Motivation
Wiring a parent-graph
PrimitiveStringinto a subgraph host's promoted multiline input left the textarea fully visible and editable while the wire landed, unlike the same wire into a plainCLIPTextEncode, whose textarea hides and leaves the slot. Promoted INT widgets on the same host hid correctly, which made the textarea read as a subgraph-specific rendering bug. The report and its intentionally failing repro landed in #18085 — test: add failing repros for promoted widget external-link rendering; this PR converts the relevant repro into a real regression test and fixes the cause.Before / After
Before (Vue nodes): wire
PrimitiveStringinto the host's promotedtext; the textarea stays visible and editable, the store'ssuppression.byConnectionstaysfalse, andcomputeProcessedWidgetskeepsvisible: true.After: the textarea hides and only the labeled
textslot remains, matching the plainCLIPTextEncodebehavior and the INT promoted rows.Why
createPromotedMultilineWidgetbuilds the promoted textarea as aDOMWidgetImpland never passes it throughBaseWidget.setNodeId(), which is where an ordinary widget swaps its private_visibilityfor the store-owned component.LGraphNode.updateComputedDisabled()therefore wroteconnectionSuppressedinto a private object, while the Vue renderer read the store entrySubgraphNode._setWidgethad registered under the sameWidgetId.How
BaseWidget.bindVisibility(visibility)shares a store-owned visibility component;setNodeId()now uses it for the swap it already performed.createPromotedMultilineWidgetbinds the new host widget touseWidgetValueStore().getWidgetVisibility(widgetId)right after creation, so connection suppression written through the widget is what the renderer reads.Red-Green Verification
test: add failing test for promoted textarea ignoring hide-on-connect(7d20f28)fix: hide the promoted textarea when its host input is connected(c7d4d75)Supersedes the
test.fail()casehides the promoted text control after a String is wired into the hostand the twoit.failscases inuseProcessedWidgets.promotedExternalLink.regression.test.tsfrom #18085 — test: add failing repros for promoted widget external-link rendering. The other repros in that PR (width label, redo wire drift) are handled in their own PRs.Provenance
pnpm test:uniton the regression file plusBaseWidget,src/lib/litegraph/src/subgraph,widgetValueStore,widgetConnectionSuppressionandsrc/scripts/domWidgetsuites: 24 files, 460 passed. Before the fix the regression file reported 2 failed / 1 passed for the stated reason (store flagfalse, render modelvisible: true). Playwright--project=chromiumonsubgraphPromotedWidgetExternalLink.spec.ts: 2 passed after the fix; before it, the host row failedtoHaveCount(0)with 1 textarea while the plain row passed.oxfmt --check,eslint,oxlint --type-awareon the changed files,pnpm typecheck:browser, and the commit-hookpnpm typecheckand push-hookpnpm knippassed.Reviewer context
Test plan
test:commit, green on thefix:commitbrowser_tests/assets/subgraphs/subgraph-promoted-int-text-with-primitives.json, wirePrimitiveStringinto the host'stext: the textarea hides and the labeled slot remains; disconnect restores it🤖 Generated with Claude Code
https://claude.ai/code/session_01JwD8PkozfznCoUwAG46WAg