Repository navigation
fix: record an undo entry when a link is dropped from a Vue node slot - #18117
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 2038 passed, 0 failed · 2 flaky📊 Browser Reports
📦 Bundle: 9.92 MB gzip 🟢 -63 BDetailsSummary
Category Glance App Entry Points — 3.77 kB (baseline 3.77 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.45 MB (baseline 1.45 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 132 kB (baseline 132 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 14 added / 14 removed / 4 unchanged Panels & Settings — 637 kB (baseline 637 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 17 unchanged User & Accounts — 37.9 kB (baseline 37.9 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 6 added / 6 removed / 5 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 1 unchanged UI Components — 124 kB (baseline 124 kB) • ⚪ 0 BReusable component library chunks
Status: 7 added / 7 removed / 9 unchanged Data & Services — 3.86 MB (baseline 3.86 MB) • 🔴 +73 BStores, services, APIs, and repositories
Status: 13 added / 13 removed / 3 unchanged Utilities & Hooks — 565 kB (baseline 565 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 19 added / 19 removed / 19 unchanged Vendor & Third-Party — 17.4 MB (baseline 17.4 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 17.7 MB (baseline 17.7 MB) • ⚪ 0 BBundles that do not match a named category
Status: 73 added / 73 removed / 225 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-19T15:31:32.137Z",
"gitSha": "009ac1f71c71f2e0dcaa250de7d472b93b5d52a1",
"branch": "fix/change-tracker-capture-vue-slot-drag-connect",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2023.3649999999557,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.261000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 443.99700000000007,
"heapDeltaBytes": 9897352,
"heapUsedBytes": 71432364,
"domNodes": -262,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 12.801,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 1993.0540000000292,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.046,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 531.366,
"heapDeltaBytes": 8819468,
"heapUsedBytes": 70457292,
"domNodes": -265,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 12.343,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2082.070999999985,
"styleRecalcs": 79,
"styleRecalcDurationMs": 40.594,
"layouts": 14,
"layoutDurationMs": 4.418,
"taskDurationMs": 1069.3000000000002,
"heapDeltaBytes": 16449416,
"heapUsedBytes": 77666052,
"domNodes": -269,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 194.78,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1815.8099999999422,
"styleRecalcs": 74,
"styleRecalcDurationMs": 29.496999999999996,
"layouts": 14,
"layoutDurationMs": 4.275,
"taskDurationMs": 933.5060000000002,
"heapDeltaBytes": 3268164,
"heapUsedBytes": 65398632,
"domNodes": -263,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 177.04799999999997,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1709.0900000000033,
"styleRecalcs": 31,
"styleRecalcDurationMs": 16.911999999999995,
"layouts": 6,
"layoutDurationMs": 1.2439999999999998,
"taskDurationMs": 396.17100000000005,
"heapDeltaBytes": 2354484,
"heapUsedBytes": 63150008,
"domNodes": 74,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 15.317000000000004,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1739.8110000000315,
"styleRecalcs": 32,
"styleRecalcDurationMs": 17.946000000000005,
"layouts": 6,
"layoutDurationMs": 1.0630000000000002,
"taskDurationMs": 384.40799999999996,
"heapDeltaBytes": 2184092,
"heapUsedBytes": 64132244,
"domNodes": 76,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 15.083000000000002,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 700.3950000000145,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.385000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 477.954,
"heapDeltaBytes": 17915464,
"heapUsedBytes": 79880352,
"domNodes": 20,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 169.10999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 714.5249999999805,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.583000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 484.538,
"heapDeltaBytes": 18241820,
"heapUsedBytes": 80209988,
"domNodes": 16,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 170.92000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2034.700999999984,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.9509999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 698.085,
"heapDeltaBytes": 3081740,
"heapUsedBytes": 82935904,
"domNodes": -252,
"jsHeapTotalBytes": -794624,
"scriptDurationMs": 37.87800000000001,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2039.445999999998,
"styleRecalcs": 5,
"styleRecalcDurationMs": 7.7799999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 662.5969999999999,
"heapDeltaBytes": 3248388,
"heapUsedBytes": 82900640,
"domNodes": -248,
"jsHeapTotalBytes": -1056768,
"scriptDurationMs": 36.26,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2475.3630000000157,
"styleRecalcs": 64,
"styleRecalcDurationMs": 10.373000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1722.034,
"heapDeltaBytes": 19120220,
"heapUsedBytes": 83178904,
"domNodes": -257,
"jsHeapTotalBytes": 1011712,
"scriptDurationMs": 868.3259999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2535.7870000000275,
"styleRecalcs": 66,
"styleRecalcDurationMs": 11.641999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1748.0130000000001,
"heapDeltaBytes": -1439660,
"heapUsedBytes": 79055376,
"domNodes": -253,
"jsHeapTotalBytes": 741376,
"scriptDurationMs": 885.3249999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3582.877999999994,
"styleRecalcs": 60,
"styleRecalcDurationMs": 9.994,
"layouts": 60,
"layoutDurationMs": 12.926999999999998,
"taskDurationMs": 1710.353,
"heapDeltaBytes": 8419924,
"heapUsedBytes": 73915748,
"domNodes": -11,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 795.517,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3768.210999999951,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.287999999999998,
"layouts": 60,
"layoutDurationMs": 13.594999999999999,
"taskDurationMs": 1800.8609999999999,
"heapDeltaBytes": 7945888,
"heapUsedBytes": 73883524,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 840.299,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3104.566000000034,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.979999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1992.3000000000002,
"heapDeltaBytes": 18549620,
"heapUsedBytes": 84135028,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 1003.8689999999999,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3147.9940000000397,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.1640000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2057.796,
"heapDeltaBytes": 23884488,
"heapUsedBytes": 89757332,
"domNodes": 0,
"jsHeapTotalBytes": 942080,
"scriptDurationMs": 1062.555,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2026.791000000003,
"styleRecalcs": 7,
"styleRecalcDurationMs": 8.068000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 730.8969999999999,
"heapDeltaBytes": -7242144,
"heapUsedBytes": 80346856,
"domNodes": -255,
"jsHeapTotalBytes": 290816,
"scriptDurationMs": 42.72200000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2022.952000000032,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.714,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 648.1009999999999,
"heapDeltaBytes": -3385980,
"heapUsedBytes": 83752556,
"domNodes": -248,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 38.74000000000001,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 601.0630000000106,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.282,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 423.299,
"heapDeltaBytes": 13518764,
"heapUsedBytes": 76659520,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 143.41799999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 575.9970000000294,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.057999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 412.45199999999994,
"heapDeltaBytes": 13862348,
"heapUsedBytes": 77160340,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 142.82,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2015.8230000000117,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.741000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 540.783,
"heapDeltaBytes": 3474352,
"heapUsedBytes": 66878016,
"domNodes": -277,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 11.943999999999999,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2022.7260000000342,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.511,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 418.216,
"heapDeltaBytes": 18620168,
"heapUsedBytes": 81795704,
"domNodes": -275,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 12.812000000000001,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1735.9050000000025,
"styleRecalcs": 77,
"styleRecalcDurationMs": 27.244999999999997,
"layouts": 18,
"layoutDurationMs": 4.872999999999999,
"taskDurationMs": 837.3580000000001,
"heapDeltaBytes": 17943024,
"heapUsedBytes": 80872820,
"domNodes": -278,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 115.486,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1716.6669999999158,
"styleRecalcs": 77,
"styleRecalcDurationMs": 28.335,
"layouts": 18,
"layoutDurationMs": 5.383,
"taskDurationMs": 846.325,
"heapDeltaBytes": 12360068,
"heapUsedBytes": 75558688,
"domNodes": -278,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 115.80100000000002,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 1385.3450000000294,
"styleRecalcs": 18,
"styleRecalcDurationMs": 30.536,
"layouts": 5,
"layoutDurationMs": 13.887,
"taskDurationMs": 989.2489999999998,
"heapDeltaBytes": 19204352,
"heapUsedBytes": 105793484,
"domNodes": 13587,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 33.938,
"eventListeners": 2383,
"totalBlockingTimeMs": 148,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8436.70000000003,
"styleRecalcs": 247,
"styleRecalcDurationMs": 35.672999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5960.448,
"heapDeltaBytes": -4453124,
"heapUsedBytes": 74942812,
"domNodes": -251,
"jsHeapTotalBytes": -831488,
"scriptDurationMs": 2804.445,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8781.350999999973,
"styleRecalcs": 248,
"styleRecalcDurationMs": 38.576,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6179.9220000000005,
"heapDeltaBytes": -874336,
"heapUsedBytes": 78979848,
"domNodes": -248,
"jsHeapTotalBytes": -1126400,
"scriptDurationMs": 2915.278,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17239.461000000007,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16903.623,
"heapDeltaBytes": -33513840,
"heapUsedBytes": 183008872,
"domNodes": -8061,
"jsHeapTotalBytes": -17698816,
"scriptDurationMs": 274.13699999999994,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 16714.048999999934,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16234.484999999999,
"heapDeltaBytes": -44049708,
"heapUsedBytes": 194372904,
"domNodes": -8061,
"jsHeapTotalBytes": -21729280,
"scriptDurationMs": 283.21599999999995,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 21976.932999999975,
"styleRecalcs": 164,
"styleRecalcDurationMs": 22.17399999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21721.733,
"heapDeltaBytes": -38351748,
"heapUsedBytes": 178049660,
"domNodes": -8061,
"jsHeapTotalBytes": -12914688,
"scriptDurationMs": 942.0989999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 99,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999995634
},
{
"name": "vue-large-graph-pan",
"durationMs": 20294.738000000052,
"styleRecalcs": 155,
"styleRecalcDurationMs": 16.55200000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20007.933,
"heapDeltaBytes": -24162716,
"heapUsedBytes": 189476304,
"domNodes": -8061,
"jsHeapTotalBytes": -14495744,
"scriptDurationMs": 858.477,
"eventListeners": -14928,
"totalBlockingTimeMs": 78,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6296.098999999969,
"styleRecalcs": 20,
"styleRecalcDurationMs": 82.65400000000001,
"layouts": 20,
"layoutDurationMs": 26.482999999999993,
"taskDurationMs": 6228.980999999999,
"heapDeltaBytes": -38671128,
"heapUsedBytes": 177924100,
"domNodes": -8061,
"jsHeapTotalBytes": 7925760,
"scriptDurationMs": 112.57000000000001,
"eventListeners": -14928,
"totalBlockingTimeMs": 546,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6159.559999999942,
"styleRecalcs": 20,
"styleRecalcDurationMs": 78.34399999999997,
"layouts": 20,
"layoutDurationMs": 22.96300000000001,
"taskDurationMs": 6057.599000000001,
"heapDeltaBytes": -39692372,
"heapUsedBytes": 182612700,
"domNodes": -8061,
"jsHeapTotalBytes": 14524416,
"scriptDurationMs": 109.10600000000001,
"eventListeners": -14928,
"totalBlockingTimeMs": 420,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8561.497000000032,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8424.399999999998,
"heapDeltaBytes": 867484,
"heapUsedBytes": 167625360,
"domNodes": 0,
"jsHeapTotalBytes": -25690112,
"scriptDurationMs": 157.51400000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.773333333333238,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8449.783000000025,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8239.020999999997,
"heapDeltaBytes": -23206744,
"heapUsedBytes": 170947508,
"domNodes": 0,
"jsHeapTotalBytes": -28311552,
"scriptDurationMs": 132.84700000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 123.3630000000403,
"styleRecalcs": 8,
"styleRecalcDurationMs": 21.668,
"layouts": 3,
"layoutDurationMs": 1.6740000000000002,
"taskDurationMs": 93.054,
"heapDeltaBytes": 3165464,
"heapUsedBytes": 64370948,
"domNodes": 131,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.354000000000001,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "workflow-execution",
"durationMs": 103.81900000004407,
"styleRecalcs": 8,
"styleRecalcDurationMs": 18.745,
"layouts": 3,
"layoutDurationMs": 1.6000000000000003,
"taskDurationMs": 79.66699999999999,
"heapDeltaBytes": 3069180,
"heapUsedBytes": 64686280,
"domNodes": 131,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.992999999999999,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🎨 Storybook: ✅ Built — View Storybook |
Playwright videos for new testsDownload the recorded videos and HTML report Recorded projects: chromium Recorded test titles:
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #18117 +/- ##
==========================================
+ Coverage 82.79% 83.80% +1.01%
==========================================
Files 2938 2244 -694
Lines 144525 127677 -16848
Branches 39037 34353 -4684
==========================================
- Hits 119658 107003 -12655
+ Misses 23611 20385 -3226
+ Partials 1256 289 -967
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 703 files with indirect coverage changes 🚀 New features to boost your workflow:
|
2f9f6df to
4cc1e58
Compare
christian-byrne
left a comment
There was a problem hiding this comment.
finishInteraction() now records a completed Vue slot drop through the active workflow's existing change tracker. No blocking finding in this bounded fix.
Full context for agent readers
Reviewed pointer completion, cancellation, adapter cleanup, the active-tracker guard, snapshot comparison and legacy mouseup capture. Capture runs after the connection and cleanup, while unchanged snapshots do not add history. Cancellation remains outside this new call.
Independently ran the regression on its exact test-only parent: Ctrl+Z leaves one link where zero is expected. The proposed head passes that case, compatible connection and incompatible-slot cases (three Chromium tests). An additional isolated empty-canvas drop check passes: connect, drop another drag on empty canvas, Escape, then one Ctrl+Z removes the original connection; history remains one entry before undo. Production build passes. Native checks at the unchanged reviewed head are terminal without adverse results.
Both core/1.54 and cloud/1.54 accept the full patch independently, and both contain the required tracker method, workflow fixture and browser helper APIs. Backport labels request release PRs; they do not establish release acceptance.
This fixes missed manual-drag history, not wire geometry or phantom history after redo. Original agent-generated workflow and release acceptance remain open under Christian's existing follow-through.
Glossary: snapshot means the graph state saved for undo; backport means transferring this fix to a release branch.
Comfy-Org#18118) <!-- ccr-slack-attribution --> _Requested by **Christian Byrne** · [Slack thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1789592320785689?thread_ts=1789592320.785689&cid=C0BGH348Z0C)_ ## ELI5 Redo rebuilds the graph from a saved snapshot. While rebuilding, the graph works out afresh the order in which nodes should run and stamps each node with a new number. The undo history then compares the live graph with its snapshot, sees those numbers differ, and concludes you edited something, so the next plain click on the canvas records a phantom "change". Pressing Ctrl+Z after that restores a snapshot that looks identical, so undo appears to do nothing and you have to press it twice. This PR makes the comparison ignore that run-order number, which the user never edits. ## Motivation Before: connect two nodes, undo, redo, click the canvas, press Ctrl+Z: the link stays. The click after the redo pushed an undo entry that differs from the live graph only in node `order`, so the first Ctrl+Z is a visible no-op and the redo queue is wiped. After: the click after a redo records nothing, and Ctrl+Z removes the redone link. Why: `ChangeTracker.graphEqual` deep-compares node objects, including `order`. `order` is the execution index that `LGraph.updateExecutionOrder()` recomputes on every configure, add or remove; a snapshot captured before a reload and the graph rebuilt from it legitimately disagree on it. The auto-queue comparison in the same file already lists `order` among the non-execution node properties it ignores. ## Provenance - **Authored by:** interactive session - **Verified:** Vitest `changeTracker.test.ts`, new case `does not push when only the recomputed node execution order differs`: fails on the test-only commit (`expected [ Array(1) ] to have a length of +0 but got 1`), and the whole file passes with the fix (63/63). Playwright `changeTracker.spec.ts`, new case `Undo after a redo and a canvas click removes the redone link`: fails on the test-only commit at its final assertion (`expected 0, received 1` links) with every earlier step passing, and passes with the fix. The other 6 failing cases in that spec fail identically in the local sandbox with the fix stashed (legacy-menu and subgraph-entry environment issues) and are green in CI. Full `pnpm lint`, `pnpm format:check`, typecheck, eslint, oxlint and oxfmt on the changed files: clean. - **Deviations:** none ## Reviewer context - **Type:** bug fix, undo/redo change detection - **Slots into:** Comfy-Org#18085 (repro and isolation PR). The phantom entry was found while isolating the link drift there. The missing undo entry for a Vue node slot drag-connect is a separate bug, fixed in Comfy-Org#18117. - The e2e clicks two different empty spots on purpose: two same-spot clicks inside the double-click window open node search, which swallows Ctrl+Z and Ctrl+Y. ## How `graphEqual` compares the two node lists with `order` omitted from every node. Nothing else in the comparison changes. ## Red-green verification | Commit | CI | Purpose | |---|---|---| | `test: cover the spurious undo entry pushed by a canvas click after redo` (e7539e0) | red | the unit case pushes an entry for an order-only difference (unit `test` job failed); the Playwright case leaves the link in place after the post-redo Ctrl+Z (e2e-status failed on shard 2 and the new-tests video job) | | `fix: ignore recomputed node execution order when comparing graph snapshots` (c2cffd8) | green | same cases pass, all checks green | ## Test plan - [x] CI red on the test-only commit (unit `test` job and e2e-status failed, shard 2 and the new-tests video job) - [x] CI green on the fix commit - [ ] Connect two nodes, Ctrl+Z, Ctrl+Y, click empty canvas, Ctrl+Z: the link is removed on the first press - [ ] Move a node, click the canvas, Ctrl+Z: the move is still undone (a real change is still detected) --- _Generated by [Claude Code](https://claude.ai/code/session_01JwD8PkozfznCoUwAG46WAg)_ --------- Co-authored-by: Claude <noreply@anthropic.com>
…t a cloud carrier (#18257) ## Summary Eight merged `main` Agent fixes that had no `cloud/1.54` carrier are cherry-picked onto the current release tip. Two sources need hand re-expression and are excluded. Runtime source is unmodified from the eight sources; seven follow-up commits are test-only adaptations to the release's module surface. Verification at the current head `2991cfc3f8` is hosted CI (77 success, 16 skipped, 0 failed) plus DrJKL's local run (see below); the picked browser specs had not been run against the target before this PR. Open gates: release-scope sign-off on the three non-Agent carries and exact-head human re-approval on `2991cfc3f8`, both tracked in [blocked-on-christian 825](christian-byrne/blocked-on-christian#825). Replaces [18254](#18254): six picks there inherited `Co-authored-by: Claude` trailers from the `main` squash commits and failed the AI co-author check. Runtime source is byte-identical to that PR's head `d1f35ac622`; two test files differ (listed under Adaptations). <details><summary>Full context for agent readers</summary> ## Changes Sources, all `cherry-pick -x -m 1`, clean, in merge order: - [18104](#18104) prefer previewUrl for dragged batch-output attachments - [18110](#18110) re-measure Vue node slot offsets after graph reload - [18117](#18117) record an undo entry when a link is dropped from a Vue node slot - [18118](#18118) stop a canvas click after redo from pushing a spurious undo entry - [18124](#18124) never silently no-op the subscription-required dialog - [18127](#18127) restore autogrow inputs after Agent reconciliation - [18191](#18191) keep the ghost placement flag out of the CRDT document - [18196](#18196) retarget new Agent chat to the workflow tab on screen Adaptations, all test-only, no runtime change: - `NodeSlots` reload unit test uses `createTestingPinia` + `setActivePinia` instead of `getActivePinia()!`, because the shared test Pinia setup from [17237](#17237) is `main`-only. - Browser fixture gains `NodeSlotReference.expectLinkCount` (same body as `main`, from [17403](#17403)); three picked Agent specs open the panel with the label the release UI renders, `agent.askComfyAgent`, because `agent.entryButton` from [17621](#17621) does not exist on this line. - `useSlotLinkInteraction.autoPan.test.ts`: the `globalEnums` mock is dropped (the picked composable now reads `RenderShape` from the real module, as on `main`), and the `@vueuse/core` mock spreads the actual module so release-native transitive imports such as `useStorage` resolve while the event-listener overrides stay focused. - `useSlotLinkInteraction.autoPan.test.ts` (`249123390c`): the workflow store is mocked at its seam instead of a partial module mock, per dante01yoon's review. - `subgraphPromotedWidgetExternalLink.spec.ts` (`2991cfc3f8`): the plain CLIPTextEncode "hides the text control" case and its two constants are deleted, because it asserts [17576](#17576) behavior (WidgetGrid retains labels for connected inputs) that is not on `cloud/1.54`. Re-add when 17576 lands on this line; the 17576 decision is [blocked-on-christian 824](christian-byrne/blocked-on-christian#824). Dependencies: none added; release lockfile pins preserved. Exclusions: [18063](#18063) and [18073](#18073) conflict because they edit `agentCrdtProjection.ts` and `agentCrdtDocLifecycle.ts`, files created by the follower split in [16908](#16908), which `cloud/1.54` never received. They need focused hand re-expression onto the pre-split follower, following [18219](#18219) and [18195](#18195); tracked as separate program rows. ## Review focus - Every source commit is an unmodified cherry-pick; review effort belongs on the test-only adaptation commits and on whether the eight sources are wanted on this line at all. - Sources 18110, 18117, and 18118 touch undo/redo and slot measurement outside the Agent panel, so they change behavior for users who never open the Agent. - This is not behavioral acceptance or a merge-check waiver; no target-native browser acceptance has run outside hosted CI. ## Exact-head verification Head history: `210e191fc9` (approved by DrJKL) received five test-only follow-ups: `a9ab888243` (module-surface alignment), `a63fef35ae` (`test.fixme` instead of `test.skip`, which the release's oxlint config rejects), `118ac5e9c6` (restore VueUse exports in the auto-pan mock, fixing the suite-collection failure DrJKL found at `a63fef35ae`), `249123390c` (workflow-store seam mock), and `2991cfc3f8` (delete the plain CLIPTextEncode browser case). - `210e191fc9`, local on top of `cloud/1.54` tip `1bbcdc66fa`: cherry-pick dry run of all 10 candidates, 8 clean individually and as a sequential stack, 2 conflicting as described above; `vitest run` on the 9 touched unit test files 405 passed; both `vue-tsc` projects exit 0; `oxfmt` and `eslint` clean; lint-staged and knip passed in hooks. - `a63fef35ae`, hosted: `lint-and-format` passed. DrJKL's local focused run: 405 passed plus one suite-collection failure in `useSlotLinkInteraction.autoPan.test.ts` (`useStorage` missing from the total `@vueuse/core` mock). Fixed in `118ac5e9c6`. - `118ac5e9c6`: hosted CI green; the unit `test` job covers the collection fix. - `2991cfc3f8` (current head): hosted CI 77 success, 16 skipped, 0 failed. DrJKL's local run on this head: both typecheck projects, ESLint, Oxlint, format, and Knip clean; Vitest 4 of 4 on the auto-pan suite; Playwright discovery 43 tests across 7 specs; Fallow clean. Author-side local verification is not run on this head (host resource hold); hosted CI plus DrJKL's run are the verification of record. Program receipt: [2026-09-21-ms215-gap-backport-cloud154.md](https://github.com/christian-byrne/in-app-agent-program/blob/main/reports/pr-ownership/2026-09-21-ms215-gap-backport-cloud154.md). </details> --------- Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> Co-authored-by: test-bot <test-bot@users.noreply.github.com> Co-authored-by: Alexander Brown <drjkl@comfy.org> Co-authored-by: Amp <amp@ampcode.com>
The external-boundary undo test pinned the post-connect state with clickEmptySpace() because a Vue slot drag-connect used to leave no undo snapshot of its own. Since #18117 the drop records one directly, so the pin click is redundant, and it had also become unclickable in CI (the workflow tab bar overlays the default empty-space position and intercepts the click, timing the test out). Remove the pin click and update the spec header's stale caveat about the missing snapshot.
…dget CI showed undo in the external-boundary test restoring a state captured between the two explicit promotions: the change tracker snapshots on window mouseup, which fires before the click handlers that apply promotions, so its activeState lagged the built baseline by one action and the slot drop (#18117) pushed that stale state as the undo target. Click empty canvas once the baseline is fully built so the drop pushes the settled state, and a single undo restores all four promoted widgets.
<!-- ccr-slack-attribution --> _Requested by **Jo Zhang, Christian Byrne** · [Slack thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1789707519592879?thread_ts=1789707519.592879&cid=C0BGH348Z0C)_ ## ELI5 A subgraph node shows several "promoted" widgets from the nodes hidden inside it (like width, height, seed). When you rewire the connection behind just one of those widgets, the others could flicker, duplicate, or vanish for a moment, and the wired-in widget itself could disappear. This PR fixes that and adds tests at both levels: unit tests prove the mechanism, and the browser-level repro tests — which this PR's own CI confirmed now pass with the fix — are kept as plain regression tests. - Fixes #14495 ## Motivation This started as a REPRO-ONLY PR for a reported bug: wiring a new node into a subgraph's promoted "prompt" widget makes the subgraph's *other* promoted widgets render duplicated, and a closely related report has the rewired widget itself disappear with redo misplacing the wire. Investigation traced a confirmed mechanism for the disappearing half at the data-model layer (see Summary). Once that mechanism was nailed down precisely enough to fix without guessing, and a second, more contained duplication theory was checked and refuted, it became worth landing the fix and the validating tests in the same PR rather than leaving a fully-diagnosed, small, well-scoped bug unfixed. ## Provenance - **Authored by:** interactive session, Claude Code - **Verified:** `pnpm exec vitest run src/lib/litegraph/src/subgraph/SubgraphWidgetPromotion.test.ts` — 51 passed, 0 failed (was 50 passed / 1 expected fail before the fix; that case now passes for real and was flipped from `it.fails` to `it`). `pnpm exec vitest run src/lib/litegraph/src/subgraph/ src/renderer/extensions/vueNodes/widgets/utils/multilineTextarea.promoted.test.ts src/stores/widgetValueStore.test.ts src/stores/domWidgetStore.test.ts` — 413 passed, 0 failed. `pnpm typecheck`, `pnpm lint`, `pnpm knip` — clean. E2E confirmation came from this PR's own CI (see Summary). Re-verified after the 2026-10-01 rebase onto main: same scoped suites green, typecheck/lint/knip clean. - **Deviations:** none remaining. The previous push deliberately left the e2e `test.fail()` cases unflipped pending CI evidence; that evidence has now arrived (see "E2E confirmation" below) and they are flipped to plain `test()` in this push, exactly per the plan recorded in the earlier Test plan. ## Reviewer context - **Type:** fix + test — a small, contained timing fix plus the tests that prove it, validate/refute an alternate duplication theory, and lock in the browser-level symptom as regression coverage - **Slots into:** a subgraph promoted-widget-promotion bug investigation; no project or epic, ad-hoc follow-up to that investigation - **Not in scope:** `createPromotedMultilineWidget`'s visibility/suppression path — that's PR #18085's territory (a sibling investigation into the same widget family) ## Summary ### The fix (`src/lib/litegraph/src/subgraph/SubgraphNode.ts`) Rewiring the interior link behind a promoted widget (e.g. dragging a new node onto an already-promoted widget's socket) removes the old link before the new one lands. `SubgraphInputNode`'s `'input-disconnected'` handler used to demote the widget **synchronously** — clearing `input.widgetId`/`.widget`/`._widget` immediately — while deferring the matching `widgetValueStore` cleanup to a `queueMicrotask`. For one tick, `hostNode.widgets.length` (synchronous) and the store's tracked id count for that node (deferred) disagreed. The Vue widget grid (`useProcessedWidgets`/`computeProcessedWidgets`) reads its render *order* from the store and its liveness *filter* from `hostNode.widgets` — i.e. from both sides of that exact disagreement. The fix defers the demotion itself by a microtask (mirroring the already-deferred store cleanup), tracked with a per-input cancellation token. The `'input-connected'` listener clears that token on a same-tick reconnect, so a rewire never drops the widget from `hostNode.widgets` at all. A genuine disconnect with no reconnect still fully demotes once the microtask runs — nothing about final-state behavior changes, only the timing of an in-between state that used to be observable. **Deliberate timing-change note** (per this repo's own ecosystem-impact rule for changes touching `node.widgets` access): this changes when a disconnect becomes observable on `hostNode.widgets` — previously synchronous, now one microtask tick later for a genuine disconnect. Two existing tests in `SubgraphWidgetPromotion.test.ts` asserted this synchronously with no `await`; both were updated to `await Promise.resolve()` after the disconnecting call, with a comment explaining why. No public API shape or callback signature changed — only internal timing. ### New tests - `SubgraphWidgetPromotion.test.ts`, "keeps every promoted widget present while rewiring the interior link behind one of them" (previously `it.fails`, now a plain `it`): builds a host with 4 promoted widgets from 4 different interior nodes, rewires the link behind one of them onto a *new* interior node mid-test, and asserts `hostNode.widgets.length` stays at 4 throughout — including immediately after the disconnect step, before the reconnect lands. - `SubgraphWidgetPromotion.test.ts`, "Promoted textarea dual-registration (PM-1328 duplication lead)": tests a second, independently-raised theory for the duplication symptom — that a promoted textarea's DOM-hosted widget (a `DOMWidgetImpl` living in `useDomWidgetStore`, materialized by `createPromotedHostWidget`) and a store-projected row could both end up registered for the same input, which would duplicate a row in the widget grid. Built a minimal `SubgraphNode` subclass wired the same way the app's real subclass is, exercised it across a rewire and a `configure()` reconfigure. **Both pass as-is — the theory is refuted.** `_projectPromotedWidget`'s `if (input._widget) return input._widget` guard is unconditional across every call site and there's no observable window where `input.widgetId` is set while `input._widget` isn't. Kept as regression coverage. ### E2E confirmation (CI run [35419314544](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/35419314544)) CI on the previous head answered the open question the `test.fail()` repros were posted to ask — the fix **does** resolve the browser-level symptom end-to-end: - Both `subgraphPromotedWidgetRewireDuplication.spec.ts` repro scenarios (interior rewire and external boundary wire) were reported "Expected to fail, but passed" on every run and retry (video job + shard 12, 4/4 retries). Flipped to plain `test()` regression tests, and retitled to describe the behavior they now guarantee. - `subgraphPromotion.spec.ts` "Promoted STRING widget edit survives a rebind of the interior link" — a *pre-existing* `test.fail()` for #14495 — also passed on all 4 shard-12 attempts. Flipped to plain `test()`; hence "Fixes #14495" above. - The external-boundary undo test went through two CI-informed revisions after the rebase: which snapshot undo targets depends on change-tracker capture timing the test cannot control (captures fire on window mouseup, before the click handlers that apply promotions, so the entry pushed by the slot drop — #18117 — can lag the built baseline by one action), and an attempt to pin the snapshot with an extra canvas click timed out in CI. The test now asserts the invariant both reported symptoms violate instead of a fixed widget set: whatever state undo restores, the host's model holds no duplicate widgets and the grid renders exactly one row per model widget, none otherwise. ## Test plan - [x] Watch this PR's `playwright-video-new-tests` CI check: the `test.fail()` cases were reported as unexpectedly passed (run 35419314544) - [x] Flip those cases (and the pre-existing #14495 one) to plain `test()` - [x] Make the external-boundary undo test deterministic (it now asserts render/model consistency after undo instead of assuming which snapshot undo targets) - [ ] CI green on the rebased head (the "Check for AI agent co-author trailers" check was removed from main in #19393; the first commit still carries trailers, and rewording it remains a maintainer call since it rewrites shared history) 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01U6aDANuoAYDtxd9WiCk44Q --------- Co-authored-by: Claude <noreply@anthropic.com>
<!-- ccr-slack-attribution --> _Requested by **Jo Zhang, Christian Byrne** · [Slack thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1789707519592879?thread_ts=1789707519.592879&cid=C0BGH348Z0C)_ A subgraph node shows several "promoted" widgets from the nodes hidden inside it (like width, height, seed). When you rewire the connection behind just one of those widgets, the others could flicker, duplicate, or vanish for a moment, and the wired-in widget itself could disappear. This PR fixes that and adds tests at both levels: unit tests prove the mechanism, and the browser-level repro tests — which this PR's own CI confirmed now pass with the fix — are kept as plain regression tests. - Fixes #14495 This started as a REPRO-ONLY PR for a reported bug: wiring a new node into a subgraph's promoted "prompt" widget makes the subgraph's *other* promoted widgets render duplicated, and a closely related report has the rewired widget itself disappear with redo misplacing the wire. Investigation traced a confirmed mechanism for the disappearing half at the data-model layer (see Summary). Once that mechanism was nailed down precisely enough to fix without guessing, and a second, more contained duplication theory was checked and refuted, it became worth landing the fix and the validating tests in the same PR rather than leaving a fully-diagnosed, small, well-scoped bug unfixed. - **Authored by:** interactive session, Claude Code - **Verified:** `pnpm exec vitest run src/lib/litegraph/src/subgraph/SubgraphWidgetPromotion.test.ts` — 51 passed, 0 failed (was 50 passed / 1 expected fail before the fix; that case now passes for real and was flipped from `it.fails` to `it`). `pnpm exec vitest run src/lib/litegraph/src/subgraph/ src/renderer/extensions/vueNodes/widgets/utils/multilineTextarea.promoted.test.ts src/stores/widgetValueStore.test.ts src/stores/domWidgetStore.test.ts` — 413 passed, 0 failed. `pnpm typecheck`, `pnpm lint`, `pnpm knip` — clean. E2E confirmation came from this PR's own CI (see Summary). Re-verified after the 2026-10-01 rebase onto main: same scoped suites green, typecheck/lint/knip clean. - **Deviations:** none remaining. The previous push deliberately left the e2e `test.fail()` cases unflipped pending CI evidence; that evidence has now arrived (see "E2E confirmation" below) and they are flipped to plain `test()` in this push, exactly per the plan recorded in the earlier Test plan. - **Type:** fix + test — a small, contained timing fix plus the tests that prove it, validate/refute an alternate duplication theory, and lock in the browser-level symptom as regression coverage - **Slots into:** a subgraph promoted-widget-promotion bug investigation; no project or epic, ad-hoc follow-up to that investigation - **Not in scope:** `createPromotedMultilineWidget`'s visibility/suppression path — that's PR #18085's territory (a sibling investigation into the same widget family) Rewiring the interior link behind a promoted widget (e.g. dragging a new node onto an already-promoted widget's socket) removes the old link before the new one lands. `SubgraphInputNode`'s `'input-disconnected'` handler used to demote the widget **synchronously** — clearing `input.widgetId`/`.widget`/`._widget` immediately — while deferring the matching `widgetValueStore` cleanup to a `queueMicrotask`. For one tick, `hostNode.widgets.length` (synchronous) and the store's tracked id count for that node (deferred) disagreed. The Vue widget grid (`useProcessedWidgets`/`computeProcessedWidgets`) reads its render *order* from the store and its liveness *filter* from `hostNode.widgets` — i.e. from both sides of that exact disagreement. The fix defers the demotion itself by a microtask (mirroring the already-deferred store cleanup), tracked with a per-input cancellation token. The `'input-connected'` listener clears that token on a same-tick reconnect, so a rewire never drops the widget from `hostNode.widgets` at all. A genuine disconnect with no reconnect still fully demotes once the microtask runs — nothing about final-state behavior changes, only the timing of an in-between state that used to be observable. **Deliberate timing-change note** (per this repo's own ecosystem-impact rule for changes touching `node.widgets` access): this changes when a disconnect becomes observable on `hostNode.widgets` — previously synchronous, now one microtask tick later for a genuine disconnect. Two existing tests in `SubgraphWidgetPromotion.test.ts` asserted this synchronously with no `await`; both were updated to `await Promise.resolve()` after the disconnecting call, with a comment explaining why. No public API shape or callback signature changed — only internal timing. - `SubgraphWidgetPromotion.test.ts`, "keeps every promoted widget present while rewiring the interior link behind one of them" (previously `it.fails`, now a plain `it`): builds a host with 4 promoted widgets from 4 different interior nodes, rewires the link behind one of them onto a *new* interior node mid-test, and asserts `hostNode.widgets.length` stays at 4 throughout — including immediately after the disconnect step, before the reconnect lands. - `SubgraphWidgetPromotion.test.ts`, "Promoted textarea dual-registration (PM-1328 duplication lead)": tests a second, independently-raised theory for the duplication symptom — that a promoted textarea's DOM-hosted widget (a `DOMWidgetImpl` living in `useDomWidgetStore`, materialized by `createPromotedHostWidget`) and a store-projected row could both end up registered for the same input, which would duplicate a row in the widget grid. Built a minimal `SubgraphNode` subclass wired the same way the app's real subclass is, exercised it across a rewire and a `configure()` reconfigure. **Both pass as-is — the theory is refuted.** `_projectPromotedWidget`'s `if (input._widget) return input._widget` guard is unconditional across every call site and there's no observable window where `input.widgetId` is set while `input._widget` isn't. Kept as regression coverage. [35419314544](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/35419314544)) CI on the previous head answered the open question the `test.fail()` repros were posted to ask — the fix **does** resolve the browser-level symptom end-to-end: - Both `subgraphPromotedWidgetRewireDuplication.spec.ts` repro scenarios (interior rewire and external boundary wire) were reported "Expected to fail, but passed" on every run and retry (video job + shard 12, 4/4 retries). Flipped to plain `test()` regression tests, and retitled to describe the behavior they now guarantee. - `subgraphPromotion.spec.ts` "Promoted STRING widget edit survives a rebind of the interior link" — a *pre-existing* `test.fail()` for #14495 — also passed on all 4 shard-12 attempts. Flipped to plain `test()`; hence "Fixes #14495" above. - The external-boundary undo test went through two CI-informed revisions after the rebase: which snapshot undo targets depends on change-tracker capture timing the test cannot control (captures fire on window mouseup, before the click handlers that apply promotions, so the entry pushed by the slot drop — #18117 — can lag the built baseline by one action), and an attempt to pin the snapshot with an extra canvas click timed out in CI. The test now asserts the invariant both reported symptoms violate instead of a fixed widget set: whatever state undo restores, the host's model holds no duplicate widgets and the grid renders exactly one row per model widget, none otherwise. - [x] Watch this PR's `playwright-video-new-tests` CI check: the `test.fail()` cases were reported as unexpectedly passed (run 35419314544) - [x] Flip those cases (and the pre-existing #14495 one) to plain `test()` - [x] Make the external-boundary undo test deterministic (it now asserts render/model consistency after undo instead of assuming which snapshot undo targets) - [ ] CI green on the rebased head (the "Check for AI agent co-author trailers" check was removed from main in #19393; the first commit still carries trailers, and rewording it remains a maintainer call since it rewrites shared history) 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01U6aDANuoAYDtxd9WiCk44Q --------- (cherry picked from commit 9ee67cb) (The two conflicting test files are byte-identical between core/1.54 and cloud/1.54 at their merge base, so this is the same resolution as the core/1.54 carrier. `SubgraphNode.ts` differs slightly between the two branches but the fix applied cleanly to both.)
<!-- ccr-slack-attribution --> _Requested by **Jo Zhang, Christian Byrne** · [Slack thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1789707519592879?thread_ts=1789707519.592879&cid=C0BGH348Z0C)_ A subgraph node shows several "promoted" widgets from the nodes hidden inside it (like width, height, seed). When you rewire the connection behind just one of those widgets, the others could flicker, duplicate, or vanish for a moment, and the wired-in widget itself could disappear. This PR fixes that and adds tests at both levels: unit tests prove the mechanism, and the browser-level repro tests — which this PR's own CI confirmed now pass with the fix — are kept as plain regression tests. - Fixes #14495 This started as a REPRO-ONLY PR for a reported bug: wiring a new node into a subgraph's promoted "prompt" widget makes the subgraph's *other* promoted widgets render duplicated, and a closely related report has the rewired widget itself disappear with redo misplacing the wire. Investigation traced a confirmed mechanism for the disappearing half at the data-model layer (see Summary). Once that mechanism was nailed down precisely enough to fix without guessing, and a second, more contained duplication theory was checked and refuted, it became worth landing the fix and the validating tests in the same PR rather than leaving a fully-diagnosed, small, well-scoped bug unfixed. - **Authored by:** interactive session, Claude Code - **Verified:** `pnpm exec vitest run src/lib/litegraph/src/subgraph/SubgraphWidgetPromotion.test.ts` — 51 passed, 0 failed (was 50 passed / 1 expected fail before the fix; that case now passes for real and was flipped from `it.fails` to `it`). `pnpm exec vitest run src/lib/litegraph/src/subgraph/ src/renderer/extensions/vueNodes/widgets/utils/multilineTextarea.promoted.test.ts src/stores/widgetValueStore.test.ts src/stores/domWidgetStore.test.ts` — 413 passed, 0 failed. `pnpm typecheck`, `pnpm lint`, `pnpm knip` — clean. E2E confirmation came from this PR's own CI (see Summary). Re-verified after the 2026-10-01 rebase onto main: same scoped suites green, typecheck/lint/knip clean. - **Deviations:** none remaining. The previous push deliberately left the e2e `test.fail()` cases unflipped pending CI evidence; that evidence has now arrived (see "E2E confirmation" below) and they are flipped to plain `test()` in this push, exactly per the plan recorded in the earlier Test plan. - **Type:** fix + test — a small, contained timing fix plus the tests that prove it, validate/refute an alternate duplication theory, and lock in the browser-level symptom as regression coverage - **Slots into:** a subgraph promoted-widget-promotion bug investigation; no project or epic, ad-hoc follow-up to that investigation - **Not in scope:** `createPromotedMultilineWidget`'s visibility/suppression path — that's PR #18085's territory (a sibling investigation into the same widget family) Rewiring the interior link behind a promoted widget (e.g. dragging a new node onto an already-promoted widget's socket) removes the old link before the new one lands. `SubgraphInputNode`'s `'input-disconnected'` handler used to demote the widget **synchronously** — clearing `input.widgetId`/`.widget`/`._widget` immediately — while deferring the matching `widgetValueStore` cleanup to a `queueMicrotask`. For one tick, `hostNode.widgets.length` (synchronous) and the store's tracked id count for that node (deferred) disagreed. The Vue widget grid (`useProcessedWidgets`/`computeProcessedWidgets`) reads its render *order* from the store and its liveness *filter* from `hostNode.widgets` — i.e. from both sides of that exact disagreement. The fix defers the demotion itself by a microtask (mirroring the already-deferred store cleanup), tracked with a per-input cancellation token. The `'input-connected'` listener clears that token on a same-tick reconnect, so a rewire never drops the widget from `hostNode.widgets` at all. A genuine disconnect with no reconnect still fully demotes once the microtask runs — nothing about final-state behavior changes, only the timing of an in-between state that used to be observable. **Deliberate timing-change note** (per this repo's own ecosystem-impact rule for changes touching `node.widgets` access): this changes when a disconnect becomes observable on `hostNode.widgets` — previously synchronous, now one microtask tick later for a genuine disconnect. Two existing tests in `SubgraphWidgetPromotion.test.ts` asserted this synchronously with no `await`; both were updated to `await Promise.resolve()` after the disconnecting call, with a comment explaining why. No public API shape or callback signature changed — only internal timing. - `SubgraphWidgetPromotion.test.ts`, "keeps every promoted widget present while rewiring the interior link behind one of them" (previously `it.fails`, now a plain `it`): builds a host with 4 promoted widgets from 4 different interior nodes, rewires the link behind one of them onto a *new* interior node mid-test, and asserts `hostNode.widgets.length` stays at 4 throughout — including immediately after the disconnect step, before the reconnect lands. - `SubgraphWidgetPromotion.test.ts`, "Promoted textarea dual-registration (PM-1328 duplication lead)": tests a second, independently-raised theory for the duplication symptom — that a promoted textarea's DOM-hosted widget (a `DOMWidgetImpl` living in `useDomWidgetStore`, materialized by `createPromotedHostWidget`) and a store-projected row could both end up registered for the same input, which would duplicate a row in the widget grid. Built a minimal `SubgraphNode` subclass wired the same way the app's real subclass is, exercised it across a rewire and a `configure()` reconfigure. **Both pass as-is — the theory is refuted.** `_projectPromotedWidget`'s `if (input._widget) return input._widget` guard is unconditional across every call site and there's no observable window where `input.widgetId` is set while `input._widget` isn't. Kept as regression coverage. [35419314544](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/35419314544)) CI on the previous head answered the open question the `test.fail()` repros were posted to ask — the fix **does** resolve the browser-level symptom end-to-end: - Both `subgraphPromotedWidgetRewireDuplication.spec.ts` repro scenarios (interior rewire and external boundary wire) were reported "Expected to fail, but passed" on every run and retry (video job + shard 12, 4/4 retries). Flipped to plain `test()` regression tests, and retitled to describe the behavior they now guarantee. - `subgraphPromotion.spec.ts` "Promoted STRING widget edit survives a rebind of the interior link" — a *pre-existing* `test.fail()` for #14495 — also passed on all 4 shard-12 attempts. Flipped to plain `test()`; hence "Fixes #14495" above. - The external-boundary undo test went through two CI-informed revisions after the rebase: which snapshot undo targets depends on change-tracker capture timing the test cannot control (captures fire on window mouseup, before the click handlers that apply promotions, so the entry pushed by the slot drop — #18117 — can lag the built baseline by one action), and an attempt to pin the snapshot with an extra canvas click timed out in CI. The test now asserts the invariant both reported symptoms violate instead of a fixed widget set: whatever state undo restores, the host's model holds no duplicate widgets and the grid renders exactly one row per model widget, none otherwise. - [x] Watch this PR's `playwright-video-new-tests` CI check: the `test.fail()` cases were reported as unexpectedly passed (run 35419314544) - [x] Flip those cases (and the pre-existing #14495 one) to plain `test()` - [x] Make the external-boundary undo test deterministic (it now asserts render/model consistency after undo instead of assuming which snapshot undo targets) - [ ] CI green on the rebased head (the "Check for AI agent co-author trailers" check was removed from main in #19393; the first commit still carries trailers, and rewording it remains a maintainer call since it rewrites shared history) 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01U6aDANuoAYDtxd9WiCk44Q --------- (cherry picked from commit 9ee67cb) ## Backport adaptation (core/1.54) The fix itself (`SubgraphNode.ts`, `interfaces.ts`) cherry-picked clean and is byte-identical to upstream. Only two test files conflicted, both because the cherry-pick's context included neighbouring code that is not on this branch: - `useErrorClearingHooks.test.ts` — the conflict hunk also carried an unrelated test, "retires an absorbed promoted media error when its host is deleted", which main gained from a different, unbackported PR. Dropped that test and applied only this PR's change to the test that does exist here: make "keeps promoted missing media until the last fanout consumer is deleted" async and await the deferred demotion. - `SubgraphWidgetPromotion.test.ts` — import-only conflict. Accepted the three new imports (`WidgetValue`, `createPromotedMultilineWidget`, `useDomWidgetStore`) required by the new PM-1328 describe block; verified all three modules and symbols exist on this branch. The new block also uses `LegacyWidget`, which main imports from the litegraph barrel in a neighbouring non-conflicting import hunk, so this branch's version of that hunk won and left it out; the test failed with `ReferenceError: LegacyWidget is not defined` until it was added to the barrel import. `LegacyWidget` already exists and is exported from the barrel on this branch. No backport-only compatibility shim was needed and no public API shape or callback signature changed. The deliberate timing change this PR documents (a genuine disconnect becomes observable on `hostNode.widgets` one microtask later) is carried as-is.
Requested by Christian Byrne · Slack thread
ELI5
Dragging a wire out of a slot on a Vue node and dropping it on another slot connects the two nodes, but the undo history never hears about it. Press Ctrl+Z straight after the drop and nothing happens; you first have to click somewhere on the canvas, and that click is what finally writes the undo entry. This PR writes the entry the moment the drop finishes, the same way the classic canvas already does.
Motivation
Before: connect two Vue node slots by dragging, press Ctrl+Z: the link stays. Only a later canvas click, key press or widget edit records the connection, so undo looks like it needs two steps or does nothing.
After: Ctrl+Z right after the drop removes the link.
Why: the change tracker records canvas edits from the window
mouseupevent and fromLGraphCanvas.processMouseUp. The Vue slot drag callspreventDefault()onpointerdown, which suppresses the compatibilitymouseup, and the drop is resolved entirely inside the Vue composable, so neither hook runs andcaptureCanvasState()is never called.Provenance
linkInteraction.spec.ts, new caseundo right after dropping a link on a slot removes that link: fails on the test-only commit (expected 0, received 1links after undo) and passes with the fix. The rest of the spec has the same outcome with and without the fix (9 cases fail in the local sandbox either way: 8toHaveScreenshotbaselines and one minimap overlay intercepting the subgraph button; a control run with the fix stashed reproduced all 9). A local probe confirmed the undo queue holds exactly one entry right after the drop. Root andbrowser_teststypecheck, fullpnpm lint,pnpm format:check, eslint, oxlint and oxfmt on the changed files: clean.Reviewer context
useSlotLinkInteraction.autoPan.test.ts, so the e2e is the lowest level that proves the wiring.How
useSlotLinkInteraction.finishInteraction()callscaptureCanvasState()on the active workflow's change tracker after the drop is resolved and the canvas marked dirty, mirroring theLGraphCanvas.processMouseUpwrapper the tracker installs for the legacy canvas.captureCanvasState()compares against the last snapshot, so a drop that connects nothing pushes no entry, a second capture from any other hook is a no-op, and the legacy path is untouched.Red-green verification
test: cover undo right after a Vue node slot drag-connect(d8f3af7)fix: capture the canvas state when a Vue node slot link drag finishes(2f9f6df)Test plan
Generated by Claude Code