Repository navigation
fix: re-measure Vue node slot offsets after a graph reload so links stay on their slots through undo/redo - #18110
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 2047 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle: 9.93 MB gzip 🔴 +62 BDetailsSummary
Category Glance App Entry Points — 3.81 kB (baseline 3.81 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.45 MB (baseline 1.45 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 132 kB (baseline 132 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 14 added / 14 removed / 4 unchanged Panels & Settings — 638 kB (baseline 638 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 18 unchanged User & Accounts — 37.9 kB (baseline 37.9 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 6 added / 6 removed / 5 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 1 unchanged UI Components — 124 kB (baseline 124 kB) • ⚪ 0 BReusable component library chunks
Status: 7 added / 7 removed / 9 unchanged Data & Services — 3.86 MB (baseline 3.86 MB) • 🔴 +595 BStores, services, APIs, and repositories
Status: 13 added / 13 removed / 3 unchanged Utilities & Hooks — 566 kB (baseline 566 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 19 added / 19 removed / 19 unchanged Vendor & Third-Party — 17.4 MB (baseline 17.4 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 17.7 MB (baseline 17.7 MB) • ⚪ 0 BBundles that do not match a named category
Status: 73 added / 73 removed / 227 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-20T06:07:50.924Z",
"gitSha": "472c823aa857c19c667428fb323a5622a20b58ae",
"branch": "fix/vue-slot-offsets-resync-after-reload",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2022.4849999999606,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.866999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 478.23,
"heapDeltaBytes": 12596180,
"heapUsedBytes": 74589428,
"domNodes": -262,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 10.354000000000003,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2003.6000000000058,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.836,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 497.40299999999996,
"heapDeltaBytes": 10343348,
"heapUsedBytes": 71614148,
"domNodes": -265,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 10.482000000000001,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2081.715000000031,
"styleRecalcs": 80,
"styleRecalcDurationMs": 42.951,
"layouts": 14,
"layoutDurationMs": 5.674,
"taskDurationMs": 1083.979,
"heapDeltaBytes": 15837200,
"heapUsedBytes": 77148532,
"domNodes": -265,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 204.604,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1825.2049999999826,
"styleRecalcs": 76,
"styleRecalcDurationMs": 31.208,
"layouts": 14,
"layoutDurationMs": 4.596,
"taskDurationMs": 771.975,
"heapDeltaBytes": -5845928,
"heapUsedBytes": 56077716,
"domNodes": -262,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 169.20499999999998,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1738.7109999999666,
"styleRecalcs": 32,
"styleRecalcDurationMs": 19.128,
"layouts": 6,
"layoutDurationMs": 1.2710000000000001,
"taskDurationMs": 359.98800000000006,
"heapDeltaBytes": 2042832,
"heapUsedBytes": 64369436,
"domNodes": 75,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 13.179000000000004,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1738.8180000000375,
"styleRecalcs": 32,
"styleRecalcDurationMs": 18.383000000000003,
"layouts": 6,
"layoutDurationMs": 1.3470000000000002,
"taskDurationMs": 342.181,
"heapDeltaBytes": 2188400,
"heapUsedBytes": 64300784,
"domNodes": 76,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 11.801999999999996,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 691.2849999999935,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.754000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 462.252,
"heapDeltaBytes": 18152724,
"heapUsedBytes": 79365628,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 168.219,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 651.0260000000017,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.641000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 456.835,
"heapDeltaBytes": 17962708,
"heapUsedBytes": 79952572,
"domNodes": 16,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 169.956,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2035.7420000000275,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.840000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 476.846,
"heapDeltaBytes": 1354932,
"heapUsedBytes": 82091652,
"domNodes": -249,
"jsHeapTotalBytes": -1806336,
"scriptDurationMs": 37.02899999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2029.4369999999162,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.966999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 577.8059999999999,
"heapDeltaBytes": 2851844,
"heapUsedBytes": 83092132,
"domNodes": -250,
"jsHeapTotalBytes": -1318912,
"scriptDurationMs": 36.032,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2393.876999999975,
"styleRecalcs": 67,
"styleRecalcDurationMs": 14.410000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1772.1709999999998,
"heapDeltaBytes": -654172,
"heapUsedBytes": 78903320,
"domNodes": -255,
"jsHeapTotalBytes": -307200,
"scriptDurationMs": 898.961,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2218.270999999959,
"styleRecalcs": 63,
"styleRecalcDurationMs": 8.955000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1625.893,
"heapDeltaBytes": 13602496,
"heapUsedBytes": 78100056,
"domNodes": -9,
"jsHeapTotalBytes": 487424,
"scriptDurationMs": 850.905,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-zoom",
"durationMs": 3857.819999999947,
"styleRecalcs": 60,
"styleRecalcDurationMs": 11.883999999999999,
"layouts": 60,
"layoutDurationMs": 15.588,
"taskDurationMs": 1893.192,
"heapDeltaBytes": 10125236,
"heapUsedBytes": 75039396,
"domNodes": -261,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 873.1370000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3669.059999999945,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.429999999999998,
"layouts": 60,
"layoutDurationMs": 13.785000000000002,
"taskDurationMs": 1765.32,
"heapDeltaBytes": 8274716,
"heapUsedBytes": 73975476,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 814.3580000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "legacy-node-drag",
"durationMs": 3181.5709999999626,
"styleRecalcs": 41,
"styleRecalcDurationMs": 6.785999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2081.1259999999997,
"heapDeltaBytes": 24026332,
"heapUsedBytes": 89545912,
"domNodes": -260,
"jsHeapTotalBytes": 942080,
"scriptDurationMs": 1057.566,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3160.5349999999817,
"styleRecalcs": 41,
"styleRecalcDurationMs": 5.981000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1987.456,
"heapDeltaBytes": 22816152,
"heapUsedBytes": 88945876,
"domNodes": 2,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 995.0770000000001,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2030.5329999999913,
"styleRecalcs": 3,
"styleRecalcDurationMs": 3.0480000000000023,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 571.31,
"heapDeltaBytes": -3673624,
"heapUsedBytes": 84028004,
"domNodes": -257,
"jsHeapTotalBytes": -1282048,
"scriptDurationMs": 37.561,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2011.6930000000366,
"styleRecalcs": 2,
"styleRecalcDurationMs": 2.162000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 561.0410000000002,
"heapDeltaBytes": 19729492,
"heapUsedBytes": 83768880,
"domNodes": -258,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 33.97899999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 621.6570000000274,
"styleRecalcs": 47,
"styleRecalcDurationMs": 13.091000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 431.52000000000004,
"heapDeltaBytes": 13460824,
"heapUsedBytes": 76970560,
"domNodes": 20,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 154.71099999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 573.1359999999768,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.121,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 410.515,
"heapDeltaBytes": 13611636,
"heapUsedBytes": 76923192,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 143.373,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2012.222999999949,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.992,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 461.85800000000006,
"heapDeltaBytes": 539532,
"heapUsedBytes": 63977232,
"domNodes": -278,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 8.098999999999998,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2017.8500000000668,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.987000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 468.174,
"heapDeltaBytes": 18278392,
"heapUsedBytes": 81596456,
"domNodes": -277,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 9.318,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1739.4780000000196,
"styleRecalcs": 77,
"styleRecalcDurationMs": 31.515,
"layouts": 18,
"layoutDurationMs": 5.938,
"taskDurationMs": 883.076,
"heapDeltaBytes": 4181920,
"heapUsedBytes": 67412260,
"domNodes": -278,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 124.64899999999999,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1717.6130000000285,
"styleRecalcs": 79,
"styleRecalcDurationMs": 27.705000000000002,
"layouts": 18,
"layoutDurationMs": 4.97,
"taskDurationMs": 813.5419999999999,
"heapDeltaBytes": 3802100,
"heapUsedBytes": 67367480,
"domNodes": -279,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 111.649,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1385.8960000000025,
"styleRecalcs": 18,
"styleRecalcDurationMs": 29.774,
"layouts": 5,
"layoutDurationMs": 13.234,
"taskDurationMs": 909.7330000000002,
"heapDeltaBytes": -6504292,
"heapUsedBytes": 84496340,
"domNodes": 13587,
"jsHeapTotalBytes": 11534336,
"scriptDurationMs": 29.36500000000001,
"eventListeners": 2383,
"totalBlockingTimeMs": 143,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8967.339000000038,
"styleRecalcs": 247,
"styleRecalcDurationMs": 41.234,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6227.606,
"heapDeltaBytes": -4039276,
"heapUsedBytes": 75413208,
"domNodes": -249,
"jsHeapTotalBytes": 446464,
"scriptDurationMs": 2934.791,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8467.136000000097,
"styleRecalcs": 246,
"styleRecalcDurationMs": 35.628,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5958.65,
"heapDeltaBytes": -4561168,
"heapUsedBytes": 75390188,
"domNodes": -253,
"jsHeapTotalBytes": 217088,
"scriptDurationMs": 2819.9519999999998,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-large-graph-idle",
"durationMs": 17681.3820000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17077.515,
"heapDeltaBytes": -31627604,
"heapUsedBytes": 182171804,
"domNodes": -8061,
"jsHeapTotalBytes": -13115392,
"scriptDurationMs": 282.721,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17217.53100000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16816.23,
"heapDeltaBytes": -45024636,
"heapUsedBytes": 169763396,
"domNodes": -8061,
"jsHeapTotalBytes": -11874304,
"scriptDurationMs": 275.258,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21326.876999999968,
"styleRecalcs": 160,
"styleRecalcDurationMs": 20.175999999999974,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21139.916999999998,
"heapDeltaBytes": -24098524,
"heapUsedBytes": 190174924,
"domNodes": -8061,
"jsHeapTotalBytes": -15806464,
"scriptDurationMs": 913.891,
"eventListeners": -14928,
"totalBlockingTimeMs": 77,
"frameDurationMs": 18.330000000000048,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 21087.597999999958,
"styleRecalcs": 156,
"styleRecalcDurationMs": 17.757999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20909.609,
"heapDeltaBytes": -30504376,
"heapUsedBytes": 179183352,
"domNodes": -8061,
"jsHeapTotalBytes": -13176832,
"scriptDurationMs": 885.212,
"eventListeners": -14928,
"totalBlockingTimeMs": 116,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6423.2880000000705,
"styleRecalcs": 20,
"styleRecalcDurationMs": 78.405,
"layouts": 20,
"layoutDurationMs": 23.552000000000003,
"taskDurationMs": 6320.809,
"heapDeltaBytes": -29970032,
"heapUsedBytes": 184468264,
"domNodes": -8061,
"jsHeapTotalBytes": 16244736,
"scriptDurationMs": 118.033,
"eventListeners": -14928,
"totalBlockingTimeMs": 421,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 6258.99400000003,
"styleRecalcs": 20,
"styleRecalcDurationMs": 81.12799999999997,
"layouts": 20,
"layoutDurationMs": 25.27299999999999,
"taskDurationMs": 6196.6359999999995,
"heapDeltaBytes": -54233488,
"heapUsedBytes": 175775884,
"domNodes": -8061,
"jsHeapTotalBytes": 19939328,
"scriptDurationMs": 109.49400000000001,
"eventListeners": -14928,
"totalBlockingTimeMs": 377,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8953.666999999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8712.288,
"heapDeltaBytes": 33156108,
"heapUsedBytes": 189881080,
"domNodes": 0,
"jsHeapTotalBytes": -10747904,
"scriptDurationMs": 132.99499999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8902.430999999979,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8654.402,
"heapDeltaBytes": 21809096,
"heapUsedBytes": 190220688,
"domNodes": 0,
"jsHeapTotalBytes": -6291456,
"scriptDurationMs": 136.04100000000008,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 482.65300000002753,
"styleRecalcs": 19,
"styleRecalcDurationMs": 31.019,
"layouts": 4,
"layoutDurationMs": 2.18,
"taskDurationMs": 141.548,
"heapDeltaBytes": 5046792,
"heapUsedBytes": 66840172,
"domNodes": 147,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 11.689,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 453.3339999999271,
"styleRecalcs": 12,
"styleRecalcDurationMs": 19.955000000000002,
"layouts": 3,
"layoutDurationMs": 1.0630000000000002,
"taskDurationMs": 115.11399999999999,
"heapDeltaBytes": 4873804,
"heapUsedBytes": 66455932,
"domNodes": 119,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 11.037,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since ff8246bc1e575b46a3a2457623ec448fc98420ed
Full docs: ADR-DEVEX-LINT-0015 🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
Playwright videos for new testsDownload the recorded videos and HTML report Recorded projects: chromium Recorded test titles:
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #18110 +/- ##
==========================================
+ Coverage 82.85% 83.82% +0.97%
==========================================
Files 2950 2254 -696
Lines 145221 128257 -16964
Branches 39277 32668 -6609
==========================================
- Hits 120322 107515 -12807
+ Misses 23630 20453 -3177
+ Partials 1269 289 -980
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 707 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Undo and redo reload the graph, which drops every DOM-measured slot offset while the Vue node stays mounted with identical rows. Litegraph then falls back to its own widget layout for the link endpoint, so the wire lands on the wrong row: 38px below the width dot on a promoted subgraph host, 10px on a plain EmptyLatentImage. Ports the repro spec from #18085 with the drift case as a real table-driven regression test covering a plain node too, and adds a NodeSlots case for re-measuring after the layout store clears the graph.
Undo and redo reload the graph through LGraph.configure, whose clear purges every DOM-measured slot offset for the root graph. A Vue node that survives the reload with identical rows and size never re-measured, so link endpoints fell back to litegraph's own widget layout and drew the wire a row off the slot dot. The layout store now exposes a reactive slotOffsetVersion that is bumped only when slot offsets are dropped in bulk (clearGraph, clearViewGeometry), and NodeSlots adds it to its syncSlotOffsets watch. Every mounted Vue node renders one NodeSlots, and syncSlotOffsets measures the whole node element, so one trigger per node restores every slot offset after a reload.
4c58b84 to
c4e5b77
Compare
|
@coderabbitai review Generated by Claude Code |
christian-byrne
left a comment
There was a problem hiding this comment.
slotOffsetVersion restores mounted-node measurements after graph reload without feeding measurement writes back into the watcher. No remaining blocker found in this bounded rendering fix; original agent-workflow and release acceptance remain open.
Full context for agent readers
Reviewed production, component regression, workflow fixture and browser assertions. The counter changes only when cached measurements are removed, and the existing post-render watcher recomputes offsets. This is transient frontend geometry, not a shared-document or persistence change.
Independent pre-fix checkout fails the component assertion (missing offset) and both browser drift assertions (38 pixels on promoted width, 10 pixels on plain batch size). The refreshed tree passes 265 layout/component tests and all six browser cases. Build, source/browser typechecks, lint, formatting and unused-code checks pass. The final inspected screenshot shows width aligned and height separate; the trace records undo, disconnection, redo, reconnection and the endpoint assertion. The short recording alone is insufficient to judge those rapid intermediate states.
Refreshed the test expectations against the merged label fix and Christian's visible-but-disabled decision. Removed obsolete expected-failure markers without dropping label assertions. Promoted text now asserts enabled before wiring, visible and disabled afterward, plus socket visibility. Plain text retains its hiding assertion. These supersede the stale expected-failure description in the PR body.
The test deliberately commits the drag with a blank-canvas click. It does not resolve the separate missed undo-entry or extra redo-entry tasks. Original agent-connect/save-reload and release acceptance remain owned in the Linear follow-through. Neither 1.54 target has qualified for a clean backport because the component regression hunk conflicts; target-native test adaptation remains tracked.
Glossary: slot offset is a measured wire endpoint; promoted widget exposes an inner-node control on its enclosing subgraph; expected failure marks a known failing test rather than fixing its defect.
…t a cloud carrier (#18257) ## Summary Eight merged `main` Agent fixes that had no `cloud/1.54` carrier are cherry-picked onto the current release tip. Two sources need hand re-expression and are excluded. Runtime source is unmodified from the eight sources; seven follow-up commits are test-only adaptations to the release's module surface. Verification at the current head `2991cfc3f8` is hosted CI (77 success, 16 skipped, 0 failed) plus DrJKL's local run (see below); the picked browser specs had not been run against the target before this PR. Open gates: release-scope sign-off on the three non-Agent carries and exact-head human re-approval on `2991cfc3f8`, both tracked in [blocked-on-christian 825](christian-byrne/blocked-on-christian#825). Replaces [18254](#18254): six picks there inherited `Co-authored-by: Claude` trailers from the `main` squash commits and failed the AI co-author check. Runtime source is byte-identical to that PR's head `d1f35ac622`; two test files differ (listed under Adaptations). <details><summary>Full context for agent readers</summary> ## Changes Sources, all `cherry-pick -x -m 1`, clean, in merge order: - [18104](#18104) prefer previewUrl for dragged batch-output attachments - [18110](#18110) re-measure Vue node slot offsets after graph reload - [18117](#18117) record an undo entry when a link is dropped from a Vue node slot - [18118](#18118) stop a canvas click after redo from pushing a spurious undo entry - [18124](#18124) never silently no-op the subscription-required dialog - [18127](#18127) restore autogrow inputs after Agent reconciliation - [18191](#18191) keep the ghost placement flag out of the CRDT document - [18196](#18196) retarget new Agent chat to the workflow tab on screen Adaptations, all test-only, no runtime change: - `NodeSlots` reload unit test uses `createTestingPinia` + `setActivePinia` instead of `getActivePinia()!`, because the shared test Pinia setup from [17237](#17237) is `main`-only. - Browser fixture gains `NodeSlotReference.expectLinkCount` (same body as `main`, from [17403](#17403)); three picked Agent specs open the panel with the label the release UI renders, `agent.askComfyAgent`, because `agent.entryButton` from [17621](#17621) does not exist on this line. - `useSlotLinkInteraction.autoPan.test.ts`: the `globalEnums` mock is dropped (the picked composable now reads `RenderShape` from the real module, as on `main`), and the `@vueuse/core` mock spreads the actual module so release-native transitive imports such as `useStorage` resolve while the event-listener overrides stay focused. - `useSlotLinkInteraction.autoPan.test.ts` (`249123390c`): the workflow store is mocked at its seam instead of a partial module mock, per dante01yoon's review. - `subgraphPromotedWidgetExternalLink.spec.ts` (`2991cfc3f8`): the plain CLIPTextEncode "hides the text control" case and its two constants are deleted, because it asserts [17576](#17576) behavior (WidgetGrid retains labels for connected inputs) that is not on `cloud/1.54`. Re-add when 17576 lands on this line; the 17576 decision is [blocked-on-christian 824](christian-byrne/blocked-on-christian#824). Dependencies: none added; release lockfile pins preserved. Exclusions: [18063](#18063) and [18073](#18073) conflict because they edit `agentCrdtProjection.ts` and `agentCrdtDocLifecycle.ts`, files created by the follower split in [16908](#16908), which `cloud/1.54` never received. They need focused hand re-expression onto the pre-split follower, following [18219](#18219) and [18195](#18195); tracked as separate program rows. ## Review focus - Every source commit is an unmodified cherry-pick; review effort belongs on the test-only adaptation commits and on whether the eight sources are wanted on this line at all. - Sources 18110, 18117, and 18118 touch undo/redo and slot measurement outside the Agent panel, so they change behavior for users who never open the Agent. - This is not behavioral acceptance or a merge-check waiver; no target-native browser acceptance has run outside hosted CI. ## Exact-head verification Head history: `210e191fc9` (approved by DrJKL) received five test-only follow-ups: `a9ab888243` (module-surface alignment), `a63fef35ae` (`test.fixme` instead of `test.skip`, which the release's oxlint config rejects), `118ac5e9c6` (restore VueUse exports in the auto-pan mock, fixing the suite-collection failure DrJKL found at `a63fef35ae`), `249123390c` (workflow-store seam mock), and `2991cfc3f8` (delete the plain CLIPTextEncode browser case). - `210e191fc9`, local on top of `cloud/1.54` tip `1bbcdc66fa`: cherry-pick dry run of all 10 candidates, 8 clean individually and as a sequential stack, 2 conflicting as described above; `vitest run` on the 9 touched unit test files 405 passed; both `vue-tsc` projects exit 0; `oxfmt` and `eslint` clean; lint-staged and knip passed in hooks. - `a63fef35ae`, hosted: `lint-and-format` passed. DrJKL's local focused run: 405 passed plus one suite-collection failure in `useSlotLinkInteraction.autoPan.test.ts` (`useStorage` missing from the total `@vueuse/core` mock). Fixed in `118ac5e9c6`. - `118ac5e9c6`: hosted CI green; the unit `test` job covers the collection fix. - `2991cfc3f8` (current head): hosted CI 77 success, 16 skipped, 0 failed. DrJKL's local run on this head: both typecheck projects, ESLint, Oxlint, format, and Knip clean; Vitest 4 of 4 on the auto-pan suite; Playwright discovery 43 tests across 7 specs; Fallow clean. Author-side local verification is not run on this head (host resource hold); hosted CI plus DrJKL's run are the verification of record. Program receipt: [2026-09-21-ms215-gap-backport-cloud154.md](https://github.com/christian-byrne/in-app-agent-program/blob/main/reports/pr-ownership/2026-09-21-ms215-gap-backport-cloud154.md). </details> --------- Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> Co-authored-by: test-bot <test-bot@users.noreply.github.com> Co-authored-by: Alexander Brown <drjkl@comfy.org> Co-authored-by: Amp <amp@ampcode.com>
Requested by Christian Byrne · Slack thread
ELI5
A Vue node measures where each of its slot dots sits and stores the measurements so the canvas knows where to draw the wire end. Undo and redo rebuild the graph from a snapshot, and that rebuild throws all those measurements away, but the node on screen never changes and never re-measures. With no measurement the canvas falls back to its own guess of where the widget row is, and that guess can be a full row off, so the wire visibly lands on the wrong slot. This PR tells mounted Vue nodes to measure again whenever their stored measurements are dropped.
Motivation
Before: wiring a node into a Vue-rendered widget slot, then pressing undo and redo, could leave the wire end drawn on a different row than the slot dot it is connected to (38 px off on a promoted subgraph host with a multiline text widget above the slot, 10 px off on a plain EmptyLatentImage's third widget). The link stayed correct in the graph, only its rendering was wrong, and it stayed wrong until something else resized the node. After: the wire end stays on the slot dot through undo and redo, for subgraph hosts and plain nodes alike.
Why: the graph reload behind undo and redo purges every DOM-measured slot offset from the layout store, and nothing re-measured a Vue node that survived the reload with identical rows and size.
Provenance
subgraphPromotedWidgetExternalLink.spec.tsdrift rows on the test-only commit: 2 failed on the drift assertion (host 38 px, plain batch_size 10 px); with the fix: both pass and the rest of the spec keeps its expected outcomes. Vitestsrc/renderer/core/layout+src/renderer/extensions/vueNodes/components: 33 files, 262 passed (the new NodeSlots case fails pre-fix withexpected null to deeply equal { x: 0, y: 20 }).vue-tsc --noEmitandvue-tsc --project browser_tests/tsconfig.json: clean. eslint, oxlint, oxfmt on the changed files: clean.knip --cache: clean.changeTracker.spec.tsfails identically in the local sandbox with and without the fix (legacy-canvas collapse clicks and default-workflow node locators), so those failures are environmental there; CI is the arbiter.Reviewer context
test.fail()drift case (keeps the wire on the promoted width slot dot after undo and redo), which becomes a real table-driven regression test here with a plain-node row added; test: add failing repros for promoted widget external-link rendering #18085 should drop that case once this lands. The label and textarea cases no longer carrytest.fail(): the width-label cases assert the label stays visible after wiring, and the promoted text case asserts the textarea is enabled before wiring and visible but disabled afterward, with its input slot dot shown.How
layoutStoregains a reactiveslotOffsetVersionthat is bumped only when measured slot offsets are dropped in bulk (clearGraph,clearViewGeometry), never on a measurement write, so re-measuring cannot feed back into itself.NodeSlots.vueadds that version to its existingsyncSlotOffsetswatch. Every mounted Vue node renders oneNodeSlots, andsyncSlotOffsetsmeasures the whole[data-node-id]element, so one trigger per node re-measures every slot (inputs, outputs and widget rows). Purging on clear stays as is; keeping stale offsets would be wrong when the reload does change rows.Red-green verification
test: cover the wire drifting off a Vue widget slot after undo and redofix: re-measure Vue node slot offsets after the layout store drops themTest plan
Generated by Claude Code