Repository navigation
[backport core/1.54] test: pin PM-1303 Flux2ImageNode prompt box collapse across generations (#18098) - #18514
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
…ns (#18098) Remove stale execution progress widgets. Preserve other workflows' widgets. Prompt-height collapse remains unresolved. <details><summary>Full context for agent readers</summary> This began as reproduction-only coverage, but now includes production cleanup in `executionStore`: completion, interruption and error remove the progress widget from the viewed workflow before queued-job state is deleted. Review found and repaired a cross-workflow bug: identical node IDs in another tab must not be cleaned up. Cleanup also uses the existing subgraph-aware execution-ID mapping. This is a partial fix for the [Flux prompt incident](https://linear.app/comfyorg/issue/PM-1303) and its [reproduction task](https://linear.app/comfyorg/issue/PM-1310), not closure of either. The prompt stays registered and retains its typed text through two generations, but remains vertically collapsed. The height assertion stays expected-failing. A separate conflict-free replicated data type (CRDT) reconciliation test retains the known stale-snapshot value-overwrite reproduction; that is not fixed here. Christian's [completion lane](https://ampcode.com/threads/T-01a0bb17-0593-72cc-840e-4120f777fdf0) takes the broader assignment on merge: repair prompt-height allocation, resolve or rule out the Cloud reconciliation candidate against the original workflow, and verify both 1.54 releases. Program tracking is in `claude-handoff-9` on the [program board](https://github.com/christian-byrne/in-app-agent-program/blob/main/todo.md). No clean-backport label until full target-native source, API and fixture qualification. Original context: [Christian's Slack request](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1789700733927729), [preserved Claude session](https://claude.ai/code/session_01Stfza8cuRcz7X1SkxmpDt1). </details> - Execution store: 141 tests pass, including success/error/interruption cleanup and cross-workflow/subgraph exclusions. The cross-workflow counterexample failed before the guard. - Browser: prompt type, registration, and node/registry cleanup pass; retained height-collapse case remains expected-failing. The final recording shows intact text, no stale Running line, and a still-collapsed textarea. - Reconciliation reproduction: one pass, one existing expected failure. - Source/browser typechecks, lint/format and Cloud build pass. Native checks remain merge gates. - Full screenshot scenario retains a local eight-pixel initial-baseline mismatch; no golden was rewritten. A later mistaken Cloud-build/Chromium-project run failed during boot and is not counted as behavioral evidence. The successful rerun used the matching localhost surface and Chromium project. Glossary: progress widget is the temporary execution-status row; CRDT is the synchronized graph document; an expected failure records an unresolved defect, not a completed fix. --------- Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: bymyself <cbyrne@comfy.org> ## Manual backport notes (core/1.54) Automated backport failed on `src/stores/executionStore.test.ts` (target's hoisted-mocks block already had more mocks than this PR's simpler version). Resolved by keeping target's block and adding `mockRemoveTextPreview` to it. Other fixes needed to make the cherry-pick compile/pass on this branch: - Added missing `fromPartial` (`@total-typescript/shoehorn`) and `useWorkflowStore` imports the new tests need, matching main's imports that target's test file predates. - Replaced `useWorkflowStore().activeWorkflow = ...` (target's mock exposes `activeWorkflow` as a read-only getter) with the existing `mockActiveWorkflow.value = ...` pattern already used elsewhere in this file, and set it from `store.queuedJobs['job-1'].workflow` (not the local `workflow` var) so it holds the same Vue-reactivity-wrapped reference as `queuedJobs`, matching production `workflowStore`/`queuedJobs` identity semantics that target's shallowRef-based mock doesn't reproduce otherwise. - Dropped `src/workbench/extensions/agent/crdt/ecsFollowerAdapter.promptReconcile.test.ts`. It imports `AgentCrdtProjection` from `./agentCrdtProjection`, a module that doesn't exist on core/1.54 (refactored away in #16908, split into `ecsFollowerAdapter.ts`/`graphMutations.ts`/`followerDoc.ts`). This test is an unrelated CRDT-reconciliation reproduction the PR body explicitly says is "not fixed here"; porting it to the refactored API is out of scope for this backport. Verified: `pnpm exec vitest run src/stores/executionStore.test.ts` (138/138 pass), `pnpm exec vue-tsc --noEmit`, `pnpm exec oxlint` all clean on this branch.
🎭 Playwright: ✅ 1943 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-23T03:54:55.457Z",
"gitSha": "612e06b6d36ee9e310b041325599fb1105c9c981",
"branch": "backport-18098-to-core-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2055.5060000000367,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.498000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 527.42,
"heapDeltaBytes": 11592860,
"heapUsedBytes": 82226956,
"domNodes": -280,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 8.408999999999999,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2051.5139999999974,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.119000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 494.85,
"heapDeltaBytes": 1033088,
"heapUsedBytes": 71559280,
"domNodes": -280,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 8.438999999999998,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2032.1460000000116,
"styleRecalcs": 80,
"styleRecalcDurationMs": 29.497,
"layouts": 14,
"layoutDurationMs": 3.9029999999999996,
"taskDurationMs": 987.1920000000001,
"heapDeltaBytes": -7025136,
"heapUsedBytes": 62292240,
"domNodes": -282,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 183.51099999999997,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1823.6499999999864,
"styleRecalcs": 74,
"styleRecalcDurationMs": 26.197,
"layouts": 14,
"layoutDurationMs": 3.7390000000000003,
"taskDurationMs": 857.924,
"heapDeltaBytes": 13485324,
"heapUsedBytes": 84296832,
"domNodes": -282,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 156.32000000000002,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1738.9949999999885,
"styleRecalcs": 33,
"styleRecalcDurationMs": 17.569000000000003,
"layouts": 6,
"layoutDurationMs": 1.133,
"taskDurationMs": 378.18800000000005,
"heapDeltaBytes": 4544064,
"heapUsedBytes": 74822660,
"domNodes": 77,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 12.209000000000001,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1659.695000000056,
"styleRecalcs": 31,
"styleRecalcDurationMs": 13.472000000000001,
"layouts": 6,
"layoutDurationMs": 0.9880000000000002,
"taskDurationMs": 344.122,
"heapDeltaBytes": 4287808,
"heapUsedBytes": 74317440,
"domNodes": 75,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 9.699,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 665.9619999999791,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.567999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 456.18199999999996,
"heapDeltaBytes": -7207280,
"heapUsedBytes": 63458996,
"domNodes": 20,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 162.235,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 671.1379999999849,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.784999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 472.68799999999993,
"heapDeltaBytes": 18679744,
"heapUsedBytes": 87754880,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 181.9,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2050.9380000000306,
"styleRecalcs": 6,
"styleRecalcDurationMs": 11.536999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 615.0500000000001,
"heapDeltaBytes": 8004040,
"heapUsedBytes": 83855380,
"domNodes": -276,
"jsHeapTotalBytes": -1155072,
"scriptDurationMs": 34.797999999999995,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2040.0899999999638,
"styleRecalcs": 4,
"styleRecalcDurationMs": 4.930999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 593.6550000000001,
"heapDeltaBytes": -15196832,
"heapUsedBytes": 87791188,
"domNodes": -270,
"jsHeapTotalBytes": -1380352,
"scriptDurationMs": 31.042,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2331.605999999965,
"styleRecalcs": 65,
"styleRecalcDurationMs": 9.389000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1675.8899999999999,
"heapDeltaBytes": -14417820,
"heapUsedBytes": 89619696,
"domNodes": -273,
"jsHeapTotalBytes": -1417216,
"scriptDurationMs": 838.594,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2290.4989999999543,
"styleRecalcs": 67,
"styleRecalcDurationMs": 11.383000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1662.0110000000002,
"heapDeltaBytes": -1261572,
"heapUsedBytes": 76013612,
"domNodes": -286,
"jsHeapTotalBytes": -929792,
"scriptDurationMs": 819.9000000000001,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3498.6599999999726,
"styleRecalcs": 60,
"styleRecalcDurationMs": 9.301,
"layouts": 60,
"layoutDurationMs": 11.635000000000002,
"taskDurationMs": 1643.7869999999998,
"heapDeltaBytes": 12063544,
"heapUsedBytes": 80100560,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 766.672,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3568.1039999999484,
"styleRecalcs": 61,
"styleRecalcDurationMs": 10.427,
"layouts": 60,
"layoutDurationMs": 11.562,
"taskDurationMs": 1706.917,
"heapDeltaBytes": 10232108,
"heapUsedBytes": 77139272,
"domNodes": -278,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 785.5640000000001,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3172.9859999999803,
"styleRecalcs": 41,
"styleRecalcDurationMs": 5.931000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1968.449,
"heapDeltaBytes": 12444764,
"heapUsedBytes": 93075988,
"domNodes": -284,
"jsHeapTotalBytes": -212992,
"scriptDurationMs": 975.703,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3160.92500000002,
"styleRecalcs": 43,
"styleRecalcDurationMs": 8.226999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1978.082,
"heapDeltaBytes": 5865496,
"heapUsedBytes": 86833856,
"domNodes": -280,
"jsHeapTotalBytes": 1097728,
"scriptDurationMs": 994.4710000000001,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2032.1460000000116,
"styleRecalcs": 4,
"styleRecalcDurationMs": 4.285000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 600.7330000000001,
"heapDeltaBytes": 10446408,
"heapUsedBytes": 87112184,
"domNodes": -274,
"jsHeapTotalBytes": -2203648,
"scriptDurationMs": 35.76700000000001,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2059.077000000002,
"styleRecalcs": 6,
"styleRecalcDurationMs": 6.3160000000000025,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 634.612,
"heapDeltaBytes": 6641960,
"heapUsedBytes": 83910740,
"domNodes": -274,
"jsHeapTotalBytes": -630784,
"scriptDurationMs": 36.41799999999999,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 572.8179999999838,
"styleRecalcs": 48,
"styleRecalcDurationMs": 11.572000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 408.754,
"heapDeltaBytes": 14962420,
"heapUsedBytes": 88090100,
"domNodes": 22,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 141.56400000000002,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 638.0759999999555,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.703000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 428.465,
"heapDeltaBytes": 14154104,
"heapUsedBytes": 86257620,
"domNodes": 18,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 152.79999999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2021.4859999999817,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.596000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 475.8800000000001,
"heapDeltaBytes": -1141192,
"heapUsedBytes": 70918160,
"domNodes": -297,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 7.290000000000001,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2015.1650000000245,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.540999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 480.692,
"heapDeltaBytes": -14536456,
"heapUsedBytes": 58591048,
"domNodes": -294,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 7.516000000000002,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1725.0569999999925,
"styleRecalcs": 77,
"styleRecalcDurationMs": 26.177,
"layouts": 18,
"layoutDurationMs": 4.614,
"taskDurationMs": 793.944,
"heapDeltaBytes": -14784072,
"heapUsedBytes": 58078364,
"domNodes": -296,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 109.34700000000001,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1755.6200000000217,
"styleRecalcs": 77,
"styleRecalcDurationMs": 24.735,
"layouts": 18,
"layoutDurationMs": 4.268,
"taskDurationMs": 808.616,
"heapDeltaBytes": -7532088,
"heapUsedBytes": 65622576,
"domNodes": -299,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 108.225,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-transition-enter",
"durationMs": 1417.0520000000124,
"styleRecalcs": 19,
"styleRecalcDurationMs": 31.300000000000008,
"layouts": 15,
"layoutDurationMs": 15.233999999999998,
"taskDurationMs": 936.5769999999998,
"heapDeltaBytes": 19275772,
"heapUsedBytes": 108305552,
"domNodes": 13751,
"jsHeapTotalBytes": 12582912,
"scriptDurationMs": 30.083000000000006,
"eventListeners": 2385,
"totalBlockingTimeMs": 143,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8383.846000000005,
"styleRecalcs": 246,
"styleRecalcDurationMs": 32.412,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5780.545999999999,
"heapDeltaBytes": 12694652,
"heapUsedBytes": 89141892,
"domNodes": -271,
"jsHeapTotalBytes": -929792,
"scriptDurationMs": 2715.4880000000003,
"eventListeners": -178,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8432.42500000008,
"styleRecalcs": 248,
"styleRecalcDurationMs": 36.294999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5826.342000000001,
"heapDeltaBytes": 9149332,
"heapUsedBytes": 84920072,
"domNodes": -271,
"jsHeapTotalBytes": 643072,
"scriptDurationMs": 2741.3219999999997,
"eventListeners": -178,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16879.413999999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16413.041,
"heapDeltaBytes": -52936672,
"heapUsedBytes": 182357456,
"domNodes": -8068,
"jsHeapTotalBytes": -13500416,
"scriptDurationMs": 276.016,
"eventListeners": -14931,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16971.515999999952,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16556.243000000002,
"heapDeltaBytes": -40615488,
"heapUsedBytes": 182466284,
"domNodes": -8068,
"jsHeapTotalBytes": -9875456,
"scriptDurationMs": 272.13,
"eventListeners": -14929,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20660.053000000004,
"styleRecalcs": 177,
"styleRecalcDurationMs": 17.55000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20289.892,
"heapDeltaBytes": -35068104,
"heapUsedBytes": 182705964,
"domNodes": -8068,
"jsHeapTotalBytes": -10235904,
"scriptDurationMs": 911.7940000000001,
"eventListeners": -14927,
"totalBlockingTimeMs": 46,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 20685.22299999995,
"styleRecalcs": 175,
"styleRecalcDurationMs": 17.884999999999984,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20271.832,
"heapDeltaBytes": -49677004,
"heapUsedBytes": 168835660,
"domNodes": -8068,
"jsHeapTotalBytes": -10235904,
"scriptDurationMs": 934.395,
"eventListeners": -14927,
"totalBlockingTimeMs": 107,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 6161.7089999999735,
"styleRecalcs": 20,
"styleRecalcDurationMs": 78.86500000000002,
"layouts": 20,
"layoutDurationMs": 22.54499999999998,
"taskDurationMs": 6033.818,
"heapDeltaBytes": -44667396,
"heapUsedBytes": 183480964,
"domNodes": -8068,
"jsHeapTotalBytes": 7184384,
"scriptDurationMs": 108.741,
"eventListeners": -14927,
"totalBlockingTimeMs": 414,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 6054.24000000005,
"styleRecalcs": 20,
"styleRecalcDurationMs": 78.816,
"layouts": 20,
"layoutDurationMs": 22.375999999999994,
"taskDurationMs": 5973.456999999999,
"heapDeltaBytes": -41279348,
"heapUsedBytes": 184248424,
"domNodes": -8068,
"jsHeapTotalBytes": 13934592,
"scriptDurationMs": 108.49400000000001,
"eventListeners": -14927,
"totalBlockingTimeMs": 384,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8604.927999999973,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8340.496000000001,
"heapDeltaBytes": 17017700,
"heapUsedBytes": 178134916,
"domNodes": 0,
"jsHeapTotalBytes": -12320768,
"scriptDurationMs": 132.14000000000004,
"eventListeners": -14,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8424.542000000089,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8228.431999999997,
"heapDeltaBytes": 7475804,
"heapUsedBytes": 179391976,
"domNodes": 0,
"jsHeapTotalBytes": -11534336,
"scriptDurationMs": 127.26899999999996,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 485.4220000000282,
"styleRecalcs": 18,
"styleRecalcDurationMs": 23.028,
"layouts": 4,
"layoutDurationMs": 1.8650000000000002,
"taskDurationMs": 118.904,
"heapDeltaBytes": 5083816,
"heapUsedBytes": 74018644,
"domNodes": 147,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 13.974000000000002,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 117.0830000000933,
"styleRecalcs": 7,
"styleRecalcDurationMs": 19.864,
"layouts": 3,
"layoutDurationMs": 1.671,
"taskDurationMs": 87.426,
"heapDeltaBytes": 2981324,
"heapUsedBytes": 70936740,
"domNodes": 128,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 8.147000000000002,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E CoverageNote Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.
Top 10 files by uncovered lines
|
7b13f0b to
43ef618
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.54 #18514 +/- ##
=============================================
+ Coverage 83.57% 83.60% +0.03%
=============================================
Files 2094 2096 +2
Lines 123694 123811 +117
Branches 33365 31543 -1822
=============================================
+ Hits 103377 103517 +140
+ Misses 20138 20115 -23
Partials 179 179
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 17 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Requested by Christian Byrne · Slack thread
Manual backport of #18098 to
core/1.54. The automated backport failed with a merge conflict insrc/stores/executionStore.test.ts(comment: #18098 (comment)).Why manual
Target's hoisted-mocks block in the test file already had more mocks (from separate, already-landed test-infra work on this branch) than the version this PR's diff was based on. Resolved by keeping target's block and adding this PR's
mockRemoveTextPreviewmock into it, rather than accepting either side wholesale.Verified the diff is not already effectively present on
core/1.54(git diff --cached origin/core/1.54was non-empty after the cherry-pick — this is a real, needed backport, not a stacking false-positive).Additional fixes required on top of the raw cherry-pick
fromPartial(@total-typescript/shoehorn) anduseWorkflowStoreimports the new tests need (present onmain, absent from target's older version of the test file).workflowStoremock exposesactiveWorkflowas a read-only getter (useWorkflowStore().activeWorkflow = ...throws). Switched the new tests to the existingmockActiveWorkflow.value = ...pattern already used elsewhere in the file, sourcing the value fromstore.queuedJobs['job-1'].workflow(not the localworkflowvar) so it carries the same Vue-reactivity-wrapped identity asqueuedJobs, which is what the new production check (job.workflow === workflowStore.activeWorkflow) inexecutionStore.tsrelies on. The target'sshallowRef-based mock doesn't reproduce that identity automatically the waymain's un-mocked real Pinia store does.src/workbench/extensions/agent/crdt/ecsFollowerAdapter.promptReconcile.test.ts. It importsAgentCrdtProjectionfrom./agentCrdtProjection, a module that doesn't exist oncore/1.54(refactored away in refactor(agent): split CRDT follower layers #16908, split intoecsFollowerAdapter.ts/graphMutations.ts/followerDoc.ts). This test is an unrelated CRDT-reconciliation reproduction that test: pin PM-1303 Flux2ImageNode prompt box collapse across generations #18098's own description says is "not fixed here"; porting it to the refactored API is out of scope for this backport.Verification
pnpm exec vitest run src/stores/executionStore.test.ts— 138/138 passpnpm exec vue-tsc --noEmit— cleanpnpm exec oxlinton changed files — clean🤖 Generated with Claude Code
https://claude.ai/code/session_01Stfza8cuRcz7X1SkxmpDt1
Generated by Claude Code