Repository navigation
[backport cloud/1.54] test: pin PM-1303 Flux2ImageNode prompt box collapse across generations (#18098) - #18515
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
…ns (#18098) Remove stale execution progress widgets. Preserve other workflows' widgets. Prompt-height collapse remains unresolved. <details><summary>Full context for agent readers</summary> This began as reproduction-only coverage, but now includes production cleanup in `executionStore`: completion, interruption and error remove the progress widget from the viewed workflow before queued-job state is deleted. Review found and repaired a cross-workflow bug: identical node IDs in another tab must not be cleaned up. Cleanup also uses the existing subgraph-aware execution-ID mapping. This is a partial fix for the [Flux prompt incident](https://linear.app/comfyorg/issue/PM-1303) and its [reproduction task](https://linear.app/comfyorg/issue/PM-1310), not closure of either. The prompt stays registered and retains its typed text through two generations, but remains vertically collapsed. The height assertion stays expected-failing. A separate conflict-free replicated data type (CRDT) reconciliation test retains the known stale-snapshot value-overwrite reproduction; that is not fixed here. Christian's [completion lane](https://ampcode.com/threads/T-01a0bb17-0593-72cc-840e-4120f777fdf0) takes the broader assignment on merge: repair prompt-height allocation, resolve or rule out the Cloud reconciliation candidate against the original workflow, and verify both 1.54 releases. Program tracking is in `claude-handoff-9` on the [program board](https://github.com/christian-byrne/in-app-agent-program/blob/main/todo.md). No clean-backport label until full target-native source, API and fixture qualification. Original context: [Christian's Slack request](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1789700733927729), [preserved Claude session](https://claude.ai/code/session_01Stfza8cuRcz7X1SkxmpDt1). </details> - Execution store: 141 tests pass, including success/error/interruption cleanup and cross-workflow/subgraph exclusions. The cross-workflow counterexample failed before the guard. - Browser: prompt type, registration, and node/registry cleanup pass; retained height-collapse case remains expected-failing. The final recording shows intact text, no stale Running line, and a still-collapsed textarea. - Reconciliation reproduction: one pass, one existing expected failure. - Source/browser typechecks, lint/format and Cloud build pass. Native checks remain merge gates. - Full screenshot scenario retains a local eight-pixel initial-baseline mismatch; no golden was rewritten. A later mistaken Cloud-build/Chromium-project run failed during boot and is not counted as behavioral evidence. The successful rerun used the matching localhost surface and Chromium project. Glossary: progress widget is the temporary execution-status row; CRDT is the synchronized graph document; an expected failure records an unresolved defect, not a completed fix. --------- Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: bymyself <cbyrne@comfy.org> ## Manual backport notes (cloud/1.54) Automated backport failed on `src/stores/executionStore.test.ts` (target's hoisted-mocks block already had more mocks than this PR's simpler version). Resolved by keeping target's block and adding `mockRemoveTextPreview` to it. Other fixes needed to make the cherry-pick compile/pass on this branch: - Added missing `fromPartial` (`@total-typescript/shoehorn`) and `useWorkflowStore` imports the new tests need, matching main's imports that target's test file predates. - Replaced `useWorkflowStore().activeWorkflow = ...` (target's mock exposes `activeWorkflow` as a read-only getter) with the existing `mockActiveWorkflow.value = ...` pattern already used elsewhere in this file, and set it from `store.queuedJobs['job-1'].workflow` (not the local `workflow` var) so it holds the same Vue-reactivity-wrapped reference as `queuedJobs`, matching production `workflowStore`/`queuedJobs` identity semantics that target's shallowRef-based mock doesn't reproduce otherwise. - Dropped `src/workbench/extensions/agent/crdt/ecsFollowerAdapter.promptReconcile.test.ts`. It imports `AgentCrdtProjection` from `./agentCrdtProjection`, a module that doesn't exist on cloud/1.54 (refactored away in #16908, split into `ecsFollowerAdapter.ts`/`graphMutations.ts`/`followerDoc.ts`). This test is an unrelated CRDT-reconciliation reproduction the PR body explicitly says is "not fixed here"; porting it to the refactored API is out of scope for this backport. Verified: `pnpm exec vitest run src/stores/executionStore.test.ts` (138/138 pass), `pnpm exec vue-tsc --noEmit`, `pnpm exec oxlint` all clean on this branch.
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1942 passed, 0 failed📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-23T03:56:30.647Z",
"gitSha": "cc68b976a9df4a84ff16759c1794005645c00f9b",
"branch": "backport-18098-to-cloud-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2057.811000000015,
"styleRecalcs": 8,
"styleRecalcDurationMs": 9.064999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 574.8910000000001,
"heapDeltaBytes": -12244564,
"heapUsedBytes": 56724480,
"domNodes": -281,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 14.071999999999997,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2025.4429999999957,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.337,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 477.2850000000001,
"heapDeltaBytes": 1461516,
"heapUsedBytes": 70838752,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 7.805,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2124.986999999976,
"styleRecalcs": 80,
"styleRecalcDurationMs": 38.733000000000004,
"layouts": 14,
"layoutDurationMs": 5.617999999999999,
"taskDurationMs": 1109.316,
"heapDeltaBytes": 8479704,
"heapUsedBytes": 79201324,
"domNodes": -279,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 192.688,
"eventListeners": -168,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1810.3159999999434,
"styleRecalcs": 75,
"styleRecalcDurationMs": 28.217,
"layouts": 14,
"layoutDurationMs": 4.266000000000001,
"taskDurationMs": 875.6930000000001,
"heapDeltaBytes": -3965780,
"heapUsedBytes": 66825264,
"domNodes": -279,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 162.408,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1739.9409999999875,
"styleRecalcs": 32,
"styleRecalcDurationMs": 16.516999999999996,
"layouts": 6,
"layoutDurationMs": 1.137,
"taskDurationMs": 350.686,
"heapDeltaBytes": 4641684,
"heapUsedBytes": 75308948,
"domNodes": 76,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 10.873000000000001,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1721.99599999999,
"styleRecalcs": 33,
"styleRecalcDurationMs": 17.791,
"layouts": 6,
"layoutDurationMs": 1.076,
"taskDurationMs": 378.26599999999996,
"heapDeltaBytes": 4615752,
"heapUsedBytes": 75817684,
"domNodes": 76,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 12.596,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 707.6179999999681,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.127,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 457.85999999999996,
"heapDeltaBytes": -8192440,
"heapUsedBytes": 62674488,
"domNodes": 18,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 162.86999999999998,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 624.4860000000472,
"styleRecalcs": 13,
"styleRecalcDurationMs": 8.947999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 438.766,
"heapDeltaBytes": -7817252,
"heapUsedBytes": 62775292,
"domNodes": 22,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 157.16,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2045.9260000000086,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.640000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 660.691,
"heapDeltaBytes": 10217408,
"heapUsedBytes": 86753116,
"domNodes": -274,
"jsHeapTotalBytes": -2203648,
"scriptDurationMs": 36.80799999999999,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2059.38900000001,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 632.4580000000001,
"heapDeltaBytes": 7854336,
"heapUsedBytes": 83095568,
"domNodes": -275,
"jsHeapTotalBytes": -1155072,
"scriptDurationMs": 39.30200000000001,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2604.721999999981,
"styleRecalcs": 66,
"styleRecalcDurationMs": 11.855999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1753.002,
"heapDeltaBytes": 24829776,
"heapUsedBytes": 90793928,
"domNodes": -273,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 889.7479999999999,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2355.1350000000184,
"styleRecalcs": 68,
"styleRecalcDurationMs": 13.078,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1723.43,
"heapDeltaBytes": -8022756,
"heapUsedBytes": 68919472,
"domNodes": -245,
"jsHeapTotalBytes": 942080,
"scriptDurationMs": 855.3439999999999,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3568.2349999999587,
"styleRecalcs": 60,
"styleRecalcDurationMs": 9.584999999999999,
"layouts": 60,
"layoutDurationMs": 11.767000000000001,
"taskDurationMs": 1694.872,
"heapDeltaBytes": 8066800,
"heapUsedBytes": 75672488,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 771.337,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3505.07499999992,
"styleRecalcs": 60,
"styleRecalcDurationMs": 9.667999999999996,
"layouts": 60,
"layoutDurationMs": 11.714999999999998,
"taskDurationMs": 1675.581,
"heapDeltaBytes": 12075360,
"heapUsedBytes": 80155512,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 778.7470000000001,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3057.172000000037,
"styleRecalcs": 43,
"styleRecalcDurationMs": 7.407,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1918.116,
"heapDeltaBytes": 21523572,
"heapUsedBytes": 101934616,
"domNodes": 6,
"jsHeapTotalBytes": 5398528,
"scriptDurationMs": 961.2290000000002,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3085.8049999999366,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.978,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1939.0620000000004,
"heapDeltaBytes": 22167720,
"heapUsedBytes": 90443916,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 966.3770000000001,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2000.4169999999704,
"styleRecalcs": 3,
"styleRecalcDurationMs": 1.9470000000000007,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 543.42,
"heapDeltaBytes": 22088876,
"heapUsedBytes": 87999500,
"domNodes": -274,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 33.51800000000001,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2032.4219999999968,
"styleRecalcs": 3,
"styleRecalcDurationMs": 3.0510000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 593.677,
"heapDeltaBytes": 9898848,
"heapUsedBytes": 87566968,
"domNodes": -273,
"jsHeapTotalBytes": -2203648,
"scriptDurationMs": 33.848000000000006,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 596.1100000000101,
"styleRecalcs": 48,
"styleRecalcDurationMs": 11.982999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 408.915,
"heapDeltaBytes": 15078852,
"heapUsedBytes": 87788728,
"domNodes": 22,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 143.228,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 633.8450000000648,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.354,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 417.63700000000006,
"heapDeltaBytes": 15082760,
"heapUsedBytes": 87928540,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 144.671,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2020.825000000002,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.02,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 497.6820000000001,
"heapDeltaBytes": 4116120,
"heapUsedBytes": 77029796,
"domNodes": -293,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 8.578,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2004.363000000012,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.128000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 437.538,
"heapDeltaBytes": 718340,
"heapUsedBytes": 65874296,
"domNodes": 18,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 7.900000000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1741.472999999985,
"styleRecalcs": 77,
"styleRecalcDurationMs": 28.645,
"layouts": 18,
"layoutDurationMs": 5.1450000000000005,
"taskDurationMs": 858.4050000000001,
"heapDeltaBytes": -11673380,
"heapUsedBytes": 61398296,
"domNodes": -295,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 115.97800000000001,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1759.0730000000576,
"styleRecalcs": 77,
"styleRecalcDurationMs": 27.457,
"layouts": 18,
"layoutDurationMs": 5.209999999999999,
"taskDurationMs": 829.8270000000001,
"heapDeltaBytes": -7915724,
"heapUsedBytes": 64105240,
"domNodes": -296,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 111.575,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1400.8640000000696,
"styleRecalcs": 18,
"styleRecalcDurationMs": 32.754999999999995,
"layouts": 14,
"layoutDurationMs": 15.453000000000001,
"taskDurationMs": 976.319,
"heapDeltaBytes": -7173168,
"heapUsedBytes": 82726676,
"domNodes": 13751,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 31.982000000000003,
"eventListeners": 2385,
"totalBlockingTimeMs": 144,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8530.17600000004,
"styleRecalcs": 247,
"styleRecalcDurationMs": 34.052,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5904.732,
"heapDeltaBytes": 13149536,
"heapUsedBytes": 89201828,
"domNodes": -270,
"jsHeapTotalBytes": -667648,
"scriptDurationMs": 2761.314,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8540.442999999981,
"styleRecalcs": 247,
"styleRecalcDurationMs": 34.647000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5865.433,
"heapDeltaBytes": 12702156,
"heapUsedBytes": 89094216,
"domNodes": -270,
"jsHeapTotalBytes": -1716224,
"scriptDurationMs": 2708.2879999999996,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999952,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17543.45999999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16907.088000000003,
"heapDeltaBytes": -48071552,
"heapUsedBytes": 178326788,
"domNodes": -8068,
"jsHeapTotalBytes": -16474112,
"scriptDurationMs": 285.191,
"eventListeners": -14933,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17003.816000000028,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16568.869,
"heapDeltaBytes": -56566500,
"heapUsedBytes": 177394852,
"domNodes": -8068,
"jsHeapTotalBytes": -17784832,
"scriptDurationMs": 315.87100000000004,
"eventListeners": -14933,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20792.62300000005,
"styleRecalcs": 165,
"styleRecalcDurationMs": 17.254000000000048,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20406.614999999998,
"heapDeltaBytes": -31052740,
"heapUsedBytes": 192724692,
"domNodes": -8068,
"jsHeapTotalBytes": -16285696,
"scriptDurationMs": 922.6290000000001,
"eventListeners": -14925,
"totalBlockingTimeMs": 36,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 20722.687999999947,
"styleRecalcs": 164,
"styleRecalcDurationMs": 17.042,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20389.053999999996,
"heapDeltaBytes": -47085976,
"heapUsedBytes": 183724920,
"domNodes": -8068,
"jsHeapTotalBytes": -13283328,
"scriptDurationMs": 917.6330000000002,
"eventListeners": -14929,
"totalBlockingTimeMs": 160,
"frameDurationMs": 18.329999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6222.219999999993,
"styleRecalcs": 20,
"styleRecalcDurationMs": 101.61599999999999,
"layouts": 20,
"layoutDurationMs": 33.339999999999996,
"taskDurationMs": 6073.77,
"heapDeltaBytes": -42270228,
"heapUsedBytes": 175964152,
"domNodes": -8068,
"jsHeapTotalBytes": 9433088,
"scriptDurationMs": 113.518,
"eventListeners": -14927,
"totalBlockingTimeMs": 603,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 6321.940999999924,
"styleRecalcs": 20,
"styleRecalcDurationMs": 80.85499999999996,
"layouts": 20,
"layoutDurationMs": 22.839,
"taskDurationMs": 6150.885,
"heapDeltaBytes": -42576072,
"heapUsedBytes": 182401580,
"domNodes": -8068,
"jsHeapTotalBytes": 12906496,
"scriptDurationMs": 114.77,
"eventListeners": -14929,
"totalBlockingTimeMs": 371,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8836.377999999968,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8514.973,
"heapDeltaBytes": 21442728,
"heapUsedBytes": 178747024,
"domNodes": 0,
"jsHeapTotalBytes": -13893632,
"scriptDurationMs": 143.62599999999992,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8784.571000000029,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8459.978,
"heapDeltaBytes": 18739500,
"heapUsedBytes": 177961796,
"domNodes": 0,
"jsHeapTotalBytes": -11010048,
"scriptDurationMs": 151.91699999999997,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 111.60600000005161,
"styleRecalcs": 9,
"styleRecalcDurationMs": 14.463999999999999,
"layouts": 2,
"layoutDurationMs": 0.546,
"taskDurationMs": 77.91800000000002,
"heapDeltaBytes": 3112952,
"heapUsedBytes": 72075956,
"domNodes": 111,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.990000000000001,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 115.01299999997627,
"styleRecalcs": 7,
"styleRecalcDurationMs": 16.096,
"layouts": 2,
"layoutDurationMs": 1.388,
"taskDurationMs": 77.50599999999999,
"heapDeltaBytes": 2988132,
"heapUsedBytes": 72325012,
"domNodes": 126,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 5.6290000000000004,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E CoverageNote Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.
Top 10 files by uncovered lines
|
c60b5f2 to
7e24687
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.54 #18515 +/- ##
=============================================
Coverage ? 83.64%
=============================================
Files ? 2098
Lines ? 124104
Branches ? 33558
=============================================
Hits ? 103812
Misses ? 20114
Partials ? 178
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Requested by Christian Byrne · Slack thread
Manual backport of #18098 to
cloud/1.54. The automated backport failed with a merge conflict insrc/stores/executionStore.test.ts(comment: #18098 (comment)).Why manual
Same conflict shape as the
core/1.54backport (#see companion PR): target's hoisted-mocks block in the test file already had more mocks than the version this PR's diff was based on.cloud/1.54's pre-cherry-pickexecutionStore.test.ts/executionStore.ts/useNodeProgressText.tsare byte-identical tocore/1.54's, so the same resolution was reused verbatim.Verified the diff is not already effectively present on
cloud/1.54(git diff --cached origin/cloud/1.54was non-empty after the cherry-pick — this is a real, needed backport, not a stacking false-positive).Additional fixes required on top of the raw cherry-pick
fromPartial(@total-typescript/shoehorn) anduseWorkflowStoreimports the new tests need (present onmain, absent from target's older version of the test file).workflowStoremock exposesactiveWorkflowas a read-only getter (useWorkflowStore().activeWorkflow = ...throws). Switched the new tests to the existingmockActiveWorkflow.value = ...pattern already used elsewhere in the file, sourcing the value fromstore.queuedJobs['job-1'].workflow(not the localworkflowvar) so it carries the same Vue-reactivity-wrapped identity asqueuedJobs, which is what the new production check (job.workflow === workflowStore.activeWorkflow) inexecutionStore.tsrelies on.src/workbench/extensions/agent/crdt/ecsFollowerAdapter.promptReconcile.test.ts. It importsAgentCrdtProjectionfrom./agentCrdtProjection, a module that doesn't exist oncloud/1.54(refactored away in refactor(agent): split CRDT follower layers #16908, split intoecsFollowerAdapter.ts/graphMutations.ts/followerDoc.ts). This test is an unrelated CRDT-reconciliation reproduction that test: pin PM-1303 Flux2ImageNode prompt box collapse across generations #18098's own description says is "not fixed here"; porting it to the refactored API is out of scope for this backport.Verification
pnpm exec vitest run src/stores/executionStore.test.ts— 138/138 passpnpm exec vue-tsc --noEmit— cleanpnpm exec oxlinton changed files — clean🤖 Generated with Claude Code
https://claude.ai/code/session_01Stfza8cuRcz7X1SkxmpDt1
Generated by Claude Code