Repository navigation
fix(agent): retry an unanswered CRDT doc subscribe after transport reconnect - #18073
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 2039 passed, 0 failed · 2 flaky📊 Browser Reports
📦 Bundle: 9.93 MB gzip 🟢 -694 BDetailsSummary
Category Glance App Entry Points — 3.81 kB (baseline 3.81 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.45 MB (baseline 1.45 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 132 kB (baseline 132 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 14 added / 14 removed / 4 unchanged Panels & Settings — 638 kB (baseline 638 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 18 unchanged User & Accounts — 37.9 kB (baseline 37.9 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 6 added / 6 removed / 5 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 1 unchanged UI Components — 124 kB (baseline 124 kB) • ⚪ 0 BReusable component library chunks
Status: 7 added / 7 removed / 9 unchanged Data & Services — 3.86 MB (baseline 3.86 MB) • 🟢 -1.08 kBStores, services, APIs, and repositories
Status: 13 added / 13 removed / 3 unchanged Utilities & Hooks — 566 kB (baseline 566 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 19 added / 19 removed / 19 unchanged Vendor & Third-Party — 17.4 MB (baseline 17.4 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 17.7 MB (baseline 17.7 MB) • ⚪ 0 BBundles that do not match a named category
Status: 73 added / 73 removed / 227 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-20T05:10:09.303Z",
"gitSha": "afc877efe4568500333367acf71f7ae31d92683d",
"branch": "test/pm-1260-agent-graph-op-lost-repro",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2011.2450000000308,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.956999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 391.36800000000005,
"heapDeltaBytes": 9447280,
"heapUsedBytes": 70059636,
"domNodes": -266,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 8.07,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2009.2959999999493,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.715,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 366.69599999999997,
"heapDeltaBytes": 4959580,
"heapUsedBytes": 66591940,
"domNodes": -264,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 9.479999999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1849.2899999999963,
"styleRecalcs": 76,
"styleRecalcDurationMs": 30.481,
"layouts": 14,
"layoutDurationMs": 4.321000000000001,
"taskDurationMs": 845.3019999999999,
"heapDeltaBytes": -4854852,
"heapUsedBytes": 56617784,
"domNodes": -261,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 165.799,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1767.7929999999833,
"styleRecalcs": 74,
"styleRecalcDurationMs": 27.114,
"layouts": 14,
"layoutDurationMs": 3.928,
"taskDurationMs": 740.655,
"heapDeltaBytes": -6144708,
"heapUsedBytes": 55846628,
"domNodes": -264,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 166.452,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1707.8010000000177,
"styleRecalcs": 31,
"styleRecalcDurationMs": 14.238000000000001,
"layouts": 6,
"layoutDurationMs": 1.2640000000000002,
"taskDurationMs": 311.638,
"heapDeltaBytes": 2330032,
"heapUsedBytes": 63644828,
"domNodes": 75,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 9.637,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1725.4299999999603,
"styleRecalcs": 30,
"styleRecalcDurationMs": 18.022999999999996,
"layouts": 6,
"layoutDurationMs": 1.7189999999999999,
"taskDurationMs": 348.33099999999996,
"heapDeltaBytes": 2050184,
"heapUsedBytes": 63078872,
"domNodes": 75,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 11.511999999999999,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 616.7849999999362,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.719000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 430.22700000000003,
"heapDeltaBytes": 18229560,
"heapUsedBytes": 80209808,
"domNodes": 16,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 165.30100000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 640.5059999999594,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.708999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 446.041,
"heapDeltaBytes": 17926408,
"heapUsedBytes": 80017760,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 165.51300000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2033.5300000000416,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.270000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 588.312,
"heapDeltaBytes": 2497684,
"heapUsedBytes": 82189416,
"domNodes": -250,
"jsHeapTotalBytes": -794624,
"scriptDurationMs": 35.32599999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2034.2970000001515,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.78,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 542.8170000000001,
"heapDeltaBytes": 3803608,
"heapUsedBytes": 82963340,
"domNodes": -247,
"jsHeapTotalBytes": -1318912,
"scriptDurationMs": 32.79699999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2179.56300000003,
"styleRecalcs": 64,
"styleRecalcDurationMs": 8.649000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1575.18,
"heapDeltaBytes": 14754572,
"heapUsedBytes": 78665800,
"domNodes": -254,
"jsHeapTotalBytes": 1536000,
"scriptDurationMs": 826.5699999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2165.271999999959,
"styleRecalcs": 64,
"styleRecalcDurationMs": 9.357999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1434.5879999999997,
"heapDeltaBytes": 14387228,
"heapUsedBytes": 78869108,
"domNodes": 4,
"jsHeapTotalBytes": 1273856,
"scriptDurationMs": 829.025,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3457.9410000000053,
"styleRecalcs": 61,
"styleRecalcDurationMs": 9.929,
"layouts": 60,
"layoutDurationMs": 12.161000000000001,
"taskDurationMs": 1615.6640000000002,
"heapDeltaBytes": 8790232,
"heapUsedBytes": 74360576,
"domNodes": 2,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 773.119,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3554.505000000063,
"styleRecalcs": 60,
"styleRecalcDurationMs": 9.307000000000002,
"layouts": 60,
"layoutDurationMs": 12.622000000000002,
"taskDurationMs": 1660.561,
"heapDeltaBytes": 7394184,
"heapUsedBytes": 73465200,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 768.4159999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2951.396999999929,
"styleRecalcs": 41,
"styleRecalcDurationMs": 5.555000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1827.81,
"heapDeltaBytes": 16442276,
"heapUsedBytes": 84313836,
"domNodes": 2,
"jsHeapTotalBytes": 679936,
"scriptDurationMs": 943.3190000000001,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2996.0120000000643,
"styleRecalcs": 41,
"styleRecalcDurationMs": 5.53,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1913.6369999999997,
"heapDeltaBytes": 18606760,
"heapUsedBytes": 84528452,
"domNodes": 2,
"jsHeapTotalBytes": 679936,
"scriptDurationMs": 976.728,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2000.2749999999878,
"styleRecalcs": 3,
"styleRecalcDurationMs": 3.646,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 493.47200000000004,
"heapDeltaBytes": 20130524,
"heapUsedBytes": 84092628,
"domNodes": -254,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 30.200000000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2046.3150000000496,
"styleRecalcs": 5,
"styleRecalcDurationMs": 5.506999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 549.279,
"heapDeltaBytes": -3997704,
"heapUsedBytes": 83877600,
"domNodes": -252,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 32.874,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 561.2320000000182,
"styleRecalcs": 47,
"styleRecalcDurationMs": 9.922,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 388.567,
"heapDeltaBytes": 13109332,
"heapUsedBytes": 76528208,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 139.66699999999997,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 598.4879999998611,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.827,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 397.104,
"heapDeltaBytes": 13490336,
"heapUsedBytes": 76719692,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 144.083,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2006.988999999976,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.717,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 433.701,
"heapDeltaBytes": 4458508,
"heapUsedBytes": 67618360,
"domNodes": -276,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 6.8100000000000005,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2005.6640000000243,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.969000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 437.83700000000005,
"heapDeltaBytes": 11648592,
"heapUsedBytes": 74786760,
"domNodes": -277,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 7.099000000000001,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1708.2110000000057,
"styleRecalcs": 77,
"styleRecalcDurationMs": 25.528000000000002,
"layouts": 18,
"layoutDurationMs": 4.7410000000000005,
"taskDurationMs": 766.829,
"heapDeltaBytes": 924260,
"heapUsedBytes": 64374756,
"domNodes": -275,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 107.21499999999999,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1708.0630000000383,
"styleRecalcs": 77,
"styleRecalcDurationMs": 28.048000000000002,
"layouts": 18,
"layoutDurationMs": 5.038,
"taskDurationMs": 793.603,
"heapDeltaBytes": -110880,
"heapUsedBytes": 62478024,
"domNodes": -278,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 114.31199999999998,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1367.5799999998617,
"styleRecalcs": 17,
"styleRecalcDurationMs": 28.098,
"layouts": 5,
"layoutDurationMs": 13.065999999999997,
"taskDurationMs": 864.2669999999999,
"heapDeltaBytes": -6388612,
"heapUsedBytes": 80293928,
"domNodes": 13587,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 31.167999999999996,
"eventListeners": 2383,
"totalBlockingTimeMs": 138,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8258.510999999999,
"styleRecalcs": 247,
"styleRecalcDurationMs": 32.498,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5606.9839999999995,
"heapDeltaBytes": -4741264,
"heapUsedBytes": 75390128,
"domNodes": -250,
"jsHeapTotalBytes": -569344,
"scriptDurationMs": 2715.997,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8506.869000000052,
"styleRecalcs": 248,
"styleRecalcDurationMs": 34.954,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5746.1669999999995,
"heapDeltaBytes": -4494688,
"heapUsedBytes": 75255468,
"domNodes": -248,
"jsHeapTotalBytes": 479232,
"scriptDurationMs": 2736.346,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16467.445999999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15573.263,
"heapDeltaBytes": -34566028,
"heapUsedBytes": 177375776,
"domNodes": -8061,
"jsHeapTotalBytes": -12238848,
"scriptDurationMs": 230.90700000000004,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 17180.997000000163,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16738.678,
"heapDeltaBytes": -36999896,
"heapUsedBytes": 177495084,
"domNodes": -8061,
"jsHeapTotalBytes": -11542528,
"scriptDurationMs": 271.89799999999997,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 20136.571000000004,
"styleRecalcs": 160,
"styleRecalcDurationMs": 15.499999999999986,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19765.753000000004,
"heapDeltaBytes": -37583712,
"heapUsedBytes": 178638908,
"domNodes": -8061,
"jsHeapTotalBytes": -18288640,
"scriptDurationMs": 898.2049999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 33,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20509.402999999795,
"styleRecalcs": 157,
"styleRecalcDurationMs": 18.263999999999974,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20291.592,
"heapDeltaBytes": -43505980,
"heapUsedBytes": 166993176,
"domNodes": -8061,
"jsHeapTotalBytes": -10555392,
"scriptDurationMs": 932.763,
"eventListeners": -14928,
"totalBlockingTimeMs": 79,
"frameDurationMs": 18.329999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6025.539999999864,
"styleRecalcs": 20,
"styleRecalcDurationMs": 77.93099999999997,
"layouts": 20,
"layoutDurationMs": 21.87,
"taskDurationMs": 5906.165,
"heapDeltaBytes": -18613108,
"heapUsedBytes": 196387632,
"domNodes": -8061,
"jsHeapTotalBytes": 15388672,
"scriptDurationMs": 105.67599999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 373,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 6120.867000000089,
"styleRecalcs": 20,
"styleRecalcDurationMs": 77.38700000000001,
"layouts": 20,
"layoutDurationMs": 23.807999999999996,
"taskDurationMs": 6058.897,
"heapDeltaBytes": -33244076,
"heapUsedBytes": 183072084,
"domNodes": -8060,
"jsHeapTotalBytes": 15265792,
"scriptDurationMs": 112.166,
"eventListeners": -14928,
"totalBlockingTimeMs": 393,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8409.095999999863,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8123.754000000002,
"heapDeltaBytes": 6776124,
"heapUsedBytes": 183623664,
"domNodes": 0,
"jsHeapTotalBytes": -12845056,
"scriptDurationMs": 123.01899999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8392.100999999911,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8173.373999999999,
"heapDeltaBytes": -32247996,
"heapUsedBytes": 161892688,
"domNodes": 0,
"jsHeapTotalBytes": -28835840,
"scriptDurationMs": 155.00200000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 474.16900000007445,
"styleRecalcs": 18,
"styleRecalcDurationMs": 23.021,
"layouts": 5,
"layoutDurationMs": 2.206,
"taskDurationMs": 133.591,
"heapDeltaBytes": 5282040,
"heapUsedBytes": 66822328,
"domNodes": 151,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 15.297,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 107.92400000013913,
"styleRecalcs": 6,
"styleRecalcDurationMs": 15.628999999999998,
"layouts": 4,
"layoutDurationMs": 2.042,
"taskDurationMs": 78.22299999999998,
"heapDeltaBytes": 3025176,
"heapUsedBytes": 64643768,
"domNodes": 124,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.559,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🎨 Storybook: ✅ Built — View Storybook🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 2fd052d1a5bfab0baa0f8c9c4e0db18946774979
Full docs: ADR-DEVEX-LINT-0015 🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
b0796c9 to
8ae221f
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #18073 +/- ##
==========================================
+ Coverage 82.78% 83.83% +1.05%
==========================================
Files 2939 2253 -686
Lines 144683 128240 -16443
Branches 37233 32902 -4331
==========================================
- Hits 119773 107511 -12262
+ Misses 23636 20440 -3196
+ Partials 1274 289 -985
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 772 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Playwright videos for new testsDownload the recorded videos and HTML report Recorded projects: cloud Recorded test titles:
|
|
Investigated whether this is a trivial frontend fix. It isn't — here's why, and what a real fix needs. Reconnect/resubscribe path already handles the cases I first suspected. Real gap found: there's no ack-timeout for a Why that gap alone doesn't make this test's fix trivial: this repro's mock What a fix plan needs:
Generated by Claude Code |
f999159 to
7b6c2bf
Compare
Adds an intentionally-failing e2e repro: the agent's CRDT doc host applies an add_node op (it lands in the authoritative document, matching the "CRDT event log" evidence from the bug's debug report) at the exact moment the transport carrying it drops. The websocket reconnects (chat keeps working), but the doc subscription that reconnect should re-establish never completes, so the node the agent added never appears on the live canvas. Marked test.fail() per current convention for known-failing repros. No fix attempted here.
…connect A doc_subscribe that left the transport and was never answered used to be a permanent hang: the bridge's reconcile no-ops once intent equals reality, the refusal backoff arms only on an explicit ok:false, and the recency probe arms only after a confirm. After a socket reconnect the follower sat at connected: false forever while the agent's op stayed in the host's log. The bridge now dispatches doc_subscribe_sent at the send boundary and the lifecycle arms a 15 s ack timer from it. Silence retries the same-lineage subscribe (same state vector, no reset) up to three times, sharing the existing refusal budget; the third expiry is terminal: the recency probe is disarmed, a give-up latch blocks further retries, one failure_confirming_agent_doc_subscribe warning is reported, and the composable marks the follower disconnected. Confirm, reconnect and retarget release the latch and reset the budget. The e2e repro's mock now swallows only the first post-reconnect subscribe and answers the retry; test.fail() is left in place on purpose in this commit so the spec reports "expected to fail, but passed" as the red-to-green proof. The next commit flips it to a plain test. Documented in docs/adr/CRDT-FOLLOWER-0035.
With the ack-timeout retry in place the spec passes: the node the agent added while the doc subscription was unanswered lands on the canvas after the follower's same-lineage retry. Drop the test.fail() marker.
…me parser fallow flagged the /ws message handler (cyclomatic 14, CRAP 56) as newly introduced complexity. Parsing the follower's subscription frame is now a small pure helper and the handler only decides whether to answer.
9aace94 to
6ab2968
Compare
…lost-graph-op spec
christian-byrne
left a comment
There was a problem hiding this comment.
Reconnect recovery verified. Original incident remains open. Christian's completion lane owns follow-through.
Full context for agent readers
Reconnect repair PR18073, reviewed at 870236359. The browser test uses the real document applier with controlled transport: it drops an update, ignores the first post-reconnect subscription, answers the retry, and verifies the missing node appears without replacing the document. The test passed in 19.8 seconds. The inspected recording shows the note, but not a final textual agent reply.
Review also reproduced a late refusal restarting retries after the terminal limit. The new guard fixes that: the added regression failed before the fix and passes after it. All 640 document-sync tests pass, with one pre-existing expected failure; cloud build, source/browser typechecks, lint and format pass.
This establishes one recovery path, not the cause of the September 16 incident. Keep this issue open under Christian's completion lane: recover the complete original prompt and pre-action canvas state, extend the existing eval reproduction, and verify generating nodes match chat outputs on the intended workflow. Preserve the existing parent fix owner; do not create a competing implementation. Program successor: claude-handoff-3 in the shared todo.
Both 1.54 targets lack agentCrdtDocLifecycle.ts; the follower and dev-panel changes also conflict. No clean-backport labels. This lane owns retry after the lifecycle prerequisite is backported or the fix is adapted to the target-native lifecycle, with the same timeout/terminal/reconnect tests and browser recovery case. Source merge does not complete target-release acceptance.
Glossary: document sync is the graph replication channel; a subscription asks the host to send graph updates; an expected failure is a test explicitly documenting an existing defect.
…e derived binding main #18073 added a subscribe-ack retry loop that signals a disconnect by writing a `connected` ref: once through `AgentCrdtDocLifecycle`'s new `onGaveUp` callback, once in `onReconnected`. This branch removed that ref because `status.connected` is derived from `acknowledgedWorkflowId`, so both writes are re-expressed as clearing the acknowledgement, which is the same statement: a subscribe that was never confirmed is not a connection. `lifecycle.clearStaleProbe()` in `onReconnected` takes main's `lifecycle.onReconnected()`, which supersedes it.
#18099) <!-- ccr-slack-attribution --> _Requested by **Christian Byrne** · [Slack thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1789729191698819?thread_ts=1789729191.698819&cid=C0BGH348Z0C)_ ## Summary Started as an intentionally-failing repro for the in-app agent reporting a turn as done while the canvas ends up with zero nodes (agent CRDT schema-version fail-closed with no signal to backend). Per review feedback (see below), a real fix for the underlying schema-gate latch bug has now landed alongside the repro: `test.fail()` is removed and the repro's final assertion passes normally. ## Changes - **What**: `browser_tests/tests/agent/agentZeroNodesOnUnreadableSchema.spec.ts` drives the real agent panel against a fake doc host (`HostDoc`, the same fixture the sibling PM-1260 repro (#18073) and `agentConversationFixture` use). The host's catch-up frame is corrupted so its merged doc's `meta.schema_version` is missing/undefined — an unreadable-schema shape `assertReadableSchema` (KA-11, `src/workbench/extensions/agent/crdt/schemaGuard.ts`) refuses; see the spec's header comment for why this trigger is simulated rather than a proven real-world path. A schema-version repair and then a successful `add_node` tool call (reported over chat) are each sent to the browser as their own frames on the host's own authoritative document, and now both actually reach the canvas. - Also adds a focused Vitest case, `followerSubscription.test.ts` › `FE-KA11-1`, isolating the latch mechanism directly against `LayoutFollowerBridge` (no browser, no panel). - `browser_tests/fixtures/agentConversationHostDoc.ts`'s shared `HostDoc` test fixture gains two additive, test-only methods: `corruptSchemaVersion()` and `repairSchemaVersion()`, which restores `meta.schema_version` and returns the delta frame carrying just that repair (mirroring `apply()`'s before/after shape). - **Production fix**: `src/workbench/extensions/agent/crdt/layoutFollowerBridge.ts`'s `onDocUpdate` used to latch `schemaError` for the *entire document lineage* the moment one merged frame's `meta.schema_version` was unreadable (`if (this.schemaError !== null) return`, checked *before* the frame was even merged). That made a later same-lineage repair permanently unreachable — the repair frame was silently dropped along with everything after it, forever, until an explicit `doc_reset`. Now every same-lineage, in-order frame is merged regardless of latch state, and the KA-11 read gate (`assertReadableSchema`, now behind the `isReadableUpdate()` helper) is re-checked after every merge instead of only the first. A later frame that restores a readable `meta.schema_version` clears `schemaError` and resumes projecting normally — the gate now un-latches on repair instead of only on a lineage reset. ## Before / After - **Before (`main`)**: once a doc's schema becomes unreadable (e.g. a catch-up frame with no `meta.schema_version`), the CRDT follower dropped every later update for that document's lineage forever, with no `doc_reset` following an ordinary tool call and no signal to the backend. The agent kept reporting tool-call and turn success because nothing told it the browser stopped projecting. The user saw the agent claim success while the canvas stayed empty. - **After (this PR)**: a same-lineage frame that repairs `meta.schema_version` un-latches the gate, so ops sent afterward (e.g. `add_node`) merge and project normally. The repro's final assertion (`expect(vueNodes.getNodeLocator(...)).toBeVisible()`) passes without `test.fail()`. ## Step 0 — checked for an existing PR first - **#16372** ("surface dropped doc_update frames instead of silent apply failure") touches `layoutFollowerBridge.ts` and `useAgentCrdtFollower.ts`, but its whole diff is about a *different* drop family: `FollowerApplyError` (malformed Yjs updates) and `EcsFollowerAdapter.applyFrame` returning `false` for no bound session. It does not cover this bug. - **#16590** ("explain and gate workflow schema mismatches") also touches `layoutFollowerBridge.ts`'s schema handling, but only for the *subscribe-time* refusal case. It does not cover the post-merge `assertReadableSchema` latch either. - No other open PR touching `schemaGuard.ts`, the `schemaError`/KA-11 latch, or this specific case was found. ## Verification - `NODE_OPTIONS="--no-experimental-webstorage" pnpm exec vitest run src/workbench/extensions/agent/crdt/followerSubscription.test.ts` — **43 passed, 2 expected fail** (pre-existing, unrelated, from `main`'s own `it.fails` cases), including the two `FE-KA11-1` cases now proving the un-latch-on-repair behavior. - `NODE_OPTIONS="--no-experimental-webstorage" pnpm exec vitest run src/workbench/extensions/agent/crdt/` — full directory post-merge, **859 passed, 15 expected fail** (pre-existing, unrelated) — no regressions. - `pnpm typecheck` — passed (clean across the whole workspace). - `pnpm run typecheck:browser` (`vue-tsc --project browser_tests/tsconfig.json`) — passed. - `pnpm exec eslint` / `pnpm exec oxfmt --check` / `pnpm exec oxlint` on all changed files — passed. - `pnpm exec playwright test --list browser_tests/tests/agent/agentZeroNodesOnUnreadableSchema.spec.ts` — collects successfully. - **Known limitation, stated plainly**: this sandbox's egress policy blocks `cdn.playwright.dev` (403), so the Chromium binary could not be downloaded and the e2e spec could not be executed against a real browser in this session — only collected (`--list`), typechecked, and linted. **CI's actual Playwright run on this PR is the authoritative pass/fail signal for the e2e half.** ## Step 2.3 — did the RCA's latch claim hold up? - `onDocUpdate`'s early return (before the sequence/apply logic, so a later frame was not even merged into the follower's `Y.Doc`) was present, unmodified, on `main` at the commit this branch was cut from. - The Vitest cases confirm the latch existed and, after this PR's fix, confirm it now clears on a repairing frame instead of persisting until `doc_reset`. - **Result:** the RCA's claim about this mechanism held up under direct code reading and a passing causal unit test — and is now fixed at the source, not just documented. ## Response to review (dante01yoon) - **Blocking**: `host.apply(...)`'s returned `HostFrame` was discarded instead of being sent, so `add_node` never reached the browser. Fixed: wrapped in `send(...)`, matching `agentConversationFixture.ts`'s `this.hostSocket.send(this.host.apply(entry.ops))` pattern. - **Second-order issue**: `repairSchemaVersion()`'s effect never reached the browser because `apply()` computes its own before/after delta fresh at call time. Restructured: `repairSchemaVersion()` now returns its own before/after delta frame, exactly like `apply()`/`catchUp()`, sent as its own later-seq frame before `add_node`. - **Nit**: named both `corruptSchemaVersion()` and `repairSchemaVersion()` in this description. - **Header/description accuracy**: reworded the spec's header comment and this description to state the conditional the test actually pins ("IF a doc's schema_version ever becomes unreadable...") rather than an unproven causal claim about the trigger. ## Response to review (christian-byrne) — "Attempt a fix that swaps test result" Read as: attempt the real product fix for the schema-gate latch so the repro's final assertion flips from failing (`test.fail()`) to passing — matching this PR's own "After (once a fix lands)" note above. Implemented in `layoutFollowerBridge.ts` (see "Production fix" above): the KA-11 gate now re-checks on every merged frame and un-latches when a later frame restores a readable `schema_version`, instead of latching forever on the first failure. `test.fail()` is removed from the e2e spec and its final assertion (`toBeVisible()`) now passes; the two `followerSubscription.test.ts` cases that previously pinned the "latches forever" behavior now prove the un-latch-on-repair behavior instead. Fix scoped to `layoutFollowerBridge.ts` only (no `schemaGuard.ts` change needed). Also folded in a second, unrelated fix for the CI re-run failures a parallel investigation found on this same spec: `page.getByRole('button', { name: OPEN_AGENT_LABEL })` was an unscoped locator that hit a strict-mode violation (matching 63-81 buttons — unrelated topbar/tab/feedback/user buttons) and was failing both the `playwright-video-new-tests` and `playwright-tests (cloud)` jobs (107028559537, 107022232650) for real, not flake. Root cause: `main` had already renamed the entry button's i18n key from `agent.askComfyAgent` ("Ask Comfy Agent") to `agent.entryButton` ("Agent", now rendered by `AgentEntryButton.vue`) before this branch merged, so `OPEN_AGENT_LABEL` resolved to `undefined` at runtime — an unnamed `getByRole('button', ...)` matches every button on the page, which is exactly the 63-81-match symptom (including the "Agent" button itself). Updated the constant to `enMessages.agent.entryButton` (matching every other agent spec already on `main`) and additionally scoped/gated the locator to `[data-testid=integrated-tab-bar-actions]` + `data-agent-gate-settled`, the pattern already used in `agentChatRefreshPersistence.spec.ts` and `agentPanelLifecycle.spec.ts`. ## Merge with main Merged `main` into this branch (merge commit, no rebase/force-push) to pick up the base's moved-on history. One real conflict, in `layoutFollowerBridge.ts`: `main` had independently refactored `onDocUpdate` into `rejectStaleUpdate`/`rejectSequenceGap`/`isReadableUpdate` helpers and added a `ClassifiedDocUpdate` dispatch shape. Resolved by keeping `main`'s refactored structure and adding this PR's fix inside it: `isReadableUpdate()` now clears `this.schemaError = null` on a successful re-check, preserving the same un-latch-on-repair behavior under `main`'s current method layout. `followerSubscription.test.ts` and `agentConversationHostDoc.ts` auto-merged cleanly. Re-ran the full verification pass (vitest, typecheck, typecheck:browser, eslint, oxfmt, playwright --list) after the merge; all green. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01UZ9MAkZ9grYSDqqbmMdXvE --- _Generated by [Claude Code](https://claude.ai/code/session_01UZ9MAkZ9grYSDqqbmMdXvE)_ --------- Co-authored-by: Claude <noreply@anthropic.com>
## Summary Ports to `core/1.54` every merged `main` Agent fix that `cloud/1.54` carries and core does not (the Agent UI catch-up from #18622, the cloud-only CRDT and workflow fixes, and the round-2 fixes), so both release lines are symmetric ahead of the local-agent rollout. ## Changes - **What**: `cherry-pick -x`, in three groups: - Agent UI, as in #18622: #17339, #17908, #17420, #18348, #18043, #17621 (without its two `src/lib/litegraph/` files; a 5 px HUD offset in `SideToolbar.vue` compensates), #17471, #17690. - Cloud-only fixes: #18063, #18073, #18064, #18033, #18289, #18604, #18616, #18376. - Round 2: #17568, #17628, #16491, #18453, #17767, #18431 (from #18571), #18603. - **Already on `core/1.54`**: #17439 (#18161), #17912 (#18186), #18391 (#18595). - **Excluded**: #17730 (core lacks its three files), #18421 (dead code on core builds), #16917 (conflicts with later core changes), #18066 (Christian's request), #18375 and #18251 (need their litegraph hunks). ## Review Focus - On this line the Agent panel registers only in cloud builds (`src/extensions/core/index.ts:41-44`); the shared chrome from #17621 and #17471 and the host telemetry from #18376 and #18603 ship in every build. - `HostTelemetrySink.ts` and its test equal `main`'s files (#18376, then #18603 on top). - #18064: `agentConversationHostDoc.test.ts` keeps this line's file; #18063's new test uses `main`'s version (multi-player 0.3.x stamps). - Supersedes #18571 and the closed #18637. Linear: [PM-1657](https://linear.app/comfyorg/issue/PM-1657), [PM-1656](https://linear.app/comfyorg/issue/PM-1656) ## Screenshots (if applicable) Visual changes are the ones reviewed on `main` and carried to cloud in #18622. --------- Co-authored-by: uytieu <uytieu@users.noreply.github.com> Co-authored-by: ryan-di <ryan.weihao.di@gmail.com> Co-authored-by: jaeone lee <89377375+jaeone94@users.noreply.github.com> Co-authored-by: Christian Byrne <cbyrne@comfy.org> Co-authored-by: Amp <amp@ampcode.com> Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Alexander Brown <drjkl@comfy.org> Co-authored-by: Comfy Org PR Bot <snomiao+comfy-pr@gmail.com> Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> Co-authored-by: Hunter <huntcsg@users.noreply.github.com> Co-authored-by: Maanil Verma <vermaMaanil97@gmail.com>
…t a cloud carrier (#18257) ## Summary Eight merged `main` Agent fixes that had no `cloud/1.54` carrier are cherry-picked onto the current release tip. Two sources need hand re-expression and are excluded. Runtime source is unmodified from the eight sources; seven follow-up commits are test-only adaptations to the release's module surface. Verification at the current head `2991cfc3f8` is hosted CI (77 success, 16 skipped, 0 failed) plus DrJKL's local run (see below); the picked browser specs had not been run against the target before this PR. Open gates: release-scope sign-off on the three non-Agent carries and exact-head human re-approval on `2991cfc3f8`, both tracked in [blocked-on-christian 825](christian-byrne/blocked-on-christian#825). Replaces [18254](#18254): six picks there inherited `Co-authored-by: Claude` trailers from the `main` squash commits and failed the AI co-author check. Runtime source is byte-identical to that PR's head `d1f35ac622`; two test files differ (listed under Adaptations). <details><summary>Full context for agent readers</summary> ## Changes Sources, all `cherry-pick -x -m 1`, clean, in merge order: - [18104](#18104) prefer previewUrl for dragged batch-output attachments - [18110](#18110) re-measure Vue node slot offsets after graph reload - [18117](#18117) record an undo entry when a link is dropped from a Vue node slot - [18118](#18118) stop a canvas click after redo from pushing a spurious undo entry - [18124](#18124) never silently no-op the subscription-required dialog - [18127](#18127) restore autogrow inputs after Agent reconciliation - [18191](#18191) keep the ghost placement flag out of the CRDT document - [18196](#18196) retarget new Agent chat to the workflow tab on screen Adaptations, all test-only, no runtime change: - `NodeSlots` reload unit test uses `createTestingPinia` + `setActivePinia` instead of `getActivePinia()!`, because the shared test Pinia setup from [17237](#17237) is `main`-only. - Browser fixture gains `NodeSlotReference.expectLinkCount` (same body as `main`, from [17403](#17403)); three picked Agent specs open the panel with the label the release UI renders, `agent.askComfyAgent`, because `agent.entryButton` from [17621](#17621) does not exist on this line. - `useSlotLinkInteraction.autoPan.test.ts`: the `globalEnums` mock is dropped (the picked composable now reads `RenderShape` from the real module, as on `main`), and the `@vueuse/core` mock spreads the actual module so release-native transitive imports such as `useStorage` resolve while the event-listener overrides stay focused. - `useSlotLinkInteraction.autoPan.test.ts` (`249123390c`): the workflow store is mocked at its seam instead of a partial module mock, per dante01yoon's review. - `subgraphPromotedWidgetExternalLink.spec.ts` (`2991cfc3f8`): the plain CLIPTextEncode "hides the text control" case and its two constants are deleted, because it asserts [17576](#17576) behavior (WidgetGrid retains labels for connected inputs) that is not on `cloud/1.54`. Re-add when 17576 lands on this line; the 17576 decision is [blocked-on-christian 824](christian-byrne/blocked-on-christian#824). Dependencies: none added; release lockfile pins preserved. Exclusions: [18063](#18063) and [18073](#18073) conflict because they edit `agentCrdtProjection.ts` and `agentCrdtDocLifecycle.ts`, files created by the follower split in [16908](#16908), which `cloud/1.54` never received. They need focused hand re-expression onto the pre-split follower, following [18219](#18219) and [18195](#18195); tracked as separate program rows. ## Review focus - Every source commit is an unmodified cherry-pick; review effort belongs on the test-only adaptation commits and on whether the eight sources are wanted on this line at all. - Sources 18110, 18117, and 18118 touch undo/redo and slot measurement outside the Agent panel, so they change behavior for users who never open the Agent. - This is not behavioral acceptance or a merge-check waiver; no target-native browser acceptance has run outside hosted CI. ## Exact-head verification Head history: `210e191fc9` (approved by DrJKL) received five test-only follow-ups: `a9ab888243` (module-surface alignment), `a63fef35ae` (`test.fixme` instead of `test.skip`, which the release's oxlint config rejects), `118ac5e9c6` (restore VueUse exports in the auto-pan mock, fixing the suite-collection failure DrJKL found at `a63fef35ae`), `249123390c` (workflow-store seam mock), and `2991cfc3f8` (delete the plain CLIPTextEncode browser case). - `210e191fc9`, local on top of `cloud/1.54` tip `1bbcdc66fa`: cherry-pick dry run of all 10 candidates, 8 clean individually and as a sequential stack, 2 conflicting as described above; `vitest run` on the 9 touched unit test files 405 passed; both `vue-tsc` projects exit 0; `oxfmt` and `eslint` clean; lint-staged and knip passed in hooks. - `a63fef35ae`, hosted: `lint-and-format` passed. DrJKL's local focused run: 405 passed plus one suite-collection failure in `useSlotLinkInteraction.autoPan.test.ts` (`useStorage` missing from the total `@vueuse/core` mock). Fixed in `118ac5e9c6`. - `118ac5e9c6`: hosted CI green; the unit `test` job covers the collection fix. - `2991cfc3f8` (current head): hosted CI 77 success, 16 skipped, 0 failed. DrJKL's local run on this head: both typecheck projects, ESLint, Oxlint, format, and Knip clean; Vitest 4 of 4 on the auto-pan suite; Playwright discovery 43 tests across 7 specs; Fallow clean. Author-side local verification is not run on this head (host resource hold); hosted CI plus DrJKL's run are the verification of record. Program receipt: [2026-09-21-ms215-gap-backport-cloud154.md](https://github.com/christian-byrne/in-app-agent-program/blob/main/reports/pr-ownership/2026-09-21-ms215-gap-backport-cloud154.md). </details> --------- Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> Co-authored-by: test-bot <test-bot@users.noreply.github.com> Co-authored-by: Alexander Brown <drjkl@comfy.org> Co-authored-by: Amp <amp@ampcode.com>
Requested by Christian Byrne · Slack thread
Summary
Before: the agent adds a node, the websocket blips and reconnects, the follower re-sends
doc_subscribeon the new socket and nothing answers it. The bridge's reconcile no-ops once intent equals reality, the refusal backoff arms only on an explicitok: false, and the 30 s recency probe arms only after a confirm, so the canvas never shows the node, the agent reports success in chat, and the follower sits atconnected: falseforever.After: a subscribe that leaves the transport and is not acknowledged within 15 s is retried on the same lineage (same state vector, no reset), up to three attempts that share the existing refusal budget. On give-up the follower reports
connected: false, logs onefailure_confirming_agent_doc_subscribeDatadog warning, and recovers on the next reconnect, retarget ordoc_reset.The retry is safe because the ingest relay treats a repeat
doc_subscribeon one connection as an idempotent re-join (re-join the fanout, ack, catch up against the offered state vector); the 15 s timeout matches the relay's own resync budget, so a slow but live catch-up is not doubled up.Changes
LayoutFollowerBridge.reconcile()dispatchesdoc_subscribe_sentwhen a subscribe frame leaves the transport.AgentCrdtDocLifecycleowns the ack timer (SUBSCRIBE_ACK_TIMEOUT_MS = 15_000,SUBSCRIBE_ACK_MAX_TIMEOUTS = 3), the give-up latch and a newonGaveUpcallback.useAgentCrdtFollowerroutes the event into the lifecycle, resets every budget onreconnected, and marks the follower disconnected on give-up. New dev-panel event kindsubscribe_ack_timeout. The decision and alternatives are recorded indocs/adr/CRDT-FOLLOWER-0035-bounded-ack-timeout-retry-for-unacknowledged-doc-subscribe.md.Review Focus
status-frame reconcile may resubscribe; only a confirm, a reconnect or a retarget release it. Adoc_resetstill sends its fresh-lineage subscribe and its ack recovers the follower.Testing
src/workbench/extensions/agent/crdt/agentCrdtDocLifecycle.test.ts(new, 13 tests): exact timing, confirm and refusal hand-off, shared silence/refusal budget, terminal state with a singlereportError, latch behaviour, reconnect reset, retarget and destroy cancellation.followerSubscription.test.ts:doc_subscribe_sentdispatched once per successful send and again on resubscribe, gap-forced resync anddoc_reset, never on a closed socket; a late ack for a superseded same-workflow subscribe is accepted; a duplicate ack plus catch-up merges idempotently with no stale or gap signal.useAgentCrdtFollower.test.ts: the composable arms the timer from the bridge event, unmount cancels it, reconnect resets the budget,connectedflips to false on give-up.browser_tests/tests/agent/agentGraphOpLostOnDisconnect.spec.ts: the mock now swallows only the first post-reconnect subscribe and answers the retry. Red without the fix (toBeVisibleon the added node times out after 25 s), reported by Playwright as "Expected to fail, but passed" with the fix whiletest.fail()was still in place (commit 7b6c2bf), green as a plain test after the flip (commit 14a8149). The spec asserts the retry fingerprint: exactly two post-reconnectdoc_subscribeframes, same state vector, nodoc_unsubscribebetween them, spaced at leastSUBSCRIBE_ACK_TIMEOUT_MS - 500apart.pnpm lint,pnpm typecheck,pnpm format:check,pnpm knip,pnpm adr:checkandpnpm exec fallow audit --changed-since <base>are clean;pnpm test:unit src/workbench/extensions/agent/crdtpasses (640 tests).🤖 Generated with Claude Code
https://claude.ai/code/session_019PEMXgoNGrXQeBpmmTmotC