Skip to content

fix(agent-crdt): retry silent document subscriptions (cloud/1.54) - #18267

Merged
christian-byrne merged 2 commits into
cloud/1.54from
backport-18073-cloud-1.54
Sep 21, 2026
Merged

christian-byrne merged 2 commits into
cloud/1.54from
backport-18073-cloud-1.54

Conversation

@christian-byrne

@christian-byrne christian-byrne commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor

Re-expresses the unanswered document-subscribe retry from source PR 18073 on the pre-split cloud/1.54 follower.

  • Arms a 15-second acknowledgement timer only after doc_subscribe leaves the transport.
  • Retries the same workflow and state vector with a bounded shared refusal/silence budget.
  • Reports a terminal warning and keeps the follower disconnected after the budget is exhausted.
Full context for agent readers

Source: PR 18073 / ff8246bc1e575b46a3a2457623ec448fc98420ed.
Target parent: cloud/1.54 at 1bbcdc66fa00c8462bfb50a8f3a77b48556675fb.

The source fix uses AgentCrdtDocLifecycle, which was introduced by the later follower split in PR 16908. This carrier deliberately does not backport that refactor. It places the same bounded timer, give-up latch, reconnect reset, telemetry, and event wiring inside the release line's existing follower lifecycle.

The source's main-only browser spec and ADR were not copied. Release-local unit cases cover successful-send arming, timeout retries, teardown, reconnect reset, terminal state, and same-lineage idempotence. Expensive local test, typecheck, lint, format, build, and browser commands were deferred under the active host resource constraint; hosted CI is the first executable verification of this exact head.

No deployment, release, ruleset, or history mutation is included.

Justification: Qualified Agent 1.54 release backport; exact-head hosted checks and target-aware guard pass, with no reviewer objection.

Backport #18073 to cloud/1.54 by re-expressing the retry in the pre-split follower.
@coderabbitai

coderabbitai Bot commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: 6a849e53-3715-407e-b368-6450ae6f7a4b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@vercel

vercel Bot commented Sep 21, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
billing-web Ignored Ignored Sep 21, 2026 9:31am UTC

Request Review

@github-actions

github-actions Bot commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 1933 passed, 0 failed

📊 Browser Reports
  • chromium: View Report (✅ 1912 / ❌ 0 / ⚠️ 0 / ⏭️ 13)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/21/2026, 09:33:29 AM UTC

Links

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.1 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 60.6 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.6 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.3 MB heap
large-graph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.9 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 4ms TBT · 81.3 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.4 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 85.6 MB heap
minimap-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.5 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 84.0 MB heap
subgraph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.3 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 59.3 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 149ms TBT · 80.7 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 77.7 MB heap
vue-large-graph-idle: · 55.4 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 171.5 MB heap
vue-large-graph-pan: · 56.3 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 144ms TBT · 179.2 MB heap
vue-node-resize-workload: · 55.4 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 502ms TBT · 165.3 MB heap
vue-zoom-out-idle: · 56.3 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 170.9 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.2 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 9ms
canvas-idle: layout count 0
canvas-idle: style recalc count 9
canvas-idle: task duration 553ms
canvas-idle: script duration 10ms
canvas-idle: TBT 0ms
canvas-idle: heap used 63.1 MB
canvas-idle: DOM nodes -281
canvas-idle: event listeners -181
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 31ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 77
canvas-mouse-sweep: task duration 893ms
canvas-mouse-sweep: script duration 164ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 60.6 MB
canvas-mouse-sweep: DOM nodes -279
canvas-mouse-sweep: event listeners -165
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 18ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 31
canvas-zoom-sweep: task duration 376ms
canvas-zoom-sweep: script duration 12ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 71.6 MB
canvas-zoom-sweep: DOM nodes 77
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 9ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 12
dom-widget-clipping: task duration 460ms
dom-widget-clipping: script duration 163ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 72.3 MB
dom-widget-clipping: DOM nodes 19
dom-widget-clipping: event listeners 2
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 5ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 5
large-graph-idle: task duration 601ms
large-graph-idle: script duration 34ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 82.9 MB
large-graph-idle: DOM nodes -270
large-graph-idle: event listeners -162
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 14ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 67
large-graph-pan: task duration 1811ms
large-graph-pan: script duration 916ms
large-graph-pan: TBT 4ms
large-graph-pan: heap used 81.3 MB
large-graph-pan: DOM nodes -275
large-graph-pan: event listeners -177
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 12ms
large-graph-zoom: style recalc duration 11ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 61
large-graph-zoom: task duration 1768ms
large-graph-zoom: script duration 798ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 72.4 MB
large-graph-zoom: DOM nodes -143
large-graph-zoom: event listeners -90
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 5ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 40
legacy-node-drag: task duration 1944ms
legacy-node-drag: script duration 968ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 85.6 MB
legacy-node-drag: DOM nodes 0
legacy-node-drag: event listeners 188
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 5ms
minimap-idle: layout count 0
minimap-idle: style recalc count 5
minimap-idle: task duration 571ms
minimap-idle: script duration 33ms
minimap-idle: TBT 0ms
minimap-idle: heap used 83.5 MB
minimap-idle: DOM nodes -270
minimap-idle: event listeners -80
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 11ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 47
subgraph-dom-widget-clipping: task duration 422ms
subgraph-dom-widget-clipping: script duration 143ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 84.0 MB
subgraph-dom-widget-clipping: DOM nodes 19
subgraph-dom-widget-clipping: event listeners 7
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 8ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 9
subgraph-idle: task duration 497ms
subgraph-idle: script duration 8ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 67.3 MB
subgraph-idle: DOM nodes -296
subgraph-idle: event listeners -210
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 5ms
subgraph-mouse-sweep: style recalc duration 29ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 78
subgraph-mouse-sweep: task duration 850ms
subgraph-mouse-sweep: script duration 113ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 59.3 MB
subgraph-mouse-sweep: DOM nodes -295
subgraph-mouse-sweep: event listeners -225
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 16ms
subgraph-transition-enter: style recalc duration 33ms
subgraph-transition-enter: layout count 15
subgraph-transition-enter: style recalc count 19
subgraph-transition-enter: task duration 962ms
subgraph-transition-enter: script duration 33ms
subgraph-transition-enter: TBT 149ms
subgraph-transition-enter: heap used 80.7 MB
subgraph-transition-enter: DOM nodes 13751
subgraph-transition-enter: event listeners 2385
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 39ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 248
viewport-pan-sweep: task duration 6128ms
viewport-pan-sweep: script duration 2845ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 77.7 MB
viewport-pan-sweep: DOM nodes -276
viewport-pan-sweep: event listeners -161
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 16976ms
vue-large-graph-idle: script duration 302ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 171.5 MB
vue-large-graph-idle: DOM nodes -8068
vue-large-graph-idle: event listeners -14934
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 19ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 174
vue-large-graph-pan: task duration 21109ms
vue-large-graph-pan: script duration 980ms
vue-large-graph-pan: TBT 144ms
vue-large-graph-pan: heap used 179.2 MB
vue-large-graph-pan: DOM nodes -8068
vue-large-graph-pan: event listeners -14928
vue-node-resize-workload: avg frame time 18ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 28ms
vue-node-resize-workload: style recalc duration 86ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 6210ms
vue-node-resize-workload: script duration 115ms
vue-node-resize-workload: TBT 502ms
vue-node-resize-workload: heap used 165.3 MB
vue-node-resize-workload: DOM nodes -8068
vue-node-resize-workload: event listeners -14928
vue-zoom-out-idle: avg frame time 18ms
vue-zoom-out-idle: p95 frame time 17ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 8557ms
vue-zoom-out-idle: script duration 145ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 170.9 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners -12
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 17ms
workflow-execution: layout count 2
workflow-execution: style recalc count 10
workflow-execution: task duration 88ms
workflow-execution: script duration 8ms
workflow-execution: TBT 0ms
workflow-execution: heap used 69.2 MB
workflow-execution: DOM nodes 124
workflow-execution: event listeners 43
Raw data
{
  "timestamp": "2026-09-21T09:43:26.649Z",
  "gitSha": "998ba1f5d5a7f68713c3bfed2565d8e43aa2bf7b",
  "branch": "backport-18073-cloud-1.54",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2051.0360000000105,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 7.403999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 608.138,
      "heapDeltaBytes": -6098340,
      "heapUsedBytes": 64027620,
      "domNodes": -282,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 9.029000000000002,
      "eventListeners": -198,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2056.8949999999973,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 9.664,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 498.8550000000001,
      "heapDeltaBytes": -1732184,
      "heapUsedBytes": 68406396,
      "domNodes": -279,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 11.327,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1844.6270000000027,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 30.180999999999997,
      "layouts": 14,
      "layoutDurationMs": 4.192,
      "taskDurationMs": 901.1310000000001,
      "heapDeltaBytes": -875548,
      "heapUsedBytes": 68703632,
      "domNodes": -279,
      "jsHeapTotalBytes": 6545408,
      "scriptDurationMs": 166.998,
      "eventListeners": -166,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1839.0860000000089,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 31.79,
      "layouts": 14,
      "layoutDurationMs": 4.348,
      "taskDurationMs": 884.698,
      "heapDeltaBytes": -12144248,
      "heapUsedBytes": 58390432,
      "domNodes": -279,
      "jsHeapTotalBytes": 6283264,
      "scriptDurationMs": 161.923,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1720.1420000000098,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 15.981999999999996,
      "layouts": 6,
      "layoutDurationMs": 0.993,
      "taskDurationMs": 355.721,
      "heapDeltaBytes": 4627268,
      "heapUsedBytes": 74952508,
      "domNodes": 75,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 10.497,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1714.1570000000002,
      "styleRecalcs": 30,
      "styleRecalcDurationMs": 19.539,
      "layouts": 6,
      "layoutDurationMs": 1.3479999999999999,
      "taskDurationMs": 396.29400000000004,
      "heapDeltaBytes": 4581696,
      "heapUsedBytes": 75194572,
      "domNodes": 79,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 12.598999999999998,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 666.3530000000151,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 8.436,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 455.83799999999997,
      "heapDeltaBytes": 18092416,
      "heapUsedBytes": 88652544,
      "domNodes": 18,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 162.261,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 684.8630000000071,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 8.886,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 464.235,
      "heapDeltaBytes": -8184300,
      "heapUsedBytes": 62890380,
      "domNodes": 20,
      "jsHeapTotalBytes": 6291456,
      "scriptDurationMs": 163.41,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2071.8289999999797,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 6.416999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 612.665,
      "heapDeltaBytes": 10005192,
      "heapUsedBytes": 86563492,
      "domNodes": -272,
      "jsHeapTotalBytes": -2465792,
      "scriptDurationMs": 33.89,
      "eventListeners": -162,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2027.6660000000675,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 4.281,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 588.639,
      "heapDeltaBytes": -15836072,
      "heapUsedBytes": 87383816,
      "domNodes": -267,
      "jsHeapTotalBytes": -1642496,
      "scriptDurationMs": 34.415,
      "eventListeners": -162,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2580.5990000000065,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 13.102000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1767.977,
      "heapDeltaBytes": 8870664,
      "heapUsedBytes": 85346772,
      "domNodes": -272,
      "jsHeapTotalBytes": 1691648,
      "scriptDurationMs": 858.6279999999999,
      "eventListeners": -162,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2712.3880000000327,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 14.059999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1854.7150000000001,
      "heapDeltaBytes": 7350580,
      "heapUsedBytes": 85076668,
      "domNodes": -278,
      "jsHeapTotalBytes": -143360,
      "scriptDurationMs": 974.326,
      "eventListeners": -192,
      "totalBlockingTimeMs": 7,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3639.630000000011,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 10.298000000000002,
      "layouts": 60,
      "layoutDurationMs": 12.574000000000002,
      "taskDurationMs": 1736.634,
      "heapDeltaBytes": 8369600,
      "heapUsedBytes": 76310328,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 796.003,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3626.0839999999916,
      "styleRecalcs": 61,
      "styleRecalcDurationMs": 12.090999999999998,
      "layouts": 60,
      "layoutDurationMs": 12.356,
      "taskDurationMs": 1800.3390000000002,
      "heapDeltaBytes": -3001544,
      "heapUsedBytes": 75542676,
      "domNodes": -286,
      "jsHeapTotalBytes": -1417216,
      "scriptDurationMs": 799.5329999999999,
      "eventListeners": -190,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3103.1750000000216,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 5.4990000000000006,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1941.92,
      "heapDeltaBytes": 19398480,
      "heapUsedBytes": 89464788,
      "domNodes": 0,
      "jsHeapTotalBytes": 1990656,
      "scriptDurationMs": 959.236,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3095.493000000033,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 4.864,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1945.36,
      "heapDeltaBytes": 22143580,
      "heapUsedBytes": 89995456,
      "domNodes": 0,
      "jsHeapTotalBytes": 679936,
      "scriptDurationMs": 976.1529999999999,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2039.5059999999603,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 8.459000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 599.614,
      "heapDeltaBytes": 10397796,
      "heapUsedBytes": 86944132,
      "domNodes": -268,
      "jsHeapTotalBytes": -1417216,
      "scriptDurationMs": 34.44,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2005.0240000000485,
      "styleRecalcs": 3,
      "styleRecalcDurationMs": 2.4530000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 543.108,
      "heapDeltaBytes": 21796060,
      "heapUsedBytes": 88184484,
      "domNodes": -272,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 31.137999999999998,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 606.6569999999842,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 10.176,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 425.35,
      "heapDeltaBytes": 15043536,
      "heapUsedBytes": 88290788,
      "domNodes": 18,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 145.214,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 612.310999999977,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 11.815,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 418.51300000000003,
      "heapDeltaBytes": 14976776,
      "heapUsedBytes": 87919912,
      "domNodes": 20,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 141.2,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2034.9190000000021,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.941999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 503.431,
      "heapDeltaBytes": 8865240,
      "heapUsedBytes": 81699784,
      "domNodes": -295,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 7.931999999999998,
      "eventListeners": -210,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2006.6339999999627,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.966000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 490.168,
      "heapDeltaBytes": -13430700,
      "heapUsedBytes": 59532288,
      "domNodes": -296,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 7.778000000000002,
      "eventListeners": -210,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1717.2130000000152,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 28.131999999999998,
      "layouts": 18,
      "layoutDurationMs": 4.944,
      "taskDurationMs": 824.057,
      "heapDeltaBytes": -14967952,
      "heapUsedBytes": 57816204,
      "domNodes": -296,
      "jsHeapTotalBytes": 6807552,
      "scriptDurationMs": 109.005,
      "eventListeners": -210,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1764.7079999999278,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 30.627999999999997,
      "layouts": 18,
      "layoutDurationMs": 4.760999999999999,
      "taskDurationMs": 875.014,
      "heapDeltaBytes": -6691616,
      "heapUsedBytes": 66450416,
      "domNodes": -294,
      "jsHeapTotalBytes": 7069696,
      "scriptDurationMs": 117.436,
      "eventListeners": -240,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1434.9080000000072,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 33.08299999999999,
      "layouts": 15,
      "layoutDurationMs": 16.238,
      "taskDurationMs": 961.865,
      "heapDeltaBytes": -5262388,
      "heapUsedBytes": 84568984,
      "domNodes": 13751,
      "jsHeapTotalBytes": 11010048,
      "scriptDurationMs": 33.095,
      "eventListeners": 2385,
      "totalBlockingTimeMs": 149,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8570.647000000008,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 37.816,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5985.14,
      "heapDeltaBytes": 1658200,
      "heapUsedBytes": 77885452,
      "domNodes": -279,
      "jsHeapTotalBytes": 643072,
      "scriptDurationMs": 2771.366,
      "eventListeners": -176,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8968.282000000045,
      "styleRecalcs": 246,
      "styleRecalcDurationMs": 39.471000000000004,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6269.979,
      "heapDeltaBytes": -18262064,
      "heapUsedBytes": 85155452,
      "domNodes": -273,
      "jsHeapTotalBytes": -1187840,
      "scriptDurationMs": 2918.7279999999996,
      "eventListeners": -146,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17791.41900000002,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17129.651,
      "heapDeltaBytes": -56199456,
      "heapUsedBytes": 177648284,
      "domNodes": -8068,
      "jsHeapTotalBytes": -16474112,
      "scriptDurationMs": 311.68199999999996,
      "eventListeners": -14935,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 18.333333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17424.797000000013,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16822.12,
      "heapDeltaBytes": -53772256,
      "heapUsedBytes": 181925232,
      "domNodes": -8068,
      "jsHeapTotalBytes": -13807616,
      "scriptDurationMs": 292.801,
      "eventListeners": -14933,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21445.798000000024,
      "styleRecalcs": 178,
      "styleRecalcDurationMs": 18.61400000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 21082.749,
      "heapDeltaBytes": -37214996,
      "heapUsedBytes": 192563492,
      "domNodes": -8068,
      "jsHeapTotalBytes": -20168704,
      "scriptDurationMs": 970.028,
      "eventListeners": -14929,
      "totalBlockingTimeMs": 245,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21443.833000000042,
      "styleRecalcs": 169,
      "styleRecalcDurationMs": 18.703000000000024,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 21134.644,
      "heapDeltaBytes": -35321644,
      "heapUsedBytes": 183274268,
      "domNodes": -8068,
      "jsHeapTotalBytes": -11988992,
      "scriptDurationMs": 990.597,
      "eventListeners": -14927,
      "totalBlockingTimeMs": 43,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6358.212000000038,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 78.64300000000001,
      "layouts": 20,
      "layoutDurationMs": 22.639999999999993,
      "taskDurationMs": 6231.6539999999995,
      "heapDeltaBytes": -57934616,
      "heapUsedBytes": 169949740,
      "domNodes": -8068,
      "jsHeapTotalBytes": 12689408,
      "scriptDurationMs": 115.231,
      "eventListeners": -14927,
      "totalBlockingTimeMs": 427,
      "frameDurationMs": 18.333333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6311.655999999971,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 93.71199999999996,
      "layouts": 20,
      "layoutDurationMs": 33.63100000000001,
      "taskDurationMs": 6188.459,
      "heapDeltaBytes": -43101884,
      "heapUsedBytes": 176607380,
      "domNodes": -8068,
      "jsHeapTotalBytes": 9269248,
      "scriptDurationMs": 115.24600000000001,
      "eventListeners": -14929,
      "totalBlockingTimeMs": 577,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8803.985000000011,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8449.319,
      "heapDeltaBytes": 13973844,
      "heapUsedBytes": 178531768,
      "domNodes": 0,
      "jsHeapTotalBytes": -18612224,
      "scriptDurationMs": 142.204,
      "eventListeners": -12,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666763,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 9171.069000000101,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8665.125,
      "heapDeltaBytes": 6768712,
      "heapUsedBytes": 179944072,
      "domNodes": 0,
      "jsHeapTotalBytes": -13893632,
      "scriptDurationMs": 147.5080000000001,
      "eventListeners": -12,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 116.0380000000032,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 19.060000000000002,
      "layouts": 2,
      "layoutDurationMs": 1.3589999999999998,
      "taskDurationMs": 84.44399999999999,
      "heapDeltaBytes": 3017916,
      "heapUsedBytes": 71279424,
      "domNodes": 131,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 8.505,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 446.8650000000025,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 15.430000000000001,
      "layouts": 2,
      "layoutDurationMs": 0.4559999999999999,
      "taskDurationMs": 92.184,
      "heapDeltaBytes": 4753540,
      "heapUsedBytes": 73817860,
      "domNodes": 117,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 7.575,
      "eventListeners": 67,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    }
  ]
}

🔬 E2E Coverage

Metric Covered Total Pct
Lines 50281 75334 66.7% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.4% 1159
src/LGraphNode.ts 69.5% 390
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/platform/workspace/stores/billingOperationStore.ts 7.9% 313
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/LGraph.ts 78.3% 264
src/platform/workspace/stores/teamWorkspaceStore.ts 37.7% 261
src/scripts/app.ts 71.6% 257
src/scripts/pnginfo.ts 21.4% 221

@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Sep 21, 2026
@codecov

codecov Bot commented Sep 21, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@              Coverage Diff              @@
##             cloud/1.54   #18267   +/-   ##
=============================================
  Coverage              ?   83.56%           
=============================================
  Files                 ?     2094           
  Lines                 ?   123628           
  Branches              ?    33132           
=============================================
  Hits                  ?   103306           
  Misses                ?    20144           
  Partials              ?      178           
Flag Coverage Δ
e2e 66.75% <ø> (?)
unit 78.49% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...c/workbench/extensions/agent/crdt/CrdtDevPanel.vue 92.09% <ø> (ø)
src/workbench/extensions/agent/crdt/devPanelLog.ts 100.00% <ø> (ø)
...ench/extensions/agent/crdt/layoutFollowerBridge.ts 97.60% <100.00%> (ø)
...ench/extensions/agent/crdt/useAgentCrdtFollower.ts 98.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@christian-byrne christian-byrne left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exact-head adaptation review at ba5fccde73d59b38392ebe89d73b02a650be5bc2 against cloud/1.54 tip 1bbcdc66fa00c8462bfb50a8f3a77b48556675fb: no blocking findings.

I compared the six-file pre-split-follower implementation with source PR #18073. The successful-send event arms the 15-second acknowledgement timer only after transport delivery; refusal and silence consume the same retry counter; the third unanswered subscribe latches terminal give-up; acknowledgement, reconnect, retarget, and teardown follow the source lifecycle; and stale probes cannot bypass an active timer or the give-up latch. The automatic merge tree is exactly the reviewed head tree (27d9ac710a97040373f794ce0cff54ac8a7e28fa), and all 91 hosted checks are terminal non-adverse (78 success, 13 skipped; required unit, lint/format, and E2E gates pass).

Local suites were intentionally not rerun under the active host-resource restriction; this review relies on static exact-head inspection and hosted CI. COMMENT only: this records adaptation clearance and does not fabricate an approval.

@christian-byrne christian-byrne left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refresh-only exact-head adaptation review at 3307c1fd9c58514da17aa92a63f96d7d486f39c5: no blocking findings.

The head is a two-parent merge of the previously reviewed carrier ba5fccde73d59b38392ebe89d73b02a650be5bc2 and current cloud/1.54 tip 4985279d1ecf12b764c225be12315905b06e5bb7. Git resolved it without conflict to tree a69c7f3570b2b46c71952622200953f52bba5c50, preserving both the silent-subscribe retry and the just-landed pending-delete/tab-suspension fix. No product hunk was rewritten during refresh.

Hosted checks on this new head remain required. Local suites remain deferred under the active host-resource restriction. COMMENT only: this records adaptation clearance and does not fabricate an approval.

@christian-byrne
christian-byrne merged commit f39439a into cloud/1.54 Sep 21, 2026
92 checks passed
@christian-byrne
christian-byrne deleted the backport-18073-cloud-1.54 branch September 21, 2026 10:00

@DrJKL DrJKL left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Post-merge review found one behavior defect and three missing regression cases. These are follow-up targets; this is a COMMENT review on the merged PR.

Finding without an inline anchor
  • [P3] Correct the state-vector claim in the PR description. The description says retries use the "same workflow and state vector," but LayoutFollowerBridge.reconcile() calls follower.stateVector() for every send. If the follower document changes between attempts, the value changes. The invariant is the same workflow and document lineage, using the current state vector. Please use that wording in follow-up documentation.
Checked and cleared
  • The timer, counters, and give-up latch remain inline rather than moving into the later lifecycle abstraction. The PR explicitly chose this shape for the pre-split release branch, so I did not treat the missing refactor as a follow-up defect.
  • The new event follows this release branch's existing untyped EventTarget contract. Converting the whole bridge to the repository's typed event target would be a separate refactor, not part of this backport.
  • Manual timeout ownership matches the refusal and stale timers already owned by this lifecycle. The applicable VueUse guidance covers DOM event handling, not this retry policy.
Coverage

Standard review lanes: correctness, maintainability, TypeScript/Vue idioms, unit tests, and PR prose. I traced send, acknowledgement, refusal, silence, reconnect, status, retarget, inactivity, teardown, stale probe, reset, late acknowledgement, and same-lineage update paths. The exact-head unit suite passed 1,543 files and 21,270 tests. A focused temporary assertion reproduced the refusal-exhaustion defect: after the sixth refusal, a status event called reconcile() once when terminal state should have blocked it.

*/
const onSocketActivity: EventListener = () => {
if (subscribeRetryTimer !== null) return
if (subscribeGaveUp || subscribeRetryTimer !== null) return

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P2] Latch terminal state when refusals exhaust the shared budget. scheduleSubscribeRetry() returns when subscribeRetryAttempt reaches six, but it never sets subscribeGaveUp or reports the terminal warning. The bridge clears sentWorkflowId on each refusal, so the next status event reaches this guard and sends again. I reproduced that path by extending the existing six-refusal test: the following status event called reconcile() once. Route refusal-ending exhaustion through the same terminal transition as silence, and cover a mixed silence/refusal sequence whose final outcome is a refusal.

it('retries a subscribe the bridge sent but nobody acknowledged', () => {
vi.useFakeTimers()
const { unmount } = mountFollower('wf-1')
dispatchFrame('doc_subscribe_sent', { workflowId: 'wf-1' })

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P2] Add the response-before-deadline cases. No test sends doc_subscribe_sent, receives doc_subscribed before 15 seconds, then advances past the old deadline. A missing clear on success would cause a redundant resubscribe; a missing clear on refusal would run both the ack timeout and refusal backoff. A two-row ok: true / ok: false test would protect this timer handoff.

// (`previous` is undefined there), so a plain mount or retarget keeps its
// existing "reconcile on frame or on graph readiness" behaviour.
const justActivated = active && previous?.[1] === false
clearSubscribeAckTimer()

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P2] Cover both target transitions with a pending ack timer. Existing switch coverage arms the refusal or stale timer, not doc_subscribe_sent; inactivity has the same gap. A regression that removed this clear could let workflow A's timeout resubscribe workflow B, or fire after the target becomes inactive. Table workflow switch and deactivation, advance through the old deadline, and assert no retry.

() => bridge.removeEventListener('schema_error', onSchemaError),
() => bridge.removeEventListener('doc_gap', onGap),
() => bridge.removeEventListener('doc_stale', onStale),
() => bridge.removeEventListener('doc_subscribe_sent', onSubscribeSent),

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P3] Prove the new listener is gone after teardown. The added test shows that unmount clears an already armed timer, but it would still pass if this listener removal disappeared. Emit doc_subscribe_sent on the retained fake bridge after unmount, advance 15 seconds, and assert no resubscribe or warning.

@DrJKL DrJKL added agent Comfy Agent product, integration, tests or product documentation agent-backport Agent changes targeting a stable cloud/core release branch agent-crdt Agent document synchronization, graph projection or CRDT operations agent-test-unit Touches Agent-related unit/component tests or their support agent-ui Agent panel, composer, transcript or other user-interface components labels Sep 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent Comfy Agent product, integration, tests or product documentation agent-backport Agent changes targeting a stable cloud/core release branch agent-crdt Agent document synchronization, graph projection or CRDT operations agent-test-unit Touches Agent-related unit/component tests or their support agent-ui Agent panel, composer, transcript or other user-interface components risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants