Repository navigation
test: pin combo widget false red ring condition and guard the agent write path - #18103
claude[bot] wants to merge 7 commits into
Conversation
Two test.fail Playwright repros drive set_widget, add_node and a tab round trip through the agent conversation replay fixture, one on a plain KSampler combo and one on the Flux2ImageNode dynamic combo, attaching a screenshot plus a live-vs-rendered combo lens at each step. Two failing unit cases pin the mechanism: WidgetSelectDefault marks a legal value invalid while its options list is empty or absent, and a widgetValueStore write to a COMFY_DYNAMICCOMBO_V3 selector skips the setter that rebuilds its option widgets. Synthesized repro conversations live under fixtures/data/agent/repros and are minted with comfy-cli against the pinned catalog; the replay suite still lists recordings only.
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 2037 passed, 0 failed · 2 flaky📊 Browser Reports
📦 Bundle: 9.92 MB gzip 🔴 +18 BDetailsSummary
Category Glance App Entry Points — 3.77 kB (baseline 3.77 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.45 MB (baseline 1.45 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 132 kB (baseline 132 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 14 added / 14 removed / 4 unchanged Panels & Settings — 637 kB (baseline 637 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 17 unchanged User & Accounts — 37.9 kB (baseline 37.9 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 6 added / 6 removed / 5 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 1 unchanged UI Components — 124 kB (baseline 124 kB) • ⚪ 0 BReusable component library chunks
Status: 7 added / 7 removed / 9 unchanged Data & Services — 3.86 MB (baseline 3.86 MB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 13 added / 13 removed / 3 unchanged Utilities & Hooks — 565 kB (baseline 565 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 19 added / 19 removed / 19 unchanged Vendor & Third-Party — 17.4 MB (baseline 17.4 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 17.7 MB (baseline 17.7 MB) • 🔴 +115 BBundles that do not match a named category
Status: 73 added / 73 removed / 225 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-19T15:45:39.347Z",
"gitSha": "92142fcd7ac278416183efb0a2a7183790bff34c",
"branch": "test/agent-combo-widget-red-ring-repro",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2003.0079999999657,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.125000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 319.35600000000005,
"heapDeltaBytes": -4480684,
"heapUsedBytes": 57481960,
"domNodes": -261,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 8.422999999999998,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-idle",
"durationMs": 1990.9410000000207,
"styleRecalcs": 9,
"styleRecalcDurationMs": 5.8039999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 281.147,
"heapDeltaBytes": 17113132,
"heapUsedBytes": 79117232,
"domNodes": -262,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 6.973,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1694.3810000000212,
"styleRecalcs": 74,
"styleRecalcDurationMs": 23.742,
"layouts": 14,
"layoutDurationMs": 4.4799999999999995,
"taskDurationMs": 563.352,
"heapDeltaBytes": -3813836,
"heapUsedBytes": 57254568,
"domNodes": -259,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 110.071,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1728.049999999996,
"styleRecalcs": 76,
"styleRecalcDurationMs": 27.576999999999998,
"layouts": 14,
"layoutDurationMs": 5.102,
"taskDurationMs": 603.5820000000001,
"heapDeltaBytes": 1682572,
"heapUsedBytes": 63768780,
"domNodes": -258,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 118.88799999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1708.3689999999478,
"styleRecalcs": 31,
"styleRecalcDurationMs": 14.937999999999999,
"layouts": 6,
"layoutDurationMs": 1.248,
"taskDurationMs": 257.133,
"heapDeltaBytes": 2158824,
"heapUsedBytes": 64175196,
"domNodes": 76,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 12.839,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1708.5210000000188,
"styleRecalcs": 30,
"styleRecalcDurationMs": 12.31,
"layouts": 6,
"layoutDurationMs": 1.139,
"taskDurationMs": 213.28699999999998,
"heapDeltaBytes": 2168236,
"heapUsedBytes": 64082844,
"domNodes": 77,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 9.249,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 433.63600000003544,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.525,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 291.173,
"heapDeltaBytes": 17549640,
"heapUsedBytes": 79381960,
"domNodes": 20,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 106.624,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-clipping",
"durationMs": 482.6110000000199,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.106,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 306.593,
"heapDeltaBytes": 17901540,
"heapUsedBytes": 79835732,
"domNodes": 19,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 110.806,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-idle",
"durationMs": 2022.166000000027,
"styleRecalcs": 8,
"styleRecalcDurationMs": 5.311,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 367.814,
"heapDeltaBytes": 3292808,
"heapUsedBytes": 82846800,
"domNodes": -241,
"jsHeapTotalBytes": -1581056,
"scriptDurationMs": 26.592999999999993,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2013.512999999989,
"styleRecalcs": 8,
"styleRecalcDurationMs": 4.956,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 359.848,
"heapDeltaBytes": 3547168,
"heapUsedBytes": 82805672,
"domNodes": -240,
"jsHeapTotalBytes": -794624,
"scriptDurationMs": 25.536999999999995,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2112.5579999999786,
"styleRecalcs": 67,
"styleRecalcDurationMs": 12.845999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1130.693,
"heapDeltaBytes": 14019352,
"heapUsedBytes": 78433136,
"domNodes": 10,
"jsHeapTotalBytes": 487424,
"scriptDurationMs": 594.011,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2345.4229999999825,
"styleRecalcs": 69,
"styleRecalcDurationMs": 16.19,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1172.052,
"heapDeltaBytes": -19129644,
"heapUsedBytes": 67137144,
"domNodes": -217,
"jsHeapTotalBytes": 1601536,
"scriptDurationMs": 576.902,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3356.3800000000015,
"styleRecalcs": 63,
"styleRecalcDurationMs": 14.800999999999998,
"layouts": 60,
"layoutDurationMs": 16.965,
"taskDurationMs": 1248.617,
"heapDeltaBytes": 9838584,
"heapUsedBytes": 74303460,
"domNodes": 8,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 544.1349999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3191.4500000000317,
"styleRecalcs": 63,
"styleRecalcDurationMs": 13.418999999999997,
"layouts": 60,
"layoutDurationMs": 14.575999999999999,
"taskDurationMs": 1205.098,
"heapDeltaBytes": 10040740,
"heapUsedBytes": 75428116,
"domNodes": -3,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 559.344,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2622.2869999999716,
"styleRecalcs": 45,
"styleRecalcDurationMs": 9.266,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1484.898,
"heapDeltaBytes": -3388020,
"heapUsedBytes": 80136656,
"domNodes": -254,
"jsHeapTotalBytes": 2506752,
"scriptDurationMs": 724.661,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2347.584000000097,
"styleRecalcs": 45,
"styleRecalcDurationMs": 8.833999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1368.323,
"heapDeltaBytes": 4625192,
"heapUsedBytes": 70945128,
"domNodes": 10,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 685.343,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2021.9400000000292,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.325999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 425.45199999999994,
"heapDeltaBytes": -5098308,
"heapUsedBytes": 82003164,
"domNodes": -244,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 28.731999999999992,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2004.4080000000122,
"styleRecalcs": 5,
"styleRecalcDurationMs": 3.164,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 332.14500000000004,
"heapDeltaBytes": 19708292,
"heapUsedBytes": 84079856,
"domNodes": 10,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 31.048,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 410.14300000000503,
"styleRecalcs": 48,
"styleRecalcDurationMs": 10.063,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 267.99100000000004,
"heapDeltaBytes": 13099264,
"heapUsedBytes": 76488344,
"domNodes": 22,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 93.27499999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 426.32399999990866,
"styleRecalcs": 48,
"styleRecalcDurationMs": 10.296999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 278.537,
"heapDeltaBytes": 13376764,
"heapUsedBytes": 76589412,
"domNodes": 22,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 98.18299999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-idle",
"durationMs": 2043.8029999999685,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.970000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 404.1050000000001,
"heapDeltaBytes": 412188,
"heapUsedBytes": 63831672,
"domNodes": -276,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 16.076999999999998,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 1991.5529999999535,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.321000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 313.68700000000007,
"heapDeltaBytes": -2559236,
"heapUsedBytes": 60148260,
"domNodes": -274,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 7.191000000000002,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1694.1130000000157,
"styleRecalcs": 77,
"styleRecalcDurationMs": 27.237,
"layouts": 18,
"layoutDurationMs": 5.745,
"taskDurationMs": 592.407,
"heapDeltaBytes": -152220,
"heapUsedBytes": 63168188,
"domNodes": -274,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 90.962,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1675.275000000056,
"styleRecalcs": 78,
"styleRecalcDurationMs": 23.850999999999996,
"layouts": 18,
"layoutDurationMs": 5.437,
"taskDurationMs": 567.833,
"heapDeltaBytes": 16619124,
"heapUsedBytes": 79811128,
"domNodes": -273,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 88.963,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 833.5370000000353,
"styleRecalcs": 18,
"styleRecalcDurationMs": 18.878,
"layouts": 5,
"layoutDurationMs": 7.622,
"taskDurationMs": 611.0629999999999,
"heapDeltaBytes": -6546484,
"heapUsedBytes": 84320900,
"domNodes": 13587,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 24.771999999999995,
"eventListeners": 2383,
"totalBlockingTimeMs": 60,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 9015.092999999979,
"styleRecalcs": 248,
"styleRecalcDurationMs": 43.31700000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4322.965,
"heapDeltaBytes": -3766528,
"heapUsedBytes": 75309460,
"domNodes": -244,
"jsHeapTotalBytes": 1003520,
"scriptDurationMs": 2014.4989999999998,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 9033.506999999987,
"styleRecalcs": 249,
"styleRecalcDurationMs": 43.21999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4452.7339999999995,
"heapDeltaBytes": 9651796,
"heapUsedBytes": 88597828,
"domNodes": -245,
"jsHeapTotalBytes": 3624960,
"scriptDurationMs": 2231.0860000000002,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 12372.793999999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11806.302,
"heapDeltaBytes": -64020076,
"heapUsedBytes": 171961484,
"domNodes": -8091,
"jsHeapTotalBytes": -17182720,
"scriptDurationMs": 175.29600000000002,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 11956.978999999934,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11215.432999999999,
"heapDeltaBytes": -40860172,
"heapUsedBytes": 189579384,
"domNodes": -8062,
"jsHeapTotalBytes": -13688832,
"scriptDurationMs": 156.271,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 14463.963999999976,
"styleRecalcs": 70,
"styleRecalcDurationMs": 14.734999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14343.850999999999,
"heapDeltaBytes": -50033184,
"heapUsedBytes": 184900812,
"domNodes": -8062,
"jsHeapTotalBytes": -19214336,
"scriptDurationMs": 665.504,
"eventListeners": -14928,
"totalBlockingTimeMs": 46,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 14260.076000000026,
"styleRecalcs": 69,
"styleRecalcDurationMs": 13.650999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13970.834,
"heapDeltaBytes": -23971260,
"heapUsedBytes": 187030664,
"domNodes": -8062,
"jsHeapTotalBytes": -16764928,
"scriptDurationMs": 645.92,
"eventListeners": -14928,
"totalBlockingTimeMs": 57,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 4437.600000000031,
"styleRecalcs": 20,
"styleRecalcDurationMs": 56.921,
"layouts": 20,
"layoutDurationMs": 23.92799999999999,
"taskDurationMs": 4411.807999999999,
"heapDeltaBytes": -40509676,
"heapUsedBytes": 176765372,
"domNodes": -8062,
"jsHeapTotalBytes": 15527936,
"scriptDurationMs": 76.678,
"eventListeners": -14928,
"totalBlockingTimeMs": 50,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 4345.5169999999725,
"styleRecalcs": 20,
"styleRecalcDurationMs": 51.314,
"layouts": 20,
"layoutDurationMs": 22.055000000000007,
"taskDurationMs": 4268.456,
"heapDeltaBytes": -19390524,
"heapUsedBytes": 191149776,
"domNodes": -8062,
"jsHeapTotalBytes": 20766720,
"scriptDurationMs": 70.19,
"eventListeners": -14928,
"totalBlockingTimeMs": 23,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6118.434999999977,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5920.438000000001,
"heapDeltaBytes": -17271872,
"heapUsedBytes": 176720688,
"domNodes": 0,
"jsHeapTotalBytes": -19660800,
"scriptDurationMs": 85.03100000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6176.148000000012,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5986.978000000001,
"heapDeltaBytes": -30406816,
"heapUsedBytes": 164637504,
"domNodes": 0,
"jsHeapTotalBytes": -22020096,
"scriptDurationMs": 81.16600000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 423.5089999999673,
"styleRecalcs": 12,
"styleRecalcDurationMs": 15.780999999999997,
"layouts": 3,
"layoutDurationMs": 0.8890000000000002,
"taskDurationMs": 81.66,
"heapDeltaBytes": 4796048,
"heapUsedBytes": 66205568,
"domNodes": 122,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 7.527999999999998,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 67.30300000003808,
"styleRecalcs": 6,
"styleRecalcDurationMs": 10.147000000000002,
"layouts": 2,
"layoutDurationMs": 1.1310000000000002,
"taskDurationMs": 47.48400000000001,
"heapDeltaBytes": 2883288,
"heapUsedBytes": 64430820,
"domNodes": 121,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 3.4599999999999995,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000273
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Both e2e cases passed under test.fail in CI and locally: set_widget on a live node, add_node with combo values and a tab-return resync leave every KSampler and Flux2ImageNode combo without an invalid ring, because the placeholder widget an add_node registers is materialized in the same frame. Drop test.fail so they guard the path; the rendering condition stays pinned by the failing unit cases.
|
CI note on the a3e7c01 drops Local runs of the final spec: KSampler 1/1, Flux2ImageNode 3/3 on an idle runner. One earlier Flux2 run, taken right after a heavy job, missed the fixture's 5 s |
Playwright videos for new testsDownload the recorded videos and HTML report Recorded projects: cloud Recorded test titles:
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #18103 +/- ##
==========================================
+ Coverage 82.79% 83.80% +1.00%
==========================================
Files 2938 2244 -694
Lines 144525 127678 -16847
Branches 39037 34354 -4683
==========================================
- Hits 119658 106995 -12663
+ Misses 23611 20394 -3217
+ Partials 1256 289 -967
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 707 files with indirect coverage changes 🚀 New features to boost your workflow:
|
The recordings check compared RECORDED_EXPECTATIONS against the files under conversations/ only, so the two synthesized repro cases with expectations of their own failed it. Include repros/ in the turn count.
WidgetSelectDefault's isInvalid painted the red ring on any value once options.values was undefined or [], including an agent-written value whose options simply haven't loaded/materialized yet. Only ring once there's a real options list to judge the value against.
Assessment of the two red unit tests
The bug: Both fixes the task description suggested turn out to have real blast radius, not a one-line guard:
Either path touches It's also worth noting the e2e replay ( Recommendation: leave Net: the rendering symptom (red ring on a legal value) is fixed and shipped regardless of the unconfirmed production trigger — it can't mask a real "genuinely stale value" problem, since real staleness only shows up once options are actually populated. The dynamic-combo setter-skip is a separate, real bug, but its fix needs a design decision on |
|
Updating Playwright Expectations |
| snapshot | status | changed pixels | | --- | --- | --- | | `tests/links/linkVisibility.spec.ts-snapshots/vue-link-hidden-chromium-linux.png` | modified | 53487B -> 53293B | | `tests/links/linkVisibility.spec.ts-snapshots/vue-link-revealed-from-input-chromium-linux.png` | modified | 56813B -> 56573B | | `tests/links/linkVisibility.spec.ts-snapshots/vue-link-revealed-from-output-chromium-linux.png` | modified | 56735B -> 56500B | | `tests/vueNodes/interactions/canvas/pan.spec.ts-snapshots/vue-nodes-paned-with-touch-mobile-chrome-linux.png` | modified | 26264B -> 25800B | | `tests/vueNodes/nodeStates/colors.spec.ts-snapshots/vue-node-custom-color-blue-chromium-linux.png` | modified | 104899B -> 104721B | | `tests/vueNodes/nodeStates/colors.spec.ts-snapshots/vue-node-custom-colors-dark-all-colors-chromium-linux.png` | modified | 137427B -> 136884B | | `tests/vueNodes/nodeStates/colors.spec.ts-snapshots/vue-node-custom-colors-light-all-colors-chromium-linux.png` | modified | 139597B -> 138978B | | `tests/vueNodes/rerouteNodeSize.spec.ts-snapshots/vue-reroute-node-compact-chromium-linux.png` | modified | 52024B -> 51844B | Screenshot capture is not bit-deterministic; small pixel deltas are usually text rasterization noise. Confirm each rewrite corresponds to a test expected to change.
…et-red-ring-repro # Conflicts: # browser_tests/tests/vueNodes/interactions/canvas/pan.spec.ts-snapshots/vue-nodes-paned-with-touch-mobile-chrome-linux.png # browser_tests/tests/vueNodes/nodeStates/colors.spec.ts-snapshots/vue-node-custom-color-blue-chromium-linux.png # browser_tests/tests/vueNodes/nodeStates/colors.spec.ts-snapshots/vue-node-custom-colors-dark-all-colors-chromium-linux.png # browser_tests/tests/vueNodes/nodeStates/colors.spec.ts-snapshots/vue-node-custom-colors-light-all-colors-chromium-linux.png # browser_tests/tests/vueNodes/rerouteNodeSize.spec.ts-snapshots/vue-reroute-node-compact-chromium-linux.png
| snapshot | status | changed pixels | | --- | --- | --- | | `tests/vueNodes/interactions/canvas/pan.spec.ts-snapshots/vue-nodes-paned-with-touch-mobile-chrome-linux.png` | modified | 25800B -> 25733B | | `tests/vueNodes/nodeStates/colors.spec.ts-snapshots/vue-node-custom-color-blue-chromium-linux.png` | modified | 104721B -> 104848B | | `tests/vueNodes/nodeStates/colors.spec.ts-snapshots/vue-node-custom-colors-dark-all-colors-chromium-linux.png` | modified | 136884B -> 137109B | | `tests/vueNodes/nodeStates/colors.spec.ts-snapshots/vue-node-custom-colors-light-all-colors-chromium-linux.png` | modified | 138978B -> 139336B | | `tests/vueNodes/rerouteNodeSize.spec.ts-snapshots/vue-reroute-node-compact-chromium-linux.png` | modified | 51844B -> 51916B | Screenshot capture is not bit-deterministic; small pixel deltas are usually text rasterization noise. Confirm each rewrite corresponds to a test expected to change.
|
Investigated the three CI failures on this PR ( Root cause: none of these were flakes. The Searched every All CI checks are now green on the current head, including the three originally-failing jobs. 🤖 Generated with Claude Code |
|
A push to Mechanical part (fine to auto-resolve when this lands): 5 binary Playwright screenshot conflicts ( Substantive conflict (the actual blocker): both branches independently fixed the same combo-widget red-ring bug in
This needs a human call on how to reconcile #18070's mechanism with this PR's fix — e.g. whether the narrower Generated by Claude Code |
|
Closing this stale repro branch as superseded by #18070 and the follow-up production fixes already on main. The branch is now conflicting, its agent replay cases did not reproduce the reported ring, and the remaining dynamic-combo setter-skip was explicitly left as an unconfirmed, separate design question. Keeping this open would imply PM-1272 / PM-1311 still need this merge when those tickets are already resolved by the shipped path. |
Requested by Christian Byrne · Slack thread
Summary
Investigation tests for the report that combo widgets in an agent workflow tab paint the red "invalid value" ring although every value the agent wrote is a legal option. Two reports came in: one on plain parameter dropdowns, one specifically on Flux2ImageNode. No fix is included.
Two levels of evidence, and they disagree in an informative way:
it.fails): the rendering condition exists.WidgetSelectDefault.vue'sisInvalidpaints the ring on a legal value whenever the widget'soptions.valuesisundefinedor[], and awidgetValueStore.setValue()on aCOMFY_DYNAMICCOMBO_V3selector skips the setter that rebuilds its option widgets.set_widgeton a live node,add_nodewith combo values, and a tab-return resync through the conversation replay fixture leaves every KSampler and Flux2ImageNode combo without a ring (two-lens check: live litegraphoptionsvs renderedaria-invalid). The placeholder widget anadd_noderegisters withoptions: {}is materialized in the same frame, so its empty list never reaches the renderer. The first push had these astest.fail; CI'splaywright-video-new-testsand a local run both reported "Expected to fail, but passed", so they are now plain tests guarding the path.What this says about the reports
The earlier root-cause hypothesis (agent write bypasses the widget callback, leaving the value out of sync with a stale options list) is not confirmed by the replay path for either node family. The condition that produces the ring is real, so the production trigger is something that leaves a combo's options list empty or missing the value at render time and that this harness does not exercise. Candidates worth a real recording from the reporting environment: a remote combo whose
values: []binding has not loaded yet, a mismatch between the agent's pinned catalog and the client'sobject_infooptions, or an asset or model list that resolves differently in cloud. The Flux2ImageNode report cannot be tied to the plain-dropdown report on this evidence; treat it as unconfirmed rather than a duplicate. The dynamic-combo setter bypass is real but invisible in this fixture because bothmodeloptions declare the same sub-inputs.Changes
browser_tests/tests/agent/agentComboWidgetRedRing.spec.ts: two@cloud @agent @widgetcases on the agent conversation replay fixture (KSampler plain combo, Flux2ImageNode dynamic combo). Each step attaches a full-page screenshot plus a JSON lens of every combo through two views: the live litegraph widget (value, options,valueInOptions) and the renderedWidgetSelectDefaulttrigger (aria-invalid).browser_tests/fixtures/helpers/ComboWidgetHelper.ts: the two-lens helper.browser_tests/fixtures/data/agent/repros/*.json: synthesized conversations (response_side: synthesized), ops minted with comfy-cli 1.20.0 against the cloud object_info catalog (sha256:325ecf69...), envelope stripped.agentConversation.tsalso loads fromrepros/;listRecordedConversations()still lists recordings only. README documents the convention.WidgetSelectDefault.test.ts:it.fails.fortable, a legal value must not be marked invalid whileoptions.valuesisundefinedor[].dynamicWidgets.test.ts:test.fails, awidgetValueStore.setValue()on the selector must rebuild option widgets like a direct write does.Testing
WidgetSelectDefaultrows report as expected failures; the newdynamicWidgetscase fails withAssertionError: expected 2 to be 3.--project=cloud, local dev server + CPU ComfyUI backend): both cases pass (KSampler 43.4 s). Screenshots and lens JSON showmodel=Flux.2 [max]in a 2-entry options list,aria-invalidabsent, before and after the tab round trip.pnpm typecheckpass.🤖 Generated with Claude Code
https://claude.ai/code/session_01WgCgZKjk1bLPcyYppEr9DZ