Repository navigation
fix: restore composer placeholder (cloud/1.54) - #18195
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
🎭 Playwright: ✅ 1930 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-20T17:56:47.059Z",
"gitSha": "197cdf53e13266d7c2fe7a20fc7606ba1746c98d",
"branch": "christian/claude-placeholder-cloud154",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2018.6800000000176,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.891000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 488.765,
"heapDeltaBytes": 9385836,
"heapUsedBytes": 79191976,
"domNodes": -279,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 8.233,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-idle",
"durationMs": 2040.2959999998984,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.244,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 489.4580000000001,
"heapDeltaBytes": -13160388,
"heapUsedBytes": 55895476,
"domNodes": 20,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 8.562999999999997,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2047.7899999999636,
"styleRecalcs": 78,
"styleRecalcDurationMs": 31.272000000000002,
"layouts": 14,
"layoutDurationMs": 4.836,
"taskDurationMs": 1013.5110000000001,
"heapDeltaBytes": -3561400,
"heapUsedBytes": 65439592,
"domNodes": -282,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 181.81399999999996,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1782.000999999923,
"styleRecalcs": 73,
"styleRecalcDurationMs": 26.714000000000002,
"layouts": 14,
"layoutDurationMs": 3.9639999999999995,
"taskDurationMs": 854.403,
"heapDeltaBytes": -6794100,
"heapUsedBytes": 63468556,
"domNodes": -280,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 160.408,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1755.010000000084,
"styleRecalcs": 33,
"styleRecalcDurationMs": 16.854,
"layouts": 6,
"layoutDurationMs": 1.107,
"taskDurationMs": 349.977,
"heapDeltaBytes": 4672648,
"heapUsedBytes": 74926204,
"domNodes": 76,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 10.843000000000002,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1665.318999999954,
"styleRecalcs": 30,
"styleRecalcDurationMs": 17.196999999999996,
"layouts": 6,
"layoutDurationMs": 0.915,
"taskDurationMs": 346.259,
"heapDeltaBytes": 4627996,
"heapUsedBytes": 75047300,
"domNodes": 76,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 10.287,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 632.9929999999422,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.498000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 455.492,
"heapDeltaBytes": 18336428,
"heapUsedBytes": 88751108,
"domNodes": 16,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 164.432,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 660.3850000000193,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.088999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 444.15799999999996,
"heapDeltaBytes": 18060680,
"heapUsedBytes": 88364108,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 160.268,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2073.2100000000173,
"styleRecalcs": 8,
"styleRecalcDurationMs": 13.104999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 627.1089999999999,
"heapDeltaBytes": 5594688,
"heapUsedBytes": 81771300,
"domNodes": -278,
"jsHeapTotalBytes": -1679360,
"scriptDurationMs": 34.137,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2026.56300000001,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.779000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 590.579,
"heapDeltaBytes": 11044384,
"heapUsedBytes": 86545688,
"domNodes": -270,
"jsHeapTotalBytes": -1679360,
"scriptDurationMs": 32.84100000000001,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2264.2299999999977,
"styleRecalcs": 67,
"styleRecalcDurationMs": 12.944000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1669.0259999999996,
"heapDeltaBytes": -9453760,
"heapUsedBytes": 67422604,
"domNodes": -280,
"jsHeapTotalBytes": 155648,
"scriptDurationMs": 818.0289999999999,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2224.864000000025,
"styleRecalcs": 65,
"styleRecalcDurationMs": 9.874999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1618.645,
"heapDeltaBytes": 19069464,
"heapUsedBytes": 84605916,
"domNodes": -276,
"jsHeapTotalBytes": 1011712,
"scriptDurationMs": 807.4689999999999,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3499.2180000000417,
"styleRecalcs": 62,
"styleRecalcDurationMs": 11.918999999999999,
"layouts": 60,
"layoutDurationMs": 11.276000000000002,
"taskDurationMs": 1725.9450000000004,
"heapDeltaBytes": -2670604,
"heapUsedBytes": 75959816,
"domNodes": -284,
"jsHeapTotalBytes": -2203648,
"scriptDurationMs": 757.1450000000001,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3537.1410000000196,
"styleRecalcs": 63,
"styleRecalcDurationMs": 12.906,
"layouts": 60,
"layoutDurationMs": 11.85,
"taskDurationMs": 1739.3359999999998,
"heapDeltaBytes": 14207308,
"heapUsedBytes": 92945004,
"domNodes": -288,
"jsHeapTotalBytes": 3825664,
"scriptDurationMs": 776.3910000000001,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3088.9329999999973,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.796000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1939.3939999999998,
"heapDeltaBytes": 22040692,
"heapUsedBytes": 89330132,
"domNodes": 0,
"jsHeapTotalBytes": 679936,
"scriptDurationMs": 1000.969,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666636,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3064.6500000000287,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.499,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1908.1119999999999,
"heapDeltaBytes": 22592352,
"heapUsedBytes": 90231360,
"domNodes": 0,
"jsHeapTotalBytes": 1204224,
"scriptDurationMs": 947.1030000000001,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2026.5459999999393,
"styleRecalcs": 2,
"styleRecalcDurationMs": 1.9109999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 538.13,
"heapDeltaBytes": 22229032,
"heapUsedBytes": 87946788,
"domNodes": -275,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 34.515,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2060.081999999966,
"styleRecalcs": 6,
"styleRecalcDurationMs": 6.473,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 613.595,
"heapDeltaBytes": 5887356,
"heapUsedBytes": 83321992,
"domNodes": -280,
"jsHeapTotalBytes": -1679360,
"scriptDurationMs": 32.722,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 614.0980000000127,
"styleRecalcs": 46,
"styleRecalcDurationMs": 11.270000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 414.27000000000004,
"heapDeltaBytes": 14698784,
"heapUsedBytes": 87680708,
"domNodes": 18,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 146.84900000000002,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 593.9060000000609,
"styleRecalcs": 44,
"styleRecalcDurationMs": 8.567000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 410.89,
"heapDeltaBytes": 14720140,
"heapUsedBytes": 87742240,
"domNodes": 14,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 143.96499999999997,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2021.0230000000138,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.157000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 489.54600000000005,
"heapDeltaBytes": -6918132,
"heapUsedBytes": 65844996,
"domNodes": -295,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 7.945,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2017.7889999999934,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.662000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 480.326,
"heapDeltaBytes": 8909252,
"heapUsedBytes": 81696388,
"domNodes": -296,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 7.769000000000002,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1753.4560000000283,
"styleRecalcs": 79,
"styleRecalcDurationMs": 27.849,
"layouts": 18,
"layoutDurationMs": 5.311,
"taskDurationMs": 810.319,
"heapDeltaBytes": 1655748,
"heapUsedBytes": 74871320,
"domNodes": -293,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 110.36600000000001,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1782.0580000000064,
"styleRecalcs": 80,
"styleRecalcDurationMs": 27.854999999999997,
"layouts": 18,
"layoutDurationMs": 5.083,
"taskDurationMs": 842.171,
"heapDeltaBytes": -14694508,
"heapUsedBytes": 58088988,
"domNodes": -296,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 113.63699999999999,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1416.4040000000568,
"styleRecalcs": 19,
"styleRecalcDurationMs": 32.507,
"layouts": 15,
"layoutDurationMs": 15.777999999999997,
"taskDurationMs": 940.7079999999999,
"heapDeltaBytes": 21982208,
"heapUsedBytes": 106608268,
"domNodes": 13751,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 28.462,
"eventListeners": 2387,
"totalBlockingTimeMs": 148,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8672.505999999998,
"styleRecalcs": 249,
"styleRecalcDurationMs": 35.605,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5809.277,
"heapDeltaBytes": 1806616,
"heapUsedBytes": 77623780,
"domNodes": -280,
"jsHeapTotalBytes": 1167360,
"scriptDurationMs": 2681.6969999999997,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8455.463000000009,
"styleRecalcs": 249,
"styleRecalcDurationMs": 35.186,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5826.739,
"heapDeltaBytes": -7315216,
"heapUsedBytes": 68339984,
"domNodes": -280,
"jsHeapTotalBytes": 679936,
"scriptDurationMs": 2717.0490000000004,
"eventListeners": -178,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17163.697999999953,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16675.094,
"heapDeltaBytes": -60918720,
"heapUsedBytes": 178017436,
"domNodes": -8068,
"jsHeapTotalBytes": -15863808,
"scriptDurationMs": 274.871,
"eventListeners": -14931,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17261.080999999875,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16658.424,
"heapDeltaBytes": -39279604,
"heapUsedBytes": 178129248,
"domNodes": -8068,
"jsHeapTotalBytes": -14426112,
"scriptDurationMs": 270.38700000000006,
"eventListeners": -14933,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 21059.63299999996,
"styleRecalcs": 175,
"styleRecalcDurationMs": 18.426,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20726.164999999997,
"heapDeltaBytes": -45306760,
"heapUsedBytes": 166877356,
"domNodes": -8068,
"jsHeapTotalBytes": -16924672,
"scriptDurationMs": 910.7579999999999,
"eventListeners": -14929,
"totalBlockingTimeMs": 50,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 20632.622000000083,
"styleRecalcs": 169,
"styleRecalcDurationMs": 16.141000000000016,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20248.557,
"heapDeltaBytes": -46242980,
"heapUsedBytes": 178874452,
"domNodes": -8068,
"jsHeapTotalBytes": -17457152,
"scriptDurationMs": 876.593,
"eventListeners": -14927,
"totalBlockingTimeMs": 13,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 6280.412999999953,
"styleRecalcs": 20,
"styleRecalcDurationMs": 82.34800000000003,
"layouts": 20,
"layoutDurationMs": 23.125999999999994,
"taskDurationMs": 6140.0830000000005,
"heapDeltaBytes": -40600608,
"heapUsedBytes": 183338888,
"domNodes": -8067,
"jsHeapTotalBytes": 6193152,
"scriptDurationMs": 137.173,
"eventListeners": -14925,
"totalBlockingTimeMs": 408,
"frameDurationMs": 17.773333333333298,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 6242.034999999987,
"styleRecalcs": 20,
"styleRecalcDurationMs": 84.29999999999998,
"layouts": 20,
"layoutDurationMs": 22.89899999999999,
"taskDurationMs": 6097.479000000001,
"heapDeltaBytes": -56392556,
"heapUsedBytes": 182124744,
"domNodes": -8068,
"jsHeapTotalBytes": 10047488,
"scriptDurationMs": 108.122,
"eventListeners": -14931,
"totalBlockingTimeMs": 505,
"frameDurationMs": 18.329999999999927,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8617.520000000013,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8405.197000000002,
"heapDeltaBytes": 8056808,
"heapUsedBytes": 170427860,
"domNodes": 0,
"jsHeapTotalBytes": -16515072,
"scriptDurationMs": 181.06300000000002,
"eventListeners": -12,
"totalBlockingTimeMs": 2,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8858.76600000006,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8480.103,
"heapDeltaBytes": 15019156,
"heapUsedBytes": 178943020,
"domNodes": 0,
"jsHeapTotalBytes": -18874368,
"scriptDurationMs": 138.957,
"eventListeners": -14,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 516.5529999999308,
"styleRecalcs": 17,
"styleRecalcDurationMs": 37.977,
"layouts": 2,
"layoutDurationMs": 0.9189999999999999,
"taskDurationMs": 147.42899999999997,
"heapDeltaBytes": 4981116,
"heapUsedBytes": 73907836,
"domNodes": 145,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 11.646,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 121.47800000002462,
"styleRecalcs": 7,
"styleRecalcDurationMs": 13.286999999999999,
"layouts": 2,
"layoutDurationMs": 0.729,
"taskDurationMs": 96.53200000000001,
"heapDeltaBytes": -14050380,
"heapUsedBytes": 64724932,
"domNodes": 106,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 5.226000000000002,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
} |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.54 #18195 +/- ##
=============================================
Coverage ? 83.53%
=============================================
Files ? 2094
Lines ? 123386
Branches ? 34407
=============================================
Hits ? 103070
Misses ? 20138
Partials ? 178
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
The composer placeholder backport passes target-native acceptance. Normal merge remains blocked on non-author approval under this completion lane's no-admin rule.
Full context for agent readers
Reviewed the production patch against the merged source fix and the four-line target-native objectInfo fixture adaptation. Each release target passed 229 unit/component tests, the Cloud browser case, source/browser typechecks, formatting, lint and normal hooks. The core target also has three failing-before/passing-after checks. The fresh release-target guard confirms base ancestry, 91 terminal non-adverse checks and no unresolved review threads at this submitted head. No source-main refresh, deployment or fabricated self-approval.
Christian's completion lane retains both release outcomes in the placeholder issue and the program's composer-release task. This COMMENT records review evidence; it is not another person's approval.
Glossary: target-native acceptance runs the repair on the intended release branch; a backport carries an already-merged fix to an older release.
dante01yoon
left a comment
There was a problem hiding this comment.
Verdict: approve — clean, minimal backport.
I diffed this PR against the merged source (#18069) hunk by hunk. Every shared file is byte-identical once index/@@ headers are normalised:
src/.../agentComposerStore.ts— identicalsrc/.../composer/InlinePromptEditor.vue— identicalsrc/.../agentComposerStore.test.ts,Composer.inlineReferences.test.ts,AgentPanelRoot.test.ts— identicalbrowser_tests/tests/agent/agentComposerPlaceholderReset.spec.ts,agentPanelMocks.ts— identical
The only delta is the extra browser_tests/fixtures/utils/cloudBootMocks.ts hunk, which is the correct adaptation rather than main-only drift: main already carries this option as objectInfo?: 'server' | Record<string, ComfyNodeDef>, so #18069 did not need to add it. This branch adds only the narrower objectInfo?: 'server' form the new spec actually uses, and leaves the default mocked path (objectInfo === undefined → empty /api/object_info) unchanged. Nothing main-only rode along.
Spot checks on the release target head:
ComposerReferenceis already imported inagentComposerStore.tsoncloud/1.54, so the newresetTextWhenReferencesClearedsignature type-checks without a new import.Composer.vueon this head already declaresavailableWorkflowsandselectWorkflowReference, so the new props inComposer.inlineReferences.test.tsare real props, not silently-ignored extras.- The updated
nextAction === 'removed-attachment'expectation inAgentPanelRoot.test.tsis consistent with the production change:removeAttachment()routes throughremoveReference(), which now clears whitespace-only text once the last reference is gone. deleteReference()only consumes padding whenstate.doc.nodeAt(end)is a text node starting with a space, soend + paddingstays in range and typed text after a chip survives — matching the newkeeps a typed leading space when no reference was insertedcase.
All 106 CI checks on this head are successful or skipped; none failed. No findings.
Validation I did not run: I reviewed read-only through the GitHub API and did not execute the unit or Playwright suites locally, so the test-run counts in the description are author-reported here.
…t a cloud carrier (#18257) ## Summary Eight merged `main` Agent fixes that had no `cloud/1.54` carrier are cherry-picked onto the current release tip. Two sources need hand re-expression and are excluded. Runtime source is unmodified from the eight sources; seven follow-up commits are test-only adaptations to the release's module surface. Verification at the current head `2991cfc3f8` is hosted CI (77 success, 16 skipped, 0 failed) plus DrJKL's local run (see below); the picked browser specs had not been run against the target before this PR. Open gates: release-scope sign-off on the three non-Agent carries and exact-head human re-approval on `2991cfc3f8`, both tracked in [blocked-on-christian 825](christian-byrne/blocked-on-christian#825). Replaces [18254](#18254): six picks there inherited `Co-authored-by: Claude` trailers from the `main` squash commits and failed the AI co-author check. Runtime source is byte-identical to that PR's head `d1f35ac622`; two test files differ (listed under Adaptations). <details><summary>Full context for agent readers</summary> ## Changes Sources, all `cherry-pick -x -m 1`, clean, in merge order: - [18104](#18104) prefer previewUrl for dragged batch-output attachments - [18110](#18110) re-measure Vue node slot offsets after graph reload - [18117](#18117) record an undo entry when a link is dropped from a Vue node slot - [18118](#18118) stop a canvas click after redo from pushing a spurious undo entry - [18124](#18124) never silently no-op the subscription-required dialog - [18127](#18127) restore autogrow inputs after Agent reconciliation - [18191](#18191) keep the ghost placement flag out of the CRDT document - [18196](#18196) retarget new Agent chat to the workflow tab on screen Adaptations, all test-only, no runtime change: - `NodeSlots` reload unit test uses `createTestingPinia` + `setActivePinia` instead of `getActivePinia()!`, because the shared test Pinia setup from [17237](#17237) is `main`-only. - Browser fixture gains `NodeSlotReference.expectLinkCount` (same body as `main`, from [17403](#17403)); three picked Agent specs open the panel with the label the release UI renders, `agent.askComfyAgent`, because `agent.entryButton` from [17621](#17621) does not exist on this line. - `useSlotLinkInteraction.autoPan.test.ts`: the `globalEnums` mock is dropped (the picked composable now reads `RenderShape` from the real module, as on `main`), and the `@vueuse/core` mock spreads the actual module so release-native transitive imports such as `useStorage` resolve while the event-listener overrides stay focused. - `useSlotLinkInteraction.autoPan.test.ts` (`249123390c`): the workflow store is mocked at its seam instead of a partial module mock, per dante01yoon's review. - `subgraphPromotedWidgetExternalLink.spec.ts` (`2991cfc3f8`): the plain CLIPTextEncode "hides the text control" case and its two constants are deleted, because it asserts [17576](#17576) behavior (WidgetGrid retains labels for connected inputs) that is not on `cloud/1.54`. Re-add when 17576 lands on this line; the 17576 decision is [blocked-on-christian 824](christian-byrne/blocked-on-christian#824). Dependencies: none added; release lockfile pins preserved. Exclusions: [18063](#18063) and [18073](#18073) conflict because they edit `agentCrdtProjection.ts` and `agentCrdtDocLifecycle.ts`, files created by the follower split in [16908](#16908), which `cloud/1.54` never received. They need focused hand re-expression onto the pre-split follower, following [18219](#18219) and [18195](#18195); tracked as separate program rows. ## Review focus - Every source commit is an unmodified cherry-pick; review effort belongs on the test-only adaptation commits and on whether the eight sources are wanted on this line at all. - Sources 18110, 18117, and 18118 touch undo/redo and slot measurement outside the Agent panel, so they change behavior for users who never open the Agent. - This is not behavioral acceptance or a merge-check waiver; no target-native browser acceptance has run outside hosted CI. ## Exact-head verification Head history: `210e191fc9` (approved by DrJKL) received five test-only follow-ups: `a9ab888243` (module-surface alignment), `a63fef35ae` (`test.fixme` instead of `test.skip`, which the release's oxlint config rejects), `118ac5e9c6` (restore VueUse exports in the auto-pan mock, fixing the suite-collection failure DrJKL found at `a63fef35ae`), `249123390c` (workflow-store seam mock), and `2991cfc3f8` (delete the plain CLIPTextEncode browser case). - `210e191fc9`, local on top of `cloud/1.54` tip `1bbcdc66fa`: cherry-pick dry run of all 10 candidates, 8 clean individually and as a sequential stack, 2 conflicting as described above; `vitest run` on the 9 touched unit test files 405 passed; both `vue-tsc` projects exit 0; `oxfmt` and `eslint` clean; lint-staged and knip passed in hooks. - `a63fef35ae`, hosted: `lint-and-format` passed. DrJKL's local focused run: 405 passed plus one suite-collection failure in `useSlotLinkInteraction.autoPan.test.ts` (`useStorage` missing from the total `@vueuse/core` mock). Fixed in `118ac5e9c6`. - `118ac5e9c6`: hosted CI green; the unit `test` job covers the collection fix. - `2991cfc3f8` (current head): hosted CI 77 success, 16 skipped, 0 failed. DrJKL's local run on this head: both typecheck projects, ESLint, Oxlint, format, and Knip clean; Vitest 4 of 4 on the auto-pan suite; Playwright discovery 43 tests across 7 specs; Fallow clean. Author-side local verification is not run on this head (host resource hold); hosted CI plus DrJKL's run are the verification of record. Program receipt: [2026-09-21-ms215-gap-backport-cloud154.md](https://github.com/christian-byrne/in-app-agent-program/blob/main/reports/pr-ownership/2026-09-21-ms215-gap-backport-cloud154.md). </details> --------- Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> Co-authored-by: test-bot <test-bot@users.noreply.github.com> Co-authored-by: Alexander Brown <drjkl@comfy.org> Co-authored-by: Amp <amp@ampcode.com>
Summary
Restore the composer placeholder after removing its last reference. Backport the merged source fix with a release-native browser fixture.
Human owner: christian-byrne
Full context for agent readers
Changes
Production behavior matches the reviewed source: removing the final node/workflow reference clears insertion padding, without normalizing ordinary typed text. The release's
mockCloudBootgains the opt-inobjectInfo: 'server'fixture option; its default mocked behavior is unchanged. No production prerequisite or wholesale main merge.Review Focus
Preserve typed leading spaces and text after removed references. Verify chip-button, Backspace and node-selection removal. This is an adapted backport, not an unchanged automatic cherry-pick.
Test Plan
Tracking
Placeholder incident and release follow-through remains open under Christian's completion lane. The program receipt records both release targets and retained evidence. A merge is not deployment.
Glossary: backport applies a merged source fix to a release branch; fixture adaptation changes test setup rather than shipped behavior.