Repository navigation
fix: restore composer placeholder (core/1.54) - #18194
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
🎭 Playwright: ✅ 1931 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-20T18:24:22.549Z",
"gitSha": "0bcc0b152f1730fb9d976989a7ff8a62a7c0985b",
"branch": "christian/claude-placeholder-core154",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2037.4669999999924,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.104,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 505.628,
"heapDeltaBytes": -7600508,
"heapUsedBytes": 62477240,
"domNodes": -278,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 10.148000000000001,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2038.5539999999764,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.397999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 476.85299999999995,
"heapDeltaBytes": -8181680,
"heapUsedBytes": 61793924,
"domNodes": -279,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 10.175,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1759.8189999999931,
"styleRecalcs": 75,
"styleRecalcDurationMs": 24.692000000000004,
"layouts": 14,
"layoutDurationMs": 4.176,
"taskDurationMs": 717.588,
"heapDeltaBytes": -491740,
"heapUsedBytes": 69213408,
"domNodes": -281,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 125.89800000000001,
"eventListeners": -166,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1724.5229999999765,
"styleRecalcs": 74,
"styleRecalcDurationMs": 24.596,
"layouts": 14,
"layoutDurationMs": 3.6819999999999995,
"taskDurationMs": 738.065,
"heapDeltaBytes": 7368248,
"heapUsedBytes": 77381348,
"domNodes": -280,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 127.574,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1666.3800000000037,
"styleRecalcs": 31,
"styleRecalcDurationMs": 13.187999999999999,
"layouts": 6,
"layoutDurationMs": 0.9159999999999999,
"taskDurationMs": 290.54999999999995,
"heapDeltaBytes": 4265396,
"heapUsedBytes": 74494296,
"domNodes": 77,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 10.065000000000001,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1724.8319999999921,
"styleRecalcs": 30,
"styleRecalcDurationMs": 15.693999999999999,
"layouts": 6,
"layoutDurationMs": 1.1430000000000002,
"taskDurationMs": 359.674,
"heapDeltaBytes": 4666864,
"heapUsedBytes": 75437664,
"domNodes": 75,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 14.334999999999999,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 570.4620000000205,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.922000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 385.534,
"heapDeltaBytes": 17685892,
"heapUsedBytes": 87643388,
"domNodes": 20,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 133.304,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 561.6569999999683,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.051,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 390.76500000000004,
"heapDeltaBytes": 18616336,
"heapUsedBytes": 87962888,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 129.279,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666682,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2022.7610000000027,
"styleRecalcs": 6,
"styleRecalcDurationMs": 4.840000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 524.495,
"heapDeltaBytes": 10719148,
"heapUsedBytes": 86962792,
"domNodes": -267,
"jsHeapTotalBytes": -3252224,
"scriptDurationMs": 29.679,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2037.6110000000835,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.065000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 593.5950000000001,
"heapDeltaBytes": -15603988,
"heapUsedBytes": 87477252,
"domNodes": -262,
"jsHeapTotalBytes": -1380352,
"scriptDurationMs": 34.147000000000006,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2269.9499999999944,
"styleRecalcs": 69,
"styleRecalcDurationMs": 16.384999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1450.627,
"heapDeltaBytes": -1256372,
"heapUsedBytes": 76090700,
"domNodes": -276,
"jsHeapTotalBytes": -143360,
"scriptDurationMs": 666.577,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2199.102000000039,
"styleRecalcs": 67,
"styleRecalcDurationMs": 11.982,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1405.468,
"heapDeltaBytes": 19788884,
"heapUsedBytes": 85640432,
"domNodes": -270,
"jsHeapTotalBytes": 1536000,
"scriptDurationMs": 683.901,
"eventListeners": -160,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3282.9100000000153,
"styleRecalcs": 61,
"styleRecalcDurationMs": 10.640999999999998,
"layouts": 60,
"layoutDurationMs": 12.14,
"taskDurationMs": 1434.3499999999997,
"heapDeltaBytes": 8505712,
"heapUsedBytes": 75916968,
"domNodes": 2,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 626.903,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3342.948999999976,
"styleRecalcs": 62,
"styleRecalcDurationMs": 12.691,
"layouts": 60,
"layoutDurationMs": 13.404,
"taskDurationMs": 1518.1489999999997,
"heapDeltaBytes": 8365008,
"heapUsedBytes": 76255960,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 681.1030000000001,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2469.765999999993,
"styleRecalcs": 41,
"styleRecalcDurationMs": 5.686,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1629.572,
"heapDeltaBytes": 12845296,
"heapUsedBytes": 80543832,
"domNodes": 2,
"jsHeapTotalBytes": 679936,
"scriptDurationMs": 797.809,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2546.244999999999,
"styleRecalcs": 43,
"styleRecalcDurationMs": 10.292000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1667.7120000000002,
"heapDeltaBytes": 211596,
"heapUsedBytes": 80510652,
"domNodes": -281,
"jsHeapTotalBytes": -1261568,
"scriptDurationMs": 781.084,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2053.2670000000053,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.136999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 511.7839999999999,
"heapDeltaBytes": 6755700,
"heapUsedBytes": 84044460,
"domNodes": -284,
"jsHeapTotalBytes": -1155072,
"scriptDurationMs": 31.311000000000007,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2028.833000000077,
"styleRecalcs": 6,
"styleRecalcDurationMs": 4.857999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 544.3739999999999,
"heapDeltaBytes": 10537508,
"heapUsedBytes": 87814684,
"domNodes": -268,
"jsHeapTotalBytes": -2465792,
"scriptDurationMs": 31.7,
"eventListeners": -160,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 530.3759999999897,
"styleRecalcs": 47,
"styleRecalcDurationMs": 9.429,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 332.889,
"heapDeltaBytes": 14568208,
"heapUsedBytes": 86552476,
"domNodes": 20,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 114.232,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 544.1460000000689,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.004000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 353.801,
"heapDeltaBytes": 14259688,
"heapUsedBytes": 86202252,
"domNodes": 20,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 116.178,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 1992.1080000000302,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.269999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 402.949,
"heapDeltaBytes": -15362872,
"heapUsedBytes": 57301236,
"domNodes": -295,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 7.731,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 1991.2590000000137,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.355,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 470.77,
"heapDeltaBytes": 7195304,
"heapUsedBytes": 78595532,
"domNodes": -295,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 9.752000000000002,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1704.7190000000114,
"styleRecalcs": 78,
"styleRecalcDurationMs": 24.711999999999996,
"layouts": 18,
"layoutDurationMs": 4.5,
"taskDurationMs": 676.457,
"heapDeltaBytes": -8747812,
"heapUsedBytes": 63541264,
"domNodes": -292,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 89.60199999999999,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1690.9950000000435,
"styleRecalcs": 77,
"styleRecalcDurationMs": 24.597,
"layouts": 18,
"layoutDurationMs": 4.543,
"taskDurationMs": 705.508,
"heapDeltaBytes": -7976292,
"heapUsedBytes": 63997880,
"domNodes": -294,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 92.57799999999999,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1319.0309999999954,
"styleRecalcs": 20,
"styleRecalcDurationMs": 26.468999999999994,
"layouts": 16,
"layoutDurationMs": 12.373000000000001,
"taskDurationMs": 825.2430000000002,
"heapDeltaBytes": -5119796,
"heapUsedBytes": 85021952,
"domNodes": 13751,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 26.918999999999997,
"eventListeners": 2385,
"totalBlockingTimeMs": 92,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8431.96599999999,
"styleRecalcs": 247,
"styleRecalcDurationMs": 36.689,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4896.677000000001,
"heapDeltaBytes": 8811468,
"heapUsedBytes": 85136044,
"domNodes": -271,
"jsHeapTotalBytes": -1191936,
"scriptDurationMs": 2188.6229999999996,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8575.755999999956,
"styleRecalcs": 249,
"styleRecalcDurationMs": 39.413,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5046.146000000001,
"heapDeltaBytes": 8543456,
"heapUsedBytes": 84376172,
"domNodes": -271,
"jsHeapTotalBytes": -143360,
"scriptDurationMs": 2198.9700000000003,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 14937.761000000024,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14517.995000000003,
"heapDeltaBytes": -53075672,
"heapUsedBytes": 178600044,
"domNodes": -8068,
"jsHeapTotalBytes": -17383424,
"scriptDurationMs": 224.97400000000002,
"eventListeners": -14935,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 14833.007000000067,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14440.386,
"heapDeltaBytes": -59639024,
"heapUsedBytes": 169122608,
"domNodes": -8068,
"jsHeapTotalBytes": -15966208,
"scriptDurationMs": 227.016,
"eventListeners": -14933,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 17795.357000000025,
"styleRecalcs": 136,
"styleRecalcDurationMs": 15.577000000000007,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17451.636000000002,
"heapDeltaBytes": -58174972,
"heapUsedBytes": 168989308,
"domNodes": -8068,
"jsHeapTotalBytes": -21467136,
"scriptDurationMs": 734.108,
"eventListeners": -14933,
"totalBlockingTimeMs": 7,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 17641.47700000001,
"styleRecalcs": 141,
"styleRecalcDurationMs": 16.495000000000008,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17315.825,
"heapDeltaBytes": -29157776,
"heapUsedBytes": 192331420,
"domNodes": -8068,
"jsHeapTotalBytes": -14028800,
"scriptDurationMs": 777.465,
"eventListeners": -14931,
"totalBlockingTimeMs": 18,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 5335.194000000001,
"styleRecalcs": 20,
"styleRecalcDurationMs": 59.55599999999997,
"layouts": 20,
"layoutDurationMs": 20.664,
"taskDurationMs": 5246.277,
"heapDeltaBytes": -45437360,
"heapUsedBytes": 173198824,
"domNodes": -8068,
"jsHeapTotalBytes": 20750336,
"scriptDurationMs": 90.32499999999999,
"eventListeners": -14933,
"totalBlockingTimeMs": 182,
"frameDurationMs": 17.220000000000013,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 5374.260000000049,
"styleRecalcs": 20,
"styleRecalcDurationMs": 61.032000000000004,
"layouts": 20,
"layoutDurationMs": 21.356,
"taskDurationMs": 5262.612000000001,
"heapDeltaBytes": -35833200,
"heapUsedBytes": 181775064,
"domNodes": -8068,
"jsHeapTotalBytes": 18092032,
"scriptDurationMs": 92.302,
"eventListeners": -14929,
"totalBlockingTimeMs": 191,
"frameDurationMs": 17.220000000000013,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7540.6290000000245,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7372.358999999998,
"heapDeltaBytes": 9685312,
"heapUsedBytes": 170360752,
"domNodes": 0,
"jsHeapTotalBytes": -6815744,
"scriptDurationMs": 111.81800000000003,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7396.588000000065,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7238.417,
"heapDeltaBytes": 11335936,
"heapUsedBytes": 171041384,
"domNodes": 0,
"jsHeapTotalBytes": -6029312,
"scriptDurationMs": 113.54799999999999,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 454.2240000000106,
"styleRecalcs": 18,
"styleRecalcDurationMs": 19.268,
"layouts": 4,
"layoutDurationMs": 1.667,
"taskDurationMs": 99.49699999999999,
"heapDeltaBytes": 5099292,
"heapUsedBytes": 73992932,
"domNodes": 149,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 11.706,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "workflow-execution",
"durationMs": 79.44999999995161,
"styleRecalcs": 6,
"styleRecalcDurationMs": 10.931999999999999,
"layouts": 2,
"layoutDurationMs": 0.9850000000000002,
"taskDurationMs": 52.13800000000002,
"heapDeltaBytes": 2988924,
"heapUsedBytes": 71817696,
"domNodes": 124,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 4.123999999999999,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.54 #18194 +/- ##
=============================================
- Coverage 83.53% 83.52% -0.01%
=============================================
Files 2094 2094
Lines 123380 123387 +7
Branches 31385 31387 +2
=============================================
+ Hits 103060 103062 +2
- Misses 20141 20146 +5
Partials 179 179
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 8 files with indirect coverage changes 🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
The composer placeholder backport passes target-native acceptance. Normal merge remains blocked on non-author approval under this completion lane's no-admin rule.
Full context for agent readers
Reviewed the production patch against the merged source fix and the four-line target-native objectInfo fixture adaptation. Each release target passed 229 unit/component tests, the Cloud browser case, source/browser typechecks, formatting, lint and normal hooks. The core target also has three failing-before/passing-after checks. The fresh release-target guard confirms base ancestry, 91 terminal non-adverse checks and no unresolved review threads at this submitted head. No source-main refresh, deployment or fabricated self-approval.
Christian's completion lane retains both release outcomes in the placeholder issue and the program's composer-release task. This COMMENT records review evidence; it is not another person's approval.
Glossary: target-native acceptance runs the repair on the intended release branch; a backport carries an already-merged fix to an older release.
dante01yoon
left a comment
There was a problem hiding this comment.
Approving. I reviewed this as a backport, so the question I tried to answer is fidelity to the merged source rather than re-litigating the fix — and it holds up unusually cleanly.
Per-file fidelity against #18069 (merged to main as 02f631c). I extracted the changed lines of every file the two PRs share and compared them:
| File | Result |
|---|---|
src/workbench/extensions/agent/stores/agent/agentComposerStore.ts |
identical (30 changed lines) |
src/workbench/extensions/agent/components/agent/composer/InlinePromptEditor.vue |
identical (14) |
src/workbench/extensions/agent/AgentPanelRoot.test.ts |
identical (9) |
src/workbench/extensions/agent/components/agent/Composer.inlineReferences.test.ts |
identical (53) |
src/workbench/extensions/agent/stores/agent/agentComposerStore.test.ts |
identical (18) |
browser_tests/tests/agent/agentComposerPlaceholderReset.spec.ts |
identical (100) |
browser_tests/tests/agent/agentPanelMocks.ts |
identical (9) |
Both production files are byte-identical to the reviewed source, so the shipped behaviour is the source's: deleteReference swallows one trailing padding space with the chip, and resetTextWhenReferencesCleared clears text only when the reference list is empty and the remainder is whitespace — which is what keeps the "typed leading space" case from regressing.
The one adaptation is a correct narrowing, not an invention. cloudBootMocks.ts is the only file not in the source PR, because main's mockCloudBootRoutes already understands objectInfo. Comparing against main, this backport implements the strict subset the test needs — objectInfo?: 'server' versus main's 'server' | Record<string, ComfyNodeDef> — and the 'server' path behaves identically on both (skip the /api/object_info route so the real catalogue loads). Default behaviour is unchanged since objectInfo is undefined for every existing caller. Narrower than main is the safe direction for a release branch.
No main-only dependency slipped in. I checked each thing the new spec reaches for against core/1.54 at this head: agent.addToPrompt / agent.nodes locale keys exist; Composer.vue already accepts availableWorkflows and selectWorkflowReference; NodeSelectionModeBanner.vue carries the node-selection-mode-banner test id; comfyPage.nodeOps.{clearGraph,addNode}, comfyPage.canvasOps.mouseClickAt, comfyPage.nextFrame and AgentPanel.{open,selectWorkflow} are all present on the release line.
No findings. Not re-reviewing the fix design itself — that was settled on #18069, and this carries it verbatim.
Unanchored
The fidelity comparison above is a property of the diff as a whole rather than of any one changed line, so there is nothing to attach it to inline. Validation I did not run: I did not execute the release-target unit suite or the target-native Cloud browser case locally, so the "229 unit/component tests" and browser-case results in the test plan are taken as reported.
christian-byrne
left a comment
There was a problem hiding this comment.
Cloud backport merged. Core refreshed and browser-qualified. Core merge and final release acceptance remain open.
Full context for agent readers
The composer source fix merged at 08:53 UTC. Prior red/green cases cover node-selection removal, inline chip removal and Backspace while preserving typed text.
The Cloud backport merged at 18:00:45 UTC as release commit a84e8cc7, verified as the cloud/1.54 tip. It had 230 focused tests, source/browser types and the passing black-box removal case, with exact-head approval before normal auto-merge. This is a release-branch merge, not a deployment.
The Core backport now includes the current core/1.54 aggregate through non-rewriting integration 7ba2244272. Reviewed the clean integration; only the Agent panel test file overlapped, retaining both consent and composer tests. The source fix remains unchanged. 230 focused tests, source/browser typechecks and the push hook pass.
Two earlier browser attempts could not find the Agent button. Correcting the isolated Vite server to explicit DISTRIBUTION=cloud with the qualified loopback backend made the unchanged browser case pass in eight seconds. The final screenshot was inspected: the empty composer shows its placeholder and no residual reference. No consent regression was established, no assertion was weakened, and the failed attempts remain preserved. The schedule now requires explicit distribution selection before blaming product code for this symptom. Dante's approval covers the refreshed head; hosted checks are running and normal auto-merge is enabled.
Christian's completion lane retains the existing composer handoff task and this incident through the Core merge and final release acceptance. No automatic backport labels: both carriers include release-fixture adaptation. Durable receipt.
Glossary: backport applies a merged fix to a release branch; distribution selects which product surface the frontend builds; exact head is the specific reviewed commit.
Summary
Restore the composer placeholder after removing its last reference. Backport the merged source fix with a release-native browser fixture.
Human owner: christian-byrne
Full context for agent readers
Changes
Production behavior matches the reviewed source: removing the final node/workflow reference clears insertion padding, without normalizing ordinary typed text. The release's
mockCloudBootgains the opt-inobjectInfo: 'server'fixture option; its default mocked behavior is unchanged. No production prerequisite or wholesale main merge.Review Focus
Preserve typed leading spaces and text after removed references. Verify chip-button, Backspace and node-selection removal. This is an adapted backport, not an unchanged automatic cherry-pick.
Test Plan
Tracking
Placeholder incident and release follow-through remains open under Christian's completion lane. The program receipt records both release targets and retained evidence. A merge is not deployment.
Glossary: backport applies a merged source fix to a release branch; fixture adaptation changes test setup rather than shipped behavior.