Repository navigation
fix: default dynamic combo migration options to an empty array - #18037
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 2040 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle: 9.92 MB gzip 🟢 -20 BDetailsSummary
Category Glance App Entry Points — 3.77 kB (baseline 3.77 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.45 MB (baseline 1.45 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 132 kB (baseline 132 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 14 added / 14 removed / 4 unchanged Panels & Settings — 637 kB (baseline 637 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 17 unchanged User & Accounts — 37.9 kB (baseline 37.9 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 6 added / 6 removed / 5 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 1 unchanged UI Components — 124 kB (baseline 124 kB) • ⚪ 0 BReusable component library chunks
Status: 7 added / 7 removed / 9 unchanged Data & Services — 3.86 MB (baseline 3.86 MB) • 🔴 +159 BStores, services, APIs, and repositories
Status: 13 added / 13 removed / 3 unchanged Utilities & Hooks — 566 kB (baseline 566 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 19 added / 19 removed / 19 unchanged Vendor & Third-Party — 17.4 MB (baseline 17.4 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 17.7 MB (baseline 17.7 MB) • ⚪ 0 BBundles that do not match a named category
Status: 73 added / 73 removed / 225 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-20T01:49:12.948Z",
"gitSha": "2dfc6b0cd97e99f23bb7356c5ab9b151a952d12d",
"branch": "fix/dynamic-combo-migration-options-v2",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 1992.7789999999845,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.37,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 350.091,
"heapDeltaBytes": -3088188,
"heapUsedBytes": 58999220,
"domNodes": -263,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 8.62,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2008.2210000000487,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.090999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 431.575,
"heapDeltaBytes": 16009228,
"heapUsedBytes": 77264240,
"domNodes": -264,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 12.199000000000002,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2013.9350000000036,
"styleRecalcs": 78,
"styleRecalcDurationMs": 34.642,
"layouts": 14,
"layoutDurationMs": 4.749,
"taskDurationMs": 967.265,
"heapDeltaBytes": 12388852,
"heapUsedBytes": 72980596,
"domNodes": -265,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 185.54999999999998,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1875.1790000000028,
"styleRecalcs": 78,
"styleRecalcDurationMs": 33.515,
"layouts": 14,
"layoutDurationMs": 4.61,
"taskDurationMs": 817.302,
"heapDeltaBytes": 15983320,
"heapUsedBytes": 77620956,
"domNodes": -261,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 173.64000000000001,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1663.0569999999807,
"styleRecalcs": 31,
"styleRecalcDurationMs": 16.432,
"layouts": 6,
"layoutDurationMs": 1.1010000000000002,
"taskDurationMs": 297.359,
"heapDeltaBytes": 2149440,
"heapUsedBytes": 64224752,
"domNodes": 76,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 15.019000000000002,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1724.4640000000118,
"styleRecalcs": 30,
"styleRecalcDurationMs": 16.069,
"layouts": 6,
"layoutDurationMs": 1.0600000000000003,
"taskDurationMs": 336.25899999999996,
"heapDeltaBytes": 2206512,
"heapUsedBytes": 64286272,
"domNodes": 74,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 11.386000000000001,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 661.9689999999991,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.168,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 447.6880000000001,
"heapDeltaBytes": 18314396,
"heapUsedBytes": 80118208,
"domNodes": 18,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 161.114,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 680.7669999999462,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.35,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 461.76,
"heapDeltaBytes": 18278516,
"heapUsedBytes": 79949860,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 163.291,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2029.153000000008,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.303000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 654.862,
"heapDeltaBytes": 3511072,
"heapUsedBytes": 83215172,
"domNodes": -251,
"jsHeapTotalBytes": -270336,
"scriptDurationMs": 35.56100000000001,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2066.556999999989,
"styleRecalcs": 6,
"styleRecalcDurationMs": 9.929999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 696.342,
"heapDeltaBytes": 1148116,
"heapUsedBytes": 81217620,
"domNodes": -254,
"jsHeapTotalBytes": -8192,
"scriptDurationMs": 41.583,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2238.894000000016,
"styleRecalcs": 66,
"styleRecalcDurationMs": 10.545999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1538.481,
"heapDeltaBytes": 14847804,
"heapUsedBytes": 79094940,
"domNodes": -251,
"jsHeapTotalBytes": 1536000,
"scriptDurationMs": 865.934,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2253.840999999966,
"styleRecalcs": 64,
"styleRecalcDurationMs": 9.586,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1650.008,
"heapDeltaBytes": 14070124,
"heapUsedBytes": 78576584,
"domNodes": 4,
"jsHeapTotalBytes": 487424,
"scriptDurationMs": 837.515,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3642.0760000000314,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.168999999999997,
"layouts": 60,
"layoutDurationMs": 13.168,
"taskDurationMs": 1767.849,
"heapDeltaBytes": 11895132,
"heapUsedBytes": 77850744,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 810.636,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3574.4489999999587,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.192999999999998,
"layouts": 60,
"layoutDurationMs": 12.876999999999999,
"taskDurationMs": 1716.445,
"heapDeltaBytes": 8523164,
"heapUsedBytes": 74310552,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 798.697,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3096.441000000027,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.926000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1936.4409999999998,
"heapDeltaBytes": 21985116,
"heapUsedBytes": 89961472,
"domNodes": 0,
"jsHeapTotalBytes": 942080,
"scriptDurationMs": 983.02,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3173.8490000000183,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.005000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2003.926,
"heapDeltaBytes": 25279192,
"heapUsedBytes": 91034104,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 1025.063,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2048.8050000000158,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.9860000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 630.335,
"heapDeltaBytes": -3822232,
"heapUsedBytes": 83447760,
"domNodes": -249,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 37.953999999999986,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 1999.9820000000454,
"styleRecalcs": 2,
"styleRecalcDurationMs": 1.5870000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 501.194,
"heapDeltaBytes": 20085808,
"heapUsedBytes": 84327132,
"domNodes": -258,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 30.898999999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 614.0509999999608,
"styleRecalcs": 46,
"styleRecalcDurationMs": 11.351,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 420.49699999999996,
"heapDeltaBytes": 13507928,
"heapUsedBytes": 76854276,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 148.153,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 560.6310000000576,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.391000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 359.73600000000005,
"heapDeltaBytes": 14212448,
"heapUsedBytes": 76845812,
"domNodes": 18,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 142.28199999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2001.037999999994,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.253000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 464.0789999999999,
"heapDeltaBytes": 16549556,
"heapUsedBytes": 79932724,
"domNodes": -278,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 8.946,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 1998.954000000026,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.570999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 507.498,
"heapDeltaBytes": 7823980,
"heapUsedBytes": 71315056,
"domNodes": -279,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 11.049999999999997,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1723.608000000013,
"styleRecalcs": 78,
"styleRecalcDurationMs": 27.251,
"layouts": 18,
"layoutDurationMs": 4.993,
"taskDurationMs": 815.5839999999998,
"heapDeltaBytes": -6821772,
"heapUsedBytes": 56300484,
"domNodes": -276,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 113.235,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1708.7099999999964,
"styleRecalcs": 77,
"styleRecalcDurationMs": 28.809,
"layouts": 18,
"layoutDurationMs": 5.627,
"taskDurationMs": 825.7880000000001,
"heapDeltaBytes": 202404,
"heapUsedBytes": 63534440,
"domNodes": -277,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 114.802,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1419.0399999999954,
"styleRecalcs": 16,
"styleRecalcDurationMs": 30.485,
"layouts": 5,
"layoutDurationMs": 13.614999999999998,
"taskDurationMs": 981.878,
"heapDeltaBytes": -6456516,
"heapUsedBytes": 80452732,
"domNodes": 13587,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 33.037,
"eventListeners": 2383,
"totalBlockingTimeMs": 151,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8579.537999999957,
"styleRecalcs": 246,
"styleRecalcDurationMs": 35.441,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6071.719,
"heapDeltaBytes": -4470576,
"heapUsedBytes": 75336656,
"domNodes": -251,
"jsHeapTotalBytes": -77824,
"scriptDurationMs": 2819.511,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8375.053999999978,
"styleRecalcs": 247,
"styleRecalcDurationMs": 39.431,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5775.4839999999995,
"heapDeltaBytes": -3822960,
"heapUsedBytes": 75632292,
"domNodes": -249,
"jsHeapTotalBytes": 1003520,
"scriptDurationMs": 2731.7599999999998,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17382.226000000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16909.48,
"heapDeltaBytes": -17179200,
"heapUsedBytes": 190171756,
"domNodes": -8061,
"jsHeapTotalBytes": -12591104,
"scriptDurationMs": 303.719,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17100.02099999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16684.721000000005,
"heapDeltaBytes": -23836620,
"heapUsedBytes": 189868740,
"domNodes": -8061,
"jsHeapTotalBytes": -12066816,
"scriptDurationMs": 266.89099999999996,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20957.96300000006,
"styleRecalcs": 161,
"styleRecalcDurationMs": 18.626000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20666.845,
"heapDeltaBytes": -62965288,
"heapUsedBytes": 167725756,
"domNodes": -8061,
"jsHeapTotalBytes": -14213120,
"scriptDurationMs": 904.2270000000001,
"eventListeners": -14928,
"totalBlockingTimeMs": 187,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 20746.969000000034,
"styleRecalcs": 154,
"styleRecalcDurationMs": 19.643999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20510.649,
"heapDeltaBytes": -67627800,
"heapUsedBytes": 166936408,
"domNodes": -8061,
"jsHeapTotalBytes": -13639680,
"scriptDurationMs": 919.847,
"eventListeners": -14928,
"totalBlockingTimeMs": 78,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 6189.108000000033,
"styleRecalcs": 20,
"styleRecalcDurationMs": 81.67099999999999,
"layouts": 20,
"layoutDurationMs": 23.914999999999992,
"taskDurationMs": 6109.783,
"heapDeltaBytes": -27927644,
"heapUsedBytes": 195497612,
"domNodes": -8061,
"jsHeapTotalBytes": 12972032,
"scriptDurationMs": 109.547,
"eventListeners": -14928,
"totalBlockingTimeMs": 506,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 6121.203000000037,
"styleRecalcs": 20,
"styleRecalcDurationMs": 77.892,
"layouts": 20,
"layoutDurationMs": 24.101999999999997,
"taskDurationMs": 6048.361,
"heapDeltaBytes": -30287220,
"heapUsedBytes": 183272156,
"domNodes": -8061,
"jsHeapTotalBytes": 17293312,
"scriptDurationMs": 109.31400000000001,
"eventListeners": -14928,
"totalBlockingTimeMs": 411,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8479.446000000053,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8287.429999999998,
"heapDeltaBytes": -2670536,
"heapUsedBytes": 171230656,
"domNodes": 0,
"jsHeapTotalBytes": -5767168,
"scriptDurationMs": 131.86999999999992,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8377.635000000055,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8221.911,
"heapDeltaBytes": 5783848,
"heapUsedBytes": 187852856,
"domNodes": 0,
"jsHeapTotalBytes": -19398656,
"scriptDurationMs": 126.95899999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 127.94099999996433,
"styleRecalcs": 8,
"styleRecalcDurationMs": 19.019000000000002,
"layouts": 3,
"layoutDurationMs": 1.738,
"taskDurationMs": 98.17599999999999,
"heapDeltaBytes": 3245708,
"heapUsedBytes": 64729056,
"domNodes": 131,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.992,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 105.32000000000608,
"styleRecalcs": 6,
"styleRecalcDurationMs": 12.568,
"layouts": 2,
"layoutDurationMs": 0.6169999999999999,
"taskDurationMs": 73.72200000000001,
"heapDeltaBytes": 3039388,
"heapUsedBytes": 64826760,
"domNodes": 106,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.092,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
|
I don't have a means to re-run a single job while the overall run is still in progress (GitHub returns a 403 for that), but I'll re-run it once the run finishes and report back. |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #18037 +/- ##
==========================================
+ Coverage 82.78% 83.79% +1.01%
==========================================
Files 2946 2250 -696
Lines 145057 128034 -17023
Branches 39230 32613 -6617
==========================================
- Hits 120081 107291 -12790
+ Misses 23710 20453 -3257
+ Partials 1266 290 -976
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 707 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
Re-ran |
3989d22 to
b3857ed
Compare
Playwright videos for new testsDownload the recorded videos and HTML report Recorded projects: chromium Recorded test titles:
|
transformInputSpecV1ToV2 drops the options key when a COMFY_DYNAMICCOMBO_V3 V1 tuple has no options object at all (e.g. ['COMFY_DYNAMICCOMBO_V3', undefined]), which is exactly what subgraphStore.ts's registerNodeDef produces for promoted dynamic-combo boundary inputs. Downstream, flattenInputSpecs asserts on the missing options array (Sentry CLOUD-FRONTEND-STAGING-4KQ).
transformInputSpecV1ToV2 now special-cases COMFY_DYNAMICCOMBO_V3 the same way it already special-cases CHART: when the V1 tuple supplies no options object at all, it defaults options to [] so the resulting V2 spec always satisfies flattenInputSpecs's expectation of an options array. A dynamic combo whose options object is present but missing its options key still throws as before.
b3857ed to
2a7b377
Compare
christian-byrne
left a comment
There was a problem hiding this comment.
The normalization is limited to dynamic-combo inputs with absent metadata; explicit malformed metadata and nested options retain their existing paths. The 64 affected unit tests, typechecked build and browser blueprint-preview regression pass at this head. Merge remains subject to current-base hosted checks.
<!-- ccr-slack-attribution --> _Requested via [Slack thread](https://comfy-organization.slack.com/archives/C09KFK2ABB8/p1789399739062479?thread_ts=1789399739.062479&cid=C09KFK2ABB8)_ ## Before / After **Before:** A subgraph-blueprint synthetic nodedef (built in `subgraphStore.ts`) that promotes a `COMFY_DYNAMICCOMBO_V3` boundary input produces a V1 tuple of `['COMFY_DYNAMICCOMBO_V3', undefined]`. `transformInputSpecV1ToV2` turned this into a V2 spec with no `options` key at all, so `flattenInputSpecs` hit its "expected an options array on dynamic combo" assertion and reported it to Sentry. Visibly, this dropped the nested option rows from the node's preview/help tab for these subgraph blueprints — cosmetic, not a crash. **After:** the same input now gets `options: []`, so the assertion is never tripped and the preview/help tab renders normally (with no nested options, matching reality, instead of silently failing). ## Why Fixes Sentry issue **CLOUD-FRONTEND-STAGING-4KQ** (`[Assertion failed]: flattenInputSpecs: expected an options array on dynamic combo`). `transformInputSpecV1ToV2` (`src/schemas/nodeDef/migration.ts`) now special-cases `COMFY_DYNAMICCOMBO_V3` the same way it already special-cases `CHART`: when the V1 tuple supplies no options object at all (`inputSpecV1[1] === undefined`), it defaults `options` to `[]` so the resulting V2 spec always satisfies `flattenInputSpecs`'s expectation of an options array. This only covers the "no options object at all" case produced by `subgraphStore.ts`'s `registerNodeDef`; a dynamic combo whose options object is present but missing its `options` key still throws as before (see the existing "skips a dynamic combo whose options field is not an array" test), so a genuinely malformed nodedef is still surfaced. ## Red-Green Verification | Commit | Purpose | |--------|---------| | `test: add failing test for dynamic combo migration missing options` | Proves the test reproduces the bug (fails against pre-fix `migration.ts`) | | `fix: default dynamic combo migration options to an empty array` | Makes the test pass, with the rest of `migration.test.ts` and `inputSpecUtil.test.ts` unaffected | ## Test Plan - [x] Unit test added in `src/schemas/nodeDef/migration.test.ts`, confirmed failing locally against pre-fix code - [x] Fix applied, same test passes locally - [x] Full `migration.test.ts` (23 → 24 tests) and `inputSpecUtil.test.ts` (5 tests) suites pass, including the existing "skips a dynamic combo whose options field is not an array" regression test - [x] `pnpm typecheck` clean --- _Generated by [Claude Code](https://claude.ai/code/session_01DqXqWkUXB8eNLEET45fpmo)_ --------- Co-authored-by: bymyself <cbyrne@comfy.org>
<!-- ccr-slack-attribution --> _Requested via [Slack thread](https://comfy-organization.slack.com/archives/C09KFK2ABB8/p1789399739062479?thread_ts=1789399739.062479&cid=C09KFK2ABB8)_ ## Before / After **Before:** A subgraph-blueprint synthetic nodedef (built in `subgraphStore.ts`) that promotes a `COMFY_DYNAMICCOMBO_V3` boundary input produces a V1 tuple of `['COMFY_DYNAMICCOMBO_V3', undefined]`. `transformInputSpecV1ToV2` turned this into a V2 spec with no `options` key at all, so `flattenInputSpecs` hit its "expected an options array on dynamic combo" assertion and reported it to Sentry. Visibly, this dropped the nested option rows from the node's preview/help tab for these subgraph blueprints — cosmetic, not a crash. **After:** the same input now gets `options: []`, so the assertion is never tripped and the preview/help tab renders normally (with no nested options, matching reality, instead of silently failing). ## Why Fixes Sentry issue **CLOUD-FRONTEND-STAGING-4KQ** (`[Assertion failed]: flattenInputSpecs: expected an options array on dynamic combo`). `transformInputSpecV1ToV2` (`src/schemas/nodeDef/migration.ts`) now special-cases `COMFY_DYNAMICCOMBO_V3` the same way it already special-cases `CHART`: when the V1 tuple supplies no options object at all (`inputSpecV1[1] === undefined`), it defaults `options` to `[]` so the resulting V2 spec always satisfies `flattenInputSpecs`'s expectation of an options array. This only covers the "no options object at all" case produced by `subgraphStore.ts`'s `registerNodeDef`; a dynamic combo whose options object is present but missing its `options` key still throws as before (see the existing "skips a dynamic combo whose options field is not an array" test), so a genuinely malformed nodedef is still surfaced. ## Red-Green Verification | Commit | Purpose | |--------|---------| | `test: add failing test for dynamic combo migration missing options` | Proves the test reproduces the bug (fails against pre-fix `migration.ts`) | | `fix: default dynamic combo migration options to an empty array` | Makes the test pass, with the rest of `migration.test.ts` and `inputSpecUtil.test.ts` unaffected | ## Test Plan - [x] Unit test added in `src/schemas/nodeDef/migration.test.ts`, confirmed failing locally against pre-fix code - [x] Fix applied, same test passes locally - [x] Full `migration.test.ts` (23 → 24 tests) and `inputSpecUtil.test.ts` (5 tests) suites pass, including the existing "skips a dynamic combo whose options field is not an array" regression test - [x] `pnpm typecheck` clean --- _Generated by [Claude Code](https://claude.ai/code/session_01DqXqWkUXB8eNLEET45fpmo)_ --------- Co-authored-by: bymyself <cbyrne@comfy.org>
…an empty array (#18172) Backport of #18037 to `core/1.54` Automatically created by backport workflow. Justification: Agent 1.54 release backport authorized by Christian's September 16/20 grant; exact head 4b9e6de was independently adaptation-reviewed against core/1.54@40c021cfddfcc5bb1fed7bc784b1e28bb5d49699, required target-native acceptance and terminal hosted checks passed, the current target-aware merge guard passed, and no unresolved human objection remains. REVIEW_REQUIRED is the only branch-protection condition bypassed. Residuals retained: the initial cold fixture timeout is preserved; unchanged blueprint assertions pass with a 120-second test budget; preview acceptance does not certify live-model execution. Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> Co-authored-by: bymyself <cbyrne@comfy.org>
… an empty array (#18173) Backport of #18037 to cloud/1.54. Default absent COMFY_DYNAMICCOMBO_V3 options to an empty array while retaining malformed-option validation. Preserve the source regression coverage and blueprint preview browser acceptance. Independently reviewed head: 39dda8e Target: c0ce3d3 Source patch ID: 9796611f20d8b72f32bfc909993c5bd9f51af28e Historical generated co-author trailers remain an explicitly accepted residual; this merge does not repair release history. The activeDownloads expected failure and broader acceptance remain open. Co-authored-by: bymyself <cbyrne@comfy.org>
Requested via Slack thread
Before / After
Before: A subgraph-blueprint synthetic nodedef (built in
subgraphStore.ts) that promotes aCOMFY_DYNAMICCOMBO_V3boundary input produces a V1 tuple of['COMFY_DYNAMICCOMBO_V3', undefined].transformInputSpecV1ToV2turned this into a V2 spec with nooptionskey at all, soflattenInputSpecshit its "expected an options array on dynamic combo" assertion and reported it to Sentry. Visibly, this dropped the nested option rows from the node's preview/help tab for these subgraph blueprints — cosmetic, not a crash.After: the same input now gets
options: [], so the assertion is never tripped and the preview/help tab renders normally (with no nested options, matching reality, instead of silently failing).Why
Fixes Sentry issue CLOUD-FRONTEND-STAGING-4KQ (
[Assertion failed]: flattenInputSpecs: expected an options array on dynamic combo).transformInputSpecV1ToV2(src/schemas/nodeDef/migration.ts) now special-casesCOMFY_DYNAMICCOMBO_V3the same way it already special-casesCHART: when the V1 tuple supplies no options object at all (inputSpecV1[1] === undefined), it defaultsoptionsto[]so the resulting V2 spec always satisfiesflattenInputSpecs's expectation of an options array. This only covers the "no options object at all" case produced bysubgraphStore.ts'sregisterNodeDef; a dynamic combo whose options object is present but missing itsoptionskey still throws as before (see the existing "skips a dynamic combo whose options field is not an array" test), so a genuinely malformed nodedef is still surfaced.Red-Green Verification
test: add failing test for dynamic combo migration missing optionsmigration.ts)fix: default dynamic combo migration options to an empty arraymigration.test.tsandinputSpecUtil.test.tsunaffectedTest Plan
src/schemas/nodeDef/migration.test.ts, confirmed failing locally against pre-fix codemigration.test.ts(23 → 24 tests) andinputSpecUtil.test.ts(5 tests) suites pass, including the existing "skips a dynamic combo whose options field is not an array" regression testpnpm typecheckcleanGenerated by Claude Code