Repository navigation
[backport core/1.54] fix: default dynamic combo migration options to an empty array - #18172
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
🎭 Playwright: ✅ 1932 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-21T02:29:43.864Z",
"gitSha": "c309626f10aba7e6ead0fe46c768ae276924ac4e",
"branch": "backport-18037-to-core-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2053.604000000007,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.719000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 563.6179999999999,
"heapDeltaBytes": -7777588,
"heapUsedBytes": 62279012,
"domNodes": -277,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 7.493999999999997,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2010.8479999998963,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.1160000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 490.82900000000006,
"heapDeltaBytes": -6033672,
"heapUsedBytes": 57908536,
"domNodes": -282,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 7.586000000000002,
"eventListeners": -166,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1801.5620000000467,
"styleRecalcs": 74,
"styleRecalcDurationMs": 28.363999999999997,
"layouts": 14,
"layoutDurationMs": 3.7459999999999996,
"taskDurationMs": 854.638,
"heapDeltaBytes": -4462992,
"heapUsedBytes": 65392572,
"domNodes": -278,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 161.99999999999997,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1841.5860000000066,
"styleRecalcs": 76,
"styleRecalcDurationMs": 29.821000000000005,
"layouts": 14,
"layoutDurationMs": 4.412,
"taskDurationMs": 879.4510000000001,
"heapDeltaBytes": -2562436,
"heapUsedBytes": 68201812,
"domNodes": -280,
"jsHeapTotalBytes": 6807552,
"scriptDurationMs": 170.388,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1717.7560000000085,
"styleRecalcs": 30,
"styleRecalcDurationMs": 14.394,
"layouts": 6,
"layoutDurationMs": 0.9970000000000001,
"taskDurationMs": 346.557,
"heapDeltaBytes": 4381264,
"heapUsedBytes": 74729228,
"domNodes": 75,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 10.161,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1754.8020000000406,
"styleRecalcs": 32,
"styleRecalcDurationMs": 15.993,
"layouts": 6,
"layoutDurationMs": 1.177,
"taskDurationMs": 353.607,
"heapDeltaBytes": 4342016,
"heapUsedBytes": 74212128,
"domNodes": 77,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 10.158000000000001,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 647.2850000000108,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.444,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 449.218,
"heapDeltaBytes": 18753104,
"heapUsedBytes": 88502196,
"domNodes": 20,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 166.097,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 625.5990000000793,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.531999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 442.443,
"heapDeltaBytes": 18761072,
"heapUsedBytes": 88540652,
"domNodes": 18,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 160.14899999999997,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2070.9170000000086,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.094,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 605.6539999999999,
"heapDeltaBytes": -14853220,
"heapUsedBytes": 87723408,
"domNodes": -268,
"jsHeapTotalBytes": -856064,
"scriptDurationMs": 36.465,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2073.1539999999313,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.930999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 617.384,
"heapDeltaBytes": 9149144,
"heapUsedBytes": 85373064,
"domNodes": -272,
"jsHeapTotalBytes": -892928,
"scriptDurationMs": 31.49800000000001,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2345.696999999973,
"styleRecalcs": 67,
"styleRecalcDurationMs": 12.328000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1697.9160000000002,
"heapDeltaBytes": 3749724,
"heapUsedBytes": 80752808,
"domNodes": -248,
"jsHeapTotalBytes": 643072,
"scriptDurationMs": 862.0870000000001,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2180.195000000026,
"styleRecalcs": 66,
"styleRecalcDurationMs": 10.565999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1613.3930000000003,
"heapDeltaBytes": 12151392,
"heapUsedBytes": 89336052,
"domNodes": -274,
"jsHeapTotalBytes": -405504,
"scriptDurationMs": 811.928,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3447.5889999999936,
"styleRecalcs": 61,
"styleRecalcDurationMs": 9.819,
"layouts": 60,
"layoutDurationMs": 11.333,
"taskDurationMs": 1647.9669999999999,
"heapDeltaBytes": 8821764,
"heapUsedBytes": 76255892,
"domNodes": 2,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 768.057,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "large-graph-zoom",
"durationMs": 3596.5609999999515,
"styleRecalcs": 63,
"styleRecalcDurationMs": 12.740000000000006,
"layouts": 60,
"layoutDurationMs": 11.53,
"taskDurationMs": 1778.2459999999999,
"heapDeltaBytes": -2662760,
"heapUsedBytes": 76338496,
"domNodes": -284,
"jsHeapTotalBytes": -1941504,
"scriptDurationMs": 814.561,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3041.966000000002,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.579,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1892.2489999999998,
"heapDeltaBytes": 17931400,
"heapUsedBytes": 85225332,
"domNodes": -278,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 960.924,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3127.884999999992,
"styleRecalcs": 43,
"styleRecalcDurationMs": 7.9049999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1983.65,
"heapDeltaBytes": 4837164,
"heapUsedBytes": 85225060,
"domNodes": -280,
"jsHeapTotalBytes": 49152,
"scriptDurationMs": 968.445,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2032.2689999999852,
"styleRecalcs": 2,
"styleRecalcDurationMs": 1.9400000000000008,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 573.8559999999999,
"heapDeltaBytes": 9270120,
"heapUsedBytes": 86636236,
"domNodes": -279,
"jsHeapTotalBytes": -2203648,
"scriptDurationMs": 33.595,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2004.9789999999348,
"styleRecalcs": 3,
"styleRecalcDurationMs": 4.6080000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 539.942,
"heapDeltaBytes": 21798300,
"heapUsedBytes": 88094768,
"domNodes": 6,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 33.27500000000001,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 575.3540000000044,
"styleRecalcs": 48,
"styleRecalcDurationMs": 11.482,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 398.83099999999996,
"heapDeltaBytes": 15039464,
"heapUsedBytes": 87821316,
"domNodes": 22,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 138.124,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 569.5460000000594,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.264999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 402.42900000000003,
"heapDeltaBytes": 14731984,
"heapUsedBytes": 87815188,
"domNodes": 18,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 143.207,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2035.8530000000314,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.43,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 488.60699999999997,
"heapDeltaBytes": -8223048,
"heapUsedBytes": 63715580,
"domNodes": -294,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 7.314999999999999,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 1990.071999999941,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.026,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 478.879,
"heapDeltaBytes": -3533648,
"heapUsedBytes": 62337728,
"domNodes": -293,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 7.743,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1719.1010000000233,
"styleRecalcs": 77,
"styleRecalcDurationMs": 25.220000000000002,
"layouts": 18,
"layoutDurationMs": 4.368,
"taskDurationMs": 780.5649999999999,
"heapDeltaBytes": 1144288,
"heapUsedBytes": 74071964,
"domNodes": -296,
"jsHeapTotalBytes": 7069696,
"scriptDurationMs": 105.125,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1755.7879999999386,
"styleRecalcs": 78,
"styleRecalcDurationMs": 28.043,
"layouts": 18,
"layoutDurationMs": 4.604,
"taskDurationMs": 802.624,
"heapDeltaBytes": -6520676,
"heapUsedBytes": 65473540,
"domNodes": -294,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 107.708,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1383.7889999999788,
"styleRecalcs": 18,
"styleRecalcDurationMs": 31.831,
"layouts": 14,
"layoutDurationMs": 15.152000000000003,
"taskDurationMs": 917.4669999999998,
"heapDeltaBytes": 21956060,
"heapUsedBytes": 105830088,
"domNodes": 13751,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 31.21,
"eventListeners": 2385,
"totalBlockingTimeMs": 146,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8470.567000000017,
"styleRecalcs": 248,
"styleRecalcDurationMs": 35.262,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5799.755,
"heapDeltaBytes": 9528872,
"heapUsedBytes": 85071004,
"domNodes": -269,
"jsHeapTotalBytes": -405504,
"scriptDurationMs": 2733.5789999999997,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8371.298999999908,
"styleRecalcs": 247,
"styleRecalcDurationMs": 34.282000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5743.909,
"heapDeltaBytes": 9196512,
"heapUsedBytes": 85089336,
"domNodes": -271,
"jsHeapTotalBytes": 380928,
"scriptDurationMs": 2690.674,
"eventListeners": -178,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16766.053,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16212.958,
"heapDeltaBytes": -54980904,
"heapUsedBytes": 178428848,
"domNodes": -8068,
"jsHeapTotalBytes": -16211968,
"scriptDurationMs": 262.44300000000004,
"eventListeners": -14931,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 16701.135000000024,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16007.538,
"heapDeltaBytes": -40386412,
"heapUsedBytes": 178083204,
"domNodes": -8068,
"jsHeapTotalBytes": -10280960,
"scriptDurationMs": 271.36400000000003,
"eventListeners": -14931,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20894.05599999998,
"styleRecalcs": 172,
"styleRecalcDurationMs": 17.747000000000014,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20531.829999999998,
"heapDeltaBytes": -61447340,
"heapUsedBytes": 169604048,
"domNodes": -8068,
"jsHeapTotalBytes": -18001920,
"scriptDurationMs": 908.267,
"eventListeners": -14929,
"totalBlockingTimeMs": 159,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20648.296999999955,
"styleRecalcs": 168,
"styleRecalcDurationMs": 17.781999999999965,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20326.67,
"heapDeltaBytes": -50660216,
"heapUsedBytes": 168701264,
"domNodes": -8068,
"jsHeapTotalBytes": -11575296,
"scriptDurationMs": 932.0840000000001,
"eventListeners": -14927,
"totalBlockingTimeMs": 126,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6218.469000000027,
"styleRecalcs": 20,
"styleRecalcDurationMs": 79.50199999999997,
"layouts": 20,
"layoutDurationMs": 22.528999999999993,
"taskDurationMs": 6080.536,
"heapDeltaBytes": -40566464,
"heapUsedBytes": 190483620,
"domNodes": -8068,
"jsHeapTotalBytes": 8839168,
"scriptDurationMs": 115.899,
"eventListeners": -14927,
"totalBlockingTimeMs": 407,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 6159.177999999997,
"styleRecalcs": 20,
"styleRecalcDurationMs": 79.28800000000003,
"layouts": 20,
"layoutDurationMs": 22.472999999999992,
"taskDurationMs": 6033.478000000001,
"heapDeltaBytes": -41806692,
"heapUsedBytes": 176159200,
"domNodes": -8068,
"jsHeapTotalBytes": 9687040,
"scriptDurationMs": 130.24099999999999,
"eventListeners": -14929,
"totalBlockingTimeMs": 391,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8527.47899999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8288.824999999999,
"heapDeltaBytes": 10913992,
"heapUsedBytes": 182160424,
"domNodes": 0,
"jsHeapTotalBytes": -7077888,
"scriptDurationMs": 139.07900000000006,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8414.432999999917,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8111.129,
"heapDeltaBytes": 22657448,
"heapUsedBytes": 182046896,
"domNodes": 0,
"jsHeapTotalBytes": -7077888,
"scriptDurationMs": 130.68599999999998,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 452.90699999998196,
"styleRecalcs": 15,
"styleRecalcDurationMs": 21.913,
"layouts": 3,
"layoutDurationMs": 1.308,
"taskDurationMs": 104.808,
"heapDeltaBytes": 4817952,
"heapUsedBytes": 73692008,
"domNodes": 124,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 8.344999999999999,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 112.52999999999247,
"styleRecalcs": 7,
"styleRecalcDurationMs": 14.167000000000002,
"layouts": 2,
"layoutDurationMs": 1.161,
"taskDurationMs": 69.59499999999998,
"heapDeltaBytes": 2992620,
"heapUsedBytes": 71648832,
"domNodes": 126,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 4.970000000000001,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.54 #18172 +/- ##
============================================
Coverage 83.54% 83.54%
============================================
Files 2094 2094
Lines 123483 123487 +4
Branches 31433 33282 +1849
============================================
+ Hits 103161 103167 +6
+ Misses 20143 20141 -2
Partials 179 179
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 6 files with indirect coverage changes 🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Independent target-adaptation review: COMMENT / HOLD for head 1e7510c against core/1.54 tip e79d6ae. Source #18037 intent and full four-file patch are preserved (identical stable patch ID); undefined options receive an empty array while malformed supplied options still reach the existing assertion. Current-target merge-tree simulation is clean. No target-specific code defect, review thread, or human objection found. Hosted product checks are green, but the AI co-author trailer check fails on this exact head. Remove only the forbidden Claude co-author trailer, preserving the human trailer; requalify the new exact head and current-target acceptance before merge. Current target is not an ancestor of this old carrier head. Cloud advisory cancellations are not a product regression. This is not a ready-for-merge receipt; REVIEW_REQUIRED is not itself a defect. Bounded review of this launch head is released for the finalizer to repair/refresh; any new head or target requires a new receipt.
<!-- ccr-slack-attribution --> _Requested via [Slack thread](https://comfy-organization.slack.com/archives/C09KFK2ABB8/p1789399739062479?thread_ts=1789399739.062479&cid=C09KFK2ABB8)_ ## Before / After **Before:** A subgraph-blueprint synthetic nodedef (built in `subgraphStore.ts`) that promotes a `COMFY_DYNAMICCOMBO_V3` boundary input produces a V1 tuple of `['COMFY_DYNAMICCOMBO_V3', undefined]`. `transformInputSpecV1ToV2` turned this into a V2 spec with no `options` key at all, so `flattenInputSpecs` hit its "expected an options array on dynamic combo" assertion and reported it to Sentry. Visibly, this dropped the nested option rows from the node's preview/help tab for these subgraph blueprints — cosmetic, not a crash. **After:** the same input now gets `options: []`, so the assertion is never tripped and the preview/help tab renders normally (with no nested options, matching reality, instead of silently failing). ## Why Fixes Sentry issue **CLOUD-FRONTEND-STAGING-4KQ** (`[Assertion failed]: flattenInputSpecs: expected an options array on dynamic combo`). `transformInputSpecV1ToV2` (`src/schemas/nodeDef/migration.ts`) now special-cases `COMFY_DYNAMICCOMBO_V3` the same way it already special-cases `CHART`: when the V1 tuple supplies no options object at all (`inputSpecV1[1] === undefined`), it defaults `options` to `[]` so the resulting V2 spec always satisfies `flattenInputSpecs`'s expectation of an options array. This only covers the "no options object at all" case produced by `subgraphStore.ts`'s `registerNodeDef`; a dynamic combo whose options object is present but missing its `options` key still throws as before (see the existing "skips a dynamic combo whose options field is not an array" test), so a genuinely malformed nodedef is still surfaced. ## Red-Green Verification | Commit | Purpose | |--------|---------| | `test: add failing test for dynamic combo migration missing options` | Proves the test reproduces the bug (fails against pre-fix `migration.ts`) | | `fix: default dynamic combo migration options to an empty array` | Makes the test pass, with the rest of `migration.test.ts` and `inputSpecUtil.test.ts` unaffected | ## Test Plan - [x] Unit test added in `src/schemas/nodeDef/migration.test.ts`, confirmed failing locally against pre-fix code - [x] Fix applied, same test passes locally - [x] Full `migration.test.ts` (23 → 24 tests) and `inputSpecUtil.test.ts` (5 tests) suites pass, including the existing "skips a dynamic combo whose options field is not an array" regression test - [x] `pnpm typecheck` clean --- _Generated by [Claude Code](https://claude.ai/code/session_01DqXqWkUXB8eNLEET45fpmo)_ --------- Co-authored-by: bymyself <cbyrne@comfy.org>
1e7510c to
225022b
Compare
christian-byrne
left a comment
There was a problem hiding this comment.
Independent repaired-head adaptation review: COMMENT / HOLD at 225022b against core/1.54@e79d6ae0ad4e1a0923cf2d92bef4383a387e8dfb. The prior metadata and ancestry blockers are corrected. Independently verified: the amended ancestor's tree equals the original reviewed tree; bymyself's human trailer is preserved; the exact head tree equals Git's clean automatic merge of the amended ancestor and live target; target is an ancestor; the full target-relative product patch retains stable ID 9796611f20d8b72f32bfc909993c5bd9f51af28e. Executed trailer check: No AI agent Co-authored-by trailers found. Prior source-intent/full-adaptation review carries forward; no target-specific defect, review thread or human objection found. Finalizer reports 28 focused tests per target, source/browser typechecks, scoped lint/format/knip and blueprintDynamicCombo browser acceptance on both exact release trees using a disposable ComfyUI 0.30.0 CPU backend. Core's first browser attempt timed out during cold fixture setup before the test body; the retained failure was followed by unchanged assertions passing with a 120-second local setup budget. These execution results are finalizer-reported, not independently rerun; raw acceptance logs requested. The authoritative target-aware guard still returns NOT MERGE READY because hosted checks are incomplete. Adaptation is clear; bounded review lease RELEASED, not merge-ready. Inspect acceptance evidence, require terminal non-adverse hosted checks and run the current-target guard immediately before any authorized merge. Any head/target movement invalidates this receipt; unchanged code need not be reviewed again. REVIEW_REQUIRED is not itself a defect.
christian-byrne
left a comment
There was a problem hiding this comment.
Independent post-history target refresh review: COMMENT / HOLD at 4b9e6de against core/1.54@40c021cfddfcc5bb1fed7bc784b1e28bb5d49699. Full tree equals the independently computed clean automatic merge of the prior reviewed carrier and the newly merged history target; ancestry passes and the target-relative source #18037 patch remains 9796611f20d8b72f32bfc909993c5bd9f51af28e. Trailer script passes. No additional product change, target-adaptation defect, unresolved review thread or new human objection found. Finalizer reports 68 passing focused tests per target (dynamic 28 + history 40), source/browser types, scoped lint/format and knip; these new runs are reported, not independently rerun. Fresh exact-head browser acceptance is still running. The authoritative target-aware guard returns NOT MERGE READY because hosted checks are incomplete. Prior-target browser success is not substituted for this new integration. Adaptation-clear; bounded review lease RELEASED, NOT merge-ready. Complete fresh acceptance/terminal checks and execute current-target guard immediately before any authorized merge. Head or target movement invalidates this receipt; REVIEW_REQUIRED alone is not a defect.
christian-byrne
left a comment
There was a problem hiding this comment.
Release-finalizer COMMENT, not human approval. Christian's September 16/20 Agent backport grant authorizes this qualified merge. Exact head 4b9e6de against core/1.54@40c021cfddfcc5bb1fed7bc784b1e28bb5d49699 has independent adaptation review #5262616445: automatic merge-tree equality, ancestry, unchanged source #18037 patch and clean trailer check. Original forbidden AI coauthor trailer was removed message-only with tree equality; the bymyself trailer and provenance remain. Fresh exact-head evidence: 68 unit passes (28 migration/input-spec plus 40 history), source/browser types, scoped lint/format and knip; blueprintDynamicCombo browser pass (18.1s) verifies boundary_model, COMFY_DYNAMICCOMBO_V3 and no page errors. Reviewer inspected raw logs with exact head/target identities (bundle5b13f6486b71378b730a03b1fae465b6fab3f7e33fe3809b29c9220621e06d4a). Initial cold-fixture15s timeout retained; no assertions weakened; fresh test budget120s. Current guard passes89 terminal non-adverse check runs and commit statuses; discussions reread, no unresolved human objection/thread. Only REVIEW_REQUIRED will be bypassed; no peer approval is asserted. Preview-only acceptance does not certify live-model execution. Prevention Justification is in the PR body. Rerunning the current target-aware guard immediately before head-bound admin squash.
|
Post-merge verification found a metadata defect: the actual squash commit has exactly the reviewed/tested product tree, but GitHub generated a forbidden claude[bot] coauthor trailer from contributor authorship despite clean carrier trailers. The actual merged-commit trailer check fails. Christian authorized a message-only current-tip repair; a clean same-tree repair is prepared with the original author/date and bymyself trailer preserved. Its exact-lease push was rejected by repository rules (force-push/required-check/PR restrictions), so the remote is unchanged and no protections were modified. Core follow-on merges are held pending disposition. The older history squash commits in #18222/#18223 have the same metadata issue and remain untouched outside this narrow repair grant. Explicit clean squash bodies now prevent recurrence, verified on the actual #18208 merge. Product verification and metadata-policy status must not be conflated. |
Backport of #18037 to
core/1.54Automatically created by backport workflow.
Justification: Agent 1.54 release backport authorized by Christian's September 16/20 grant; exact head 4b9e6de was independently adaptation-reviewed against core/1.54@40c021cfddfcc5bb1fed7bc784b1e28bb5d49699, required target-native acceptance and terminal hosted checks passed, the current target-aware merge guard passed, and no unresolved human objection remains. REVIEW_REQUIRED is the only branch-protection condition bypassed. Residuals retained: the initial cold fixture timeout is preserved; unchanged blueprint assertions pass with a 120-second test budget; preview acceptance does not certify live-model execution.