Skip to content

fix: default dynamic combo migration options to an empty array - #18035

Closed
claude[bot] wants to merge 1 commit into
mainfrom
fix/dynamic-combo-migration-options
Closed

claude[bot] wants to merge 1 commit into
mainfrom
fix/dynamic-combo-migration-options

Conversation

@claude

@claude claude Bot commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

Requested via Slack thread

Before / After

Before: A subgraph-blueprint synthetic nodedef (built in subgraphStore.ts) that promotes a COMFY_DYNAMICCOMBO_V3 boundary input produces a V1 tuple of ['COMFY_DYNAMICCOMBO_V3', undefined]. transformInputSpecV1ToV2 turned this into a V2 spec with no options key at all, so flattenInputSpecs hit its "expected an options array on dynamic combo" assertion and reported it to Sentry. Visibly, this dropped the nested option rows from the node's preview/help tab for these subgraph blueprints — cosmetic, not a crash.

After: the same input now gets options: [], so the assertion is never tripped and the preview/help tab renders normally (with no nested options, matching reality, instead of silently failing).

Why

Fixes Sentry issue CLOUD-FRONTEND-STAGING-4KQ ([Assertion failed]: flattenInputSpecs: expected an options array on dynamic combo).

transformInputSpecV1ToV2 (src/schemas/nodeDef/migration.ts) now special-cases COMFY_DYNAMICCOMBO_V3 the same way it already special-cases CHART: when the V1 tuple supplies no options object at all (inputSpecV1[1] === undefined), it defaults options to [] so the resulting V2 spec always satisfies flattenInputSpecs's expectation of an options array. This only covers the "no options object at all" case produced by subgraphStore.ts's registerNodeDef; a dynamic combo whose options object is present but missing its options key still throws as before (see the existing "skips a dynamic combo whose options field is not an array" test), so a genuinely malformed nodedef is still surfaced.

Red-Green Verification

Commit Purpose
test: add failing test for dynamic combo migration missing options Proves the test reproduces the bug (fails against pre-fix migration.ts)
fix: default dynamic combo migration options to an empty array Makes the test pass, with the rest of migration.test.ts and inputSpecUtil.test.ts unaffected

Test Plan

  • Unit test added in src/schemas/nodeDef/migration.test.ts, confirmed failing locally against pre-fix code
  • Fix applied, same test passes locally
  • Full migration.test.ts (23 → 24 tests) and inputSpecUtil.test.ts (5 tests) suites pass, including the existing "skips a dynamic combo whose options field is not an array" regression test
  • pnpm typecheck clean

🤖 Generated with Claude Code

https://claude.ai/code/session_01DqXqWkUXB8eNLEET45fpmo


Generated by Claude Code

transformInputSpecV1ToV2 drops the options key when a
COMFY_DYNAMICCOMBO_V3 V1 tuple has no options object at all (e.g.
['COMFY_DYNAMICCOMBO_V3', undefined]), which is exactly what
subgraphStore.ts's registerNodeDef produces for promoted dynamic-combo
boundary inputs. Downstream, flattenInputSpecs asserts on the missing
options array (Sentry CLOUD-FRONTEND-STAGING-4KQ).

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DqXqWkUXB8eNLEET45fpmo
@claude
claude Bot requested a review from a team September 18, 2026 19:13
@coderabbitai

coderabbitai Bot commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: a7d198e7-784b-4a0c-9f07-8c7b31c847d9

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 18, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 2033 passed, 0 failed · 4 flaky

📊 Browser Reports
  • chromium: View Report (✅ 2012 / ❌ 0 / ⚠️ 4 / ⏭️ 13)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/18/2026, 07:15:25 PM UTC

Links

📦 Bundle: 9.92 MB gzip ⚪ 0 B

Details

Summary

  • Raw size: 42.1 MB baseline 42.1 MB — ⚪ 0 B
  • Gzip: 9.92 MB baseline 9.92 MB — ⚪ 0 B
  • Brotli: 6.98 MB baseline 6.98 MB — ⚪ 0 B
  • Bundles: 453 current • 453 baseline

Category Glance
Other ⚪ 0 B (17.7 MB) · Vendor & Third-Party ⚪ 0 B (17.4 MB) · Data & Services ⚪ 0 B (3.85 MB) · Graph Workspace ⚪ 0 B (1.45 MB) · Panels & Settings ⚪ 0 B (637 kB) · Utilities & Hooks ⚪ 0 B (565 kB) · + 5 more

App Entry Points — 3.77 kB (baseline 3.77 kB) • ⚪ 0 B

Main entry bundles and manifests

Status: 1 unchanged

Graph Workspace — 1.45 MB (baseline 1.45 MB) • ⚪ 0 B

Graph editor runtime, canvas, workflow orchestration

Status: 3 unchanged

Views & Navigation — 132 kB (baseline 132 kB) • ⚪ 0 B

Top-level views, pages, and routed surfaces

Status: 18 unchanged

Panels & Settings — 637 kB (baseline 637 kB) • ⚪ 0 B

Configuration panels, inspectors, and settings screens

Status: 27 unchanged

User & Accounts — 37.9 kB (baseline 37.9 kB) • ⚪ 0 B

Authentication, profile, and account management bundles

Status: 11 unchanged

Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 B

Modals, dialogs, drawers, and in-app editors

Status: 8 unchanged

UI Components — 124 kB (baseline 124 kB) • ⚪ 0 B

Reusable component library chunks

Status: 16 unchanged

Data & Services — 3.85 MB (baseline 3.85 MB) • ⚪ 0 B

Stores, services, APIs, and repositories

Status: 16 unchanged

Utilities & Hooks — 565 kB (baseline 565 kB) • ⚪ 0 B

Helpers, composables, and utility bundles

Status: 38 unchanged

Vendor & Third-Party — 17.4 MB (baseline 17.4 MB) • ⚪ 0 B

External libraries and shared vendor chunks

Status: 18 unchanged

Other — 17.7 MB (baseline 17.7 MB) • ⚪ 0 B

Bundles that do not match a named category

Status: 297 unchanged

⚡ Performance

⏳ Performance tests in progress…

@github-actions github-actions Bot added the risk:xhigh PR risk grade (advisory shadow check; grader-owned) label Sep 18, 2026
@claude

claude Bot commented Sep 18, 2026

Copy link
Copy Markdown
Contributor Author

Superseded by #18037 (same change, commits rewritten without AI co-author trailers).

@claude claude Bot closed this Sep 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:xhigh PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant