Repository navigation
[backport cloud/1.54] fix: default dynamic combo migration options to an empty array - #18173
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1933 passed, 0 failed📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-21T03:01:34.472Z",
"gitSha": "768d893732ac74404be77f9c8259329174b98bd6",
"branch": "backport-18037-to-cloud-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2083.679000000018,
"styleRecalcs": 6,
"styleRecalcDurationMs": 4.7280000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 579.225,
"heapDeltaBytes": -10931252,
"heapUsedBytes": 58918224,
"domNodes": -282,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 9.594999999999999,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2056.603999999993,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.924,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 524.201,
"heapDeltaBytes": 7912972,
"heapUsedBytes": 77930164,
"domNodes": -277,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 9.386999999999999,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1816.4649999999938,
"styleRecalcs": 75,
"styleRecalcDurationMs": 25.672,
"layouts": 14,
"layoutDurationMs": 4.150000000000001,
"taskDurationMs": 864.469,
"heapDeltaBytes": -6717728,
"heapUsedBytes": 63454284,
"domNodes": -279,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 154.167,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1870.0939999999946,
"styleRecalcs": 75,
"styleRecalcDurationMs": 28.658,
"layouts": 14,
"layoutDurationMs": 4.155,
"taskDurationMs": 889.456,
"heapDeltaBytes": -5986108,
"heapUsedBytes": 64018812,
"domNodes": -281,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 151.628,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1738.574999999969,
"styleRecalcs": 32,
"styleRecalcDurationMs": 15.010000000000002,
"layouts": 6,
"layoutDurationMs": 1.0669999999999997,
"taskDurationMs": 352.94199999999995,
"heapDeltaBytes": 4655972,
"heapUsedBytes": 75714056,
"domNodes": 74,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 11.269000000000002,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1738.3870000001025,
"styleRecalcs": 31,
"styleRecalcDurationMs": 17.167,
"layouts": 6,
"layoutDurationMs": 1.2519999999999998,
"taskDurationMs": 375.94899999999996,
"heapDeltaBytes": 4652480,
"heapUsedBytes": 74997556,
"domNodes": 77,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 12.359000000000002,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 642.3480000000268,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.786999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 443.64300000000003,
"heapDeltaBytes": 18775860,
"heapUsedBytes": 87722944,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 156.18699999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 736.2259999999878,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.876999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 455.01800000000003,
"heapDeltaBytes": 18829916,
"heapUsedBytes": 88338264,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 157.589,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2042.5650000000246,
"styleRecalcs": 5,
"styleRecalcDurationMs": 3.8189999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 597.367,
"heapDeltaBytes": 10235960,
"heapUsedBytes": 86634528,
"domNodes": -270,
"jsHeapTotalBytes": -2203648,
"scriptDurationMs": 36.82999999999999,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2058.1059999999525,
"styleRecalcs": 5,
"styleRecalcDurationMs": 5.195999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 669.0960000000001,
"heapDeltaBytes": 6133472,
"heapUsedBytes": 82659148,
"domNodes": -284,
"jsHeapTotalBytes": -630784,
"scriptDurationMs": 35.057,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2185.9949999999913,
"styleRecalcs": 64,
"styleRecalcDurationMs": 10.318999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1608.1739999999998,
"heapDeltaBytes": 21377996,
"heapUsedBytes": 87447708,
"domNodes": -278,
"jsHeapTotalBytes": 1273856,
"scriptDurationMs": 837.229,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2297.064999999975,
"styleRecalcs": 64,
"styleRecalcDurationMs": 10.870000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1683.1370000000004,
"heapDeltaBytes": 7840964,
"heapUsedBytes": 84706160,
"domNodes": -278,
"jsHeapTotalBytes": -1716224,
"scriptDurationMs": 791.7810000000001,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3444.9769999999944,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.325000000000001,
"layouts": 60,
"layoutDurationMs": 12.499,
"taskDurationMs": 1634.4630000000002,
"heapDeltaBytes": 7761764,
"heapUsedBytes": 75682656,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 743.2189999999999,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "large-graph-zoom",
"durationMs": 3583.2560000000058,
"styleRecalcs": 61,
"styleRecalcDurationMs": 11.684,
"layouts": 60,
"layoutDurationMs": 13.287,
"taskDurationMs": 1752.2859999999998,
"heapDeltaBytes": -1835004,
"heapUsedBytes": 76438716,
"domNodes": -280,
"jsHeapTotalBytes": -1679360,
"scriptDurationMs": 775.432,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3195.512000000008,
"styleRecalcs": 44,
"styleRecalcDurationMs": 8.603,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2014.379,
"heapDeltaBytes": 5830888,
"heapUsedBytes": 86328012,
"domNodes": -250,
"jsHeapTotalBytes": 1097728,
"scriptDurationMs": 1000.8779999999999,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3114.718000000039,
"styleRecalcs": 41,
"styleRecalcDurationMs": 6.012,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1986.032,
"heapDeltaBytes": 26688840,
"heapUsedBytes": 93087072,
"domNodes": -282,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 970.185,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2067.547999999988,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.073000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 622.548,
"heapDeltaBytes": 8703548,
"heapUsedBytes": 86409100,
"domNodes": -272,
"jsHeapTotalBytes": -1417216,
"scriptDurationMs": 32.675,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2078.041999999982,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.444000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 627.2400000000001,
"heapDeltaBytes": 6293188,
"heapUsedBytes": 83587840,
"domNodes": -278,
"jsHeapTotalBytes": -1155072,
"scriptDurationMs": 35.256,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 607.5270000000046,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.886,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 404.285,
"heapDeltaBytes": 14503564,
"heapUsedBytes": 86885464,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 143.94899999999998,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 573.9459999999781,
"styleRecalcs": 45,
"styleRecalcDurationMs": 8.775000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 394.08299999999997,
"heapDeltaBytes": 14641924,
"heapUsedBytes": 86671808,
"domNodes": 16,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 140.93999999999997,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2019.9739999999906,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.627,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 481.228,
"heapDeltaBytes": 7172500,
"heapUsedBytes": 80425324,
"domNodes": -294,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 7.755000000000002,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2029.7080000000278,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.900999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 552.544,
"heapDeltaBytes": -6917376,
"heapUsedBytes": 65093556,
"domNodes": -296,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 10.262,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1756.2560000000076,
"styleRecalcs": 76,
"styleRecalcDurationMs": 25.862000000000002,
"layouts": 18,
"layoutDurationMs": 4.552,
"taskDurationMs": 778.269,
"heapDeltaBytes": -7977800,
"heapUsedBytes": 64409720,
"domNodes": -297,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 96.151,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1781.82199999992,
"styleRecalcs": 78,
"styleRecalcDurationMs": 33.418000000000006,
"layouts": 18,
"layoutDurationMs": 6.457000000000001,
"taskDurationMs": 895.106,
"heapDeltaBytes": -6824344,
"heapUsedBytes": 65114160,
"domNodes": -296,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 118.39000000000001,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1384.266000000025,
"styleRecalcs": 17,
"styleRecalcDurationMs": 30.769999999999992,
"layouts": 13,
"layoutDurationMs": 14.417000000000003,
"taskDurationMs": 959.2719999999999,
"heapDeltaBytes": -5176432,
"heapUsedBytes": 84686376,
"domNodes": 13751,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 29.64,
"eventListeners": 2387,
"totalBlockingTimeMs": 134,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8310.783000000014,
"styleRecalcs": 247,
"styleRecalcDurationMs": 38.261,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5799.805,
"heapDeltaBytes": -12183160,
"heapUsedBytes": 91153472,
"domNodes": -268,
"jsHeapTotalBytes": -1155072,
"scriptDurationMs": 2650.7270000000003,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8302.583000000028,
"styleRecalcs": 250,
"styleRecalcDurationMs": 40.096999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5644.696,
"heapDeltaBytes": 4631840,
"heapUsedBytes": 80307704,
"domNodes": -278,
"jsHeapTotalBytes": -929792,
"scriptDurationMs": 2564.154,
"eventListeners": -178,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17931.65799999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17232.446,
"heapDeltaBytes": -50927488,
"heapUsedBytes": 182561028,
"domNodes": -8068,
"jsHeapTotalBytes": -17195008,
"scriptDurationMs": 308.05499999999995,
"eventListeners": -14933,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.330000000000048,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 18236.643000000073,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17488.016,
"heapDeltaBytes": -56208664,
"heapUsedBytes": 182357340,
"domNodes": -8068,
"jsHeapTotalBytes": -13545472,
"scriptDurationMs": 346.231,
"eventListeners": -14935,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 22030.079,
"styleRecalcs": 175,
"styleRecalcDurationMs": 21.015000000000008,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21694.738,
"heapDeltaBytes": -44798940,
"heapUsedBytes": 178810184,
"domNodes": -8068,
"jsHeapTotalBytes": -16719872,
"scriptDurationMs": 939.275,
"eventListeners": -14927,
"totalBlockingTimeMs": 74,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 22068.985999999997,
"styleRecalcs": 163,
"styleRecalcDurationMs": 21.428999999999977,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21848.987999999998,
"heapDeltaBytes": -35881024,
"heapUsedBytes": 168970880,
"domNodes": -8068,
"jsHeapTotalBytes": -10731520,
"scriptDurationMs": 916.036,
"eventListeners": -14929,
"totalBlockingTimeMs": 81,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6535.113000000024,
"styleRecalcs": 20,
"styleRecalcDurationMs": 78.52700000000002,
"layouts": 20,
"layoutDurationMs": 31.976000000000006,
"taskDurationMs": 6410.266999999999,
"heapDeltaBytes": -20773472,
"heapUsedBytes": 194836416,
"domNodes": -8068,
"jsHeapTotalBytes": 7835648,
"scriptDurationMs": 115.29799999999999,
"eventListeners": -14931,
"totalBlockingTimeMs": 531,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6412.584000000038,
"styleRecalcs": 20,
"styleRecalcDurationMs": 91.56900000000002,
"layouts": 20,
"layoutDurationMs": 25.66399999999999,
"taskDurationMs": 6344.9619999999995,
"heapDeltaBytes": -57683052,
"heapUsedBytes": 162090972,
"domNodes": -8068,
"jsHeapTotalBytes": 9007104,
"scriptDurationMs": 148.692,
"eventListeners": -14929,
"totalBlockingTimeMs": 349,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8999.510999999984,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8707.631,
"heapDeltaBytes": 2344316,
"heapUsedBytes": 171140608,
"domNodes": 0,
"jsHeapTotalBytes": -27525120,
"scriptDurationMs": 140.58300000000003,
"eventListeners": -16,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9203.735000000052,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8966.297,
"heapDeltaBytes": 19961924,
"heapUsedBytes": 180059836,
"domNodes": 0,
"jsHeapTotalBytes": -10223616,
"scriptDurationMs": 153.0189999999999,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 461.7070000000467,
"styleRecalcs": 13,
"styleRecalcDurationMs": 19.075,
"layouts": 3,
"layoutDurationMs": 1.4250000000000003,
"taskDurationMs": 105.49400000000003,
"heapDeltaBytes": 4877188,
"heapUsedBytes": 72848856,
"domNodes": 145,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 9.162999999999998,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "workflow-execution",
"durationMs": 87.10700000006,
"styleRecalcs": 6,
"styleRecalcDurationMs": 12.305,
"layouts": 2,
"layoutDurationMs": 0.6930000000000001,
"taskDurationMs": 59.460999999999984,
"heapDeltaBytes": 3007316,
"heapUsedBytes": 72115336,
"domNodes": 104,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 4.133000000000001,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.54 #18173 +/- ##
=============================================
Coverage ? 83.54%
=============================================
Files ? 2094
Lines ? 123512
Branches ? 32604
=============================================
Hits ? 103188
Misses ? 20146
Partials ? 178
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Independent target-adaptation review: COMMENT / HOLD for head 69add2c against cloud/1.54 tip 194fed4. Source #18037 intent and full four-file patch are preserved (identical stable patch ID); undefined options receive an empty array while malformed supplied options still reach the existing assertion. Current-target merge-tree simulation is clean. No target-specific code defect, review thread, or human objection found. Hosted product checks are green, but the AI co-author trailer check fails on this exact head. Remove only the forbidden Claude co-author trailer, preserving the human trailer; requalify the new exact head and current-target acceptance before merge. Current target is not an ancestor of this old carrier head. Cloud advisory cancellations are not a product regression. This is not a ready-for-merge receipt; REVIEW_REQUIRED is not itself a defect. Bounded review of this launch head is released for the finalizer to repair/refresh; any new head or target requires a new receipt.
<!-- ccr-slack-attribution --> _Requested via [Slack thread](https://comfy-organization.slack.com/archives/C09KFK2ABB8/p1789399739062479?thread_ts=1789399739.062479&cid=C09KFK2ABB8)_ ## Before / After **Before:** A subgraph-blueprint synthetic nodedef (built in `subgraphStore.ts`) that promotes a `COMFY_DYNAMICCOMBO_V3` boundary input produces a V1 tuple of `['COMFY_DYNAMICCOMBO_V3', undefined]`. `transformInputSpecV1ToV2` turned this into a V2 spec with no `options` key at all, so `flattenInputSpecs` hit its "expected an options array on dynamic combo" assertion and reported it to Sentry. Visibly, this dropped the nested option rows from the node's preview/help tab for these subgraph blueprints — cosmetic, not a crash. **After:** the same input now gets `options: []`, so the assertion is never tripped and the preview/help tab renders normally (with no nested options, matching reality, instead of silently failing). ## Why Fixes Sentry issue **CLOUD-FRONTEND-STAGING-4KQ** (`[Assertion failed]: flattenInputSpecs: expected an options array on dynamic combo`). `transformInputSpecV1ToV2` (`src/schemas/nodeDef/migration.ts`) now special-cases `COMFY_DYNAMICCOMBO_V3` the same way it already special-cases `CHART`: when the V1 tuple supplies no options object at all (`inputSpecV1[1] === undefined`), it defaults `options` to `[]` so the resulting V2 spec always satisfies `flattenInputSpecs`'s expectation of an options array. This only covers the "no options object at all" case produced by `subgraphStore.ts`'s `registerNodeDef`; a dynamic combo whose options object is present but missing its `options` key still throws as before (see the existing "skips a dynamic combo whose options field is not an array" test), so a genuinely malformed nodedef is still surfaced. ## Red-Green Verification | Commit | Purpose | |--------|---------| | `test: add failing test for dynamic combo migration missing options` | Proves the test reproduces the bug (fails against pre-fix `migration.ts`) | | `fix: default dynamic combo migration options to an empty array` | Makes the test pass, with the rest of `migration.test.ts` and `inputSpecUtil.test.ts` unaffected | ## Test Plan - [x] Unit test added in `src/schemas/nodeDef/migration.test.ts`, confirmed failing locally against pre-fix code - [x] Fix applied, same test passes locally - [x] Full `migration.test.ts` (23 → 24 tests) and `inputSpecUtil.test.ts` (5 tests) suites pass, including the existing "skips a dynamic combo whose options field is not an array" regression test - [x] `pnpm typecheck` clean --- _Generated by [Claude Code](https://claude.ai/code/session_01DqXqWkUXB8eNLEET45fpmo)_ --------- Co-authored-by: bymyself <cbyrne@comfy.org>
69add2c to
a213265
Compare
christian-byrne
left a comment
There was a problem hiding this comment.
Independent repaired-head adaptation review: COMMENT / HOLD at a213265 against cloud/1.54@194fed4da53941c6ca59f18af55647fac9ded5a8. The prior metadata and ancestry blockers are corrected. Independently verified: the amended ancestor's tree equals the original reviewed tree; bymyself's human trailer is preserved; the exact head tree equals Git's clean automatic merge of the amended ancestor and live target; target is an ancestor; the full target-relative product patch retains stable ID 9796611f20d8b72f32bfc909993c5bd9f51af28e. Executed trailer check: No AI agent Co-authored-by trailers found. Prior source-intent/full-adaptation review carries forward; no target-specific defect, review thread or human objection found. Finalizer reports 28 focused tests per target, source/browser typechecks, scoped lint/format/knip and blueprintDynamicCombo browser acceptance on both exact release trees using a disposable ComfyUI 0.30.0 CPU backend. Core's first browser attempt timed out during cold fixture setup before the test body; the retained failure was followed by unchanged assertions passing with a 120-second local setup budget. These execution results are finalizer-reported, not independently rerun; raw acceptance logs requested. The authoritative target-aware guard still returns NOT MERGE READY because hosted checks are incomplete. Adaptation is clear; bounded review lease RELEASED, not merge-ready. Inspect acceptance evidence, require terminal non-adverse hosted checks and run the current-target guard immediately before any authorized merge. Any head/target movement invalidates this receipt; unchanged code need not be reviewed again. REVIEW_REQUIRED is not itself a defect.
christian-byrne
left a comment
There was a problem hiding this comment.
Independent post-history target refresh review: COMMENT / HOLD at 2805b32 against cloud/1.54@78ab9ed884cd588026bb52c23755a04045585d72. Full tree equals the independently computed clean automatic merge of the prior reviewed carrier and the newly merged history target; ancestry passes and the target-relative source #18037 patch remains 9796611f20d8b72f32bfc909993c5bd9f51af28e. Trailer script passes. No additional product change, target-adaptation defect, unresolved review thread or new human objection found. Finalizer reports 68 passing focused tests per target (dynamic 28 + history 40), source/browser types, scoped lint/format and knip; these new runs are reported, not independently rerun. Fresh exact-head browser acceptance is still running. The authoritative target-aware guard returns NOT MERGE READY because hosted checks are incomplete. Prior-target browser success is not substituted for this new integration. Adaptation-clear; bounded review lease RELEASED, NOT merge-ready. Complete fresh acceptance/terminal checks and execute current-target guard immediately before any authorized merge. Head or target movement invalidates this receipt; REVIEW_REQUIRED alone is not a defect.
christian-byrne
left a comment
There was a problem hiding this comment.
Independent post-download Cloud adaptation review: COMMENT / HOLD for exact head 39dda8e against cloud/1.54@c0ce3d314aba81c99fd0560f474125a1a1ae8cce. Independently verified target ancestry, full tree equality with the clean automatic merge of prior reviewed head + target, unchanged source #18037 patch ID 9796611f20d8b72f32bfc909993c5bd9f51af28e, and passing trailer script. No additional product change, adaptation defect, unresolved review thread or new human objection. Inspected submitted archive (SHA256 b58a3c32b8022553e20423bec5ab3e084eefaaace493b9f63ab7161e5b1e590f): logs bind this head and target and show 87 unit passes plus one preserved activeDownloads expected failure across all three fix areas, browser types/format output, and the blueprint browser case passing in 19.3s with unchanged assertions. No independent rerun was performed. The target-aware guard still returns NOT MERGE READY because hosted checks are incomplete. Adaptation-clear; bounded review lease RELEASED, NOT merge-ready. Require terminal non-adverse hosted checks, immediate live guard, and terminal success of the prior automatic staging/testcloud deployment before the next Cloud merge. Use an explicit clean squash body and verify actual postmerge trailers/tree. The activeDownloads expected-failure and broader acceptance remain open; any head/target movement invalidates this receipt.
christian-byrne
left a comment
There was a problem hiding this comment.
Authorized finalizer COMMENT, not a human approval. Exact head 39dda8e against cloud/1.54@c0ce3d314aba81c99fd0560f474125a1a1ae8cce retains independent adaptation/acceptance review #18173 (review); reviewer released the metadata-only hold after Christian explicitly accepted the three historical generated trailers as residuals. No ruleset or release-history rewrite will occur.
Exact-head local evidence: 87 unit passes plus one retained activeDownloads expected failure, source/browser types, scoped lint/format/knip, and blueprint browser acceptance (1 pass, 19.3s). The evidence archive was independently inspected (SHA256 b58a3c32b8022553e20423bec5ab3e084eefaaace493b9f63ab7161e5b1e590f); the reviewer did not rerun tests. The current guard reports 89 terminal success/neutral/skipped checks and no stale receipts/unresolved threads. No unresolved human objection was found.
Christian's September 16/20 release-backport grant and September 21 accepted-residual disposition authorize the guarded admin squash merge; REVIEW_REQUIRED is the only protection condition bypassed. The PR body contains the prevention-mode Justification line. I will re-run the guard immediately before merging, supply an explicit clean squash body, then verify actual merged tree/trailers.
Christian also authorized automatic staging/testcloud deployment from qualified Cloud merges. Prior automatic run https://github.com/Comfy-Org/cloud/actions/runs/35555330547 is terminal success; I will monitor the next automatic run to terminal status and stop subsequent Cloud merges on failure. No manual dispatch or production release is authorized. Residuals retained: historical generated trailers, activeDownloads PM-1302/PM-1309 expected failure, and broader media/backend/import/cancellation acceptance. Mocked browser boundaries do not certify live model execution or deployed backend behavior.
|
Finalizer receipt: merged as 1bbcdc6 at 03:33:01Z after the immediate target-aware guard passed with 91 terminal non-adverse check-runs. Actual product tree 49da0643ee1c532ac805f6e3deefb79d1a60efa8 exactly equals the independently reviewed/tested head 39dda8e; parent is the qualified target c0ce3d3 and release ancestry passes. Explicit squash body used; actual merged-commit trailer check PASS with bymyself preserved. Frontend target push checks completed successfully. Automatic staging/testcloud run https://github.com/Comfy-Org/cloud/actions/runs/35557895812 is terminal SUCCESS (03:42:15Z); both deployment jobs succeeded. Its resolve log pins the exact merged frontend SHA. This was the authorized automatic repository_dispatch coupling, not a manual workflow dispatch. No production release/tag or ruleset/history rewrite was performed. Christian explicitly accepted the three historical generated Claude squash trailers as unrepaired residuals. The activeDownloads expected failure (PM-1302/PM-1309) and broader backend/media/import/cancellation acceptance remain open. Mocked browser acceptance is not live-model or deployed-backend certification. No human approval is claimed. |
Backport of #18037 to
cloud/1.54Automatically created by backport workflow.
Justification: Agent 1.54 release backport authorized by Christian's September 16/20 grant; exact head 39dda8e was independently adaptation-reviewed against cloud/1.54@c0ce3d314aba81c99fd0560f474125a1a1ae8cce, required target-native acceptance and terminal hosted checks passed, the current target-aware merge guard passed, and no unresolved human objection remains. REVIEW_REQUIRED is the only branch-protection condition bypassed. Residuals retained: the three historical generated Claude co-author trailers are explicitly accepted by Christian, not repaired; activeDownloads expected-failure PM-1302/PM-1309 and broader media/backend/import/cancellation acceptance remain open. Christian authorized the automatic staging/testcloud deployment coupled to qualified Cloud merges; the prior run 35555330547 succeeded and the next automatic run will be monitored to terminal status. No human approval is claimed.