Repository navigation
FE-2218 ci: run the billing-web unit tests on pull requests - #17827
Conversation
🎭 Playwright: ✅ 2024 passed, 0 failed · 1 flaky📊 Browser Reports
📦 Bundle: 10 MB gzip 🔴 +337 kBDetailsSummary
Category Glance App Entry Points — 3.73 kB (baseline 3.73 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.44 MB (baseline 1.43 MB) • 🔴 +16 kBGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 132 kB (baseline 124 kB) • 🔴 +7.82 kBTop-level views, pages, and routed surfaces
Status: 17 added / 16 removed / 1 unchanged Panels & Settings — 623 kB (baseline 621 kB) • 🔴 +2.37 kBConfiguration panels, inspectors, and settings screens
Status: 13 added / 13 removed / 14 unchanged User & Accounts — 32.3 kB (baseline 27.8 kB) • 🔴 +4.51 kBAuthentication, profile, and account management bundles
Status: 8 added / 8 removed / 3 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • 🔴 +740 BModals, dialogs, drawers, and in-app editors
Status: 8 added / 8 removed UI Components — 123 kB (baseline 117 kB) • 🔴 +6.26 kBReusable component library chunks
Status: 16 added / 15 removed Data & Services — 3.81 MB (baseline 3.6 MB) • 🔴 +205 kBStores, services, APIs, and repositories
Status: 16 added / 16 removed Utilities & Hooks — 561 kB (baseline 559 kB) • 🔴 +2.66 kBHelpers, composables, and utility bundles
Status: 29 added / 28 removed / 8 unchanged Vendor & Third-Party — 18.2 MB (baseline 18.1 MB) • 🔴 +137 kBExternal libraries and shared vendor chunks
Status: 9 added / 9 removed / 9 unchanged Other — 17.5 MB (baseline 16.4 MB) • 🔴 +1.11 MBBundles that do not match a named category
Status: 171 added / 171 removed / 125 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-16T13:54:59.575Z",
"gitSha": "46ecc7d69cdfd9a07f314fb8d50e841469688c18",
"branch": "jaewon/fe-2218-billing-web-ci-unit",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2021.788000000015,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.7029999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 387.68899999999996,
"heapDeltaBytes": 3458592,
"heapUsedBytes": 65783452,
"domNodes": -263,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 7.595000000000001,
"eventListeners": -154,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2005.8410000000322,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.907999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 450.1789999999999,
"heapDeltaBytes": 9270896,
"heapUsedBytes": 71314836,
"domNodes": -259,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 8.390000000000002,
"eventListeners": -154,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1842.409000000032,
"styleRecalcs": 79,
"styleRecalcDurationMs": 29.894000000000005,
"layouts": 14,
"layoutDurationMs": 4.253,
"taskDurationMs": 857.6870000000001,
"heapDeltaBytes": 8854452,
"heapUsedBytes": 71222712,
"domNodes": -260,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 165.656,
"eventListeners": -156,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1813.6570000000347,
"styleRecalcs": 76,
"styleRecalcDurationMs": 26.554999999999996,
"layouts": 14,
"layoutDurationMs": 4.458,
"taskDurationMs": 835.2890000000001,
"heapDeltaBytes": -1153960,
"heapUsedBytes": 59814996,
"domNodes": -261,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 164.44,
"eventListeners": -186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1707.583999999997,
"styleRecalcs": 32,
"styleRecalcDurationMs": 14.735,
"layouts": 6,
"layoutDurationMs": 1.29,
"taskDurationMs": 326.02799999999996,
"heapDeltaBytes": 2154576,
"heapUsedBytes": 64399864,
"domNodes": 75,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 10.050999999999997,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1725.0229999999647,
"styleRecalcs": 31,
"styleRecalcDurationMs": 15.747999999999998,
"layouts": 6,
"layoutDurationMs": 1.257,
"taskDurationMs": 334.33000000000004,
"heapDeltaBytes": 2108260,
"heapUsedBytes": 64540216,
"domNodes": 76,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 10.783000000000001,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 662.871999999993,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.687,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 462.27,
"heapDeltaBytes": 17904516,
"heapUsedBytes": 80311496,
"domNodes": 20,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 169.073,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 657.4980000000323,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.98,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 453.81399999999996,
"heapDeltaBytes": 17848920,
"heapUsedBytes": 80000124,
"domNodes": 16,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 168.937,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2037.776000000008,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.900999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 579.5580000000001,
"heapDeltaBytes": 3414252,
"heapUsedBytes": 82820492,
"domNodes": -247,
"jsHeapTotalBytes": -270336,
"scriptDurationMs": 34.236000000000004,
"eventListeners": -154,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2022.630999999933,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.5570000000000013,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 604.498,
"heapDeltaBytes": 4046620,
"heapUsedBytes": 83678180,
"domNodes": -251,
"jsHeapTotalBytes": -270336,
"scriptDurationMs": 34.76899999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2303.4019999999487,
"styleRecalcs": 66,
"styleRecalcDurationMs": 11.421000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1678.909,
"heapDeltaBytes": -1120368,
"heapUsedBytes": 79784360,
"domNodes": -251,
"jsHeapTotalBytes": 1265664,
"scriptDurationMs": 866.3770000000001,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2280.1020000000563,
"styleRecalcs": 67,
"styleRecalcDurationMs": 13.662999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1658.34,
"heapDeltaBytes": 15239588,
"heapUsedBytes": 79875972,
"domNodes": -248,
"jsHeapTotalBytes": 1798144,
"scriptDurationMs": 864.5849999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3562.0930000000044,
"styleRecalcs": 60,
"styleRecalcDurationMs": 9.719999999999995,
"layouts": 60,
"layoutDurationMs": 12.931,
"taskDurationMs": 1683.802,
"heapDeltaBytes": 7653292,
"heapUsedBytes": 74388332,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 791.298,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "large-graph-zoom",
"durationMs": 3597.7799999999434,
"styleRecalcs": 61,
"styleRecalcDurationMs": 10.642999999999995,
"layouts": 60,
"layoutDurationMs": 12.849,
"taskDurationMs": 1697.6360000000002,
"heapDeltaBytes": 9792016,
"heapUsedBytes": 75072936,
"domNodes": -257,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 788.569,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "legacy-node-drag",
"durationMs": 3090.0709999999663,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.695000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1891.6100000000001,
"heapDeltaBytes": 18917304,
"heapUsedBytes": 85559980,
"domNodes": 0,
"jsHeapTotalBytes": 942080,
"scriptDurationMs": 964.68,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3140.5309999998963,
"styleRecalcs": 42,
"styleRecalcDurationMs": 6.034999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1937.93,
"heapDeltaBytes": 20544820,
"heapUsedBytes": 87196580,
"domNodes": 4,
"jsHeapTotalBytes": 679936,
"scriptDurationMs": 1002.6980000000001,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2037.5460000000203,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.064000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 603.897,
"heapDeltaBytes": -8203708,
"heapUsedBytes": 79528876,
"domNodes": -254,
"jsHeapTotalBytes": -757760,
"scriptDurationMs": 34.511,
"eventListeners": -184,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2003.9050000000316,
"styleRecalcs": 5,
"styleRecalcDurationMs": 3.9730000000000008,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 566.0780000000001,
"heapDeltaBytes": 20101040,
"heapUsedBytes": 84217872,
"domNodes": -250,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 38.328,
"eventListeners": -154,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 587.1039999999539,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.600999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 408.781,
"heapDeltaBytes": 13932208,
"heapUsedBytes": 76879380,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 144.483,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 606.2580000000253,
"styleRecalcs": 48,
"styleRecalcDurationMs": 12.161999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 417.53700000000003,
"heapDeltaBytes": 13415100,
"heapUsedBytes": 77078668,
"domNodes": 22,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 144.098,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2000.8429999999748,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.383000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 454.557,
"heapDeltaBytes": 12152452,
"heapUsedBytes": 75746624,
"domNodes": -277,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 7.046,
"eventListeners": -200,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2023.2570000000578,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.7,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 450.936,
"heapDeltaBytes": 9116740,
"heapUsedBytes": 72683828,
"domNodes": -279,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 6.872,
"eventListeners": -200,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1741.6170000000193,
"styleRecalcs": 77,
"styleRecalcDurationMs": 30.705000000000002,
"layouts": 18,
"layoutDurationMs": 6.098,
"taskDurationMs": 814.904,
"heapDeltaBytes": 2857780,
"heapUsedBytes": 66321972,
"domNodes": -276,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 113.19000000000001,
"eventListeners": -232,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1706.8209999999908,
"styleRecalcs": 77,
"styleRecalcDurationMs": 27.902000000000005,
"layouts": 18,
"layoutDurationMs": 5.532,
"taskDurationMs": 797.709,
"heapDeltaBytes": 14235292,
"heapUsedBytes": 77629052,
"domNodes": -277,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 114.64099999999999,
"eventListeners": -202,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 949.2240000000152,
"styleRecalcs": 18,
"styleRecalcDurationMs": 30.470999999999997,
"layouts": 5,
"layoutDurationMs": 14.463000000000005,
"taskDurationMs": 736.3459999999999,
"heapDeltaBytes": 19990684,
"heapUsedBytes": 103497540,
"domNodes": 13587,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 28.702000000000005,
"eventListeners": 2385,
"totalBlockingTimeMs": 152,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "viewport-pan-sweep",
"durationMs": 8475.555999999982,
"styleRecalcs": 248,
"styleRecalcDurationMs": 35.951,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5793.359,
"heapDeltaBytes": -13189708,
"heapUsedBytes": 66737444,
"domNodes": -227,
"jsHeapTotalBytes": 3661824,
"scriptDurationMs": 2824.013,
"eventListeners": -168,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8320.296999999982,
"styleRecalcs": 248,
"styleRecalcDurationMs": 35.384,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5774.146,
"heapDeltaBytes": -4246368,
"heapUsedBytes": 75419096,
"domNodes": -245,
"jsHeapTotalBytes": -77824,
"scriptDurationMs": 2771.9770000000003,
"eventListeners": -138,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 12649.593000000039,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11855.869999999999,
"heapDeltaBytes": -6388284,
"heapUsedBytes": 190643444,
"domNodes": -6550,
"jsHeapTotalBytes": 4083712,
"scriptDurationMs": 219.17399999999998,
"eventListeners": -7482,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333237,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17271.54399999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16752.741,
"heapDeltaBytes": -8758852,
"heapUsedBytes": 193001280,
"domNodes": -6542,
"jsHeapTotalBytes": -581632,
"scriptDurationMs": 305.72599999999994,
"eventListeners": -7480,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21316.237999999998,
"styleRecalcs": 168,
"styleRecalcDurationMs": 17.817,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20888.571,
"heapDeltaBytes": -44197580,
"heapUsedBytes": 177656368,
"domNodes": -6542,
"jsHeapTotalBytes": -5443584,
"scriptDurationMs": 909.2750000000001,
"eventListeners": -7472,
"totalBlockingTimeMs": 44,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20715.97299999996,
"styleRecalcs": 159,
"styleRecalcDurationMs": 18.586999999999993,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20452.756,
"heapDeltaBytes": -36183484,
"heapUsedBytes": 166312484,
"domNodes": -6542,
"jsHeapTotalBytes": -1368064,
"scriptDurationMs": 953.1619999999999,
"eventListeners": -7472,
"totalBlockingTimeMs": 11,
"frameDurationMs": 18.330000000000048,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 6171.7310000000225,
"styleRecalcs": 20,
"styleRecalcDurationMs": 83.90099999999998,
"layouts": 20,
"layoutDurationMs": 25.056999999999995,
"taskDurationMs": 6050.181,
"heapDeltaBytes": -34547888,
"heapUsedBytes": 179391288,
"domNodes": -6542,
"jsHeapTotalBytes": 17260544,
"scriptDurationMs": 112.342,
"eventListeners": -7474,
"totalBlockingTimeMs": 348,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 6254.143999999997,
"styleRecalcs": 20,
"styleRecalcDurationMs": 91.083,
"layouts": 20,
"layoutDurationMs": 30.364,
"taskDurationMs": 6154.924999999999,
"heapDeltaBytes": -53656100,
"heapUsedBytes": 167652052,
"domNodes": -6542,
"jsHeapTotalBytes": 7536640,
"scriptDurationMs": 158.33399999999997,
"eventListeners": -7476,
"totalBlockingTimeMs": 567,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8799.47500000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8542.361,
"heapDeltaBytes": -6363464,
"heapUsedBytes": 182352032,
"domNodes": 0,
"jsHeapTotalBytes": 2359296,
"scriptDurationMs": 145.76100000000002,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8814.349999999991,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8487.087,
"heapDeltaBytes": 10747024,
"heapUsedBytes": 169183316,
"domNodes": -1,
"jsHeapTotalBytes": -3670016,
"scriptDurationMs": 144.43499999999997,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.886666666666617,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 480.60600000002296,
"styleRecalcs": 22,
"styleRecalcDurationMs": 29.898,
"layouts": 4,
"layoutDurationMs": 1.954,
"taskDurationMs": 143.98100000000002,
"heapDeltaBytes": 5255816,
"heapUsedBytes": 67110036,
"domNodes": 149,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 16.844,
"eventListeners": 83,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 450.4459999999426,
"styleRecalcs": 13,
"styleRecalcDurationMs": 16.883,
"layouts": 2,
"layoutDurationMs": 0.5119999999999999,
"taskDurationMs": 100.21199999999999,
"heapDeltaBytes": 4741864,
"heapUsedBytes": 66855072,
"domNodes": 119,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 9.337000000000002,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 8 included reviews per hour; 4 remain after this review. 📝 WalkthroughWalkthroughThe changes add billing web path detection, a conditional unit-test workflow, a required workflow gate, and a dedicated Codecov flag for billing web coverage. ChangesBilling web CI
Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Other Sequence Diagram(s)sequenceDiagram
participant GitHubEvent
participant ChangesFilter
participant BillingWebUnit
participant Codecov
participant BillingWebGate
GitHubEvent->>ChangesFilter: trigger workflow and detect changed paths
ChangesFilter-->>BillingWebUnit: app and package change outputs
BillingWebUnit->>BillingWebUnit: run billing-web test:coverage
BillingWebUnit->>Codecov: upload lcov.info with billing-web flag
BillingWebUnit-->>BillingWebGate: unit job result
ChangesFilter-->>BillingWebGate: filter job result and change outputs
BillingWebGate->>BillingWebGate: validate success or valid skip
Merge Risk: ⚪ Minimal · up to The billing-web CI coverage workflow and its stable gate are ready to merge. 🚥 Pre-merge checks | ✅ 7✅ Passed checks (7 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #17827 +/- ##
==========================================
+ Coverage 82.59% 83.59% +1.00%
==========================================
Files 2842 2185 -657
Lines 141828 125825 -16003
Branches 38333 32029 -6304
==========================================
- Hits 117140 105185 -11955
+ Misses 23481 20350 -3131
+ Partials 1207 290 -917
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
…e change as superseded (Comfy-Org#17828) Linear FE-2331. Follow-up from the Comfy-Org#17798 review. ## Why A billing read that fails is still an answer about the scope it was issued for. When the host switches workspace or disposes the reader while the request is in flight, the credits, status, and capabilities readers hand the caller back the original failure code — `REQUEST_FAILED`, `NOT_FOUND`, `CONFLICT` — instead of `SUPERSEDED`. A caller that distinguishes "this read no longer applies" from "this read failed" then retries, reports, or surfaces an error banner for a workspace the user already left. The same gap was fixed for `plans.ts` and `paymentMethods.ts` in Comfy-Org#17798; these three readers were written before that and kept the old shape. ## Root cause The lifecycle fence ran only on the success path: ```ts const result = await requestBalance(scope) if (result.status !== 'ok') { if (result.code === 'ACCESS_DENIED' && scopeTracker.isCurrent(context)) { snapshot = undefined } return result // <- returns before the fence } if (lifetime.disposed || !scopeTracker.isCurrent(context)) { return { status: 'error', code: 'SUPERSEDED' } } ``` Because the failure branch returned early, the failure never reached the fence. The `ACCESS_DENIED` snapshot drop compensated with its own `isCurrent` check, which is why the stale-scope case was handled for the cache but not for the returned result. ## How Move the fence to run immediately after the request settles, before `result.status` is inspected, in `credits.ts`, `status.ts`, and `capabilities.ts`. Any result — ok or error — that lands after a dispose or a scope change is now reported as `SUPERSEDED`. The denial drop keeps working for the current scope, and its now-redundant `isCurrent` guard is removed since the fence has already returned for a stale one. `capabilities.ts` is included because it carried the identical gap; `plans.ts` and `paymentMethods.ts` already have this shape from Comfy-Org#17798. ## AS-IS / TO-BE No UI change. This is SDK-internal error-code behavior on `packages/account`: | | AS-IS | TO-BE | | --- | --- | --- | | 500 lands after a workspace change | `{ code: 'REQUEST_FAILED', httpStatus: 500 }` | `{ code: 'SUPERSEDED' }` | | 500 lands after `dispose()` | `{ code: 'REQUEST_FAILED', httpStatus: 500 }` | `{ code: 'SUPERSEDED' }` | | 500 lands in the current scope | `{ code: 'REQUEST_FAILED', httpStatus: 500 }` | unchanged | | 403 lands in the current scope | drops the snapshot | unchanged | ## Testing - Added an `it.for` over two rows — the workspace changes, the reader is disposed — to each of `credits.test.ts`, `status.test.ts`, and `capabilities.test.ts`, gating a 500 behind the existing release-gate transport helper so the failure settles after the supersede. - All six new rows fail against the pre-fix source (`expected { status: 'error', code: 'REQUEST_FAILED', httpStatus: 500 } to deeply equal { status: 'error', code: 'SUPERSEDED' }`) and pass with the fence moved. - `packages/account` suite: 39 files, 634 tests passing. - `pnpm typecheck`, `pnpm lint`, `pnpm format:check`, `pnpm knip`, and `fallow audit --changed-since origin/main` all clean. ## Where this sits in the plan Billing SDK track FE-2210 ([implementation plan V2](https://app.notion.com/p/3d86d73d36508152b92cdbdfdfe83ac8)). Hybrid model: top-up in-app, subscription management / invoices / payment methods on the hosted billing app. | Phase | Item | Ticket | Status | | --- | --- | --- | --- | | 1-2 | Session core, transport, readers | FE-2211/2212/2213 | merged | | 3 | Operation lifecycle, commands, eight-state projection | FE-2227/2214/2223 | merged (Comfy-Org#17655) | | 4 | `@comfyorg/account-ui` composables + `CheckoutSteps` | FE-2215 | merged (Comfy-Org#17662, Comfy-Org#17663) | | 5 slice 1 | Top-up through the SDK behind `billing_sdk_topup_enabled` | FE-2216 | merged (Comfy-Org#17665) | | rollout C | `hosted_billing_destination` server flag read by the host | FE-2218 | merged (Comfy-Org#17716) | | rollout C | `hostedDestination` port on the lifecycle, value on operation state | FE-2210/2218 | open (Comfy-Org#17783) | | 7 prep | Scope-source port + credentialed transport (BFF / cookie hosts) | FE-2218 | merged (Comfy-Org#17782) | | 7 prep | `@comfyorg/account` → `@comfyorg/account-core` rename | FE-2218 | local, opens after Comfy-Org#17783 and Comfy-Org#17794 | | 7 prep | `billing-contract` route builder + `return_to` registry | FE-2218 | merged (Comfy-Org#17795) | | 3A-3 | Workshop adapter over `createHostedTopupCheckout` | FE-2214 | merged (Comfy-Org#17793) | | 8 core | `previewSubscribe` command | FE-2331 | merged (Comfy-Org#17797) | | 8 core | Plans + saved payment-methods readers | FE-2331 | open (Comfy-Org#17798, whole Phase 8) | | 8 ui | account-ui composables (`usePlans`, `usePaymentMethods`, `usePreviewSubscribe`) | FE-2331 | in Comfy-Org#17798 | | 7 | billing-web own-origin session, sign-in, SDK composition | FE-2218 | in Comfy-Org#17798 | | 7 | billing-web unit tests in CI (`ci-billing-web-unit.yaml`) | FE-2218 | open (Comfy-Org#17827) | | 7 | ingest CORS + top-up return hosts for billing.comfy.org and its previews (Comfy-Org/cloud) | FE-2218 | open (cloud PR 9512) | | 8 ui | billing-web `/v1` entry routing + subscription / payment-method surfaces | FE-2331 | in Comfy-Org#17798 | | 7 | npm publish (`ingest-types`, `account-core`, `billing-contract`), Platform install, billing-web live top-up | FE-2218 | todo | | 6 | Contract tests + live E2E per flow × consumer | FE-2217 | todo | | 5 slice 2 | Subscription flows through the SDK | FE-2216 | todo (plan-change decision) | | follow-up | One `needsCustomerAttention` predicate (from the Comfy-Org#17665 review) | FE-2216 | merged (Comfy-Org#17792) | | follow-up | Opaque `BillingServerCode` (from the Comfy-Org#17656 review) | FE-2227 | open (Comfy-Org#17794) | | follow-up | `useCredits` clears on `SUPERSEDED` (from the Comfy-Org#17799 review) | FE-2215 | open (Comfy-Org#17824) | | follow-up | credits / status / capabilities readers fence a late failure as `SUPERSEDED` (from the Comfy-Org#17798 review) | FE-2331 | **this PR** | ```mermaid flowchart LR P3["Phase 3 core lifecycle (merged)"] P4["Phase 4 account-ui (merged)"] P5["Phase 5 slice 1 top-up flag (merged)"] FC["PR 17716 hosted_billing_destination flag (merged)"] HD["PR 17783 hostedDestination port"] SS["PR 17782 scope-source port + credentialed transport"] RN["account-core rename"] RB["billing-contract route builder + return_to"] WS["Workshop adapter"] P8PV["previewSubscribe command"] P8RD["plans + payment-methods readers"] P8["account-ui hosted composables"] BWS["billing-web session + sign-in"] BWV["billing-web /v1 surfaces"] CORS["cloud PR 9512 ingest CORS + return hosts"] PUB["npm publish account-core / billing-contract"] P7["Phase 7 host proof: Platform + billing-web live"] P6["Phase 6 evidence"] S2["Phase 5 slice 2 subscription"] FU9["customer-attention predicate"] FU11["opaque BillingServerCode"] FU12["useCredits clears on SUPERSEDED"] FU13["reader late-failure fence"] P3 --> HD FC --> HD HD --> RB P3 --> SS SS --> P7 RB --> P7 P3 --> RN RN --> PUB RB --> PUB PUB --> P7 P3 --> P8PV P3 --> P8RD P8PV --> P8 P8RD --> P8 P4 --> P8 P8 --> S2 P8 --> BWS BWS --> BWV RB --> BWV BWV --> P7 CORS --> P7 P5 --> P6 P5 --> WS P5 --> FU9 P3 --> FU11 P4 --> FU12 P3 --> FU13 style P3 fill:#d4edda,stroke:#155724 style P4 fill:#d4edda,stroke:#155724 style P5 fill:#d4edda,stroke:#155724 style FC fill:#d4edda,stroke:#155724 style SS fill:#d4edda,stroke:#155724 style RB fill:#d4edda,stroke:#155724 style WS fill:#d4edda,stroke:#155724 style FU9 fill:#d4edda,stroke:#155724 style P8PV fill:#d4edda,stroke:#155724 style FU13 stroke:#0366d6,stroke-width:4px ```
|
Reviewed at head This PR changes CI configuration only, so there is no UI behavior to capture. The directly relevant proof is the suite the new workflow will run. Setup caveat: run locally rather than in Actions, on a checkout whose The generated Also checked and clear: The inline comments below are optional follow-ups, not merge blockers. |
huang47
left a comment
There was a problem hiding this comment.
Approving. I verified the suite this workflow will actually run — see the evidence comment above (2 files / 7 tests, 98.33% statements, lcov paths re-root correctly under network_prefix) — and the workflow itself mirrors ci-website-unit.yaml closely enough that the fork handling, token handling and node_cache default are all right. Single commit, message and title match the diff, no runtime behavior touched.
Three optional follow-ups inline. None of them need to hold this merge.
| - 'scripts/cicd/prepare-website-e2e-report.sh' | ||
| - 'scripts/cicd/check-website-e2e-result.sh' | ||
| app_billing_web: | ||
| - 'apps/billing-web/**' |
There was a problem hiding this comment.
Should this filter also list .github/workflows/ci-billing-web-unit.yaml, the way app_website just above lists ci-website-e2e.yaml and its two scripts? The consequence is visible on this very PR: run 35103654522 / 35103654481 shows billing-web-unit skipped and billing-web-unit-gate passing through the skip branch, so the job this PR adds has never executed once. The merge queue would still exercise it before anything lands on main, so this is fine to do as a follow-up.
There was a problem hiding this comment.
Agreed, and the fix is prepared: app_billing_web also matches .github/workflows/ci-billing-web-unit.yaml, so a change to the workflow runs the job it defines instead of skipping past it.
Not pushed to this branch: the PR is at merge-queue position 1 (enqueued 16:04:18Z) and the branch is push-protected while queued, so landing it here would mean dequeuing and dropping your approval. It goes out as a follow-up PR together with the two codecov points below.
There was a problem hiding this comment.
Yes — fixed in #17844, which adds .github/workflows/ci-billing-web-unit.yaml to app_billing_web.
Your diagnosis holds exactly as written: run 35103654481 shows billing-web-unit skipped and billing-web-unit-gate green through the skip branch, so this PR merged without ever executing the job it added. The first execution was the post-merge push run on main (35121739924), which ran only because every filter output defaults to 'true' off pull_request.
One nuance on the precedent you cited: app_website lists ci-website-e2e.yaml, but not ci-website-unit.yaml. So the existing unit-workflow convention is actually 'do not self-list', and what landed here matched it. I still think self-listing is the right call — the gate is only meaningful if the workflow that defines it is in scope — so #17844 changes billing-web and leaves app_website alone rather than quietly altering website CI. Worth the matching one-liner for ci-website-unit.yaml, or do you prefer that asymmetry left as-is?
| billing-web: | ||
| paths: | ||
| - apps/billing-web/src/** | ||
| carryforward: false |
There was a problem hiding this comment.
Do we want matching project.billing-web and patch.billing-web entries under coverage.status too? The website flag has both, scoped to apps/website/src/** with flag_coverage_not_uploaded_behavior: pass — which is why this PR shows live codecov/patch/website and codecov/project/website checks and no billing-web counterparts. As it stands the new upload arrives with no dedicated status of its own.
There was a problem hiding this comment.
Yes. The follow-up adds project.billing-web and patch.billing-web mirroring the website pair — paths: apps/billing-web/src/**, flags: [billing-web-unit], informational: true, flag_coverage_not_uploaded_behavior: pass — so the new upload reports under a status of its own instead of only feeding the comment.
There was a problem hiding this comment.
Yes — added in #17844. project.billing-web and patch.billing-web now mirror the website entries verbatim apart from the path and flag: scoped to apps/billing-web/src/**, informational: true, and flag_coverage_not_uploaded_behavior: pass so a skipped job cannot fail the status.
Verified with Codecov's own validator (curl -X POST --data-binary @codecov.yml https://codecov.io/validate → Valid!); both statuses resolve to flag billing-web and path (?s:apps/billing\-web/src/.*)\Z.
| paths: | ||
| - apps/website/src/** | ||
| carryforward: false | ||
| billing-web: |
There was a problem hiding this comment.
Is billing-web the name we want sitting next to website-unit a few lines up? Renaming a flag later costs its coverage history, so this is the cheapest moment to settle whether the convention is <app> or <app>-unit.
There was a problem hiding this comment.
billing-web-unit, matching website-unit and leaving billing-web-e2e free for later. Renamed in the follow-up, in both places the flag appears: the codecov.yml flags: entry, and this workflow's Codecov flags: input.
Nothing is lost by doing it now rather than at merge: as your other comment shows, the job has never executed, so no coverage has ever been uploaded under billing-web. It does want to land before #17798, which adds ~10 billing-web test files and would be the first real upload.
There was a problem hiding this comment.
Agreed on the convention — website-unit is the only other app flag, and ci-website-unit.yaml uploads under that name, so billing-web-unit is the consistent choice. Your point about the cost of a late rename is the operative one: the flag currently holds exactly one upload (the post-merge push run), so this is as cheap as it will ever be.
It is not in #17844, and only for a mechanical reason. The rename has to move flags: in ci-billing-web-unit.yaml and both new status entries in a single commit — split across two, the upload and the config disagree and the statuses silently receive no data. The token I have carries no workflow scope, so pushing .github/workflows/ is refused outright (refusing to allow a Personal Access Token to create or update workflow ... without 'workflow' scope), and the Contents API is gated the same way.
So it needs a push from a workflow-scoped credential. Three lines, all verified locally against the Codecov validator before I had to drop them:
ci-billing-web-unit.yaml:flags: billing-web→flags: billing-web-unitcodecov.yml:flags.billing-web→flags.billing-web-unitcodecov.yml: theflags:list under bothproject.billing-webandpatch.billing-web→billing-web-unit
Happy to fold it into #17844 if you or @dante01yoon re-push that branch; otherwise it should get its own PR before more history accrues under billing-web. Leaving the status-name keys as billing-web either way, matching website keying website-unit.
… a status Two follow-ups from the #17827 review. `app_billing_web` did not list `ci-billing-web-unit.yaml`, so a PR that only touches the workflow left `billing-web-unit` skipped and `billing-web-unit-gate` passing through its skip branch. #17827 itself merged that way: run 35103654481 never executed the job it added. Listing the workflow in its own filter makes it self-testing on pull requests. The merge queue already ran it unconditionally, because every filter output defaults to 'true' off `pull_request`. `coverage.status` had no `project.billing-web` or `patch.billing-web`, so the upload arrived with no dedicated status while the website flag has both. Both now mirror the website entries: scoped to `apps/billing-web/src/**`, informational, and `flag_coverage_not_uploaded_behavior: pass`. The third review point — renaming the flag to `billing-web-unit` to match `website-unit` — is left out. It has to change `flags:` in the workflow and both new status entries in one commit, or the upload and the config disagree, and the token available here cannot push `.github/workflows/`.
… a status Two follow-ups from the #17827 review. `app_billing_web` did not list `ci-billing-web-unit.yaml`, so a PR that only touches the workflow left `billing-web-unit` skipped and `billing-web-unit-gate` passing through its skip branch. #17827 itself merged that way: run 35103654481 never executed the job it added. Listing the workflow in its own filter makes it self-testing on pull requests. The merge queue already ran it unconditionally, because every filter output defaults to 'true' off `pull_request`. `coverage.status` had no `project.billing-web` or `patch.billing-web`, so the upload arrived with no dedicated status while the website flag has both. Both now mirror the website entries: scoped to `apps/billing-web/src/**`, informational, and `flag_coverage_not_uploaded_behavior: pass`. The third review point — renaming the flag to `billing-web-unit` to match `website-unit` — is left out. It has to change `flags:` in the workflow and both new status entries in one commit, or the upload and the config disagree, and the token available here cannot push `.github/workflows/`.
The third review point on #17827: the flag was `billing-web` while the website's is `website-unit`, so the two apps named the same kind of upload differently. Renaming now, before more history accrues under the old name — a later rename discards the flag's coverage history. One commit on purpose. The name lives in three places: `flags:` on the codecov upload step in `ci-billing-web-unit.yaml`, `flags.billing-web-unit` in `codecov.yml`, and the `flags:` list inside each of the two statuses this PR added. Split across commits, the upload would carry one name while the config expected the other, and the statuses would silently receive no data for every commit in between. The two status keys move to `billing-web-unit` as well, so the check names match the flag they report on.
…the SDK rail behind billing_sdk_subscription_enabled (#17853) Stacked on #17783 (base branch `jaewon/fe-2210-hosted-destination-port`); merge that first. ## Why Phase 5 slice 1 (#17665) moved top-up onto the Billing SDK behind `billing_sdk_topup_enabled`. The subscription actions the host already owns — cancel, resubscribe, and opening the payment portal — still call the workspace API directly and rely on the legacy poller for settlement and telemetry. This slice moves those three onto the SDK's commands behind their own server flag, `billing_sdk_subscription_enabled` (already on `/api/features` via Comfy-Org/cloud#9248, PostHog at 0%), so the eight-state lifecycle, idempotency, recovery and telemetry come from one implementation. Subscribe and plan change are slice 2b, stacked on this PR. ## How - **Rail switch.** `billingSdkSubscriptionRailEnabled` = `billing_sdk_subscription_enabled` AND `unified_cloud_auth`, exactly like the top-up rail. `useSubscriptionRail()` reads it once, synchronously, at the start of an action, so a flag flip mid-flow cannot issue on one rail and observe on the other. - **Three actions, one adapter.** `useWorkspaceBilling.cancelSubscription / resubscribe / manageSubscription` try the rail first; the store runs `sdk.commands.cancelSubscription()`, `resubscribe()`, `openPaymentPortal({ returnUrl })` and projects the result onto what the adapter already does with the legacy calls: settle, or throw a `WorkspaceApiError` (message is the host's, since the SDK never carries server text; `serverCode` lands in `.code`). A command that settles in any phase but `succeeded` is a failure, matching the poller. The refresh after success mirrors the poller's: cancel → status + balance + capabilities; resubscribe → `reconcileSubscriptionSuccess` + capabilities. - **Fallback.** A 404 (backend gate closed while the client flag is on) projects to `unavailable`: the adapter runs its legacy body for that action, and the store latches the route as unavailable for the tab so later actions go straight to legacy without another failed round trip. Every other failure — including `SUPERSEDED` — is thrown, never retried on legacy, so a late or superseded result cannot double-issue. - **Telemetry.** Lifecycle events are now reported for non-topup operations (top-up keeps its resumed-only filter because its dialog reports). `toBillingTelemetryEvent` already emits the poller's payload shape, so dashboards cannot tell the rails apart. - **No client-derived server state.** Eligibility and already-held answers come from the SDK and the server, as for top-up. `subscribe`, `previewSubscribe`, `useSubscriptionCheckout` and `useLegacyBilling` are untouched. ## AS-IS / TO-BE | State | AS-IS (flag off) | TO-BE (flag on) | | --- | --- | --- | | Cancel dialog at rest | <img width="480" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/as-is-cancel-dialog.png"> | <img width="480" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/to-be-cancel-dialog.png"> | | Cancel in flight | <img width="480" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/as-is-cancel-in-flight.png"> | <img width="480" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/to-be-cancel-in-flight.png"> | | Cancel settled (success toast) | <img width="480" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/as-is-cancel-settled.png"> | <img width="480" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/to-be-cancel-settled.png"> | | Cancel failed (error toast) | <img width="480" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/as-is-cancel-failed.png"> | <img width="480" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/to-be-cancel-failed.png"> | | User popover after cancel (cancelled state) | <img width="480" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/as-is-panel-after-cancel.png"> | <img width="480" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/to-be-panel-after-cancel.png"> | | Cancel request recorded | <img width="480" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/as-is-network.png"> | <img width="480" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/to-be-network.png"> | | Settings billing panel | <img width="480" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/as-is-billing-panel.png"> | <img width="480" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/to-be-billing-panel.png"> | | Resubscribe (Resume Pro) | <img width="480" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/as-is-resubscribe.png"> | <img width="480" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/to-be-resubscribe.png"> | | Resubscribe request recorded | <img width="480" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/as-is-resubscribe-network.png"> | <img width="480" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/to-be-resubscribe-network.png"> | | Payment-portal request recorded | <img width="480" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/as-is-portal-network.png"> | <img width="480" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/to-be-portal-network.png"> | - AS-IS (flag off): cancel / resubscribe / portal POST the workspace API directly; settlement and telemetry come from the legacy poller. - TO-BE (flag on): the same dialogs and toasts, the POSTs go through the SDK transport (`Idempotency-Key` on the request), settlement through the operation lifecycle; a 404 falls back to the legacy call. ## Testing | Gate | Result | | --- | --- | | `vitest run src/platform/workspace/billing src/composables/billing src/platform/workspace/composables src/platform/workspace/stores src/composables/useFeatureFlags` | 41 files, 1138 tests (12 new projection tests, 13 new adapter rail tests, +5 store tests) | | `pnpm typecheck`, `pnpm typecheck:browser`, `lint`, `format:check`, `knip` | exit 0 | | `fallow audit --changed-since origin/jaewon/fe-2210-hosted-destination-port` | no issues in 11 changed files, complexity 0, duplication 0 | | Playwright `browser_tests/tests/dialogs/cancelSubscriptionSdkRail.spec.ts` (cloud project) | **3 passed** against a served cloud dev build — `PLAYWRIGHT_TEST_URL=http://localhost:5173 pnpm exec playwright test --project=cloud browser_tests/tests/dialogs/cancelSubscriptionSdkRail.spec.ts --reporter=list`. Flag off → legacy request, flow unchanged; flag on → SDK request (`Idempotency-Key`), same dialog outcome; flag on + 404 → legacy fallback. | ## Where this sits in the plan Billing SDK track FE-2210 ([implementation plan V2](https://app.notion.com/p/3d86d73d36508152b92cdbdfdfe83ac8)). Hybrid model: top-up in-app, subscription management / invoices / payment methods on the hosted billing app. | Phase | Item | Ticket | Status | | --- | --- | --- | --- | | 1-2 | Session core, transport, readers | FE-2211/2212/2213 | merged | | 3 | Operation lifecycle, commands, eight-state projection | FE-2227/2214/2223 | merged (#17655) | | 4 | `@comfyorg/account-ui` composables + `CheckoutSteps` | FE-2215 | merged (#17662, #17663) | | 5 slice 1 | Top-up through the SDK behind `billing_sdk_topup_enabled` | FE-2216 | merged (#17665) | | rollout C | `hosted_billing_destination` server flag read by the host | FE-2218 | merged (#17716) | | rollout C | `hostedDestination` port on the lifecycle, value on operation state | FE-2210/2218 | #17783 (review; parent of this PR) | | 7 prep | Scope-source port + credentialed transport (BFF / cookie hosts) | FE-2218 | merged (#17782) | | 7 prep | `@comfyorg/account` → `@comfyorg/account-core` rename | FE-2218 | #17851 (review) | | 7 prep | `billing-contract` route builder + `return_to` registry | FE-2218 | merged (#17795) | | 3A-3 | Workshop adapter over `createHostedTopupCheckout` | FE-2214 | merged (#17793) | | 8 core | `previewSubscribe` command | FE-2331 | merged (#17797) | | 8 core | Plans + saved payment-methods readers | FE-2331 | #17798 (queued) | | 8 ui | account-ui composables (`usePlans`, `usePaymentMethods`, `usePreviewSubscribe`) | FE-2331 | #17798 (queued) | | 7 | billing-web own-origin session, sign-in, SDK composition | FE-2218 | #17798 (queued) | | 7 | billing-web unit tests in CI (`ci-billing-web-unit.yaml`) | FE-2218 | merged (#17827); #17844 (queued) | | 7 | ingest CORS + top-up return hosts for billing.comfy.org and its previews (Comfy-Org/cloud) | FE-2218 | merged (Comfy-Org/cloud#9512) | | 8 ui | billing-web `/v1` entry routing + subscription / payment-method surfaces | FE-2331 | #17798 (queued) | | 7 | npm publish (`ingest-types`, `account-core`, `billing-contract`), Platform install, billing-web live top-up | FE-2218 | todo | | 6 | Contract tests per generated schema (package layer) | FE-2217 | #17829 (review) | | 6 | Live E2E per flow × consumer + evidence table | FE-2217 | todo (needs staging flags) | | 5 slice 2a | Cancel, resubscribe and payment portal through the SDK behind `billing_sdk_subscription_enabled` | FE-2216 | **this PR** | | 5 slice 2b | Subscribe / plan change through the SDK (`previewSubscribe` quote, then subscribe; the SDK stops short-circuiting an active plan) | FE-2216 | next, stacked on this PR | | follow-up | One `needsCustomerAttention` predicate (from the #17665 review) | FE-2216 | merged (#17792) | | follow-up | Opaque `BillingServerCode` (from the #17656 review) | FE-2227 | merged (#17794) | | follow-up | `useCredits` clears on `SUPERSEDED` (from the #17799 review) | FE-2215 | merged (#17824) | | follow-up | credits / status / capabilities readers fence a late failure as `SUPERSEDED` (from the #17798 review) | FE-2331 | merged (#17828) | ```mermaid flowchart LR P3["Phase 3 core lifecycle (merged)"] P4["Phase 4 account-ui (merged)"] P5["Phase 5 slice 1 top-up flag (merged)"] FC["PR 17716 hosted_billing_destination flag (merged)"] HD["PR 17783 hostedDestination port"] SS["PR 17782 scope-source port + credentialed transport"] RN["account-core rename"] RB["billing-contract route builder + return_to"] WS["Workshop adapter"] P8PV["previewSubscribe command"] P8RD["plans + payment-methods readers"] P8["account-ui hosted composables"] BWS["billing-web session + sign-in"] BWV["billing-web /v1 surfaces"] CORS["cloud PR 9512 ingest CORS + return hosts"] PUB["npm publish account-core / billing-contract"] P7["Phase 7 host proof: Platform + billing-web live"] P6C["Phase 6 contract tests"] P6["Phase 6 live evidence"] S2A["Phase 5 slice 2a cancel / resubscribe / portal rail"] S2B["Phase 5 slice 2b subscribe + plan change"] FU9["customer-attention predicate"] FU11["opaque BillingServerCode"] FU12["useCredits clears on SUPERSEDED"] FU13["reader late-failure fence"] P3 --> HD FC --> HD HD --> RB P3 --> SS SS --> P7 RB --> P7 P3 --> RN RN --> PUB RB --> PUB PUB --> P7 P3 --> P8PV P3 --> P8RD P8PV --> P8 P8RD --> P8 P4 --> P8 P8 --> S2B HD --> S2A S2A --> S2B P8 --> BWS BWS --> BWV RB --> BWV BWV --> P7 CORS --> P7 P5 --> P6 P3 --> P6C P5 --> WS P5 --> FU9 P3 --> FU11 P4 --> FU12 P3 --> FU13 style P3 fill:#d4edda,stroke:#155724 style P4 fill:#d4edda,stroke:#155724 style P5 fill:#d4edda,stroke:#155724 style FC fill:#d4edda,stroke:#155724 style SS fill:#d4edda,stroke:#155724 style RB fill:#d4edda,stroke:#155724 style WS fill:#d4edda,stroke:#155724 style FU9 fill:#d4edda,stroke:#155724 style FU11 fill:#d4edda,stroke:#155724 style FU12 fill:#d4edda,stroke:#155724 style FU13 fill:#d4edda,stroke:#155724 style CORS fill:#d4edda,stroke:#155724 style P8PV fill:#d4edda,stroke:#155724 style S2A stroke:#0366d6,stroke-width:4px ```
… a status (Comfy-Org#17844) Follow-up to Comfy-Org#17827, from @huang47's review. ## Why Two of the three review points, both in files Comfy-Org#17827 touched. **1. The workflow does not gate on itself** ([comment](Comfy-Org#17827 (comment))). `app_billing_web` listed only `apps/billing-web/**`, so a PR that changes nothing but `ci-billing-web-unit.yaml` leaves `billing-web-unit` skipped and `billing-web-unit-gate` passing through its skip branch. Comfy-Org#17827 merged exactly that way — run [35103654481](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/35103654481) never executed the job it added. Only the post-merge push run on `main` ([35121739924](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/35121739924)) did, because every filter output defaults to `'true'` off `pull_request`. **2. The flag has no status of its own** ([comment](Comfy-Org#17827 (comment))). `codecov.yml` declared the `billing-web` flag but no `project.billing-web` / `patch.billing-web` under `coverage.status`, while the website flag has both. The upload arrived with nothing attributing it, which is why Comfy-Org#17827 showed live `codecov/patch/website` and `codecov/project/website` checks and no billing-web counterparts. ## How - `app_billing_web` now lists `.github/workflows/ci-billing-web-unit.yaml`, the way `app_website` lists `ci-website-e2e.yaml` and its two scripts. Output description updated to match. - `project.billing-web` and `patch.billing-web` mirror the website entries verbatim apart from the path and flag: scoped to `apps/billing-web/src/**`, `informational: true`, `flag_coverage_not_uploaded_behavior: pass`, so a skipped job does not fail the status. ## Also in this PR (added after the first push) **The flag rename** (`billing-web` → `billing-web-unit`, @huang47's third point) landed as a second commit, 089a852. It changes `flags:` in `ci-billing-web-unit.yaml`, the `flags:` list of both new status entries and the `flags.` block in `codecov.yml` in one commit, so the upload and the config never disagree. The status keys stay `billing-web` (check names `codecov/project/billing-web`, `codecov/patch/billing-web`), mirroring how the website keeps status key `website` with flag `website-unit`. The first push could not include it because that session's token lacked the `workflow` scope; this push has it. Deliberately unchanged: `app_website` still does **not** list `ci-website-unit.yaml` (only the e2e workflow and its two scripts), so the website *unit* workflow keeps the blind spot this PR fixes for billing-web. @huang47 — worth the matching one-liner, or do you want the asymmetry left alone? ## AS-IS / TO-BE No UI change; CI configuration only. - AS-IS: a `ci-billing-web-unit.yaml`-only PR skips the suite and reports a green gate. The `billing-web` flag uploads with no dedicated status. - TO-BE: that PR runs the suite. The upload gets `codecov/project/billing-web` and `codecov/patch/billing-web`. ## Testing - `curl -X POST --data-binary @codecov.yml https://codecov.io/validate` → `Valid!`. Both new statuses resolve to flag `billing-web` and path `(?s:apps/billing\-web/src/.*)\Z`. - Cross-checked the three places the flag name appears — the workflow's `flags:`, `flags.billing-web`, and both status entries — all read `billing-web`, so the upload is attributed. - Both changed files parse as YAML; `app_billing_web` resolves to `['apps/billing-web/**', '.github/workflows/ci-billing-web-unit.yaml']`. - Not demonstrated end-to-end: this PR touches neither `apps/billing-web/**` nor the workflow, so `billing-web-unit` is expected to **skip** here too. The self-test behaviour can only be observed on a PR that edits the workflow file, which is the push this token cannot make. The mechanism is the same glob matching that already makes `app_website` react to `ci-website-e2e.yaml`. ## Where this sits in the plan Billing SDK track FE-2210 ([implementation plan V2](https://app.notion.com/p/3d86d73d36508152b92cdbdfdfe83ac8)). Hybrid model: top-up in-app, subscription management / invoices / payment methods on the hosted billing app. | Phase | Item | Ticket | Status | | --- | --- | --- | --- | | 1-2 | Session core, transport, readers | FE-2211/2212/2213 | merged | | 3 | Operation lifecycle, commands, eight-state projection | FE-2227/2214/2223 | merged (Comfy-Org#17655) | | 4 | `@comfyorg/account-ui` composables + `CheckoutSteps` | FE-2215 | merged (Comfy-Org#17662, Comfy-Org#17663) | | 5 slice 1 | Top-up through the SDK behind `billing_sdk_topup_enabled` | FE-2216 | merged (Comfy-Org#17665) | | rollout C | `hosted_billing_destination` server flag read by the host | FE-2218 | merged (Comfy-Org#17716) | | rollout C | `hostedDestination` port on the lifecycle, value on operation state | FE-2210/2218 | Comfy-Org#17783 (review) | | 7 prep | Scope-source port + credentialed transport (BFF / cookie hosts) | FE-2218 | merged (Comfy-Org#17782) | | 7 prep | `@comfyorg/account` → `@comfyorg/account-core` rename | FE-2218 | todo (after Comfy-Org#17783, Comfy-Org#17794) | | 7 prep | `billing-contract` route builder + `return_to` registry | FE-2218 | merged (Comfy-Org#17795) | | 3A-3 | Workshop adapter over `createHostedTopupCheckout` | FE-2214 | merged (Comfy-Org#17793) | | 8 core | `previewSubscribe` command | FE-2331 | merged (Comfy-Org#17797) | | 8 core | Plans + saved payment-methods readers | FE-2331 | Comfy-Org#17798 (review) | | 8 ui | account-ui composables (`usePlans`, `usePaymentMethods`, `usePreviewSubscribe`) | FE-2331 | Comfy-Org#17798 (review) | | 7 | billing-web own-origin session, sign-in, SDK composition | FE-2218 | Comfy-Org#17798 (review) | | 7 | billing-web unit tests in CI (`ci-billing-web-unit.yaml`) | FE-2218 | merged (Comfy-Org#17827); **this PR** (Comfy-Org#17844) self-tests the workflow and adds the flag statuses | | 7 | ingest CORS + top-up return hosts for billing.comfy.org and its previews (Comfy-Org/cloud) | FE-2218 | Comfy-Org/cloud#9512 (approved x2, CI rerun) | | 8 ui | billing-web `/v1` entry routing + subscription / payment-method surfaces | FE-2331 | Comfy-Org#17798 (review) | | 7 | npm publish (`ingest-types`, `account-core`, `billing-contract`), Platform install, billing-web live top-up | FE-2218 | todo | | 6 | Contract tests per generated schema (package layer) | FE-2217 | Comfy-Org#17829 (review) | | 6 | Live E2E per flow × consumer + evidence table | FE-2217 | todo (needs staging flags) | | 5 slice 2 | Subscription flows through the SDK | FE-2216 | todo (plan-change decision) | | follow-up | One `needsCustomerAttention` predicate (from the Comfy-Org#17665 review) | FE-2216 | merged (Comfy-Org#17792) | | follow-up | Opaque `BillingServerCode` (from the Comfy-Org#17656 review) | FE-2227 | Comfy-Org#17794 (review) | | follow-up | `useCredits` clears on `SUPERSEDED` (from the Comfy-Org#17799 review) | FE-2215 | merged (Comfy-Org#17824) | | follow-up | credits / status / capabilities readers fence a late failure as `SUPERSEDED` (from the Comfy-Org#17798 review) | FE-2331 | merged (Comfy-Org#17828) | ```mermaid flowchart LR P3["Phase 3 core lifecycle (merged)"] P4["Phase 4 account-ui (merged)"] P5["Phase 5 slice 1 top-up flag (merged)"] FC["PR 17716 hosted_billing_destination flag (merged)"] HD["PR 17783 hostedDestination port"] SS["PR 17782 scope-source port + credentialed transport"] RN["account-core rename"] RB["billing-contract route builder + return_to"] WS["Workshop adapter"] P8PV["previewSubscribe command"] P8RD["plans + payment-methods readers"] P8["account-ui hosted composables"] BWS["billing-web session + sign-in"] BWV["billing-web /v1 surfaces"] CORS["cloud PR 9512 ingest CORS + return hosts"] PUB["npm publish account-core / billing-contract"] P7["Phase 7 host proof: Platform + billing-web live"] CI["billing-web unit CI: PR 17827 (merged) + PR 17844 follow-up"] P6C["Phase 6 contract tests"] P6["Phase 6 live evidence"] S2["Phase 5 slice 2 subscription"] FU9["customer-attention predicate"] FU11["opaque BillingServerCode"] FU12["useCredits clears on SUPERSEDED"] FU13["reader late-failure fence"] P3 --> HD FC --> HD HD --> RB P3 --> SS SS --> P7 RB --> P7 P3 --> RN RN --> PUB RB --> PUB PUB --> P7 P3 --> P8PV P3 --> P8RD P8PV --> P8 P8RD --> P8 P4 --> P8 P8 --> S2 P8 --> BWS BWS --> BWV RB --> BWV BWV --> P7 CORS --> P7 BWS --> CI CI --> P7 P5 --> P6 P3 --> P6C P5 --> WS P5 --> FU9 P3 --> FU11 P4 --> FU12 P3 --> FU13 style P3 fill:#d4edda,stroke:#155724 style P4 fill:#d4edda,stroke:#155724 style P5 fill:#d4edda,stroke:#155724 style FC fill:#d4edda,stroke:#155724 style SS fill:#d4edda,stroke:#155724 style RB fill:#d4edda,stroke:#155724 style WS fill:#d4edda,stroke:#155724 style FU9 fill:#d4edda,stroke:#155724 style P8PV fill:#d4edda,stroke:#155724 style CI stroke:#0366d6,stroke-width:4px ```
… billing reads (Comfy-Org#17852) Stacked on Comfy-Org#17798 (base branch `jaewon/fe-2331-plans-payment-methods-readers`); merge that first. Comfy-Org#17851 (the `account-core` rename) sits on the same parent: whichever of the two lands second is re-based mechanically (the rename has a replay script). ## Why `fallow audit` on Comfy-Org#17798 reported a clone family across the five billing readers: `credits.ts`, `status.ts`, `capabilities.ts`, `plans.ts` and `paymentMethods.ts` each re-implemented the same fetch-and-fence shape — capture the scope, share one request per scope, release a caller on its own signal, report a late answer (success or failure) as `SUPERSEDED`, and drop a published snapshot on a denial unless the request predates a change the host fenced. Five copies of that logic is five places the Comfy-Org#17828 late-failure fence had to be applied, and the next reader would have been a sixth. ## How One skeleton, `createScopedReader`, owns the request sharing, the caller release, the publish fence and the denial drop. A reader supplies only its route, decoder (`parse`) and projection into a snapshot, plus two optional hooks that absorb the real variants: `cached` (capabilities' freshness window) and `publish` (payment-methods' fenced list, capabilities' publish-as-stale). `setSnapshot` and `fenceInFlight({ detach })` let each reader assemble its own `invalidate` — capabilities fences without detaching, payment methods fences and detaches. The public API of every reader is unchanged in shape and semantics: `index.ts` is untouched and no consumer in `account-ui`, `billing-web` or `src/platform/workspace/billing` changed. Per-reader production size: credits 158→80, status 137→64, plans 163→78, paymentMethods 197→94, capabilities 317→235 lines. Tests: the fence family is proven once in `scopedReader.test.ts` with a five-reader case table (sparse filters for the one reader that paces itself), and each reader keeps only the tests of its own projection — capabilities' freshness, denials, revision invalidation and `resolved_for` checks; payment-methods' three invalidation cases. Coverage went up: status gained the signed-out-in-flight case, plans and payment methods gained dispose, all five gained sign-out-then-read. ## AS-IS / TO-BE No user-facing change; core package internals only. - AS-IS: five readers, each with its own copy of the scope fence; fallow reports 2 clone groups / 46 lines across three of them plus 4 groups spanning all four non-paced readers. - TO-BE: one skeleton, five thin readers; `fallow audit --changed-since <parent>` reports duplication 0 and no clone group above the 3-instance threshold. ## Testing | Gate | Result | | --- | --- | | `packages/account` vitest | 42 files, 659 tests (67 new shared cases replace 82 per-reader copies) | | `packages/account-ui` vitest | 9 files, 41 tests | | `@comfyorg/billing-web` test:unit | 10 files, 90 tests | | `pnpm typecheck`, `lint`, `format`, `knip` | exit 0 | | `fallow audit --changed-since origin/jaewon/fe-2331-plans-payment-methods-readers` | no issues in 13 changed files | ## Where this sits in the plan Billing SDK track FE-2210 ([implementation plan V2](https://app.notion.com/p/3d86d73d36508152b92cdbdfdfe83ac8)). Hybrid model: top-up in-app, subscription management / invoices / payment methods on the hosted billing app. | Phase | Item | Ticket | Status | | --- | --- | --- | --- | | 1-2 | Session core, transport, readers | FE-2211/2212/2213 | merged | | 3 | Operation lifecycle, commands, eight-state projection | FE-2227/2214/2223 | merged (Comfy-Org#17655) | | 4 | `@comfyorg/account-ui` composables + `CheckoutSteps` | FE-2215 | merged (Comfy-Org#17662, Comfy-Org#17663) | | 5 slice 1 | Top-up through the SDK behind `billing_sdk_topup_enabled` | FE-2216 | merged (Comfy-Org#17665) | | rollout C | `hosted_billing_destination` server flag read by the host | FE-2218 | merged (Comfy-Org#17716) | | rollout C | `hostedDestination` port on the lifecycle, value on operation state | FE-2210/2218 | Comfy-Org#17783 (review) | | 7 prep | Scope-source port + credentialed transport (BFF / cookie hosts) | FE-2218 | merged (Comfy-Org#17782) | | 7 prep | `@comfyorg/account` → `@comfyorg/account-core` rename | FE-2218 | Comfy-Org#17851 (review, sibling of this PR on Comfy-Org#17798) | | 7 prep | `billing-contract` route builder + `return_to` registry | FE-2218 | merged (Comfy-Org#17795) | | 3A-3 | Workshop adapter over `createHostedTopupCheckout` | FE-2214 | merged (Comfy-Org#17793) | | 8 core | `previewSubscribe` command | FE-2331 | merged (Comfy-Org#17797) | | 8 core | Plans + saved payment-methods readers | FE-2331 | Comfy-Org#17798 (review) | | 8 ui | account-ui composables (`usePlans`, `usePaymentMethods`, `usePreviewSubscribe`) | FE-2331 | Comfy-Org#17798 (review) | | 7 | billing-web own-origin session, sign-in, SDK composition | FE-2218 | Comfy-Org#17798 (review) | | 7 | billing-web unit tests in CI (`ci-billing-web-unit.yaml`) | FE-2218 | merged (Comfy-Org#17827); Comfy-Org#17844 follow-up (review) | | 7 | ingest CORS + top-up return hosts for billing.comfy.org and its previews (Comfy-Org/cloud) | FE-2218 | merged (Comfy-Org/cloud#9512) | | 8 ui | billing-web `/v1` entry routing + subscription / payment-method surfaces | FE-2331 | Comfy-Org#17798 (review) | | 7 | npm publish (`ingest-types`, `account-core`, `billing-contract`), Platform install, billing-web live top-up | FE-2218 | todo | | 6 | Contract tests per generated schema (package layer) | FE-2217 | Comfy-Org#17829 (review) | | 6 | Live E2E per flow × consumer + evidence table | FE-2217 | todo (needs staging flags) | | 5 slice 2 | Subscription flows through the SDK | FE-2216 | todo (plan-change decision) | | follow-up | One `needsCustomerAttention` predicate (from the Comfy-Org#17665 review) | FE-2216 | merged (Comfy-Org#17792) | | follow-up | Opaque `BillingServerCode` (from the Comfy-Org#17656 review) | FE-2227 | merged (Comfy-Org#17794) | | follow-up | `useCredits` clears on `SUPERSEDED` (from the Comfy-Org#17799 review) | FE-2215 | merged (Comfy-Org#17824) | | follow-up | credits / status / capabilities readers fence a late failure as `SUPERSEDED` (from the Comfy-Org#17798 review) | FE-2331 | merged (Comfy-Org#17828) | | follow-up | one scoped-reader skeleton behind the five billing reads (from the Comfy-Org#17798 fallow report) | FE-2331 | **this PR** | ```mermaid flowchart LR P3["Phase 3 core lifecycle (merged)"] P4["Phase 4 account-ui (merged)"] P5["Phase 5 slice 1 top-up flag (merged)"] FC["PR 17716 hosted_billing_destination flag (merged)"] HD["PR 17783 hostedDestination port"] SS["PR 17782 scope-source port + credentialed transport"] RN["account-core rename"] RB["billing-contract route builder + return_to"] WS["Workshop adapter"] P8PV["previewSubscribe command"] P8RD["plans + payment-methods readers"] P8["account-ui hosted composables"] BWS["billing-web session + sign-in"] BWV["billing-web /v1 surfaces"] CORS["cloud PR 9512 ingest CORS + return hosts"] PUB["npm publish account-core / billing-contract"] P7["Phase 7 host proof: Platform + billing-web live"] P6C["Phase 6 contract tests"] P6["Phase 6 live evidence"] S2["Phase 5 slice 2 subscription"] FU9["customer-attention predicate"] FU11["opaque BillingServerCode"] FU12["useCredits clears on SUPERSEDED"] FU13["reader late-failure fence"] FU14["scoped reader skeleton"] P3 --> HD FC --> HD HD --> RB P3 --> SS SS --> P7 RB --> P7 P3 --> RN RN --> PUB RB --> PUB PUB --> P7 P3 --> P8PV P3 --> P8RD P8PV --> P8 P8RD --> P8 P4 --> P8 P8 --> S2 P8 --> BWS BWS --> BWV RB --> BWV BWV --> P7 CORS --> P7 P5 --> P6 P3 --> P6C P5 --> WS P5 --> FU9 P3 --> FU11 P4 --> FU12 P3 --> FU13 P8RD --> FU14 FU13 --> FU14 style P3 fill:#d4edda,stroke:#155724 style P4 fill:#d4edda,stroke:#155724 style P5 fill:#d4edda,stroke:#155724 style FC fill:#d4edda,stroke:#155724 style SS fill:#d4edda,stroke:#155724 style RB fill:#d4edda,stroke:#155724 style WS fill:#d4edda,stroke:#155724 style FU9 fill:#d4edda,stroke:#155724 style FU11 fill:#d4edda,stroke:#155724 style FU12 fill:#d4edda,stroke:#155724 style FU13 fill:#d4edda,stroke:#155724 style CORS fill:#d4edda,stroke:#155724 style P8PV fill:#d4edda,stroke:#155724 style FU14 stroke:#0366d6,stroke-width:4px ```
…the SDK rail behind billing_sdk_subscription_enabled (#17853) Stacked on #17783 (base branch `jaewon/fe-2210-hosted-destination-port`); merge that first. Phase 5 slice 1 (#17665) moved top-up onto the Billing SDK behind `billing_sdk_topup_enabled`. The subscription actions the host already owns — cancel, resubscribe, and opening the payment portal — still call the workspace API directly and rely on the legacy poller for settlement and telemetry. This slice moves those three onto the SDK's commands behind their own server flag, `billing_sdk_subscription_enabled` (already on `/api/features` via Comfy-Org/cloud#9248, PostHog at 0%), so the eight-state lifecycle, idempotency, recovery and telemetry come from one implementation. Subscribe and plan change are slice 2b, stacked on this PR. - **Rail switch.** `billingSdkSubscriptionRailEnabled` = `billing_sdk_subscription_enabled` AND `unified_cloud_auth`, exactly like the top-up rail. `useSubscriptionRail()` reads it once, synchronously, at the start of an action, so a flag flip mid-flow cannot issue on one rail and observe on the other. - **Three actions, one adapter.** `useWorkspaceBilling.cancelSubscription / resubscribe / manageSubscription` try the rail first; the store runs `sdk.commands.cancelSubscription()`, `resubscribe()`, `openPaymentPortal({ returnUrl })` and projects the result onto what the adapter already does with the legacy calls: settle, or throw a `WorkspaceApiError` (message is the host's, since the SDK never carries server text; `serverCode` lands in `.code`). A command that settles in any phase but `succeeded` is a failure, matching the poller. The refresh after success mirrors the poller's: cancel → status + balance + capabilities; resubscribe → `reconcileSubscriptionSuccess` + capabilities. - **Fallback.** A 404 (backend gate closed while the client flag is on) projects to `unavailable`: the adapter runs its legacy body for that action, and the store latches the route as unavailable for the tab so later actions go straight to legacy without another failed round trip. Every other failure — including `SUPERSEDED` — is thrown, never retried on legacy, so a late or superseded result cannot double-issue. - **Telemetry.** Lifecycle events are now reported for non-topup operations (top-up keeps its resumed-only filter because its dialog reports). `toBillingTelemetryEvent` already emits the poller's payload shape, so dashboards cannot tell the rails apart. - **No client-derived server state.** Eligibility and already-held answers come from the SDK and the server, as for top-up. `subscribe`, `previewSubscribe`, `useSubscriptionCheckout` and `useLegacyBilling` are untouched. | State | AS-IS (flag off) | TO-BE (flag on) | | --- | --- | --- | | Cancel dialog at rest | <img width="480" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/as-is-cancel-dialog.png"> | <img width="480" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/to-be-cancel-dialog.png"> | | Cancel in flight | <img width="480" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/as-is-cancel-in-flight.png"> | <img width="480" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/to-be-cancel-in-flight.png"> | | Cancel settled (success toast) | <img width="480" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/as-is-cancel-settled.png"> | <img width="480" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/to-be-cancel-settled.png"> | | Cancel failed (error toast) | <img width="480" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/as-is-cancel-failed.png"> | <img width="480" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/to-be-cancel-failed.png"> | | User popover after cancel (cancelled state) | <img width="480" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/as-is-panel-after-cancel.png"> | <img width="480" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/to-be-panel-after-cancel.png"> | | Cancel request recorded | <img width="480" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/as-is-network.png"> | <img width="480" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/to-be-network.png"> | | Settings billing panel | <img width="480" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/as-is-billing-panel.png"> | <img width="480" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/to-be-billing-panel.png"> | | Resubscribe (Resume Pro) | <img width="480" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/as-is-resubscribe.png"> | <img width="480" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/to-be-resubscribe.png"> | | Resubscribe request recorded | <img width="480" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/as-is-resubscribe-network.png"> | <img width="480" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/to-be-resubscribe-network.png"> | | Payment-portal request recorded | <img width="480" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/as-is-portal-network.png"> | <img width="480" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/to-be-portal-network.png"> | - AS-IS (flag off): cancel / resubscribe / portal POST the workspace API directly; settlement and telemetry come from the legacy poller. - TO-BE (flag on): the same dialogs and toasts, the POSTs go through the SDK transport (`Idempotency-Key` on the request), settlement through the operation lifecycle; a 404 falls back to the legacy call. | Gate | Result | | --- | --- | | `vitest run src/platform/workspace/billing src/composables/billing src/platform/workspace/composables src/platform/workspace/stores src/composables/useFeatureFlags` | 41 files, 1138 tests (12 new projection tests, 13 new adapter rail tests, +5 store tests) | | `pnpm typecheck`, `pnpm typecheck:browser`, `lint`, `format:check`, `knip` | exit 0 | | `fallow audit --changed-since origin/jaewon/fe-2210-hosted-destination-port` | no issues in 11 changed files, complexity 0, duplication 0 | | Playwright `browser_tests/tests/dialogs/cancelSubscriptionSdkRail.spec.ts` (cloud project) | **3 passed** against a served cloud dev build — `PLAYWRIGHT_TEST_URL=http://localhost:5173 pnpm exec playwright test --project=cloud browser_tests/tests/dialogs/cancelSubscriptionSdkRail.spec.ts --reporter=list`. Flag off → legacy request, flow unchanged; flag on → SDK request (`Idempotency-Key`), same dialog outcome; flag on + 404 → legacy fallback. | Billing SDK track FE-2210 ([implementation plan V2](https://app.notion.com/p/3d86d73d36508152b92cdbdfdfe83ac8)). Hybrid model: top-up in-app, subscription management / invoices / payment methods on the hosted billing app. | Phase | Item | Ticket | Status | | --- | --- | --- | --- | | 1-2 | Session core, transport, readers | FE-2211/2212/2213 | merged | | 3 | Operation lifecycle, commands, eight-state projection | FE-2227/2214/2223 | merged (#17655) | | 4 | `@comfyorg/account-ui` composables + `CheckoutSteps` | FE-2215 | merged (#17662, #17663) | | 5 slice 1 | Top-up through the SDK behind `billing_sdk_topup_enabled` | FE-2216 | merged (#17665) | | rollout C | `hosted_billing_destination` server flag read by the host | FE-2218 | merged (#17716) | | rollout C | `hostedDestination` port on the lifecycle, value on operation state | FE-2210/2218 | #17783 (review; parent of this PR) | | 7 prep | Scope-source port + credentialed transport (BFF / cookie hosts) | FE-2218 | merged (#17782) | | 7 prep | `@comfyorg/account` → `@comfyorg/account-core` rename | FE-2218 | #17851 (review) | | 7 prep | `billing-contract` route builder + `return_to` registry | FE-2218 | merged (#17795) | | 3A-3 | Workshop adapter over `createHostedTopupCheckout` | FE-2214 | merged (#17793) | | 8 core | `previewSubscribe` command | FE-2331 | merged (#17797) | | 8 core | Plans + saved payment-methods readers | FE-2331 | #17798 (queued) | | 8 ui | account-ui composables (`usePlans`, `usePaymentMethods`, `usePreviewSubscribe`) | FE-2331 | #17798 (queued) | | 7 | billing-web own-origin session, sign-in, SDK composition | FE-2218 | #17798 (queued) | | 7 | billing-web unit tests in CI (`ci-billing-web-unit.yaml`) | FE-2218 | merged (#17827); #17844 (queued) | | 7 | ingest CORS + top-up return hosts for billing.comfy.org and its previews (Comfy-Org/cloud) | FE-2218 | merged (Comfy-Org/cloud#9512) | | 8 ui | billing-web `/v1` entry routing + subscription / payment-method surfaces | FE-2331 | #17798 (queued) | | 7 | npm publish (`ingest-types`, `account-core`, `billing-contract`), Platform install, billing-web live top-up | FE-2218 | todo | | 6 | Contract tests per generated schema (package layer) | FE-2217 | | 6 | Live E2E per flow × consumer + evidence table | FE-2217 | todo (needs staging flags) | | 5 slice 2a | Cancel, resubscribe and payment portal through the SDK behind `billing_sdk_subscription_enabled` | FE-2216 | **this PR** | | 5 slice 2b | Subscribe / plan change through the SDK (`previewSubscribe` quote, then subscribe; the SDK stops short-circuiting an active plan) | FE-2216 | next, stacked on this PR | | follow-up | One `needsCustomerAttention` predicate (from the #17665 review) | FE-2216 | merged (#17792) | | follow-up | Opaque `BillingServerCode` (from the #17656 review) | FE-2227 | merged (#17794) | | follow-up | `useCredits` clears on `SUPERSEDED` (from the #17799 review) | FE-2215 | merged (#17824) | | follow-up | credits / status / capabilities readers fence a late failure as `SUPERSEDED` (from the #17798 review) | FE-2331 | merged (#17828) | ```mermaid flowchart LR P3["Phase 3 core lifecycle (merged)"] P4["Phase 4 account-ui (merged)"] P5["Phase 5 slice 1 top-up flag (merged)"] FC["PR 17716 hosted_billing_destination flag (merged)"] HD["PR 17783 hostedDestination port"] SS["PR 17782 scope-source port + credentialed transport"] RN["account-core rename"] RB["billing-contract route builder + return_to"] WS["Workshop adapter"] P8PV["previewSubscribe command"] P8RD["plans + payment-methods readers"] P8["account-ui hosted composables"] BWS["billing-web session + sign-in"] BWV["billing-web /v1 surfaces"] CORS["cloud PR 9512 ingest CORS + return hosts"] PUB["npm publish account-core / billing-contract"] P7["Phase 7 host proof: Platform + billing-web live"] P6C["Phase 6 contract tests"] P6["Phase 6 live evidence"] S2A["Phase 5 slice 2a cancel / resubscribe / portal rail"] S2B["Phase 5 slice 2b subscribe + plan change"] FU9["customer-attention predicate"] FU11["opaque BillingServerCode"] FU12["useCredits clears on SUPERSEDED"] FU13["reader late-failure fence"] P3 --> HD FC --> HD HD --> RB P3 --> SS SS --> P7 RB --> P7 P3 --> RN RN --> PUB RB --> PUB PUB --> P7 P3 --> P8PV P3 --> P8RD P8PV --> P8 P8RD --> P8 P4 --> P8 P8 --> S2B HD --> S2A S2A --> S2B P8 --> BWS BWS --> BWV RB --> BWV BWV --> P7 CORS --> P7 P5 --> P6 P3 --> P6C P5 --> WS P5 --> FU9 P3 --> FU11 P4 --> FU12 P3 --> FU13 style P3 fill:#d4edda,stroke:#155724 style P4 fill:#d4edda,stroke:#155724 style P5 fill:#d4edda,stroke:#155724 style FC fill:#d4edda,stroke:#155724 style SS fill:#d4edda,stroke:#155724 style RB fill:#d4edda,stroke:#155724 style WS fill:#d4edda,stroke:#155724 style FU9 fill:#d4edda,stroke:#155724 style FU11 fill:#d4edda,stroke:#155724 style FU12 fill:#d4edda,stroke:#155724 style FU13 fill:#d4edda,stroke:#155724 style CORS fill:#d4edda,stroke:#155724 style P8PV fill:#d4edda,stroke:#155724 style S2A stroke:#0366d6,stroke-width:4px ```
…the SDK rail behind billing_sdk_subscription_enabled (#17853) Stacked on #17783 (base branch `jaewon/fe-2210-hosted-destination-port`); merge that first. Phase 5 slice 1 (#17665) moved top-up onto the Billing SDK behind `billing_sdk_topup_enabled`. The subscription actions the host already owns — cancel, resubscribe, and opening the payment portal — still call the workspace API directly and rely on the legacy poller for settlement and telemetry. This slice moves those three onto the SDK's commands behind their own server flag, `billing_sdk_subscription_enabled` (already on `/api/features` via Comfy-Org/cloud#9248, PostHog at 0%), so the eight-state lifecycle, idempotency, recovery and telemetry come from one implementation. Subscribe and plan change are slice 2b, stacked on this PR. - **Rail switch.** `billingSdkSubscriptionRailEnabled` = `billing_sdk_subscription_enabled` AND `unified_cloud_auth`, exactly like the top-up rail. `useSubscriptionRail()` reads it once, synchronously, at the start of an action, so a flag flip mid-flow cannot issue on one rail and observe on the other. - **Three actions, one adapter.** `useWorkspaceBilling.cancelSubscription / resubscribe / manageSubscription` try the rail first; the store runs `sdk.commands.cancelSubscription()`, `resubscribe()`, `openPaymentPortal({ returnUrl })` and projects the result onto what the adapter already does with the legacy calls: settle, or throw a `WorkspaceApiError` (message is the host's, since the SDK never carries server text; `serverCode` lands in `.code`). A command that settles in any phase but `succeeded` is a failure, matching the poller. The refresh after success mirrors the poller's: cancel → status + balance + capabilities; resubscribe → `reconcileSubscriptionSuccess` + capabilities. - **Fallback.** A 404 (backend gate closed while the client flag is on) projects to `unavailable`: the adapter runs its legacy body for that action, and the store latches the route as unavailable for the tab so later actions go straight to legacy without another failed round trip. Every other failure — including `SUPERSEDED` — is thrown, never retried on legacy, so a late or superseded result cannot double-issue. - **Telemetry.** Lifecycle events are now reported for non-topup operations (top-up keeps its resumed-only filter because its dialog reports). `toBillingTelemetryEvent` already emits the poller's payload shape, so dashboards cannot tell the rails apart. - **No client-derived server state.** Eligibility and already-held answers come from the SDK and the server, as for top-up. `subscribe`, `previewSubscribe`, `useSubscriptionCheckout` and `useLegacyBilling` are untouched. | State | AS-IS (flag off) | TO-BE (flag on) | | --- | --- | --- | | Cancel dialog at rest | <img width="480" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/as-is-cancel-dialog.png"> | <img width="480" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/to-be-cancel-dialog.png"> | | Cancel in flight | <img width="480" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/as-is-cancel-in-flight.png"> | <img width="480" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/to-be-cancel-in-flight.png"> | | Cancel settled (success toast) | <img width="480" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/as-is-cancel-settled.png"> | <img width="480" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/to-be-cancel-settled.png"> | | Cancel failed (error toast) | <img width="480" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/as-is-cancel-failed.png"> | <img width="480" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/to-be-cancel-failed.png"> | | User popover after cancel (cancelled state) | <img width="480" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/as-is-panel-after-cancel.png"> | <img width="480" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/to-be-panel-after-cancel.png"> | | Cancel request recorded | <img width="480" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/as-is-network.png"> | <img width="480" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/to-be-network.png"> | | Settings billing panel | <img width="480" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/as-is-billing-panel.png"> | <img width="480" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/to-be-billing-panel.png"> | | Resubscribe (Resume Pro) | <img width="480" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/as-is-resubscribe.png"> | <img width="480" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/to-be-resubscribe.png"> | | Resubscribe request recorded | <img width="480" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/as-is-resubscribe-network.png"> | <img width="480" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/to-be-resubscribe-network.png"> | | Payment-portal request recorded | <img width="480" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/as-is-portal-network.png"> | <img width="480" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/to-be-portal-network.png"> | - AS-IS (flag off): cancel / resubscribe / portal POST the workspace API directly; settlement and telemetry come from the legacy poller. - TO-BE (flag on): the same dialogs and toasts, the POSTs go through the SDK transport (`Idempotency-Key` on the request), settlement through the operation lifecycle; a 404 falls back to the legacy call. | Gate | Result | | --- | --- | | `vitest run src/platform/workspace/billing src/composables/billing src/platform/workspace/composables src/platform/workspace/stores src/composables/useFeatureFlags` | 41 files, 1138 tests (12 new projection tests, 13 new adapter rail tests, +5 store tests) | | `pnpm typecheck`, `pnpm typecheck:browser`, `lint`, `format:check`, `knip` | exit 0 | | `fallow audit --changed-since origin/jaewon/fe-2210-hosted-destination-port` | no issues in 11 changed files, complexity 0, duplication 0 | | Playwright `browser_tests/tests/dialogs/cancelSubscriptionSdkRail.spec.ts` (cloud project) | **3 passed** against a served cloud dev build — `PLAYWRIGHT_TEST_URL=http://localhost:5173 pnpm exec playwright test --project=cloud browser_tests/tests/dialogs/cancelSubscriptionSdkRail.spec.ts --reporter=list`. Flag off → legacy request, flow unchanged; flag on → SDK request (`Idempotency-Key`), same dialog outcome; flag on + 404 → legacy fallback. | Billing SDK track FE-2210 ([implementation plan V2](https://app.notion.com/p/3d86d73d36508152b92cdbdfdfe83ac8)). Hybrid model: top-up in-app, subscription management / invoices / payment methods on the hosted billing app. | Phase | Item | Ticket | Status | | --- | --- | --- | --- | | 1-2 | Session core, transport, readers | FE-2211/2212/2213 | merged | | 3 | Operation lifecycle, commands, eight-state projection | FE-2227/2214/2223 | merged (#17655) | | 4 | `@comfyorg/account-ui` composables + `CheckoutSteps` | FE-2215 | merged (#17662, #17663) | | 5 slice 1 | Top-up through the SDK behind `billing_sdk_topup_enabled` | FE-2216 | merged (#17665) | | rollout C | `hosted_billing_destination` server flag read by the host | FE-2218 | merged (#17716) | | rollout C | `hostedDestination` port on the lifecycle, value on operation state | FE-2210/2218 | #17783 (review; parent of this PR) | | 7 prep | Scope-source port + credentialed transport (BFF / cookie hosts) | FE-2218 | merged (#17782) | | 7 prep | `@comfyorg/account` → `@comfyorg/account-core` rename | FE-2218 | #17851 (review) | | 7 prep | `billing-contract` route builder + `return_to` registry | FE-2218 | merged (#17795) | | 3A-3 | Workshop adapter over `createHostedTopupCheckout` | FE-2214 | merged (#17793) | | 8 core | `previewSubscribe` command | FE-2331 | merged (#17797) | | 8 core | Plans + saved payment-methods readers | FE-2331 | #17798 (queued) | | 8 ui | account-ui composables (`usePlans`, `usePaymentMethods`, `usePreviewSubscribe`) | FE-2331 | #17798 (queued) | | 7 | billing-web own-origin session, sign-in, SDK composition | FE-2218 | #17798 (queued) | | 7 | billing-web unit tests in CI (`ci-billing-web-unit.yaml`) | FE-2218 | merged (#17827); #17844 (queued) | | 7 | ingest CORS + top-up return hosts for billing.comfy.org and its previews (Comfy-Org/cloud) | FE-2218 | merged (Comfy-Org/cloud#9512) | | 8 ui | billing-web `/v1` entry routing + subscription / payment-method surfaces | FE-2331 | #17798 (queued) | | 7 | npm publish (`ingest-types`, `account-core`, `billing-contract`), Platform install, billing-web live top-up | FE-2218 | todo | | 6 | Contract tests per generated schema (package layer) | FE-2217 | | 6 | Live E2E per flow × consumer + evidence table | FE-2217 | todo (needs staging flags) | | 5 slice 2a | Cancel, resubscribe and payment portal through the SDK behind `billing_sdk_subscription_enabled` | FE-2216 | **this PR** | | 5 slice 2b | Subscribe / plan change through the SDK (`previewSubscribe` quote, then subscribe; the SDK stops short-circuiting an active plan) | FE-2216 | next, stacked on this PR | | follow-up | One `needsCustomerAttention` predicate (from the #17665 review) | FE-2216 | merged (#17792) | | follow-up | Opaque `BillingServerCode` (from the #17656 review) | FE-2227 | merged (#17794) | | follow-up | `useCredits` clears on `SUPERSEDED` (from the #17799 review) | FE-2215 | merged (#17824) | | follow-up | credits / status / capabilities readers fence a late failure as `SUPERSEDED` (from the #17798 review) | FE-2331 | merged (#17828) | ```mermaid flowchart LR P3["Phase 3 core lifecycle (merged)"] P4["Phase 4 account-ui (merged)"] P5["Phase 5 slice 1 top-up flag (merged)"] FC["PR 17716 hosted_billing_destination flag (merged)"] HD["PR 17783 hostedDestination port"] SS["PR 17782 scope-source port + credentialed transport"] RN["account-core rename"] RB["billing-contract route builder + return_to"] WS["Workshop adapter"] P8PV["previewSubscribe command"] P8RD["plans + payment-methods readers"] P8["account-ui hosted composables"] BWS["billing-web session + sign-in"] BWV["billing-web /v1 surfaces"] CORS["cloud PR 9512 ingest CORS + return hosts"] PUB["npm publish account-core / billing-contract"] P7["Phase 7 host proof: Platform + billing-web live"] P6C["Phase 6 contract tests"] P6["Phase 6 live evidence"] S2A["Phase 5 slice 2a cancel / resubscribe / portal rail"] S2B["Phase 5 slice 2b subscribe + plan change"] FU9["customer-attention predicate"] FU11["opaque BillingServerCode"] FU12["useCredits clears on SUPERSEDED"] FU13["reader late-failure fence"] P3 --> HD FC --> HD HD --> RB P3 --> SS SS --> P7 RB --> P7 P3 --> RN RN --> PUB RB --> PUB PUB --> P7 P3 --> P8PV P3 --> P8RD P8PV --> P8 P8RD --> P8 P4 --> P8 P8 --> S2B HD --> S2A S2A --> S2B P8 --> BWS BWS --> BWV RB --> BWV BWV --> P7 CORS --> P7 P5 --> P6 P3 --> P6C P5 --> WS P5 --> FU9 P3 --> FU11 P4 --> FU12 P3 --> FU13 style P3 fill:#d4edda,stroke:#155724 style P4 fill:#d4edda,stroke:#155724 style P5 fill:#d4edda,stroke:#155724 style FC fill:#d4edda,stroke:#155724 style SS fill:#d4edda,stroke:#155724 style RB fill:#d4edda,stroke:#155724 style WS fill:#d4edda,stroke:#155724 style FU9 fill:#d4edda,stroke:#155724 style FU11 fill:#d4edda,stroke:#155724 style FU12 fill:#d4edda,stroke:#155724 style FU13 fill:#d4edda,stroke:#155724 style CORS fill:#d4edda,stroke:#155724 style P8PV fill:#d4edda,stroke:#155724 style S2A stroke:#0366d6,stroke-width:4px ```
…unt-core (Comfy-Org#17851) Stacked on Comfy-Org#17798 (base branch `jaewon/fe-2331-plans-payment-methods-readers`); merge that first, then this rebases to `main` with no content change. ## Why Phase 7 (FE-2218) publishes the framework-free billing core to npm so Platform can install it from a clean non-workspace checkout, and the plan fixes the physical `account-core` / `account-ui` split as the boundary that gets published, not the transitional `packages/account`. The view package `@comfyorg/account-ui` already exists; the core still carries the old name. This is the one mechanical rename PR the plan schedules after Phase 5 slice 1 and before the first publish. ## How Two commits so the review is trivial: 1. `git mv packages/account packages/account-core` — 95 files, 0 insertions, 0 deletions, every path a 100% rename. 2. The specifier and config edits — package name `@comfyorg/account` → `@comfyorg/account-core`, every `workspace:*` dependency (root, `apps/billing-web`, `apps/website`, `packages/account-ui`), every import specifier under `src/`, `packages/`, `apps/`, `browser_tests/`, the root `typecheck` / `lint` scripts (`typecheck:account` → `typecheck:account-core`), `knip.config.ts`, `eslint.config.ts`, the per-package loop and codecov file list in `ci-tests-unit.yaml`, the lockfile importer keys, and the two ADRs that name the package in prose. The delta over a 1:1 swap is oxfmt reflowing import lines the five extra characters pushed past 80 columns. Left alone on purpose: the `./vue` entry (the auth Vue pieces move to `account-ui` in the next PR of this stack), the Firebase app name `comfy-account` in ADR-0028, and the ADR filenames and headings (renaming those would break the ADR index and inbound links). `git grep "@comfyorg/account\b"` and `git grep "packages/account/"` return nothing after this change. The replay script lives under `temp/scripts/rename-account-core.sh` (gitignored); if a sibling PR merges first, re-running it on a fresh base reproduces this diff. ## AS-IS / TO-BE No user-facing change; package boundary only. - AS-IS: `packages/account` publishes as `@comfyorg/account` and is the name Platform would have to install, while the view layer is already `@comfyorg/account-ui`. - TO-BE: `packages/account-core` publishes as `@comfyorg/account-core`; `account-ui` and `billing-web` depend on it by the final name. ## Testing | Gate | Result | | --- | --- | | `pnpm install --frozen-lockfile` | resolves with the new name | | `packages/account-core` vitest | 41 files, 674 tests | | `packages/account-ui` vitest | 9 files, 41 tests | | `@comfyorg/billing-web` test:unit / build | 10 files, 90 tests / built | | `@comfyorg/website` typecheck | 0 errors | | root `pnpm typecheck`, `lint`, `format`, `knip` | all exit 0 | | `vitest run src/platform/workspace/billing` | 5 files, 50 tests | | `pnpm typecheck:browser`, `typecheck:website` (pre-commit) | green | ## Where this sits in the plan Billing SDK track FE-2210 ([implementation plan V2](https://app.notion.com/p/3d86d73d36508152b92cdbdfdfe83ac8)). Hybrid model: top-up in-app, subscription management / invoices / payment methods on the hosted billing app. | Phase | Item | Ticket | Status | | --- | --- | --- | --- | | 1-2 | Session core, transport, readers | FE-2211/2212/2213 | merged | | 3 | Operation lifecycle, commands, eight-state projection | FE-2227/2214/2223 | merged (Comfy-Org#17655) | | 4 | `@comfyorg/account-ui` composables + `CheckoutSteps` | FE-2215 | merged (Comfy-Org#17662, Comfy-Org#17663) | | 5 slice 1 | Top-up through the SDK behind `billing_sdk_topup_enabled` | FE-2216 | merged (Comfy-Org#17665) | | rollout C | `hosted_billing_destination` server flag read by the host | FE-2218 | merged (Comfy-Org#17716) | | rollout C | `hostedDestination` port on the lifecycle, value on operation state | FE-2210/2218 | Comfy-Org#17783 (review) | | 7 prep | Scope-source port + credentialed transport (BFF / cookie hosts) | FE-2218 | merged (Comfy-Org#17782) | | 7 prep | `@comfyorg/account` → `@comfyorg/account-core` rename | FE-2218 | **this PR** | | 7 prep | `billing-contract` route builder + `return_to` registry | FE-2218 | merged (Comfy-Org#17795) | | 3A-3 | Workshop adapter over `createHostedTopupCheckout` | FE-2214 | merged (Comfy-Org#17793) | | 8 core | `previewSubscribe` command | FE-2331 | merged (Comfy-Org#17797) | | 8 core | Plans + saved payment-methods readers | FE-2331 | Comfy-Org#17798 (review) | | 8 ui | account-ui composables (`usePlans`, `usePaymentMethods`, `usePreviewSubscribe`) | FE-2331 | Comfy-Org#17798 (review) | | 7 | billing-web own-origin session, sign-in, SDK composition | FE-2218 | Comfy-Org#17798 (review) | | 7 | billing-web unit tests in CI (`ci-billing-web-unit.yaml`) | FE-2218 | merged (Comfy-Org#17827); Comfy-Org#17844 follow-up (review) | | 7 | ingest CORS + top-up return hosts for billing.comfy.org and its previews (Comfy-Org/cloud) | FE-2218 | merged (Comfy-Org/cloud#9512) | | 8 ui | billing-web `/v1` entry routing + subscription / payment-method surfaces | FE-2331 | Comfy-Org#17798 (review) | | 7 | npm publish (`ingest-types`, `account-core`, `billing-contract`), Platform install, billing-web live top-up | FE-2218 | todo | | 6 | Contract tests per generated schema (package layer) | FE-2217 | Comfy-Org#17829 (review) | | 6 | Live E2E per flow × consumer + evidence table | FE-2217 | todo (needs staging flags) | | 5 slice 2 | Subscription flows through the SDK | FE-2216 | todo (plan-change decision) | | follow-up | One `needsCustomerAttention` predicate (from the Comfy-Org#17665 review) | FE-2216 | merged (Comfy-Org#17792) | | follow-up | Opaque `BillingServerCode` (from the Comfy-Org#17656 review) | FE-2227 | merged (Comfy-Org#17794) | | follow-up | `useCredits` clears on `SUPERSEDED` (from the Comfy-Org#17799 review) | FE-2215 | merged (Comfy-Org#17824) | | follow-up | credits / status / capabilities readers fence a late failure as `SUPERSEDED` (from the Comfy-Org#17798 review) | FE-2331 | merged (Comfy-Org#17828) | ```mermaid flowchart LR P3["Phase 3 core lifecycle (merged)"] P4["Phase 4 account-ui (merged)"] P5["Phase 5 slice 1 top-up flag (merged)"] FC["PR 17716 hosted_billing_destination flag (merged)"] HD["PR 17783 hostedDestination port"] SS["PR 17782 scope-source port + credentialed transport"] RN["account-core rename"] RB["billing-contract route builder + return_to"] WS["Workshop adapter"] P8PV["previewSubscribe command"] P8RD["plans + payment-methods readers"] P8["account-ui hosted composables"] BWS["billing-web session + sign-in"] BWV["billing-web /v1 surfaces"] CORS["cloud PR 9512 ingest CORS + return hosts"] PUB["npm publish account-core / billing-contract"] P7["Phase 7 host proof: Platform + billing-web live"] P6C["Phase 6 contract tests"] P6["Phase 6 live evidence"] S2["Phase 5 slice 2 subscription"] FU9["customer-attention predicate"] FU11["opaque BillingServerCode"] FU12["useCredits clears on SUPERSEDED"] FU13["reader late-failure fence"] P3 --> HD FC --> HD HD --> RB P3 --> SS SS --> P7 RB --> P7 P3 --> RN RN --> PUB RB --> PUB PUB --> P7 P3 --> P8PV P3 --> P8RD P8PV --> P8 P8RD --> P8 P4 --> P8 P8 --> S2 P8 --> BWS BWS --> BWV RB --> BWV BWV --> P7 CORS --> P7 P5 --> P6 P3 --> P6C P5 --> WS P5 --> FU9 P3 --> FU11 P4 --> FU12 P3 --> FU13 style P3 fill:#d4edda,stroke:#155724 style P4 fill:#d4edda,stroke:#155724 style P5 fill:#d4edda,stroke:#155724 style FC fill:#d4edda,stroke:#155724 style SS fill:#d4edda,stroke:#155724 style RB fill:#d4edda,stroke:#155724 style WS fill:#d4edda,stroke:#155724 style FU9 fill:#d4edda,stroke:#155724 style FU11 fill:#d4edda,stroke:#155724 style FU12 fill:#d4edda,stroke:#155724 style FU13 fill:#d4edda,stroke:#155724 style CORS fill:#d4edda,stroke:#155724 style P8PV fill:#d4edda,stroke:#155724 style RN stroke:#0366d6,stroke-width:4px ```
…ling core (Comfy-Org#17854) Stacked on Comfy-Org#17851 (base branch `jaewon/fe-2218-account-core-rename`), which stacks on Comfy-Org#17798; merge those first. ## Why The plan's first decision was that the Vue layer leaves the account package: composables and unstyled components ship from `@comfyorg/account-ui`, and the core keeps zero Vue coupling by construction rather than by an import-guard test. The auth Vue pieces (`PasswordRules`, `SocialAuthButtons`, `TurnstileWidget`, the region and Turnstile gates, the lifecycle scope and generation guard) had shipped in the core's `./vue` entry days before that decision and were deliberately left for a later follow-up so the fresh auth stack was not destabilised. With the rename in Comfy-Org#17851 fixing `account-core` as the boundary that gets published (Phase 7), this is that follow-up: the published core must not drag `vue`, `@vueuse/core` or a `.vue` entry to Platform. ## How - `packages/account-core/src/vue/**` → `packages/account-ui/src/auth/**` with `git mv` (7 modules + their 7 tests; git records every file as a rename). The framework-free helpers stay in the core and keep their public subpaths (`/signInSchemas`, `/turnstileScript`, `/boundedOperation`); the moved files reach them through those. - `@comfyorg/account-ui` gains per-module `./auth/*` exports (mirroring how consumers already import these individually and how the app-side test mocks target one module each) plus the two workspace deps the moved files need (`@comfyorg/shared-frontend-utils`, `@comfyorg/tailwind-utils`; both fine in the view package, neither allowed in the core). - The core drops the `./vue/*` exports, `vue`, `@vueuse/core`, `vue-tsc`, `@vitejs/plugin-vue`, `@testing-library/vue|user-event`, `@comfyorg/tailwind-utils` and the `peerDependenciesMeta` block; `typecheck` becomes `tsc --noEmit`; the vitest `account-vue` project becomes `account-firebase` (happy-dom for `src/firebase/**` only). - `vueBoundary.test.ts` now proves the boundary three ways: no `vue` / `@vueuse` import anywhere under `src` (the old `vue/` carve-out is gone), no Vue dependency in any manifest field, and no `.vue` file behind any export. - 17 import sites in 13 files repointed (`apps/billing-web`, `apps/website`, `src/`); root and `apps/website` gain `@comfyorg/account-ui: workspace:*`. A pure `git mv` commit was not possible: the pre-commit hook lints and type-checks the staged tree, and a rename without repoints leaves 17 unresolved imports. Commit 1 is therefore the rename plus the mechanical repoints; commit 2 is the boundary guard. ## AS-IS / TO-BE No user-facing change; package boundary only. - AS-IS: `@comfyorg/account-core` exports `./vue/*` and depends on `vue`; a Platform install of the core would pull Vue and `.vue` files. - TO-BE: `@comfyorg/account-core` has no view entry and no Vue dependency; the sign-in pieces ship from `@comfyorg/account-ui/auth/*` next to `./billing`. ## Testing | Gate | Result | | --- | --- | | `packages/account-core` vitest | 34 files, 638 tests | | `packages/account-ui` vitest | 16 files, 79 tests (7 moved suites) | | `@comfyorg/billing-web` test:unit / build | 10 files, 90 tests / built | | `@comfyorg/website` typecheck | 0 errors | | root `pnpm typecheck`, `lint`, `format`, `knip` | exit 0 | | `vitest run src/components/dialog/content/signin src/components/auth src/platform/workspace/billing` | 11 files, 94 tests | | `git grep "account-core/vue"` | no matches | ## Where this sits in the plan Billing SDK track FE-2210 ([implementation plan V2](https://app.notion.com/p/3d86d73d36508152b92cdbdfdfe83ac8)). Hybrid model: top-up in-app, subscription management / invoices / payment methods on the hosted billing app. | Phase | Item | Ticket | Status | | --- | --- | --- | --- | | 1-2 | Session core, transport, readers | FE-2211/2212/2213 | merged | | 3 | Operation lifecycle, commands, eight-state projection | FE-2227/2214/2223 | merged (Comfy-Org#17655) | | 4 | `@comfyorg/account-ui` composables + `CheckoutSteps` | FE-2215 | merged (Comfy-Org#17662, Comfy-Org#17663) | | 5 slice 1 | Top-up through the SDK behind `billing_sdk_topup_enabled` | FE-2216 | merged (Comfy-Org#17665) | | rollout C | `hosted_billing_destination` server flag read by the host | FE-2218 | merged (Comfy-Org#17716) | | rollout C | `hostedDestination` port on the lifecycle, value on operation state | FE-2210/2218 | Comfy-Org#17783 (review) | | 7 prep | Scope-source port + credentialed transport (BFF / cookie hosts) | FE-2218 | merged (Comfy-Org#17782) | | 7 prep | `@comfyorg/account` → `@comfyorg/account-core` rename | FE-2218 | Comfy-Org#17851 (review; parent of this PR) | | 4 follow-up | auth Vue pieces leave the core for `@comfyorg/account-ui` (`./auth/*`) | FE-2215 | **this PR** | | 7 prep | `billing-contract` route builder + `return_to` registry | FE-2218 | merged (Comfy-Org#17795) | | 3A-3 | Workshop adapter over `createHostedTopupCheckout` | FE-2214 | merged (Comfy-Org#17793) | | 8 core | `previewSubscribe` command | FE-2331 | merged (Comfy-Org#17797) | | 8 core | Plans + saved payment-methods readers | FE-2331 | Comfy-Org#17798 (queued) | | 8 ui | account-ui composables (`usePlans`, `usePaymentMethods`, `usePreviewSubscribe`) | FE-2331 | Comfy-Org#17798 (queued) | | 7 | billing-web own-origin session, sign-in, SDK composition | FE-2218 | Comfy-Org#17798 (queued) | | 7 | billing-web unit tests in CI (`ci-billing-web-unit.yaml`) | FE-2218 | merged (Comfy-Org#17827); Comfy-Org#17844 (queued) | | 7 | ingest CORS + top-up return hosts for billing.comfy.org and its previews (Comfy-Org/cloud) | FE-2218 | merged (Comfy-Org/cloud#9512) | | 8 ui | billing-web `/v1` entry routing + subscription / payment-method surfaces | FE-2331 | Comfy-Org#17798 (queued) | | 7 | npm publish (`ingest-types`, `account-core`, `billing-contract`), Platform install, billing-web live top-up | FE-2218 | todo | | 6 | Contract tests per generated schema (package layer) | FE-2217 | Comfy-Org#17829 (review) | | 6 | Live E2E per flow × consumer + evidence table | FE-2217 | todo (needs staging flags) | | 5 slice 2 | Subscription flows through the SDK | FE-2216 | todo (plan-change decision) | | follow-up | One `needsCustomerAttention` predicate (from the Comfy-Org#17665 review) | FE-2216 | merged (Comfy-Org#17792) | | follow-up | Opaque `BillingServerCode` (from the Comfy-Org#17656 review) | FE-2227 | merged (Comfy-Org#17794) | | follow-up | `useCredits` clears on `SUPERSEDED` (from the Comfy-Org#17799 review) | FE-2215 | merged (Comfy-Org#17824) | | follow-up | credits / status / capabilities readers fence a late failure as `SUPERSEDED` (from the Comfy-Org#17798 review) | FE-2331 | merged (Comfy-Org#17828) | ```mermaid flowchart LR P3["Phase 3 core lifecycle (merged)"] P4["Phase 4 account-ui (merged)"] P5["Phase 5 slice 1 top-up flag (merged)"] FC["PR 17716 hosted_billing_destination flag (merged)"] HD["PR 17783 hostedDestination port"] SS["PR 17782 scope-source port + credentialed transport"] RN["PR 17851 account-core rename"] VUE["auth Vue pieces to account-ui"] RB["billing-contract route builder + return_to"] WS["Workshop adapter"] P8PV["previewSubscribe command"] P8RD["plans + payment-methods readers"] P8["account-ui hosted composables"] BWS["billing-web session + sign-in"] BWV["billing-web /v1 surfaces"] CORS["cloud PR 9512 ingest CORS + return hosts"] PUB["npm publish account-core / billing-contract"] P7["Phase 7 host proof: Platform + billing-web live"] P6C["Phase 6 contract tests"] P6["Phase 6 live evidence"] S2["Phase 5 slice 2 subscription"] FU9["customer-attention predicate"] FU11["opaque BillingServerCode"] FU12["useCredits clears on SUPERSEDED"] FU13["reader late-failure fence"] P3 --> HD FC --> HD HD --> RB P3 --> SS SS --> P7 RB --> P7 P3 --> RN RN --> PUB RN --> VUE RB --> PUB PUB --> P7 P3 --> P8PV P3 --> P8RD P8PV --> P8 P8RD --> P8 P4 --> P8 P8 --> S2 P8 --> BWS BWS --> BWV RB --> BWV BWV --> P7 CORS --> P7 P5 --> P6 P3 --> P6C P5 --> WS P5 --> FU9 P3 --> FU11 P4 --> FU12 P3 --> FU13 style P3 fill:#d4edda,stroke:#155724 style P4 fill:#d4edda,stroke:#155724 style P5 fill:#d4edda,stroke:#155724 style FC fill:#d4edda,stroke:#155724 style SS fill:#d4edda,stroke:#155724 style RB fill:#d4edda,stroke:#155724 style WS fill:#d4edda,stroke:#155724 style FU9 fill:#d4edda,stroke:#155724 style FU11 fill:#d4edda,stroke:#155724 style FU12 fill:#d4edda,stroke:#155724 style FU13 fill:#d4edda,stroke:#155724 style CORS fill:#d4edda,stroke:#155724 style P8PV fill:#d4edda,stroke:#155724 style VUE stroke:#0366d6,stroke-width:4px ```
…act when the hosted destination says billing_web (#17860) Stacked on #17856 (base branch `jaewon/fe-2216-plan-change`) → #17853 → #17783; merge those first. ## Why Rollout layer C (`hosted_billing_destination`, `stripe` | `billing_web`, PostHog at 100% `stripe`) decides where a hosted billing action lands. The plan says the host reads the flag, hands it to the SDK (#17783) and, when it says `billing_web`, mints a `/v1/<intent>` entry with `return_to` from `@comfyorg/billing-contract`, the one definition of that route surface (#17795); when it says `stripe`, the backend's URL is opened unchanged. Today the host only opens the bare billing-web origin from the user popover (#17716) with no intent and no `return_to`, and "Billing & invoices" in the settings panel always goes to the Stripe portal. This is the last un-opened code item before the Phase 7 host proof. ## How - `src/platform/workspace/billing/hostedBillingRoutes.ts`: `hostedBillingRoute(destination, intent)` returns `{ kind: 'billing_web', url }` built by `buildBillingEntryUrl({ billingOrigin, intent, product: 'comfyui', returnTo: 'comfyui_workspace' })`, or `{ kind: 'provider' }` meaning "use the server's URL". The environment is derived, not hardcoded: the cloud base URL's hostname through the existing `resolveDeployEnv` map (`prod-v2 | stg-v2 | test-v2` → `production | staging | test`), which also classifies a local dev session by the backend it talks to. Fails closed to the provider on: no configured origin, an unknown backend family, a return target with no destination in that family, or an entry the contract refuses. A path-prefixed `VITE_BILLING_WEB_URL` keeps its prefix under the minted route. - Consumers: the popover's "Plans and pricing" mints the `pricing` intent (billing-web routes it to the subscription view; the in-app dialog stays the `stripe` behaviour and the popup-blocked fallback); `useWorkspaceBilling.manageSubscription()` mints `payment-methods` **before** either rail is consulted, so on `billing_web` no portal URL is requested on the SDK rail or the legacy one, and `openPortalWindow` + `refreshOnPortalReturn` still run so the return re-reads status, balance and capabilities. - Also fixed on the way: the popover treated a falsy `window.open(…, "noopener,noreferrer")` result as a blocked popup and showed the in-app pricing dialog as a fallback. Per the HTML spec `noopener` always returns `null`, so on `billing_web` the tab and the dialog opened together — a latent defect inherited from #17370 on `main`, caught by this PR's evidence run. The fallback is gone; the E2E `window.open` stub now returns `null` for `noopener` like a browser does, and a popover case covers both destinations. - Left on the provider on purpose: `useSubscriptionCheckout.recoverOutstandingPayment` and the `payment_method_url` steps inside an operation are mid-checkout provider steps, not hosted management; `invoices` and `result` are not served by billing-web yet (`ComingSoonView`), so nothing mints them; the legacy `/customers` rail's `accessBillingPortal` is being retired by the personal-billing flip and is not touched. - `@comfyorg/billing-contract` becomes a root `workspace:*` dependency. The CI cloud build for E2E (`.github/actions/build-cloud-frontend`, used only by `ci-tests-e2e.yaml` and `pr-update-playwright-expectations.yaml`, never by a deploy) gets `VITE_BILLING_WEB_URL=https://billing-web.example`, a reserved origin the spec stubs, reachable only when the server flag says `billing_web`. - No frontend-derived server state: the destination is the flag as-is; the host chooses only the URL shape. ## AS-IS / TO-BE | AS-IS — `hosted_billing_destination: stripe` | TO-BE — `hosted_billing_destination: billing_web` | | --- | --- | | **1. User popover, "Plans and pricing" hovered**<br><img width="480" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17860-screenshots/screenshots/as-is-popover-plans.png"><br>Same menu item, unchanged by the flag. | **1. User popover, "Plans and pricing" hovered**<br><img width="480" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17860-screenshots/screenshots/to-be-popover-plans.png"><br>Same menu item, unchanged by the flag. | | **2. After clicking "Plans and pricing"**<br><img width="480" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17860-screenshots/screenshots/as-is-plans-result.png"><br>In-app "Choose a Plan" dialog, no tab opened. | **2. After clicking "Plans and pricing"**<br><img width="480" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17860-screenshots/screenshots/to-be-plans-result.png"><br>`billing-web.example/v1/pricing?product=comfyui&return_to=comfyui_workspace` tab opens and nothing else: `window.open` returns `null` under `noopener` as the spec requires, and no in-app dialog is left behind. | | **3. Settings ▸ Workspace ▸ Plan & Credits, before clicking "Billing & invoices"**<br><img width="480" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17860-screenshots/screenshots/as-is-settings-billing.png"><br>Identical panel; the destination is only read on click. | **3. Settings ▸ Workspace ▸ Plan & Credits, before clicking "Billing & invoices"**<br><img width="480" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17860-screenshots/screenshots/to-be-settings-billing.png"><br>Identical panel; the destination is only read on click. | | **4. After clicking "Billing & invoices"**<br><img width="480" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17860-screenshots/screenshots/as-is-manage-result.png"><br>`POST /api/billing/payment-portal` recorded, and the URL it returned (`https://billing.example/portal`) opened. | **4. After clicking "Billing & invoices"**<br><img width="480" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17860-screenshots/screenshots/to-be-manage-result.png"><br>No request to `/api/billing/payment-portal` on either rail; `billing-web.example/v1/payment-methods?product=comfyui&return_to=comfyui_workspace` minted and opened. | | **5. Return trip — refocusing the app tab after the hosted tab opened**<br><img width="480" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17860-screenshots/screenshots/as-is-return-refresh.png"><br>`/api/billing/status`, `/balance` and `/capabilities` re-read. | **5. Return trip — refocusing the app tab after the hosted tab opened**<br><img width="480" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17860-screenshots/screenshots/to-be-return-refresh.png"><br>Same three reads; `openPortalWindow` + `refreshOnPortalReturn` still run on the minted route. | - AS-IS (`stripe`, today's default): popover → in-app pricing dialog; settings → Stripe portal via `POST /billing/payment-portal`. - TO-BE (`billing_web`): popover → `<billing-web>/v1/pricing?product=comfyui&return_to=comfyui_workspace`; settings → `<billing-web>/v1/payment-methods?…`, no portal request on either rail; the app re-reads billing state on return. ## Testing | Gate | Result | | --- | --- | | `vitest run src/platform/workspace src/composables/billing src/composables/useFeatureFlags src/config` | 91 files, 1890 tests (19 new route cases: intent × destination × env × prefix × each fail-closed branch; 3 new adapter cases; 3 popover cases re-pointed) | | `packages/billing-contract` vitest | 3 files, 62 tests | | `pnpm typecheck`, `typecheck:browser`, `lint`, `format`, `knip` | exit 0 | | `fallow audit --changed-since origin/jaewon/fe-2216-plan-change` | no issues in 10 changed files | | `PLAYWRIGHT_TEST_URL=http://localhost:5431 pnpm exec playwright test --project=cloud browser_tests/tests/dialogs/hostedBillingDestination.spec.ts --reporter=list`, against `VITE_BILLING_WEB_URL=https://billing-web.example pnpm dev:cloud` | `4 passed (4.6s)` — settings on both destinations, plus the two new avatar-menu cases: `opens the in-app pricing table from the avatar menu while the destination is stripe` and `opens the billing-web pricing entry alone from the avatar menu while the destination is billing_web` | ## Where this sits in the plan Billing SDK track FE-2210 ([implementation plan V2](https://app.notion.com/p/3d86d73d36508152b92cdbdfdfe83ac8)). Hybrid model: top-up in-app, subscription management / invoices / payment methods on the hosted billing app. | Phase | Item | Ticket | Status | | --- | --- | --- | --- | | 1-2 | Session core, transport, readers | FE-2211/2212/2213 | merged | | 3 | Operation lifecycle, commands, eight-state projection | FE-2227/2214/2223 | merged (#17655) | | 4 | `@comfyorg/account-ui` composables + `CheckoutSteps` | FE-2215 | merged (#17662, #17663) | | 5 slice 1 | Top-up through the SDK behind `billing_sdk_topup_enabled` | FE-2216 | merged (#17665) | | rollout C | `hosted_billing_destination` server flag read by the host | FE-2218 | merged (#17716) | | rollout C | `hostedDestination` port on the lifecycle, value on operation state | FE-2210/2218 | #17783 (review) | | 7 prep | Scope-source port + credentialed transport (BFF / cookie hosts) | FE-2218 | merged (#17782) | | 7 prep | `@comfyorg/account` → `@comfyorg/account-core` rename | FE-2218 | #17851 (review) | | 7 prep | `billing-contract` route builder + `return_to` registry | FE-2218 | merged (#17795) | | 3A-3 | Workshop adapter over `createHostedTopupCheckout` | FE-2214 | merged (#17793) | | 8 core | `previewSubscribe` command | FE-2331 | merged (#17797) | | 8 core | Plans + saved payment-methods readers | FE-2331 | merged (#17798) | | 8 ui | account-ui composables (`usePlans`, `usePaymentMethods`, `usePreviewSubscribe`) | FE-2331 | merged (#17798) | | 7 | billing-web own-origin session, sign-in, SDK composition | FE-2218 | merged (#17798) | | 7 | billing-web unit tests in CI (`ci-billing-web-unit.yaml`) | FE-2218 | merged (#17827, #17844) | | 7 | ingest CORS + top-up return hosts for billing.comfy.org and its previews (Comfy-Org/cloud) | FE-2218 | merged (Comfy-Org/cloud#9512) | | 8 ui | billing-web `/v1` entry routing + subscription / payment-method surfaces | FE-2331 | merged (#17798) | | 7 | npm publish (`ingest-types`, `account-core`, `billing-contract`), Platform install, billing-web live top-up | FE-2218 | todo | | 6 | Contract tests per generated schema (package layer) | FE-2217 | #17829 (review) | | 6 | Live E2E per flow × consumer + evidence table | FE-2217 | todo (needs staging flags) | | 5 slice 2a | Cancel, resubscribe and payment portal through the SDK behind `billing_sdk_subscription_enabled` | FE-2216 | #17853 (review) | | 5 slice 2b | Subscribe and plan change through the SDK, priced by the server | FE-2216 | #17856 (review; parent of this PR) | | 7 / rollout C | Host mints billing-web `/v1/<intent>` entries with `return_to` when `hosted_billing_destination` is `billing_web` | FE-2218 | **this PR** | | follow-up | One `needsCustomerAttention` predicate (from the #17665 review) | FE-2216 | merged (#17792) | | follow-up | Opaque `BillingServerCode` (from the #17656 review) | FE-2227 | merged (#17794) | | follow-up | `useCredits` clears on `SUPERSEDED` (from the #17799 review) | FE-2215 | merged (#17824) | | follow-up | credits / status / capabilities readers fence a late failure as `SUPERSEDED` (from the #17798 review) | FE-2331 | merged (#17828) | ```mermaid flowchart LR P3["Phase 3 core lifecycle (merged)"] P4["Phase 4 account-ui (merged)"] P5["Phase 5 slice 1 top-up flag (merged)"] FC["PR 17716 hosted_billing_destination flag (merged)"] HD["PR 17783 hostedDestination port"] SS["PR 17782 scope-source port + credentialed transport"] RN["account-core rename"] RB["billing-contract route builder + return_to"] WS["Workshop adapter"] P8PV["previewSubscribe command"] P8RD["plans + payment-methods readers"] P8["account-ui hosted composables"] BWS["billing-web session + sign-in"] BWV["billing-web /v1 surfaces"] CORS["cloud PR 9512 ingest CORS + return hosts"] PUB["npm publish account-core / billing-contract"] P7["Phase 7 host proof: Platform + billing-web live"] P6C["Phase 6 contract tests"] P6["Phase 6 live evidence"] S2A["PR 17853 slice 2a cancel / resubscribe / portal rail"] S2B["PR 17856 slice 2b subscribe + plan change"] LC["Layer C: host mints billing-web entries"] FU9["customer-attention predicate"] FU11["opaque BillingServerCode"] FU12["useCredits clears on SUPERSEDED"] FU13["reader late-failure fence"] P3 --> HD FC --> HD HD --> RB P3 --> SS SS --> P7 RB --> P7 P3 --> RN RN --> PUB RB --> PUB PUB --> P7 P3 --> P8PV P3 --> P8RD P8PV --> P8 P8RD --> P8 P4 --> P8 P8 --> S2B HD --> S2A S2A --> S2B S2B --> LC RB --> LC HD --> LC LC --> P7 P8 --> BWS BWS --> BWV RB --> BWV BWV --> P7 CORS --> P7 P5 --> P6 P3 --> P6C P5 --> WS P5 --> FU9 P3 --> FU11 P4 --> FU12 P3 --> FU13 style P3 fill:#d4edda,stroke:#155724 style P4 fill:#d4edda,stroke:#155724 style P5 fill:#d4edda,stroke:#155724 style FC fill:#d4edda,stroke:#155724 style SS fill:#d4edda,stroke:#155724 style RB fill:#d4edda,stroke:#155724 style WS fill:#d4edda,stroke:#155724 style FU9 fill:#d4edda,stroke:#155724 style BWV fill:#d4edda,stroke:#155724 style BWS fill:#d4edda,stroke:#155724 style P8 fill:#d4edda,stroke:#155724 style P8RD fill:#d4edda,stroke:#155724 style CORS fill:#d4edda,stroke:#155724 style FU13 fill:#d4edda,stroke:#155724 style FU12 fill:#d4edda,stroke:#155724 style FU11 fill:#d4edda,stroke:#155724 style P8PV fill:#d4edda,stroke:#155724 style LC stroke:#0366d6,stroke-width:4px ```
…act when the hosted destination says billing_web (#17860) Stacked on #17856 (base branch `jaewon/fe-2216-plan-change`) → #17853 → Rollout layer C (`hosted_billing_destination`, `stripe` | `billing_web`, PostHog at 100% `stripe`) decides where a hosted billing action lands. The plan says the host reads the flag, hands it to the SDK (#17783) and, when it says `billing_web`, mints a `/v1/<intent>` entry with `return_to` from `@comfyorg/billing-contract`, the one definition of that route surface (#17795); when it says `stripe`, the backend's URL is opened unchanged. Today the host only opens the bare billing-web origin from the user popover (#17716) with no intent and no `return_to`, and "Billing & invoices" in the settings panel always goes to the Stripe portal. This is the last un-opened code item before the Phase 7 host proof. - `src/platform/workspace/billing/hostedBillingRoutes.ts`: `hostedBillingRoute(destination, intent)` returns `{ kind: 'billing_web', url }` built by `buildBillingEntryUrl({ billingOrigin, intent, product: 'comfyui', returnTo: 'comfyui_workspace' })`, or `{ kind: 'provider' }` meaning "use the server's URL". The environment is derived, not hardcoded: the cloud base URL's hostname through the existing `resolveDeployEnv` map (`prod-v2 | stg-v2 | test-v2` → `production | staging | test`), which also classifies a local dev session by the backend it talks to. Fails closed to the provider on: no configured origin, an unknown backend family, a return target with no destination in that family, or an entry the contract refuses. A path-prefixed `VITE_BILLING_WEB_URL` keeps its prefix under the minted route. - Consumers: the popover's "Plans and pricing" mints the `pricing` intent (billing-web routes it to the subscription view; the in-app dialog stays the `stripe` behaviour and the popup-blocked fallback); `useWorkspaceBilling.manageSubscription()` mints `payment-methods` **before** either rail is consulted, so on `billing_web` no portal URL is requested on the SDK rail or the legacy one, and `openPortalWindow` + `refreshOnPortalReturn` still run so the return re-reads status, balance and capabilities. - Also fixed on the way: the popover treated a falsy `window.open(…, "noopener,noreferrer")` result as a blocked popup and showed the in-app pricing dialog as a fallback. Per the HTML spec `noopener` always returns `null`, so on `billing_web` the tab and the dialog opened together — a latent defect inherited from #17370 on `main`, caught by this PR's evidence run. The fallback is gone; the E2E `window.open` stub now returns `null` for `noopener` like a browser does, and a popover case covers both destinations. - Left on the provider on purpose: `useSubscriptionCheckout.recoverOutstandingPayment` and the `payment_method_url` steps inside an operation are mid-checkout provider steps, not hosted management; `invoices` and `result` are not served by billing-web yet (`ComingSoonView`), so nothing mints them; the legacy `/customers` rail's `accessBillingPortal` is being retired by the personal-billing flip and is not touched. - `@comfyorg/billing-contract` becomes a root `workspace:*` dependency. The CI cloud build for E2E (`.github/actions/build-cloud-frontend`, used only by `ci-tests-e2e.yaml` and `pr-update-playwright-expectations.yaml`, never by a deploy) gets `VITE_BILLING_WEB_URL=https://billing-web.example`, a reserved origin the spec stubs, reachable only when the server flag says `billing_web`. - No frontend-derived server state: the destination is the flag as-is; the host chooses only the URL shape. | AS-IS — `hosted_billing_destination: stripe` | TO-BE — `hosted_billing_destination: billing_web` | | --- | --- | | **1. User popover, "Plans and pricing" hovered**<br><img width="480" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17860-screenshots/screenshots/as-is-popover-plans.png"><br>Same menu item, unchanged by the flag. | **1. User popover, "Plans and pricing" hovered**<br><img width="480" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17860-screenshots/screenshots/to-be-popover-plans.png"><br>Same menu item, unchanged by the flag. | | **2. After clicking "Plans and pricing"**<br><img width="480" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17860-screenshots/screenshots/as-is-plans-result.png"><br>In-app "Choose a Plan" dialog, no tab opened. | **2. After clicking "Plans and pricing"**<br><img width="480" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17860-screenshots/screenshots/to-be-plans-result.png"><br>`billing-web.example/v1/pricing?product=comfyui&return_to=comfyui_workspace` tab opens and nothing else: `window.open` returns `null` under `noopener` as the spec requires, and no in-app dialog is left behind. | | **3. Settings ▸ Workspace ▸ Plan & Credits, before clicking "Billing & invoices"**<br><img width="480" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17860-screenshots/screenshots/as-is-settings-billing.png"><br>Identical panel; the destination is only read on click. | **3. Settings ▸ Workspace ▸ Plan & Credits, before clicking "Billing & invoices"**<br><img width="480" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17860-screenshots/screenshots/to-be-settings-billing.png"><br>Identical panel; the destination is only read on click. | | **4. After clicking "Billing & invoices"**<br><img width="480" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17860-screenshots/screenshots/as-is-manage-result.png"><br>`POST /api/billing/payment-portal` recorded, and the URL it returned (`https://billing.example/portal`) opened. | **4. After clicking "Billing & invoices"**<br><img width="480" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17860-screenshots/screenshots/to-be-manage-result.png"><br>No request to `/api/billing/payment-portal` on either rail; `billing-web.example/v1/payment-methods?product=comfyui&return_to=comfyui_workspace` minted and opened. | | **5. Return trip — refocusing the app tab after the hosted tab opened**<br><img width="480" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17860-screenshots/screenshots/as-is-return-refresh.png"><br>`/api/billing/status`, `/balance` and `/capabilities` re-read. | **5. Return trip — refocusing the app tab after the hosted tab opened**<br><img width="480" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17860-screenshots/screenshots/to-be-return-refresh.png"><br>Same three reads; `openPortalWindow` + `refreshOnPortalReturn` still run on the minted route. | - AS-IS (`stripe`, today's default): popover → in-app pricing dialog; settings → Stripe portal via `POST /billing/payment-portal`. - TO-BE (`billing_web`): popover → `<billing-web>/v1/pricing?product=comfyui&return_to=comfyui_workspace`; settings → `<billing-web>/v1/payment-methods?…`, no portal request on either rail; the app re-reads billing state on return. | Gate | Result | | --- | --- | | `vitest run src/platform/workspace src/composables/billing src/composables/useFeatureFlags src/config` | 91 files, 1890 tests (19 new route cases: intent × destination × env × prefix × each fail-closed branch; 3 new adapter cases; 3 popover cases re-pointed) | | `packages/billing-contract` vitest | 3 files, 62 tests | | `pnpm typecheck`, `typecheck:browser`, `lint`, `format`, `knip` | exit 0 | | `fallow audit --changed-since origin/jaewon/fe-2216-plan-change` | no issues in 10 changed files | | `PLAYWRIGHT_TEST_URL=http://localhost:5431 pnpm exec playwright test --project=cloud browser_tests/tests/dialogs/hostedBillingDestination.spec.ts --reporter=list`, against `VITE_BILLING_WEB_URL=https://billing-web.example pnpm dev:cloud` | `4 passed (4.6s)` — settings on both destinations, plus the two new avatar-menu cases: `opens the in-app pricing table from the avatar menu while the destination is stripe` and `opens the billing-web pricing entry alone from the avatar menu while the destination is billing_web` | Billing SDK track FE-2210 ([implementation plan V2](https://app.notion.com/p/3d86d73d36508152b92cdbdfdfe83ac8)). Hybrid model: top-up in-app, subscription management / invoices / payment methods on the hosted billing app. | Phase | Item | Ticket | Status | | --- | --- | --- | --- | | 1-2 | Session core, transport, readers | FE-2211/2212/2213 | merged | | 3 | Operation lifecycle, commands, eight-state projection | FE-2227/2214/2223 | merged (#17655) | | 4 | `@comfyorg/account-ui` composables + `CheckoutSteps` | FE-2215 | merged (#17662, #17663) | | 5 slice 1 | Top-up through the SDK behind `billing_sdk_topup_enabled` | FE-2216 | merged (#17665) | | rollout C | `hosted_billing_destination` server flag read by the host | FE-2218 | merged (#17716) | | rollout C | `hostedDestination` port on the lifecycle, value on operation state | FE-2210/2218 | #17783 (review) | | 7 prep | Scope-source port + credentialed transport (BFF / cookie hosts) | FE-2218 | merged (#17782) | | 7 prep | `@comfyorg/account` → `@comfyorg/account-core` rename | FE-2218 | #17851 (review) | | 7 prep | `billing-contract` route builder + `return_to` registry | FE-2218 | merged (#17795) | | 3A-3 | Workshop adapter over `createHostedTopupCheckout` | FE-2214 | merged (#17793) | | 8 core | `previewSubscribe` command | FE-2331 | merged (#17797) | | 8 core | Plans + saved payment-methods readers | FE-2331 | merged (#17798) | | 8 ui | account-ui composables (`usePlans`, `usePaymentMethods`, `usePreviewSubscribe`) | FE-2331 | merged (#17798) | | 7 | billing-web own-origin session, sign-in, SDK composition | FE-2218 | merged (#17798) | | 7 | billing-web unit tests in CI (`ci-billing-web-unit.yaml`) | FE-2218 | merged (#17827, #17844) | | 7 | ingest CORS + top-up return hosts for billing.comfy.org and its previews (Comfy-Org/cloud) | FE-2218 | merged (Comfy-Org/cloud#9512) | | 8 ui | billing-web `/v1` entry routing + subscription / payment-method surfaces | FE-2331 | merged (#17798) | | 7 | npm publish (`ingest-types`, `account-core`, `billing-contract`), Platform install, billing-web live top-up | FE-2218 | todo | | 6 | Contract tests per generated schema (package layer) | FE-2217 | | 6 | Live E2E per flow × consumer + evidence table | FE-2217 | todo (needs staging flags) | | 5 slice 2a | Cancel, resubscribe and payment portal through the SDK behind `billing_sdk_subscription_enabled` | FE-2216 | #17853 (review) | | 5 slice 2b | Subscribe and plan change through the SDK, priced by the server | FE-2216 | #17856 (review; parent of this PR) | | 7 / rollout C | Host mints billing-web `/v1/<intent>` entries with `return_to` when `hosted_billing_destination` is `billing_web` | FE-2218 | **this PR** | | follow-up | One `needsCustomerAttention` predicate (from the #17665 review) | FE-2216 | merged (#17792) | | follow-up | Opaque `BillingServerCode` (from the #17656 review) | FE-2227 | merged (#17794) | | follow-up | `useCredits` clears on `SUPERSEDED` (from the #17799 review) | FE-2215 | merged (#17824) | | follow-up | credits / status / capabilities readers fence a late failure as `SUPERSEDED` (from the #17798 review) | FE-2331 | merged (#17828) | ```mermaid flowchart LR P3["Phase 3 core lifecycle (merged)"] P4["Phase 4 account-ui (merged)"] P5["Phase 5 slice 1 top-up flag (merged)"] FC["PR 17716 hosted_billing_destination flag (merged)"] HD["PR 17783 hostedDestination port"] SS["PR 17782 scope-source port + credentialed transport"] RN["account-core rename"] RB["billing-contract route builder + return_to"] WS["Workshop adapter"] P8PV["previewSubscribe command"] P8RD["plans + payment-methods readers"] P8["account-ui hosted composables"] BWS["billing-web session + sign-in"] BWV["billing-web /v1 surfaces"] CORS["cloud PR 9512 ingest CORS + return hosts"] PUB["npm publish account-core / billing-contract"] P7["Phase 7 host proof: Platform + billing-web live"] P6C["Phase 6 contract tests"] P6["Phase 6 live evidence"] S2A["PR 17853 slice 2a cancel / resubscribe / portal rail"] S2B["PR 17856 slice 2b subscribe + plan change"] LC["Layer C: host mints billing-web entries"] FU9["customer-attention predicate"] FU11["opaque BillingServerCode"] FU12["useCredits clears on SUPERSEDED"] FU13["reader late-failure fence"] P3 --> HD FC --> HD HD --> RB P3 --> SS SS --> P7 RB --> P7 P3 --> RN RN --> PUB RB --> PUB PUB --> P7 P3 --> P8PV P3 --> P8RD P8PV --> P8 P8RD --> P8 P4 --> P8 P8 --> S2B HD --> S2A S2A --> S2B S2B --> LC RB --> LC HD --> LC LC --> P7 P8 --> BWS BWS --> BWV RB --> BWV BWV --> P7 CORS --> P7 P5 --> P6 P3 --> P6C P5 --> WS P5 --> FU9 P3 --> FU11 P4 --> FU12 P3 --> FU13 style P3 fill:#d4edda,stroke:#155724 style P4 fill:#d4edda,stroke:#155724 style P5 fill:#d4edda,stroke:#155724 style FC fill:#d4edda,stroke:#155724 style SS fill:#d4edda,stroke:#155724 style RB fill:#d4edda,stroke:#155724 style WS fill:#d4edda,stroke:#155724 style FU9 fill:#d4edda,stroke:#155724 style BWV fill:#d4edda,stroke:#155724 style BWS fill:#d4edda,stroke:#155724 style P8 fill:#d4edda,stroke:#155724 style P8RD fill:#d4edda,stroke:#155724 style CORS fill:#d4edda,stroke:#155724 style FU13 fill:#d4edda,stroke:#155724 style FU12 fill:#d4edda,stroke:#155724 style FU11 fill:#d4edda,stroke:#155724 style P8PV fill:#d4edda,stroke:#155724 style LC stroke:#0366d6,stroke-width:4px ```
…contract and ingest-types (Comfy-Org#17882) ## Why `@comfyorg/account-core`, `@comfyorg/billing-contract` and `@comfyorg/ingest-types` are about to be installed by Platform from the public registry, and today none of them can be packed: `exports` point at `src/*.ts`, there is no `files` allowlist, no build, and the core still reaches into a private workspace utility. The release workflows on Comfy-Org#17881 assume `build` and `smoke:pack` exist; this PR is the part that makes a tarball installable in plain Node. Built on Comfy-Org#17854 (auth Vue surface → `account-ui`, now merged) so the core builds from a Vue-free tree, and it reproduces Maanil's Comfy-Org#17838 / Comfy-Org#17839 / Comfy-Org#17840 on the renamed tree as agreed in the review thread there. Base is `main`. ## How - **Private-utility cut** — the one remaining reach out of the core was `turnstileScript.ts` → `@comfyorg/shared-frontend-utils/loadExternalScript`. The loader is now package-owned (`packages/account-core/src/loadExternalScript.ts`, byte-identical) and `@comfyorg/shared-frontend-utils` leaves the core's dependencies. `publishBoundary.test.ts` fails on any future `workspace:` dependency that is not itself published (`@comfyorg/ingest-types` is the only allowed one). - **Manifests** — `files: ["dist"]`, `sideEffects: false`, `repository`/`homepage`/`author`, MIT `LICENSE` per package, `publishConfig.exports` mapping every dev `exports` entry to `dist/*.js` + `.d.ts`, `./package.json` export, `access: public`. `@comfyorg/ingest-types` moves `zod` to a peer so a consumer never gets two zod copies. `private: true` stays on all three (`ingest-types` had no `private` at all; it now has the latch). Flipping `private` is a one-line change per manifest in a later reviewed PR. - **Build** — `tsconfig.build.json` per package (`declaration`, `noEmitOnError`, `types: []`, tests and fixtures excluded), `build` = `clean` + `tsc -p`, `prepack` runs it. Relative imports carry `.js` so the emitted ESM resolves under `nodenext`; `openapi-ts.config.ts` sets `importFileExtension: '.js'` so regeneration keeps it. - **Smoke pack** — `scripts/smokePack.ts` (run as `pnpm --filter @comfyorg/account-core smoke:pack`) packs all three, checks each tarball (no source/test/fixture files, every export target present, no unrewritten `catalog:`/`workspace:`), installs them into a throwaway npm project, imports all 21 entries from plain Node ESM, and type-checks a `nodenext` consumer. Dropping one `.js` extension makes the typed step fail with `TS2835`, which the plain-Node step alone would not catch. - **CI** — `ci-packages-pack.yaml` on `pull_request` for the three package paths: matrix job per package (typecheck → build → `check:pack`) plus one `smoke-consumer` job. The tarball rules live in one pure module, `publishableTarball.ts`, with its own test file; the CLI and the smoke test are two entry points onto it, so CI and the smoke test cannot drift. Deliberate divergences from Comfy-Org#17839: no `region` export and no deletion in `shared-frontend-utils/networkUtil.ts` (the region gate moved to `account-ui` with the Vue surface and three app suites still import it); `createScriptLoader` stays in the shared package for its three `src/platform` callers. Open point: the root `LICENSE` is GPL-3.0 while all three manifests already declare MIT (as `@comfyorg/design-system` publishes). Without a per-package file pnpm would inject the GPL text into a tarball whose manifest says MIT, so the MIT files fix the actual defect; whether the SDK packages should be MIT at all is a call for the reviewer to confirm. ## AS-IS / TO-BE No UI change; packages, scripts and CI only. - AS-IS: `pnpm pack` on any of the three ships `src/*.ts` (or nothing) with `exports` a consumer cannot resolve, and the core depends on a private workspace package. - TO-BE: `smoke:pack` proves the three tarballs install and import from plain Node with types, and CI runs that proof on every change to the packages. ## Testing | Check | Result | | --- | --- | | `build` account-core / billing-contract / ingest-types | 92 / 18 / 6 dist files | | `smoke:pack` | 3 packed, 21 entries imported under Node ESM, `nodenext` tsc clean | | vitest account-core / account-ui / billing-contract / billing-web | 675 / 79 / 62 / 90 pass | | `pnpm typecheck`, `pnpm lint`, `pnpm format:check`, `pnpm knip` (with `dist` on disk) | exit 0 | | `yamllint` on the new workflow | clean | ## Where this sits in the plan Billing SDK track FE-2210 ([implementation plan V2](https://app.notion.com/p/3d86d73d36508152b92cdbdfdfe83ac8)). Hybrid model: top-up in-app, subscription management / invoices / payment methods on the hosted billing app. | Phase | Item | Ticket | Status | | --- | --- | --- | --- | | 1-2 | Session core, transport, readers | FE-2211/2212/2213 | merged | | 3 | Operation lifecycle, commands, eight-state projection | FE-2227/2214/2223 | merged (Comfy-Org#17655) | | 4 | `@comfyorg/account-ui` composables + `CheckoutSteps` | FE-2215 | merged (Comfy-Org#17662, Comfy-Org#17663) | | 5 slice 1 | Top-up through the SDK behind `billing_sdk_topup_enabled` | FE-2216 | merged (Comfy-Org#17665) | | rollout C | `hosted_billing_destination` server flag read by the host | FE-2218 | merged (Comfy-Org#17716) | | rollout C | `hostedDestination` port on the lifecycle, value on operation state | FE-2210/2218 | Comfy-Org#17783 (review, carries slice 2a) | | 7 prep | Scope-source port + credentialed transport (BFF / cookie hosts) | FE-2218 | merged (Comfy-Org#17782) | | 7 prep | `@comfyorg/account` → `@comfyorg/account-core` rename | FE-2218 | merged (Comfy-Org#17851) | | 7 prep | Auth Vue surface → `account-ui`; core Vue-free by construction | FE-2215 | merged (Comfy-Org#17854) | | 7 prep | `billing-contract` route builder + `return_to` registry | FE-2218 | merged (Comfy-Org#17795) | | 3A-3 | Workshop adapter over `createHostedTopupCheckout` | FE-2214 | merged (Comfy-Org#17793) | | 8 core | `previewSubscribe` command | FE-2331 | merged (Comfy-Org#17797) | | 8 core | Plans + saved payment-methods readers | FE-2331 | merged (Comfy-Org#17798) | | 8 ui | account-ui composables (`usePlans`, `usePaymentMethods`, `usePreviewSubscribe`) | FE-2331 | merged (Comfy-Org#17798) | | 7 | billing-web own-origin session, sign-in, SDK composition | FE-2218 | merged (Comfy-Org#17798) | | 7 | billing-web unit tests in CI (`ci-billing-web-unit.yaml`) | FE-2218 | merged (Comfy-Org#17827, Comfy-Org#17844) | | 7 | ingest CORS + top-up return hosts for billing.comfy.org and its previews (Comfy-Org/cloud) | FE-2218 | merged (Comfy-Org/cloud#9512) | | 8 ui | billing-web `/v1` entry routing + subscription / payment-method surfaces | FE-2331 | merged (Comfy-Org#17798) | | 7 | Package release workflows + versioning ADR (bump PR → publish on merge, snapshots) | FE-2218 | Comfy-Org#17881 (review) | | 7 | Publish readiness: dist build, files allowlist, pack smoke test, private-utility cut | FE-2218 | **this PR** | | 7 | First publish (`private` off), Platform install, billing-web live top-up | FE-2218 | todo | | 6 | Contract tests per generated schema (package layer) | FE-2217 | Comfy-Org#17829 (review) | | 6 | Live E2E per flow × consumer + evidence table | FE-2217 | todo (needs staging flags) | | 5 slice 2 | Subscription flows through the SDK | FE-2216 | Comfy-Org#17856 / Comfy-Org#17860 (review) | | follow-up | One `needsCustomerAttention` predicate (from the Comfy-Org#17665 review) | FE-2216 | merged (Comfy-Org#17792) | | follow-up | Opaque `BillingServerCode` (from the Comfy-Org#17656 review) | FE-2227 | merged (Comfy-Org#17794) | | follow-up | `useCredits` clears on `SUPERSEDED` (from the Comfy-Org#17799 review) | FE-2215 | merged (Comfy-Org#17824) | | follow-up | credits / status / capabilities readers fence a late failure as `SUPERSEDED` (from the Comfy-Org#17798 review) | FE-2331 | merged (Comfy-Org#17828) | ```mermaid flowchart LR P3["Phase 3 core lifecycle (merged)"] P4["Phase 4 account-ui (merged)"] P5["Phase 5 slice 1 top-up flag (merged)"] FC["PR 17716 hosted_billing_destination flag (merged)"] HD["PR 17783 hostedDestination port"] SS["PR 17782 scope-source port + credentialed transport"] RN["account-core rename (merged)"] AV["auth Vue surface to account-ui (merged)"] RB["billing-contract route builder + return_to"] WS["Workshop adapter"] P8PV["previewSubscribe command"] P8RD["plans + payment-methods readers"] P8["account-ui hosted composables"] BWS["billing-web session + sign-in"] BWV["billing-web /v1 surfaces"] CORS["cloud PR 9512 ingest CORS + return hosts"] RW["PR 17881 release workflows + ADR"] PR["publish readiness: dist, files, smoke pack"] PUB["first publish account-core / billing-contract / ingest-types"] P7["Phase 7 host proof: Platform + billing-web live"] P6C["Phase 6 contract tests"] P6["Phase 6 live evidence"] S2["Phase 5 slice 2 subscription"] FU9["customer-attention predicate"] FU11["opaque BillingServerCode"] FU12["useCredits clears on SUPERSEDED"] FU13["reader late-failure fence"] P3 --> HD FC --> HD HD --> RB P3 --> SS SS --> P7 RB --> P7 P3 --> RN RN --> AV AV --> PR RW --> PUB PR --> PUB RB --> PUB PUB --> P7 P3 --> P8PV P3 --> P8RD P8PV --> P8 P8RD --> P8 P4 --> P8 P8 --> S2 P8 --> BWS BWS --> BWV RB --> BWV BWV --> P7 CORS --> P7 P5 --> P6 P3 --> P6C P5 --> WS P5 --> FU9 P3 --> FU11 P4 --> FU12 P3 --> FU13 style P3 fill:#d4edda,stroke:#155724 style P4 fill:#d4edda,stroke:#155724 style P5 fill:#d4edda,stroke:#155724 style FC fill:#d4edda,stroke:#155724 style SS fill:#d4edda,stroke:#155724 style RB fill:#d4edda,stroke:#155724 style WS fill:#d4edda,stroke:#155724 style FU9 fill:#d4edda,stroke:#155724 style BWV fill:#d4edda,stroke:#155724 style BWS fill:#d4edda,stroke:#155724 style P8 fill:#d4edda,stroke:#155724 style P8RD fill:#d4edda,stroke:#155724 style CORS fill:#d4edda,stroke:#155724 style FU13 fill:#d4edda,stroke:#155724 style FU12 fill:#d4edda,stroke:#155724 style FU11 fill:#d4edda,stroke:#155724 style P8PV fill:#d4edda,stroke:#155724 style RN fill:#d4edda,stroke:#155724 style AV fill:#d4edda,stroke:#155724 style PR stroke:#0366d6,stroke-width:4px ```
…codes (Comfy-Org#17829) Linear FE-2217. ## Why The billing SDK core decodes generated zod schemas from `@comfyorg/ingest-types/zod`, which a bot regenerates from the cloud OpenAPI whenever the backend moves. Today a regen that renames a field, drops it, or widens an enum the reducer switches on surfaces either as a typecheck error somewhere deep in the core or, worse, as a runtime `MALFORMED_RESPONSE` in front of a customer mid-payment. Nothing states, in one readable place, which fields of which schema the SDK actually depends on. This adds a contract test per generated schema the core decodes. Each pins the fields the core reads and the enum members it branches on, at the type level and at parse time, so a regen that changes one of them fails a named block whose name says what broke — the parse rows under `vitest run`, the `expectTypeOf` exhaustiveness pins under the package typecheck. A failure here means the backend contract moved: fix the SDK, not the test. These are pins, not behaviour: reader and command behaviour stays covered by the existing `credits.test.ts`, `status.test.ts`, `capabilities.test.ts`, `operationState.test.ts`, `subscriptionCommands.test.ts`, and `topup.test.ts`. ## How New folder `packages/account-core/src/core/billing/contracts/`, one file per endpoint contract, picked up by the package's existing `src/core/**/*.{test,spec}.ts` include. Each file holds a canonical fixture typed as `z.input<typeof schema>` built by a small typed builder (no casts), parses it with `safeParse`, pins the output type with `expectTypeOf`, and runs one `it.for` row per enum value the SDK branches on. | Schema | Module that decodes it | Fields pinned | | --- | --- | --- | | `zBillingBalanceResponse` | `credits.ts` (read by `topup.ts`, `balanceWatch.ts`) | `amount_micros` as a number; the four optional breakdown micros | | `zBillingStatusResponse` | `status.ts` (read by `operationLifecycle.ts`, `subscriptionCommands.ts`, `presentation.ts`) | `billing_rail` (3), `pending_billing_op_id`, `pending_billing_op_type` (2), `action_url`, `payment_intent_client_secret`, `is_active`, `subscription_tier` (7), `subscription_status` (3) | | `zBillingCapabilitiesResponse`, `zBillingCapabilities`, `zBillingCapabilityScope`, `zBillingCapabilityRolloutDefaults` | `capabilities.ts` (which parses the three named pieces, not the response schema) | the five response keys the reader recomposes into its own schema, reading `expires_at` as a plain string and `revision` as a number; all seven capability booleans; `resolved_for.user_id` / `workspace_id`; `expires_at`; `revision` as an int64 bounded to the JavaScript-safe range the reader reads it back as a number over; `denied_reasons` absent from the contract, which is why `capabilityDenials.ts` decodes it off the raw body | | `zBillingOpStatusResponse` | `operationLifecycle.ts`, `operationState.ts` | `id`; `status` (the 4 the reducer handles); `authentication_state` (the 5 it reads or assigns); `decline_reason` (8, incl. the `generic` fallback); `recovery_action` (4); `phase` (3); `action_url`; `payment_intent_client_secret`; `retryable` optional | | `zErrorResponse` | `billingErrorBody.ts` | `code` as an open string the commands match against their own closed set; a body without `message` yields no code | | `zSubscribeRequest`, `zSubscribeResponse` | `subscriptionCommands.ts` | `confirmation_token`, `saved_payment_method_id` (`pm_` prefix), `idempotency_key`, `confirm_reactivation`; `billing_op_id`, `status` (3), optional `payment_method_url` | | `zResubscribeResponse` | `subscriptionCommands.ts` | `billing_op_id` regardless of `status` (2) | | `zCancelSubscriptionResponse2` | `subscriptionCommands.ts` | `billing_op_id` on both members of the response union | | `zPaymentPortalResponse` | `subscriptionCommands.ts` | `url` required, and not https-checked by the schema, which is why the command re-checks it | | `zPreviewSubscribeRequest`, `zPreviewSubscribeResponse` | `subscriptionCommands.ts` | `plan_slug` required and the three optional request fields; `allowed`, `is_immediate`, `effective_at`, `transition_type` (4), the int64 money fields and their JSON-number coercion, `discounts`, `requires_reactivation_confirmation` | | `zCreateTopupRequest`, `zCreateTopupResponse` | `topup.ts` | `amount_cents` minimum and its int64 coercion of the JSON number the command validates but does not send; `idempotency_key`; `billing_op_id` regardless of `status` (3) | | `zCreateTopupCheckoutRequest`, `zCreateTopupCheckoutResponse` | `topup.ts` | the amount bounds and the `return_url` URL rule, pinned by the issue **path** the command reads to tell the two apart; `checkout_url` required, `session_id` optional | `capabilityDenials.ts` is the one billing module that decodes without a generated schema — deliberately, since a strict enum parse would lose the whole capability set the first time the server names an unfamiliar policy branch. Its absence from the generated contract is pinned in `billingCapabilities.contract.test.ts`. ## AS-IS / TO-BE No UI. A regenerated `zBillingOpStatusResponse` that adds a fifth `status`: - AS-IS: the new value falls through `terminalFromStatus` into the pending branch; the operation polls until its budget runs out and reports `timed_out`. - TO-BE: `billingOpStatus.contract.test.ts` fails on the regen PR, naming the reducer as what needs updating. Two gates, and which one fires depends on the pin: the enum rows (`accepts the %s status`) fail under `vitest run`, while the exhaustiveness pin at `billingOpStatus.contract.test.ts:36` sits at module scope and fails as a TS2344 under the package typecheck, not in the test run. ## Testing - `cd packages/account-core && vitest run src/core/billing/contracts` — 12 files, 90 tests, all passing. The type pins are not among them: they sit at module scope and fail `pnpm --filter @comfyorg/account-core typecheck` instead, because nothing here runs `vitest --typecheck`. - `cd packages/account-core && tsc --noEmit` — clean - `pnpm typecheck` — passing; verified the type pins bite by injecting a spurious enum member and watching `expectTypeOf` fail with TS2344 - `pnpm lint`, `pnpm format`, `pnpm knip` — passing - `fallow audit --changed-since origin/main` — no issues in the 13 changed files ## Where this sits in the plan Billing SDK track FE-2210 ([implementation plan V2](https://app.notion.com/p/3d86d73d36508152b92cdbdfdfe83ac8)). Hybrid model: top-up in-app, subscription management / invoices / payment methods on the hosted billing app. | Phase | Item | Ticket | Status | | --- | --- | --- | --- | | 1-2 | Session core, transport, readers | FE-2211/2212/2213 | merged | | 3 | Operation lifecycle, commands, eight-state projection | FE-2227/2214/2223 | merged (Comfy-Org#17655) | | 4 | `@comfyorg/account-ui` composables + `CheckoutSteps` | FE-2215 | merged (Comfy-Org#17662, Comfy-Org#17663) | | 5 slice 1 | Top-up through the SDK behind `billing_sdk_topup_enabled` | FE-2216 | merged (Comfy-Org#17665) | | rollout C | `hosted_billing_destination` server flag read by the host | FE-2218 | merged (Comfy-Org#17716) | | rollout C | `hostedDestination` port on the lifecycle, value on operation state | FE-2210/2218 | open (Comfy-Org#17783, carries slice 2a) | | 7 prep | Scope-source port + credentialed transport (BFF / cookie hosts) | FE-2218 | merged (Comfy-Org#17782) | | 7 prep | `@comfyorg/account` → `@comfyorg/account-core` rename | FE-2218 | merged (Comfy-Org#17851) — this PR sits on it | | 7 prep | `billing-contract` route builder + `return_to` registry | FE-2218 | merged (Comfy-Org#17795) | | 3A-3 | Workshop adapter over `createHostedTopupCheckout` | FE-2214 | merged (Comfy-Org#17793) | | 8 core | `previewSubscribe` command | FE-2331 | merged (Comfy-Org#17797) | | 8 core | Plans + saved payment-methods readers | FE-2331 | merged (Comfy-Org#17798) | | 8 ui | account-ui composables (`usePlans`, `usePaymentMethods`, `usePreviewSubscribe`) | FE-2331 | merged (Comfy-Org#17798) | | 7 | billing-web own-origin session, sign-in, SDK composition | FE-2218 | merged (Comfy-Org#17798) | | 7 | billing-web unit tests in CI (`ci-billing-web-unit.yaml`) | FE-2218 | merged (Comfy-Org#17827, Comfy-Org#17844) | | 7 | ingest CORS + top-up return hosts for billing.comfy.org and its previews (Comfy-Org/cloud) | FE-2218 | merged (Comfy-Org/cloud#9512) | | 8 ui | billing-web `/v1` entry routing + subscription / payment-method surfaces | FE-2331 | merged (Comfy-Org#17798) | | 7 | Publish readiness: dist build, files allowlist, pack smoke test | FE-2218 | merged (Comfy-Org#17882) | | 7 | Package release workflows + versioning ADR | FE-2218 | open (Comfy-Org#17881) | | 7 | First publish (`private` off), Platform install, billing-web live top-up | FE-2218 | todo | | 6 | Contract tests per generated schema (package layer) | FE-2217 | **this PR** | | 6 | Live E2E per flow × consumer + evidence table | FE-2217 | todo (needs staging flags) | | 5 slice 2 | Subscription flows through the SDK | FE-2216 | open (Comfy-Org#17856, Comfy-Org#17860) | | follow-up | One `needsCustomerAttention` predicate (from the Comfy-Org#17665 review) | FE-2216 | merged (Comfy-Org#17792) | | follow-up | Opaque `BillingServerCode` (from the Comfy-Org#17656 review) | FE-2227 | merged (Comfy-Org#17794) | | follow-up | `useCredits` clears on `SUPERSEDED` (from the Comfy-Org#17799 review) | FE-2215 | merged (Comfy-Org#17824) | | follow-up | credits / status / capabilities readers fence a late failure as `SUPERSEDED` (from the Comfy-Org#17798 review) | FE-2331 | open (Comfy-Org#17828) | ```mermaid flowchart LR P3["Phase 3 core lifecycle (merged)"] P4["Phase 4 account-ui (merged)"] P5["Phase 5 slice 1 top-up flag (merged)"] FC["PR 17716 hosted_billing_destination flag (merged)"] HD["PR 17783 hostedDestination port"] SS["PR 17782 scope-source port + credentialed transport"] RN["account-core rename"] RB["billing-contract route builder + return_to"] WS["Workshop adapter"] P8PV["previewSubscribe command"] P8RD["plans + payment-methods readers"] P8["account-ui hosted composables"] BWS["billing-web session + sign-in"] BWV["billing-web /v1 surfaces"] CORS["cloud PR 9512 ingest CORS + return hosts"] PUB["npm publish account-core / billing-contract"] P7["Phase 7 host proof: Platform + billing-web live"] P6C["Phase 6 contract tests"] P6["Phase 6 live evidence"] S2["Phase 5 slice 2 subscription"] FU9["customer-attention predicate"] FU11["opaque BillingServerCode"] FU12["useCredits clears on SUPERSEDED"] FU13["reader late-failure fence"] P3 --> HD FC --> HD HD --> RB P3 --> SS SS --> P7 RB --> P7 P3 --> RN RN --> PUB RB --> PUB PUB --> P7 P3 --> P8PV P3 --> P8RD P8PV --> P8 P8RD --> P8 P4 --> P8 P8 --> S2 P8 --> BWS BWS --> BWV RB --> BWV BWV --> P7 CORS --> P7 P5 --> P6 P3 --> P6C P5 --> WS P5 --> FU9 P3 --> FU11 P4 --> FU12 P3 --> FU13 style P3 fill:#d4edda,stroke:#155724 style P4 fill:#d4edda,stroke:#155724 style P5 fill:#d4edda,stroke:#155724 style FC fill:#d4edda,stroke:#155724 style SS fill:#d4edda,stroke:#155724 style RB fill:#d4edda,stroke:#155724 style WS fill:#d4edda,stroke:#155724 style FU9 fill:#d4edda,stroke:#155724 style P8PV fill:#d4edda,stroke:#155724 style P6C stroke:#0366d6,stroke-width:4px ```
…ced by the server (Comfy-Org#17856) Stacked on Comfy-Org#17853 (base branch `jaewon/fe-2216-subscription-rail`), which stacks on Comfy-Org#17783; merge those first. ## Why Slice 2a (Comfy-Org#17853) put cancel, resubscribe and the payment portal on the SDK rail. Subscribe — new subscriptions and plan changes — was left on the legacy call because the SDK's `subscribe` refused an active subscription on the client (`active → ALREADY_HELD`) and routed a scheduled cancel to `resubscribe()`, which carries no plan. Both contradict what the host already does: `useWorkspaceBilling.subscribe` posts `/billing/subscribe` whatever the subscription state, `useSubscriptionCheckout` quotes the change first with `previewSubscribe`, and the server prices the change, reactivates or refuses (`REACTIVATION_CONFIRMATION_REQUIRED` exists for exactly that). Decision (2026-09-16): mirror the host; no product change. ## How - **Core.** `subscribe()` issues `POST /billing/subscribe` for every subscription state and never short-circuits; the client-side eligibility switch, `eligibilityOf` and its type are gone (nothing else read them). `resubscribe()` stays the explicit "resume" command. `docs/billing-command-eligibility.md` (the path the module doc already referenced) now records the route per command and that the status read decides nothing for subscribe. - **Core, quote decoding.** The generated zod for the preview coerces every int64 to `bigint` while the generated TS type for the same fields is `number`, so the SDK's quote was not assignable to the host's `PreviewSubscribeResponse`. The cents fields are decoded as `z.number()` via `.extend` on the generated schemas (the precedent `capabilities.ts` sets for `revision`; money on this route is bounded to cents well inside the safe range). The two types are now structurally identical and `pnpm typecheck` proves the assignment with no hand-written projection. - **Host.** On the rail (read once per action, as in 2a) `useWorkspaceBilling.subscribe` maps `SubscribeOptions → SubscribeInput` field for field (`confirmationToken` / `savedPaymentMethodId` empty → dropped, as the workspace client does; nothing dropped otherwise) and runs `sdk.commands.subscribe`; `previewSubscribe` runs `sdk.commands.previewSubscribe`. Both share 2a's route latch (404 → legacy once), and every other failure is thrown as a `WorkspaceApiError` whose `.code` carries the server code verbatim, so `useSubscriptionCheckout` and `useDowngradeToPersonal` keep branching on `REACTIVATION_CONFIRMATION_REQUIRED`, `SUBSCRIPTION_PAYMENT_REQUIRED`, `OUTSTANDING_PAYMENT_REQUIRED`, `TRANSITION_NOT_ALLOWED`, `PRORATION_QUOTE_EXPIRED`, `SUBSCRIPTION_QUOTE_STALE` unchanged. - **Customer steps.** The SDK settles the operation inside `subscribe()`, so nothing else watches it: the store's lifecycle subscriber now handles non-topup pending states — the existing in-page challenge driver, and a once-per-operation `window.open(actionUrl)` with the same popup-blocked toast the checkout shows. Without both, a 3DS plan change or a `needs_payment_method` answer would time out with nothing on screen. - **Settled response.** A settled subscribe projects to the `{ billing_op_id, status: 'subscribed' }` body `handleSubscribeResponse` already handles; `needs_payment_method` / `pending_payment` never reach the host because the lifecycle drove them first. - Not on the rail: `teamSubscriptionCheckoutUtil.ts` calls `workspaceApi.subscribe` directly and stays legacy on both rails; `savePendingSubscriptionCheckout` and checkout-journey `billing_op_id` linking run after settlement rather than at issue, because the SDK does not surface the issued operation (recovery across reloads is the lifecycle's `recover()`). ## AS-IS / TO-BE Same journey on both: `?pricing=creator&cycle=yearly` against an active `standard-annual` subscription on the `stripe` rail, 1280×800, every endpoint mocked. | State | AS-IS — `billing_sdk_subscription_enabled: false` | TO-BE — `billing_sdk_subscription_enabled: true` | | --- | --- | --- | | "Confirm your upgrade" with the quote | <img width="480" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17856-screenshots/screenshots/as-is-confirm-upgrade.png"> | <img width="480" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17856-screenshots/screenshots/to-be-confirm-upgrade.png"> | | "You're all set" after confirming | <img width="480" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17856-screenshots/screenshots/as-is-all-set.png"> | <img width="480" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17856-screenshots/screenshots/to-be-all-set.png"> | | Recorded `subscribe` request (quote above it carries no key on either rail) | no `Idempotency-Key` <br> <img width="480" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17856-screenshots/screenshots/as-is-subscribe-headers.png"> | `Idempotency-Key` present and echoed as `idempotency_key` <br> <img width="480" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17856-screenshots/screenshots/to-be-subscribe-headers.png"> | | `POST /billing/subscribe` answers 404 | one POST, the click fails ("Request failed with status code 404") <br> <img width="480" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17856-screenshots/screenshots/as-is-404-fallback.png"> | two POSTs from one click — first with the key → 404, second without → 200, "You're all set" <br> <img width="480" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17856-screenshots/screenshots/to-be-404-fallback.png"> | | Server answers `REACTIVATION_CONFIRMATION_REQUIRED` | re-quotes, shows the reactivation panel and the coded toast <br> <img width="480" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17856-screenshots/screenshots/as-is-reactivation-required.png"> | identical panel, toast and CTA on the rail <br> <img width="480" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17856-screenshots/screenshots/to-be-reactivation-required.png"> | - AS-IS (flag off): quote and subscribe go through the workspace API; a 3DS or payment-method step is driven by the checkout composable off the raw response. - TO-BE (flag on): the same screens and copy; quote and subscribe go through the SDK transport (`Idempotency-Key` on the subscribe POST), settlement through the operation lifecycle; a 404 falls back to the legacy call. ## Testing | Gate | Result | | --- | --- | | `packages/account` vitest | 39 files, 634 tests (new: active plan change issues the request; canceled carries `plan_slug` + `confirm_reactivation`; `REACTIVATION_CONFIRMATION_REQUIRED` surfaces coded) | | host vitest (billing sdk, composables/billing, workspace composables + stores, feature flags) | 41 files, 1151 tests | | `pnpm typecheck`, `typecheck:browser`, `lint`, `format`, `knip` | exit 0 | | `fallow audit --changed-since origin/jaewon/fe-2216-subscription-rail` | no issues in 10 changed files, complexity 0, duplication 0 | | Playwright cloud: `planChangeSdkRail.spec.ts` (3) + `cancelSubscriptionSdkRail.spec.ts` (3) | `6 passed (11.5s)` — `PLAYWRIGHT_TEST_URL=http://localhost:5173 pnpm exec playwright test --project=cloud browser_tests/tests/dialogs/planChangeSdkRail.spec.ts browser_tests/tests/dialogs/cancelSubscriptionSdkRail.spec.ts --reporter=list` against a `pnpm dev:cloud` vite server, all endpoints mocked | ## Where this sits in the plan Billing SDK track FE-2210 ([implementation plan V2](https://app.notion.com/p/3d86d73d36508152b92cdbdfdfe83ac8)). Hybrid model: top-up in-app, subscription management / invoices / payment methods on the hosted billing app. | Phase | Item | Ticket | Status | | --- | --- | --- | --- | | 1-2 | Session core, transport, readers | FE-2211/2212/2213 | merged | | 3 | Operation lifecycle, commands, eight-state projection | FE-2227/2214/2223 | merged (Comfy-Org#17655) | | 4 | `@comfyorg/account-ui` composables + `CheckoutSteps` | FE-2215 | merged (Comfy-Org#17662, Comfy-Org#17663) | | 5 slice 1 | Top-up through the SDK behind `billing_sdk_topup_enabled` | FE-2216 | merged (Comfy-Org#17665) | | rollout C | `hosted_billing_destination` server flag read by the host | FE-2218 | merged (Comfy-Org#17716) | | rollout C | `hostedDestination` port on the lifecycle, value on operation state | FE-2210/2218 | Comfy-Org#17783 (review) | | 7 prep | Scope-source port + credentialed transport (BFF / cookie hosts) | FE-2218 | merged (Comfy-Org#17782) | | 7 prep | `@comfyorg/account` → `@comfyorg/account-core` rename | FE-2218 | Comfy-Org#17851 (review) | | 7 prep | `billing-contract` route builder + `return_to` registry | FE-2218 | merged (Comfy-Org#17795) | | 3A-3 | Workshop adapter over `createHostedTopupCheckout` | FE-2214 | merged (Comfy-Org#17793) | | 8 core | `previewSubscribe` command | FE-2331 | merged (Comfy-Org#17797) | | 8 core | Plans + saved payment-methods readers | FE-2331 | merged (Comfy-Org#17798) | | 8 ui | account-ui composables (`usePlans`, `usePaymentMethods`, `usePreviewSubscribe`) | FE-2331 | merged (Comfy-Org#17798) | | 7 | billing-web own-origin session, sign-in, SDK composition | FE-2218 | merged (Comfy-Org#17798) | | 7 | billing-web unit tests in CI (`ci-billing-web-unit.yaml`) | FE-2218 | merged (Comfy-Org#17827, Comfy-Org#17844) | | 7 | ingest CORS + top-up return hosts for billing.comfy.org and its previews (Comfy-Org/cloud) | FE-2218 | merged (Comfy-Org/cloud#9512) | | 8 ui | billing-web `/v1` entry routing + subscription / payment-method surfaces | FE-2331 | merged (Comfy-Org#17798) | | 7 | npm publish (`ingest-types`, `account-core`, `billing-contract`), Platform install, billing-web live top-up | FE-2218 | todo | | 6 | Contract tests per generated schema (package layer) | FE-2217 | Comfy-Org#17829 (review) | | 6 | Live E2E per flow × consumer + evidence table | FE-2217 | todo (needs staging flags) | | 5 slice 2a | Cancel, resubscribe and payment portal through the SDK behind `billing_sdk_subscription_enabled` | FE-2216 | Comfy-Org#17853 (review; parent of this PR) | | 5 slice 2b | Subscribe and plan change through the SDK: quote, then subscribe; the SDK never short-circuits on the client | FE-2216 | **this PR** | | follow-up | One `needsCustomerAttention` predicate (from the Comfy-Org#17665 review) | FE-2216 | merged (Comfy-Org#17792) | | follow-up | Opaque `BillingServerCode` (from the Comfy-Org#17656 review) | FE-2227 | merged (Comfy-Org#17794) | | follow-up | `useCredits` clears on `SUPERSEDED` (from the Comfy-Org#17799 review) | FE-2215 | merged (Comfy-Org#17824) | | follow-up | credits / status / capabilities readers fence a late failure as `SUPERSEDED` (from the Comfy-Org#17798 review) | FE-2331 | merged (Comfy-Org#17828) | ```mermaid flowchart LR P3["Phase 3 core lifecycle (merged)"] P4["Phase 4 account-ui (merged)"] P5["Phase 5 slice 1 top-up flag (merged)"] FC["PR 17716 hosted_billing_destination flag (merged)"] HD["PR 17783 hostedDestination port"] SS["PR 17782 scope-source port + credentialed transport"] RN["account-core rename"] RB["billing-contract route builder + return_to"] WS["Workshop adapter"] P8PV["previewSubscribe command"] P8RD["plans + payment-methods readers"] P8["account-ui hosted composables"] BWS["billing-web session + sign-in"] BWV["billing-web /v1 surfaces"] CORS["cloud PR 9512 ingest CORS + return hosts"] PUB["npm publish account-core / billing-contract"] P7["Phase 7 host proof: Platform + billing-web live"] P6C["Phase 6 contract tests"] P6["Phase 6 live evidence"] S2A["PR 17853 slice 2a cancel / resubscribe / portal rail"] S2B["Phase 5 slice 2b subscribe + plan change"] FU9["customer-attention predicate"] FU11["opaque BillingServerCode"] FU12["useCredits clears on SUPERSEDED"] FU13["reader late-failure fence"] P3 --> HD FC --> HD HD --> RB P3 --> SS SS --> P7 RB --> P7 P3 --> RN RN --> PUB RB --> PUB PUB --> P7 P3 --> P8PV P3 --> P8RD P8PV --> P8 P8RD --> P8 P4 --> P8 P8 --> S2B HD --> S2A S2A --> S2B P8 --> BWS BWS --> BWV RB --> BWV BWV --> P7 CORS --> P7 P5 --> P6 P3 --> P6C P5 --> WS P5 --> FU9 P3 --> FU11 P4 --> FU12 P3 --> FU13 style P3 fill:#d4edda,stroke:#155724 style P4 fill:#d4edda,stroke:#155724 style P5 fill:#d4edda,stroke:#155724 style FC fill:#d4edda,stroke:#155724 style SS fill:#d4edda,stroke:#155724 style RB fill:#d4edda,stroke:#155724 style WS fill:#d4edda,stroke:#155724 style FU9 fill:#d4edda,stroke:#155724 style BWV fill:#d4edda,stroke:#155724 style BWS fill:#d4edda,stroke:#155724 style P8 fill:#d4edda,stroke:#155724 style P8RD fill:#d4edda,stroke:#155724 style CORS fill:#d4edda,stroke:#155724 style FU13 fill:#d4edda,stroke:#155724 style FU12 fill:#d4edda,stroke:#155724 style FU11 fill:#d4edda,stroke:#155724 style P8PV fill:#d4edda,stroke:#155724 style S2B stroke:#0366d6,stroke-width:4px ```
…Rs, with the versioning ADR (Comfy-Org#17881) ## Why `@comfyorg/account-core`, `@comfyorg/billing-contract` and `@comfyorg/ingest-types` are about to be installed by Platform from the public registry, and the plan had nothing on how their versions are cut. The monorepo already releases one package (`@comfyorg/design-system`) through a version-bump PR that publishes on merge; the decision (2026-09-16) is to follow that pattern for the SDK packages, generalized over a package input rather than copied, and to defer Changesets with the revisit conditions written down. ## How - `version-bump-package.yaml` — `workflow_dispatch` with `package` (account-core / billing-contract / ingest-types), `version_type`, `pre_release`; bumps on `main` and opens a `Release`-labelled PR titled `<package> <version>` (same pinned `create-pull-request` action as the design-system workflow). - `publish-package.yaml` — reusable (`workflow_dispatch` + `workflow_call`): name/version match, an explicit failure while `"private": true`, `build` and `smoke:pack` via `--if-present` (works before and after the publish-readiness PR lands), `npm view` skip on an existing version, `pnpm publish --access public --tag … --provenance` under `id-token: write`. - `publish-package-on-merge.yaml` — on a merged `Release` PR touching one of the three manifests, publishes every package whose `version` changed against the first parent (matrix), posts the release-links comment per package and the Slack notice. - `.github/actions/comment-release-links` — three additive cases so each package's summary has its own section. - `packages/{account-core,billing-contract,ingest-types}/package.json` — `"private": true` removed. Comfy-Org#17882 is merged and its smoke test proves the three tarballs install from plain Node, so the latch comes off here, in the same reviewed PR as the machinery that checks it. Nothing publishes on this merge: the on-merge job needs a `Release` label and a version change, and neither is present. - `docs/adr/RELEASES-PACKAGES-0033-sdk-packages-release-through-version-bump-prs.md` (+ index): context, the decision and each workflow's rationale, the versioning policy (`1.0.0-alpha.N` on `next` until the Phase 7 host proof, then `1.0.0`; generated-contract additions minor, removals major, decided on the regeneration PR), alternatives (Changesets, release-please, semantic-release, per-package copies) and the explicit "when to revisit Changesets" list. Written against the post-rename names (`packages/account-core`); the on-merge path filter matches once Comfy-Org#17851 lands. Design-system workflows are untouched. Not in this PR, on purpose: the `ingest-types` regeneration bump — the generator lives in Comfy-Org/cloud; the one-step change needed there is recorded in the ADR's follow-ups. **Snapshot publishing is not in this PR.** A `pull_request` run executes the workflow definition from the pull request's own merge ref, so a publish step triggered that way is PR-authored code holding `NPM_TOKEN`, and on `main` today no `pull_request` workflow reaches that secret. It returns in its own PR, publishing from a `workflow_run` job that runs the default branch's definition over an artifact the pull-request job produces. ## AS-IS / TO-BE No UI change; CI and docs only. - AS-IS: only `@comfyorg/design-system` has a release path; the SDK packages have no bump, no publish, no policy. - TO-BE: one dispatch bumps any of the three, the merged `Release` PR publishes with provenance, and the ADR records why Changesets waits and what the snapshot follow-up has to satisfy. ## Testing | Check | Result | | --- | --- | | `actionlint` on the four workflows | 0 findings | | `zizmor --min-severity medium` | clean apart from the repo-exempt `actions/checkout@v7` / `setup-node@v6` pins (`.pinact.yaml`); workflow-level `permissions: contents: read` added after its finding | | `yamllint` (as `ci-yaml-validation.yaml` runs it) | clean | | `pnpm adr:check`, `pnpm lint`, `pnpm format:check`, `pnpm knip` | exit 0 | After the second review round (860ef8a, 8f7972f, 41793c7): `publish-package.yaml` rejects a prerelease on `latest` and reports whether it published or skipped, and `version-bump-package.yaml` holds `account-core` and `billing-contract` on the `1.0.0-alpha.N` line, since `patch`, `minor` and `major` all turn `1.0.0-alpha.0` into `1.0.0`. The hardening that round added to the snapshot workflow left with it in 25b09c3. After the first review round (23b854e, 5985af7): the manual publish no longer takes a caller-supplied `ref` (it publishes the ref it was dispatched on), and the ADR scopes the prerelease-first gate to the hand-written packages, putting `ingest-types` outside it. The Slack notice posts to `#proj-billing` (`C0BNGQG2LCW`), not the design-system channel. Open points for review: `--provenance` is new relative to the design-system publish and is confirmed on the first real run; Follow-ups, not in this PR: a protected `environment` with required reviewers and an environment-scoped `NPM_TOKEN` on the publish job (repo configuration), and the same `ref` removal on `publish-design-system.yaml`. ## Where this sits in the plan Billing SDK track FE-2210 ([implementation plan V2](https://app.notion.com/p/3d86d73d36508152b92cdbdfdfe83ac8)). Hybrid model: top-up in-app, subscription management / invoices / payment methods on the hosted billing app. | Phase | Item | Ticket | Status | | --- | --- | --- | --- | | 1-2 | Session core, transport, readers | FE-2211/2212/2213 | merged | | 3 | Operation lifecycle, commands, eight-state projection | FE-2227/2214/2223 | merged (Comfy-Org#17655) | | 4 | `@comfyorg/account-ui` composables + `CheckoutSteps` | FE-2215 | merged (Comfy-Org#17662, Comfy-Org#17663) | | 5 slice 1 | Top-up through the SDK behind `billing_sdk_topup_enabled` | FE-2216 | merged (Comfy-Org#17665) | | rollout C | `hosted_billing_destination` server flag read by the host | FE-2218 | merged (Comfy-Org#17716) | | rollout C | `hostedDestination` port on the lifecycle, value on operation state | FE-2210/2218 | Comfy-Org#17783 (review, carries slice 2a) | | 7 prep | Scope-source port + credentialed transport (BFF / cookie hosts) | FE-2218 | merged (Comfy-Org#17782) | | 7 prep | `@comfyorg/account` → `@comfyorg/account-core` rename | FE-2218 | Comfy-Org#17851 (queued) | | 7 prep | `billing-contract` route builder + `return_to` registry | FE-2218 | merged (Comfy-Org#17795) | | 3A-3 | Workshop adapter over `createHostedTopupCheckout` | FE-2214 | merged (Comfy-Org#17793) | | 8 core | `previewSubscribe` command | FE-2331 | merged (Comfy-Org#17797) | | 8 core | Plans + saved payment-methods readers | FE-2331 | merged (Comfy-Org#17798) | | 8 ui | account-ui composables (`usePlans`, `usePaymentMethods`, `usePreviewSubscribe`) | FE-2331 | merged (Comfy-Org#17798) | | 7 | billing-web own-origin session, sign-in, SDK composition | FE-2218 | merged (Comfy-Org#17798) | | 7 | billing-web unit tests in CI (`ci-billing-web-unit.yaml`) | FE-2218 | merged (Comfy-Org#17827, Comfy-Org#17844) | | 7 | ingest CORS + top-up return hosts for billing.comfy.org and its previews (Comfy-Org/cloud) | FE-2218 | merged (Comfy-Org/cloud#9512) | | 8 ui | billing-web `/v1` entry routing + subscription / payment-method surfaces | FE-2331 | merged (Comfy-Org#17798) | | 7 | Package release workflows + versioning ADR (bump dispatch → publish on merge) | FE-2218 | **this PR** | | 7 | Pre-merge snapshots from a default-branch `workflow_run` job | FE-2218 | todo (split out of this PR) | | 7 | Publish readiness: dist build, files allowlist, pack smoke test, private-utility cut | FE-2218 | merged (Comfy-Org#17882) | | 7 | `private` off on the three manifests | FE-2218 | **this PR** | | 7 | First publish (bump PRs: ingest-types, then billing-contract, account-core), Platform install, billing-web live top-up | FE-2218 | todo | | 6 | Contract tests per generated schema (package layer) | FE-2217 | Comfy-Org#17829 (review) | | 6 | Live E2E per flow × consumer + evidence table | FE-2217 | todo (needs staging flags) | | 5 slice 2 | Subscription flows through the SDK | FE-2216 | Comfy-Org#17856 / Comfy-Org#17860 (review) | | follow-up | One `needsCustomerAttention` predicate (from the Comfy-Org#17665 review) | FE-2216 | merged (Comfy-Org#17792) | | follow-up | Opaque `BillingServerCode` (from the Comfy-Org#17656 review) | FE-2227 | merged (Comfy-Org#17794) | | follow-up | `useCredits` clears on `SUPERSEDED` (from the Comfy-Org#17799 review) | FE-2215 | merged (Comfy-Org#17824) | | follow-up | credits / status / capabilities readers fence a late failure as `SUPERSEDED` (from the Comfy-Org#17798 review) | FE-2331 | merged (Comfy-Org#17828) | ```mermaid flowchart LR P3["Phase 3 core lifecycle (merged)"] P4["Phase 4 account-ui (merged)"] P5["Phase 5 slice 1 top-up flag (merged)"] FC["PR 17716 hosted_billing_destination flag (merged)"] HD["PR 17783 hostedDestination port"] SS["PR 17782 scope-source port + credentialed transport"] RN["account-core rename"] RB["billing-contract route builder + return_to"] WS["Workshop adapter"] P8PV["previewSubscribe command"] P8RD["plans + payment-methods readers"] P8["account-ui hosted composables"] BWS["billing-web session + sign-in"] BWV["billing-web /v1 surfaces"] CORS["cloud PR 9512 ingest CORS + return hosts"] RW["release workflows + ADR"] PUB["npm publish account-core / billing-contract"] P7["Phase 7 host proof: Platform + billing-web live"] P6C["Phase 6 contract tests"] P6["Phase 6 live evidence"] S2["Phase 5 slice 2 subscription"] FU9["customer-attention predicate"] FU11["opaque BillingServerCode"] FU12["useCredits clears on SUPERSEDED"] FU13["reader late-failure fence"] P3 --> HD FC --> HD HD --> RB P3 --> SS SS --> P7 RB --> P7 P3 --> RN RN --> PUB RW --> PUB RB --> PUB PUB --> P7 P3 --> P8PV P3 --> P8RD P8PV --> P8 P8RD --> P8 P4 --> P8 P8 --> S2 P8 --> BWS BWS --> BWV RB --> BWV BWV --> P7 CORS --> P7 P5 --> P6 P3 --> P6C P5 --> WS P5 --> FU9 P3 --> FU11 P4 --> FU12 P3 --> FU13 style P3 fill:#d4edda,stroke:#155724 style P4 fill:#d4edda,stroke:#155724 style P5 fill:#d4edda,stroke:#155724 style FC fill:#d4edda,stroke:#155724 style SS fill:#d4edda,stroke:#155724 style RB fill:#d4edda,stroke:#155724 style WS fill:#d4edda,stroke:#155724 style FU9 fill:#d4edda,stroke:#155724 style BWV fill:#d4edda,stroke:#155724 style BWS fill:#d4edda,stroke:#155724 style P8 fill:#d4edda,stroke:#155724 style P8RD fill:#d4edda,stroke:#155724 style CORS fill:#d4edda,stroke:#155724 style FU13 fill:#d4edda,stroke:#155724 style FU12 fill:#d4edda,stroke:#155724 style FU11 fill:#d4edda,stroke:#155724 style P8PV fill:#d4edda,stroke:#155724 style RW stroke:#0366d6,stroke-width:4px ```
Linear FE-2218.
Why
apps/billing-webhas a Vitest suite (App.test.ts,EmbeddedCheckout.test.ts, with ~10 more files landing in #17798) that runs in zero CI steps today.ci-tests-unit.yamlruns the root Vitest suite and then loops over a fixed package list (account account-ui billing-contract object-info-parser shared-frontend-utils design-system) —@comfyorg/billing-webis not in that loop, and the workflow'schanges-filtershould-rungate excludesapps/**outright, so a billing-web-only PR skips the job entirely.apps/websitehas its ownci-website-unit.yaml; billing-web had no equivalent. A broken billing-web test could merge green.How
New
.github/workflows/ci-billing-web-unit.yaml, modelled onci-website-unit.yaml:pushtomain,pull_request(branches-ignore: [wip/*, draft/*, temp/*]), andmerge_group. Nopaths:filter on the triggers: apaths:-filtered workflow produces no check run at all when the paths do not match, so it can never be a required check, and it would leave the merge queue waiting.changesjob runs./.github/actions/changes-filter, andbilling-web-unitisneeds: changeswithif: app-billing-web-changes == 'true' || packages-changes == 'true'. A newapp-billing-web-changesoutput computed fromapps/billing-web/**is added to that action, next to the existingapp-website-changes; shared deps (.nvmrc, rootpackage.json,pnpm-lock.yaml,pnpm-workspace.yaml) fold in automatically like every otherapp-*output, and the existingpackages-changesalready coverspackages/**— includingaccount,account-ui, andbilling-contract.billing-web-unit-gatejob (needs: [changes, billing-web-unit],if: always()) emits the stable branch-protection context: it passes when the unit job succeeded, or when it was skipped and filtering itself succeeded and found no billing-web or package changes, and fails otherwise. Same success/skip logic aswebsite-unit-gate, so a filter-step failure cannot be mistaken for "nothing to run".ubuntu-latest+./.github/actions/setup-frontend(pnpm,.nvmrcNode, lockfile-keyed pnpm store cache), plus the repo's usual${{ github.workflow }}-${{ github.ref }}cancel-in-progress concurrency andcontents: read.pnpm --filter @comfyorg/billing-web test:coverageand uploadsapps/billing-web/coverage/lcov.infoto Codecov under flagbilling-web, re-rooted withnetwork_prefix: apps/billing-web/so paths cannot collide with root-app coverage.fail_ci_if_error: ${{ github.event.pull_request.head.repo.fork != true }}, matching the website workflow — forks have no token, so upload failures cannot block outside contributors.codecov.ymldeclares the new flag withpaths: apps/billing-web/src/**andcarryforward: false, matching thewebsite-unitentry, so patch coverage is attributed correctly and a missing upload is not papered over with stale data.No typecheck or build job here:
pnpm typecheck(root) already fans out totypecheck:billing-web,pnpm lintalready runspnpm --filter @comfyorg/billing-web lint, and both run on every PR through the ungatedci-lint-format.yaml.vite buildfor billing-web is still uncovered by CI — out of scope for this PR.AS-IS / TO-BE
No UI change.
grep -rn "billing-web" .github/workflows/returns nothing. The billing-web suite executes in no CI job on any event.CI: Billing Web Unitreports on every PR and merge-queue candidate. A PR touchingapps/billing-web/**orpackages/**executes the suite with coverage and reports it to Codecov under thebilling-webflag; any other PR skips the test job but still emits a passingbilling-web-unit-gate, so the check can be marked required.Testing
pnpm --filter @comfyorg/billing-web test:coverage— 2 test files, 7 tests passed; 98.33% statements, 100% branches, 90% functions, 98.27% lines.apps/billing-web/coverage/lcov.infowritten at the path the workflow uploads.yamllint --config-file .yamllint .github/workflows/ci-billing-web-unit.yaml .github/actions/changes-filter/action.yaml codecov.yml— clean (same linter and config asci-yaml-validation.yaml). Workflow also parses and resolves to the expectedon(push/pull_request/merge_group) andjobs(changes,billing-web-unit,billing-web-unit-gate) structure.diffagainstci-website-unit.yamlshows only name, path, and filter-output renames plus the narrowerpush: branches: [main]— the gate job's logic is byte-identical apart from those substitutions..pinact.yaml:actions/checkout@v7is inignore_actions,codecov/codecov-actionis SHA-pinned to the same commitci-website-unit.yamluses.Where this sits in the plan
Billing SDK track FE-2210 (implementation plan V2). Hybrid model: top-up in-app, subscription management / invoices / payment methods on the hosted billing app.
@comfyorg/account-uicomposables +CheckoutStepsbilling_sdk_topup_enabledhosted_billing_destinationserver flag read by the hosthostedDestinationport on the lifecycle, value on operation state@comfyorg/account→@comfyorg/account-corerenamebilling-contractroute builder +return_toregistrycreateHostedTopupCheckoutpreviewSubscribecommandusePlans,usePaymentMethods,usePreviewSubscribe)ci-billing-web-unit.yaml)/v1entry routing + subscription / payment-method surfacesingest-types,account-core,billing-contract), Platform install, billing-web live top-upneedsCustomerAttentionpredicate (from the #17665 review)BillingServerCode(from the #17656 review)useCreditsclears onSUPERSEDED(from the #17799 review)