Skip to content

FE-2218 ci: self-test the billing-web unit workflow and give its flag a status - #17844

Merged
dante01yoon merged 2 commits into
mainfrom
jaewon/fe-2218-billing-web-codecov-flag-followups
Sep 16, 2026
Merged

dante01yoon merged 2 commits into
mainfrom
jaewon/fe-2218-billing-web-codecov-flag-followups

Conversation

@dante01yoon

@dante01yoon dante01yoon commented Sep 16, 2026 •

Copy link
Copy Markdown
Collaborator

Follow-up to #17827, from @huang47's review.

Why

Two of the three review points, both in files #17827 touched.

1. The workflow does not gate on itself (comment). app_billing_web listed only apps/billing-web/**, so a PR that changes nothing but ci-billing-web-unit.yaml leaves billing-web-unit skipped and billing-web-unit-gate passing through its skip branch. #17827 merged exactly that way — run 35103654481 never executed the job it added. Only the post-merge push run on main (35121739924) did, because every filter output defaults to 'true' off pull_request.

2. The flag has no status of its own (comment). codecov.yml declared the billing-web flag but no project.billing-web / patch.billing-web under coverage.status, while the website flag has both. The upload arrived with nothing attributing it, which is why #17827 showed live codecov/patch/website and codecov/project/website checks and no billing-web counterparts.

How

  • app_billing_web now lists .github/workflows/ci-billing-web-unit.yaml, the way app_website lists ci-website-e2e.yaml and its two scripts. Output description updated to match.
  • project.billing-web and patch.billing-web mirror the website entries verbatim apart from the path and flag: scoped to apps/billing-web/src/**, informational: true, flag_coverage_not_uploaded_behavior: pass, so a skipped job does not fail the status.

Also in this PR (added after the first push)

The flag rename (billing-web → billing-web-unit, @huang47's third point) landed as a second commit, 089a852. It changes flags: in ci-billing-web-unit.yaml, the flags: list of both new status entries and the flags. block in codecov.yml in one commit, so the upload and the config never disagree. The status keys stay billing-web (check names codecov/project/billing-web, codecov/patch/billing-web), mirroring how the website keeps status key website with flag website-unit. The first push could not include it because that session's token lacked the workflow scope; this push has it.

Deliberately unchanged: app_website still does not list ci-website-unit.yaml (only the e2e workflow and its two scripts), so the website unit workflow keeps the blind spot this PR fixes for billing-web. @huang47 — worth the matching one-liner, or do you want the asymmetry left alone?

AS-IS / TO-BE

No UI change; CI configuration only.

  • AS-IS: a ci-billing-web-unit.yaml-only PR skips the suite and reports a green gate. The billing-web flag uploads with no dedicated status.
  • TO-BE: that PR runs the suite. The upload gets codecov/project/billing-web and codecov/patch/billing-web.

Testing

  • curl -X POST --data-binary @codecov.yml https://codecov.io/validate → Valid!, re-run against head 089a852bfc. Both new statuses resolve to flag billing-web-unit and path (?s:apps/billing\-web/src/.*)\Z.
  • Cross-checked the three places the flag name appears — the workflow's flags:, flags.billing-web-unit in codecov.yml, and the flags: list inside both status entries — all read billing-web-unit, so the upload is attributed. The status keys stay billing-web, so the checks remain codecov/project/billing-web and codecov/patch/billing-web, mirroring the website's status key website with flag website-unit.
  • All three changed files parse as YAML; app_billing_web resolves to ['apps/billing-web/**', '.github/workflows/ci-billing-web-unit.yaml'].
  • The self-test is demonstrated on this PR. The flag-rename commit 089a852bfc edits .github/workflows/ci-billing-web-unit.yaml — the path this PR adds to app_billing_web, and the only reason the filter matched: nothing here touches apps/billing-web/**, packages/**, or the deps set, so packages-changes and deps are both false and the job's if: had exactly one way to become true. Run 35133260165: changes ✅, billing-web-unit ✅ — executed, not skipped — and billing-web-unit-gate ✅.
  • This supersedes the earlier note that the behaviour could only be observed on some other PR. The first push could not reach the workflow file (its token lacked the workflow scope); the second could, and the workflow gated on itself.
  • The statuses report on that same head: codecov/project/billing-web ✅ and codecov/patch/billing-web ✅ — the half FE-2218 ci: run the billing-web unit tests on pull requests #17827 had no counterpart for.

Where this sits in the plan

Billing SDK track FE-2210 (implementation plan V2). Hybrid model: top-up in-app, subscription management / invoices / payment methods on the hosted billing app.

Phase Item Ticket Status
1-2 Session core, transport, readers FE-2211/2212/2213 merged
3 Operation lifecycle, commands, eight-state projection FE-2227/2214/2223 merged (#17655)
4 @comfyorg/account-ui composables + CheckoutSteps FE-2215 merged (#17662, #17663)
5 slice 1 Top-up through the SDK behind billing_sdk_topup_enabled FE-2216 merged (#17665)
rollout C hosted_billing_destination server flag read by the host FE-2218 merged (#17716)
rollout C hostedDestination port on the lifecycle, value on operation state FE-2210/2218 #17783 (review)
7 prep Scope-source port + credentialed transport (BFF / cookie hosts) FE-2218 merged (#17782)
7 prep @comfyorg/account → @comfyorg/account-core rename FE-2218 todo (after #17783, #17794)
7 prep billing-contract route builder + return_to registry FE-2218 merged (#17795)
3A-3 Workshop adapter over createHostedTopupCheckout FE-2214 merged (#17793)
8 core previewSubscribe command FE-2331 merged (#17797)
8 core Plans + saved payment-methods readers FE-2331 #17798 (review)
8 ui account-ui composables (usePlans, usePaymentMethods, usePreviewSubscribe) FE-2331 #17798 (review)
7 billing-web own-origin session, sign-in, SDK composition FE-2218 #17798 (review)
7 billing-web unit tests in CI (ci-billing-web-unit.yaml) FE-2218 merged (#17827); this PR (#17844) self-tests the workflow and adds the flag statuses
7 ingest CORS + top-up return hosts for billing.comfy.org and its previews (Comfy-Org/cloud) FE-2218 Comfy-Org/cloud#9512 (approved x2, CI rerun)
8 ui billing-web /v1 entry routing + subscription / payment-method surfaces FE-2331 #17798 (review)
7 npm publish (ingest-types, account-core, billing-contract), Platform install, billing-web live top-up FE-2218 todo
6 Contract tests per generated schema (package layer) FE-2217 #17829 (review)
6 Live E2E per flow × consumer + evidence table FE-2217 todo (needs staging flags)
5 slice 2 Subscription flows through the SDK FE-2216 todo (plan-change decision)
follow-up One needsCustomerAttention predicate (from the #17665 review) FE-2216 merged (#17792)
follow-up Opaque BillingServerCode (from the #17656 review) FE-2227 #17794 (review)
follow-up useCredits clears on SUPERSEDED (from the #17799 review) FE-2215 merged (#17824)
follow-up credits / status / capabilities readers fence a late failure as SUPERSEDED (from the #17798 review) FE-2331 merged (#17828)
flowchart LR
  P3["Phase 3 core lifecycle (merged)"]
  P4["Phase 4 account-ui (merged)"]
  P5["Phase 5 slice 1 top-up flag (merged)"]
  FC["PR 17716 hosted_billing_destination flag (merged)"]
  HD["PR 17783 hostedDestination port"]
  SS["PR 17782 scope-source port + credentialed transport"]
  RN["account-core rename"]
  RB["billing-contract route builder + return_to"]
  WS["Workshop adapter"]
  P8PV["previewSubscribe command"]
  P8RD["plans + payment-methods readers"]
  P8["account-ui hosted composables"]
  BWS["billing-web session + sign-in"]
  BWV["billing-web /v1 surfaces"]
  CORS["cloud PR 9512 ingest CORS + return hosts"]
  PUB["npm publish account-core / billing-contract"]
  P7["Phase 7 host proof: Platform + billing-web live"]
  CI["billing-web unit CI: PR 17827 (merged) + PR 17844 follow-up"]
  P6C["Phase 6 contract tests"]
  P6["Phase 6 live evidence"]
  S2["Phase 5 slice 2 subscription"]
  FU9["customer-attention predicate"]
  FU11["opaque BillingServerCode"]
  FU12["useCredits clears on SUPERSEDED"]
  FU13["reader late-failure fence"]
  P3 --> HD
  FC --> HD
  HD --> RB
  P3 --> SS
  SS --> P7
  RB --> P7
  P3 --> RN
  RN --> PUB
  RB --> PUB
  PUB --> P7
  P3 --> P8PV
  P3 --> P8RD
  P8PV --> P8
  P8RD --> P8
  P4 --> P8
  P8 --> S2
  P8 --> BWS
  BWS --> BWV
  RB --> BWV
  BWV --> P7
  CORS --> P7
  BWS --> CI
  CI --> P7
  P5 --> P6
  P3 --> P6C
  P5 --> WS
  P5 --> FU9
  P3 --> FU11
  P4 --> FU12
  P3 --> FU13
  style P3 fill:#d4edda,stroke:#155724
  style P4 fill:#d4edda,stroke:#155724
  style P5 fill:#d4edda,stroke:#155724
  style FC fill:#d4edda,stroke:#155724
  style SS fill:#d4edda,stroke:#155724
  style RB fill:#d4edda,stroke:#155724
  style WS fill:#d4edda,stroke:#155724
  style FU9 fill:#d4edda,stroke:#155724
  style P8PV fill:#d4edda,stroke:#155724
  style CI stroke:#0366d6,stroke-width:4px
Loading

@dante01yoon
dante01yoon requested a review from a team September 16, 2026 17:02
@vercel

vercel Bot commented Sep 16, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
billing-web Ignored Ignored Preview Sep 16, 2026 6:15pm UTC

Request Review

@github-actions

github-actions Bot commented Sep 16, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 2022 passed, 0 failed · 2 flaky

📊 Browser Reports
  • chromium: View Report (✅ 2001 / ❌ 0 / ⚠️ 2 / ⏭️ 13)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle: 10 MB gzip ⚪ 0 B

Details

Summary

  • Raw size: 42.6 MB baseline 42.6 MB — ⚪ 0 B
  • Gzip: 10 MB baseline 10 MB — ⚪ 0 B
  • Brotli: 7.07 MB baseline 7.07 MB — ⚪ 0 B
  • Bundles: 451 current • 451 baseline

Category Glance
Vendor & Third-Party ⚪ 0 B (18.2 MB) · Other ⚪ 0 B (17.5 MB) · Data & Services ⚪ 0 B (3.81 MB) · Graph Workspace ⚪ 0 B (1.44 MB) · Panels & Settings ⚪ 0 B (623 kB) · Utilities & Hooks ⚪ 0 B (561 kB) · + 5 more

App Entry Points — 3.73 kB (baseline 3.73 kB) • ⚪ 0 B

Main entry bundles and manifests

Status: 1 unchanged

Graph Workspace — 1.44 MB (baseline 1.44 MB) • ⚪ 0 B

Graph editor runtime, canvas, workflow orchestration

Status: 3 unchanged

Views & Navigation — 132 kB (baseline 132 kB) • ⚪ 0 B

Top-level views, pages, and routed surfaces

Status: 18 unchanged

Panels & Settings — 623 kB (baseline 623 kB) • ⚪ 0 B

Configuration panels, inspectors, and settings screens

Status: 27 unchanged

User & Accounts — 32.3 kB (baseline 32.3 kB) • ⚪ 0 B

Authentication, profile, and account management bundles

Status: 11 unchanged

Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 B

Modals, dialogs, drawers, and in-app editors

Status: 8 unchanged

UI Components — 123 kB (baseline 123 kB) • ⚪ 0 B

Reusable component library chunks

Status: 16 unchanged

Data & Services — 3.81 MB (baseline 3.81 MB) • ⚪ 0 B

Stores, services, APIs, and repositories

Status: 16 unchanged

Utilities & Hooks — 561 kB (baseline 561 kB) • ⚪ 0 B

Helpers, composables, and utility bundles

Status: 37 unchanged

Vendor & Third-Party — 18.2 MB (baseline 18.2 MB) • ⚪ 0 B

External libraries and shared vendor chunks

Status: 18 unchanged

Other — 17.5 MB (baseline 17.5 MB) • ⚪ 0 B

Bundles that do not match a named category

Status: 296 unchanged

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 62.7 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.3 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 61.0 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 76.7 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 79.0 MB heap
large-graph-pan: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.8 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.9 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 80.2 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 80.1 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.4 MB heap
subgraph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.5 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.3 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 132ms TBT · 96.0 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 76.1 MB heap
vue-large-graph-idle: · 56.3 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 178.3 MB heap
vue-large-graph-pan: · 55.4 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 160ms TBT · 164.9 MB heap
vue-node-resize-workload: · 55.4 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 533ms TBT · 168.1 MB heap
vue-zoom-out-idle: · 54.6 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 163.9 MB heap
workflow-execution: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 62.1 MB heap

⚠️ 2 regressions detected

Show regressions
Metric Baseline PR (median) Δ Sig
canvas-idle: p95 frame time 17ms 17ms +1% ⚠️ z=2.9
subgraph-idle: p95 frame time 17ms 17ms +1% ⚠️ z=2.2
All metrics
Metric Baseline PR (median) Δ Sig
canvas-idle: avg frame time 17ms 17ms -0% z=0.9
canvas-idle: p95 frame time 17ms 17ms +1% ⚠️ z=2.9
canvas-idle: layout duration 0ms 0ms +0% —
canvas-idle: style recalc duration 7ms 8ms +10% z=0.2
canvas-idle: layout count 0 0 +0% —
canvas-idle: style recalc count 8 8 +0% z=-0.2
canvas-idle: task duration 449ms 518ms +15% z=0.8
canvas-idle: script duration 9ms 10ms +21% z=0.5
canvas-idle: TBT 0ms 0ms +0% —
canvas-idle: heap used 61.6 MB 62.7 MB +2% z=0.0
canvas-idle: DOM nodes -263 -265 +1% z=-0.6
canvas-idle: event listeners -154 -156 +1% z=-0.4
canvas-mouse-sweep: avg frame time 17ms 17ms +0% z=0.9
canvas-mouse-sweep: p95 frame time 17ms 17ms +0% z=0.4
canvas-mouse-sweep: layout duration 4ms 5ms +10% z=0.4
canvas-mouse-sweep: style recalc duration 30ms 33ms +10% z=0.8
canvas-mouse-sweep: layout count 14 14 +0% —
canvas-mouse-sweep: style recalc count 74 78 +5% z=0.8
canvas-mouse-sweep: task duration 875ms 896ms +2% z=0.4
canvas-mouse-sweep: script duration 158ms 160ms +1% z=0.0
canvas-mouse-sweep: TBT 0ms 0ms +0% —
canvas-mouse-sweep: heap used 69.7 MB 65.3 MB -6% z=-0.4
canvas-mouse-sweep: DOM nodes -263 -262 -0% z=-0.0
canvas-mouse-sweep: event listeners -156 -155 -1% z=1.2
canvas-zoom-sweep: avg frame time 17ms 17ms +0% z=0.2
canvas-zoom-sweep: p95 frame time 17ms 17ms +0% z=0.3
canvas-zoom-sweep: layout duration 1ms 1ms +14% z=0.9
canvas-zoom-sweep: style recalc duration 15ms 18ms +20% z=0.9
canvas-zoom-sweep: layout count 6 6 +0% —
canvas-zoom-sweep: style recalc count 32 31 -3% z=-1.3
canvas-zoom-sweep: task duration 334ms 367ms +10% z=0.5
canvas-zoom-sweep: script duration 11ms 14ms +28% z=0.7
canvas-zoom-sweep: TBT 0ms 0ms +0% —
canvas-zoom-sweep: heap used 61.5 MB 61.0 MB -1% z=-2.2
canvas-zoom-sweep: DOM nodes 76 76 -1% z=-0.5
canvas-zoom-sweep: event listeners 19 19 +0% z=-0.5
dom-widget-clipping: avg frame time 17ms 17ms +0% z=0.5
dom-widget-clipping: p95 frame time 17ms 17ms -0% z=-0.4
dom-widget-clipping: layout duration 0ms 0ms +0% —
dom-widget-clipping: style recalc duration 8ms 8ms -5% z=0.4
dom-widget-clipping: layout count 0 0 +0% —
dom-widget-clipping: style recalc count 12 11 -13% z=-0.3
dom-widget-clipping: task duration 435ms 467ms +7% z=0.6
dom-widget-clipping: script duration 162ms 166ms +2% z=0.3
dom-widget-clipping: TBT 0ms 0ms +0% —
dom-widget-clipping: heap used 76.6 MB 76.7 MB +0% z=1.1
dom-widget-clipping: DOM nodes 20 17 -15% z=-0.3
dom-widget-clipping: event listeners 2 1 -50% z=-2.2
large-graph-idle: avg frame time 17ms 17ms -0% z=-0.8
large-graph-idle: p95 frame time 17ms 17ms +0% z=0.3
large-graph-idle: layout duration 0ms 0ms +0% —
large-graph-idle: style recalc duration 4ms 7ms +65% z=0.2
large-graph-idle: layout count 0 0 +0% —
large-graph-idle: style recalc count 5 6 +10% z=-0.4
large-graph-idle: task duration 547ms 618ms +13% z=0.3
large-graph-idle: script duration 33ms 36ms +12% z=0.2
large-graph-idle: TBT 0ms 0ms +0% —
large-graph-idle: heap used 78.7 MB 79.0 MB +0% z=1.2
large-graph-idle: DOM nodes -249 -249 -0% z=-0.2
large-graph-idle: event listeners -182 -168 -8% z=-0.2
large-graph-pan: avg frame time 17ms 17ms -0% z=-1.2
large-graph-pan: p95 frame time 17ms 17ms +1% z=1.8
large-graph-pan: layout duration 0ms 0ms +0% —
large-graph-pan: style recalc duration 12ms 13ms +8% z=0.5
large-graph-pan: layout count 0 0 +0% —
large-graph-pan: style recalc count 66 66 +0% z=0.2
large-graph-pan: task duration 1587ms 1646ms +4% z=0.2
large-graph-pan: script duration 788ms 815ms +3% z=-0.0
large-graph-pan: TBT 0ms 0ms +0% variance too high
large-graph-pan: heap used 75.8 MB 73.8 MB -3% z=-0.2
large-graph-pan: DOM nodes -249 -253 +2% z=-0.9
large-graph-pan: event listeners -154 -168 +9% z=-1.2
large-graph-zoom: avg frame time 17ms 17ms +0% z=-1.1
large-graph-zoom: p95 frame time 17ms 17ms -1% z=-1.8
large-graph-zoom: layout duration 14ms 15ms +10% z=1.0
large-graph-zoom: style recalc duration 13ms 14ms +10% z=1.6
large-graph-zoom: layout count 60 60 +0% —
large-graph-zoom: style recalc count 62 63 +1% z=0.8
large-graph-zoom: task duration 1708ms 1791ms +5% z=0.6
large-graph-zoom: script duration 776ms 811ms +4% z=0.3
large-graph-zoom: TBT 0ms 0ms +0% —
large-graph-zoom: heap used 70.7 MB 70.9 MB +0% z=0.5
large-graph-zoom: DOM nodes -257 -129 -50% z=-0.6
large-graph-zoom: event listeners -180 -85 -53% z=-0.7
legacy-node-drag: avg frame time 17ms 17ms -0% z=-0.9
legacy-node-drag: p95 frame time 17ms 17ms -0% z=-0.0
legacy-node-drag: layout duration 0ms 0ms +0% —
legacy-node-drag: style recalc duration 7ms 8ms +14% z=1.1
legacy-node-drag: layout count 0 0 +0% —
legacy-node-drag: style recalc count 42 43 +1% z=0.7
legacy-node-drag: task duration 1919ms 2005ms +4% z=0.5
legacy-node-drag: script duration 998ms 1003ms +0% z=0.3
legacy-node-drag: TBT 0ms 0ms +0% —
legacy-node-drag: heap used 80.3 MB 80.2 MB -0% z=-0.1
legacy-node-drag: DOM nodes 2 -133 -6725% z=-1.0
legacy-node-drag: event listeners 188 1 -100% z=-3.4
minimap-idle: avg frame time 17ms 17ms -0% z=-0.9
minimap-idle: p95 frame time 17ms 17ms -0% z=0.0
minimap-idle: layout duration 0ms 0ms +0% —
minimap-idle: style recalc duration 6ms 5ms -16% z=-0.1
minimap-idle: layout count 0 0 +0% —
minimap-idle: style recalc count 7 5 -29% z=-0.1
minimap-idle: task duration 614ms 632ms +3% z=0.7
minimap-idle: script duration 33ms 38ms +15% z=0.4
minimap-idle: TBT 0ms 0ms +0% —
minimap-idle: heap used 75.1 MB 80.1 MB +7% z=1.1
minimap-idle: DOM nodes -257 -250 -3% z=-0.2
minimap-idle: event listeners -184 -154 -16% z=-0.2
subgraph-dom-widget-clipping: avg frame time 17ms 17ms -0% z=-1.0
subgraph-dom-widget-clipping: p95 frame time 17ms 17ms -0% z=0.5
subgraph-dom-widget-clipping: layout duration 0ms 0ms +0% —
subgraph-dom-widget-clipping: style recalc duration 10ms 11ms +12% z=0.7
subgraph-dom-widget-clipping: layout count 0 0 +0% —
subgraph-dom-widget-clipping: style recalc count 46 48 +3% z=1.4
subgraph-dom-widget-clipping: task duration 392ms 410ms +5% z=0.2
subgraph-dom-widget-clipping: script duration 141ms 146ms +3% z=0.3
subgraph-dom-widget-clipping: TBT 0ms 0ms +0% —
subgraph-dom-widget-clipping: heap used 73.5 MB 73.4 MB -0% z=-0.5
subgraph-dom-widget-clipping: DOM nodes 18 21 +17% z=1.6
subgraph-dom-widget-clipping: event listeners 8 7 -13% z=-0.2
subgraph-idle: avg frame time 17ms 17ms -0% z=-2.6
subgraph-idle: p95 frame time 17ms 17ms +1% ⚠️ z=2.2
subgraph-idle: layout duration 0ms 0ms +0% —
subgraph-idle: style recalc duration 8ms 8ms +3% z=-0.1
subgraph-idle: layout count 0 0 +0% —
subgraph-idle: style recalc count 10 9 -10% z=-1.3
subgraph-idle: task duration 372ms 490ms +32% z=0.4
subgraph-idle: script duration 7ms 10ms +33% z=0.9
subgraph-idle: TBT 0ms 0ms +0% —
subgraph-idle: heap used 60.8 MB 63.5 MB +4% z=-0.1
subgraph-idle: DOM nodes -276 -277 +0% z=-0.4
subgraph-idle: event listeners -230 -215 -7% z=-0.5
subgraph-mouse-sweep: avg frame time 17ms 17ms -0% z=0.7
subgraph-mouse-sweep: p95 frame time 17ms 17ms -0% z=-0.0
subgraph-mouse-sweep: layout duration 6ms 6ms +8% z=0.9
subgraph-mouse-sweep: style recalc duration 26ms 31ms +20% z=1.3
subgraph-mouse-sweep: layout count 18 18 +0% —
subgraph-mouse-sweep: style recalc count 77 80 +3% z=5.6
subgraph-mouse-sweep: task duration 763ms 776ms +2% z=0.0
subgraph-mouse-sweep: script duration 100ms 113ms +12% z=0.3
subgraph-mouse-sweep: TBT 0ms 0ms +0% —
subgraph-mouse-sweep: heap used 58.8 MB 65.3 MB +11% z=0.5
subgraph-mouse-sweep: DOM nodes -273 -273 +0% z=1.9
subgraph-mouse-sweep: event listeners -232 -216 -7% z=-0.1
subgraph-transition-enter: avg frame time 17ms 17ms +0% z=0.4
subgraph-transition-enter: p95 frame time 17ms 17ms +0% z=-1.2
subgraph-transition-enter: layout duration 12ms 12ms +2% z=-0.3
subgraph-transition-enter: style recalc duration 27ms 28ms +3% z=-0.0
subgraph-transition-enter: layout count 5 5 +0% —
subgraph-transition-enter: style recalc count 17 18 +6% z=1.2
subgraph-transition-enter: task duration 875ms 938ms +7% z=0.5
subgraph-transition-enter: script duration 29ms 30ms +2% z=0.1
subgraph-transition-enter: TBT 120ms 132ms +10% z=-0.1
subgraph-transition-enter: heap used 77.9 MB 96.0 MB +23% z=0.4
subgraph-transition-enter: DOM nodes 13587 13587 +0% —
subgraph-transition-enter: event listeners 2387 2387 +0% z=0.9
viewport-pan-sweep: avg frame time 17ms 17ms -0% z=-0.6
viewport-pan-sweep: p95 frame time 17ms 17ms -1% z=-1.3
viewport-pan-sweep: layout duration 0ms 0ms +0% —
viewport-pan-sweep: style recalc duration 38ms 42ms +12% z=1.0
viewport-pan-sweep: layout count 0 0 +0% —
viewport-pan-sweep: style recalc count 248 248 -0% z=-0.1
viewport-pan-sweep: task duration 5707ms 6130ms +7% z=0.6
viewport-pan-sweep: script duration 2712ms 2905ms +7% z=0.6
viewport-pan-sweep: TBT 0ms 0ms +0% —
viewport-pan-sweep: heap used 64.8 MB 76.1 MB +17% z=0.9
viewport-pan-sweep: DOM nodes -247 -248 +0% z=-0.5
viewport-pan-sweep: event listeners -168 -137 -18% z=1.1
vue-large-graph-idle: avg frame time 18ms 18ms -0% z=0.2
vue-large-graph-idle: p95 frame time 17ms 17ms -0% z=-1.4
vue-large-graph-idle: layout duration 0ms 0ms +0% —
vue-large-graph-idle: style recalc duration 0ms 0ms +0% —
vue-large-graph-idle: layout count 0 0 +0% —
vue-large-graph-idle: style recalc count 0 0 +0% —
vue-large-graph-idle: task duration 16848ms 17870ms +6% z=0.9
vue-large-graph-idle: script duration 267ms 303ms +13% z=0.6
vue-large-graph-idle: TBT 0ms 0ms +0% variance too high
vue-large-graph-idle: heap used 162.5 MB 178.3 MB +10% z=0.6
vue-large-graph-idle: DOM nodes -8061 -8061 +0% z=-0.9
vue-large-graph-idle: event listeners -14926 -14925 -0% z=-0.9
vue-large-graph-pan: avg frame time 18ms 18ms +2% z=0.5
vue-large-graph-pan: p95 frame time 17ms 17ms +0% z=1.2
vue-large-graph-pan: layout duration 0ms 0ms +0% —
vue-large-graph-pan: style recalc duration 20ms 24ms +21% z=0.9
vue-large-graph-pan: layout count 0 0 +0% —
vue-large-graph-pan: style recalc count 159 162 +2% z=0.3
vue-large-graph-pan: task duration 21327ms 22412ms +5% z=0.8
vue-large-graph-pan: script duration 873ms 930ms +7% z=0.4
vue-large-graph-pan: TBT 150ms 160ms +6% variance too high
vue-large-graph-pan: heap used 170.0 MB 164.9 MB -3% z=-0.9
vue-large-graph-pan: DOM nodes -8061 -8061 +0% z=-0.9
vue-large-graph-pan: event listeners -14922 -14920 -0% z=-0.9
vue-node-resize-workload: avg frame time 18ms 18ms -2% z=1.0
vue-node-resize-workload: p95 frame time 17ms 17ms +0% z=1.1
vue-node-resize-workload: layout duration 24ms 28ms +18% z=1.0
vue-node-resize-workload: style recalc duration 73ms 79ms +9% z=0.4
vue-node-resize-workload: layout count 20 20 +0% —
vue-node-resize-workload: style recalc count 20 20 +0% —
vue-node-resize-workload: task duration 6148ms 6611ms +8% z=0.9
vue-node-resize-workload: script duration 112ms 133ms +19% z=1.1
vue-node-resize-workload: TBT 424ms 533ms +26% z=1.3
vue-node-resize-workload: heap used 175.2 MB 168.1 MB -4% z=-1.1
vue-node-resize-workload: DOM nodes -8061 -8061 +0% z=-0.9
vue-node-resize-workload: event listeners -14924 -14922 -0% z=-0.9
vue-zoom-out-idle: avg frame time 18ms 18ms +3% z=1.9
vue-zoom-out-idle: p95 frame time 17ms 17ms +0% z=1.0
vue-zoom-out-idle: layout duration 0ms 0ms +0% —
vue-zoom-out-idle: style recalc duration 0ms 0ms +0% —
vue-zoom-out-idle: layout count 0 0 +0% —
vue-zoom-out-idle: style recalc count 0 0 +0% —
vue-zoom-out-idle: task duration 8767ms 9002ms +3% z=0.8
vue-zoom-out-idle: script duration 145ms 150ms +4% z=0.5
vue-zoom-out-idle: TBT 0ms 0ms +0% —
vue-zoom-out-idle: heap used 181.7 MB 163.9 MB -10% z=-1.4
vue-zoom-out-idle: DOM nodes 0 0 +0% —
vue-zoom-out-idle: event listeners -14 -13 -7% z=-0.5
workflow-execution: avg frame time 17ms 17ms -0% z=-0.7
workflow-execution: p95 frame time 17ms 17ms +0% z=-1.5
workflow-execution: layout duration 2ms 1ms -40% z=-2.6
workflow-execution: style recalc duration 24ms 16ms -34% z=-1.9
workflow-execution: layout count 3 3 +0% z=-1.1
workflow-execution: style recalc count 18 8 -56% z=-1.5
workflow-execution: task duration 121ms 90ms -26% z=-1.2
workflow-execution: script duration 10ms 8ms -19% z=-0.9
workflow-execution: TBT 0ms 0ms +0% —
workflow-execution: heap used 63.9 MB 62.1 MB -3% z=-1.6
workflow-execution: DOM nodes 148 110 -26% z=-2.5
workflow-execution: event listeners 83 34 -59% z=-1.2
Historical variance (last 15 runs)
Metric μ σ CV
canvas-idle: avg frame time 17ms 0ms 0.0%
canvas-idle: p95 frame time 17ms 0ms 0.1%
canvas-idle: layout duration 0ms 0ms 0.0%
canvas-idle: style recalc duration 7ms 1ms 15.8%
canvas-idle: layout count 0 0 0.0%
canvas-idle: style recalc count 8 1 8.3%
canvas-idle: task duration 456ms 73ms 16.0%
canvas-idle: script duration 9ms 2ms 19.5%
canvas-idle: TBT 0ms 0ms 0.0%
canvas-idle: heap used 62.6 MB 3.2 MB 5.1%
canvas-idle: DOM nodes -238 43 0.0%
canvas-idle: event listeners -145 27 0.0%
canvas-mouse-sweep: avg frame time 17ms 0ms 0.0%
canvas-mouse-sweep: p95 frame time 17ms 0ms 0.2%
canvas-mouse-sweep: layout duration 5ms 0ms 7.5%
canvas-mouse-sweep: style recalc duration 30ms 4ms 13.8%
canvas-mouse-sweep: layout count 14 0 0.0%
canvas-mouse-sweep: style recalc count 76 2 2.5%
canvas-mouse-sweep: task duration 853ms 112ms 13.1%
canvas-mouse-sweep: script duration 160ms 19ms 12.1%
canvas-mouse-sweep: TBT 0ms 0ms 0.0%
canvas-mouse-sweep: heap used 66.4 MB 2.4 MB 3.6%
canvas-mouse-sweep: DOM nodes -262 1 0.0%
canvas-mouse-sweep: event listeners -162 6 0.0%
canvas-zoom-sweep: avg frame time 17ms 0ms 0.0%
canvas-zoom-sweep: p95 frame time 17ms 0ms 0.2%
canvas-zoom-sweep: layout duration 1ms 0ms 10.8%
canvas-zoom-sweep: style recalc duration 16ms 2ms 12.3%
canvas-zoom-sweep: layout count 6 0 0.0%
canvas-zoom-sweep: style recalc count 31 0 1.0%
canvas-zoom-sweep: task duration 341ms 52ms 15.2%
canvas-zoom-sweep: script duration 12ms 2ms 16.8%
canvas-zoom-sweep: TBT 0ms 0ms 0.0%
canvas-zoom-sweep: heap used 61.4 MB 187.7 KB 0.3%
canvas-zoom-sweep: DOM nodes 76 1 0.7%
canvas-zoom-sweep: event listeners 19 0 2.1%
dom-widget-clipping: avg frame time 17ms 0ms 0.0%
dom-widget-clipping: p95 frame time 17ms 0ms 0.2%
dom-widget-clipping: layout duration 0ms 0ms 0.0%
dom-widget-clipping: style recalc duration 8ms 1ms 8.2%
dom-widget-clipping: layout count 0 0 0.0%
dom-widget-clipping: style recalc count 11 1 5.8%
dom-widget-clipping: task duration 439ms 50ms 11.4%
dom-widget-clipping: script duration 160ms 19ms 11.7%
dom-widget-clipping: TBT 0ms 0ms 0.0%
dom-widget-clipping: heap used 76.3 MB 325.5 KB 0.4%
dom-widget-clipping: DOM nodes 17 1 6.8%
dom-widget-clipping: event listeners 2 0 19.5%
large-graph-idle: avg frame time 17ms 0ms 0.0%
large-graph-idle: p95 frame time 17ms 0ms 0.2%
large-graph-idle: layout duration 0ms 0ms 0.0%
large-graph-idle: style recalc duration 7ms 2ms 26.7%
large-graph-idle: layout count 0 0 0.0%
large-graph-idle: style recalc count 6 1 21.3%
large-graph-idle: task duration 593ms 82ms 13.7%
large-graph-idle: script duration 36ms 5ms 14.0%
large-graph-idle: TBT 0ms 0ms 0.0%
large-graph-idle: heap used 77.6 MB 1.2 MB 1.6%
large-graph-idle: DOM nodes -245 22 0.0%
large-graph-idle: event listeners -165 14 0.0%
large-graph-pan: avg frame time 17ms 0ms 0.0%
large-graph-pan: p95 frame time 17ms 0ms 0.2%
large-graph-pan: layout duration 0ms 0ms 0.0%
large-graph-pan: style recalc duration 12ms 2ms 13.0%
large-graph-pan: layout count 0 0 0.0%
large-graph-pan: style recalc count 66 1 2.2%
large-graph-pan: task duration 1599ms 197ms 12.3%
large-graph-pan: script duration 817ms 100ms 12.3%
large-graph-pan: TBT 0ms 0ms 387.3%
large-graph-pan: heap used 74.5 MB 5.0 MB 6.7%
large-graph-pan: DOM nodes -190 67 0.0%
large-graph-pan: event listeners -108 51 0.0%
large-graph-zoom: avg frame time 17ms 0ms 0.0%
large-graph-zoom: p95 frame time 17ms 0ms 0.2%
large-graph-zoom: layout duration 14ms 1ms 7.8%
large-graph-zoom: style recalc duration 12ms 1ms 10.0%
large-graph-zoom: layout count 60 0 0.0%
large-graph-zoom: style recalc count 61 1 2.3%
large-graph-zoom: task duration 1669ms 191ms 11.4%
large-graph-zoom: script duration 782ms 91ms 11.6%
large-graph-zoom: TBT 0ms 0ms 0.0%
large-graph-zoom: heap used 70.4 MB 1.1 MB 1.6%
large-graph-zoom: DOM nodes -96 56 0.0%
large-graph-zoom: event listeners -57 38 0.0%
legacy-node-drag: avg frame time 17ms 0ms 0.0%
legacy-node-drag: p95 frame time 17ms 0ms 0.2%
legacy-node-drag: layout duration 0ms 0ms 0.0%
legacy-node-drag: style recalc duration 7ms 1ms 15.6%
legacy-node-drag: layout count 0 0 0.0%
legacy-node-drag: style recalc count 41 2 3.7%
legacy-node-drag: task duration 1894ms 216ms 11.4%
legacy-node-drag: script duration 973ms 115ms 11.8%
legacy-node-drag: TBT 0ms 0ms 0.0%
legacy-node-drag: heap used 80.7 MB 4.4 MB 5.4%
legacy-node-drag: DOM nodes -71 62 0.0%
legacy-node-drag: event listeners 151 45 29.5%
minimap-idle: avg frame time 17ms 0ms 0.0%
minimap-idle: p95 frame time 17ms 0ms 0.2%
minimap-idle: layout duration 0ms 0ms 0.0%
minimap-idle: style recalc duration 5ms 1ms 21.2%
minimap-idle: layout count 0 0 0.0%
minimap-idle: style recalc count 5 1 27.5%
minimap-idle: task duration 572ms 82ms 14.3%
minimap-idle: script duration 36ms 6ms 15.5%
minimap-idle: TBT 0ms 0ms 0.0%
minimap-idle: heap used 77.8 MB 2.0 MB 2.6%
minimap-idle: DOM nodes -243 30 0.0%
minimap-idle: event listeners -149 36 0.0%
subgraph-dom-widget-clipping: avg frame time 17ms 0ms 0.0%
subgraph-dom-widget-clipping: p95 frame time 17ms 0ms 0.1%
subgraph-dom-widget-clipping: layout duration 0ms 0ms 0.0%
subgraph-dom-widget-clipping: style recalc duration 11ms 1ms 6.4%
subgraph-dom-widget-clipping: layout count 0 0 0.0%
subgraph-dom-widget-clipping: style recalc count 47 1 1.3%
subgraph-dom-widget-clipping: task duration 399ms 48ms 12.0%
subgraph-dom-widget-clipping: script duration 141ms 16ms 11.3%
subgraph-dom-widget-clipping: TBT 0ms 0ms 0.0%
subgraph-dom-widget-clipping: heap used 73.5 MB 171.4 KB 0.2%
subgraph-dom-widget-clipping: DOM nodes 19 1 5.8%
subgraph-dom-widget-clipping: event listeners 7 1 9.1%
subgraph-idle: avg frame time 17ms 0ms 0.0%
subgraph-idle: p95 frame time 17ms 0ms 0.2%
subgraph-idle: layout duration 0ms 0ms 0.0%
subgraph-idle: style recalc duration 8ms 1ms 12.4%
subgraph-idle: layout count 0 0 0.0%
subgraph-idle: style recalc count 10 1 5.7%
subgraph-idle: task duration 460ms 68ms 14.9%
subgraph-idle: script duration 8ms 1ms 16.7%
subgraph-idle: TBT 0ms 0ms 0.0%
subgraph-idle: heap used 64.0 MB 3.6 MB 5.7%
subgraph-idle: DOM nodes -263 34 0.0%
subgraph-idle: event listeners -202 26 0.0%
subgraph-mouse-sweep: avg frame time 17ms 0ms 0.0%
subgraph-mouse-sweep: p95 frame time 17ms 0ms 0.2%
subgraph-mouse-sweep: layout duration 6ms 1ms 9.2%
subgraph-mouse-sweep: style recalc duration 28ms 3ms 9.5%
subgraph-mouse-sweep: layout count 18 0 0.0%
subgraph-mouse-sweep: style recalc count 77 0 0.5%
subgraph-mouse-sweep: task duration 775ms 95ms 12.3%
subgraph-mouse-sweep: script duration 109ms 12ms 11.3%
subgraph-mouse-sweep: TBT 0ms 0ms 0.0%
subgraph-mouse-sweep: heap used 63.8 MB 3.1 MB 4.9%
subgraph-mouse-sweep: DOM nodes -275 1 0.0%
subgraph-mouse-sweep: event listeners -215 10 0.0%
subgraph-transition-enter: avg frame time 17ms 0ms 0.0%
subgraph-transition-enter: p95 frame time 17ms 0ms 0.3%
subgraph-transition-enter: layout duration 12ms 2ms 12.7%
subgraph-transition-enter: style recalc duration 28ms 3ms 11.6%
subgraph-transition-enter: layout count 5 0 0.0%
subgraph-transition-enter: style recalc count 17 1 5.2%
subgraph-transition-enter: task duration 865ms 139ms 16.1%
subgraph-transition-enter: script duration 30ms 5ms 17.0%
subgraph-transition-enter: TBT 134ms 28ms 20.6%
subgraph-transition-enter: heap used 92.0 MB 9.3 MB 10.1%
subgraph-transition-enter: DOM nodes 13587 0 0.0%
subgraph-transition-enter: event listeners 2386 1 0.0%
viewport-pan-sweep: avg frame time 17ms 0ms 0.0%
viewport-pan-sweep: p95 frame time 17ms 0ms 0.2%
viewport-pan-sweep: layout duration 0ms 0ms 0.0%
viewport-pan-sweep: style recalc duration 40ms 3ms 7.4%
viewport-pan-sweep: layout count 0 0 0.0%
viewport-pan-sweep: style recalc count 248 1 0.4%
viewport-pan-sweep: task duration 5721ms 735ms 12.8%
viewport-pan-sweep: script duration 2719ms 316ms 11.6%
viewport-pan-sweep: TBT 0ms 0ms 0.0%
viewport-pan-sweep: heap used 72.0 MB 4.3 MB 6.0%
viewport-pan-sweep: DOM nodes -244 7 0.0%
viewport-pan-sweep: event listeners -150 12 0.0%
vue-large-graph-idle: avg frame time 18ms 0ms 2.0%
vue-large-graph-idle: p95 frame time 17ms 0ms 0.1%
vue-large-graph-idle: layout duration 0ms 0ms 0.0%
vue-large-graph-idle: style recalc duration 0ms 0ms 0.0%
vue-large-graph-idle: layout count 0 0 0.0%
vue-large-graph-idle: style recalc count 0 0 0.0%
vue-large-graph-idle: task duration 16098ms 2063ms 12.8%
vue-large-graph-idle: script duration 273ms 48ms 17.7%
vue-large-graph-idle: TBT 0ms 0ms 387.3%
vue-large-graph-idle: heap used 174.5 MB 6.1 MB 3.5%
vue-large-graph-idle: DOM nodes -7352 784 0.0%
vue-large-graph-idle: event listeners -11451 3846 0.0%
vue-large-graph-pan: avg frame time 18ms 0ms 2.0%
vue-large-graph-pan: p95 frame time 17ms 0ms 0.1%
vue-large-graph-pan: layout duration 0ms 0ms 0.0%
vue-large-graph-pan: style recalc duration 20ms 4ms 20.2%
vue-large-graph-pan: layout count 0 0 0.0%
vue-large-graph-pan: style recalc count 153 27 17.4%
vue-large-graph-pan: task duration 20500ms 2462ms 12.0%
vue-large-graph-pan: script duration 885ms 101ms 11.4%
vue-large-graph-pan: TBT 110ms 67ms 60.8%
vue-large-graph-pan: heap used 169.7 MB 5.2 MB 3.0%
vue-large-graph-pan: DOM nodes -7352 784 0.0%
vue-large-graph-pan: event listeners -11446 3847 0.0%
vue-node-resize-workload: avg frame time 18ms 0ms 1.6%
vue-node-resize-workload: p95 frame time 17ms 0ms 0.2%
vue-node-resize-workload: layout duration 25ms 3ms 12.4%
vue-node-resize-workload: style recalc duration 76ms 9ms 11.7%
vue-node-resize-workload: layout count 20 0 0.0%
vue-node-resize-workload: style recalc count 20 0 0.0%
vue-node-resize-workload: task duration 5944ms 730ms 12.3%
vue-node-resize-workload: script duration 113ms 17ms 15.4%
vue-node-resize-workload: TBT 367ms 129ms 35.2%
vue-node-resize-workload: heap used 173.0 MB 4.3 MB 2.5%
vue-node-resize-workload: DOM nodes -7353 785 0.0%
vue-node-resize-workload: event listeners -11448 3846 0.0%
vue-zoom-out-idle: avg frame time 18ms 0ms 1.7%
vue-zoom-out-idle: p95 frame time 17ms 0ms 0.1%
vue-zoom-out-idle: layout duration 0ms 0ms 0.0%
vue-zoom-out-idle: style recalc duration 0ms 0ms 0.0%
vue-zoom-out-idle: layout count 0 0 0.0%
vue-zoom-out-idle: style recalc count 0 0 0.0%
vue-zoom-out-idle: task duration 8172ms 1016ms 12.4%
vue-zoom-out-idle: script duration 139ms 24ms 17.2%
vue-zoom-out-idle: TBT 0ms 0ms 0.0%
vue-zoom-out-idle: heap used 172.8 MB 6.4 MB 3.7%
vue-zoom-out-idle: DOM nodes 0 0 0.0%
vue-zoom-out-idle: event listeners -12 2 0.0%
workflow-execution: avg frame time 17ms 0ms 0.0%
workflow-execution: p95 frame time 17ms 0ms 0.2%
workflow-execution: layout duration 2ms 0ms 15.2%
workflow-execution: style recalc duration 21ms 3ms 13.3%
workflow-execution: layout count 4 0 12.9%
workflow-execution: style recalc count 13 4 27.7%
workflow-execution: task duration 108ms 15ms 13.9%
workflow-execution: script duration 10ms 2ms 19.1%
workflow-execution: TBT 0ms 0ms 0.0%
workflow-execution: heap used 63.2 MB 690.5 KB 1.1%
workflow-execution: DOM nodes 133 9 7.0%
workflow-execution: event listeners 59 21 36.0%
Trend (last 15 commits on main)
Metric Trend Dir Latest
canvas-idle: avg frame time ▁█▆▃▆▃▆▃▁▆▃▁▃▁▆ ➡️ 17ms
canvas-idle: p95 frame time ▄▄█▅▄█▄▁▄█▄▅██▄ ➡️ 17ms
canvas-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-idle: style recalc duration █▅▅▆▆▇▅▁▁▄▃▄▇▂▄ 📉 7ms
canvas-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
canvas-idle: style recalc count ▇▄▄▄▆▄▄▁█▄▄▆▄▇▄ ➡️ 8
canvas-idle: task duration ▅▆▆▅▄▅█▆▁▆▅▄▇▃▅ 📉 443ms
canvas-idle: script duration ▇▅▆▆▃▆█▄▁▅▅▃▆▃▄ 📉 9ms
canvas-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-idle: heap used ▃▄▂▅█▆▃▅▆█▅▆▁▆▅ ➡️ 63.2 MB
canvas-idle: DOM nodes ▁▁▁▁█▁▁▁▁██▁▁█▁ 📉 -263
canvas-idle: event listeners ▁▃▂▃█▃▂▂▃▇█▃▂█▃ 📉 -154
canvas-mouse-sweep: avg frame time ▃▆▃▃▃▃▃▆▁█▃▁▃▆▆ ➡️ 17ms
canvas-mouse-sweep: p95 frame time ▁▃▆▃▆█▃▆▃▃▁▃▃▁▃ ➡️ 17ms
canvas-mouse-sweep: layout duration ▄█▆▅▃▆█▅▄█▆▃▆▁▄ ➡️ 5ms
canvas-mouse-sweep: style recalc duration ▆█▅▆▅▇▇▅▂▇▆▃▆▁▅ 📉 30ms
canvas-mouse-sweep: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 14
canvas-mouse-sweep: style recalc count ▆█▅▆▄█▆▅▁█▇▂▅▁▃ ➡️ 74
canvas-mouse-sweep: task duration ▇█▇▇▅█▇▆▁█▆▅▇▃▇ 📉 890ms
canvas-mouse-sweep: script duration ▇▇▆▇▆█▆▅▁▇▅▆▇▃▆ 📉 156ms
canvas-mouse-sweep: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-mouse-sweep: heap used ▆▃▇██▃▃▅▁▆▄▆▇▃█ ➡️ 69.0 MB
canvas-mouse-sweep: DOM nodes ▃▃▄▅▃▂▄▄█▄▄▆▄▄▁ ➡️ -264
canvas-mouse-sweep: event listeners █▄▇██▄▄▄▁▇▄▄▇▅▄ ➡️ -165
canvas-zoom-sweep: avg frame time ▃▃██▃▆█▆▁█▁█▆▆▃ ➡️ 17ms
canvas-zoom-sweep: p95 frame time ▆▆▃█▃▃▃▃▃▆▃▁▆▁▃ ➡️ 17ms
canvas-zoom-sweep: layout duration ▄▆▅▆▁▇▇▆▁█▆▂▆▁▅ ➡️ 1ms
canvas-zoom-sweep: style recalc duration ▇▇▆█▅██▇▁▆▅▄█▂▄ 📉 15ms
canvas-zoom-sweep: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 6
canvas-zoom-sweep: style recalc count ▃▃█▃▃▆▆▃▁▃▁▃▆▁█ ➡️ 32
canvas-zoom-sweep: task duration ▆▇▆█▅██▇▁▇▅▅█▃▆ 📉 334ms
canvas-zoom-sweep: script duration ▆▆▅▇▃▇█▆▁▆▅▂▆▃▄ 📉 11ms
canvas-zoom-sweep: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-zoom-sweep: heap used ▇▇▇▆▄▇▇███▃▇▁▇▅ ➡️ 61.3 MB
canvas-zoom-sweep: DOM nodes ▄▄▇▅▄▁▅▄█▁▁▇▂▇▅ ➡️ 76
canvas-zoom-sweep: event listeners ▁▁▁▁▁▅▁▁▁▅▅▁▁█▁ ➡️ 19
dom-widget-clipping: avg frame time ▃▁██▃▆▆▁▃▃▆▃▃█▃ ➡️ 17ms
dom-widget-clipping: p95 frame time ▁█▅██▄▁▁▄▄▁▁█▁▄ ➡️ 17ms
dom-widget-clipping: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
dom-widget-clipping: style recalc duration ▂▆▁▆▄▆█▃▃▃▆▃▆▁▄ ➡️ 8ms
dom-widget-clipping: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
dom-widget-clipping: style recalc count ▁▆▂▃▃▄▄▄█▂▄▃▄▆▆ ➡️ 11
dom-widget-clipping: task duration █▇▆▇▇▇█▆▁▆▆▆▇▃▆ 📉 428ms
dom-widget-clipping: script duration █▇▆▇▇█▇▆▁▆▅▆▇▃▆ 📉 162ms
dom-widget-clipping: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
dom-widget-clipping: heap used ▁█▅▇█▁█▁▅▅▆▆▇▆█ ➡️ 76.7 MB
dom-widget-clipping: DOM nodes ▁▆▂▃▃▄▄▄█▂▄▃▄▆▆ ➡️ 19
dom-widget-clipping: event listeners █▁█▁█▁██▁█▁███▁ ➡️ 1
large-graph-idle: avg frame time ▃▆▆██▆███▁▆▆▆█▆ ➡️ 17ms
large-graph-idle: p95 frame time ▆▆▃▆▁▆▁▃▃▃▆▁▃█▃ ➡️ 17ms
large-graph-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-idle: style recalc duration ▁▅▃▃▂▄▄▃▄▂▃▄█▃▁ ➡️ 4ms
large-graph-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
large-graph-idle: style recalc count ▁▂▅▄▃▂▄▅█▂▄▅▄▇▂ 📈 5
large-graph-idle: task duration ▆▆▆█▅█▇▆▁▇▆▆▇▃▅ 📉 553ms
large-graph-idle: script duration ▅▆▆▆▅█▇▅▁▇▆▅▇▃▄ 📉 32ms
large-graph-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-idle: heap used ▇█▄▆▆▇▆▄▁▆▆▆▅▄▇ ➡️ 78.4 MB
large-graph-idle: DOM nodes ▁▁▁▁▁▁▁▁▂▁▁▁▁▂█ ➡️ -165
large-graph-idle: event listeners ▃▂▂▃▃▃▂▂▁▃▃▂▂▃█ ➡️ -120
large-graph-pan: avg frame time ▆▆▃▃▆▁▃█▆▃█▃▃▃▃ ➡️ 17ms
large-graph-pan: p95 frame time ▁▃▃▆█▃▃▆▆▆▆▆▁▁▁ ➡️ 17ms
large-graph-pan: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-pan: style recalc duration ▃▅▅▃▃▆▅█▆▃▆▁▅▃▄ ➡️ 12ms
large-graph-pan: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
large-graph-pan: style recalc count ▅▄▅▃▅▄▃██▁▆▃▆▆▅ ➡️ 66
large-graph-pan: task duration ▇▆▆▇▆█▆▆▁▆▅▅▆▃▅ 📉 1581ms
large-graph-pan: script duration ▇▆▆▇▆█▆▆▁▆▄▆▇▃▅ 📉 795ms
large-graph-pan: TBT ▁▁▁▁█▁▁▁▁▁▁▁▁▁▁ 📉 0ms
large-graph-pan: heap used ▆▄▃▄▁▅█▄▁▅▆▅▁▃▃ ➡️ 72.0 MB
large-graph-pan: DOM nodes ▁▁▅▁▄▁█▂▅▄▁█▁█▁ 📉 -242
large-graph-pan: event listeners ▂▄▃▄▃▃▆▁▃█▂▆▁▆▄ 📉 -111
large-graph-zoom: avg frame time ▆▆▃▃▁▃▃▃▆█▆▃█▆▁ ➡️ 17ms
large-graph-zoom: p95 frame time ▃▃▆▃█▆▆▃▃▁█▃▃▃▆ ➡️ 17ms
large-graph-zoom: layout duration ▃▇▅▄▁▆█▅▆▇▅▁▃▁▄ ➡️ 14ms
large-graph-zoom: style recalc duration ▂█▅▃▁▃▆▄█▅▆▂▃▅▅ ➡️ 12ms
large-graph-zoom: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 60
large-graph-zoom: style recalc count ▂▃▃▁▂▁▁▂█▂▃▃▂▆▃ ➡️ 62
large-graph-zoom: task duration ▆▇▆▇▅██▆▁▇▆▆▇▃▆ 📉 1660ms
large-graph-zoom: script duration ▇▇▆█▆█▇▆▁▇▆▆▇▃▆ 📉 781ms
large-graph-zoom: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-zoom: heap used ▆▆▄▆▇▇█▇▁▅▃▄▄▆▆ ➡️ 70.6 MB
large-graph-zoom: DOM nodes █▁▅▁█▅▄▅▁▅▅▅▅▅▁ 📈 -175
large-graph-zoom: event listeners █▁▅▅█▅▅▅▁▅▅▅▅▄▁ 📈 -117
legacy-node-drag: avg frame time ▆▆▆▆▁█▆▃▃▆▄▅▆▄▆ ➡️ 17ms
legacy-node-drag: p95 frame time ▆▃█▁▃▆▆▃▁▃▃▆▆█▆ ➡️ 17ms
legacy-node-drag: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
legacy-node-drag: style recalc duration ▃▄▂▃▆▄▃▄█▃▄▁▁▄▅ ➡️ 7ms
legacy-node-drag: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
legacy-node-drag: style recalc count ▂▃▁▂▃▂▁▂█▁▃▂▁▆▄ ➡️ 42
legacy-node-drag: task duration ▇▇▆█▇█▇▆▁█▆▆▇▃▆ 📉 1917ms
legacy-node-drag: script duration ▇▇▆█▇█▇▇▁█▅▆▇▃▇ 📉 997ms
legacy-node-drag: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
legacy-node-drag: heap used ▇█▆█▇▇▇▆▁█▅▇▇▂▅ ➡️ 79.0 MB
legacy-node-drag: DOM nodes ▁▅█▄▅▄▄▁▂▄████▅ 📉 -81
legacy-node-drag: event listeners ▁▄█▄▄▄██▁▅█████ 📈 187
minimap-idle: avg frame time ▁▆▆▆▁▆▃▆▃▆▁▃▁▆█ ➡️ 17ms
minimap-idle: p95 frame time ▁▃▆▆▃██▁▁▆▆▃▃▆▆ ➡️ 17ms
minimap-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
minimap-idle: style recalc duration ▄▁▂▄▄▄▇▆▅▃▄▇▄▃█ 📈 7ms
minimap-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
minimap-idle: style recalc count ▁▁▂▄▃▁▄▆█▃▅▆▁▆▆ 📈 7
minimap-idle: task duration ▆▆▅▇▅█▇█▁▇▅▆▇▂▆ ➡️ 605ms
minimap-idle: script duration ▆▆▅▆▄█▇█▁▇▆▃▇▃▅ 📉 34ms
minimap-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
minimap-idle: heap used █▇▆▅▆█▆▁▄▇▆▂▇▅▃ ➡️ 75.5 MB
minimap-idle: DOM nodes ▂██▁▁▂▂▁▂▂▂▁▁▂▁ ➡️ -256
minimap-idle: event listeners ▅▅█▅▂▃▂▁▂▂▂▁▃▂▁ 📈 -184
subgraph-dom-widget-clipping: avg frame time ▁▃▆▆▃█▆▃▃▃▁▃▃▆█ ➡️ 17ms
subgraph-dom-widget-clipping: p95 frame time ▃█▁▃▁▃▆▃▃▃▃▃▃▃▆ ➡️ 17ms
subgraph-dom-widget-clipping: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-dom-widget-clipping: style recalc duration ▇▇▇█▅█▇▇▄█▇▄▇▁▄ ➡️ 10ms
subgraph-dom-widget-clipping: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
subgraph-dom-widget-clipping: style recalc count ▃▃▄▃▄▂▃▆█▄▇▄▁▃▄ ➡️ 47
subgraph-dom-widget-clipping: task duration ▇▇▆█▆█▇▇▁▇▅▆█▃▆ 📉 393ms
subgraph-dom-widget-clipping: script duration ██▇▇▆█▇▇▁▇▅▇█▃▆ 📉 142ms
subgraph-dom-widget-clipping: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-dom-widget-clipping: heap used ▇▇▅▇▅▇▇▇▅▁▅██▅▇ ➡️ 73.6 MB
subgraph-dom-widget-clipping: DOM nodes ▃▃▅▃▅▂▃▇█▅█▅▁▃▅ ➡️ 19
subgraph-dom-widget-clipping: event listeners ▃▃█▃▆▆▃▆▃█▃█▃▁█ ➡️ 8
subgraph-idle: avg frame time █▅▁▅▅▄▁▁█▅██▁▄█ ➡️ 17ms
subgraph-idle: p95 frame time ▃▁▁▃▃▆▁▁▃▆▃█▆▁▃ ➡️ 17ms
subgraph-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-idle: style recalc duration █▄▆▆▄▇▅▄▁▆▄▄█▄▄ ➡️ 8ms
subgraph-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
subgraph-idle: style recalc count ▅▂▇▁▅▄▁▂█▄▁▂▇▇▅ ➡️ 10
subgraph-idle: task duration ▇▆▆▇▆██▆▁▇▆▆█▃▄ 📉 399ms
subgraph-idle: script duration ▆▅▅▆▄▆█▄▁▆▅▄▅▃▄ 📉 7ms
subgraph-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-idle: heap used ▄▃▁█▆▆█▆▆▆▇▄▆▃▄ ➡️ 62.4 MB
subgraph-idle: DOM nodes ▁█▁▁▁▁▁▁▁▁█▁▁▁▁ ➡️ -276
subgraph-idle: event listeners ▃█▁▃▃▃▃▃▃▃█▃▃▂▂ ➡️ -221
subgraph-mouse-sweep: avg frame time ▆▃▁▁▃█▆▆▃█▁▃▁▃▆ ➡️ 17ms
subgraph-mouse-sweep: p95 frame time ▁▆▆▃▁▃▆▆▆▆▁█▃█▆ ➡️ 17ms
subgraph-mouse-sweep: layout duration ▄▇▄▅▃▅█▄▄▆▅▂▃▁▄ ➡️ 6ms
subgraph-mouse-sweep: style recalc duration ▅▇▅▇▄▇█▅▁▆▅▄▆▁▄ 📉 27ms
subgraph-mouse-sweep: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 18
subgraph-mouse-sweep: style recalc count ▄▁▄▆▄▄▃█▃▃▃▃▆█▄ ➡️ 77
subgraph-mouse-sweep: task duration ▆▇▆█▅██▇▁▇▅▆▇▂▆ 📉 757ms
subgraph-mouse-sweep: script duration ▆▆▅▇▅█▇▆▁▆▅▅▇▂▄ 📉 99ms
subgraph-mouse-sweep: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-mouse-sweep: heap used ▅▁▁▄▅▅▂▃▂▃▂█▂▅▃ ➡️ 63.7 MB
subgraph-mouse-sweep: DOM nodes ▂▃▄▃▂▂▃▂▇▁▅▃▄█▆ ➡️ -274
subgraph-mouse-sweep: event listeners █▁▁▆█▆▃▅▆▃▆█▃▆▃ ➡️ -221
subgraph-transition-enter: avg frame time ▅▁▅█▄▅▅▁▅▅▁▅▅▅▁ ➡️ 17ms
subgraph-transition-enter: p95 frame time █▁▁█▁███████▁▁▁ ➡️ 17ms
subgraph-transition-enter: layout duration ▆▇▅▆▆█▆▅▁▅▃▆▇▆▅ 📉 12ms
subgraph-transition-enter: style recalc duration ▇▆▆▇▇█▆▆▁▆▄▆█▄▅ 📉 27ms
subgraph-transition-enter: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 5
subgraph-transition-enter: style recalc count ▁▃▁▆▁▁▃▁█▆▃▃▃▃▃ ➡️ 17
subgraph-transition-enter: task duration ▇▇▇▆▆█▇▆▁▆▄▃▇▃▆ 📉 875ms
subgraph-transition-enter: script duration ▇▆▆▅▅█▆▆▁▅▃▃▆▂▅ 📉 29ms
subgraph-transition-enter: TBT ▇▆▅▆▆▇▆▅▁▅▃▆█▃▄ 📉 120ms
subgraph-transition-enter: heap used ▁▆▆▆▁▇▇▆▇▆▇▁█▅▁ ➡️ 77.9 MB
subgraph-transition-enter: DOM nodes ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 13587
subgraph-transition-enter: event listeners ▁████▁▁█▁█▁▁█▁█ ➡️ 2387
viewport-pan-sweep: avg frame time ▃▁▃▃▅▆▄▄▄▆▆▄█▆█ ➡️ 17ms
viewport-pan-sweep: p95 frame time ▄▁█▁▄█▁▄▄▁▄▅███ ➡️ 17ms
viewport-pan-sweep: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
viewport-pan-sweep: style recalc duration ▂▅▄▃▁▄█▄▅▆▆▁▂▂▂ ➡️ 38ms
viewport-pan-sweep: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
viewport-pan-sweep: style recalc count ▃▂▃▃▃▁▃▃▇▃▆▄▂█▄ ➡️ 248
viewport-pan-sweep: task duration ▇▇▆▇▆█▇▆▁▇▅▆▇▃▆ 📉 5690ms
viewport-pan-sweep: script duration ▇▆▆▇▆█▇▆▁▇▅▆█▃▆ 📉 2734ms
viewport-pan-sweep: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
viewport-pan-sweep: heap used ▃▁▄▃▄▆▄▄▆▅█▂▅▄▃ ➡️ 70.1 MB
viewport-pan-sweep: DOM nodes ▂▂▂▂▂▁▂▂▃▄█▅▁█▄ ➡️ -240
viewport-pan-sweep: event listeners ▅▅▃█▇█▇▅▆▃▄▅▂▁▁ 📈 -168
vue-large-graph-idle: avg frame time ▅▆▆▅▅▆▆█▁██▅▆▆▆ ➡️ 18ms
vue-large-graph-idle: p95 frame time ██▄▄█▄▄▅▁█▄█▄▄█ ➡️ 17ms
vue-large-graph-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
vue-large-graph-idle: style recalc duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
vue-large-graph-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
vue-large-graph-idle: style recalc count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
vue-large-graph-idle: task duration ▆█▇▅▆▇█▇▁█▇▅▇▄▇ ➡️ 16820ms
vue-large-graph-idle: script duration ▆█▇▅▆▇██▁█▆▅▇▄▆ 📉 269ms
vue-large-graph-idle: TBT ▁▁▁▁▁▁█▁▁▁▁▁▁▁▁ 📉 0ms
vue-large-graph-idle: heap used ▅▅▅▆▅▄█▁▅▆▅▄▇▆▂ ➡️ 164.7 MB
vue-large-graph-idle: DOM nodes ███████▁▁▁▁▁▁▁▁ 📈 -8061
vue-large-graph-idle: event listeners ███████▁▁▁▁▁▁▁▁ 📈 -14927
vue-large-graph-pan: avg frame time ▆▇█▆▇▅▆▅▁▇█▃▅▄▅ ➡️ 18ms
vue-large-graph-pan: p95 frame time ▁▁▁▁█▁██▁▁██▁█▁ ➡️ 17ms
vue-large-graph-pan: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
vue-large-graph-pan: style recalc duration ▅▇▆▅▃▅█▄▁█▆▃▅▂▅ 📉 20ms
vue-large-graph-pan: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
vue-large-graph-pan: style recalc count ▇█▇▇█▇█▆▁█▇██▅▇ 📉 160
vue-large-graph-pan: task duration ▆█▇▇▆▆█▆▁█▇▅▇▃▇ ➡️ 21261ms
vue-large-graph-pan: script duration ▇█▇█▆▇█▆▁█▆▆▇▃▆ 📉 884ms
vue-large-graph-pan: TBT ▃█▅▇▃▃▇▄▁▇▃▂▄▁▆ 📉 159ms
vue-large-graph-pan: heap used █▅▃▃█▃▁▇▃▂▆▇▇▇▄ ➡️ 167.0 MB
vue-large-graph-pan: DOM nodes ███████▁▁▁▁▁▁▁▁ 📈 -8061
vue-large-graph-pan: event listeners ███████▁▁▁▁▁▁▁▁ 📈 -14922
vue-node-resize-workload: avg frame time ▇█▄▅▄▅█▅▁▇▅▂▅▂█ ➡️ 18ms
vue-node-resize-workload: p95 frame time ▃▆▆▃█▆█▁██▆▃▆█▆ ➡️ 17ms
vue-node-resize-workload: layout duration ▅▅▄▃▂▄▆▄▁█▅▂▃▂▃ ➡️ 24ms
vue-node-resize-workload: style recalc duration ▇▆▆▇▇█▇▆▁█▅▇▇▂▅ 📉 73ms
vue-node-resize-workload: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 20
vue-node-resize-workload: style recalc count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 20
vue-node-resize-workload: task duration ▇▇▅▇▆█▇▇▁█▇▄▆▄▇ ➡️ 6209ms
vue-node-resize-workload: script duration ▇▇▅▆▅█▇▆▁█▇▄▆▃▆ 📉 115ms
vue-node-resize-workload: TBT ▇▇▅▇▆▇▇▇▁█▆▅▆▃▇ 📉 415ms
vue-node-resize-workload: heap used ▄▁▅█▂▄▂▆▁▃▄▇▇▇▅ ➡️ 174.8 MB
vue-node-resize-workload: DOM nodes ███████▁▁▁▁▁▁▁▁ 📈 -8071
vue-node-resize-workload: event listeners ███████▁▁▁▁▁▁▁▁ 📈 -14923
vue-zoom-out-idle: avg frame time ▆▇█▆▆▇▇▆▁▆▇▅▅▄▆ ➡️ 18ms
vue-zoom-out-idle: p95 frame time ██▄▄▁▄█▄▁▄███▅▄ ➡️ 17ms
vue-zoom-out-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
vue-zoom-out-idle: style recalc duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
vue-zoom-out-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
vue-zoom-out-idle: style recalc count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
vue-zoom-out-idle: task duration ▇█▇▇▅▇█▇▁▇▇▅▇▄▇ 📉 8681ms
vue-zoom-out-idle: script duration ▇▇▆█▅▇▇▇▁▇▆▆▆▃▆ 📉 142ms
vue-zoom-out-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
vue-zoom-out-idle: heap used ▁▅▁▂▅▄▃▂▂▄█▄▃▅▆ ➡️ 180.2 MB
vue-zoom-out-idle: DOM nodes ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
vue-zoom-out-idle: event listeners ▄▃▄▃▄▃▁▂█▃▄▄▄▄▂ ➡️ -14
workflow-execution: avg frame time ▆▁▃▃▃▃▃▁▃▃▃▃█▁▆ ➡️ 17ms
workflow-execution: p95 frame time ▆▆▆▁▃▆▃▃▆█▁▃▆▁▃ ➡️ 17ms
workflow-execution: layout duration ▅▁▆▁▃▆█▆▄▃▁▃▃▂▄ 📉 2ms
workflow-execution: style recalc duration ▇▅▃▁▅▇▄█▁█▂▅▁▃▇ ➡️ 24ms
workflow-execution: layout count █▃▆▅▆██▆█▆▁▅▁▆▅ ➡️ 3
workflow-execution: style recalc count █▅▃▁▅▅▄█▅▄▃▇▂██ ➡️ 18
workflow-execution: task duration █▅▃▂▄▇▄▆▁▆▂▅▂▃▆ ➡️ 122ms
workflow-execution: script duration █▅▁▂▂▆▄▅▂▄▂▄▁▂▄ 📉 11ms
workflow-execution: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
workflow-execution: heap used █▅▃▁▄▆▄▇▅▃▃▅▁█▇ ➡️ 63.9 MB
workflow-execution: DOM nodes █▃▄▁▅▄▅█▅▃▃▇▄▇█ ➡️ 146
workflow-execution: event listeners █▆▄▃▆▇▃█▆▄▃▆▁██ ➡️ 83
Raw data
{
  "timestamp": "2026-09-16T18:27:46.520Z",
  "gitSha": "595d86f1e5386974da36aef0fc2d95690f0eb51f",
  "branch": "jaewon/fe-2218-billing-web-codecov-flag-followups",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2036.1709999999675,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 7.213999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 556.668,
      "heapDeltaBytes": 5671012,
      "heapUsedBytes": 66837840,
      "domNodes": -266,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 10.729000000000003,
      "eventListeners": -158,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-idle",
      "durationMs": 2006.1590000000251,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 7.892000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 479.129,
      "heapDeltaBytes": 2965104,
      "heapUsedBytes": 64578876,
      "domNodes": -264,
      "jsHeapTotalBytes": 4448256,
      "scriptDurationMs": 10.087000000000002,
      "eventListeners": -154,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1906.89900000001,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 33.761,
      "layouts": 14,
      "layoutDurationMs": 4.9479999999999995,
      "taskDurationMs": 899.9999999999999,
      "heapDeltaBytes": 6574892,
      "heapUsedBytes": 69053596,
      "domNodes": -263,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 161.222,
      "eventListeners": -154,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1890.1969999999437,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 33.174,
      "layouts": 14,
      "layoutDurationMs": 4.871,
      "taskDurationMs": 892.493,
      "heapDeltaBytes": 5517612,
      "heapUsedBytes": 67986760,
      "domNodes": -261,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 159.111,
      "eventListeners": -156,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1738.0600000000186,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 16.903000000000002,
      "layouts": 6,
      "layoutDurationMs": 1.3179999999999996,
      "taskDurationMs": 365.21400000000006,
      "heapDeltaBytes": 2057616,
      "heapUsedBytes": 63684768,
      "domNodes": 75,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 13.568,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1725.781999999981,
      "styleRecalcs": 30,
      "styleRecalcDurationMs": 18.839000000000002,
      "layouts": 6,
      "layoutDurationMs": 1.412,
      "taskDurationMs": 368.612,
      "heapDeltaBytes": 2111252,
      "heapUsedBytes": 64261232,
      "domNodes": 76,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 13.565999999999999,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 691.7930000000183,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 8.359000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 460.8349999999999,
      "heapDeltaBytes": 17942980,
      "heapUsedBytes": 80401508,
      "domNodes": 18,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 162.105,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 692.5079999999753,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 7.6140000000000025,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 472.389,
      "heapDeltaBytes": 17901548,
      "heapUsedBytes": 80385784,
      "domNodes": 16,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 169.683,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2029.465000000016,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 8.01,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 627.167,
      "heapDeltaBytes": 2885152,
      "heapUsedBytes": 82850428,
      "domNodes": -249,
      "jsHeapTotalBytes": -794624,
      "scriptDurationMs": 36.00300000000001,
      "eventListeners": -154,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2049.7709999999643,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 5.97,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 607.8720000000001,
      "heapDeltaBytes": 2728868,
      "heapUsedBytes": 82876444,
      "domNodes": -248,
      "jsHeapTotalBytes": -794624,
      "scriptDurationMs": 36.919,
      "eventListeners": -182,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2258.768000000032,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 11.906999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1647.1599999999999,
      "heapDeltaBytes": -5382820,
      "heapUsedBytes": 75708512,
      "domNodes": -253,
      "jsHeapTotalBytes": 1003520,
      "scriptDurationMs": 818.333,
      "eventListeners": -152,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2217.9949999999735,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 14.141999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1644.5379999999998,
      "heapDeltaBytes": -1984764,
      "heapUsedBytes": 79006128,
      "domNodes": -253,
      "jsHeapTotalBytes": 1003520,
      "scriptDurationMs": 812.4910000000001,
      "eventListeners": -184,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3658.7789999999814,
      "styleRecalcs": 63,
      "styleRecalcDurationMs": 15.119,
      "layouts": 60,
      "layoutDurationMs": 15.411000000000001,
      "taskDurationMs": 1880.5169999999998,
      "heapDeltaBytes": -9132388,
      "heapUsedBytes": 73611972,
      "domNodes": -261,
      "jsHeapTotalBytes": -1056768,
      "scriptDurationMs": 827.295,
      "eventListeners": -178,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3537.193000000002,
      "styleRecalcs": 62,
      "styleRecalcDurationMs": 12.844000000000001,
      "layouts": 60,
      "layoutDurationMs": 14.976999999999999,
      "taskDurationMs": 1700.8100000000002,
      "heapDeltaBytes": 9120580,
      "heapUsedBytes": 75142932,
      "domNodes": 4,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 793.757,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3122.8380000000016,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 5.722000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1996.5720000000001,
      "heapDeltaBytes": 23204588,
      "heapUsedBytes": 89104180,
      "domNodes": 0,
      "jsHeapTotalBytes": 2252800,
      "scriptDurationMs": 994.167,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3189.732000000049,
      "styleRecalcs": 45,
      "styleRecalcDurationMs": 9.827000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 2012.9779999999998,
      "heapDeltaBytes": -4054740,
      "heapUsedBytes": 79068924,
      "domNodes": -265,
      "jsHeapTotalBytes": 7487488,
      "scriptDurationMs": 1011.371,
      "eventListeners": -187,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2044.4490000000428,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 6.260999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 613.57,
      "heapDeltaBytes": -3785652,
      "heapUsedBytes": 84184576,
      "domNodes": -246,
      "jsHeapTotalBytes": -495616,
      "scriptDurationMs": 36.242999999999995,
      "eventListeners": -154,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2037.239999999997,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 3.5199999999999987,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 651.2959999999999,
      "heapDeltaBytes": -3909484,
      "heapUsedBytes": 83879316,
      "domNodes": -254,
      "jsHeapTotalBytes": -1019904,
      "scriptDurationMs": 40.53799999999999,
      "eventListeners": -154,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 608.4250000000111,
      "styleRecalcs": 48,
      "styleRecalcDurationMs": 11.982,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 411.36899999999997,
      "heapDeltaBytes": 13308528,
      "heapUsedBytes": 76865272,
      "domNodes": 22,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 146.772,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 591.7389999999614,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 10.824000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 409.39400000000006,
      "heapDeltaBytes": 13379412,
      "heapUsedBytes": 77105244,
      "domNodes": 20,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 144.711,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2016.2290000000098,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.04,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 499.83899999999994,
      "heapDeltaBytes": -5845048,
      "heapUsedBytes": 57957492,
      "domNodes": -277,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 9.850000000000001,
      "eventListeners": -230,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2021.6350000000602,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.549000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 480.60800000000006,
      "heapDeltaBytes": 11532788,
      "heapUsedBytes": 75153040,
      "domNodes": -277,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 9.246,
      "eventListeners": -200,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1703.8239999999973,
      "styleRecalcs": 79,
      "styleRecalcDurationMs": 31.028999999999996,
      "layouts": 18,
      "layoutDurationMs": 6.1499999999999995,
      "taskDurationMs": 732.9200000000001,
      "heapDeltaBytes": -3417500,
      "heapUsedBytes": 60336504,
      "domNodes": -273,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 113.63299999999998,
      "eventListeners": -232,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1735.588000000007,
      "styleRecalcs": 80,
      "styleRecalcDurationMs": 31.526,
      "layouts": 18,
      "layoutDurationMs": 5.887,
      "taskDurationMs": 818.5469999999999,
      "heapDeltaBytes": 12900420,
      "heapUsedBytes": 76515100,
      "domNodes": -273,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 111.596,
      "eventListeners": -200,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1368.8940000000684,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 28.069999999999997,
      "layouts": 5,
      "layoutDurationMs": 12.014000000000001,
      "taskDurationMs": 938.4110000000001,
      "heapDeltaBytes": 19708172,
      "heapUsedBytes": 100713252,
      "domNodes": 13587,
      "jsHeapTotalBytes": 11010048,
      "scriptDurationMs": 29.98699999999999,
      "eventListeners": 2387,
      "totalBlockingTimeMs": 132,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8629.863000000001,
      "styleRecalcs": 247,
      "styleRecalcDurationMs": 41.882000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6297.668,
      "heapDeltaBytes": 3080972,
      "heapUsedBytes": 82762724,
      "domNodes": -248,
      "jsHeapTotalBytes": 2052096,
      "scriptDurationMs": 2991.197,
      "eventListeners": -136,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8411.077999999976,
      "styleRecalcs": 248,
      "styleRecalcDurationMs": 42.812000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5961.543,
      "heapDeltaBytes": -4254468,
      "heapUsedBytes": 76777324,
      "domNodes": -247,
      "jsHeapTotalBytes": 778240,
      "scriptDurationMs": 2819.625,
      "eventListeners": -138,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 18234.228000000032,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17976.168999999998,
      "heapDeltaBytes": -52611788,
      "heapUsedBytes": 189710612,
      "domNodes": -8061,
      "jsHeapTotalBytes": -14336000,
      "scriptDurationMs": 309.529,
      "eventListeners": -14926,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.773333333333238,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 18007.926,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17762.86,
      "heapDeltaBytes": -47148944,
      "heapUsedBytes": 184248880,
      "domNodes": -8061,
      "jsHeapTotalBytes": -8970240,
      "scriptDurationMs": 295.74899999999997,
      "eventListeners": -14924,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666763,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 22185.05699999997,
      "styleRecalcs": 155,
      "styleRecalcDurationMs": 22.320000000000007,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 22023.581,
      "heapDeltaBytes": -45479184,
      "heapUsedBytes": 168168896,
      "domNodes": -8061,
      "jsHeapTotalBytes": -17661952,
      "scriptDurationMs": 907.988,
      "eventListeners": -14920,
      "totalBlockingTimeMs": 215,
      "frameDurationMs": 17.77333333333348,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 22889.947000000007,
      "styleRecalcs": 169,
      "styleRecalcDurationMs": 25.189000000000018,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 22800.329999999998,
      "heapDeltaBytes": -33219128,
      "heapUsedBytes": 177654388,
      "domNodes": -8061,
      "jsHeapTotalBytes": -11853824,
      "scriptDurationMs": 952.3729999999999,
      "eventListeners": -14920,
      "totalBlockingTimeMs": 104,
      "frameDurationMs": 18.330000000000048,
      "p95FrameDurationMs": 16.799999999995634
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6502.544999999998,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 74.11300000000004,
      "layouts": 20,
      "layoutDurationMs": 25.953000000000003,
      "taskDurationMs": 6469.914999999999,
      "heapDeltaBytes": -30035312,
      "heapUsedBytes": 180457156,
      "domNodes": -8061,
      "jsHeapTotalBytes": 13574144,
      "scriptDurationMs": 129.464,
      "eventListeners": -14922,
      "totalBlockingTimeMs": 487,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6779.162999999926,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 84.499,
      "layouts": 20,
      "layoutDurationMs": 30.40900000000002,
      "taskDurationMs": 6751.389,
      "heapDeltaBytes": -63464592,
      "heapUsedBytes": 172098460,
      "domNodes": -8061,
      "jsHeapTotalBytes": 9691136,
      "scriptDurationMs": 135.76900000000003,
      "eventListeners": -14922,
      "totalBlockingTimeMs": 579,
      "frameDurationMs": 18.333333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 9011.291999999969,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8879.461999999998,
      "heapDeltaBytes": -17725280,
      "heapUsedBytes": 176797312,
      "domNodes": 0,
      "jsHeapTotalBytes": -29360128,
      "scriptDurationMs": 146.05599999999995,
      "eventListeners": -14,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 9234.764000000041,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 9124.87,
      "heapDeltaBytes": -13818672,
      "heapUsedBytes": 166848892,
      "domNodes": 0,
      "jsHeapTotalBytes": -5767168,
      "scriptDurationMs": 153.80100000000007,
      "eventListeners": -12,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 18.886666666666738,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 132.46700000001965,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 15.126000000000003,
      "layouts": 3,
      "layoutDurationMs": 0.9520000000000002,
      "taskDurationMs": 99.84499999999998,
      "heapDeltaBytes": 3245816,
      "heapUsedBytes": 65301888,
      "domNodes": 112,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 10.199000000000002,
      "eventListeners": 35,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 120.49999999999272,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 16.151,
      "layouts": 3,
      "layoutDurationMs": 1.101,
      "taskDurationMs": 79.46400000000001,
      "heapDeltaBytes": 3015244,
      "heapUsedBytes": 65010724,
      "domNodes": 108,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 6.574000000000002,
      "eventListeners": 33,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    }
  ]
}

🔬 E2E Coverage

Metric Covered Total Pct
Lines 51029 77356 66.0% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.7% 1159
src/LGraphNode.ts 69.9% 388
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/platform/workspace/stores/workspaceAuthStore.ts 33.1% 331
src/platform/workspace/stores/billingOperationStore.ts 7.9% 313
src/LGraph.ts 79.1% 263
src/platform/workspace/stores/teamWorkspaceStore.ts 38.9% 256
src/scripts/app.ts 71.7% 255
src/core/billing/operationLifecycle.ts 0.9% 226

@coderabbitai

coderabbitai Bot commented Sep 16, 2026 •

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 67fc5092-dfac-4ba2-aee3-289e509d5ec3

📥 Commits

Reviewing files that changed from the base of the PR and between 2870d8a and 089a852.

📒 Files selected for processing (2)
  • .github/workflows/ci-billing-web-unit.yaml
  • codecov.yml

Included review availability: Your plan provides up to 8 included reviews per hour; 6 remain after this review.


📝 Walkthrough

Walkthrough

The changes make billing-web workflow edits trigger billing-web change detection and align the billing-web unit coverage upload with new Codecov project and patch status entries.

Changes

Billing-web CI configuration

Layer / File(s) Summary
Billing-web workflow change detection
.github/actions/changes-filter/action.yaml
The billing-web unit workflow now triggers app-billing-web-changes on pull requests. The output description lists the workflow path.
Billing-web coverage reporting
.github/workflows/ci-billing-web-unit.yaml, codecov.yml
The unit workflow uploads coverage with the billing-web-unit flag. Codecov adds informative project and patch statuses for apps/billing-web/src/** and defines the matching flag.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 089a8

This PR updates CI detection and informational coverage reporting without an identified merge-blocking risk.

🚥 Pre-merge checks | ✅ 7
✅ Passed checks (7 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
End-To-End Regression Coverage For Fixes ✅ Passed The PR title and both commit subjects contain no bug-fix signal such as “fix” or “bugfix.” The changed files are CI and Codecov configuration files, and the PR description identifies the work as CI co…
Website End-To-End Regression Coverage ✅ Passed No changed file is under apps/website/src/ or apps/website/public/. The listed changes are limited to CI path filtering, Codecov configuration, and the billing-web unit workflow. This check does n…
Adr Compliance For Entity/Litegraph Changes ✅ Passed The changed files are .github/actions/changes-filter/action.yaml, codecov.yml, and .github/workflows/ci-billing-web-unit.yaml. None is under src/lib/litegraph/, src/ecs/, or related to graph…
Title check ✅ Passed The title clearly identifies the main changes: self-testing the billing-web unit workflow and adding a dedicated Codecov status for its flag.
Description check ✅ Passed The description provides a detailed summary, implementation details, review context, testing evidence, and the absence of UI changes. It does not use the template headings exactly and does not explici…
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jaewon/fe-2218-billing-web-codecov-flag-followups

Comment @coderabbitai help to get the list of available commands.

… a status

Two follow-ups from the #17827 review.

`app_billing_web` did not list `ci-billing-web-unit.yaml`, so a PR that only
touches the workflow left `billing-web-unit` skipped and `billing-web-unit-gate`
passing through its skip branch. #17827 itself merged that way: run 35103654481
never executed the job it added. Listing the workflow in its own filter makes it
self-testing on pull requests. The merge queue already ran it unconditionally,
because every filter output defaults to 'true' off `pull_request`.

`coverage.status` had no `project.billing-web` or `patch.billing-web`, so the
upload arrived with no dedicated status while the website flag has both. Both
now mirror the website entries: scoped to `apps/billing-web/src/**`,
informational, and `flag_coverage_not_uploaded_behavior: pass`.

The third review point — renaming the flag to `billing-web-unit` to match
`website-unit` — is left out. It has to change `flags:` in the workflow and both
new status entries in one commit, or the upload and the config disagree, and the
token available here cannot push `.github/workflows/`.
coderabbitai[bot]
coderabbitai Bot previously approved these changes Sep 16, 2026
@github-actions github-actions Bot added the risk:xhigh PR risk grade (advisory shadow check; grader-owned) label Sep 16, 2026
@codecov

codecov Bot commented Sep 16, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@            Coverage Diff             @@
##             main   #17844      +/-   ##
==========================================
+ Coverage   82.61%   83.62%   +1.00%     
==========================================
  Files        2848     2192     -656     
  Lines      141992   125993   -15999     
  Branches    36526    33927    -2599     
==========================================
- Hits       117304   105359   -11945     
+ Misses      23482    20345    -3137     
+ Partials     1206      289     -917     
Flag Coverage Δ
billing-web ?
billing-web-unit 100.00% <ø> (?)
e2e 65.96% <ø> (-0.04%) ⬇️
unit 78.67% <ø> (+<0.01%) ⬆️
website-unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.
see 673 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dante01yoon

Copy link
Copy Markdown
Collaborator Author

Codecov has now reported on this PR, so the second fix is confirmed live rather than just validator-checked:

pass | codecov/patch/billing-web
pass | codecov/project/billing-web
pass | codecov/patch/website
pass | codecov/project/website
pass | codecov/patch

Those two billing-web contexts are exactly what was missing — on #17827 only the website pair existed. They pass through flag_coverage_not_uploaded_behavior: pass, which is correct here: billing-web-unit skipped on this PR (it touches neither apps/billing-web/** nor the workflow), and carryforward: false means no stale data is substituted. Codecov's flag table shows billing-web as ? for the same reason, alongside website-unit, which is also ?.

Full status: 85 pass, 19 skipping, 0 failing, 0 pending. CodeRabbit reports no actionable comments and 7/7 pre-merge checks passed.

Two things still outstanding, neither actionable from my side:

  1. The first fix — app_billing_web listing its own workflow — still cannot be demonstrated end-to-end, since proving it requires a PR that edits .github/workflows/ci-billing-web-unit.yaml, which is the push my credential is refused for (no workflow scope).
  2. The flag rename to billing-web-unit needs that same workflow scope, so it is still out. Details and the exact three-line change are in the PR description and in this reply on #17827.

Merge is blocked only on a required approving review: ProtectMain and ProtectMainReview each require one, and the CodeRabbit approval does not satisfy it.

The third review point on #17827: the flag was `billing-web` while the
website's is `website-unit`, so the two apps named the same kind of upload
differently. Renaming now, before more history accrues under the old name —
a later rename discards the flag's coverage history.

One commit on purpose. The name lives in three places: `flags:` on the
codecov upload step in `ci-billing-web-unit.yaml`, `flags.billing-web-unit`
in `codecov.yml`, and the `flags:` list inside each of the two statuses
this PR added. Split across commits, the upload would carry one name while
the config expected the other, and the statuses would silently receive no
data for every commit in between.

The two status keys move to `billing-web-unit` as well, so the check names
match the flag they report on.
@dante01yoon

Copy link
Copy Markdown
Collaborator Author

Folded in the third point as 089a852: the Codecov flag is now billing-web-unit in the workflow and in codecov.yml in one commit; status keys stay billing-web so the check names mirror the website's (codecov/project/website with flag website-unit). Body updated to match.

@huang47 huang47 left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Can we update the PR’s Testing section to reflect the renamed flag and successful self-test? This is not blocking this PR. The configuration now uses billing-web-unit, and that job passed in run 35133260165, contradicting the old billing-web value and expected skip.

@dante01yoon

Copy link
Copy Markdown
Collaborator Author

The rename commit (089a852) closes the third review point, and it also happens to supply the end-to-end proof for the first one that I twice said could not be obtained here.

Fix 1 is now demonstrated, not just reasoned about. Because this PR touches .github/workflows/ci-billing-web-unit.yaml and app_billing_web now lists that file, the job executed instead of skipping:

pass | billing-web-unit        (ran 18:15:49 -> 18:16:36, run 35133260165)
pass | billing-web-unit-gate

At the previous head it read skipping; the totals moved 85 pass / 19 skipping -> 86 pass / 18 skipping, one job crossing over. That is exactly the blind spot @huang47 identified — a workflow-only change used to leave the suite unrun behind a green gate.

Fix 3 is consistent in all four places, so the upload cannot land unattributed:

Location Value
ci-billing-web-unit.yaml → flags: billing-web-unit
codecov.yml → flags key billing-web-unit
project.billing-web → flags billing-web-unit
patch.billing-web → flags billing-web-unit

Status keys stay billing-web, matching website keying website-unit. codecov.io/validate → Valid!.

Fix 2 is now backed by a real upload rather than the not-uploaded fallback. Codecov's flag table shows billing-web-unit at 100.00%, with codecov/project/billing-web and codecov/patch/billing-web both green. The old billing-web flag shows ?, as expected now that nothing uploads to it.

One observation, not a blocker: that 100.00% differs from the 98.33% statements measured locally in the #17827 review (EmbeddedCheckout.vue line 262 uncovered). It predates these changes and does not affect the status wiring, but if the flag's paths filter or network_prefix re-rooting is dropping a file, the figure would be flattered. @huang47 — worth a glance at the flag's file list when convenient.

Full status: 86 pass, 18 skipping, 0 failing, 0 pending. No open review threads. Merge is still blocked only on a required approving review; the CodeRabbit approval does not satisfy ProtectMain / ProtectMainReview.

@huang47 huang47 removed their assignment Sep 16, 2026
@dante01yoon
dante01yoon added this pull request to the merge queue Sep 16, 2026
@dante01yoon

Copy link
Copy Markdown
Collaborator Author

@huang47 Done — Testing section rewritten. Description only; nothing pushed to the branch, so the approval and the queue position stand.

Both stale claims are gone:

  • Flag name. All three places now read billing-web-unit: the workflow's flags:, flags.billing-web-unit in codecov.yml, and the flags: list inside each of the two statuses. The status keys stay billing-web, so the checks remain codecov/project/billing-web and codecov/patch/billing-web — the same split the website has between status key website and flag website-unit.
  • The self-test. The "expected to skip" note is replaced by run 35133260165: changes ✅, billing-web-unit ✅ (executed, not skipped), billing-web-unit-gate ✅.

One thing worth stating explicitly, because it is what makes that run a self-test rather than a coincidence: the job's if: is app-billing-web-changes || packages-changes, and this PR touches nothing under apps/billing-web/**, nothing under packages/**, and nothing in the deps set (.nvmrc, root package.json, pnpm-lock.yaml, pnpm-workspace.yaml). So packages-changes and deps are both false, and .github/workflows/ci-billing-web-unit.yaml — the path this PR adds to app_billing_web — was the only way that condition could become true.

Also re-ran the validator against the current file rather than reusing the earlier result: Valid!, both statuses resolving to flag billing-web-unit and path (?s:apps/billing\-web/src/.*)\Z.

Separately, for whoever writes the squash message: the last paragraph of commit 089a852bfc says "the two status keys move to billing-web-unit as well". They did not — the keys stayed billing-web, which is what the file and the description say. Only the flags: values moved. Not worth a force-push on an approved branch, but worth not copying into the merge commit.

Merged via the queue into main with commit 7dc3692 Sep 16, 2026
106 checks passed
@dante01yoon
dante01yoon deleted the jaewon/fe-2218-billing-web-codecov-flag-followups branch September 16, 2026 19:09
dante01yoon added a commit that referenced this pull request Sep 16, 2026
…the SDK rail behind billing_sdk_subscription_enabled (#17853)

Stacked on #17783 (base branch
`jaewon/fe-2210-hosted-destination-port`); merge that first.

## Why

Phase 5 slice 1 (#17665) moved top-up onto the Billing SDK behind
`billing_sdk_topup_enabled`. The subscription actions the host already
owns — cancel, resubscribe, and opening the payment portal — still call
the workspace API directly and rely on the legacy poller for settlement
and telemetry. This slice moves those three onto the SDK's commands
behind their own server flag, `billing_sdk_subscription_enabled`
(already on `/api/features` via Comfy-Org/cloud#9248, PostHog at 0%), so
the eight-state lifecycle, idempotency, recovery and telemetry come from
one implementation. Subscribe and plan change are slice 2b, stacked on
this PR.

## How

- **Rail switch.** `billingSdkSubscriptionRailEnabled` =
`billing_sdk_subscription_enabled` AND `unified_cloud_auth`, exactly
like the top-up rail. `useSubscriptionRail()` reads it once,
synchronously, at the start of an action, so a flag flip mid-flow cannot
issue on one rail and observe on the other.
- **Three actions, one adapter.**
`useWorkspaceBilling.cancelSubscription / resubscribe /
manageSubscription` try the rail first; the store runs
`sdk.commands.cancelSubscription()`, `resubscribe()`,
`openPaymentPortal({ returnUrl })` and projects the result onto what the
adapter already does with the legacy calls: settle, or throw a
`WorkspaceApiError` (message is the host's, since the SDK never carries
server text; `serverCode` lands in `.code`). A command that settles in
any phase but `succeeded` is a failure, matching the poller. The refresh
after success mirrors the poller's: cancel → status + balance +
capabilities; resubscribe → `reconcileSubscriptionSuccess` +
capabilities.
- **Fallback.** A 404 (backend gate closed while the client flag is on)
projects to `unavailable`: the adapter runs its legacy body for that
action, and the store latches the route as unavailable for the tab so
later actions go straight to legacy without another failed round trip.
Every other failure — including `SUPERSEDED` — is thrown, never retried
on legacy, so a late or superseded result cannot double-issue.
- **Telemetry.** Lifecycle events are now reported for non-topup
operations (top-up keeps its resumed-only filter because its dialog
reports). `toBillingTelemetryEvent` already emits the poller's payload
shape, so dashboards cannot tell the rails apart.
- **No client-derived server state.** Eligibility and already-held
answers come from the SDK and the server, as for top-up. `subscribe`,
`previewSubscribe`, `useSubscriptionCheckout` and `useLegacyBilling` are
untouched.

## AS-IS / TO-BE

| State | AS-IS (flag off) | TO-BE (flag on) |
| --- | --- | --- |
| Cancel dialog at rest | <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/as-is-cancel-dialog.png">
| <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/to-be-cancel-dialog.png">
|
| Cancel in flight | <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/as-is-cancel-in-flight.png">
| <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/to-be-cancel-in-flight.png">
|
| Cancel settled (success toast) | <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/as-is-cancel-settled.png">
| <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/to-be-cancel-settled.png">
|
| Cancel failed (error toast) | <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/as-is-cancel-failed.png">
| <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/to-be-cancel-failed.png">
|
| User popover after cancel (cancelled state) | <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/as-is-panel-after-cancel.png">
| <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/to-be-panel-after-cancel.png">
|
| Cancel request recorded | <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/as-is-network.png">
| <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/to-be-network.png">
|
| Settings billing panel | <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/as-is-billing-panel.png">
| <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/to-be-billing-panel.png">
|
| Resubscribe (Resume Pro) | <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/as-is-resubscribe.png">
| <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/to-be-resubscribe.png">
|
| Resubscribe request recorded | <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/as-is-resubscribe-network.png">
| <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/to-be-resubscribe-network.png">
|
| Payment-portal request recorded | <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/as-is-portal-network.png">
| <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/to-be-portal-network.png">
|

- AS-IS (flag off): cancel / resubscribe / portal POST the workspace API
directly; settlement and telemetry come from the legacy poller.
- TO-BE (flag on): the same dialogs and toasts, the POSTs go through the
SDK transport (`Idempotency-Key` on the request), settlement through the
operation lifecycle; a 404 falls back to the legacy call.

## Testing

| Gate | Result |
| --- | --- |
| `vitest run src/platform/workspace/billing src/composables/billing
src/platform/workspace/composables src/platform/workspace/stores
src/composables/useFeatureFlags` | 41 files, 1138 tests (12 new
projection tests, 13 new adapter rail tests, +5 store tests) |
| `pnpm typecheck`, `pnpm typecheck:browser`, `lint`, `format:check`,
`knip` | exit 0 |
| `fallow audit --changed-since
origin/jaewon/fe-2210-hosted-destination-port` | no issues in 11 changed
files, complexity 0, duplication 0 |
| Playwright
`browser_tests/tests/dialogs/cancelSubscriptionSdkRail.spec.ts` (cloud
project) | **3 passed** against a served cloud dev build —
`PLAYWRIGHT_TEST_URL=http://localhost:5173 pnpm exec playwright test
--project=cloud
browser_tests/tests/dialogs/cancelSubscriptionSdkRail.spec.ts
--reporter=list`. Flag off → legacy request, flow unchanged; flag on →
SDK request (`Idempotency-Key`), same dialog outcome; flag on + 404 →
legacy fallback. |

## Where this sits in the plan

Billing SDK track FE-2210 ([implementation plan
V2](https://app.notion.com/p/3d86d73d36508152b92cdbdfdfe83ac8)). Hybrid
model: top-up in-app, subscription management / invoices / payment
methods on the hosted billing app.

| Phase | Item | Ticket | Status |
| --- | --- | --- | --- |
| 1-2 | Session core, transport, readers | FE-2211/2212/2213 | merged |
| 3 | Operation lifecycle, commands, eight-state projection |
FE-2227/2214/2223 | merged (#17655) |
| 4 | `@comfyorg/account-ui` composables + `CheckoutSteps` | FE-2215 |
merged (#17662, #17663) |
| 5 slice 1 | Top-up through the SDK behind `billing_sdk_topup_enabled`
| FE-2216 | merged (#17665) |
| rollout C | `hosted_billing_destination` server flag read by the host
| FE-2218 | merged (#17716) |
| rollout C | `hostedDestination` port on the lifecycle, value on
operation state | FE-2210/2218 | #17783 (review; parent of this PR) |
| 7 prep | Scope-source port + credentialed transport (BFF / cookie
hosts) | FE-2218 | merged (#17782) |
| 7 prep | `@comfyorg/account` → `@comfyorg/account-core` rename |
FE-2218 | #17851 (review) |
| 7 prep | `billing-contract` route builder + `return_to` registry |
FE-2218 | merged (#17795) |
| 3A-3 | Workshop adapter over `createHostedTopupCheckout` | FE-2214 |
merged (#17793) |
| 8 core | `previewSubscribe` command | FE-2331 | merged (#17797) |
| 8 core | Plans + saved payment-methods readers | FE-2331 | #17798
(queued) |
| 8 ui | account-ui composables (`usePlans`, `usePaymentMethods`,
`usePreviewSubscribe`) | FE-2331 | #17798 (queued) |
| 7 | billing-web own-origin session, sign-in, SDK composition | FE-2218
| #17798 (queued) |
| 7 | billing-web unit tests in CI (`ci-billing-web-unit.yaml`) |
FE-2218 | merged (#17827); #17844 (queued) |
| 7 | ingest CORS + top-up return hosts for billing.comfy.org and its
previews (Comfy-Org/cloud) | FE-2218 | merged (Comfy-Org/cloud#9512) |
| 8 ui | billing-web `/v1` entry routing + subscription / payment-method
surfaces | FE-2331 | #17798 (queued) |
| 7 | npm publish (`ingest-types`, `account-core`, `billing-contract`),
Platform install, billing-web live top-up | FE-2218 | todo |
| 6 | Contract tests per generated schema (package layer) | FE-2217 |
#17829 (review) |
| 6 | Live E2E per flow × consumer + evidence table | FE-2217 | todo
(needs staging flags) |
| 5 slice 2a | Cancel, resubscribe and payment portal through the SDK
behind `billing_sdk_subscription_enabled` | FE-2216 | **this PR** |
| 5 slice 2b | Subscribe / plan change through the SDK
(`previewSubscribe` quote, then subscribe; the SDK stops
short-circuiting an active plan) | FE-2216 | next, stacked on this PR |
| follow-up | One `needsCustomerAttention` predicate (from the #17665
review) | FE-2216 | merged (#17792) |
| follow-up | Opaque `BillingServerCode` (from the #17656 review) |
FE-2227 | merged (#17794) |
| follow-up | `useCredits` clears on `SUPERSEDED` (from the #17799
review) | FE-2215 | merged (#17824) |
| follow-up | credits / status / capabilities readers fence a late
failure as `SUPERSEDED` (from the #17798 review) | FE-2331 | merged
(#17828) |

```mermaid
flowchart LR
  P3["Phase 3 core lifecycle (merged)"]
  P4["Phase 4 account-ui (merged)"]
  P5["Phase 5 slice 1 top-up flag (merged)"]
  FC["PR 17716 hosted_billing_destination flag (merged)"]
  HD["PR 17783 hostedDestination port"]
  SS["PR 17782 scope-source port + credentialed transport"]
  RN["account-core rename"]
  RB["billing-contract route builder + return_to"]
  WS["Workshop adapter"]
  P8PV["previewSubscribe command"]
  P8RD["plans + payment-methods readers"]
  P8["account-ui hosted composables"]
  BWS["billing-web session + sign-in"]
  BWV["billing-web /v1 surfaces"]
  CORS["cloud PR 9512 ingest CORS + return hosts"]
  PUB["npm publish account-core / billing-contract"]
  P7["Phase 7 host proof: Platform + billing-web live"]
  P6C["Phase 6 contract tests"]
  P6["Phase 6 live evidence"]
  S2A["Phase 5 slice 2a cancel / resubscribe / portal rail"]
  S2B["Phase 5 slice 2b subscribe + plan change"]
  FU9["customer-attention predicate"]
  FU11["opaque BillingServerCode"]
  FU12["useCredits clears on SUPERSEDED"]
  FU13["reader late-failure fence"]
  P3 --> HD
  FC --> HD
  HD --> RB
  P3 --> SS
  SS --> P7
  RB --> P7
  P3 --> RN
  RN --> PUB
  RB --> PUB
  PUB --> P7
  P3 --> P8PV
  P3 --> P8RD
  P8PV --> P8
  P8RD --> P8
  P4 --> P8
  P8 --> S2B
  HD --> S2A
  S2A --> S2B
  P8 --> BWS
  BWS --> BWV
  RB --> BWV
  BWV --> P7
  CORS --> P7
  P5 --> P6
  P3 --> P6C
  P5 --> WS
  P5 --> FU9
  P3 --> FU11
  P4 --> FU12
  P3 --> FU13
  style P3 fill:#d4edda,stroke:#155724
  style P4 fill:#d4edda,stroke:#155724
  style P5 fill:#d4edda,stroke:#155724
  style FC fill:#d4edda,stroke:#155724
  style SS fill:#d4edda,stroke:#155724
  style RB fill:#d4edda,stroke:#155724
  style WS fill:#d4edda,stroke:#155724
  style FU9 fill:#d4edda,stroke:#155724
  style FU11 fill:#d4edda,stroke:#155724
  style FU12 fill:#d4edda,stroke:#155724
  style FU13 fill:#d4edda,stroke:#155724
  style CORS fill:#d4edda,stroke:#155724
  style P8PV fill:#d4edda,stroke:#155724
  style S2A stroke:#0366d6,stroke-width:4px
```
pull Bot pushed a commit to Penguinjanator/ComfyUI_frontend that referenced this pull request Sep 16, 2026
… billing reads (Comfy-Org#17852)

Stacked on Comfy-Org#17798 (base branch
`jaewon/fe-2331-plans-payment-methods-readers`); merge that first.
Comfy-Org#17851 (the `account-core` rename) sits on the same parent: whichever of
the two lands second is re-based mechanically (the rename has a replay
script).

## Why

`fallow audit` on Comfy-Org#17798 reported a clone family across the five billing
readers: `credits.ts`, `status.ts`, `capabilities.ts`, `plans.ts` and
`paymentMethods.ts` each re-implemented the same fetch-and-fence shape —
capture the scope, share one request per scope, release a caller on its
own signal, report a late answer (success or failure) as `SUPERSEDED`,
and drop a published snapshot on a denial unless the request predates a
change the host fenced. Five copies of that logic is five places the
Comfy-Org#17828 late-failure fence had to be applied, and the next reader would
have been a sixth.

## How

One skeleton, `createScopedReader`, owns the request sharing, the caller
release, the publish fence and the denial drop. A reader supplies only
its route, decoder (`parse`) and projection into a snapshot, plus two
optional hooks that absorb the real variants: `cached` (capabilities'
freshness window) and `publish` (payment-methods' fenced list,
capabilities' publish-as-stale). `setSnapshot` and `fenceInFlight({
detach })` let each reader assemble its own `invalidate` — capabilities
fences without detaching, payment methods fences and detaches.

The public API of every reader is unchanged in shape and semantics:
`index.ts` is untouched and no consumer in `account-ui`, `billing-web`
or `src/platform/workspace/billing` changed. Per-reader production size:
credits 158→80, status 137→64, plans 163→78, paymentMethods 197→94,
capabilities 317→235 lines.

Tests: the fence family is proven once in `scopedReader.test.ts` with a
five-reader case table (sparse filters for the one reader that paces
itself), and each reader keeps only the tests of its own projection —
capabilities' freshness, denials, revision invalidation and
`resolved_for` checks; payment-methods' three invalidation cases.
Coverage went up: status gained the signed-out-in-flight case, plans and
payment methods gained dispose, all five gained sign-out-then-read.

## AS-IS / TO-BE

No user-facing change; core package internals only.

- AS-IS: five readers, each with its own copy of the scope fence; fallow
reports 2 clone groups / 46 lines across three of them plus 4 groups
spanning all four non-paced readers.
- TO-BE: one skeleton, five thin readers; `fallow audit --changed-since
<parent>` reports duplication 0 and no clone group above the 3-instance
threshold.

## Testing

| Gate | Result |
| --- | --- |
| `packages/account` vitest | 42 files, 659 tests (67 new shared cases
replace 82 per-reader copies) |
| `packages/account-ui` vitest | 9 files, 41 tests |
| `@comfyorg/billing-web` test:unit | 10 files, 90 tests |
| `pnpm typecheck`, `lint`, `format`, `knip` | exit 0 |
| `fallow audit --changed-since
origin/jaewon/fe-2331-plans-payment-methods-readers` | no issues in 13
changed files |

## Where this sits in the plan

Billing SDK track FE-2210 ([implementation plan
V2](https://app.notion.com/p/3d86d73d36508152b92cdbdfdfe83ac8)). Hybrid
model: top-up in-app, subscription management / invoices / payment
methods on the hosted billing app.

| Phase | Item | Ticket | Status |
| --- | --- | --- | --- |
| 1-2 | Session core, transport, readers | FE-2211/2212/2213 | merged |
| 3 | Operation lifecycle, commands, eight-state projection |
FE-2227/2214/2223 | merged (Comfy-Org#17655) |
| 4 | `@comfyorg/account-ui` composables + `CheckoutSteps` | FE-2215 |
merged (Comfy-Org#17662, Comfy-Org#17663) |
| 5 slice 1 | Top-up through the SDK behind `billing_sdk_topup_enabled`
| FE-2216 | merged (Comfy-Org#17665) |
| rollout C | `hosted_billing_destination` server flag read by the host
| FE-2218 | merged (Comfy-Org#17716) |
| rollout C | `hostedDestination` port on the lifecycle, value on
operation state | FE-2210/2218 | Comfy-Org#17783 (review) |
| 7 prep | Scope-source port + credentialed transport (BFF / cookie
hosts) | FE-2218 | merged (Comfy-Org#17782) |
| 7 prep | `@comfyorg/account` → `@comfyorg/account-core` rename |
FE-2218 | Comfy-Org#17851 (review, sibling of this PR on Comfy-Org#17798) |
| 7 prep | `billing-contract` route builder + `return_to` registry |
FE-2218 | merged (Comfy-Org#17795) |
| 3A-3 | Workshop adapter over `createHostedTopupCheckout` | FE-2214 |
merged (Comfy-Org#17793) |
| 8 core | `previewSubscribe` command | FE-2331 | merged (Comfy-Org#17797) |
| 8 core | Plans + saved payment-methods readers | FE-2331 | Comfy-Org#17798
(review) |
| 8 ui | account-ui composables (`usePlans`, `usePaymentMethods`,
`usePreviewSubscribe`) | FE-2331 | Comfy-Org#17798 (review) |
| 7 | billing-web own-origin session, sign-in, SDK composition | FE-2218
| Comfy-Org#17798 (review) |
| 7 | billing-web unit tests in CI (`ci-billing-web-unit.yaml`) |
FE-2218 | merged (Comfy-Org#17827); Comfy-Org#17844 follow-up (review) |
| 7 | ingest CORS + top-up return hosts for billing.comfy.org and its
previews (Comfy-Org/cloud) | FE-2218 | merged (Comfy-Org/cloud#9512) |
| 8 ui | billing-web `/v1` entry routing + subscription / payment-method
surfaces | FE-2331 | Comfy-Org#17798 (review) |
| 7 | npm publish (`ingest-types`, `account-core`, `billing-contract`),
Platform install, billing-web live top-up | FE-2218 | todo |
| 6 | Contract tests per generated schema (package layer) | FE-2217 |
Comfy-Org#17829 (review) |
| 6 | Live E2E per flow × consumer + evidence table | FE-2217 | todo
(needs staging flags) |
| 5 slice 2 | Subscription flows through the SDK | FE-2216 | todo
(plan-change decision) |
| follow-up | One `needsCustomerAttention` predicate (from the Comfy-Org#17665
review) | FE-2216 | merged (Comfy-Org#17792) |
| follow-up | Opaque `BillingServerCode` (from the Comfy-Org#17656 review) |
FE-2227 | merged (Comfy-Org#17794) |
| follow-up | `useCredits` clears on `SUPERSEDED` (from the Comfy-Org#17799
review) | FE-2215 | merged (Comfy-Org#17824) |
| follow-up | credits / status / capabilities readers fence a late
failure as `SUPERSEDED` (from the Comfy-Org#17798 review) | FE-2331 | merged
(Comfy-Org#17828) |
| follow-up | one scoped-reader skeleton behind the five billing reads
(from the Comfy-Org#17798 fallow report) | FE-2331 | **this PR** |

```mermaid
flowchart LR
  P3["Phase 3 core lifecycle (merged)"]
  P4["Phase 4 account-ui (merged)"]
  P5["Phase 5 slice 1 top-up flag (merged)"]
  FC["PR 17716 hosted_billing_destination flag (merged)"]
  HD["PR 17783 hostedDestination port"]
  SS["PR 17782 scope-source port + credentialed transport"]
  RN["account-core rename"]
  RB["billing-contract route builder + return_to"]
  WS["Workshop adapter"]
  P8PV["previewSubscribe command"]
  P8RD["plans + payment-methods readers"]
  P8["account-ui hosted composables"]
  BWS["billing-web session + sign-in"]
  BWV["billing-web /v1 surfaces"]
  CORS["cloud PR 9512 ingest CORS + return hosts"]
  PUB["npm publish account-core / billing-contract"]
  P7["Phase 7 host proof: Platform + billing-web live"]
  P6C["Phase 6 contract tests"]
  P6["Phase 6 live evidence"]
  S2["Phase 5 slice 2 subscription"]
  FU9["customer-attention predicate"]
  FU11["opaque BillingServerCode"]
  FU12["useCredits clears on SUPERSEDED"]
  FU13["reader late-failure fence"]
  FU14["scoped reader skeleton"]
  P3 --> HD
  FC --> HD
  HD --> RB
  P3 --> SS
  SS --> P7
  RB --> P7
  P3 --> RN
  RN --> PUB
  RB --> PUB
  PUB --> P7
  P3 --> P8PV
  P3 --> P8RD
  P8PV --> P8
  P8RD --> P8
  P4 --> P8
  P8 --> S2
  P8 --> BWS
  BWS --> BWV
  RB --> BWV
  BWV --> P7
  CORS --> P7
  P5 --> P6
  P3 --> P6C
  P5 --> WS
  P5 --> FU9
  P3 --> FU11
  P4 --> FU12
  P3 --> FU13
  P8RD --> FU14
  FU13 --> FU14
  style P3 fill:#d4edda,stroke:#155724
  style P4 fill:#d4edda,stroke:#155724
  style P5 fill:#d4edda,stroke:#155724
  style FC fill:#d4edda,stroke:#155724
  style SS fill:#d4edda,stroke:#155724
  style RB fill:#d4edda,stroke:#155724
  style WS fill:#d4edda,stroke:#155724
  style FU9 fill:#d4edda,stroke:#155724
  style FU11 fill:#d4edda,stroke:#155724
  style FU12 fill:#d4edda,stroke:#155724
  style FU13 fill:#d4edda,stroke:#155724
  style CORS fill:#d4edda,stroke:#155724
  style P8PV fill:#d4edda,stroke:#155724
  style FU14 stroke:#0366d6,stroke-width:4px
```
dante01yoon added a commit that referenced this pull request Sep 17, 2026
…the SDK rail behind billing_sdk_subscription_enabled (#17853)

Stacked on #17783 (base branch
`jaewon/fe-2210-hosted-destination-port`); merge that first.

Phase 5 slice 1 (#17665) moved top-up onto the Billing SDK behind
`billing_sdk_topup_enabled`. The subscription actions the host already
owns — cancel, resubscribe, and opening the payment portal — still call
the workspace API directly and rely on the legacy poller for settlement
and telemetry. This slice moves those three onto the SDK's commands
behind their own server flag, `billing_sdk_subscription_enabled`
(already on `/api/features` via Comfy-Org/cloud#9248, PostHog at 0%), so
the eight-state lifecycle, idempotency, recovery and telemetry come from
one implementation. Subscribe and plan change are slice 2b, stacked on
this PR.

- **Rail switch.** `billingSdkSubscriptionRailEnabled` =
`billing_sdk_subscription_enabled` AND `unified_cloud_auth`, exactly
like the top-up rail. `useSubscriptionRail()` reads it once,
synchronously, at the start of an action, so a flag flip mid-flow cannot
issue on one rail and observe on the other.
- **Three actions, one adapter.**
`useWorkspaceBilling.cancelSubscription / resubscribe /
manageSubscription` try the rail first; the store runs
`sdk.commands.cancelSubscription()`, `resubscribe()`,
`openPaymentPortal({ returnUrl })` and projects the result onto what the
adapter already does with the legacy calls: settle, or throw a
`WorkspaceApiError` (message is the host's, since the SDK never carries
server text; `serverCode` lands in `.code`). A command that settles in
any phase but `succeeded` is a failure, matching the poller. The refresh
after success mirrors the poller's: cancel → status + balance +
capabilities; resubscribe → `reconcileSubscriptionSuccess` +
capabilities.
- **Fallback.** A 404 (backend gate closed while the client flag is on)
projects to `unavailable`: the adapter runs its legacy body for that
action, and the store latches the route as unavailable for the tab so
later actions go straight to legacy without another failed round trip.
Every other failure — including `SUPERSEDED` — is thrown, never retried
on legacy, so a late or superseded result cannot double-issue.
- **Telemetry.** Lifecycle events are now reported for non-topup
operations (top-up keeps its resumed-only filter because its dialog
reports). `toBillingTelemetryEvent` already emits the poller's payload
shape, so dashboards cannot tell the rails apart.
- **No client-derived server state.** Eligibility and already-held
answers come from the SDK and the server, as for top-up. `subscribe`,
`previewSubscribe`, `useSubscriptionCheckout` and `useLegacyBilling` are
untouched.

| State | AS-IS (flag off) | TO-BE (flag on) |
| --- | --- | --- |
| Cancel dialog at rest | <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/as-is-cancel-dialog.png">
| <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/to-be-cancel-dialog.png">
|
| Cancel in flight | <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/as-is-cancel-in-flight.png">
| <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/to-be-cancel-in-flight.png">
|
| Cancel settled (success toast) | <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/as-is-cancel-settled.png">
| <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/to-be-cancel-settled.png">
|
| Cancel failed (error toast) | <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/as-is-cancel-failed.png">
| <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/to-be-cancel-failed.png">
|
| User popover after cancel (cancelled state) | <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/as-is-panel-after-cancel.png">
| <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/to-be-panel-after-cancel.png">
|
| Cancel request recorded | <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/as-is-network.png">
| <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/to-be-network.png">
|
| Settings billing panel | <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/as-is-billing-panel.png">
| <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/to-be-billing-panel.png">
|
| Resubscribe (Resume Pro) | <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/as-is-resubscribe.png">
| <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/to-be-resubscribe.png">
|
| Resubscribe request recorded | <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/as-is-resubscribe-network.png">
| <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/to-be-resubscribe-network.png">
|
| Payment-portal request recorded | <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/as-is-portal-network.png">
| <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/to-be-portal-network.png">
|

- AS-IS (flag off): cancel / resubscribe / portal POST the workspace API
directly; settlement and telemetry come from the legacy poller.
- TO-BE (flag on): the same dialogs and toasts, the POSTs go through the
SDK transport (`Idempotency-Key` on the request), settlement through the
operation lifecycle; a 404 falls back to the legacy call.

| Gate | Result |
| --- | --- |
| `vitest run src/platform/workspace/billing src/composables/billing
src/platform/workspace/composables src/platform/workspace/stores
src/composables/useFeatureFlags` | 41 files, 1138 tests (12 new
projection tests, 13 new adapter rail tests, +5 store tests) |
| `pnpm typecheck`, `pnpm typecheck:browser`, `lint`, `format:check`,
`knip` | exit 0 |
| `fallow audit --changed-since
origin/jaewon/fe-2210-hosted-destination-port` | no issues in 11 changed
files, complexity 0, duplication 0 |
| Playwright
`browser_tests/tests/dialogs/cancelSubscriptionSdkRail.spec.ts` (cloud
project) | **3 passed** against a served cloud dev build —
`PLAYWRIGHT_TEST_URL=http://localhost:5173 pnpm exec playwright test
--project=cloud
browser_tests/tests/dialogs/cancelSubscriptionSdkRail.spec.ts
--reporter=list`. Flag off → legacy request, flow unchanged; flag on →
SDK request (`Idempotency-Key`), same dialog outcome; flag on + 404 →
legacy fallback. |

Billing SDK track FE-2210 ([implementation plan
V2](https://app.notion.com/p/3d86d73d36508152b92cdbdfdfe83ac8)). Hybrid
model: top-up in-app, subscription management / invoices / payment
methods on the hosted billing app.

| Phase | Item | Ticket | Status |
| --- | --- | --- | --- |
| 1-2 | Session core, transport, readers | FE-2211/2212/2213 | merged |
| 3 | Operation lifecycle, commands, eight-state projection |
FE-2227/2214/2223 | merged (#17655) |
| 4 | `@comfyorg/account-ui` composables + `CheckoutSteps` | FE-2215 |
merged (#17662, #17663) |
| 5 slice 1 | Top-up through the SDK behind `billing_sdk_topup_enabled`
| FE-2216 | merged (#17665) |
| rollout C | `hosted_billing_destination` server flag read by the host
| FE-2218 | merged (#17716) |
| rollout C | `hostedDestination` port on the lifecycle, value on
operation state | FE-2210/2218 | #17783 (review; parent of this PR) |
| 7 prep | Scope-source port + credentialed transport (BFF / cookie
hosts) | FE-2218 | merged (#17782) |
| 7 prep | `@comfyorg/account` → `@comfyorg/account-core` rename |
FE-2218 | #17851 (review) |
| 7 prep | `billing-contract` route builder + `return_to` registry |
FE-2218 | merged (#17795) |
| 3A-3 | Workshop adapter over `createHostedTopupCheckout` | FE-2214 |
merged (#17793) |
| 8 core | `previewSubscribe` command | FE-2331 | merged (#17797) |
| 8 core | Plans + saved payment-methods readers | FE-2331 | #17798
(queued) |
| 8 ui | account-ui composables (`usePlans`, `usePaymentMethods`,
`usePreviewSubscribe`) | FE-2331 | #17798 (queued) |
| 7 | billing-web own-origin session, sign-in, SDK composition | FE-2218
| #17798 (queued) |
| 7 | billing-web unit tests in CI (`ci-billing-web-unit.yaml`) |
FE-2218 | merged (#17827); #17844 (queued) |
| 7 | ingest CORS + top-up return hosts for billing.comfy.org and its
previews (Comfy-Org/cloud) | FE-2218 | merged (Comfy-Org/cloud#9512) |
| 8 ui | billing-web `/v1` entry routing + subscription / payment-method
surfaces | FE-2331 | #17798 (queued) |
| 7 | npm publish (`ingest-types`, `account-core`, `billing-contract`),
Platform install, billing-web live top-up | FE-2218 | todo |
| 6 | Contract tests per generated schema (package layer) | FE-2217 |
| 6 | Live E2E per flow × consumer + evidence table | FE-2217 | todo
(needs staging flags) |
| 5 slice 2a | Cancel, resubscribe and payment portal through the SDK
behind `billing_sdk_subscription_enabled` | FE-2216 | **this PR** |
| 5 slice 2b | Subscribe / plan change through the SDK
(`previewSubscribe` quote, then subscribe; the SDK stops
short-circuiting an active plan) | FE-2216 | next, stacked on this PR |
| follow-up | One `needsCustomerAttention` predicate (from the #17665
review) | FE-2216 | merged (#17792) |
| follow-up | Opaque `BillingServerCode` (from the #17656 review) |
FE-2227 | merged (#17794) |
| follow-up | `useCredits` clears on `SUPERSEDED` (from the #17799
review) | FE-2215 | merged (#17824) |
| follow-up | credits / status / capabilities readers fence a late
failure as `SUPERSEDED` (from the #17798 review) | FE-2331 | merged
(#17828) |

```mermaid
flowchart LR
  P3["Phase 3 core lifecycle (merged)"]
  P4["Phase 4 account-ui (merged)"]
  P5["Phase 5 slice 1 top-up flag (merged)"]
  FC["PR 17716 hosted_billing_destination flag (merged)"]
  HD["PR 17783 hostedDestination port"]
  SS["PR 17782 scope-source port + credentialed transport"]
  RN["account-core rename"]
  RB["billing-contract route builder + return_to"]
  WS["Workshop adapter"]
  P8PV["previewSubscribe command"]
  P8RD["plans + payment-methods readers"]
  P8["account-ui hosted composables"]
  BWS["billing-web session + sign-in"]
  BWV["billing-web /v1 surfaces"]
  CORS["cloud PR 9512 ingest CORS + return hosts"]
  PUB["npm publish account-core / billing-contract"]
  P7["Phase 7 host proof: Platform + billing-web live"]
  P6C["Phase 6 contract tests"]
  P6["Phase 6 live evidence"]
  S2A["Phase 5 slice 2a cancel / resubscribe / portal rail"]
  S2B["Phase 5 slice 2b subscribe + plan change"]
  FU9["customer-attention predicate"]
  FU11["opaque BillingServerCode"]
  FU12["useCredits clears on SUPERSEDED"]
  FU13["reader late-failure fence"]
  P3 --> HD
  FC --> HD
  HD --> RB
  P3 --> SS
  SS --> P7
  RB --> P7
  P3 --> RN
  RN --> PUB
  RB --> PUB
  PUB --> P7
  P3 --> P8PV
  P3 --> P8RD
  P8PV --> P8
  P8RD --> P8
  P4 --> P8
  P8 --> S2B
  HD --> S2A
  S2A --> S2B
  P8 --> BWS
  BWS --> BWV
  RB --> BWV
  BWV --> P7
  CORS --> P7
  P5 --> P6
  P3 --> P6C
  P5 --> WS
  P5 --> FU9
  P3 --> FU11
  P4 --> FU12
  P3 --> FU13
  style P3 fill:#d4edda,stroke:#155724
  style P4 fill:#d4edda,stroke:#155724
  style P5 fill:#d4edda,stroke:#155724
  style FC fill:#d4edda,stroke:#155724
  style SS fill:#d4edda,stroke:#155724
  style RB fill:#d4edda,stroke:#155724
  style WS fill:#d4edda,stroke:#155724
  style FU9 fill:#d4edda,stroke:#155724
  style FU11 fill:#d4edda,stroke:#155724
  style FU12 fill:#d4edda,stroke:#155724
  style FU13 fill:#d4edda,stroke:#155724
  style CORS fill:#d4edda,stroke:#155724
  style P8PV fill:#d4edda,stroke:#155724
  style S2A stroke:#0366d6,stroke-width:4px
```
dante01yoon added a commit that referenced this pull request Sep 17, 2026
…the SDK rail behind billing_sdk_subscription_enabled (#17853)

Stacked on #17783 (base branch
`jaewon/fe-2210-hosted-destination-port`); merge that first.

Phase 5 slice 1 (#17665) moved top-up onto the Billing SDK behind
`billing_sdk_topup_enabled`. The subscription actions the host already
owns — cancel, resubscribe, and opening the payment portal — still call
the workspace API directly and rely on the legacy poller for settlement
and telemetry. This slice moves those three onto the SDK's commands
behind their own server flag, `billing_sdk_subscription_enabled`
(already on `/api/features` via Comfy-Org/cloud#9248, PostHog at 0%), so
the eight-state lifecycle, idempotency, recovery and telemetry come from
one implementation. Subscribe and plan change are slice 2b, stacked on
this PR.

- **Rail switch.** `billingSdkSubscriptionRailEnabled` =
`billing_sdk_subscription_enabled` AND `unified_cloud_auth`, exactly
like the top-up rail. `useSubscriptionRail()` reads it once,
synchronously, at the start of an action, so a flag flip mid-flow cannot
issue on one rail and observe on the other.
- **Three actions, one adapter.**
`useWorkspaceBilling.cancelSubscription / resubscribe /
manageSubscription` try the rail first; the store runs
`sdk.commands.cancelSubscription()`, `resubscribe()`,
`openPaymentPortal({ returnUrl })` and projects the result onto what the
adapter already does with the legacy calls: settle, or throw a
`WorkspaceApiError` (message is the host's, since the SDK never carries
server text; `serverCode` lands in `.code`). A command that settles in
any phase but `succeeded` is a failure, matching the poller. The refresh
after success mirrors the poller's: cancel → status + balance +
capabilities; resubscribe → `reconcileSubscriptionSuccess` +
capabilities.
- **Fallback.** A 404 (backend gate closed while the client flag is on)
projects to `unavailable`: the adapter runs its legacy body for that
action, and the store latches the route as unavailable for the tab so
later actions go straight to legacy without another failed round trip.
Every other failure — including `SUPERSEDED` — is thrown, never retried
on legacy, so a late or superseded result cannot double-issue.
- **Telemetry.** Lifecycle events are now reported for non-topup
operations (top-up keeps its resumed-only filter because its dialog
reports). `toBillingTelemetryEvent` already emits the poller's payload
shape, so dashboards cannot tell the rails apart.
- **No client-derived server state.** Eligibility and already-held
answers come from the SDK and the server, as for top-up. `subscribe`,
`previewSubscribe`, `useSubscriptionCheckout` and `useLegacyBilling` are
untouched.

| State | AS-IS (flag off) | TO-BE (flag on) |
| --- | --- | --- |
| Cancel dialog at rest | <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/as-is-cancel-dialog.png">
| <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/to-be-cancel-dialog.png">
|
| Cancel in flight | <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/as-is-cancel-in-flight.png">
| <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/to-be-cancel-in-flight.png">
|
| Cancel settled (success toast) | <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/as-is-cancel-settled.png">
| <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/to-be-cancel-settled.png">
|
| Cancel failed (error toast) | <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/as-is-cancel-failed.png">
| <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/to-be-cancel-failed.png">
|
| User popover after cancel (cancelled state) | <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/as-is-panel-after-cancel.png">
| <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/to-be-panel-after-cancel.png">
|
| Cancel request recorded | <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/as-is-network.png">
| <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/to-be-network.png">
|
| Settings billing panel | <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/as-is-billing-panel.png">
| <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/to-be-billing-panel.png">
|
| Resubscribe (Resume Pro) | <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/as-is-resubscribe.png">
| <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/to-be-resubscribe.png">
|
| Resubscribe request recorded | <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/as-is-resubscribe-network.png">
| <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/to-be-resubscribe-network.png">
|
| Payment-portal request recorded | <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/as-is-portal-network.png">
| <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/to-be-portal-network.png">
|

- AS-IS (flag off): cancel / resubscribe / portal POST the workspace API
directly; settlement and telemetry come from the legacy poller.
- TO-BE (flag on): the same dialogs and toasts, the POSTs go through the
SDK transport (`Idempotency-Key` on the request), settlement through the
operation lifecycle; a 404 falls back to the legacy call.

| Gate | Result |
| --- | --- |
| `vitest run src/platform/workspace/billing src/composables/billing
src/platform/workspace/composables src/platform/workspace/stores
src/composables/useFeatureFlags` | 41 files, 1138 tests (12 new
projection tests, 13 new adapter rail tests, +5 store tests) |
| `pnpm typecheck`, `pnpm typecheck:browser`, `lint`, `format:check`,
`knip` | exit 0 |
| `fallow audit --changed-since
origin/jaewon/fe-2210-hosted-destination-port` | no issues in 11 changed
files, complexity 0, duplication 0 |
| Playwright
`browser_tests/tests/dialogs/cancelSubscriptionSdkRail.spec.ts` (cloud
project) | **3 passed** against a served cloud dev build —
`PLAYWRIGHT_TEST_URL=http://localhost:5173 pnpm exec playwright test
--project=cloud
browser_tests/tests/dialogs/cancelSubscriptionSdkRail.spec.ts
--reporter=list`. Flag off → legacy request, flow unchanged; flag on →
SDK request (`Idempotency-Key`), same dialog outcome; flag on + 404 →
legacy fallback. |

Billing SDK track FE-2210 ([implementation plan
V2](https://app.notion.com/p/3d86d73d36508152b92cdbdfdfe83ac8)). Hybrid
model: top-up in-app, subscription management / invoices / payment
methods on the hosted billing app.

| Phase | Item | Ticket | Status |
| --- | --- | --- | --- |
| 1-2 | Session core, transport, readers | FE-2211/2212/2213 | merged |
| 3 | Operation lifecycle, commands, eight-state projection |
FE-2227/2214/2223 | merged (#17655) |
| 4 | `@comfyorg/account-ui` composables + `CheckoutSteps` | FE-2215 |
merged (#17662, #17663) |
| 5 slice 1 | Top-up through the SDK behind `billing_sdk_topup_enabled`
| FE-2216 | merged (#17665) |
| rollout C | `hosted_billing_destination` server flag read by the host
| FE-2218 | merged (#17716) |
| rollout C | `hostedDestination` port on the lifecycle, value on
operation state | FE-2210/2218 | #17783 (review; parent of this PR) |
| 7 prep | Scope-source port + credentialed transport (BFF / cookie
hosts) | FE-2218 | merged (#17782) |
| 7 prep | `@comfyorg/account` → `@comfyorg/account-core` rename |
FE-2218 | #17851 (review) |
| 7 prep | `billing-contract` route builder + `return_to` registry |
FE-2218 | merged (#17795) |
| 3A-3 | Workshop adapter over `createHostedTopupCheckout` | FE-2214 |
merged (#17793) |
| 8 core | `previewSubscribe` command | FE-2331 | merged (#17797) |
| 8 core | Plans + saved payment-methods readers | FE-2331 | #17798
(queued) |
| 8 ui | account-ui composables (`usePlans`, `usePaymentMethods`,
`usePreviewSubscribe`) | FE-2331 | #17798 (queued) |
| 7 | billing-web own-origin session, sign-in, SDK composition | FE-2218
| #17798 (queued) |
| 7 | billing-web unit tests in CI (`ci-billing-web-unit.yaml`) |
FE-2218 | merged (#17827); #17844 (queued) |
| 7 | ingest CORS + top-up return hosts for billing.comfy.org and its
previews (Comfy-Org/cloud) | FE-2218 | merged (Comfy-Org/cloud#9512) |
| 8 ui | billing-web `/v1` entry routing + subscription / payment-method
surfaces | FE-2331 | #17798 (queued) |
| 7 | npm publish (`ingest-types`, `account-core`, `billing-contract`),
Platform install, billing-web live top-up | FE-2218 | todo |
| 6 | Contract tests per generated schema (package layer) | FE-2217 |
| 6 | Live E2E per flow × consumer + evidence table | FE-2217 | todo
(needs staging flags) |
| 5 slice 2a | Cancel, resubscribe and payment portal through the SDK
behind `billing_sdk_subscription_enabled` | FE-2216 | **this PR** |
| 5 slice 2b | Subscribe / plan change through the SDK
(`previewSubscribe` quote, then subscribe; the SDK stops
short-circuiting an active plan) | FE-2216 | next, stacked on this PR |
| follow-up | One `needsCustomerAttention` predicate (from the #17665
review) | FE-2216 | merged (#17792) |
| follow-up | Opaque `BillingServerCode` (from the #17656 review) |
FE-2227 | merged (#17794) |
| follow-up | `useCredits` clears on `SUPERSEDED` (from the #17799
review) | FE-2215 | merged (#17824) |
| follow-up | credits / status / capabilities readers fence a late
failure as `SUPERSEDED` (from the #17798 review) | FE-2331 | merged
(#17828) |

```mermaid
flowchart LR
  P3["Phase 3 core lifecycle (merged)"]
  P4["Phase 4 account-ui (merged)"]
  P5["Phase 5 slice 1 top-up flag (merged)"]
  FC["PR 17716 hosted_billing_destination flag (merged)"]
  HD["PR 17783 hostedDestination port"]
  SS["PR 17782 scope-source port + credentialed transport"]
  RN["account-core rename"]
  RB["billing-contract route builder + return_to"]
  WS["Workshop adapter"]
  P8PV["previewSubscribe command"]
  P8RD["plans + payment-methods readers"]
  P8["account-ui hosted composables"]
  BWS["billing-web session + sign-in"]
  BWV["billing-web /v1 surfaces"]
  CORS["cloud PR 9512 ingest CORS + return hosts"]
  PUB["npm publish account-core / billing-contract"]
  P7["Phase 7 host proof: Platform + billing-web live"]
  P6C["Phase 6 contract tests"]
  P6["Phase 6 live evidence"]
  S2A["Phase 5 slice 2a cancel / resubscribe / portal rail"]
  S2B["Phase 5 slice 2b subscribe + plan change"]
  FU9["customer-attention predicate"]
  FU11["opaque BillingServerCode"]
  FU12["useCredits clears on SUPERSEDED"]
  FU13["reader late-failure fence"]
  P3 --> HD
  FC --> HD
  HD --> RB
  P3 --> SS
  SS --> P7
  RB --> P7
  P3 --> RN
  RN --> PUB
  RB --> PUB
  PUB --> P7
  P3 --> P8PV
  P3 --> P8RD
  P8PV --> P8
  P8RD --> P8
  P4 --> P8
  P8 --> S2B
  HD --> S2A
  S2A --> S2B
  P8 --> BWS
  BWS --> BWV
  RB --> BWV
  BWV --> P7
  CORS --> P7
  P5 --> P6
  P3 --> P6C
  P5 --> WS
  P5 --> FU9
  P3 --> FU11
  P4 --> FU12
  P3 --> FU13
  style P3 fill:#d4edda,stroke:#155724
  style P4 fill:#d4edda,stroke:#155724
  style P5 fill:#d4edda,stroke:#155724
  style FC fill:#d4edda,stroke:#155724
  style SS fill:#d4edda,stroke:#155724
  style RB fill:#d4edda,stroke:#155724
  style WS fill:#d4edda,stroke:#155724
  style FU9 fill:#d4edda,stroke:#155724
  style FU11 fill:#d4edda,stroke:#155724
  style FU12 fill:#d4edda,stroke:#155724
  style FU13 fill:#d4edda,stroke:#155724
  style CORS fill:#d4edda,stroke:#155724
  style P8PV fill:#d4edda,stroke:#155724
  style S2A stroke:#0366d6,stroke-width:4px
```
pull Bot pushed a commit to Penguinjanator/ComfyUI_frontend that referenced this pull request Sep 17, 2026
…unt-core (Comfy-Org#17851)

Stacked on Comfy-Org#17798 (base branch
`jaewon/fe-2331-plans-payment-methods-readers`); merge that first, then
this rebases to `main` with no content change.

## Why

Phase 7 (FE-2218) publishes the framework-free billing core to npm so
Platform can install it from a clean non-workspace checkout, and the
plan fixes the physical `account-core` / `account-ui` split as the
boundary that gets published, not the transitional `packages/account`.
The view package `@comfyorg/account-ui` already exists; the core still
carries the old name. This is the one mechanical rename PR the plan
schedules after Phase 5 slice 1 and before the first publish.

## How

Two commits so the review is trivial:

1. `git mv packages/account packages/account-core` — 95 files, 0
insertions, 0 deletions, every path a 100% rename.
2. The specifier and config edits — package name `@comfyorg/account` →
`@comfyorg/account-core`, every `workspace:*` dependency (root,
`apps/billing-web`, `apps/website`, `packages/account-ui`), every import
specifier under `src/`, `packages/`, `apps/`, `browser_tests/`, the root
`typecheck` / `lint` scripts (`typecheck:account` →
`typecheck:account-core`), `knip.config.ts`, `eslint.config.ts`, the
per-package loop and codecov file list in `ci-tests-unit.yaml`, the
lockfile importer keys, and the two ADRs that name the package in prose.
The delta over a 1:1 swap is oxfmt reflowing import lines the five extra
characters pushed past 80 columns.

Left alone on purpose: the `./vue` entry (the auth Vue pieces move to
`account-ui` in the next PR of this stack), the Firebase app name
`comfy-account` in ADR-0028, and the ADR filenames and headings
(renaming those would break the ADR index and inbound links). `git grep
"@comfyorg/account\b"` and `git grep "packages/account/"` return nothing
after this change.

The replay script lives under `temp/scripts/rename-account-core.sh`
(gitignored); if a sibling PR merges first, re-running it on a fresh
base reproduces this diff.

## AS-IS / TO-BE

No user-facing change; package boundary only.

- AS-IS: `packages/account` publishes as `@comfyorg/account` and is the
name Platform would have to install, while the view layer is already
`@comfyorg/account-ui`.
- TO-BE: `packages/account-core` publishes as `@comfyorg/account-core`;
`account-ui` and `billing-web` depend on it by the final name.

## Testing

| Gate | Result |
| --- | --- |
| `pnpm install --frozen-lockfile` | resolves with the new name |
| `packages/account-core` vitest | 41 files, 674 tests |
| `packages/account-ui` vitest | 9 files, 41 tests |
| `@comfyorg/billing-web` test:unit / build | 10 files, 90 tests / built
|
| `@comfyorg/website` typecheck | 0 errors |
| root `pnpm typecheck`, `lint`, `format`, `knip` | all exit 0 |
| `vitest run src/platform/workspace/billing` | 5 files, 50 tests |
| `pnpm typecheck:browser`, `typecheck:website` (pre-commit) | green |

## Where this sits in the plan

Billing SDK track FE-2210 ([implementation plan
V2](https://app.notion.com/p/3d86d73d36508152b92cdbdfdfe83ac8)). Hybrid
model: top-up in-app, subscription management / invoices / payment
methods on the hosted billing app.

| Phase | Item | Ticket | Status |
| --- | --- | --- | --- |
| 1-2 | Session core, transport, readers | FE-2211/2212/2213 | merged |
| 3 | Operation lifecycle, commands, eight-state projection |
FE-2227/2214/2223 | merged (Comfy-Org#17655) |
| 4 | `@comfyorg/account-ui` composables + `CheckoutSteps` | FE-2215 |
merged (Comfy-Org#17662, Comfy-Org#17663) |
| 5 slice 1 | Top-up through the SDK behind `billing_sdk_topup_enabled`
| FE-2216 | merged (Comfy-Org#17665) |
| rollout C | `hosted_billing_destination` server flag read by the host
| FE-2218 | merged (Comfy-Org#17716) |
| rollout C | `hostedDestination` port on the lifecycle, value on
operation state | FE-2210/2218 | Comfy-Org#17783 (review) |
| 7 prep | Scope-source port + credentialed transport (BFF / cookie
hosts) | FE-2218 | merged (Comfy-Org#17782) |
| 7 prep | `@comfyorg/account` → `@comfyorg/account-core` rename |
FE-2218 | **this PR** |
| 7 prep | `billing-contract` route builder + `return_to` registry |
FE-2218 | merged (Comfy-Org#17795) |
| 3A-3 | Workshop adapter over `createHostedTopupCheckout` | FE-2214 |
merged (Comfy-Org#17793) |
| 8 core | `previewSubscribe` command | FE-2331 | merged (Comfy-Org#17797) |
| 8 core | Plans + saved payment-methods readers | FE-2331 | Comfy-Org#17798
(review) |
| 8 ui | account-ui composables (`usePlans`, `usePaymentMethods`,
`usePreviewSubscribe`) | FE-2331 | Comfy-Org#17798 (review) |
| 7 | billing-web own-origin session, sign-in, SDK composition | FE-2218
| Comfy-Org#17798 (review) |
| 7 | billing-web unit tests in CI (`ci-billing-web-unit.yaml`) |
FE-2218 | merged (Comfy-Org#17827); Comfy-Org#17844 follow-up (review) |
| 7 | ingest CORS + top-up return hosts for billing.comfy.org and its
previews (Comfy-Org/cloud) | FE-2218 | merged (Comfy-Org/cloud#9512) |
| 8 ui | billing-web `/v1` entry routing + subscription / payment-method
surfaces | FE-2331 | Comfy-Org#17798 (review) |
| 7 | npm publish (`ingest-types`, `account-core`, `billing-contract`),
Platform install, billing-web live top-up | FE-2218 | todo |
| 6 | Contract tests per generated schema (package layer) | FE-2217 |
Comfy-Org#17829 (review) |
| 6 | Live E2E per flow × consumer + evidence table | FE-2217 | todo
(needs staging flags) |
| 5 slice 2 | Subscription flows through the SDK | FE-2216 | todo
(plan-change decision) |
| follow-up | One `needsCustomerAttention` predicate (from the Comfy-Org#17665
review) | FE-2216 | merged (Comfy-Org#17792) |
| follow-up | Opaque `BillingServerCode` (from the Comfy-Org#17656 review) |
FE-2227 | merged (Comfy-Org#17794) |
| follow-up | `useCredits` clears on `SUPERSEDED` (from the Comfy-Org#17799
review) | FE-2215 | merged (Comfy-Org#17824) |
| follow-up | credits / status / capabilities readers fence a late
failure as `SUPERSEDED` (from the Comfy-Org#17798 review) | FE-2331 | merged
(Comfy-Org#17828) |

```mermaid
flowchart LR
  P3["Phase 3 core lifecycle (merged)"]
  P4["Phase 4 account-ui (merged)"]
  P5["Phase 5 slice 1 top-up flag (merged)"]
  FC["PR 17716 hosted_billing_destination flag (merged)"]
  HD["PR 17783 hostedDestination port"]
  SS["PR 17782 scope-source port + credentialed transport"]
  RN["account-core rename"]
  RB["billing-contract route builder + return_to"]
  WS["Workshop adapter"]
  P8PV["previewSubscribe command"]
  P8RD["plans + payment-methods readers"]
  P8["account-ui hosted composables"]
  BWS["billing-web session + sign-in"]
  BWV["billing-web /v1 surfaces"]
  CORS["cloud PR 9512 ingest CORS + return hosts"]
  PUB["npm publish account-core / billing-contract"]
  P7["Phase 7 host proof: Platform + billing-web live"]
  P6C["Phase 6 contract tests"]
  P6["Phase 6 live evidence"]
  S2["Phase 5 slice 2 subscription"]
  FU9["customer-attention predicate"]
  FU11["opaque BillingServerCode"]
  FU12["useCredits clears on SUPERSEDED"]
  FU13["reader late-failure fence"]
  P3 --> HD
  FC --> HD
  HD --> RB
  P3 --> SS
  SS --> P7
  RB --> P7
  P3 --> RN
  RN --> PUB
  RB --> PUB
  PUB --> P7
  P3 --> P8PV
  P3 --> P8RD
  P8PV --> P8
  P8RD --> P8
  P4 --> P8
  P8 --> S2
  P8 --> BWS
  BWS --> BWV
  RB --> BWV
  BWV --> P7
  CORS --> P7
  P5 --> P6
  P3 --> P6C
  P5 --> WS
  P5 --> FU9
  P3 --> FU11
  P4 --> FU12
  P3 --> FU13
  style P3 fill:#d4edda,stroke:#155724
  style P4 fill:#d4edda,stroke:#155724
  style P5 fill:#d4edda,stroke:#155724
  style FC fill:#d4edda,stroke:#155724
  style SS fill:#d4edda,stroke:#155724
  style RB fill:#d4edda,stroke:#155724
  style WS fill:#d4edda,stroke:#155724
  style FU9 fill:#d4edda,stroke:#155724
  style FU11 fill:#d4edda,stroke:#155724
  style FU12 fill:#d4edda,stroke:#155724
  style FU13 fill:#d4edda,stroke:#155724
  style CORS fill:#d4edda,stroke:#155724
  style P8PV fill:#d4edda,stroke:#155724
  style RN stroke:#0366d6,stroke-width:4px
```
pull Bot pushed a commit to Mu-L/ComfyUI_frontend that referenced this pull request Sep 17, 2026
…ling core (Comfy-Org#17854)

Stacked on Comfy-Org#17851 (base branch `jaewon/fe-2218-account-core-rename`),
which stacks on Comfy-Org#17798; merge those first.

## Why

The plan's first decision was that the Vue layer leaves the account
package: composables and unstyled components ship from
`@comfyorg/account-ui`, and the core keeps zero Vue coupling by
construction rather than by an import-guard test. The auth Vue pieces
(`PasswordRules`, `SocialAuthButtons`, `TurnstileWidget`, the region and
Turnstile gates, the lifecycle scope and generation guard) had shipped
in the core's `./vue` entry days before that decision and were
deliberately left for a later follow-up so the fresh auth stack was not
destabilised. With the rename in Comfy-Org#17851 fixing `account-core` as the
boundary that gets published (Phase 7), this is that follow-up: the
published core must not drag `vue`, `@vueuse/core` or a `.vue` entry to
Platform.

## How

- `packages/account-core/src/vue/**` → `packages/account-ui/src/auth/**`
with `git mv` (7 modules + their 7 tests; git records every file as a
rename). The framework-free helpers stay in the core and keep their
public subpaths (`/signInSchemas`, `/turnstileScript`,
`/boundedOperation`); the moved files reach them through those.
- `@comfyorg/account-ui` gains per-module `./auth/*` exports (mirroring
how consumers already import these individually and how the app-side
test mocks target one module each) plus the two workspace deps the moved
files need (`@comfyorg/shared-frontend-utils`,
`@comfyorg/tailwind-utils`; both fine in the view package, neither
allowed in the core).
- The core drops the `./vue/*` exports, `vue`, `@vueuse/core`,
`vue-tsc`, `@vitejs/plugin-vue`, `@testing-library/vue|user-event`,
`@comfyorg/tailwind-utils` and the `peerDependenciesMeta` block;
`typecheck` becomes `tsc --noEmit`; the vitest `account-vue` project
becomes `account-firebase` (happy-dom for `src/firebase/**` only).
- `vueBoundary.test.ts` now proves the boundary three ways: no `vue` /
`@vueuse` import anywhere under `src` (the old `vue/` carve-out is
gone), no Vue dependency in any manifest field, and no `.vue` file
behind any export.
- 17 import sites in 13 files repointed (`apps/billing-web`,
`apps/website`, `src/`); root and `apps/website` gain
`@comfyorg/account-ui: workspace:*`.

A pure `git mv` commit was not possible: the pre-commit hook lints and
type-checks the staged tree, and a rename without repoints leaves 17
unresolved imports. Commit 1 is therefore the rename plus the mechanical
repoints; commit 2 is the boundary guard.

## AS-IS / TO-BE

No user-facing change; package boundary only.

- AS-IS: `@comfyorg/account-core` exports `./vue/*` and depends on
`vue`; a Platform install of the core would pull Vue and `.vue` files.
- TO-BE: `@comfyorg/account-core` has no view entry and no Vue
dependency; the sign-in pieces ship from `@comfyorg/account-ui/auth/*`
next to `./billing`.

## Testing

| Gate | Result |
| --- | --- |
| `packages/account-core` vitest | 34 files, 638 tests |
| `packages/account-ui` vitest | 16 files, 79 tests (7 moved suites) |
| `@comfyorg/billing-web` test:unit / build | 10 files, 90 tests / built
|
| `@comfyorg/website` typecheck | 0 errors |
| root `pnpm typecheck`, `lint`, `format`, `knip` | exit 0 |
| `vitest run src/components/dialog/content/signin src/components/auth
src/platform/workspace/billing` | 11 files, 94 tests |
| `git grep "account-core/vue"` | no matches |

## Where this sits in the plan

Billing SDK track FE-2210 ([implementation plan
V2](https://app.notion.com/p/3d86d73d36508152b92cdbdfdfe83ac8)). Hybrid
model: top-up in-app, subscription management / invoices / payment
methods on the hosted billing app.

| Phase | Item | Ticket | Status |
| --- | --- | --- | --- |
| 1-2 | Session core, transport, readers | FE-2211/2212/2213 | merged |
| 3 | Operation lifecycle, commands, eight-state projection |
FE-2227/2214/2223 | merged (Comfy-Org#17655) |
| 4 | `@comfyorg/account-ui` composables + `CheckoutSteps` | FE-2215 |
merged (Comfy-Org#17662, Comfy-Org#17663) |
| 5 slice 1 | Top-up through the SDK behind `billing_sdk_topup_enabled`
| FE-2216 | merged (Comfy-Org#17665) |
| rollout C | `hosted_billing_destination` server flag read by the host
| FE-2218 | merged (Comfy-Org#17716) |
| rollout C | `hostedDestination` port on the lifecycle, value on
operation state | FE-2210/2218 | Comfy-Org#17783 (review) |
| 7 prep | Scope-source port + credentialed transport (BFF / cookie
hosts) | FE-2218 | merged (Comfy-Org#17782) |
| 7 prep | `@comfyorg/account` → `@comfyorg/account-core` rename |
FE-2218 | Comfy-Org#17851 (review; parent of this PR) |
| 4 follow-up | auth Vue pieces leave the core for
`@comfyorg/account-ui` (`./auth/*`) | FE-2215 | **this PR** |
| 7 prep | `billing-contract` route builder + `return_to` registry |
FE-2218 | merged (Comfy-Org#17795) |
| 3A-3 | Workshop adapter over `createHostedTopupCheckout` | FE-2214 |
merged (Comfy-Org#17793) |
| 8 core | `previewSubscribe` command | FE-2331 | merged (Comfy-Org#17797) |
| 8 core | Plans + saved payment-methods readers | FE-2331 | Comfy-Org#17798
(queued) |
| 8 ui | account-ui composables (`usePlans`, `usePaymentMethods`,
`usePreviewSubscribe`) | FE-2331 | Comfy-Org#17798 (queued) |
| 7 | billing-web own-origin session, sign-in, SDK composition | FE-2218
| Comfy-Org#17798 (queued) |
| 7 | billing-web unit tests in CI (`ci-billing-web-unit.yaml`) |
FE-2218 | merged (Comfy-Org#17827); Comfy-Org#17844 (queued) |
| 7 | ingest CORS + top-up return hosts for billing.comfy.org and its
previews (Comfy-Org/cloud) | FE-2218 | merged (Comfy-Org/cloud#9512) |
| 8 ui | billing-web `/v1` entry routing + subscription / payment-method
surfaces | FE-2331 | Comfy-Org#17798 (queued) |
| 7 | npm publish (`ingest-types`, `account-core`, `billing-contract`),
Platform install, billing-web live top-up | FE-2218 | todo |
| 6 | Contract tests per generated schema (package layer) | FE-2217 |
Comfy-Org#17829 (review) |
| 6 | Live E2E per flow × consumer + evidence table | FE-2217 | todo
(needs staging flags) |
| 5 slice 2 | Subscription flows through the SDK | FE-2216 | todo
(plan-change decision) |
| follow-up | One `needsCustomerAttention` predicate (from the Comfy-Org#17665
review) | FE-2216 | merged (Comfy-Org#17792) |
| follow-up | Opaque `BillingServerCode` (from the Comfy-Org#17656 review) |
FE-2227 | merged (Comfy-Org#17794) |
| follow-up | `useCredits` clears on `SUPERSEDED` (from the Comfy-Org#17799
review) | FE-2215 | merged (Comfy-Org#17824) |
| follow-up | credits / status / capabilities readers fence a late
failure as `SUPERSEDED` (from the Comfy-Org#17798 review) | FE-2331 | merged
(Comfy-Org#17828) |

```mermaid
flowchart LR
  P3["Phase 3 core lifecycle (merged)"]
  P4["Phase 4 account-ui (merged)"]
  P5["Phase 5 slice 1 top-up flag (merged)"]
  FC["PR 17716 hosted_billing_destination flag (merged)"]
  HD["PR 17783 hostedDestination port"]
  SS["PR 17782 scope-source port + credentialed transport"]
  RN["PR 17851 account-core rename"]
  VUE["auth Vue pieces to account-ui"]
  RB["billing-contract route builder + return_to"]
  WS["Workshop adapter"]
  P8PV["previewSubscribe command"]
  P8RD["plans + payment-methods readers"]
  P8["account-ui hosted composables"]
  BWS["billing-web session + sign-in"]
  BWV["billing-web /v1 surfaces"]
  CORS["cloud PR 9512 ingest CORS + return hosts"]
  PUB["npm publish account-core / billing-contract"]
  P7["Phase 7 host proof: Platform + billing-web live"]
  P6C["Phase 6 contract tests"]
  P6["Phase 6 live evidence"]
  S2["Phase 5 slice 2 subscription"]
  FU9["customer-attention predicate"]
  FU11["opaque BillingServerCode"]
  FU12["useCredits clears on SUPERSEDED"]
  FU13["reader late-failure fence"]
  P3 --> HD
  FC --> HD
  HD --> RB
  P3 --> SS
  SS --> P7
  RB --> P7
  P3 --> RN
  RN --> PUB
  RN --> VUE
  RB --> PUB
  PUB --> P7
  P3 --> P8PV
  P3 --> P8RD
  P8PV --> P8
  P8RD --> P8
  P4 --> P8
  P8 --> S2
  P8 --> BWS
  BWS --> BWV
  RB --> BWV
  BWV --> P7
  CORS --> P7
  P5 --> P6
  P3 --> P6C
  P5 --> WS
  P5 --> FU9
  P3 --> FU11
  P4 --> FU12
  P3 --> FU13
  style P3 fill:#d4edda,stroke:#155724
  style P4 fill:#d4edda,stroke:#155724
  style P5 fill:#d4edda,stroke:#155724
  style FC fill:#d4edda,stroke:#155724
  style SS fill:#d4edda,stroke:#155724
  style RB fill:#d4edda,stroke:#155724
  style WS fill:#d4edda,stroke:#155724
  style FU9 fill:#d4edda,stroke:#155724
  style FU11 fill:#d4edda,stroke:#155724
  style FU12 fill:#d4edda,stroke:#155724
  style FU13 fill:#d4edda,stroke:#155724
  style CORS fill:#d4edda,stroke:#155724
  style P8PV fill:#d4edda,stroke:#155724
  style VUE stroke:#0366d6,stroke-width:4px
```
dante01yoon added a commit that referenced this pull request Sep 17, 2026
…act when the hosted destination says billing_web (#17860)

Stacked on #17856 (base branch `jaewon/fe-2216-plan-change`) → #17853 →
#17783; merge those first.

## Why

Rollout layer C (`hosted_billing_destination`, `stripe` | `billing_web`,
PostHog at 100% `stripe`) decides where a hosted billing action lands.
The plan says the host reads the flag, hands it to the SDK (#17783) and,
when it says `billing_web`, mints a `/v1/<intent>` entry with
`return_to` from `@comfyorg/billing-contract`, the one definition of
that route surface (#17795); when it says `stripe`, the backend's URL is
opened unchanged. Today the host only opens the bare billing-web origin
from the user popover (#17716) with no intent and no `return_to`, and
"Billing & invoices" in the settings panel always goes to the Stripe
portal. This is the last un-opened code item before the Phase 7 host
proof.

## How

- `src/platform/workspace/billing/hostedBillingRoutes.ts`:
`hostedBillingRoute(destination, intent)` returns `{ kind:
'billing_web', url }` built by `buildBillingEntryUrl({ billingOrigin,
intent, product: 'comfyui', returnTo: 'comfyui_workspace' })`, or `{
kind: 'provider' }` meaning "use the server's URL". The environment is
derived, not hardcoded: the cloud base URL's hostname through the
existing `resolveDeployEnv` map (`prod-v2 | stg-v2 | test-v2` →
`production | staging | test`), which also classifies a local dev
session by the backend it talks to. Fails closed to the provider on: no
configured origin, an unknown backend family, a return target with no
destination in that family, or an entry the contract refuses. A
path-prefixed `VITE_BILLING_WEB_URL` keeps its prefix under the minted
route.
- Consumers: the popover's "Plans and pricing" mints the `pricing`
intent (billing-web routes it to the subscription view; the in-app
dialog stays the `stripe` behaviour and the popup-blocked fallback);
`useWorkspaceBilling.manageSubscription()` mints `payment-methods`
**before** either rail is consulted, so on `billing_web` no portal URL
is requested on the SDK rail or the legacy one, and `openPortalWindow` +
`refreshOnPortalReturn` still run so the return re-reads status, balance
and capabilities.
- Also fixed on the way: the popover treated a falsy `window.open(…,
"noopener,noreferrer")` result as a blocked popup and showed the in-app
pricing dialog as a fallback. Per the HTML spec `noopener` always
returns `null`, so on `billing_web` the tab and the dialog opened
together — a latent defect inherited from #17370 on `main`, caught by
this PR's evidence run. The fallback is gone; the E2E `window.open` stub
now returns `null` for `noopener` like a browser does, and a popover
case covers both destinations.
- Left on the provider on purpose:
`useSubscriptionCheckout.recoverOutstandingPayment` and the
`payment_method_url` steps inside an operation are mid-checkout provider
steps, not hosted management; `invoices` and `result` are not served by
billing-web yet (`ComingSoonView`), so nothing mints them; the legacy
`/customers` rail's `accessBillingPortal` is being retired by the
personal-billing flip and is not touched.
- `@comfyorg/billing-contract` becomes a root `workspace:*` dependency.
The CI cloud build for E2E (`.github/actions/build-cloud-frontend`, used
only by `ci-tests-e2e.yaml` and
`pr-update-playwright-expectations.yaml`, never by a deploy) gets
`VITE_BILLING_WEB_URL=https://billing-web.example`, a reserved origin
the spec stubs, reachable only when the server flag says `billing_web`.
- No frontend-derived server state: the destination is the flag as-is;
the host chooses only the URL shape.

## AS-IS / TO-BE

| AS-IS — `hosted_billing_destination: stripe` | TO-BE —
`hosted_billing_destination: billing_web` |
| --- | --- |
| **1. User popover, "Plans and pricing" hovered**<br><img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17860-screenshots/screenshots/as-is-popover-plans.png"><br>Same
menu item, unchanged by the flag. | **1. User popover, "Plans and
pricing" hovered**<br><img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17860-screenshots/screenshots/to-be-popover-plans.png"><br>Same
menu item, unchanged by the flag. |
| **2. After clicking "Plans and pricing"**<br><img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17860-screenshots/screenshots/as-is-plans-result.png"><br>In-app
"Choose a Plan" dialog, no tab opened. | **2. After clicking "Plans and
pricing"**<br><img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17860-screenshots/screenshots/to-be-plans-result.png"><br>`billing-web.example/v1/pricing?product=comfyui&return_to=comfyui_workspace`
tab opens and nothing else: `window.open` returns `null` under
`noopener` as the spec requires, and no in-app dialog is left behind. |
| **3. Settings ▸ Workspace ▸ Plan & Credits, before clicking "Billing &
invoices"**<br><img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17860-screenshots/screenshots/as-is-settings-billing.png"><br>Identical
panel; the destination is only read on click. | **3. Settings ▸
Workspace ▸ Plan & Credits, before clicking "Billing &
invoices"**<br><img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17860-screenshots/screenshots/to-be-settings-billing.png"><br>Identical
panel; the destination is only read on click. |
| **4. After clicking "Billing & invoices"**<br><img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17860-screenshots/screenshots/as-is-manage-result.png"><br>`POST
/api/billing/payment-portal` recorded, and the URL it returned
(`https://billing.example/portal`) opened. | **4. After clicking
"Billing & invoices"**<br><img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17860-screenshots/screenshots/to-be-manage-result.png"><br>No
request to `/api/billing/payment-portal` on either rail;
`billing-web.example/v1/payment-methods?product=comfyui&return_to=comfyui_workspace`
minted and opened. |
| **5. Return trip — refocusing the app tab after the hosted tab
opened**<br><img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17860-screenshots/screenshots/as-is-return-refresh.png"><br>`/api/billing/status`,
`/balance` and `/capabilities` re-read. | **5. Return trip — refocusing
the app tab after the hosted tab opened**<br><img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17860-screenshots/screenshots/to-be-return-refresh.png"><br>Same
three reads; `openPortalWindow` + `refreshOnPortalReturn` still run on
the minted route. |

- AS-IS (`stripe`, today's default): popover → in-app pricing dialog;
settings → Stripe portal via `POST /billing/payment-portal`.
- TO-BE (`billing_web`): popover →
`<billing-web>/v1/pricing?product=comfyui&return_to=comfyui_workspace`;
settings → `<billing-web>/v1/payment-methods?…`, no portal request on
either rail; the app re-reads billing state on return.

## Testing

| Gate | Result |
| --- | --- |
| `vitest run src/platform/workspace src/composables/billing
src/composables/useFeatureFlags src/config` | 91 files, 1890 tests (19
new route cases: intent × destination × env × prefix × each fail-closed
branch; 3 new adapter cases; 3 popover cases re-pointed) |
| `packages/billing-contract` vitest | 3 files, 62 tests |
| `pnpm typecheck`, `typecheck:browser`, `lint`, `format`, `knip` | exit
0 |
| `fallow audit --changed-since origin/jaewon/fe-2216-plan-change` | no
issues in 10 changed files |
| `PLAYWRIGHT_TEST_URL=http://localhost:5431 pnpm exec playwright test
--project=cloud
browser_tests/tests/dialogs/hostedBillingDestination.spec.ts
--reporter=list`, against
`VITE_BILLING_WEB_URL=https://billing-web.example pnpm dev:cloud` | `4
passed (4.6s)` — settings on both destinations, plus the two new
avatar-menu cases: `opens the in-app pricing table from the avatar menu
while the destination is stripe` and `opens the billing-web pricing
entry alone from the avatar menu while the destination is billing_web` |

## Where this sits in the plan

Billing SDK track FE-2210 ([implementation plan
V2](https://app.notion.com/p/3d86d73d36508152b92cdbdfdfe83ac8)). Hybrid
model: top-up in-app, subscription management / invoices / payment
methods on the hosted billing app.

| Phase | Item | Ticket | Status |
| --- | --- | --- | --- |
| 1-2 | Session core, transport, readers | FE-2211/2212/2213 | merged |
| 3 | Operation lifecycle, commands, eight-state projection |
FE-2227/2214/2223 | merged (#17655) |
| 4 | `@comfyorg/account-ui` composables + `CheckoutSteps` | FE-2215 |
merged (#17662, #17663) |
| 5 slice 1 | Top-up through the SDK behind `billing_sdk_topup_enabled`
| FE-2216 | merged (#17665) |
| rollout C | `hosted_billing_destination` server flag read by the host
| FE-2218 | merged (#17716) |
| rollout C | `hostedDestination` port on the lifecycle, value on
operation state | FE-2210/2218 | #17783 (review) |
| 7 prep | Scope-source port + credentialed transport (BFF / cookie
hosts) | FE-2218 | merged (#17782) |
| 7 prep | `@comfyorg/account` → `@comfyorg/account-core` rename |
FE-2218 | #17851 (review) |
| 7 prep | `billing-contract` route builder + `return_to` registry |
FE-2218 | merged (#17795) |
| 3A-3 | Workshop adapter over `createHostedTopupCheckout` | FE-2214 |
merged (#17793) |
| 8 core | `previewSubscribe` command | FE-2331 | merged (#17797) |
| 8 core | Plans + saved payment-methods readers | FE-2331 | merged
(#17798) |
| 8 ui | account-ui composables (`usePlans`, `usePaymentMethods`,
`usePreviewSubscribe`) | FE-2331 | merged (#17798) |
| 7 | billing-web own-origin session, sign-in, SDK composition | FE-2218
| merged (#17798) |
| 7 | billing-web unit tests in CI (`ci-billing-web-unit.yaml`) |
FE-2218 | merged (#17827, #17844) |
| 7 | ingest CORS + top-up return hosts for billing.comfy.org and its
previews (Comfy-Org/cloud) | FE-2218 | merged (Comfy-Org/cloud#9512) |
| 8 ui | billing-web `/v1` entry routing + subscription / payment-method
surfaces | FE-2331 | merged (#17798) |
| 7 | npm publish (`ingest-types`, `account-core`, `billing-contract`),
Platform install, billing-web live top-up | FE-2218 | todo |
| 6 | Contract tests per generated schema (package layer) | FE-2217 |
#17829 (review) |
| 6 | Live E2E per flow × consumer + evidence table | FE-2217 | todo
(needs staging flags) |
| 5 slice 2a | Cancel, resubscribe and payment portal through the SDK
behind `billing_sdk_subscription_enabled` | FE-2216 | #17853 (review) |
| 5 slice 2b | Subscribe and plan change through the SDK, priced by the
server | FE-2216 | #17856 (review; parent of this PR) |
| 7 / rollout C | Host mints billing-web `/v1/<intent>` entries with
`return_to` when `hosted_billing_destination` is `billing_web` | FE-2218
| **this PR** |
| follow-up | One `needsCustomerAttention` predicate (from the #17665
review) | FE-2216 | merged (#17792) |
| follow-up | Opaque `BillingServerCode` (from the #17656 review) |
FE-2227 | merged (#17794) |
| follow-up | `useCredits` clears on `SUPERSEDED` (from the #17799
review) | FE-2215 | merged (#17824) |
| follow-up | credits / status / capabilities readers fence a late
failure as `SUPERSEDED` (from the #17798 review) | FE-2331 | merged
(#17828) |

```mermaid
flowchart LR
  P3["Phase 3 core lifecycle (merged)"]
  P4["Phase 4 account-ui (merged)"]
  P5["Phase 5 slice 1 top-up flag (merged)"]
  FC["PR 17716 hosted_billing_destination flag (merged)"]
  HD["PR 17783 hostedDestination port"]
  SS["PR 17782 scope-source port + credentialed transport"]
  RN["account-core rename"]
  RB["billing-contract route builder + return_to"]
  WS["Workshop adapter"]
  P8PV["previewSubscribe command"]
  P8RD["plans + payment-methods readers"]
  P8["account-ui hosted composables"]
  BWS["billing-web session + sign-in"]
  BWV["billing-web /v1 surfaces"]
  CORS["cloud PR 9512 ingest CORS + return hosts"]
  PUB["npm publish account-core / billing-contract"]
  P7["Phase 7 host proof: Platform + billing-web live"]
  P6C["Phase 6 contract tests"]
  P6["Phase 6 live evidence"]
  S2A["PR 17853 slice 2a cancel / resubscribe / portal rail"]
  S2B["PR 17856 slice 2b subscribe + plan change"]
  LC["Layer C: host mints billing-web entries"]
  FU9["customer-attention predicate"]
  FU11["opaque BillingServerCode"]
  FU12["useCredits clears on SUPERSEDED"]
  FU13["reader late-failure fence"]
  P3 --> HD
  FC --> HD
  HD --> RB
  P3 --> SS
  SS --> P7
  RB --> P7
  P3 --> RN
  RN --> PUB
  RB --> PUB
  PUB --> P7
  P3 --> P8PV
  P3 --> P8RD
  P8PV --> P8
  P8RD --> P8
  P4 --> P8
  P8 --> S2B
  HD --> S2A
  S2A --> S2B
  S2B --> LC
  RB --> LC
  HD --> LC
  LC --> P7
  P8 --> BWS
  BWS --> BWV
  RB --> BWV
  BWV --> P7
  CORS --> P7
  P5 --> P6
  P3 --> P6C
  P5 --> WS
  P5 --> FU9
  P3 --> FU11
  P4 --> FU12
  P3 --> FU13
  style P3 fill:#d4edda,stroke:#155724
  style P4 fill:#d4edda,stroke:#155724
  style P5 fill:#d4edda,stroke:#155724
  style FC fill:#d4edda,stroke:#155724
  style SS fill:#d4edda,stroke:#155724
  style RB fill:#d4edda,stroke:#155724
  style WS fill:#d4edda,stroke:#155724
  style FU9 fill:#d4edda,stroke:#155724
  style BWV fill:#d4edda,stroke:#155724
  style BWS fill:#d4edda,stroke:#155724
  style P8 fill:#d4edda,stroke:#155724
  style P8RD fill:#d4edda,stroke:#155724
  style CORS fill:#d4edda,stroke:#155724
  style FU13 fill:#d4edda,stroke:#155724
  style FU12 fill:#d4edda,stroke:#155724
  style FU11 fill:#d4edda,stroke:#155724
  style P8PV fill:#d4edda,stroke:#155724
  style LC stroke:#0366d6,stroke-width:4px
```
dante01yoon added a commit that referenced this pull request Sep 17, 2026
…act when the hosted destination says billing_web (#17860)

Stacked on #17856 (base branch `jaewon/fe-2216-plan-change`) → #17853 →

Rollout layer C (`hosted_billing_destination`, `stripe` | `billing_web`,
PostHog at 100% `stripe`) decides where a hosted billing action lands.
The plan says the host reads the flag, hands it to the SDK (#17783) and,
when it says `billing_web`, mints a `/v1/<intent>` entry with
`return_to` from `@comfyorg/billing-contract`, the one definition of
that route surface (#17795); when it says `stripe`, the backend's URL is
opened unchanged. Today the host only opens the bare billing-web origin
from the user popover (#17716) with no intent and no `return_to`, and
"Billing & invoices" in the settings panel always goes to the Stripe
portal. This is the last un-opened code item before the Phase 7 host
proof.

- `src/platform/workspace/billing/hostedBillingRoutes.ts`:
`hostedBillingRoute(destination, intent)` returns `{ kind:
'billing_web', url }` built by `buildBillingEntryUrl({ billingOrigin,
intent, product: 'comfyui', returnTo: 'comfyui_workspace' })`, or `{
kind: 'provider' }` meaning "use the server's URL". The environment is
derived, not hardcoded: the cloud base URL's hostname through the
existing `resolveDeployEnv` map (`prod-v2 | stg-v2 | test-v2` →
`production | staging | test`), which also classifies a local dev
session by the backend it talks to. Fails closed to the provider on: no
configured origin, an unknown backend family, a return target with no
destination in that family, or an entry the contract refuses. A
path-prefixed `VITE_BILLING_WEB_URL` keeps its prefix under the minted
route.
- Consumers: the popover's "Plans and pricing" mints the `pricing`
intent (billing-web routes it to the subscription view; the in-app
dialog stays the `stripe` behaviour and the popup-blocked fallback);
`useWorkspaceBilling.manageSubscription()` mints `payment-methods`
**before** either rail is consulted, so on `billing_web` no portal URL
is requested on the SDK rail or the legacy one, and `openPortalWindow` +
`refreshOnPortalReturn` still run so the return re-reads status, balance
and capabilities.
- Also fixed on the way: the popover treated a falsy `window.open(…,
"noopener,noreferrer")` result as a blocked popup and showed the in-app
pricing dialog as a fallback. Per the HTML spec `noopener` always
returns `null`, so on `billing_web` the tab and the dialog opened
together — a latent defect inherited from #17370 on `main`, caught by
this PR's evidence run. The fallback is gone; the E2E `window.open` stub
now returns `null` for `noopener` like a browser does, and a popover
case covers both destinations.
- Left on the provider on purpose:
`useSubscriptionCheckout.recoverOutstandingPayment` and the
`payment_method_url` steps inside an operation are mid-checkout provider
steps, not hosted management; `invoices` and `result` are not served by
billing-web yet (`ComingSoonView`), so nothing mints them; the legacy
`/customers` rail's `accessBillingPortal` is being retired by the
personal-billing flip and is not touched.
- `@comfyorg/billing-contract` becomes a root `workspace:*` dependency.
The CI cloud build for E2E (`.github/actions/build-cloud-frontend`, used
only by `ci-tests-e2e.yaml` and
`pr-update-playwright-expectations.yaml`, never by a deploy) gets
`VITE_BILLING_WEB_URL=https://billing-web.example`, a reserved origin
the spec stubs, reachable only when the server flag says `billing_web`.
- No frontend-derived server state: the destination is the flag as-is;
the host chooses only the URL shape.

| AS-IS — `hosted_billing_destination: stripe` | TO-BE —
`hosted_billing_destination: billing_web` |
| --- | --- |
| **1. User popover, "Plans and pricing" hovered**<br><img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17860-screenshots/screenshots/as-is-popover-plans.png"><br>Same
menu item, unchanged by the flag. | **1. User popover, "Plans and
pricing" hovered**<br><img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17860-screenshots/screenshots/to-be-popover-plans.png"><br>Same
menu item, unchanged by the flag. |
| **2. After clicking "Plans and pricing"**<br><img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17860-screenshots/screenshots/as-is-plans-result.png"><br>In-app
"Choose a Plan" dialog, no tab opened. | **2. After clicking "Plans and
pricing"**<br><img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17860-screenshots/screenshots/to-be-plans-result.png"><br>`billing-web.example/v1/pricing?product=comfyui&return_to=comfyui_workspace`
tab opens and nothing else: `window.open` returns `null` under
`noopener` as the spec requires, and no in-app dialog is left behind. |
| **3. Settings ▸ Workspace ▸ Plan & Credits, before clicking "Billing &
invoices"**<br><img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17860-screenshots/screenshots/as-is-settings-billing.png"><br>Identical
panel; the destination is only read on click. | **3. Settings ▸
Workspace ▸ Plan & Credits, before clicking "Billing &
invoices"**<br><img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17860-screenshots/screenshots/to-be-settings-billing.png"><br>Identical
panel; the destination is only read on click. |
| **4. After clicking "Billing & invoices"**<br><img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17860-screenshots/screenshots/as-is-manage-result.png"><br>`POST
/api/billing/payment-portal` recorded, and the URL it returned
(`https://billing.example/portal`) opened. | **4. After clicking
"Billing & invoices"**<br><img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17860-screenshots/screenshots/to-be-manage-result.png"><br>No
request to `/api/billing/payment-portal` on either rail;
`billing-web.example/v1/payment-methods?product=comfyui&return_to=comfyui_workspace`
minted and opened. |
| **5. Return trip — refocusing the app tab after the hosted tab
opened**<br><img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17860-screenshots/screenshots/as-is-return-refresh.png"><br>`/api/billing/status`,
`/balance` and `/capabilities` re-read. | **5. Return trip — refocusing
the app tab after the hosted tab opened**<br><img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17860-screenshots/screenshots/to-be-return-refresh.png"><br>Same
three reads; `openPortalWindow` + `refreshOnPortalReturn` still run on
the minted route. |

- AS-IS (`stripe`, today's default): popover → in-app pricing dialog;
settings → Stripe portal via `POST /billing/payment-portal`.
- TO-BE (`billing_web`): popover →
`<billing-web>/v1/pricing?product=comfyui&return_to=comfyui_workspace`;
settings → `<billing-web>/v1/payment-methods?…`, no portal request on
either rail; the app re-reads billing state on return.

| Gate | Result |
| --- | --- |
| `vitest run src/platform/workspace src/composables/billing
src/composables/useFeatureFlags src/config` | 91 files, 1890 tests (19
new route cases: intent × destination × env × prefix × each fail-closed
branch; 3 new adapter cases; 3 popover cases re-pointed) |
| `packages/billing-contract` vitest | 3 files, 62 tests |
| `pnpm typecheck`, `typecheck:browser`, `lint`, `format`, `knip` | exit
0 |
| `fallow audit --changed-since origin/jaewon/fe-2216-plan-change` | no
issues in 10 changed files |
| `PLAYWRIGHT_TEST_URL=http://localhost:5431 pnpm exec playwright test
--project=cloud
browser_tests/tests/dialogs/hostedBillingDestination.spec.ts
--reporter=list`, against
`VITE_BILLING_WEB_URL=https://billing-web.example pnpm dev:cloud` | `4
passed (4.6s)` — settings on both destinations, plus the two new
avatar-menu cases: `opens the in-app pricing table from the avatar menu
while the destination is stripe` and `opens the billing-web pricing
entry alone from the avatar menu while the destination is billing_web` |

Billing SDK track FE-2210 ([implementation plan
V2](https://app.notion.com/p/3d86d73d36508152b92cdbdfdfe83ac8)). Hybrid
model: top-up in-app, subscription management / invoices / payment
methods on the hosted billing app.

| Phase | Item | Ticket | Status |
| --- | --- | --- | --- |
| 1-2 | Session core, transport, readers | FE-2211/2212/2213 | merged |
| 3 | Operation lifecycle, commands, eight-state projection |
FE-2227/2214/2223 | merged (#17655) |
| 4 | `@comfyorg/account-ui` composables + `CheckoutSteps` | FE-2215 |
merged (#17662, #17663) |
| 5 slice 1 | Top-up through the SDK behind `billing_sdk_topup_enabled`
| FE-2216 | merged (#17665) |
| rollout C | `hosted_billing_destination` server flag read by the host
| FE-2218 | merged (#17716) |
| rollout C | `hostedDestination` port on the lifecycle, value on
operation state | FE-2210/2218 | #17783 (review) |
| 7 prep | Scope-source port + credentialed transport (BFF / cookie
hosts) | FE-2218 | merged (#17782) |
| 7 prep | `@comfyorg/account` → `@comfyorg/account-core` rename |
FE-2218 | #17851 (review) |
| 7 prep | `billing-contract` route builder + `return_to` registry |
FE-2218 | merged (#17795) |
| 3A-3 | Workshop adapter over `createHostedTopupCheckout` | FE-2214 |
merged (#17793) |
| 8 core | `previewSubscribe` command | FE-2331 | merged (#17797) |
| 8 core | Plans + saved payment-methods readers | FE-2331 | merged
(#17798) |
| 8 ui | account-ui composables (`usePlans`, `usePaymentMethods`,
`usePreviewSubscribe`) | FE-2331 | merged (#17798) |
| 7 | billing-web own-origin session, sign-in, SDK composition | FE-2218
| merged (#17798) |
| 7 | billing-web unit tests in CI (`ci-billing-web-unit.yaml`) |
FE-2218 | merged (#17827, #17844) |
| 7 | ingest CORS + top-up return hosts for billing.comfy.org and its
previews (Comfy-Org/cloud) | FE-2218 | merged (Comfy-Org/cloud#9512) |
| 8 ui | billing-web `/v1` entry routing + subscription / payment-method
surfaces | FE-2331 | merged (#17798) |
| 7 | npm publish (`ingest-types`, `account-core`, `billing-contract`),
Platform install, billing-web live top-up | FE-2218 | todo |
| 6 | Contract tests per generated schema (package layer) | FE-2217 |
| 6 | Live E2E per flow × consumer + evidence table | FE-2217 | todo
(needs staging flags) |
| 5 slice 2a | Cancel, resubscribe and payment portal through the SDK
behind `billing_sdk_subscription_enabled` | FE-2216 | #17853 (review) |
| 5 slice 2b | Subscribe and plan change through the SDK, priced by the
server | FE-2216 | #17856 (review; parent of this PR) |
| 7 / rollout C | Host mints billing-web `/v1/<intent>` entries with
`return_to` when `hosted_billing_destination` is `billing_web` | FE-2218
| **this PR** |
| follow-up | One `needsCustomerAttention` predicate (from the #17665
review) | FE-2216 | merged (#17792) |
| follow-up | Opaque `BillingServerCode` (from the #17656 review) |
FE-2227 | merged (#17794) |
| follow-up | `useCredits` clears on `SUPERSEDED` (from the #17799
review) | FE-2215 | merged (#17824) |
| follow-up | credits / status / capabilities readers fence a late
failure as `SUPERSEDED` (from the #17798 review) | FE-2331 | merged
(#17828) |

```mermaid
flowchart LR
  P3["Phase 3 core lifecycle (merged)"]
  P4["Phase 4 account-ui (merged)"]
  P5["Phase 5 slice 1 top-up flag (merged)"]
  FC["PR 17716 hosted_billing_destination flag (merged)"]
  HD["PR 17783 hostedDestination port"]
  SS["PR 17782 scope-source port + credentialed transport"]
  RN["account-core rename"]
  RB["billing-contract route builder + return_to"]
  WS["Workshop adapter"]
  P8PV["previewSubscribe command"]
  P8RD["plans + payment-methods readers"]
  P8["account-ui hosted composables"]
  BWS["billing-web session + sign-in"]
  BWV["billing-web /v1 surfaces"]
  CORS["cloud PR 9512 ingest CORS + return hosts"]
  PUB["npm publish account-core / billing-contract"]
  P7["Phase 7 host proof: Platform + billing-web live"]
  P6C["Phase 6 contract tests"]
  P6["Phase 6 live evidence"]
  S2A["PR 17853 slice 2a cancel / resubscribe / portal rail"]
  S2B["PR 17856 slice 2b subscribe + plan change"]
  LC["Layer C: host mints billing-web entries"]
  FU9["customer-attention predicate"]
  FU11["opaque BillingServerCode"]
  FU12["useCredits clears on SUPERSEDED"]
  FU13["reader late-failure fence"]
  P3 --> HD
  FC --> HD
  HD --> RB
  P3 --> SS
  SS --> P7
  RB --> P7
  P3 --> RN
  RN --> PUB
  RB --> PUB
  PUB --> P7
  P3 --> P8PV
  P3 --> P8RD
  P8PV --> P8
  P8RD --> P8
  P4 --> P8
  P8 --> S2B
  HD --> S2A
  S2A --> S2B
  S2B --> LC
  RB --> LC
  HD --> LC
  LC --> P7
  P8 --> BWS
  BWS --> BWV
  RB --> BWV
  BWV --> P7
  CORS --> P7
  P5 --> P6
  P3 --> P6C
  P5 --> WS
  P5 --> FU9
  P3 --> FU11
  P4 --> FU12
  P3 --> FU13
  style P3 fill:#d4edda,stroke:#155724
  style P4 fill:#d4edda,stroke:#155724
  style P5 fill:#d4edda,stroke:#155724
  style FC fill:#d4edda,stroke:#155724
  style SS fill:#d4edda,stroke:#155724
  style RB fill:#d4edda,stroke:#155724
  style WS fill:#d4edda,stroke:#155724
  style FU9 fill:#d4edda,stroke:#155724
  style BWV fill:#d4edda,stroke:#155724
  style BWS fill:#d4edda,stroke:#155724
  style P8 fill:#d4edda,stroke:#155724
  style P8RD fill:#d4edda,stroke:#155724
  style CORS fill:#d4edda,stroke:#155724
  style FU13 fill:#d4edda,stroke:#155724
  style FU12 fill:#d4edda,stroke:#155724
  style FU11 fill:#d4edda,stroke:#155724
  style P8PV fill:#d4edda,stroke:#155724
  style LC stroke:#0366d6,stroke-width:4px
```
pull Bot pushed a commit to Mu-L/ComfyUI_frontend that referenced this pull request Sep 17, 2026
…contract and ingest-types (Comfy-Org#17882)

## Why

`@comfyorg/account-core`, `@comfyorg/billing-contract` and
`@comfyorg/ingest-types` are about to be installed by Platform from the
public registry, and today none of them can be packed: `exports` point
at `src/*.ts`, there is no `files` allowlist, no build, and the core
still reaches into a private workspace utility. The release workflows on
Comfy-Org#17881 assume `build` and `smoke:pack` exist; this PR is the part that
makes a tarball installable in plain Node.

Built on Comfy-Org#17854 (auth Vue surface → `account-ui`, now merged) so the
core builds from a Vue-free tree, and it reproduces Maanil's Comfy-Org#17838 /
Comfy-Org#17839 / Comfy-Org#17840 on the renamed tree as agreed in the review thread
there. Base is `main`.

## How

- **Private-utility cut** — the one remaining reach out of the core was
`turnstileScript.ts` →
`@comfyorg/shared-frontend-utils/loadExternalScript`. The loader is now
package-owned (`packages/account-core/src/loadExternalScript.ts`,
byte-identical) and `@comfyorg/shared-frontend-utils` leaves the core's
dependencies. `publishBoundary.test.ts` fails on any future `workspace:`
dependency that is not itself published (`@comfyorg/ingest-types` is the
only allowed one).
- **Manifests** — `files: ["dist"]`, `sideEffects: false`,
`repository`/`homepage`/`author`, MIT `LICENSE` per package,
`publishConfig.exports` mapping every dev `exports` entry to `dist/*.js`
+ `.d.ts`, `./package.json` export, `access: public`.
`@comfyorg/ingest-types` moves `zod` to a peer so a consumer never gets
two zod copies. `private: true` stays on all three (`ingest-types` had
no `private` at all; it now has the latch). Flipping `private` is a
one-line change per manifest in a later reviewed PR.
- **Build** — `tsconfig.build.json` per package (`declaration`,
`noEmitOnError`, `types: []`, tests and fixtures excluded), `build` =
`clean` + `tsc -p`, `prepack` runs it. Relative imports carry `.js` so
the emitted ESM resolves under `nodenext`; `openapi-ts.config.ts` sets
`importFileExtension: '.js'` so regeneration keeps it.
- **Smoke pack** — `scripts/smokePack.ts` (run as `pnpm --filter
@comfyorg/account-core smoke:pack`) packs all three, checks each tarball
(no source/test/fixture files, every export target present, no
unrewritten `catalog:`/`workspace:`), installs them into a throwaway npm
project, imports all 21 entries from plain Node ESM, and type-checks a
`nodenext` consumer. Dropping one `.js` extension makes the typed step
fail with `TS2835`, which the plain-Node step alone would not catch.
- **CI** — `ci-packages-pack.yaml` on `pull_request` for the three
package paths: matrix job per package (typecheck → build → `check:pack`)
plus one `smoke-consumer` job. The tarball rules live in one pure
module, `publishableTarball.ts`, with its own test file; the CLI and the
smoke test are two entry points onto it, so CI and the smoke test cannot
drift.

Deliberate divergences from Comfy-Org#17839: no `region` export and no deletion
in `shared-frontend-utils/networkUtil.ts` (the region gate moved to
`account-ui` with the Vue surface and three app suites still import it);
`createScriptLoader` stays in the shared package for its three
`src/platform` callers.

Open point: the root `LICENSE` is GPL-3.0 while all three manifests
already declare MIT (as `@comfyorg/design-system` publishes). Without a
per-package file pnpm would inject the GPL text into a tarball whose
manifest says MIT, so the MIT files fix the actual defect; whether the
SDK packages should be MIT at all is a call for the reviewer to confirm.

## AS-IS / TO-BE

No UI change; packages, scripts and CI only.

- AS-IS: `pnpm pack` on any of the three ships `src/*.ts` (or nothing)
with `exports` a consumer cannot resolve, and the core depends on a
private workspace package.
- TO-BE: `smoke:pack` proves the three tarballs install and import from
plain Node with types, and CI runs that proof on every change to the
packages.

## Testing

| Check | Result |
| --- | --- |
| `build` account-core / billing-contract / ingest-types | 92 / 18 / 6
dist files |
| `smoke:pack` | 3 packed, 21 entries imported under Node ESM,
`nodenext` tsc clean |
| vitest account-core / account-ui / billing-contract / billing-web |
675 / 79 / 62 / 90 pass |
| `pnpm typecheck`, `pnpm lint`, `pnpm format:check`, `pnpm knip` (with
`dist` on disk) | exit 0 |
| `yamllint` on the new workflow | clean |

## Where this sits in the plan

Billing SDK track FE-2210 ([implementation plan
V2](https://app.notion.com/p/3d86d73d36508152b92cdbdfdfe83ac8)). Hybrid
model: top-up in-app, subscription management / invoices / payment
methods on the hosted billing app.

| Phase | Item | Ticket | Status |
| --- | --- | --- | --- |
| 1-2 | Session core, transport, readers | FE-2211/2212/2213 | merged |
| 3 | Operation lifecycle, commands, eight-state projection |
FE-2227/2214/2223 | merged (Comfy-Org#17655) |
| 4 | `@comfyorg/account-ui` composables + `CheckoutSteps` | FE-2215 |
merged (Comfy-Org#17662, Comfy-Org#17663) |
| 5 slice 1 | Top-up through the SDK behind `billing_sdk_topup_enabled`
| FE-2216 | merged (Comfy-Org#17665) |
| rollout C | `hosted_billing_destination` server flag read by the host
| FE-2218 | merged (Comfy-Org#17716) |
| rollout C | `hostedDestination` port on the lifecycle, value on
operation state | FE-2210/2218 | Comfy-Org#17783 (review, carries slice 2a) |
| 7 prep | Scope-source port + credentialed transport (BFF / cookie
hosts) | FE-2218 | merged (Comfy-Org#17782) |
| 7 prep | `@comfyorg/account` → `@comfyorg/account-core` rename |
FE-2218 | merged (Comfy-Org#17851) |
| 7 prep | Auth Vue surface → `account-ui`; core Vue-free by
construction | FE-2215 | merged (Comfy-Org#17854) |
| 7 prep | `billing-contract` route builder + `return_to` registry |
FE-2218 | merged (Comfy-Org#17795) |
| 3A-3 | Workshop adapter over `createHostedTopupCheckout` | FE-2214 |
merged (Comfy-Org#17793) |
| 8 core | `previewSubscribe` command | FE-2331 | merged (Comfy-Org#17797) |
| 8 core | Plans + saved payment-methods readers | FE-2331 | merged
(Comfy-Org#17798) |
| 8 ui | account-ui composables (`usePlans`, `usePaymentMethods`,
`usePreviewSubscribe`) | FE-2331 | merged (Comfy-Org#17798) |
| 7 | billing-web own-origin session, sign-in, SDK composition | FE-2218
| merged (Comfy-Org#17798) |
| 7 | billing-web unit tests in CI (`ci-billing-web-unit.yaml`) |
FE-2218 | merged (Comfy-Org#17827, Comfy-Org#17844) |
| 7 | ingest CORS + top-up return hosts for billing.comfy.org and its
previews (Comfy-Org/cloud) | FE-2218 | merged (Comfy-Org/cloud#9512) |
| 8 ui | billing-web `/v1` entry routing + subscription / payment-method
surfaces | FE-2331 | merged (Comfy-Org#17798) |
| 7 | Package release workflows + versioning ADR (bump PR → publish on
merge, snapshots) | FE-2218 | Comfy-Org#17881 (review) |
| 7 | Publish readiness: dist build, files allowlist, pack smoke test,
private-utility cut | FE-2218 | **this PR** |
| 7 | First publish (`private` off), Platform install, billing-web live
top-up | FE-2218 | todo |
| 6 | Contract tests per generated schema (package layer) | FE-2217 |
Comfy-Org#17829 (review) |
| 6 | Live E2E per flow × consumer + evidence table | FE-2217 | todo
(needs staging flags) |
| 5 slice 2 | Subscription flows through the SDK | FE-2216 | Comfy-Org#17856 /
Comfy-Org#17860 (review) |
| follow-up | One `needsCustomerAttention` predicate (from the Comfy-Org#17665
review) | FE-2216 | merged (Comfy-Org#17792) |
| follow-up | Opaque `BillingServerCode` (from the Comfy-Org#17656 review) |
FE-2227 | merged (Comfy-Org#17794) |
| follow-up | `useCredits` clears on `SUPERSEDED` (from the Comfy-Org#17799
review) | FE-2215 | merged (Comfy-Org#17824) |
| follow-up | credits / status / capabilities readers fence a late
failure as `SUPERSEDED` (from the Comfy-Org#17798 review) | FE-2331 | merged
(Comfy-Org#17828) |

```mermaid
flowchart LR
  P3["Phase 3 core lifecycle (merged)"]
  P4["Phase 4 account-ui (merged)"]
  P5["Phase 5 slice 1 top-up flag (merged)"]
  FC["PR 17716 hosted_billing_destination flag (merged)"]
  HD["PR 17783 hostedDestination port"]
  SS["PR 17782 scope-source port + credentialed transport"]
  RN["account-core rename (merged)"]
  AV["auth Vue surface to account-ui (merged)"]
  RB["billing-contract route builder + return_to"]
  WS["Workshop adapter"]
  P8PV["previewSubscribe command"]
  P8RD["plans + payment-methods readers"]
  P8["account-ui hosted composables"]
  BWS["billing-web session + sign-in"]
  BWV["billing-web /v1 surfaces"]
  CORS["cloud PR 9512 ingest CORS + return hosts"]
  RW["PR 17881 release workflows + ADR"]
  PR["publish readiness: dist, files, smoke pack"]
  PUB["first publish account-core / billing-contract / ingest-types"]
  P7["Phase 7 host proof: Platform + billing-web live"]
  P6C["Phase 6 contract tests"]
  P6["Phase 6 live evidence"]
  S2["Phase 5 slice 2 subscription"]
  FU9["customer-attention predicate"]
  FU11["opaque BillingServerCode"]
  FU12["useCredits clears on SUPERSEDED"]
  FU13["reader late-failure fence"]
  P3 --> HD
  FC --> HD
  HD --> RB
  P3 --> SS
  SS --> P7
  RB --> P7
  P3 --> RN
  RN --> AV
  AV --> PR
  RW --> PUB
  PR --> PUB
  RB --> PUB
  PUB --> P7
  P3 --> P8PV
  P3 --> P8RD
  P8PV --> P8
  P8RD --> P8
  P4 --> P8
  P8 --> S2
  P8 --> BWS
  BWS --> BWV
  RB --> BWV
  BWV --> P7
  CORS --> P7
  P5 --> P6
  P3 --> P6C
  P5 --> WS
  P5 --> FU9
  P3 --> FU11
  P4 --> FU12
  P3 --> FU13
  style P3 fill:#d4edda,stroke:#155724
  style P4 fill:#d4edda,stroke:#155724
  style P5 fill:#d4edda,stroke:#155724
  style FC fill:#d4edda,stroke:#155724
  style SS fill:#d4edda,stroke:#155724
  style RB fill:#d4edda,stroke:#155724
  style WS fill:#d4edda,stroke:#155724
  style FU9 fill:#d4edda,stroke:#155724
  style BWV fill:#d4edda,stroke:#155724
  style BWS fill:#d4edda,stroke:#155724
  style P8 fill:#d4edda,stroke:#155724
  style P8RD fill:#d4edda,stroke:#155724
  style CORS fill:#d4edda,stroke:#155724
  style FU13 fill:#d4edda,stroke:#155724
  style FU12 fill:#d4edda,stroke:#155724
  style FU11 fill:#d4edda,stroke:#155724
  style P8PV fill:#d4edda,stroke:#155724
  style RN fill:#d4edda,stroke:#155724
  style AV fill:#d4edda,stroke:#155724
  style PR stroke:#0366d6,stroke-width:4px
```
pull Bot pushed a commit to Mu-L/ComfyUI_frontend that referenced this pull request Sep 17, 2026
…codes (Comfy-Org#17829)

Linear FE-2217.

## Why

The billing SDK core decodes generated zod schemas from
`@comfyorg/ingest-types/zod`, which a bot regenerates from the cloud
OpenAPI whenever the backend moves. Today a regen that renames a field,
drops it, or widens an enum the reducer switches on surfaces either as a
typecheck error somewhere deep in the core or, worse, as a runtime
`MALFORMED_RESPONSE` in front of a customer mid-payment. Nothing states,
in one readable place, which fields of which schema the SDK actually
depends on.

This adds a contract test per generated schema the core decodes. Each
pins the fields the core reads and the enum members it branches on, at
the type level and at parse time, so a regen that changes one of them
fails a named block whose name says what broke — the parse rows under
`vitest run`, the `expectTypeOf` exhaustiveness pins under the package
typecheck. A failure here means the backend contract moved: fix the SDK,
not the test.

These are pins, not behaviour: reader and command behaviour stays
covered by the existing `credits.test.ts`, `status.test.ts`,
`capabilities.test.ts`, `operationState.test.ts`,
`subscriptionCommands.test.ts`, and `topup.test.ts`.

## How

New folder `packages/account-core/src/core/billing/contracts/`, one file
per endpoint contract, picked up by the package's existing
`src/core/**/*.{test,spec}.ts` include. Each file holds a canonical
fixture typed as `z.input<typeof schema>` built by a small typed builder
(no casts), parses it with `safeParse`, pins the output type with
`expectTypeOf`, and runs one `it.for` row per enum value the SDK
branches on.

| Schema | Module that decodes it | Fields pinned |
| --- | --- | --- |
| `zBillingBalanceResponse` | `credits.ts` (read by `topup.ts`,
`balanceWatch.ts`) | `amount_micros` as a number; the four optional
breakdown micros |
| `zBillingStatusResponse` | `status.ts` (read by
`operationLifecycle.ts`, `subscriptionCommands.ts`, `presentation.ts`) |
`billing_rail` (3), `pending_billing_op_id`, `pending_billing_op_type`
(2), `action_url`, `payment_intent_client_secret`, `is_active`,
`subscription_tier` (7), `subscription_status` (3) |
| `zBillingCapabilitiesResponse`, `zBillingCapabilities`,
`zBillingCapabilityScope`, `zBillingCapabilityRolloutDefaults` |
`capabilities.ts` (which parses the three named pieces, not the response
schema) | the five response keys the reader recomposes into its own
schema, reading `expires_at` as a plain string and `revision` as a
number; all seven capability booleans; `resolved_for.user_id` /
`workspace_id`; `expires_at`; `revision` as an int64 bounded to the
JavaScript-safe range the reader reads it back as a number over;
`denied_reasons` absent from the contract, which is why
`capabilityDenials.ts` decodes it off the raw body |
| `zBillingOpStatusResponse` | `operationLifecycle.ts`,
`operationState.ts` | `id`; `status` (the 4 the reducer handles);
`authentication_state` (the 5 it reads or assigns); `decline_reason` (8,
incl. the `generic` fallback); `recovery_action` (4); `phase` (3);
`action_url`; `payment_intent_client_secret`; `retryable` optional |
| `zErrorResponse` | `billingErrorBody.ts` | `code` as an open string
the commands match against their own closed set; a body without
`message` yields no code |
| `zSubscribeRequest`, `zSubscribeResponse` | `subscriptionCommands.ts`
| `confirmation_token`, `saved_payment_method_id` (`pm_` prefix),
`idempotency_key`, `confirm_reactivation`; `billing_op_id`, `status`
(3), optional `payment_method_url` |
| `zResubscribeResponse` | `subscriptionCommands.ts` | `billing_op_id`
regardless of `status` (2) |
| `zCancelSubscriptionResponse2` | `subscriptionCommands.ts` |
`billing_op_id` on both members of the response union |
| `zPaymentPortalResponse` | `subscriptionCommands.ts` | `url` required,
and not https-checked by the schema, which is why the command re-checks
it |
| `zPreviewSubscribeRequest`, `zPreviewSubscribeResponse` |
`subscriptionCommands.ts` | `plan_slug` required and the three optional
request fields; `allowed`, `is_immediate`, `effective_at`,
`transition_type` (4), the int64 money fields and their JSON-number
coercion, `discounts`, `requires_reactivation_confirmation` |
| `zCreateTopupRequest`, `zCreateTopupResponse` | `topup.ts` |
`amount_cents` minimum and its int64 coercion of the JSON number the
command validates but does not send; `idempotency_key`; `billing_op_id`
regardless of `status` (3) |
| `zCreateTopupCheckoutRequest`, `zCreateTopupCheckoutResponse` |
`topup.ts` | the amount bounds and the `return_url` URL rule, pinned by
the issue **path** the command reads to tell the two apart;
`checkout_url` required, `session_id` optional |

`capabilityDenials.ts` is the one billing module that decodes without a
generated schema — deliberately, since a strict enum parse would lose
the whole capability set the first time the server names an unfamiliar
policy branch. Its absence from the generated contract is pinned in
`billingCapabilities.contract.test.ts`.

## AS-IS / TO-BE

No UI. A regenerated `zBillingOpStatusResponse` that adds a fifth
`status`:

- AS-IS: the new value falls through `terminalFromStatus` into the
pending branch; the operation polls until its budget runs out and
reports `timed_out`.
- TO-BE: `billingOpStatus.contract.test.ts` fails on the regen PR,
naming the reducer as what needs updating. Two gates, and which one
fires depends on the pin: the enum rows (`accepts the %s status`) fail
under `vitest run`, while the exhaustiveness pin at
`billingOpStatus.contract.test.ts:36` sits at module scope and fails as
a TS2344 under the package typecheck, not in the test run.

## Testing

- `cd packages/account-core && vitest run src/core/billing/contracts` —
12 files, 90 tests, all passing. The type pins are not among them: they
sit at module scope and fail `pnpm --filter @comfyorg/account-core
typecheck` instead, because nothing here runs `vitest --typecheck`.
- `cd packages/account-core && tsc --noEmit` — clean
- `pnpm typecheck` — passing; verified the type pins bite by injecting a
spurious enum member and watching `expectTypeOf` fail with TS2344
- `pnpm lint`, `pnpm format`, `pnpm knip` — passing
- `fallow audit --changed-since origin/main` — no issues in the 13
changed files
## Where this sits in the plan

Billing SDK track FE-2210 ([implementation plan
V2](https://app.notion.com/p/3d86d73d36508152b92cdbdfdfe83ac8)). Hybrid
model: top-up in-app, subscription management / invoices / payment
methods on the hosted billing app.

| Phase | Item | Ticket | Status |
| --- | --- | --- | --- |
| 1-2 | Session core, transport, readers | FE-2211/2212/2213 | merged |
| 3 | Operation lifecycle, commands, eight-state projection |
FE-2227/2214/2223 | merged (Comfy-Org#17655) |
| 4 | `@comfyorg/account-ui` composables + `CheckoutSteps` | FE-2215 |
merged (Comfy-Org#17662, Comfy-Org#17663) |
| 5 slice 1 | Top-up through the SDK behind `billing_sdk_topup_enabled`
| FE-2216 | merged (Comfy-Org#17665) |
| rollout C | `hosted_billing_destination` server flag read by the host
| FE-2218 | merged (Comfy-Org#17716) |
| rollout C | `hostedDestination` port on the lifecycle, value on
operation state | FE-2210/2218 | open (Comfy-Org#17783, carries slice 2a) |
| 7 prep | Scope-source port + credentialed transport (BFF / cookie
hosts) | FE-2218 | merged (Comfy-Org#17782) |
| 7 prep | `@comfyorg/account` → `@comfyorg/account-core` rename |
FE-2218 | merged (Comfy-Org#17851) — this PR sits on it |
| 7 prep | `billing-contract` route builder + `return_to` registry |
FE-2218 | merged (Comfy-Org#17795) |
| 3A-3 | Workshop adapter over `createHostedTopupCheckout` | FE-2214 |
merged (Comfy-Org#17793) |
| 8 core | `previewSubscribe` command | FE-2331 | merged (Comfy-Org#17797) |
| 8 core | Plans + saved payment-methods readers | FE-2331 | merged
(Comfy-Org#17798) |
| 8 ui | account-ui composables (`usePlans`, `usePaymentMethods`,
`usePreviewSubscribe`) | FE-2331 | merged (Comfy-Org#17798) |
| 7 | billing-web own-origin session, sign-in, SDK composition | FE-2218
| merged (Comfy-Org#17798) |
| 7 | billing-web unit tests in CI (`ci-billing-web-unit.yaml`) |
FE-2218 | merged (Comfy-Org#17827, Comfy-Org#17844) |
| 7 | ingest CORS + top-up return hosts for billing.comfy.org and its
previews (Comfy-Org/cloud) | FE-2218 | merged (Comfy-Org/cloud#9512) |
| 8 ui | billing-web `/v1` entry routing + subscription / payment-method
surfaces | FE-2331 | merged (Comfy-Org#17798) |
| 7 | Publish readiness: dist build, files allowlist, pack smoke test |
FE-2218 | merged (Comfy-Org#17882) |
| 7 | Package release workflows + versioning ADR | FE-2218 | open
(Comfy-Org#17881) |
| 7 | First publish (`private` off), Platform install, billing-web live
top-up | FE-2218 | todo |
| 6 | Contract tests per generated schema (package layer) | FE-2217 |
**this PR** |
| 6 | Live E2E per flow × consumer + evidence table | FE-2217 | todo
(needs staging flags) |
| 5 slice 2 | Subscription flows through the SDK | FE-2216 | open
(Comfy-Org#17856, Comfy-Org#17860) |
| follow-up | One `needsCustomerAttention` predicate (from the Comfy-Org#17665
review) | FE-2216 | merged (Comfy-Org#17792) |
| follow-up | Opaque `BillingServerCode` (from the Comfy-Org#17656 review) |
FE-2227 | merged (Comfy-Org#17794) |
| follow-up | `useCredits` clears on `SUPERSEDED` (from the Comfy-Org#17799
review) | FE-2215 | merged (Comfy-Org#17824) |
| follow-up | credits / status / capabilities readers fence a late
failure as `SUPERSEDED` (from the Comfy-Org#17798 review) | FE-2331 | open
(Comfy-Org#17828) |

```mermaid
flowchart LR
  P3["Phase 3 core lifecycle (merged)"]
  P4["Phase 4 account-ui (merged)"]
  P5["Phase 5 slice 1 top-up flag (merged)"]
  FC["PR 17716 hosted_billing_destination flag (merged)"]
  HD["PR 17783 hostedDestination port"]
  SS["PR 17782 scope-source port + credentialed transport"]
  RN["account-core rename"]
  RB["billing-contract route builder + return_to"]
  WS["Workshop adapter"]
  P8PV["previewSubscribe command"]
  P8RD["plans + payment-methods readers"]
  P8["account-ui hosted composables"]
  BWS["billing-web session + sign-in"]
  BWV["billing-web /v1 surfaces"]
  CORS["cloud PR 9512 ingest CORS + return hosts"]
  PUB["npm publish account-core / billing-contract"]
  P7["Phase 7 host proof: Platform + billing-web live"]
  P6C["Phase 6 contract tests"]
  P6["Phase 6 live evidence"]
  S2["Phase 5 slice 2 subscription"]
  FU9["customer-attention predicate"]
  FU11["opaque BillingServerCode"]
  FU12["useCredits clears on SUPERSEDED"]
  FU13["reader late-failure fence"]
  P3 --> HD
  FC --> HD
  HD --> RB
  P3 --> SS
  SS --> P7
  RB --> P7
  P3 --> RN
  RN --> PUB
  RB --> PUB
  PUB --> P7
  P3 --> P8PV
  P3 --> P8RD
  P8PV --> P8
  P8RD --> P8
  P4 --> P8
  P8 --> S2
  P8 --> BWS
  BWS --> BWV
  RB --> BWV
  BWV --> P7
  CORS --> P7
  P5 --> P6
  P3 --> P6C
  P5 --> WS
  P5 --> FU9
  P3 --> FU11
  P4 --> FU12
  P3 --> FU13
  style P3 fill:#d4edda,stroke:#155724
  style P4 fill:#d4edda,stroke:#155724
  style P5 fill:#d4edda,stroke:#155724
  style FC fill:#d4edda,stroke:#155724
  style SS fill:#d4edda,stroke:#155724
  style RB fill:#d4edda,stroke:#155724
  style WS fill:#d4edda,stroke:#155724
  style FU9 fill:#d4edda,stroke:#155724
  style P8PV fill:#d4edda,stroke:#155724
  style P6C stroke:#0366d6,stroke-width:4px
```
pull Bot pushed a commit to Penguinjanator/ComfyUI_frontend that referenced this pull request Sep 17, 2026
…ced by the server (Comfy-Org#17856)

Stacked on Comfy-Org#17853 (base branch `jaewon/fe-2216-subscription-rail`),
which stacks on Comfy-Org#17783; merge those first.

## Why

Slice 2a (Comfy-Org#17853) put cancel, resubscribe and the payment portal on the
SDK rail. Subscribe — new subscriptions and plan changes — was left on
the legacy call because the SDK's `subscribe` refused an active
subscription on the client (`active → ALREADY_HELD`) and routed a
scheduled cancel to `resubscribe()`, which carries no plan. Both
contradict what the host already does: `useWorkspaceBilling.subscribe`
posts `/billing/subscribe` whatever the subscription state,
`useSubscriptionCheckout` quotes the change first with
`previewSubscribe`, and the server prices the change, reactivates or
refuses (`REACTIVATION_CONFIRMATION_REQUIRED` exists for exactly that).
Decision (2026-09-16): mirror the host; no product change.

## How

- **Core.** `subscribe()` issues `POST /billing/subscribe` for every
subscription state and never short-circuits; the client-side eligibility
switch, `eligibilityOf` and its type are gone (nothing else read them).
`resubscribe()` stays the explicit "resume" command.
`docs/billing-command-eligibility.md` (the path the module doc already
referenced) now records the route per command and that the status read
decides nothing for subscribe.
- **Core, quote decoding.** The generated zod for the preview coerces
every int64 to `bigint` while the generated TS type for the same fields
is `number`, so the SDK's quote was not assignable to the host's
`PreviewSubscribeResponse`. The cents fields are decoded as `z.number()`
via `.extend` on the generated schemas (the precedent `capabilities.ts`
sets for `revision`; money on this route is bounded to cents well inside
the safe range). The two types are now structurally identical and `pnpm
typecheck` proves the assignment with no hand-written projection.
- **Host.** On the rail (read once per action, as in 2a)
`useWorkspaceBilling.subscribe` maps `SubscribeOptions → SubscribeInput`
field for field (`confirmationToken` / `savedPaymentMethodId` empty →
dropped, as the workspace client does; nothing dropped otherwise) and
runs `sdk.commands.subscribe`; `previewSubscribe` runs
`sdk.commands.previewSubscribe`. Both share 2a's route latch (404 →
legacy once), and every other failure is thrown as a `WorkspaceApiError`
whose `.code` carries the server code verbatim, so
`useSubscriptionCheckout` and `useDowngradeToPersonal` keep branching on
`REACTIVATION_CONFIRMATION_REQUIRED`, `SUBSCRIPTION_PAYMENT_REQUIRED`,
`OUTSTANDING_PAYMENT_REQUIRED`, `TRANSITION_NOT_ALLOWED`,
`PRORATION_QUOTE_EXPIRED`, `SUBSCRIPTION_QUOTE_STALE` unchanged.
- **Customer steps.** The SDK settles the operation inside
`subscribe()`, so nothing else watches it: the store's lifecycle
subscriber now handles non-topup pending states — the existing in-page
challenge driver, and a once-per-operation `window.open(actionUrl)` with
the same popup-blocked toast the checkout shows. Without both, a 3DS
plan change or a `needs_payment_method` answer would time out with
nothing on screen.
- **Settled response.** A settled subscribe projects to the `{
billing_op_id, status: 'subscribed' }` body `handleSubscribeResponse`
already handles; `needs_payment_method` / `pending_payment` never reach
the host because the lifecycle drove them first.
- Not on the rail: `teamSubscriptionCheckoutUtil.ts` calls
`workspaceApi.subscribe` directly and stays legacy on both rails;
`savePendingSubscriptionCheckout` and checkout-journey `billing_op_id`
linking run after settlement rather than at issue, because the SDK does
not surface the issued operation (recovery across reloads is the
lifecycle's `recover()`).

## AS-IS / TO-BE

Same journey on both: `?pricing=creator&cycle=yearly` against an active
`standard-annual` subscription on the `stripe` rail, 1280×800, every
endpoint mocked.

| State | AS-IS — `billing_sdk_subscription_enabled: false` | TO-BE —
`billing_sdk_subscription_enabled: true` |
| --- | --- | --- |
| "Confirm your upgrade" with the quote | <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17856-screenshots/screenshots/as-is-confirm-upgrade.png">
| <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17856-screenshots/screenshots/to-be-confirm-upgrade.png">
|
| "You're all set" after confirming | <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17856-screenshots/screenshots/as-is-all-set.png">
| <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17856-screenshots/screenshots/to-be-all-set.png">
|
| Recorded `subscribe` request (quote above it carries no key on either
rail) | no `Idempotency-Key` <br> <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17856-screenshots/screenshots/as-is-subscribe-headers.png">
| `Idempotency-Key` present and echoed as `idempotency_key` <br> <img
width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17856-screenshots/screenshots/to-be-subscribe-headers.png">
|
| `POST /billing/subscribe` answers 404 | one POST, the click fails
("Request failed with status code 404") <br> <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17856-screenshots/screenshots/as-is-404-fallback.png">
| two POSTs from one click — first with the key → 404, second without →
200, "You're all set" <br> <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17856-screenshots/screenshots/to-be-404-fallback.png">
|
| Server answers `REACTIVATION_CONFIRMATION_REQUIRED` | re-quotes, shows
the reactivation panel and the coded toast <br> <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17856-screenshots/screenshots/as-is-reactivation-required.png">
| identical panel, toast and CTA on the rail <br> <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17856-screenshots/screenshots/to-be-reactivation-required.png">
|

- AS-IS (flag off): quote and subscribe go through the workspace API; a
3DS or payment-method step is driven by the checkout composable off the
raw response.
- TO-BE (flag on): the same screens and copy; quote and subscribe go
through the SDK transport (`Idempotency-Key` on the subscribe POST),
settlement through the operation lifecycle; a 404 falls back to the
legacy call.

## Testing

| Gate | Result |
| --- | --- |
| `packages/account` vitest | 39 files, 634 tests (new: active plan
change issues the request; canceled carries `plan_slug` +
`confirm_reactivation`; `REACTIVATION_CONFIRMATION_REQUIRED` surfaces
coded) |
| host vitest (billing sdk, composables/billing, workspace composables +
stores, feature flags) | 41 files, 1151 tests |
| `pnpm typecheck`, `typecheck:browser`, `lint`, `format`, `knip` | exit
0 |
| `fallow audit --changed-since origin/jaewon/fe-2216-subscription-rail`
| no issues in 10 changed files, complexity 0, duplication 0 |
| Playwright cloud: `planChangeSdkRail.spec.ts` (3) +
`cancelSubscriptionSdkRail.spec.ts` (3) | `6 passed (11.5s)` —
`PLAYWRIGHT_TEST_URL=http://localhost:5173 pnpm exec playwright test
--project=cloud browser_tests/tests/dialogs/planChangeSdkRail.spec.ts
browser_tests/tests/dialogs/cancelSubscriptionSdkRail.spec.ts
--reporter=list` against a `pnpm dev:cloud` vite server, all endpoints
mocked |

## Where this sits in the plan

Billing SDK track FE-2210 ([implementation plan
V2](https://app.notion.com/p/3d86d73d36508152b92cdbdfdfe83ac8)). Hybrid
model: top-up in-app, subscription management / invoices / payment
methods on the hosted billing app.

| Phase | Item | Ticket | Status |
| --- | --- | --- | --- |
| 1-2 | Session core, transport, readers | FE-2211/2212/2213 | merged |
| 3 | Operation lifecycle, commands, eight-state projection |
FE-2227/2214/2223 | merged (Comfy-Org#17655) |
| 4 | `@comfyorg/account-ui` composables + `CheckoutSteps` | FE-2215 |
merged (Comfy-Org#17662, Comfy-Org#17663) |
| 5 slice 1 | Top-up through the SDK behind `billing_sdk_topup_enabled`
| FE-2216 | merged (Comfy-Org#17665) |
| rollout C | `hosted_billing_destination` server flag read by the host
| FE-2218 | merged (Comfy-Org#17716) |
| rollout C | `hostedDestination` port on the lifecycle, value on
operation state | FE-2210/2218 | Comfy-Org#17783 (review) |
| 7 prep | Scope-source port + credentialed transport (BFF / cookie
hosts) | FE-2218 | merged (Comfy-Org#17782) |
| 7 prep | `@comfyorg/account` → `@comfyorg/account-core` rename |
FE-2218 | Comfy-Org#17851 (review) |
| 7 prep | `billing-contract` route builder + `return_to` registry |
FE-2218 | merged (Comfy-Org#17795) |
| 3A-3 | Workshop adapter over `createHostedTopupCheckout` | FE-2214 |
merged (Comfy-Org#17793) |
| 8 core | `previewSubscribe` command | FE-2331 | merged (Comfy-Org#17797) |
| 8 core | Plans + saved payment-methods readers | FE-2331 | merged
(Comfy-Org#17798) |
| 8 ui | account-ui composables (`usePlans`, `usePaymentMethods`,
`usePreviewSubscribe`) | FE-2331 | merged (Comfy-Org#17798) |
| 7 | billing-web own-origin session, sign-in, SDK composition | FE-2218
| merged (Comfy-Org#17798) |
| 7 | billing-web unit tests in CI (`ci-billing-web-unit.yaml`) |
FE-2218 | merged (Comfy-Org#17827, Comfy-Org#17844) |
| 7 | ingest CORS + top-up return hosts for billing.comfy.org and its
previews (Comfy-Org/cloud) | FE-2218 | merged (Comfy-Org/cloud#9512) |
| 8 ui | billing-web `/v1` entry routing + subscription / payment-method
surfaces | FE-2331 | merged (Comfy-Org#17798) |
| 7 | npm publish (`ingest-types`, `account-core`, `billing-contract`),
Platform install, billing-web live top-up | FE-2218 | todo |
| 6 | Contract tests per generated schema (package layer) | FE-2217 |
Comfy-Org#17829 (review) |
| 6 | Live E2E per flow × consumer + evidence table | FE-2217 | todo
(needs staging flags) |
| 5 slice 2a | Cancel, resubscribe and payment portal through the SDK
behind `billing_sdk_subscription_enabled` | FE-2216 | Comfy-Org#17853 (review;
parent of this PR) |
| 5 slice 2b | Subscribe and plan change through the SDK: quote, then
subscribe; the SDK never short-circuits on the client | FE-2216 | **this
PR** |
| follow-up | One `needsCustomerAttention` predicate (from the Comfy-Org#17665
review) | FE-2216 | merged (Comfy-Org#17792) |
| follow-up | Opaque `BillingServerCode` (from the Comfy-Org#17656 review) |
FE-2227 | merged (Comfy-Org#17794) |
| follow-up | `useCredits` clears on `SUPERSEDED` (from the Comfy-Org#17799
review) | FE-2215 | merged (Comfy-Org#17824) |
| follow-up | credits / status / capabilities readers fence a late
failure as `SUPERSEDED` (from the Comfy-Org#17798 review) | FE-2331 | merged
(Comfy-Org#17828) |

```mermaid
flowchart LR
  P3["Phase 3 core lifecycle (merged)"]
  P4["Phase 4 account-ui (merged)"]
  P5["Phase 5 slice 1 top-up flag (merged)"]
  FC["PR 17716 hosted_billing_destination flag (merged)"]
  HD["PR 17783 hostedDestination port"]
  SS["PR 17782 scope-source port + credentialed transport"]
  RN["account-core rename"]
  RB["billing-contract route builder + return_to"]
  WS["Workshop adapter"]
  P8PV["previewSubscribe command"]
  P8RD["plans + payment-methods readers"]
  P8["account-ui hosted composables"]
  BWS["billing-web session + sign-in"]
  BWV["billing-web /v1 surfaces"]
  CORS["cloud PR 9512 ingest CORS + return hosts"]
  PUB["npm publish account-core / billing-contract"]
  P7["Phase 7 host proof: Platform + billing-web live"]
  P6C["Phase 6 contract tests"]
  P6["Phase 6 live evidence"]
  S2A["PR 17853 slice 2a cancel / resubscribe / portal rail"]
  S2B["Phase 5 slice 2b subscribe + plan change"]
  FU9["customer-attention predicate"]
  FU11["opaque BillingServerCode"]
  FU12["useCredits clears on SUPERSEDED"]
  FU13["reader late-failure fence"]
  P3 --> HD
  FC --> HD
  HD --> RB
  P3 --> SS
  SS --> P7
  RB --> P7
  P3 --> RN
  RN --> PUB
  RB --> PUB
  PUB --> P7
  P3 --> P8PV
  P3 --> P8RD
  P8PV --> P8
  P8RD --> P8
  P4 --> P8
  P8 --> S2B
  HD --> S2A
  S2A --> S2B
  P8 --> BWS
  BWS --> BWV
  RB --> BWV
  BWV --> P7
  CORS --> P7
  P5 --> P6
  P3 --> P6C
  P5 --> WS
  P5 --> FU9
  P3 --> FU11
  P4 --> FU12
  P3 --> FU13
  style P3 fill:#d4edda,stroke:#155724
  style P4 fill:#d4edda,stroke:#155724
  style P5 fill:#d4edda,stroke:#155724
  style FC fill:#d4edda,stroke:#155724
  style SS fill:#d4edda,stroke:#155724
  style RB fill:#d4edda,stroke:#155724
  style WS fill:#d4edda,stroke:#155724
  style FU9 fill:#d4edda,stroke:#155724
  style BWV fill:#d4edda,stroke:#155724
  style BWS fill:#d4edda,stroke:#155724
  style P8 fill:#d4edda,stroke:#155724
  style P8RD fill:#d4edda,stroke:#155724
  style CORS fill:#d4edda,stroke:#155724
  style FU13 fill:#d4edda,stroke:#155724
  style FU12 fill:#d4edda,stroke:#155724
  style FU11 fill:#d4edda,stroke:#155724
  style P8PV fill:#d4edda,stroke:#155724
  style S2B stroke:#0366d6,stroke-width:4px
```
pull Bot pushed a commit to Penguinjanator/ComfyUI_frontend that referenced this pull request Sep 17, 2026
…Rs, with the versioning ADR (Comfy-Org#17881)

## Why

`@comfyorg/account-core`, `@comfyorg/billing-contract` and
`@comfyorg/ingest-types` are about to be installed by Platform from the
public registry, and the plan had nothing on how their versions are cut.
The monorepo already releases one package (`@comfyorg/design-system`)
through a version-bump PR that publishes on merge; the decision
(2026-09-16) is to follow that pattern for the SDK packages, generalized
over a package input rather than copied, and to defer Changesets with
the revisit conditions written down.

## How

- `version-bump-package.yaml` — `workflow_dispatch` with `package`
(account-core / billing-contract / ingest-types), `version_type`,
`pre_release`; bumps on `main` and opens a `Release`-labelled PR titled
`<package> <version>` (same pinned `create-pull-request` action as the
design-system workflow).
- `publish-package.yaml` — reusable (`workflow_dispatch` +
`workflow_call`): name/version match, an explicit failure while
`"private": true`, `build` and `smoke:pack` via `--if-present` (works
before and after the publish-readiness PR lands), `npm view` skip on an
existing version, `pnpm publish --access public --tag … --provenance`
under `id-token: write`.
- `publish-package-on-merge.yaml` — on a merged `Release` PR touching
one of the three manifests, publishes every package whose `version`
changed against the first parent (matrix), posts the release-links
comment per package and the Slack notice.
- `.github/actions/comment-release-links` — three additive cases so each
package's summary has its own section.
- `packages/{account-core,billing-contract,ingest-types}/package.json` —
`"private": true` removed. Comfy-Org#17882 is merged and its smoke test proves
the three tarballs install from plain Node, so the latch comes off here,
in the same reviewed PR as the machinery that checks it. Nothing
publishes on this merge: the on-merge job needs a `Release` label and a
version change, and neither is present.
-
`docs/adr/RELEASES-PACKAGES-0033-sdk-packages-release-through-version-bump-prs.md`
(+ index): context, the decision and each workflow's rationale, the
versioning policy (`1.0.0-alpha.N` on `next` until the Phase 7 host
proof, then `1.0.0`; generated-contract additions minor, removals major,
decided on the regeneration PR), alternatives (Changesets,
release-please, semantic-release, per-package copies) and the explicit
"when to revisit Changesets" list.

Written against the post-rename names (`packages/account-core`); the
on-merge path filter matches once Comfy-Org#17851 lands. Design-system workflows
are untouched.

Not in this PR, on purpose: the `ingest-types` regeneration bump — the
generator lives in Comfy-Org/cloud; the one-step change needed there is
recorded in the ADR's follow-ups.

**Snapshot publishing is not in this PR.** A `pull_request` run executes
the workflow definition from the pull request's own merge ref, so a
publish step triggered that way is PR-authored code holding `NPM_TOKEN`,
and on `main` today no `pull_request` workflow reaches that secret. It
returns in its own PR, publishing from a `workflow_run` job that runs
the default branch's definition over an artifact the pull-request job
produces.

## AS-IS / TO-BE

No UI change; CI and docs only.

- AS-IS: only `@comfyorg/design-system` has a release path; the SDK
packages have no bump, no publish, no policy.
- TO-BE: one dispatch bumps any of the three, the merged `Release` PR
publishes with provenance, and the ADR records why Changesets waits and
what the snapshot follow-up has to satisfy.

## Testing

| Check | Result |
| --- | --- |
| `actionlint` on the four workflows | 0 findings |
| `zizmor --min-severity medium` | clean apart from the repo-exempt
`actions/checkout@v7` / `setup-node@v6` pins (`.pinact.yaml`);
workflow-level `permissions: contents: read` added after its finding |
| `yamllint` (as `ci-yaml-validation.yaml` runs it) | clean |
| `pnpm adr:check`, `pnpm lint`, `pnpm format:check`, `pnpm knip` | exit
0 |

After the second review round (860ef8a, 8f7972f, 41793c7):
`publish-package.yaml` rejects a prerelease on `latest` and reports
whether it published or skipped, and `version-bump-package.yaml` holds
`account-core` and `billing-contract` on the `1.0.0-alpha.N` line, since
`patch`, `minor` and `major` all turn `1.0.0-alpha.0` into `1.0.0`. The
hardening that round added to the snapshot workflow left with it in
25b09c3.

After the first review round (23b854e, 5985af7): the manual
publish no longer takes a caller-supplied `ref` (it publishes the ref it
was dispatched on), and the ADR scopes the prerelease-first gate to the
hand-written packages, putting `ingest-types` outside it.

The Slack notice posts to `#proj-billing` (`C0BNGQG2LCW`), not the
design-system channel. Open points for review: `--provenance` is new
relative to the design-system publish and is confirmed on the first real
run; Follow-ups, not in this PR: a protected `environment` with required
reviewers and an environment-scoped `NPM_TOKEN` on the publish job (repo
configuration), and the same `ref` removal on
`publish-design-system.yaml`.

## Where this sits in the plan

Billing SDK track FE-2210 ([implementation plan
V2](https://app.notion.com/p/3d86d73d36508152b92cdbdfdfe83ac8)). Hybrid
model: top-up in-app, subscription management / invoices / payment
methods on the hosted billing app.

| Phase | Item | Ticket | Status |
| --- | --- | --- | --- |
| 1-2 | Session core, transport, readers | FE-2211/2212/2213 | merged |
| 3 | Operation lifecycle, commands, eight-state projection |
FE-2227/2214/2223 | merged (Comfy-Org#17655) |
| 4 | `@comfyorg/account-ui` composables + `CheckoutSteps` | FE-2215 |
merged (Comfy-Org#17662, Comfy-Org#17663) |
| 5 slice 1 | Top-up through the SDK behind `billing_sdk_topup_enabled`
| FE-2216 | merged (Comfy-Org#17665) |
| rollout C | `hosted_billing_destination` server flag read by the host
| FE-2218 | merged (Comfy-Org#17716) |
| rollout C | `hostedDestination` port on the lifecycle, value on
operation state | FE-2210/2218 | Comfy-Org#17783 (review, carries slice 2a) |
| 7 prep | Scope-source port + credentialed transport (BFF / cookie
hosts) | FE-2218 | merged (Comfy-Org#17782) |
| 7 prep | `@comfyorg/account` → `@comfyorg/account-core` rename |
FE-2218 | Comfy-Org#17851 (queued) |
| 7 prep | `billing-contract` route builder + `return_to` registry |
FE-2218 | merged (Comfy-Org#17795) |
| 3A-3 | Workshop adapter over `createHostedTopupCheckout` | FE-2214 |
merged (Comfy-Org#17793) |
| 8 core | `previewSubscribe` command | FE-2331 | merged (Comfy-Org#17797) |
| 8 core | Plans + saved payment-methods readers | FE-2331 | merged
(Comfy-Org#17798) |
| 8 ui | account-ui composables (`usePlans`, `usePaymentMethods`,
`usePreviewSubscribe`) | FE-2331 | merged (Comfy-Org#17798) |
| 7 | billing-web own-origin session, sign-in, SDK composition | FE-2218
| merged (Comfy-Org#17798) |
| 7 | billing-web unit tests in CI (`ci-billing-web-unit.yaml`) |
FE-2218 | merged (Comfy-Org#17827, Comfy-Org#17844) |
| 7 | ingest CORS + top-up return hosts for billing.comfy.org and its
previews (Comfy-Org/cloud) | FE-2218 | merged (Comfy-Org/cloud#9512) |
| 8 ui | billing-web `/v1` entry routing + subscription / payment-method
surfaces | FE-2331 | merged (Comfy-Org#17798) |
| 7 | Package release workflows + versioning ADR (bump dispatch →
publish on merge) | FE-2218 | **this PR** |
| 7 | Pre-merge snapshots from a default-branch `workflow_run` job |
FE-2218 | todo (split out of this PR) |
| 7 | Publish readiness: dist build, files allowlist, pack smoke test,
private-utility cut | FE-2218 | merged (Comfy-Org#17882) |
| 7 | `private` off on the three manifests | FE-2218 | **this PR** |
| 7 | First publish (bump PRs: ingest-types, then billing-contract,
account-core), Platform install, billing-web live top-up | FE-2218 |
todo |
| 6 | Contract tests per generated schema (package layer) | FE-2217 |
Comfy-Org#17829 (review) |
| 6 | Live E2E per flow × consumer + evidence table | FE-2217 | todo
(needs staging flags) |
| 5 slice 2 | Subscription flows through the SDK | FE-2216 | Comfy-Org#17856 /
Comfy-Org#17860 (review) |
| follow-up | One `needsCustomerAttention` predicate (from the Comfy-Org#17665
review) | FE-2216 | merged (Comfy-Org#17792) |
| follow-up | Opaque `BillingServerCode` (from the Comfy-Org#17656 review) |
FE-2227 | merged (Comfy-Org#17794) |
| follow-up | `useCredits` clears on `SUPERSEDED` (from the Comfy-Org#17799
review) | FE-2215 | merged (Comfy-Org#17824) |
| follow-up | credits / status / capabilities readers fence a late
failure as `SUPERSEDED` (from the Comfy-Org#17798 review) | FE-2331 | merged
(Comfy-Org#17828) |

```mermaid
flowchart LR
  P3["Phase 3 core lifecycle (merged)"]
  P4["Phase 4 account-ui (merged)"]
  P5["Phase 5 slice 1 top-up flag (merged)"]
  FC["PR 17716 hosted_billing_destination flag (merged)"]
  HD["PR 17783 hostedDestination port"]
  SS["PR 17782 scope-source port + credentialed transport"]
  RN["account-core rename"]
  RB["billing-contract route builder + return_to"]
  WS["Workshop adapter"]
  P8PV["previewSubscribe command"]
  P8RD["plans + payment-methods readers"]
  P8["account-ui hosted composables"]
  BWS["billing-web session + sign-in"]
  BWV["billing-web /v1 surfaces"]
  CORS["cloud PR 9512 ingest CORS + return hosts"]
  RW["release workflows + ADR"]
  PUB["npm publish account-core / billing-contract"]
  P7["Phase 7 host proof: Platform + billing-web live"]
  P6C["Phase 6 contract tests"]
  P6["Phase 6 live evidence"]
  S2["Phase 5 slice 2 subscription"]
  FU9["customer-attention predicate"]
  FU11["opaque BillingServerCode"]
  FU12["useCredits clears on SUPERSEDED"]
  FU13["reader late-failure fence"]
  P3 --> HD
  FC --> HD
  HD --> RB
  P3 --> SS
  SS --> P7
  RB --> P7
  P3 --> RN
  RN --> PUB
  RW --> PUB
  RB --> PUB
  PUB --> P7
  P3 --> P8PV
  P3 --> P8RD
  P8PV --> P8
  P8RD --> P8
  P4 --> P8
  P8 --> S2
  P8 --> BWS
  BWS --> BWV
  RB --> BWV
  BWV --> P7
  CORS --> P7
  P5 --> P6
  P3 --> P6C
  P5 --> WS
  P5 --> FU9
  P3 --> FU11
  P4 --> FU12
  P3 --> FU13
  style P3 fill:#d4edda,stroke:#155724
  style P4 fill:#d4edda,stroke:#155724
  style P5 fill:#d4edda,stroke:#155724
  style FC fill:#d4edda,stroke:#155724
  style SS fill:#d4edda,stroke:#155724
  style RB fill:#d4edda,stroke:#155724
  style WS fill:#d4edda,stroke:#155724
  style FU9 fill:#d4edda,stroke:#155724
  style BWV fill:#d4edda,stroke:#155724
  style BWS fill:#d4edda,stroke:#155724
  style P8 fill:#d4edda,stroke:#155724
  style P8RD fill:#d4edda,stroke:#155724
  style CORS fill:#d4edda,stroke:#155724
  style FU13 fill:#d4edda,stroke:#155724
  style FU12 fill:#d4edda,stroke:#155724
  style FU11 fill:#d4edda,stroke:#155724
  style P8PV fill:#d4edda,stroke:#155724
  style RW stroke:#0366d6,stroke-width:4px
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:xhigh PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants