Repository navigation
[backport cloud/1.54] fix(billing): only one subscribe CTA at a time (#16721) - #17710
Conversation
Backport of #16721. Conflict resolution: main rewrote both test files' mocks after this branch was cut (typed `vi.mock(import(...))` specifiers, `vi.mock('pinia')` dropped for the global testing pinia, `useDialogStore` asserted directly). The cherry-pick carried those rewrites in. Kept this branch's existing mock style and layered the PR's additions on top: the reactive `useBillingContext` mock, the `useSubscribeCtaPresence` mock, the presence-registering `SubscribeToRun` stub, and the "one subscribe CTA at a time" cases.
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 1922 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-15T03:18:36.657Z",
"gitSha": "bcbfdd7d1354f957fc05cfd08b796768bef89e82",
"branch": "backport-16721-to-cloud-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2029.8230000000217,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.655999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 492.895,
"heapDeltaBytes": -3005968,
"heapUsedBytes": 67076188,
"domNodes": -278,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 8.480000000000002,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2039.2180000000053,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.220000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 494.10600000000005,
"heapDeltaBytes": -6226600,
"heapUsedBytes": 62998732,
"domNodes": -277,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 8.408999999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1963.0579999999895,
"styleRecalcs": 80,
"styleRecalcDurationMs": 41.535000000000004,
"layouts": 14,
"layoutDurationMs": 4.828,
"taskDurationMs": 974.3629999999999,
"heapDeltaBytes": -8310928,
"heapUsedBytes": 61763268,
"domNodes": -279,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 157.67700000000002,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1899.028000000044,
"styleRecalcs": 76,
"styleRecalcDurationMs": 35.145999999999994,
"layouts": 14,
"layoutDurationMs": 4.529,
"taskDurationMs": 859.359,
"heapDeltaBytes": 2699196,
"heapUsedBytes": 73730552,
"domNodes": -279,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 142.796,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1723.3429999999998,
"styleRecalcs": 32,
"styleRecalcDurationMs": 15.891000000000002,
"layouts": 6,
"layoutDurationMs": 1.1849999999999998,
"taskDurationMs": 347.923,
"heapDeltaBytes": 4962848,
"heapUsedBytes": 76004976,
"domNodes": 78,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 10.980999999999998,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1681.5389999999297,
"styleRecalcs": 31,
"styleRecalcDurationMs": 15.574,
"layouts": 6,
"layoutDurationMs": 1.1469999999999998,
"taskDurationMs": 348.90099999999995,
"heapDeltaBytes": 4957932,
"heapUsedBytes": 74809800,
"domNodes": 77,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 10.57,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 628.7110000000098,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.970000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 444.261,
"heapDeltaBytes": -8113796,
"heapUsedBytes": 62652436,
"domNodes": 18,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 154.24400000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 638.7939999999617,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.621,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 431.23400000000004,
"heapDeltaBytes": 18432544,
"heapUsedBytes": 88646780,
"domNodes": 18,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 151.59300000000002,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2052.1740000000364,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.565,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 612.5639999999999,
"heapDeltaBytes": 10575420,
"heapUsedBytes": 86918296,
"domNodes": -265,
"jsHeapTotalBytes": -2199552,
"scriptDurationMs": 33.522,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2032.4279999999817,
"styleRecalcs": 6,
"styleRecalcDurationMs": 6.393,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 609.9680000000001,
"heapDeltaBytes": 10753600,
"heapUsedBytes": 86985740,
"domNodes": -265,
"jsHeapTotalBytes": -2461696,
"scriptDurationMs": 32.096999999999994,
"eventListeners": -172,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2210.599000000002,
"styleRecalcs": 66,
"styleRecalcDurationMs": 11.292,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1575.913,
"heapDeltaBytes": 8175468,
"heapUsedBytes": 85194500,
"domNodes": -270,
"jsHeapTotalBytes": -401408,
"scriptDurationMs": 753.664,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2160.978,
"styleRecalcs": 64,
"styleRecalcDurationMs": 9.403000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1528.074,
"heapDeltaBytes": 21630136,
"heapUsedBytes": 87284476,
"domNodes": -277,
"jsHeapTotalBytes": 487424,
"scriptDurationMs": 738.499,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3524.2830000000254,
"styleRecalcs": 61,
"styleRecalcDurationMs": 10.897,
"layouts": 60,
"layoutDurationMs": 12.668,
"taskDurationMs": 1676.5550000000003,
"heapDeltaBytes": 8595964,
"heapUsedBytes": 76394084,
"domNodes": 2,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 773.1940000000001,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3523.469999999975,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.149000000000001,
"layouts": 60,
"layoutDurationMs": 12.633000000000003,
"taskDurationMs": 1656.3190000000002,
"heapDeltaBytes": 8796764,
"heapUsedBytes": 76231424,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 769.16,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3128.563999999983,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.003999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1865.5870000000002,
"heapDeltaBytes": 22164744,
"heapUsedBytes": 89959604,
"domNodes": 0,
"jsHeapTotalBytes": 1728512,
"scriptDurationMs": 938.3190000000001,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666636,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2978.185999999994,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.033000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1853.2900000000002,
"heapDeltaBytes": 17604136,
"heapUsedBytes": 85348292,
"domNodes": 0,
"jsHeapTotalBytes": 1466368,
"scriptDurationMs": 929.592,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2011.622999999986,
"styleRecalcs": 2,
"styleRecalcDurationMs": 1.7309999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 559.7139999999999,
"heapDeltaBytes": 22317496,
"heapUsedBytes": 88057548,
"domNodes": -274,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 31.866000000000007,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2033.796999999936,
"styleRecalcs": 3,
"styleRecalcDurationMs": 2.5040000000000027,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 585.4930000000002,
"heapDeltaBytes": 10899032,
"heapUsedBytes": 88083140,
"domNodes": -275,
"jsHeapTotalBytes": -1937408,
"scriptDurationMs": 37.438,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 578.0919999999696,
"styleRecalcs": 45,
"styleRecalcDurationMs": 8.578000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 395.24899999999997,
"heapDeltaBytes": 14771432,
"heapUsedBytes": 86318848,
"domNodes": 16,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 141.70499999999998,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 596.2899999999536,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.622,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 390.535,
"heapDeltaBytes": 15066052,
"heapUsedBytes": 87902768,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 140.342,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2007.3309999999651,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.391,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 488.015,
"heapDeltaBytes": 4490276,
"heapUsedBytes": 77241156,
"domNodes": -295,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 7.316,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2016.9480000000135,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.19,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 481.87200000000007,
"heapDeltaBytes": -2071724,
"heapUsedBytes": 70154360,
"domNodes": -292,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 7.628999999999999,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1723.7949999999955,
"styleRecalcs": 77,
"styleRecalcDurationMs": 32.807,
"layouts": 18,
"layoutDurationMs": 4.670000000000001,
"taskDurationMs": 770.832,
"heapDeltaBytes": -926436,
"heapUsedBytes": 71351560,
"domNodes": -295,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 96.36500000000001,
"eventListeners": -222,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1734.8210000000108,
"styleRecalcs": 77,
"styleRecalcDurationMs": 32.279999999999994,
"layouts": 18,
"layoutDurationMs": 4.764,
"taskDurationMs": 769.238,
"heapDeltaBytes": -12075396,
"heapUsedBytes": 60906572,
"domNodes": -295,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 95.44800000000001,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1368.139000000042,
"styleRecalcs": 19,
"styleRecalcDurationMs": 29.685999999999996,
"layouts": 15,
"layoutDurationMs": 13.992,
"taskDurationMs": 894.3709999999998,
"heapDeltaBytes": 21940776,
"heapUsedBytes": 106059368,
"domNodes": 13751,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 28.647000000000006,
"eventListeners": 2387,
"totalBlockingTimeMs": 121,
"frameDurationMs": 16.666666666666636,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8315.373000000021,
"styleRecalcs": 248,
"styleRecalcDurationMs": 35.782000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5623.811,
"heapDeltaBytes": 8963524,
"heapUsedBytes": 85418024,
"domNodes": -267,
"jsHeapTotalBytes": -925696,
"scriptDurationMs": 2570.397,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8319.430000000011,
"styleRecalcs": 246,
"styleRecalcDurationMs": 36.767,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5674.646,
"heapDeltaBytes": 15218780,
"heapUsedBytes": 91354240,
"domNodes": -270,
"jsHeapTotalBytes": -401408,
"scriptDurationMs": 2621.158,
"eventListeners": -158,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17856.822000000022,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16849.176,
"heapDeltaBytes": -34400440,
"heapUsedBytes": 179782548,
"domNodes": -6548,
"jsHeapTotalBytes": -1507328,
"scriptDurationMs": 284.717,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17792.754999999943,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16852.137999999995,
"heapDeltaBytes": -34420684,
"heapUsedBytes": 179548960,
"domNodes": -6548,
"jsHeapTotalBytes": -6844416,
"scriptDurationMs": 302.059,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21158.245999999963,
"styleRecalcs": 169,
"styleRecalcDurationMs": 18.37300000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20810.147999999997,
"heapDeltaBytes": -20729164,
"heapUsedBytes": 182540256,
"domNodes": -6548,
"jsHeapTotalBytes": 4444160,
"scriptDurationMs": 908.9090000000001,
"eventListeners": -7469,
"totalBlockingTimeMs": 147,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 21290.640999999938,
"styleRecalcs": 166,
"styleRecalcDurationMs": 18.65300000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20943.934,
"heapDeltaBytes": -42291368,
"heapUsedBytes": 167092508,
"domNodes": -6548,
"jsHeapTotalBytes": -3104768,
"scriptDurationMs": 911.6769999999999,
"eventListeners": -7471,
"totalBlockingTimeMs": 165,
"frameDurationMs": 17.773333333333238,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 6273.723000000018,
"styleRecalcs": 20,
"styleRecalcDurationMs": 91.19,
"layouts": 20,
"layoutDurationMs": 24.272000000000002,
"taskDurationMs": 6172.636999999999,
"heapDeltaBytes": -38669204,
"heapUsedBytes": 175578016,
"domNodes": -6548,
"jsHeapTotalBytes": 1282048,
"scriptDurationMs": 135.336,
"eventListeners": -7473,
"totalBlockingTimeMs": 397,
"frameDurationMs": 17.779999999999987,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 6204.720000000066,
"styleRecalcs": 20,
"styleRecalcDurationMs": 74.68400000000003,
"layouts": 20,
"layoutDurationMs": 23.66800000000001,
"taskDurationMs": 6113.107999999999,
"heapDeltaBytes": -16527376,
"heapUsedBytes": 188523024,
"domNodes": -6548,
"jsHeapTotalBytes": 16207872,
"scriptDurationMs": 108.84200000000001,
"eventListeners": -7473,
"totalBlockingTimeMs": 511,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8978.398000000027,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8479.300000000001,
"heapDeltaBytes": 15909048,
"heapUsedBytes": 175844832,
"domNodes": 0,
"jsHeapTotalBytes": -1310720,
"scriptDurationMs": 142.768,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8973.604000000023,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8495.704,
"heapDeltaBytes": 4956500,
"heapUsedBytes": 175903972,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 142.902,
"eventListeners": -14,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 91.94000000002234,
"styleRecalcs": 7,
"styleRecalcDurationMs": 11.902999999999999,
"layouts": 2,
"layoutDurationMs": 0.601,
"taskDurationMs": 65.03800000000001,
"heapDeltaBytes": 3139488,
"heapUsedBytes": 71061232,
"domNodes": 108,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.097999999999999,
"eventListeners": 35,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 96.9759999999269,
"styleRecalcs": 6,
"styleRecalcDurationMs": 13.150000000000002,
"layouts": 2,
"layoutDurationMs": 1.4040000000000004,
"taskDurationMs": 64.48199999999999,
"heapDeltaBytes": 2999148,
"heapUsedBytes": 71231240,
"domNodes": 124,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 4.246999999999999,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.54 #17710 +/- ##
=============================================
Coverage ? 82.99%
=============================================
Files ? 2053
Lines ? 119727
Branches ? 32794
=============================================
Hits ? 99362
Misses ? 20185
Partials ? 180
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
Holding this backport for 1.55 from main: there is no log of testing beyond unit tests, and the release lines need that evidence. |
christian-byrne
left a comment
There was a problem hiding this comment.
Approving as part of a batch pass over the eight backports that had been sitting unreviewed.
For the "only one subscribe CTA" family (#17707, #17708, #17709, #17710), I compared the payloads across release lines rather than reading each one separately — the useful question for a backport set is whether the four branches are getting the same change, not whether the diff reads well four times.
They are. Diffing the core/1.54 payload against core/1.53 file by file gives zero files with differing line counts: identical file set, identical additions, identical deletions. Same for the cloud siblings, which carry the same +178/−15 across 7 files. So all four release lines receive the same fix and there is no per-branch drift to reason about.
CI green and mergeable on all four.
Backport of #16721 to
cloud/1.54. The automation could not open this PR — the cherry-pick conflicted (pr-backport.yamlrun 34923077263).Why
A free-tier workspace that cannot run showed two subscribe CTAs at once: "Upgrade" in the top corner and "Subscribe to Run" in the Run slot. The coexistence was deliberate when built, but it reads as a glitch.
Root cause
TopbarSubscribeButtongated only onisCloud && isFreeTier, whileshowsSubscribeToRunPromptisisInitialized && !canRunWorkflows. A free-tier workspace out of quota satisfies both, so both CTAs render.How
TopbarSubscribeButtonnow yields while a Run-slot prompt is actually mounted.SubscribeToRunregisters its presence throughuseSubscribeCtaPresence, so modes without the Run slot — builder, Linear without outputs, sales-managed, payment recovery — keep the Upgrade button and never drop to zero CTAs. The presence counter is read rather than the billing flag, because the flag over-reports:CloudRunButtonWrapperrendersComfyQueueButtoninstead of the prompt for sales-managed and payment-recovery states even while the flag is true.Also folds in the user-popover half:
showSubscribeActionnow requirescanTopUp, so the popover no longer renders "Upgrade to add credits" and "Subscribe" side by side.AS IS / TO BE
Behavioral evidence for the original change is on #16721; this backport is a cherry-pick of that reviewed commit with no production-code changes of its own.
Conflict resolution
Only the two test files conflicted; every production file applied cleanly.
mainrewrote both test files' mocks after this branch was cut — typedvi.mock(import(...))specifiers,vi.mock('pinia')dropped in favour of the global testing pinia, anduseDialogStoreasserted directly instead of through a hoisted stub. The cherry-pick dragged those rewrites onto a branch that does not have them.Resolution keeps this branch's existing mock style and layers only the PR's additions on top: the reactive
useBillingContextmock, theuseSubscribeCtaPresencemock, the presence-registeringSubscribeToRunstub, and the "one subscribe CTA at a time" cases. TheBillingStatustype import anduseDialogStoreassertions were left out — they belong to main-only changes, not to this PR.Verification
CloudRunButtonWrapper.test.ts,TopbarSubscribeButton.test.ts, andCurrentUserPopoverWorkspace.test.tson this branch: 59 tests, all passing.oxlintandoxfmt --checkclean on both resolved files.