Skip to content

[backport cloud/1.54] fix(billing): only one subscribe CTA at a time (#16721) - #17710

Merged
dante01yoon merged 1 commit into
cloud/1.54from
backport-16721-to-cloud-1.54
Sep 17, 2026
Merged

dante01yoon merged 1 commit into
cloud/1.54from
backport-16721-to-cloud-1.54

Conversation

@dante01yoon

Copy link
Copy Markdown
Collaborator

Backport of #16721 to cloud/1.54. The automation could not open this PR — the cherry-pick conflicted (pr-backport.yaml run 34923077263).

Why

A free-tier workspace that cannot run showed two subscribe CTAs at once: "Upgrade" in the top corner and "Subscribe to Run" in the Run slot. The coexistence was deliberate when built, but it reads as a glitch.

Root cause

TopbarSubscribeButton gated only on isCloud && isFreeTier, while showsSubscribeToRunPrompt is isInitialized && !canRunWorkflows. A free-tier workspace out of quota satisfies both, so both CTAs render.

How

TopbarSubscribeButton now yields while a Run-slot prompt is actually mounted. SubscribeToRun registers its presence through useSubscribeCtaPresence, so modes without the Run slot — builder, Linear without outputs, sales-managed, payment recovery — keep the Upgrade button and never drop to zero CTAs. The presence counter is read rather than the billing flag, because the flag over-reports: CloudRunButtonWrapper renders ComfyQueueButton instead of the prompt for sales-managed and payment-recovery states even while the flag is true.

Also folds in the user-popover half: showSubscribeAction now requires canTopUp, so the popover no longer renders "Upgrade to add credits" and "Subscribe" side by side.

AS IS / TO BE

State AS IS TO BE
Free tier, free quota left Upgrade Upgrade
Free tier, can't run Upgrade + Subscribe to Run Subscribe to Run
Subscribed neither neither
Sales-managed / payment recovery queue-button treatments unchanged

Behavioral evidence for the original change is on #16721; this backport is a cherry-pick of that reviewed commit with no production-code changes of its own.

Conflict resolution

Only the two test files conflicted; every production file applied cleanly.

main rewrote both test files' mocks after this branch was cut — typed vi.mock(import(...)) specifiers, vi.mock('pinia') dropped in favour of the global testing pinia, and useDialogStore asserted directly instead of through a hoisted stub. The cherry-pick dragged those rewrites onto a branch that does not have them.

Resolution keeps this branch's existing mock style and layers only the PR's additions on top: the reactive useBillingContext mock, the useSubscribeCtaPresence mock, the presence-registering SubscribeToRun stub, and the "one subscribe CTA at a time" cases. The BillingStatus type import and useDialogStore assertions were left out — they belong to main-only changes, not to this PR.

Verification

CloudRunButtonWrapper.test.ts, TopbarSubscribeButton.test.ts, and CurrentUserPopoverWorkspace.test.ts on this branch: 59 tests, all passing. oxlint and oxfmt --check clean on both resolved files.

Backport of #16721.

Conflict resolution: main rewrote both test files' mocks after this
branch was cut (typed `vi.mock(import(...))` specifiers, `vi.mock('pinia')`
dropped for the global testing pinia, `useDialogStore` asserted directly).
The cherry-pick carried those rewrites in. Kept this branch's existing mock
style and layered the PR's additions on top: the reactive `useBillingContext`
mock, the `useSubscribeCtaPresence` mock, the presence-registering
`SubscribeToRun` stub, and the "one subscribe CTA at a time" cases.
@coderabbitai

coderabbitai Bot commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: b9719626-9a08-4074-8567-9e01dbc5f241

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 15, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 1922 passed, 0 failed

📊 Browser Reports
  • chromium: View Report (✅ 1901 / ❌ 0 / ⚠️ 0 / ⏭️ 13)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/15/2026, 03:12:52 AM UTC

Links

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 62.0 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.6 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.9 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.1 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.9 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.2 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.8 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.6 MB heap
minimap-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 84.0 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.1 MB heap
subgraph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.3 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.1 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 121ms TBT · 101.1 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 84.3 MB heap
vue-large-graph-idle: · 56.3 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 171.3 MB heap
vue-large-graph-pan: · 56.3 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 156ms TBT · 166.7 MB heap
vue-node-resize-workload: · 56.2 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 454ms TBT · 173.6 MB heap
vue-zoom-out-idle: · 57.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 167.7 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.9 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 7ms
canvas-idle: layout count 0
canvas-idle: style recalc count 9
canvas-idle: task duration 494ms
canvas-idle: script duration 8ms
canvas-idle: TBT 0ms
canvas-idle: heap used 62.0 MB
canvas-idle: DOM nodes -278
canvas-idle: event listeners -174
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 5ms
canvas-mouse-sweep: style recalc duration 38ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 78
canvas-mouse-sweep: task duration 917ms
canvas-mouse-sweep: script duration 150ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 64.6 MB
canvas-mouse-sweep: DOM nodes -279
canvas-mouse-sweep: event listeners -161
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 16ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 32
canvas-zoom-sweep: task duration 348ms
canvas-zoom-sweep: script duration 11ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 71.9 MB
canvas-zoom-sweep: DOM nodes 78
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 7ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 11
dom-widget-clipping: task duration 438ms
dom-widget-clipping: script duration 153ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 72.1 MB
dom-widget-clipping: DOM nodes 18
dom-widget-clipping: event listeners 1
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 6ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 7
large-graph-idle: task duration 611ms
large-graph-idle: script duration 33ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 82.9 MB
large-graph-idle: DOM nodes -265
large-graph-idle: event listeners -173
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 10ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 65
large-graph-pan: task duration 1552ms
large-graph-pan: script duration 746ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 82.2 MB
large-graph-pan: DOM nodes -274
large-graph-pan: event listeners -174
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 13ms
large-graph-zoom: style recalc duration 11ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 61
large-graph-zoom: task duration 1666ms
large-graph-zoom: script duration 771ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 72.8 MB
large-graph-zoom: DOM nodes 1
large-graph-zoom: event listeners 9
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 5ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 40
legacy-node-drag: task duration 1859ms
legacy-node-drag: script duration 934ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 83.6 MB
legacy-node-drag: DOM nodes 0
legacy-node-drag: event listeners 187
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 2ms
minimap-idle: layout count 0
minimap-idle: style recalc count 3
minimap-idle: task duration 573ms
minimap-idle: script duration 35ms
minimap-idle: TBT 0ms
minimap-idle: heap used 84.0 MB
minimap-idle: DOM nodes -275
minimap-idle: event listeners -174
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 9ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 46
subgraph-dom-widget-clipping: task duration 393ms
subgraph-dom-widget-clipping: script duration 141ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 83.1 MB
subgraph-dom-widget-clipping: DOM nodes 17
subgraph-dom-widget-clipping: event listeners 8
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 7ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 10
subgraph-idle: task duration 485ms
subgraph-idle: script duration 7ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 70.3 MB
subgraph-idle: DOM nodes -294
subgraph-idle: event listeners -220
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 5ms
subgraph-mouse-sweep: style recalc duration 33ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 77
subgraph-mouse-sweep: task duration 770ms
subgraph-mouse-sweep: script duration 96ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 63.1 MB
subgraph-mouse-sweep: DOM nodes -295
subgraph-mouse-sweep: event listeners -206
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 14ms
subgraph-transition-enter: style recalc duration 30ms
subgraph-transition-enter: layout count 15
subgraph-transition-enter: style recalc count 19
subgraph-transition-enter: task duration 894ms
subgraph-transition-enter: script duration 29ms
subgraph-transition-enter: TBT 121ms
subgraph-transition-enter: heap used 101.1 MB
subgraph-transition-enter: DOM nodes 13751
subgraph-transition-enter: event listeners 2387
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 36ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 247
viewport-pan-sweep: task duration 5649ms
viewport-pan-sweep: script duration 2596ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 84.3 MB
viewport-pan-sweep: DOM nodes -269
viewport-pan-sweep: event listeners -143
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 16851ms
vue-large-graph-idle: script duration 293ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 171.3 MB
vue-large-graph-idle: DOM nodes -6548
vue-large-graph-idle: event listeners -7474
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 19ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 168
vue-large-graph-pan: task duration 20877ms
vue-large-graph-pan: script duration 910ms
vue-large-graph-pan: TBT 156ms
vue-large-graph-pan: heap used 166.7 MB
vue-large-graph-pan: DOM nodes -6548
vue-large-graph-pan: event listeners -7470
vue-node-resize-workload: avg frame time 18ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 24ms
vue-node-resize-workload: style recalc duration 83ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 6143ms
vue-node-resize-workload: script duration 122ms
vue-node-resize-workload: TBT 454ms
vue-node-resize-workload: heap used 173.6 MB
vue-node-resize-workload: DOM nodes -6548
vue-node-resize-workload: event listeners -7473
vue-zoom-out-idle: avg frame time 18ms
vue-zoom-out-idle: p95 frame time 17ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 8488ms
vue-zoom-out-idle: script duration 143ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 167.7 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners -13
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 13ms
workflow-execution: layout count 2
workflow-execution: style recalc count 7
workflow-execution: task duration 65ms
workflow-execution: script duration 5ms
workflow-execution: TBT 0ms
workflow-execution: heap used 67.9 MB
workflow-execution: DOM nodes 116
workflow-execution: event listeners 26
Raw data
{
  "timestamp": "2026-09-15T03:18:36.657Z",
  "gitSha": "bcbfdd7d1354f957fc05cfd08b796768bef89e82",
  "branch": "backport-16721-to-cloud-1.54",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2029.8230000000217,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 6.655999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 492.895,
      "heapDeltaBytes": -3005968,
      "heapUsedBytes": 67076188,
      "domNodes": -278,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 8.480000000000002,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2039.2180000000053,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.220000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 494.10600000000005,
      "heapDeltaBytes": -6226600,
      "heapUsedBytes": 62998732,
      "domNodes": -277,
      "jsHeapTotalBytes": 4448256,
      "scriptDurationMs": 8.408999999999999,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1963.0579999999895,
      "styleRecalcs": 80,
      "styleRecalcDurationMs": 41.535000000000004,
      "layouts": 14,
      "layoutDurationMs": 4.828,
      "taskDurationMs": 974.3629999999999,
      "heapDeltaBytes": -8310928,
      "heapUsedBytes": 61763268,
      "domNodes": -279,
      "jsHeapTotalBytes": 6283264,
      "scriptDurationMs": 157.67700000000002,
      "eventListeners": -146,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1899.028000000044,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 35.145999999999994,
      "layouts": 14,
      "layoutDurationMs": 4.529,
      "taskDurationMs": 859.359,
      "heapDeltaBytes": 2699196,
      "heapUsedBytes": 73730552,
      "domNodes": -279,
      "jsHeapTotalBytes": 6545408,
      "scriptDurationMs": 142.796,
      "eventListeners": -176,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1723.3429999999998,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 15.891000000000002,
      "layouts": 6,
      "layoutDurationMs": 1.1849999999999998,
      "taskDurationMs": 347.923,
      "heapDeltaBytes": 4962848,
      "heapUsedBytes": 76004976,
      "domNodes": 78,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 10.980999999999998,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1681.5389999999297,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 15.574,
      "layouts": 6,
      "layoutDurationMs": 1.1469999999999998,
      "taskDurationMs": 348.90099999999995,
      "heapDeltaBytes": 4957932,
      "heapUsedBytes": 74809800,
      "domNodes": 77,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 10.57,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 628.7110000000098,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 6.970000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 444.261,
      "heapDeltaBytes": -8113796,
      "heapUsedBytes": 62652436,
      "domNodes": 18,
      "jsHeapTotalBytes": 7340032,
      "scriptDurationMs": 154.24400000000003,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 638.7939999999617,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 6.621,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 431.23400000000004,
      "heapDeltaBytes": 18432544,
      "heapUsedBytes": 88646780,
      "domNodes": 18,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 151.59300000000002,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2052.1740000000364,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 5.565,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 612.5639999999999,
      "heapDeltaBytes": 10575420,
      "heapUsedBytes": 86918296,
      "domNodes": -265,
      "jsHeapTotalBytes": -2199552,
      "scriptDurationMs": 33.522,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2032.4279999999817,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 6.393,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 609.9680000000001,
      "heapDeltaBytes": 10753600,
      "heapUsedBytes": 86985740,
      "domNodes": -265,
      "jsHeapTotalBytes": -2461696,
      "scriptDurationMs": 32.096999999999994,
      "eventListeners": -172,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2210.599000000002,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 11.292,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1575.913,
      "heapDeltaBytes": 8175468,
      "heapUsedBytes": 85194500,
      "domNodes": -270,
      "jsHeapTotalBytes": -401408,
      "scriptDurationMs": 753.664,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2160.978,
      "styleRecalcs": 64,
      "styleRecalcDurationMs": 9.403000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1528.074,
      "heapDeltaBytes": 21630136,
      "heapUsedBytes": 87284476,
      "domNodes": -277,
      "jsHeapTotalBytes": 487424,
      "scriptDurationMs": 738.499,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3524.2830000000254,
      "styleRecalcs": 61,
      "styleRecalcDurationMs": 10.897,
      "layouts": 60,
      "layoutDurationMs": 12.668,
      "taskDurationMs": 1676.5550000000003,
      "heapDeltaBytes": 8595964,
      "heapUsedBytes": 76394084,
      "domNodes": 2,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 773.1940000000001,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3523.469999999975,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 10.149000000000001,
      "layouts": 60,
      "layoutDurationMs": 12.633000000000003,
      "taskDurationMs": 1656.3190000000002,
      "heapDeltaBytes": 8796764,
      "heapUsedBytes": 76231424,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 769.16,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3128.563999999983,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 5.003999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1865.5870000000002,
      "heapDeltaBytes": 22164744,
      "heapUsedBytes": 89959604,
      "domNodes": 0,
      "jsHeapTotalBytes": 1728512,
      "scriptDurationMs": 938.3190000000001,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666636,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2978.185999999994,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 5.033000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1853.2900000000002,
      "heapDeltaBytes": 17604136,
      "heapUsedBytes": 85348292,
      "domNodes": 0,
      "jsHeapTotalBytes": 1466368,
      "scriptDurationMs": 929.592,
      "eventListeners": 186,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2011.622999999986,
      "styleRecalcs": 2,
      "styleRecalcDurationMs": 1.7309999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 559.7139999999999,
      "heapDeltaBytes": 22317496,
      "heapUsedBytes": 88057548,
      "domNodes": -274,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 31.866000000000007,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2033.796999999936,
      "styleRecalcs": 3,
      "styleRecalcDurationMs": 2.5040000000000027,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 585.4930000000002,
      "heapDeltaBytes": 10899032,
      "heapUsedBytes": 88083140,
      "domNodes": -275,
      "jsHeapTotalBytes": -1937408,
      "scriptDurationMs": 37.438,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 578.0919999999696,
      "styleRecalcs": 45,
      "styleRecalcDurationMs": 8.578000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 395.24899999999997,
      "heapDeltaBytes": 14771432,
      "heapUsedBytes": 86318848,
      "domNodes": 16,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 141.70499999999998,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 596.2899999999536,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 9.622,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 390.535,
      "heapDeltaBytes": 15066052,
      "heapUsedBytes": 87902768,
      "domNodes": 18,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 140.342,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2007.3309999999651,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.391,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 488.015,
      "heapDeltaBytes": 4490276,
      "heapUsedBytes": 77241156,
      "domNodes": -295,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 7.316,
      "eventListeners": -220,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2016.9480000000135,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 7.19,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 481.87200000000007,
      "heapDeltaBytes": -2071724,
      "heapUsedBytes": 70154360,
      "domNodes": -292,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 7.628999999999999,
      "eventListeners": -220,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1723.7949999999955,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 32.807,
      "layouts": 18,
      "layoutDurationMs": 4.670000000000001,
      "taskDurationMs": 770.832,
      "heapDeltaBytes": -926436,
      "heapUsedBytes": 71351560,
      "domNodes": -295,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 96.36500000000001,
      "eventListeners": -222,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1734.8210000000108,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 32.279999999999994,
      "layouts": 18,
      "layoutDurationMs": 4.764,
      "taskDurationMs": 769.238,
      "heapDeltaBytes": -12075396,
      "heapUsedBytes": 60906572,
      "domNodes": -295,
      "jsHeapTotalBytes": 6545408,
      "scriptDurationMs": 95.44800000000001,
      "eventListeners": -190,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1368.139000000042,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 29.685999999999996,
      "layouts": 15,
      "layoutDurationMs": 13.992,
      "taskDurationMs": 894.3709999999998,
      "heapDeltaBytes": 21940776,
      "heapUsedBytes": 106059368,
      "domNodes": 13751,
      "jsHeapTotalBytes": 11010048,
      "scriptDurationMs": 28.647000000000006,
      "eventListeners": 2387,
      "totalBlockingTimeMs": 121,
      "frameDurationMs": 16.666666666666636,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8315.373000000021,
      "styleRecalcs": 248,
      "styleRecalcDurationMs": 35.782000000000004,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5623.811,
      "heapDeltaBytes": 8963524,
      "heapUsedBytes": 85418024,
      "domNodes": -267,
      "jsHeapTotalBytes": -925696,
      "scriptDurationMs": 2570.397,
      "eventListeners": -128,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8319.430000000011,
      "styleRecalcs": 246,
      "styleRecalcDurationMs": 36.767,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5674.646,
      "heapDeltaBytes": 15218780,
      "heapUsedBytes": 91354240,
      "domNodes": -270,
      "jsHeapTotalBytes": -401408,
      "scriptDurationMs": 2621.158,
      "eventListeners": -158,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17856.822000000022,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16849.176,
      "heapDeltaBytes": -34400440,
      "heapUsedBytes": 179782548,
      "domNodes": -6548,
      "jsHeapTotalBytes": -1507328,
      "scriptDurationMs": 284.717,
      "eventListeners": -7473,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.77333333333336,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17792.754999999943,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16852.137999999995,
      "heapDeltaBytes": -34420684,
      "heapUsedBytes": 179548960,
      "domNodes": -6548,
      "jsHeapTotalBytes": -6844416,
      "scriptDurationMs": 302.059,
      "eventListeners": -7475,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21158.245999999963,
      "styleRecalcs": 169,
      "styleRecalcDurationMs": 18.37300000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20810.147999999997,
      "heapDeltaBytes": -20729164,
      "heapUsedBytes": 182540256,
      "domNodes": -6548,
      "jsHeapTotalBytes": 4444160,
      "scriptDurationMs": 908.9090000000001,
      "eventListeners": -7469,
      "totalBlockingTimeMs": 147,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21290.640999999938,
      "styleRecalcs": 166,
      "styleRecalcDurationMs": 18.65300000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20943.934,
      "heapDeltaBytes": -42291368,
      "heapUsedBytes": 167092508,
      "domNodes": -6548,
      "jsHeapTotalBytes": -3104768,
      "scriptDurationMs": 911.6769999999999,
      "eventListeners": -7471,
      "totalBlockingTimeMs": 165,
      "frameDurationMs": 17.773333333333238,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6273.723000000018,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 91.19,
      "layouts": 20,
      "layoutDurationMs": 24.272000000000002,
      "taskDurationMs": 6172.636999999999,
      "heapDeltaBytes": -38669204,
      "heapUsedBytes": 175578016,
      "domNodes": -6548,
      "jsHeapTotalBytes": 1282048,
      "scriptDurationMs": 135.336,
      "eventListeners": -7473,
      "totalBlockingTimeMs": 397,
      "frameDurationMs": 17.779999999999987,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6204.720000000066,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 74.68400000000003,
      "layouts": 20,
      "layoutDurationMs": 23.66800000000001,
      "taskDurationMs": 6113.107999999999,
      "heapDeltaBytes": -16527376,
      "heapUsedBytes": 188523024,
      "domNodes": -6548,
      "jsHeapTotalBytes": 16207872,
      "scriptDurationMs": 108.84200000000001,
      "eventListeners": -7473,
      "totalBlockingTimeMs": 511,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8978.398000000027,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8479.300000000001,
      "heapDeltaBytes": 15909048,
      "heapUsedBytes": 175844832,
      "domNodes": 0,
      "jsHeapTotalBytes": -1310720,
      "scriptDurationMs": 142.768,
      "eventListeners": -12,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.219999999999953,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8973.604000000023,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8495.704,
      "heapDeltaBytes": 4956500,
      "heapUsedBytes": 175903972,
      "domNodes": 0,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 142.902,
      "eventListeners": -14,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 91.94000000002234,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 11.902999999999999,
      "layouts": 2,
      "layoutDurationMs": 0.601,
      "taskDurationMs": 65.03800000000001,
      "heapDeltaBytes": 3139488,
      "heapUsedBytes": 71061232,
      "domNodes": 108,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 6.097999999999999,
      "eventListeners": 35,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "workflow-execution",
      "durationMs": 96.9759999999269,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 13.150000000000002,
      "layouts": 2,
      "layoutDurationMs": 1.4040000000000004,
      "taskDurationMs": 64.48199999999999,
      "heapDeltaBytes": 2999148,
      "heapUsedBytes": 71231240,
      "domNodes": 124,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 4.246999999999999,
      "eventListeners": 17,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    }
  ]
}

🔬 E2E Coverage

Metric Covered Total Pct
Lines 49889 74431 67.0% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.4% 1159
src/LGraphNode.ts 69.5% 390
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/platform/workspace/stores/billingOperationStore.ts 8.2% 303
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/LGraph.ts 78.6% 261
src/platform/workspace/stores/teamWorkspaceStore.ts 37.7% 261
src/scripts/app.ts 71.8% 251
src/scripts/pnginfo.ts 21.4% 221

@github-actions github-actions Bot added the risk:xhigh PR risk grade (advisory shadow check; grader-owned) label Sep 15, 2026
@codecov

codecov Bot commented Sep 15, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@              Coverage Diff              @@
##             cloud/1.54   #17710   +/-   ##
=============================================
  Coverage              ?   82.99%           
=============================================
  Files                 ?     2053           
  Lines                 ?   119727           
  Branches              ?    32794           
=============================================
  Hits                  ?    99362           
  Misses                ?    20185           
  Partials              ?      180           
Flag Coverage Δ
e2e 67.05% <45.45%> (?)
unit 77.56% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/components/topbar/TopbarSubscribeButton.vue 75.00% <100.00%> (ø)
...m/cloud/subscription/components/SubscribeToRun.vue 95.83% <100.00%> (ø)
...ubscription/composables/useSubscribeCtaPresence.ts 100.00% <100.00%> (ø)
...rkspace/components/CurrentUserPopoverWorkspace.vue 89.47% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@CodeJuggernaut

Copy link
Copy Markdown
Contributor

Holding this backport for 1.55 from main: there is no log of testing beyond unit tests, and the release lines need that evidence.

@christian-byrne christian-byrne left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as part of a batch pass over the eight backports that had been sitting unreviewed.

For the "only one subscribe CTA" family (#17707, #17708, #17709, #17710), I compared the payloads across release lines rather than reading each one separately — the useful question for a backport set is whether the four branches are getting the same change, not whether the diff reads well four times.

They are. Diffing the core/1.54 payload against core/1.53 file by file gives zero files with differing line counts: identical file set, identical additions, identical deletions. Same for the cloud siblings, which carry the same +178/−15 across 7 files. So all four release lines receive the same fix and there is no per-branch drift to reason about.

CI green and mergeable on all four.

@dante01yoon
dante01yoon merged commit f5a7b15 into cloud/1.54 Sep 17, 2026
92 checks passed
@dante01yoon
dante01yoon deleted the backport-16721-to-cloud-1.54 branch September 17, 2026 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:xhigh PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants