Repository navigation
[backport core/1.54] fix(billing): only one subscribe CTA at a time (#16721) - #17709
Conversation
Backport of #16721. Conflict resolution: main rewrote both test files' mocks after this branch was cut (typed `vi.mock(import(...))` specifiers, `vi.mock('pinia')` dropped for the global testing pinia, `useDialogStore` asserted directly). The cherry-pick carried those rewrites in. Kept this branch's existing mock style and layered the PR's additions on top: the reactive `useBillingContext` mock, the `useSubscribeCtaPresence` mock, the presence-registering `SubscribeToRun` stub, and the "one subscribe CTA at a time" cases.
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 1922 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-15T03:19:08.669Z",
"gitSha": "8e3f23b84a3fc5ad086dbfb1fdb43a058c25b84f",
"branch": "backport-16721-to-core-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2087.305000000015,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.81,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 606.3000000000001,
"heapDeltaBytes": -13211196,
"heapUsedBytes": 56634504,
"domNodes": -277,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 11.935999999999998,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2039.1469999999572,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.982999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 590.032,
"heapDeltaBytes": -6227444,
"heapUsedBytes": 62990632,
"domNodes": -276,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 11.297,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1926.0009999999284,
"styleRecalcs": 79,
"styleRecalcDurationMs": 43.81,
"layouts": 14,
"layoutDurationMs": 4.815,
"taskDurationMs": 987.2929999999999,
"heapDeltaBytes": 3327428,
"heapUsedBytes": 74247464,
"domNodes": -279,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 174.368,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1935.615000000098,
"styleRecalcs": 78,
"styleRecalcDurationMs": 42.443000000000005,
"layouts": 14,
"layoutDurationMs": 4.673,
"taskDurationMs": 1012.9029999999999,
"heapDeltaBytes": 1854780,
"heapUsedBytes": 73405280,
"domNodes": -306,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 179.29,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1742.7490000000034,
"styleRecalcs": 32,
"styleRecalcDurationMs": 18.704,
"layouts": 6,
"layoutDurationMs": 1.05,
"taskDurationMs": 417.431,
"heapDeltaBytes": 5103536,
"heapUsedBytes": 75481504,
"domNodes": 75,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 14.482999999999999,
"eventListeners": 21,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1737.7810000000409,
"styleRecalcs": 31,
"styleRecalcDurationMs": 20.860000000000003,
"layouts": 6,
"layoutDurationMs": 1.3579999999999999,
"taskDurationMs": 436.0930000000001,
"heapDeltaBytes": 4666468,
"heapUsedBytes": 74760168,
"domNodes": 76,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 15.105,
"eventListeners": 21,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 828.5409999999729,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.537999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 553.678,
"heapDeltaBytes": 18526440,
"heapUsedBytes": 88469748,
"domNodes": 10,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 198.943,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 725.9350000000495,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.197000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 485.37000000000006,
"heapDeltaBytes": 18825900,
"heapUsedBytes": 88022556,
"domNodes": 18,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 171.612,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2046.8599999999242,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.423,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 652.386,
"heapDeltaBytes": 11013844,
"heapUsedBytes": 87557640,
"domNodes": -271,
"jsHeapTotalBytes": -1675264,
"scriptDurationMs": 35.414,
"eventListeners": -172,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2051.875999999993,
"styleRecalcs": 5,
"styleRecalcDurationMs": 5.446,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 712.7909999999999,
"heapDeltaBytes": 11384536,
"heapUsedBytes": 87656780,
"domNodes": -266,
"jsHeapTotalBytes": -1937408,
"scriptDurationMs": 44.431,
"eventListeners": -172,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2428.580000000011,
"styleRecalcs": 65,
"styleRecalcDurationMs": 10.772,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1709.377,
"heapDeltaBytes": 19104044,
"heapUsedBytes": 84683496,
"domNodes": -269,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 841.844,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2556.968999999981,
"styleRecalcs": 64,
"styleRecalcDurationMs": 9.927999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1727.354,
"heapDeltaBytes": 23072332,
"heapUsedBytes": 88993112,
"domNodes": -274,
"jsHeapTotalBytes": 1011712,
"scriptDurationMs": 844.5350000000001,
"eventListeners": -172,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-zoom",
"durationMs": 3741.9340000000147,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.686000000000002,
"layouts": 60,
"layoutDurationMs": 12.863,
"taskDurationMs": 1817.699,
"heapDeltaBytes": 8198208,
"heapUsedBytes": 75865776,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 816.891,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3768.868999999995,
"styleRecalcs": 60,
"styleRecalcDurationMs": 11.499999999999996,
"layouts": 60,
"layoutDurationMs": 13.306000000000003,
"taskDurationMs": 1843.451,
"heapDeltaBytes": 8493856,
"heapUsedBytes": 76227456,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 825.9150000000001,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3181.5469999999095,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.516999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2028.486,
"heapDeltaBytes": 22853080,
"heapUsedBytes": 90046912,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 986.726,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3276.4170000000377,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.090000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2109.9100000000003,
"heapDeltaBytes": 22913068,
"heapUsedBytes": 90148756,
"domNodes": 0,
"jsHeapTotalBytes": 942080,
"scriptDurationMs": 1046.816,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2037.9250000000866,
"styleRecalcs": 4,
"styleRecalcDurationMs": 6.479000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 647.4629999999999,
"heapDeltaBytes": 10500880,
"heapUsedBytes": 87469896,
"domNodes": -271,
"jsHeapTotalBytes": -1150976,
"scriptDurationMs": 37.521,
"eventListeners": -172,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2043.688999999972,
"styleRecalcs": 2,
"styleRecalcDurationMs": 2.128999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 703.1160000000001,
"heapDeltaBytes": 10870816,
"heapUsedBytes": 87878580,
"domNodes": -276,
"jsHeapTotalBytes": -2199552,
"scriptDurationMs": 39.741,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 640.4079999999794,
"styleRecalcs": 45,
"styleRecalcDurationMs": 10.609999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 426.163,
"heapDeltaBytes": 15167800,
"heapUsedBytes": 88067620,
"domNodes": 16,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 146.344,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 640.9519999999702,
"styleRecalcs": 46,
"styleRecalcDurationMs": 11.042,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 449.704,
"heapDeltaBytes": 15045872,
"heapUsedBytes": 88379172,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 145.32899999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2020.5479999999625,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.470000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 534.405,
"heapDeltaBytes": 4704132,
"heapUsedBytes": 77867008,
"domNodes": -297,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 9.067000000000002,
"eventListeners": -222,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2017.44599999995,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.535999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 557.008,
"heapDeltaBytes": -8085772,
"heapUsedBytes": 64857612,
"domNodes": -293,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 10.648000000000001,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1792.5689999999577,
"styleRecalcs": 79,
"styleRecalcDurationMs": 39.19799999999999,
"layouts": 18,
"layoutDurationMs": 5.509,
"taskDurationMs": 913.0659999999999,
"heapDeltaBytes": 1446140,
"heapUsedBytes": 74420816,
"domNodes": -295,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 120.109,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1776.1649999999918,
"styleRecalcs": 78,
"styleRecalcDurationMs": 42.714999999999996,
"layouts": 18,
"layoutDurationMs": 6.645,
"taskDurationMs": 932.477,
"heapDeltaBytes": 416768,
"heapUsedBytes": 73448416,
"domNodes": -294,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 126.58500000000001,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1434.7240000000738,
"styleRecalcs": 18,
"styleRecalcDurationMs": 34.774,
"layouts": 14,
"layoutDurationMs": 16.669,
"taskDurationMs": 1073.8319999999997,
"heapDeltaBytes": 21998308,
"heapUsedBytes": 105525828,
"domNodes": 13751,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 37.486000000000004,
"eventListeners": 2387,
"totalBlockingTimeMs": 158,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 9230.21200000005,
"styleRecalcs": 247,
"styleRecalcDurationMs": 38.054,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6290.298,
"heapDeltaBytes": 17231244,
"heapUsedBytes": 93588528,
"domNodes": -270,
"jsHeapTotalBytes": -696320,
"scriptDurationMs": 2874.865,
"eventListeners": -156,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 9673.448000000008,
"styleRecalcs": 247,
"styleRecalcDurationMs": 38.111999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6401.851,
"heapDeltaBytes": -8754740,
"heapUsedBytes": 66960936,
"domNodes": -270,
"jsHeapTotalBytes": -1150976,
"scriptDurationMs": 2872.8540000000003,
"eventListeners": -154,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17839.452000000052,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17385.781000000003,
"heapDeltaBytes": -48895092,
"heapUsedBytes": 162201496,
"domNodes": -6548,
"jsHeapTotalBytes": -8826880,
"scriptDurationMs": 363.421,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 18175.39599999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17508.784000000003,
"heapDeltaBytes": -34723304,
"heapUsedBytes": 177054640,
"domNodes": -6552,
"jsHeapTotalBytes": 1712128,
"scriptDurationMs": 309.602,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.773333333333238,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 22646.729999999934,
"styleRecalcs": 173,
"styleRecalcDurationMs": 25.09800000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22351.559999999998,
"heapDeltaBytes": -28060756,
"heapUsedBytes": 181381136,
"domNodes": -6548,
"jsHeapTotalBytes": -5160960,
"scriptDurationMs": 1019.5970000000001,
"eventListeners": -7469,
"totalBlockingTimeMs": 425,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999995634
},
{
"name": "vue-large-graph-pan",
"durationMs": 22306.669000000056,
"styleRecalcs": 168,
"styleRecalcDurationMs": 22.714000000000013,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22027.89,
"heapDeltaBytes": -43297728,
"heapUsedBytes": 166971872,
"domNodes": -6548,
"jsHeapTotalBytes": -6991872,
"scriptDurationMs": 972.87,
"eventListeners": -7469,
"totalBlockingTimeMs": 150,
"frameDurationMs": 17.77333333333348,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6459.050999999931,
"styleRecalcs": 20,
"styleRecalcDurationMs": 82.916,
"layouts": 20,
"layoutDurationMs": 25.70800000000001,
"taskDurationMs": 6400.388000000001,
"heapDeltaBytes": -35596144,
"heapUsedBytes": 168534416,
"domNodes": -6548,
"jsHeapTotalBytes": 4542464,
"scriptDurationMs": 114.02600000000001,
"eventListeners": -7471,
"totalBlockingTimeMs": 467,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 6711.304999999925,
"styleRecalcs": 20,
"styleRecalcDurationMs": 89.54599999999996,
"layouts": 20,
"layoutDurationMs": 29.047000000000004,
"taskDurationMs": 6625.94,
"heapDeltaBytes": -26535296,
"heapUsedBytes": 180827512,
"domNodes": -6548,
"jsHeapTotalBytes": 12472320,
"scriptDurationMs": 131.60300000000004,
"eventListeners": -7471,
"totalBlockingTimeMs": 613,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9163.943000000017,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8815.754000000003,
"heapDeltaBytes": 7852108,
"heapUsedBytes": 177084072,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 155.95199999999997,
"eventListeners": -14,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9266.652000000022,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8840.474,
"heapDeltaBytes": 5852540,
"heapUsedBytes": 177012740,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 170.86199999999997,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 468.4419999999818,
"styleRecalcs": 15,
"styleRecalcDurationMs": 21.618000000000006,
"layouts": 4,
"layoutDurationMs": 2.3640000000000003,
"taskDurationMs": 120.41799999999999,
"heapDeltaBytes": 4863496,
"heapUsedBytes": 73834404,
"domNodes": 124,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 11.195,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "workflow-execution",
"durationMs": 145.2480000000378,
"styleRecalcs": 8,
"styleRecalcDurationMs": 18.831999999999997,
"layouts": 2,
"layoutDurationMs": 1.5040000000000002,
"taskDurationMs": 98.34899999999999,
"heapDeltaBytes": 3004432,
"heapUsedBytes": 72036192,
"domNodes": 128,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 5.962000000000002,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.54 #17709 +/- ##
==========================================
Coverage 82.97% 82.98%
==========================================
Files 2053 2053
Lines 119720 119728 +8
Branches 30970 30971 +1
==========================================
+ Hits 99337 99352 +15
+ Misses 20203 20196 -7
Partials 180 180
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 7 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
Holding this backport for 1.55 from main: there is no log of testing beyond unit tests, and the release lines need that evidence. |
christian-byrne
left a comment
There was a problem hiding this comment.
Approving as part of a batch pass over the eight backports that had been sitting unreviewed.
For the "only one subscribe CTA" family (#17707, #17708, #17709, #17710), I compared the payloads across release lines rather than reading each one separately — the useful question for a backport set is whether the four branches are getting the same change, not whether the diff reads well four times.
They are. Diffing the core/1.54 payload against core/1.53 file by file gives zero files with differing line counts: identical file set, identical additions, identical deletions. Same for the cloud siblings, which carry the same +178/−15 across 7 files. So all four release lines receive the same fix and there is no per-branch drift to reason about.
CI green and mergeable on all four.
Backport of #16721 to
core/1.54. The automation could not open this PR — the cherry-pick conflicted (pr-backport.yamlrun 34923077263).Why
A free-tier workspace that cannot run showed two subscribe CTAs at once: "Upgrade" in the top corner and "Subscribe to Run" in the Run slot. The coexistence was deliberate when built, but it reads as a glitch.
Root cause
TopbarSubscribeButtongated only onisCloud && isFreeTier, whileshowsSubscribeToRunPromptisisInitialized && !canRunWorkflows. A free-tier workspace out of quota satisfies both, so both CTAs render.How
TopbarSubscribeButtonnow yields while a Run-slot prompt is actually mounted.SubscribeToRunregisters its presence throughuseSubscribeCtaPresence, so modes without the Run slot — builder, Linear without outputs, sales-managed, payment recovery — keep the Upgrade button and never drop to zero CTAs. The presence counter is read rather than the billing flag, because the flag over-reports:CloudRunButtonWrapperrendersComfyQueueButtoninstead of the prompt for sales-managed and payment-recovery states even while the flag is true.Also folds in the user-popover half:
showSubscribeActionnow requirescanTopUp, so the popover no longer renders "Upgrade to add credits" and "Subscribe" side by side.AS IS / TO BE
Behavioral evidence for the original change is on #16721; this backport is a cherry-pick of that reviewed commit with no production-code changes of its own.
Conflict resolution
Only the two test files conflicted; every production file applied cleanly.
mainrewrote both test files' mocks after this branch was cut — typedvi.mock(import(...))specifiers,vi.mock('pinia')dropped in favour of the global testing pinia, anduseDialogStoreasserted directly instead of through a hoisted stub. The cherry-pick dragged those rewrites onto a branch that does not have them.Resolution keeps this branch's existing mock style and layers only the PR's additions on top: the reactive
useBillingContextmock, theuseSubscribeCtaPresencemock, the presence-registeringSubscribeToRunstub, and the "one subscribe CTA at a time" cases. TheBillingStatustype import anduseDialogStoreassertions were left out — they belong to main-only changes, not to this PR.Verification
CloudRunButtonWrapper.test.ts,TopbarSubscribeButton.test.ts, andCurrentUserPopoverWorkspace.test.tson this branch: 59 tests, all passing.oxlintandoxfmt --checkclean on both resolved files.