Skip to content

[backport cloud/1.53] fix(billing): only one subscribe CTA at a time (#16721) - #17708

Merged
DrJKL merged 1 commit into
cloud/1.53from
backport-16721-to-cloud-1.53
Sep 17, 2026
Merged

DrJKL merged 1 commit into
cloud/1.53from
backport-16721-to-cloud-1.53

Conversation

@dante01yoon

Copy link
Copy Markdown
Collaborator

Backport of #16721 to cloud/1.53. The automation could not open this PR — the cherry-pick conflicted (pr-backport.yaml run 34923077263).

Why

A free-tier workspace that cannot run showed two subscribe CTAs at once: "Upgrade" in the top corner and "Subscribe to Run" in the Run slot. The coexistence was deliberate when built, but it reads as a glitch.

Root cause

TopbarSubscribeButton gated only on isCloud && isFreeTier, while showsSubscribeToRunPrompt is isInitialized && !canRunWorkflows. A free-tier workspace out of quota satisfies both, so both CTAs render.

How

TopbarSubscribeButton now yields while a Run-slot prompt is actually mounted. SubscribeToRun registers its presence through useSubscribeCtaPresence, so modes without the Run slot — builder, Linear without outputs, sales-managed, payment recovery — keep the Upgrade button and never drop to zero CTAs. The presence counter is read rather than the billing flag, because the flag over-reports: CloudRunButtonWrapper renders ComfyQueueButton instead of the prompt for sales-managed and payment-recovery states even while the flag is true.

Also folds in the user-popover half: showSubscribeAction now requires canTopUp, so the popover no longer renders "Upgrade to add credits" and "Subscribe" side by side.

AS IS / TO BE

State AS IS TO BE
Free tier, free quota left Upgrade Upgrade
Free tier, can't run Upgrade + Subscribe to Run Subscribe to Run
Subscribed neither neither
Sales-managed / payment recovery queue-button treatments unchanged

Behavioral evidence for the original change is on #16721; this backport is a cherry-pick of that reviewed commit with no production-code changes of its own.

Conflict resolution

Only the two test files conflicted; every production file applied cleanly.

main rewrote both test files' mocks after this branch was cut — typed vi.mock(import(...)) specifiers, vi.mock('pinia') dropped in favour of the global testing pinia, and useDialogStore asserted directly instead of through a hoisted stub. The cherry-pick dragged those rewrites onto a branch that does not have them.

Resolution keeps this branch's existing mock style and layers only the PR's additions on top: the reactive useBillingContext mock, the useSubscribeCtaPresence mock, the presence-registering SubscribeToRun stub, and the "one subscribe CTA at a time" cases. The BillingStatus type import and useDialogStore assertions were left out — they belong to main-only changes, not to this PR.

Verification

CloudRunButtonWrapper.test.ts, TopbarSubscribeButton.test.ts, and CurrentUserPopoverWorkspace.test.ts on this branch: 59 tests, all passing. oxlint and oxfmt --check clean on both resolved files.

Backport of #16721.

Conflict resolution: main rewrote both test files' mocks after this
branch was cut (typed `vi.mock(import(...))` specifiers, `vi.mock('pinia')`
dropped for the global testing pinia, `useDialogStore` asserted directly).
The cherry-pick carried those rewrites in. Kept this branch's existing mock
style and layered the PR's additions on top: the reactive `useBillingContext`
mock, the `useSubscribeCtaPresence` mock, the presence-registering
`SubscribeToRun` stub, and the "one subscribe CTA at a time" cases.
@coderabbitai

coderabbitai Bot commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: a03c124e-c518-440a-9f8c-0138b902d64d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 15, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ❌ 1890 passed, 1 failed · 1 flaky

❌ Failed Tests

📊 Browser Reports
  • chromium: View Report (✅ 1869 / ❌ 1 / ⚠️ 1 / ⏭️ 4)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/15/2026, 03:10:43 AM UTC

Links

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 58.9 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 59.2 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.1 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.9 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.1 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.1 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.3 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 84.9 MB heap
minimap-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.6 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.0 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.1 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.4 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 145ms TBT · 82.9 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.5 MB heap
vue-large-graph-idle: · 56.3 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 169.7 MB heap
vue-large-graph-pan: · 57.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 103ms TBT · 163.2 MB heap
vue-node-resize-workload: · 56.2 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 408ms TBT · 169.6 MB heap
workflow-execution: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.9 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 9ms
canvas-idle: layout count 0
canvas-idle: style recalc count 10
canvas-idle: task duration 563ms
canvas-idle: script duration 11ms
canvas-idle: TBT 0ms
canvas-idle: heap used 58.9 MB
canvas-idle: DOM nodes -280
canvas-idle: event listeners -170
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 43ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 78
canvas-mouse-sweep: task duration 930ms
canvas-mouse-sweep: script duration 165ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 59.2 MB
canvas-mouse-sweep: DOM nodes -282
canvas-mouse-sweep: event listeners -156
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 17ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 32
canvas-zoom-sweep: task duration 395ms
canvas-zoom-sweep: script duration 13ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 71.1 MB
canvas-zoom-sweep: DOM nodes 77
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 8ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 11
dom-widget-clipping: task duration 459ms
dom-widget-clipping: script duration 162ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 83.9 MB
dom-widget-clipping: DOM nodes 18
dom-widget-clipping: event listeners 1
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 6ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 6
large-graph-idle: task duration 668ms
large-graph-idle: script duration 35ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 82.1 MB
large-graph-idle: DOM nodes -267
large-graph-idle: event listeners -183
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 8ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 63
large-graph-pan: task duration 1615ms
large-graph-pan: script duration 802ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 82.1 MB
large-graph-pan: DOM nodes -139
large-graph-pan: event listeners 5
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 12ms
large-graph-zoom: style recalc duration 10ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 60
large-graph-zoom: task duration 1710ms
large-graph-zoom: script duration 787ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 72.3 MB
large-graph-zoom: DOM nodes 0
large-graph-zoom: event listeners 9
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 5ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 40
legacy-node-drag: task duration 1912ms
legacy-node-drag: script duration 949ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 84.9 MB
legacy-node-drag: DOM nodes -142
legacy-node-drag: event listeners 188
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 4ms
minimap-idle: layout count 0
minimap-idle: style recalc count 4
minimap-idle: task duration 555ms
minimap-idle: script duration 33ms
minimap-idle: TBT 0ms
minimap-idle: heap used 83.6 MB
minimap-idle: DOM nodes -271
minimap-idle: event listeners -75
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 10ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 46
subgraph-dom-widget-clipping: task duration 417ms
subgraph-dom-widget-clipping: script duration 143ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 83.0 MB
subgraph-dom-widget-clipping: DOM nodes 18
subgraph-dom-widget-clipping: event listeners 7
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 9ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 10
subgraph-idle: task duration 525ms
subgraph-idle: script duration 9ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 65.1 MB
subgraph-idle: DOM nodes -297
subgraph-idle: event listeners -216
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 5ms
subgraph-mouse-sweep: style recalc duration 37ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 78
subgraph-mouse-sweep: task duration 843ms
subgraph-mouse-sweep: script duration 112ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 65.4 MB
subgraph-mouse-sweep: DOM nodes -297
subgraph-mouse-sweep: event listeners -217
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 16ms
subgraph-transition-enter: style recalc duration 31ms
subgraph-transition-enter: layout count 16
subgraph-transition-enter: style recalc count 20
subgraph-transition-enter: task duration 909ms
subgraph-transition-enter: script duration 30ms
subgraph-transition-enter: TBT 145ms
subgraph-transition-enter: heap used 82.9 MB
subgraph-transition-enter: DOM nodes 13751
subgraph-transition-enter: event listeners 2381
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 35ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 248
viewport-pan-sweep: task duration 5855ms
viewport-pan-sweep: script duration 2681ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 82.5 MB
viewport-pan-sweep: DOM nodes -269
viewport-pan-sweep: event listeners -153
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 16523ms
vue-large-graph-idle: script duration 281ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 169.7 MB
vue-large-graph-idle: DOM nodes -6548
vue-large-graph-idle: event listeners -7474
vue-large-graph-pan: avg frame time 17ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 18ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 169
vue-large-graph-pan: task duration 20404ms
vue-large-graph-pan: script duration 897ms
vue-large-graph-pan: TBT 103ms
vue-large-graph-pan: heap used 163.2 MB
vue-large-graph-pan: DOM nodes -6550
vue-large-graph-pan: event listeners -7470
vue-node-resize-workload: avg frame time 18ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 24ms
vue-node-resize-workload: style recalc duration 82ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 6091ms
vue-node-resize-workload: script duration 114ms
vue-node-resize-workload: TBT 408ms
vue-node-resize-workload: heap used 169.6 MB
vue-node-resize-workload: DOM nodes -6548
vue-node-resize-workload: event listeners -7470
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 17ms
workflow-execution: layout count 2
workflow-execution: style recalc count 13
workflow-execution: task duration 102ms
workflow-execution: script duration 9ms
workflow-execution: TBT 0ms
workflow-execution: heap used 68.9 MB
workflow-execution: DOM nodes 139
workflow-execution: event listeners 62
Raw data
{
  "timestamp": "2026-09-15T03:21:16.857Z",
  "gitSha": "6f5822c9f8cd29d5c3ca245284f23f93bfe80dad",
  "branch": "backport-16721-to-cloud-1.53",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2072.225000000003,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 9.808000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 627.844,
      "heapDeltaBytes": -2688124,
      "heapUsedBytes": 67177512,
      "domNodes": -280,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 13.831999999999997,
      "eventListeners": -185,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2053.955999999971,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 8.732000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 498.217,
      "heapDeltaBytes": -13391832,
      "heapUsedBytes": 56362232,
      "domNodes": -280,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 8.101999999999999,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 2016.4120000000594,
      "styleRecalcs": 80,
      "styleRecalcDurationMs": 50.077999999999996,
      "layouts": 14,
      "layoutDurationMs": 4.57,
      "taskDurationMs": 1013.363,
      "heapDeltaBytes": -8125520,
      "heapUsedBytes": 62477592,
      "domNodes": -283,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 175.38700000000003,
      "eventListeners": -157,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1822.0229999999447,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 35.405,
      "layouts": 14,
      "layoutDurationMs": 4.1129999999999995,
      "taskDurationMs": 846.867,
      "heapDeltaBytes": -8881552,
      "heapUsedBytes": 61737572,
      "domNodes": -281,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 155.059,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1740.5710000000454,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 19.587000000000003,
      "layouts": 6,
      "layoutDurationMs": 1.19,
      "taskDurationMs": 449.7340000000001,
      "heapDeltaBytes": 4430932,
      "heapUsedBytes": 75160164,
      "domNodes": 77,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 15.925999999999998,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1667.7689999999075,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 15.006000000000002,
      "layouts": 6,
      "layoutDurationMs": 0.9670000000000002,
      "taskDurationMs": 340.342,
      "heapDeltaBytes": 4335120,
      "heapUsedBytes": 74016840,
      "domNodes": 76,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 9.863999999999997,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 693.251000000032,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 8.876,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 478.43299999999994,
      "heapDeltaBytes": 17807696,
      "heapUsedBytes": 88039444,
      "domNodes": 18,
      "jsHeapTotalBytes": 6029312,
      "scriptDurationMs": 164.591,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 646.6239999999743,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 7.97,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 439.13199999999995,
      "heapDeltaBytes": 18127852,
      "heapUsedBytes": 87807392,
      "domNodes": 18,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 159.744,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2050.212999999985,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 6.283,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 738.8000000000001,
      "heapDeltaBytes": 10551032,
      "heapUsedBytes": 85850648,
      "domNodes": -267,
      "jsHeapTotalBytes": -1916928,
      "scriptDurationMs": 37.477,
      "eventListeners": -183,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2044.2599999998947,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 5.444000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 596.7770000000002,
      "heapDeltaBytes": 11061444,
      "heapUsedBytes": 86310312,
      "domNodes": -267,
      "jsHeapTotalBytes": -868352,
      "scriptDurationMs": 32.946000000000005,
      "eventListeners": -183,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2364.043000000038,
      "styleRecalcs": 62,
      "styleRecalcDurationMs": 7.983000000000004,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1674.5839999999998,
      "heapDeltaBytes": 22084688,
      "heapUsedBytes": 88138824,
      "domNodes": 0,
      "jsHeapTotalBytes": 225280,
      "scriptDurationMs": 815.9329999999999,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2158.005000000003,
      "styleRecalcs": 64,
      "styleRecalcDurationMs": 8.988999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1554.91,
      "heapDeltaBytes": 18152804,
      "heapUsedBytes": 84059884,
      "domNodes": -277,
      "jsHeapTotalBytes": 225280,
      "scriptDurationMs": 787.369,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3613.055000000031,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 10.044,
      "layouts": 60,
      "layoutDurationMs": 12.054999999999998,
      "taskDurationMs": 1767.0919999999999,
      "heapDeltaBytes": 8539528,
      "heapUsedBytes": 76300952,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 807.11,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3491.248999999925,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 9.181999999999995,
      "layouts": 60,
      "layoutDurationMs": 11.259,
      "taskDurationMs": 1653.6179999999997,
      "heapDeltaBytes": 8152700,
      "heapUsedBytes": 75415140,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 767.693,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3098.5469999999395,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 4.610000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1987.644,
      "heapDeltaBytes": 22672992,
      "heapUsedBytes": 89554384,
      "domNodes": -283,
      "jsHeapTotalBytes": 1728512,
      "scriptDurationMs": 969.5550000000001,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2958.642999999938,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 4.771000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1835.43,
      "heapDeltaBytes": 19118588,
      "heapUsedBytes": 88504624,
      "domNodes": 0,
      "jsHeapTotalBytes": 679936,
      "scriptDurationMs": 928.9759999999999,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666636,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2013.9609999999948,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 4.320000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 582.964,
      "heapDeltaBytes": 21828832,
      "heapUsedBytes": 87657336,
      "domNodes": -268,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 35.217999999999996,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "minimap-idle",
      "durationMs": 2011.7079999999987,
      "styleRecalcs": 3,
      "styleRecalcDurationMs": 2.9169999999999994,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 527.754,
      "heapDeltaBytes": 21731260,
      "heapUsedBytes": 87723016,
      "domNodes": -273,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 30.155,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 609.9100000000135,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 10.136000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 425.641,
      "heapDeltaBytes": 14841368,
      "heapUsedBytes": 87431504,
      "domNodes": 18,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 142.375,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 590.5390000000352,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 10.533000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 407.98900000000003,
      "heapDeltaBytes": 14637736,
      "heapUsedBytes": 86628060,
      "domNodes": 18,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 143.503,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2022.4610000000212,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 10.363999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 581.373,
      "heapDeltaBytes": 906992,
      "heapUsedBytes": 73742696,
      "domNodes": -296,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 11.685999999999998,
      "eventListeners": -231,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2018.2420000001002,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.537,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 468.304,
      "heapDeltaBytes": -10049936,
      "heapUsedBytes": 62690232,
      "domNodes": -297,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 7.157999999999998,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1731.9669999999405,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 38.095000000000006,
      "layouts": 18,
      "layoutDurationMs": 4.859999999999999,
      "taskDurationMs": 891.6590000000001,
      "heapDeltaBytes": 4211596,
      "heapUsedBytes": 76990332,
      "domNodes": -297,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 117.37599999999999,
      "eventListeners": -233,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1710.5810000000474,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 35.178000000000004,
      "layouts": 18,
      "layoutDurationMs": 4.7860000000000005,
      "taskDurationMs": 794.071,
      "heapDeltaBytes": -12608008,
      "heapUsedBytes": 60145748,
      "domNodes": -297,
      "jsHeapTotalBytes": 6283264,
      "scriptDurationMs": 106.017,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1400.3930000000082,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 30.996000000000002,
      "layouts": 16,
      "layoutDurationMs": 16.481999999999996,
      "taskDurationMs": 909.3660000000001,
      "heapDeltaBytes": -5441416,
      "heapUsedBytes": 86890684,
      "domNodes": 13751,
      "jsHeapTotalBytes": 11272192,
      "scriptDurationMs": 29.518000000000004,
      "eventListeners": 2381,
      "totalBlockingTimeMs": 145,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 9050.712999999974,
      "styleRecalcs": 247,
      "styleRecalcDurationMs": 35.667,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6081.661999999999,
      "heapDeltaBytes": 12375100,
      "heapUsedBytes": 88366884,
      "domNodes": -270,
      "jsHeapTotalBytes": -675840,
      "scriptDurationMs": 2735.4539999999997,
      "eventListeners": -167,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8320.676000000049,
      "styleRecalcs": 248,
      "styleRecalcDurationMs": 34.294999999999995,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5629.189,
      "heapDeltaBytes": -15978928,
      "heapUsedBytes": 84703320,
      "domNodes": -267,
      "jsHeapTotalBytes": -1392640,
      "scriptDurationMs": 2626.3639999999996,
      "eventListeners": -139,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17143.692999999985,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16715.965999999997,
      "heapDeltaBytes": -33698980,
      "heapUsedBytes": 175690368,
      "domNodes": -6548,
      "jsHeapTotalBytes": -6885376,
      "scriptDurationMs": 280.17199999999997,
      "eventListeners": -7475,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 16935.19100000003,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16329.736,
      "heapDeltaBytes": -35506744,
      "heapUsedBytes": 180198380,
      "domNodes": -6548,
      "jsHeapTotalBytes": 8953856,
      "scriptDurationMs": 281.988,
      "eventListeners": -7473,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 20892.551000000025,
      "styleRecalcs": 169,
      "styleRecalcDurationMs": 18.963000000000008,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20553.895999999997,
      "heapDeltaBytes": -33497400,
      "heapUsedBytes": 176122516,
      "domNodes": -6552,
      "jsHeapTotalBytes": -6467584,
      "scriptDurationMs": 900.453,
      "eventListeners": -7471,
      "totalBlockingTimeMs": 133,
      "frameDurationMs": 17.219999999999953,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 20685.645999999906,
      "styleRecalcs": 168,
      "styleRecalcDurationMs": 16.99199999999995,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20254.126,
      "heapDeltaBytes": -45734492,
      "heapUsedBytes": 166135700,
      "domNodes": -6548,
      "jsHeapTotalBytes": -7970816,
      "scriptDurationMs": 892.917,
      "eventListeners": -7469,
      "totalBlockingTimeMs": 73,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6248.683000000028,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 86.52799999999999,
      "layouts": 20,
      "layoutDurationMs": 25.400000000000006,
      "taskDurationMs": 6133.2210000000005,
      "heapDeltaBytes": -27400784,
      "heapUsedBytes": 174788560,
      "domNodes": -6548,
      "jsHeapTotalBytes": 10743808,
      "scriptDurationMs": 114.74699999999999,
      "eventListeners": -7471,
      "totalBlockingTimeMs": 405,
      "frameDurationMs": 18.333333333333332,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6163.204000000178,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 77.92499999999997,
      "layouts": 20,
      "layoutDurationMs": 21.783000000000012,
      "taskDurationMs": 6049.121,
      "heapDeltaBytes": -21360652,
      "heapUsedBytes": 180827432,
      "domNodes": -6548,
      "jsHeapTotalBytes": 17297408,
      "scriptDurationMs": 112.47999999999999,
      "eventListeners": -7469,
      "totalBlockingTimeMs": 410,
      "frameDurationMs": 17.223333333333297,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 111.33200000017496,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 14.667,
      "layouts": 2,
      "layoutDurationMs": 1.1539999999999997,
      "taskDurationMs": 91.23599999999999,
      "heapDeltaBytes": 3281064,
      "heapUsedBytes": 71798836,
      "domNodes": 130,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 9.479,
      "eventListeners": 25,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "workflow-execution",
      "durationMs": 481.5730000000258,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 19.997999999999994,
      "layouts": 2,
      "layoutDurationMs": 1.1450000000000002,
      "taskDurationMs": 113.03800000000001,
      "heapDeltaBytes": 5176536,
      "heapUsedBytes": 72695360,
      "domNodes": 148,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 8.279,
      "eventListeners": 99,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    }
  ]
}

🔬 E2E Coverage

Metric Covered Total Pct
Lines 48184 70761 68.1% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.1% 1188
src/LGraphNode.ts 69.5% 396
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/platform/workspace/stores/billingOperationStore.ts 8.2% 303
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/LGraph.ts 78.4% 261
src/platform/workspace/stores/teamWorkspaceStore.ts 37.7% 261
src/scripts/app.ts 71.7% 247
src/scripts/pnginfo.ts 21.4% 221
src/stores/assetsStore.ts 44.7% 204

@github-actions github-actions Bot added the risk:R3 PR risk grade (advisory shadow check; grader-owned) label Sep 15, 2026
@codecov

codecov Bot commented Sep 15, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@              Coverage Diff              @@
##             cloud/1.53   #17708   +/-   ##
=============================================
  Coverage              ?   83.37%           
=============================================
  Files                 ?     2027           
  Lines                 ?   117417           
  Branches              ?    34414           
=============================================
  Hits                  ?    97897           
  Misses                ?    19171           
  Partials              ?      349           
Flag Coverage Δ
e2e 66.59% <45.45%> (?)
unit 76.76% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/components/topbar/TopbarSubscribeButton.vue 75.00% <100.00%> (ø)
...m/cloud/subscription/components/SubscribeToRun.vue 95.83% <100.00%> (ø)
...ubscription/composables/useSubscribeCtaPresence.ts 100.00% <100.00%> (ø)
...rkspace/components/CurrentUserPopoverWorkspace.vue 91.44% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@CodeJuggernaut

Copy link
Copy Markdown
Contributor

Holding this backport for 1.55 from main: there is no log of testing beyond unit tests, and the release lines need that evidence.

@christian-byrne christian-byrne left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as part of a batch pass over the eight backports that had been sitting unreviewed.

For the "only one subscribe CTA" family (#17707, #17708, #17709, #17710), I compared the payloads across release lines rather than reading each one separately — the useful question for a backport set is whether the four branches are getting the same change, not whether the diff reads well four times.

They are. Diffing the core/1.54 payload against core/1.53 file by file gives zero files with differing line counts: identical file set, identical additions, identical deletions. Same for the cloud siblings, which carry the same +178/−15 across 7 files. So all four release lines receive the same fix and there is no per-branch drift to reason about.

CI green and mergeable on all four.

@DrJKL
DrJKL merged commit 706f6b2 into cloud/1.53 Sep 17, 2026
127 of 129 checks passed
@DrJKL
DrJKL deleted the backport-16721-to-cloud-1.53 branch September 17, 2026 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:R3 PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants