Repository navigation
[backport cloud/1.53] fix(billing): only one subscribe CTA at a time (#16721) - #17708
Conversation
Backport of #16721. Conflict resolution: main rewrote both test files' mocks after this branch was cut (typed `vi.mock(import(...))` specifiers, `vi.mock('pinia')` dropped for the global testing pinia, `useDialogStore` asserted directly). The cherry-pick carried those rewrites in. Kept this branch's existing mock style and layered the PR's additions on top: the reactive `useBillingContext` mock, the `useSubscribeCtaPresence` mock, the presence-registering `SubscribeToRun` stub, and the "one subscribe CTA at a time" cases.
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ❌ 1890 passed, 1 failed · 1 flaky❌ Failed Tests📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-15T03:21:16.857Z",
"gitSha": "6f5822c9f8cd29d5c3ca245284f23f93bfe80dad",
"branch": "backport-16721-to-cloud-1.53",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2072.225000000003,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.808000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 627.844,
"heapDeltaBytes": -2688124,
"heapUsedBytes": 67177512,
"domNodes": -280,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 13.831999999999997,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2053.955999999971,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.732000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 498.217,
"heapDeltaBytes": -13391832,
"heapUsedBytes": 56362232,
"domNodes": -280,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 8.101999999999999,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2016.4120000000594,
"styleRecalcs": 80,
"styleRecalcDurationMs": 50.077999999999996,
"layouts": 14,
"layoutDurationMs": 4.57,
"taskDurationMs": 1013.363,
"heapDeltaBytes": -8125520,
"heapUsedBytes": 62477592,
"domNodes": -283,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 175.38700000000003,
"eventListeners": -157,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1822.0229999999447,
"styleRecalcs": 75,
"styleRecalcDurationMs": 35.405,
"layouts": 14,
"layoutDurationMs": 4.1129999999999995,
"taskDurationMs": 846.867,
"heapDeltaBytes": -8881552,
"heapUsedBytes": 61737572,
"domNodes": -281,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 155.059,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1740.5710000000454,
"styleRecalcs": 32,
"styleRecalcDurationMs": 19.587000000000003,
"layouts": 6,
"layoutDurationMs": 1.19,
"taskDurationMs": 449.7340000000001,
"heapDeltaBytes": 4430932,
"heapUsedBytes": 75160164,
"domNodes": 77,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 15.925999999999998,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1667.7689999999075,
"styleRecalcs": 31,
"styleRecalcDurationMs": 15.006000000000002,
"layouts": 6,
"layoutDurationMs": 0.9670000000000002,
"taskDurationMs": 340.342,
"heapDeltaBytes": 4335120,
"heapUsedBytes": 74016840,
"domNodes": 76,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 9.863999999999997,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 693.251000000032,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.876,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 478.43299999999994,
"heapDeltaBytes": 17807696,
"heapUsedBytes": 88039444,
"domNodes": 18,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 164.591,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 646.6239999999743,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.97,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 439.13199999999995,
"heapDeltaBytes": 18127852,
"heapUsedBytes": 87807392,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 159.744,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2050.212999999985,
"styleRecalcs": 6,
"styleRecalcDurationMs": 6.283,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 738.8000000000001,
"heapDeltaBytes": 10551032,
"heapUsedBytes": 85850648,
"domNodes": -267,
"jsHeapTotalBytes": -1916928,
"scriptDurationMs": 37.477,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2044.2599999998947,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.444000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 596.7770000000002,
"heapDeltaBytes": 11061444,
"heapUsedBytes": 86310312,
"domNodes": -267,
"jsHeapTotalBytes": -868352,
"scriptDurationMs": 32.946000000000005,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2364.043000000038,
"styleRecalcs": 62,
"styleRecalcDurationMs": 7.983000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1674.5839999999998,
"heapDeltaBytes": 22084688,
"heapUsedBytes": 88138824,
"domNodes": 0,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 815.9329999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2158.005000000003,
"styleRecalcs": 64,
"styleRecalcDurationMs": 8.988999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1554.91,
"heapDeltaBytes": 18152804,
"heapUsedBytes": 84059884,
"domNodes": -277,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 787.369,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3613.055000000031,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.044,
"layouts": 60,
"layoutDurationMs": 12.054999999999998,
"taskDurationMs": 1767.0919999999999,
"heapDeltaBytes": 8539528,
"heapUsedBytes": 76300952,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 807.11,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3491.248999999925,
"styleRecalcs": 60,
"styleRecalcDurationMs": 9.181999999999995,
"layouts": 60,
"layoutDurationMs": 11.259,
"taskDurationMs": 1653.6179999999997,
"heapDeltaBytes": 8152700,
"heapUsedBytes": 75415140,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 767.693,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3098.5469999999395,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.610000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1987.644,
"heapDeltaBytes": 22672992,
"heapUsedBytes": 89554384,
"domNodes": -283,
"jsHeapTotalBytes": 1728512,
"scriptDurationMs": 969.5550000000001,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2958.642999999938,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.771000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1835.43,
"heapDeltaBytes": 19118588,
"heapUsedBytes": 88504624,
"domNodes": 0,
"jsHeapTotalBytes": 679936,
"scriptDurationMs": 928.9759999999999,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666636,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2013.9609999999948,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.320000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 582.964,
"heapDeltaBytes": 21828832,
"heapUsedBytes": 87657336,
"domNodes": -268,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 35.217999999999996,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2011.7079999999987,
"styleRecalcs": 3,
"styleRecalcDurationMs": 2.9169999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 527.754,
"heapDeltaBytes": 21731260,
"heapUsedBytes": 87723016,
"domNodes": -273,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 30.155,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 609.9100000000135,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.136000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 425.641,
"heapDeltaBytes": 14841368,
"heapUsedBytes": 87431504,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 142.375,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 590.5390000000352,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.533000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 407.98900000000003,
"heapDeltaBytes": 14637736,
"heapUsedBytes": 86628060,
"domNodes": 18,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 143.503,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2022.4610000000212,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.363999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 581.373,
"heapDeltaBytes": 906992,
"heapUsedBytes": 73742696,
"domNodes": -296,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 11.685999999999998,
"eventListeners": -231,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2018.2420000001002,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.537,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 468.304,
"heapDeltaBytes": -10049936,
"heapUsedBytes": 62690232,
"domNodes": -297,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 7.157999999999998,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1731.9669999999405,
"styleRecalcs": 78,
"styleRecalcDurationMs": 38.095000000000006,
"layouts": 18,
"layoutDurationMs": 4.859999999999999,
"taskDurationMs": 891.6590000000001,
"heapDeltaBytes": 4211596,
"heapUsedBytes": 76990332,
"domNodes": -297,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 117.37599999999999,
"eventListeners": -233,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1710.5810000000474,
"styleRecalcs": 77,
"styleRecalcDurationMs": 35.178000000000004,
"layouts": 18,
"layoutDurationMs": 4.7860000000000005,
"taskDurationMs": 794.071,
"heapDeltaBytes": -12608008,
"heapUsedBytes": 60145748,
"domNodes": -297,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 106.017,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1400.3930000000082,
"styleRecalcs": 20,
"styleRecalcDurationMs": 30.996000000000002,
"layouts": 16,
"layoutDurationMs": 16.481999999999996,
"taskDurationMs": 909.3660000000001,
"heapDeltaBytes": -5441416,
"heapUsedBytes": 86890684,
"domNodes": 13751,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 29.518000000000004,
"eventListeners": 2381,
"totalBlockingTimeMs": 145,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 9050.712999999974,
"styleRecalcs": 247,
"styleRecalcDurationMs": 35.667,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6081.661999999999,
"heapDeltaBytes": 12375100,
"heapUsedBytes": 88366884,
"domNodes": -270,
"jsHeapTotalBytes": -675840,
"scriptDurationMs": 2735.4539999999997,
"eventListeners": -167,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8320.676000000049,
"styleRecalcs": 248,
"styleRecalcDurationMs": 34.294999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5629.189,
"heapDeltaBytes": -15978928,
"heapUsedBytes": 84703320,
"domNodes": -267,
"jsHeapTotalBytes": -1392640,
"scriptDurationMs": 2626.3639999999996,
"eventListeners": -139,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17143.692999999985,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16715.965999999997,
"heapDeltaBytes": -33698980,
"heapUsedBytes": 175690368,
"domNodes": -6548,
"jsHeapTotalBytes": -6885376,
"scriptDurationMs": 280.17199999999997,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16935.19100000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16329.736,
"heapDeltaBytes": -35506744,
"heapUsedBytes": 180198380,
"domNodes": -6548,
"jsHeapTotalBytes": 8953856,
"scriptDurationMs": 281.988,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 20892.551000000025,
"styleRecalcs": 169,
"styleRecalcDurationMs": 18.963000000000008,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20553.895999999997,
"heapDeltaBytes": -33497400,
"heapUsedBytes": 176122516,
"domNodes": -6552,
"jsHeapTotalBytes": -6467584,
"scriptDurationMs": 900.453,
"eventListeners": -7471,
"totalBlockingTimeMs": 133,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 20685.645999999906,
"styleRecalcs": 168,
"styleRecalcDurationMs": 16.99199999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20254.126,
"heapDeltaBytes": -45734492,
"heapUsedBytes": 166135700,
"domNodes": -6548,
"jsHeapTotalBytes": -7970816,
"scriptDurationMs": 892.917,
"eventListeners": -7469,
"totalBlockingTimeMs": 73,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6248.683000000028,
"styleRecalcs": 20,
"styleRecalcDurationMs": 86.52799999999999,
"layouts": 20,
"layoutDurationMs": 25.400000000000006,
"taskDurationMs": 6133.2210000000005,
"heapDeltaBytes": -27400784,
"heapUsedBytes": 174788560,
"domNodes": -6548,
"jsHeapTotalBytes": 10743808,
"scriptDurationMs": 114.74699999999999,
"eventListeners": -7471,
"totalBlockingTimeMs": 405,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 6163.204000000178,
"styleRecalcs": 20,
"styleRecalcDurationMs": 77.92499999999997,
"layouts": 20,
"layoutDurationMs": 21.783000000000012,
"taskDurationMs": 6049.121,
"heapDeltaBytes": -21360652,
"heapUsedBytes": 180827432,
"domNodes": -6548,
"jsHeapTotalBytes": 17297408,
"scriptDurationMs": 112.47999999999999,
"eventListeners": -7469,
"totalBlockingTimeMs": 410,
"frameDurationMs": 17.223333333333297,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 111.33200000017496,
"styleRecalcs": 7,
"styleRecalcDurationMs": 14.667,
"layouts": 2,
"layoutDurationMs": 1.1539999999999997,
"taskDurationMs": 91.23599999999999,
"heapDeltaBytes": 3281064,
"heapUsedBytes": 71798836,
"domNodes": 130,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.479,
"eventListeners": 25,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 481.5730000000258,
"styleRecalcs": 18,
"styleRecalcDurationMs": 19.997999999999994,
"layouts": 2,
"layoutDurationMs": 1.1450000000000002,
"taskDurationMs": 113.03800000000001,
"heapDeltaBytes": 5176536,
"heapUsedBytes": 72695360,
"domNodes": 148,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.279,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.53 #17708 +/- ##
=============================================
Coverage ? 83.37%
=============================================
Files ? 2027
Lines ? 117417
Branches ? 34414
=============================================
Hits ? 97897
Misses ? 19171
Partials ? 349
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
Holding this backport for 1.55 from main: there is no log of testing beyond unit tests, and the release lines need that evidence. |
christian-byrne
left a comment
There was a problem hiding this comment.
Approving as part of a batch pass over the eight backports that had been sitting unreviewed.
For the "only one subscribe CTA" family (#17707, #17708, #17709, #17710), I compared the payloads across release lines rather than reading each one separately — the useful question for a backport set is whether the four branches are getting the same change, not whether the diff reads well four times.
They are. Diffing the core/1.54 payload against core/1.53 file by file gives zero files with differing line counts: identical file set, identical additions, identical deletions. Same for the cloud siblings, which carry the same +178/−15 across 7 files. So all four release lines receive the same fix and there is no per-branch drift to reason about.
CI green and mergeable on all four.
Backport of #16721 to
cloud/1.53. The automation could not open this PR — the cherry-pick conflicted (pr-backport.yamlrun 34923077263).Why
A free-tier workspace that cannot run showed two subscribe CTAs at once: "Upgrade" in the top corner and "Subscribe to Run" in the Run slot. The coexistence was deliberate when built, but it reads as a glitch.
Root cause
TopbarSubscribeButtongated only onisCloud && isFreeTier, whileshowsSubscribeToRunPromptisisInitialized && !canRunWorkflows. A free-tier workspace out of quota satisfies both, so both CTAs render.How
TopbarSubscribeButtonnow yields while a Run-slot prompt is actually mounted.SubscribeToRunregisters its presence throughuseSubscribeCtaPresence, so modes without the Run slot — builder, Linear without outputs, sales-managed, payment recovery — keep the Upgrade button and never drop to zero CTAs. The presence counter is read rather than the billing flag, because the flag over-reports:CloudRunButtonWrapperrendersComfyQueueButtoninstead of the prompt for sales-managed and payment-recovery states even while the flag is true.Also folds in the user-popover half:
showSubscribeActionnow requirescanTopUp, so the popover no longer renders "Upgrade to add credits" and "Subscribe" side by side.AS IS / TO BE
Behavioral evidence for the original change is on #16721; this backport is a cherry-pick of that reviewed commit with no production-code changes of its own.
Conflict resolution
Only the two test files conflicted; every production file applied cleanly.
mainrewrote both test files' mocks after this branch was cut — typedvi.mock(import(...))specifiers,vi.mock('pinia')dropped in favour of the global testing pinia, anduseDialogStoreasserted directly instead of through a hoisted stub. The cherry-pick dragged those rewrites onto a branch that does not have them.Resolution keeps this branch's existing mock style and layers only the PR's additions on top: the reactive
useBillingContextmock, theuseSubscribeCtaPresencemock, the presence-registeringSubscribeToRunstub, and the "one subscribe CTA at a time" cases. TheBillingStatustype import anduseDialogStoreassertions were left out — they belong to main-only changes, not to this PR.Verification
CloudRunButtonWrapper.test.ts,TopbarSubscribeButton.test.ts, andCurrentUserPopoverWorkspace.test.tson this branch: 59 tests, all passing.oxlintandoxfmt --checkclean on both resolved files.