Skip to content

feat(account): eight-state payment projection and copy (FE-2223) - #17659

Merged
dante01yoon merged 1 commit into
jaewon/fe-2223-phase-3b-subscription-commands-and-eight-state-paymentfrom
jaewon/fe-2223-phase-3b-eight-state-payment-projection
Sep 15, 2026
Merged

dante01yoon merged 1 commit into
jaewon/fe-2223-phase-3b-subscription-commands-and-eight-state-paymentfrom
jaewon/fe-2223-phase-3b-eight-state-payment-projection

Conversation

@dante01yoon

@dante01yoon dante01yoon commented Sep 14, 2026 •

Copy link
Copy Markdown
Collaborator

Why

Stacked on B1 (jaewon/fe-2223-phase-3b-subscription-commands-and-eight-state-payment, #17658) → PR 0 (jaewon/fe-2227-core-error-codes-and-challenge-driver, #17656) → #17655 (FE-2227); independent of FE-2214; merge after all parents.

Phase 3B, part 2 of 2: the eight public payment states as a pure projection of one lifecycle operation, plus the copy keys behind them. Split out of B1 to keep each PR under the source budget.

How

New packages/account/src/core/billing/paymentProjection.ts and paymentCopy.ts (+ tests), export lines appended to index.ts. No other core file is touched.

projectPaymentStep(operation | undefined, hostStep: 'select' | 'preview' | 'canceled') → { step, reasonKey?, recoveryAction?, operationId?, noChargeConfirmed } over the eight states select | preview | verifying | canceled | declined | processing_error | payment_received_hold | success.

  • No operation → the host's step. Pending: parked on the customer (challenge or actionUrl) → verifying; a retryable decline (declineReason, or this tab's failed challenge → authentication_failed) → declined; otherwise preview. succeeded → success; failed → declined, except processing_error / generic → processing_error; timed_out → processing_error (generic); superseded → select.
  • Reason keys are the generated decline_reason enum plus checkout_expired and generic; copy keys are billing.reason.<key>. No raw text can become a key.
  • paymentCopy.ts ports the PoC copy.ts semantics: DEFAULT_PAYMENT_COPY, createPaymentCopy(overrides) where the safety line billing.safety.nothing_was_charged is not host-overridable, and paymentCopyKeys(projection) which names the safety key only for canceled with noChargeConfirmed.
  • noChargeConfirmed is always false: the generated contract has no field that lets a terminal backend result guarantee no current or later charge (one short comment in code says so). Relates to the BE cancel endpoint work (BE-10064).

Tests: every projection row (24 via it.for, including the host-cancel precedence rows and a sweep asserting noChargeConfirmed is never true and payment_received_hold is never produced) and the copy gate (3, including the PoC TP-12 port).

Review focus

Two decisions the plan left open, made here:

  1. Lifecycle reconciliation_needed projects to processing_error (generic) with operationId surfaced, not to payment_received_hold. The contract cannot tell "paid, entitlement pending" from "needs a human"; the id is what support acts on. payment_received_hold stays in the public union and copy table but has no producing row until the backend distinguishes the two.
  2. canceled is reached only through the host: hostStep accepts 'canceled' for a cancel the host observed (closed page, dismissed challenge). A server verdict (succeeded, failed, reconciliation_needed) outranks it — a customer who backs out after the charge went through still sees the result — while pending, timed_out, and superseded yield to it.

Ticket vs generated contract:

  • checkout_expired has no producing row: BillingOpStatusResponse.status has no expired value. The key and its copy are kept for the host and for the backend adding one.
  • noChargeConfirmed has no source field, so it is a boolean that is always false (a literal false type makes the copy gate dead by type and fails no-unnecessary-condition).

AS-IS / TO-BE

No UI surface, no screenshots.

AS-IS: the PoC reducer derived these states from an invented operation status set (expired, canceled, payment_received_hold) and matched raw error_message text for reasons.

TO-BE: a pure projection over the real BillingOperationState; hosts render step/reasonKey/operationId and localize by copy key.

Stack (2026-09-14)

Merge top-down. After a parent is squash-merged, rebase each child with git rebase --onto origin/main <parent tip> and force-push; GitHub retargets the base. Solid edges are code dependencies, dashed edges are sequencing.

flowchart TD
  P12["Phase 1 + 2 merged<br/>#17436 · #17442"] --> C["FE-2227 Phase 3 core<br/>#17655 · base main"]
  C --> P0["PR 0 coded error bodies + 3DS driver<br/>#17656"]
  P0 --> A["FE-2214 top-up command<br/>#17657"]
  P0 --> B1["FE-2223 B1 subscription commands<br/>#17658"]
  B1 --> B2["FE-2223 B2 eight-state projection<br/>#17659"]
  A --> I["Integration, do not merge<br/>#17660"]
  B2 --> I
  I --> V1["FE-2215 @comfyorg/account-ui composables<br/>#17662"]
  V1 --> V2["FE-2215 CheckoutSteps<br/>#17663"]
  I --> SES["core: narrowed BillingSession type<br/>#17664"]
  SES --> AD1["FE-2216 slice 1 top-up behind a flag<br/>#17665"]
  AD1 -.-> AD2["FE-2216 slice 2 subscription<br/>needs previewSubscribe + plan-change decision"]
  AD1 --> E["FE-2217 Phase 6 evidence"]
  S["FE-2211 salvage tag d059104ac3<br/>before 2026-09-30"] -.-> E
  BW["billing-web #17370 → #17574"] --> H["FE-2218 Phase 7 separate origin"]
  AD1 --> H
  V2 -.-> H
  AD1 -.-> SPLIT["account-core / account-ui rename PR"]
  SPLIT -.-> H
Loading

@coderabbitai

coderabbitai Bot commented Sep 14, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: e99d5bc6-6e07-4a87-bb05-851b93ef2ea4

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 14, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 1998 passed, 0 failed · 1 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1977 / ❌ 0 / ⚠️ 1 / ⏭️ 13)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🌐 Website E2E

Tip

All tests passed.

Status ✅ Passed
Report View Report

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/15/2026, 03:45:02 PM UTC

Links

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 62.1 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 62.2 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 61.4 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 76.6 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 77.4 MB heap
large-graph-pan: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.7 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.3 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 77.6 MB heap
minimap-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 79.7 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.2 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.5 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.5 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 123ms TBT · 77.8 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.9 MB heap
vue-large-graph-idle: · 56.3 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 168.4 MB heap
vue-large-graph-pan: · 56.3 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 122ms TBT · 167.1 MB heap
vue-node-resize-workload: · 56.2 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 267ms TBT · 163.1 MB heap
vue-zoom-out-idle: · 54.6 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 158.5 MB heap
workflow-execution: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 62.9 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 8ms
canvas-idle: layout count 0
canvas-idle: style recalc count 9
canvas-idle: task duration 440ms
canvas-idle: script duration 10ms
canvas-idle: TBT 0ms
canvas-idle: heap used 62.1 MB
canvas-idle: DOM nodes -263
canvas-idle: event listeners -154
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 5ms
canvas-mouse-sweep: style recalc duration 33ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 78
canvas-mouse-sweep: task duration 917ms
canvas-mouse-sweep: script duration 166ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 62.2 MB
canvas-mouse-sweep: DOM nodes -265
canvas-mouse-sweep: event listeners -156
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 16ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 31
canvas-zoom-sweep: task duration 310ms
canvas-zoom-sweep: script duration 12ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 61.4 MB
canvas-zoom-sweep: DOM nodes 76
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 8ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 11
dom-widget-clipping: task duration 442ms
dom-widget-clipping: script duration 160ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 76.6 MB
dom-widget-clipping: DOM nodes 17
dom-widget-clipping: event listeners 2
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 5ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 6
large-graph-idle: task duration 605ms
large-graph-idle: script duration 35ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 77.4 MB
large-graph-idle: DOM nodes -253
large-graph-idle: event listeners -168
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 13ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 67
large-graph-pan: task duration 1606ms
large-graph-pan: script duration 802ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 71.7 MB
large-graph-pan: DOM nodes -249
large-graph-pan: event listeners -154
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 14ms
large-graph-zoom: style recalc duration 13ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 62
large-graph-zoom: task duration 1716ms
large-graph-zoom: script duration 784ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 71.3 MB
large-graph-zoom: DOM nodes -127
large-graph-zoom: event listeners -85
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 6ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 41
legacy-node-drag: task duration 1901ms
legacy-node-drag: script duration 963ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 77.6 MB
legacy-node-drag: DOM nodes 2
legacy-node-drag: event listeners 188
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 3ms
minimap-idle: layout count 0
minimap-idle: style recalc count 3
minimap-idle: task duration 554ms
minimap-idle: script duration 36ms
minimap-idle: TBT 0ms
minimap-idle: heap used 79.7 MB
minimap-idle: DOM nodes -255
minimap-idle: event listeners -75
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 10ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 47
subgraph-dom-widget-clipping: task duration 404ms
subgraph-dom-widget-clipping: script duration 142ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 73.2 MB
subgraph-dom-widget-clipping: DOM nodes 20
subgraph-dom-widget-clipping: event listeners 8
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 7ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 9
subgraph-idle: task duration 464ms
subgraph-idle: script duration 8ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 70.5 MB
subgraph-idle: DOM nodes -276
subgraph-idle: event listeners -200
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 5ms
subgraph-mouse-sweep: style recalc duration 27ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 78
subgraph-mouse-sweep: task duration 768ms
subgraph-mouse-sweep: script duration 106ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 69.5 MB
subgraph-mouse-sweep: DOM nodes -275
subgraph-mouse-sweep: event listeners -216
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 12ms
subgraph-transition-enter: style recalc duration 28ms
subgraph-transition-enter: layout count 5
subgraph-transition-enter: style recalc count 18
subgraph-transition-enter: task duration 910ms
subgraph-transition-enter: script duration 30ms
subgraph-transition-enter: TBT 123ms
subgraph-transition-enter: heap used 77.8 MB
subgraph-transition-enter: DOM nodes 13587
subgraph-transition-enter: event listeners 2387
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 38ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 247
viewport-pan-sweep: task duration 5410ms
viewport-pan-sweep: script duration 2680ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 71.9 MB
viewport-pan-sweep: DOM nodes -248
viewport-pan-sweep: event listeners -138
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 17365ms
vue-large-graph-idle: script duration 293ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 168.4 MB
vue-large-graph-idle: DOM nodes -6542
vue-large-graph-idle: event listeners -7478
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 21ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 160
vue-large-graph-pan: task duration 21732ms
vue-large-graph-pan: script duration 884ms
vue-large-graph-pan: TBT 122ms
vue-large-graph-pan: heap used 167.1 MB
vue-large-graph-pan: DOM nodes -6542
vue-large-graph-pan: event listeners -7474
vue-node-resize-workload: avg frame time 18ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 25ms
vue-node-resize-workload: style recalc duration 75ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 5610ms
vue-node-resize-workload: script duration 120ms
vue-node-resize-workload: TBT 267ms
vue-node-resize-workload: heap used 163.1 MB
vue-node-resize-workload: DOM nodes -6542
vue-node-resize-workload: event listeners -7476
vue-zoom-out-idle: avg frame time 18ms
vue-zoom-out-idle: p95 frame time 17ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 8715ms
vue-zoom-out-idle: script duration 181ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 158.5 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners -12
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 2ms
workflow-execution: style recalc duration 20ms
workflow-execution: layout count 4
workflow-execution: style recalc count 13
workflow-execution: task duration 106ms
workflow-execution: script duration 11ms
workflow-execution: TBT 0ms
workflow-execution: heap used 62.9 MB
workflow-execution: DOM nodes 130
workflow-execution: event listeners 58
Raw data
{
  "timestamp": "2026-09-15T15:54:32.957Z",
  "gitSha": "50b70709ed2bdb8c03dfbfeb2547dd1a65428be9",
  "branch": "jaewon/fe-2223-phase-3b-eight-state-payment-projection",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2013.2820000000038,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 7.617999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 511.163,
      "heapDeltaBytes": 11305932,
      "heapUsedBytes": 72139636,
      "domNodes": -264,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 10.596000000000002,
      "eventListeners": -154,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-idle",
      "durationMs": 2006.9230000000289,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.742,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 368.37399999999997,
      "heapDeltaBytes": -4125628,
      "heapUsedBytes": 58072180,
      "domNodes": -262,
      "jsHeapTotalBytes": 4448256,
      "scriptDurationMs": 9.104000000000001,
      "eventListeners": -154,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1982.1729999999889,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 32.84,
      "layouts": 14,
      "layoutDurationMs": 4.997,
      "taskDurationMs": 963.0920000000001,
      "heapDeltaBytes": 8907784,
      "heapUsedBytes": 70261672,
      "domNodes": -267,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 174.542,
      "eventListeners": -158,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1875.996999999984,
      "styleRecalcs": 79,
      "styleRecalcDurationMs": 33.598000000000006,
      "layouts": 14,
      "layoutDurationMs": 4.966999999999999,
      "taskDurationMs": 871.5280000000001,
      "heapDeltaBytes": -1917688,
      "heapUsedBytes": 60118044,
      "domNodes": -263,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 157.221,
      "eventListeners": -154,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1721.3419999999928,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 16.211,
      "layouts": 6,
      "layoutDurationMs": 1.0669999999999997,
      "taskDurationMs": 270.938,
      "heapDeltaBytes": 2111840,
      "heapUsedBytes": 64376532,
      "domNodes": 76,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 11.467000000000002,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1731.7390000000614,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 16.439999999999998,
      "layouts": 6,
      "layoutDurationMs": 1.444,
      "taskDurationMs": 349.59400000000005,
      "heapDeltaBytes": 2103756,
      "heapUsedBytes": 64381264,
      "domNodes": 75,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 11.899,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 647.1099999999979,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 7.72,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 437.58,
      "heapDeltaBytes": 18240556,
      "heapUsedBytes": 80448088,
      "domNodes": 18,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 160.663,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 692.2469999999521,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 7.498000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 446.516,
      "heapDeltaBytes": 17979616,
      "heapUsedBytes": 80170508,
      "domNodes": 16,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 159.17199999999997,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2037.4059999999758,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 3.967999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 579.088,
      "heapDeltaBytes": 2484192,
      "heapUsedBytes": 82532716,
      "domNodes": -248,
      "jsHeapTotalBytes": -1318912,
      "scriptDurationMs": 32.722,
      "eventListeners": -154,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2072.355000000016,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 5.655,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 630.5079999999999,
      "heapDeltaBytes": -175080,
      "heapUsedBytes": 79692408,
      "domNodes": -257,
      "jsHeapTotalBytes": -1318912,
      "scriptDurationMs": 36.642,
      "eventListeners": -182,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2169.590000000028,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 12.961,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1627.2879999999998,
      "heapDeltaBytes": -4944968,
      "heapUsedBytes": 75194516,
      "domNodes": -250,
      "jsHeapTotalBytes": 1527808,
      "scriptDurationMs": 808.461,
      "eventListeners": -154,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2171.1799999999357,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 12.670999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1584.0789999999997,
      "heapDeltaBytes": -5478924,
      "heapUsedBytes": 75185408,
      "domNodes": -248,
      "jsHeapTotalBytes": -45056,
      "scriptDurationMs": 795.286,
      "eventListeners": -154,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3558.403999999996,
      "styleRecalcs": 63,
      "styleRecalcDurationMs": 14.257000000000001,
      "layouts": 60,
      "layoutDurationMs": 14.487,
      "taskDurationMs": 1736.6889999999999,
      "heapDeltaBytes": -7825976,
      "heapUsedBytes": 74535996,
      "domNodes": -255,
      "jsHeapTotalBytes": -532480,
      "scriptDurationMs": 784.836,
      "eventListeners": -178,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3589.805999999953,
      "styleRecalcs": 61,
      "styleRecalcDurationMs": 11.584000000000001,
      "layouts": 60,
      "layoutDurationMs": 14.464,
      "taskDurationMs": 1695.4000000000003,
      "heapDeltaBytes": 9825888,
      "heapUsedBytes": 74941320,
      "domNodes": 2,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 784.04,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3118.048999999985,
      "styleRecalcs": 41,
      "styleRecalcDurationMs": 6.361999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1898.955,
      "heapDeltaBytes": 15949756,
      "heapUsedBytes": 82558368,
      "domNodes": 2,
      "jsHeapTotalBytes": 1728512,
      "scriptDurationMs": 979.237,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3050.194000000033,
      "styleRecalcs": 41,
      "styleRecalcDurationMs": 6.235000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1903.822,
      "heapDeltaBytes": 14536272,
      "heapUsedBytes": 80284424,
      "domNodes": 2,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 946.5930000000001,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666636,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2019.9180000000183,
      "styleRecalcs": 3,
      "styleRecalcDurationMs": 2.877999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 557.357,
      "heapDeltaBytes": -3546860,
      "heapUsedBytes": 83346520,
      "domNodes": -255,
      "jsHeapTotalBytes": -1019904,
      "scriptDurationMs": 31.931,
      "eventListeners": -154,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "minimap-idle",
      "durationMs": 2010.868999999957,
      "styleRecalcs": 3,
      "styleRecalcDurationMs": 2.7609999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 550.2909999999999,
      "heapDeltaBytes": 19302404,
      "heapUsedBytes": 83842392,
      "domNodes": -254,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 39.619,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 618.2810000000245,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 10.132,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 407.36300000000006,
      "heapDeltaBytes": 13300468,
      "heapUsedBytes": 76617280,
      "domNodes": 20,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 143.211,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 571.8219999999974,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 10.291,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 401.369,
      "heapDeltaBytes": 13462316,
      "heapUsedBytes": 76905840,
      "domNodes": 20,
      "jsHeapTotalBytes": 6029312,
      "scriptDurationMs": 141.733,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2015.3810000000476,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.757,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 463.128,
      "heapDeltaBytes": 6692348,
      "heapUsedBytes": 70177012,
      "domNodes": -276,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 7.923999999999997,
      "eventListeners": -200,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2000.2090000000408,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.022,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 465.0639999999999,
      "heapDeltaBytes": 14336980,
      "heapUsedBytes": 77653976,
      "domNodes": -275,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 8.275,
      "eventListeners": -200,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1707.3420000000397,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 26.457,
      "layouts": 18,
      "layoutDurationMs": 5.242999999999999,
      "taskDurationMs": 764.042,
      "heapDeltaBytes": 14191820,
      "heapUsedBytes": 77418720,
      "domNodes": -275,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 104.80199999999999,
      "eventListeners": -200,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1708.5960000000568,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 28.179999999999996,
      "layouts": 18,
      "layoutDurationMs": 5.575,
      "taskDurationMs": 771.6619999999999,
      "heapDeltaBytes": 4727228,
      "heapUsedBytes": 68253036,
      "domNodes": -275,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 107.90199999999999,
      "eventListeners": -232,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1383.7819999999965,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 27.532,
      "layouts": 5,
      "layoutDurationMs": 11.708,
      "taskDurationMs": 909.5389999999999,
      "heapDeltaBytes": -6366308,
      "heapUsedBytes": 81570200,
      "domNodes": 13587,
      "jsHeapTotalBytes": 10485760,
      "scriptDurationMs": 29.752000000000006,
      "eventListeners": 2387,
      "totalBlockingTimeMs": 123,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8222.932000000015,
      "styleRecalcs": 247,
      "styleRecalcDurationMs": 38.982,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5084.7029999999995,
      "heapDeltaBytes": -5413520,
      "heapUsedBytes": 75197752,
      "domNodes": -249,
      "jsHeapTotalBytes": 483328,
      "scriptDurationMs": 2660.444,
      "eventListeners": -138,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8395.982000000004,
      "styleRecalcs": 247,
      "styleRecalcDurationMs": 37.918,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5735.671,
      "heapDeltaBytes": -4389136,
      "heapUsedBytes": 75581592,
      "domNodes": -247,
      "jsHeapTotalBytes": -45056,
      "scriptDurationMs": 2699.024,
      "eventListeners": -138,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17617.054999999993,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17326.02,
      "heapDeltaBytes": -35439456,
      "heapUsedBytes": 182903868,
      "domNodes": -6542,
      "jsHeapTotalBytes": 937984,
      "scriptDurationMs": 292.84299999999996,
      "eventListeners": -7478,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666763,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17711.680999999997,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17404.856000000003,
      "heapDeltaBytes": -31918992,
      "heapUsedBytes": 170213672,
      "domNodes": -6542,
      "jsHeapTotalBytes": 8331264,
      "scriptDurationMs": 293.814,
      "eventListeners": -7478,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21857.16000000002,
      "styleRecalcs": 164,
      "styleRecalcDurationMs": 21.63800000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 21725.982,
      "heapDeltaBytes": -9602892,
      "heapUsedBytes": 185348240,
      "domNodes": -6542,
      "jsHeapTotalBytes": -389120,
      "scriptDurationMs": 890.83,
      "eventListeners": -7472,
      "totalBlockingTimeMs": 149,
      "frameDurationMs": 17.77333333333336,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21851.173000000017,
      "styleRecalcs": 155,
      "styleRecalcDurationMs": 21.13100000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 21738.925,
      "heapDeltaBytes": -53151244,
      "heapUsedBytes": 165092292,
      "domNodes": -6542,
      "jsHeapTotalBytes": -720896,
      "scriptDurationMs": 876.787,
      "eventListeners": -7476,
      "totalBlockingTimeMs": 94,
      "frameDurationMs": 17.779999999999927,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6347.1510000000535,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 76.08699999999999,
      "layouts": 20,
      "layoutDurationMs": 26.32799999999999,
      "taskDurationMs": 6268.701000000001,
      "heapDeltaBytes": -53539716,
      "heapUsedBytes": 165329628,
      "domNodes": -6542,
      "jsHeapTotalBytes": 3833856,
      "scriptDurationMs": 136.722,
      "eventListeners": -7474,
      "totalBlockingTimeMs": 381,
      "frameDurationMs": 18.333333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 5070.9209999999985,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 73.04899999999998,
      "layouts": 20,
      "layoutDurationMs": 24.00200000000001,
      "taskDurationMs": 4950.486,
      "heapDeltaBytes": -17706168,
      "heapUsedBytes": 176613368,
      "domNodes": -6542,
      "jsHeapTotalBytes": 23535616,
      "scriptDurationMs": 102.561,
      "eventListeners": -7478,
      "totalBlockingTimeMs": 152,
      "frameDurationMs": 17.223333333333297,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8829.723999999942,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8688.316,
      "heapDeltaBytes": -424372,
      "heapUsedBytes": 172830644,
      "domNodes": 0,
      "jsHeapTotalBytes": -4194304,
      "scriptDurationMs": 191.09500000000003,
      "eventListeners": -12,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 18.333333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8973.068000000012,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8741.605,
      "heapDeltaBytes": -28242124,
      "heapUsedBytes": 159666832,
      "domNodes": 0,
      "jsHeapTotalBytes": -2883584,
      "scriptDurationMs": 170.08899999999994,
      "eventListeners": -12,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 18.330000000000048,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 474.5620000001054,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 27.360000000000003,
      "layouts": 5,
      "layoutDurationMs": 2.506,
      "taskDurationMs": 138.967,
      "heapDeltaBytes": 5277840,
      "heapUsedBytes": 67021788,
      "domNodes": 153,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 16.042,
      "eventListeners": 83,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "workflow-execution",
      "durationMs": 103.56400000000576,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 13.165,
      "layouts": 2,
      "layoutDurationMs": 0.7100000000000001,
      "taskDurationMs": 72.275,
      "heapDeltaBytes": 3018800,
      "heapUsedBytes": 64856272,
      "domNodes": 106,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 6.453999999999998,
      "eventListeners": 33,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    }
  ]
}

🔬 E2E Coverage

Metric Covered Total Pct
Lines 50800 76112 66.7% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.6% 1160
src/LGraphNode.ts 69.9% 388
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/platform/workspace/stores/workspaceAuthStore.ts 33.4% 327
src/platform/workspace/stores/billingOperationStore.ts 8.0% 311
src/LGraph.ts 79.1% 263
src/platform/workspace/stores/teamWorkspaceStore.ts 38.9% 256
src/scripts/app.ts 71.8% 251
src/scripts/pnginfo.ts 21.4% 221

@codecov

codecov Bot commented Sep 14, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 96.07843% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ages/account/src/core/billing/paymentProjection.ts 94.59% 1 Missing and 1 partial ⚠️
@@                                            Coverage Diff                                            @@
##           jaewon/fe-2223-phase-3b-subscription-commands-and-eight-state-payment   #17659      +/-   ##
=========================================================================================================
- Coverage                                                                  82.73%   82.73%   -0.01%     
=========================================================================================================
  Files                                                                       2788     2790       +2     
  Lines                                                                     140528   140580      +52     
  Branches                                                                   35931    35963      +32     
=========================================================================================================
+ Hits                                                                      116265   116303      +38     
- Misses                                                                     23176    23189      +13     
- Partials                                                                    1087     1088       +1     
Flag Coverage Δ
e2e 66.74% <ø> (-0.01%) ⬇️
unit 78.85% <96.07%> (+<0.01%) ⬆️
website-unit 74.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/account/src/core/billing/paymentCopy.ts 100.00% <100.00%> (ø)
...ages/account/src/core/billing/paymentProjection.ts 94.59% <94.59%> (ø)

... and 12 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Sep 14, 2026
@dante01yoon
dante01yoon force-pushed the jaewon/fe-2223-phase-3b-subscription-commands-and-eight-state-payment branch from 2486008 to 3d79ffe Compare September 15, 2026 01:29
@dante01yoon
dante01yoon force-pushed the jaewon/fe-2223-phase-3b-eight-state-payment-projection branch from aab5d95 to e926cc3 Compare September 15, 2026 01:29
dante01yoon added a commit that referenced this pull request Sep 15, 2026
…FE-2214) (#17689)

## Why

FE-2214's done-when says all three current top-up hosts can integrate
the top-up command. #17657 covers ComfyUI_frontend's route (`POST
/api/billing/topup`, an operation to poll). Workshop (`apps/website`)
and Platform ship on the other route, `POST
/api/billing/topup/checkout`: a provider-hosted Checkout session with no
`billing_op_id`, credits landing through a webhook. That route could not
be decoded with generated schemas until the ingest-types regen #17396
merged; it now carries `CreateTopupCheckoutRequest` /
`CreateTopupCheckoutResponse`, so this is the 3A-2 follow-up recorded on
FE-2214.

Stacked on #17657 (FE-2214 top-up command); merge after it.

## How

`createTopupCommand` gains a second method on the same surface,
`createHostedTopupCheckout({ amountCents, returnUrl, signal? })`:

- input is validated by the generated `zCreateTopupCheckoutRequest`;
`INVALID_AMOUNT` / `INVALID_RETURN_URL` are returned before anything is
sent
- the same capability gate as the in-app command (`ACCESS_DENIED`
carrying the server's denial), then the pre-purchase balance is read
- one idempotency key per attempt, in the body and on the request; a 404
maps to `NOT_AVAILABLE` so a host keeps its legacy path while
`topup_checkout_enabled` is off
- `checkout_url` must be https (`validateActionUrl`, the same rule every
lifecycle continuation obeys), otherwise `MALFORMED_RESPONSE`;
`session_id` passes through when present
- nothing is adopted on the lifecycle and no operation id is invented
(FE-2214 invariant): the result is `{ url, sessionId?, baselineMicros?
}`. The host executes its `OpenUrlMode` on `url` (Workshop pre-opens a
tab, Platform redirects) and on return arms the existing
`createBalanceWatch` with `baselineMicros`, which is how the test proves
completion

`readTopupEligibility` (from the fallow split on #17657) now returns the
two failures it can actually produce, which is what lets the hosted
result union exclude `NO_PAYMENT_METHOD`.

## AS-IS / TO-BE

AS-IS: `TopupCommand` exposes `createTopupCheckout` only; Workshop keeps
its own `createTopUpCheckout` fetch with a hand-written `zTopUpCheckout`
schema, and Platform its own.
TO-BE: `TopupCommand` exposes `createHostedTopupCheckout` over the
generated contract; a host adapter is a thin wrapper (validate → gate →
POST → open → balance watch). No UI in this PR, so no screenshots; the
consumer cutover for Workshop is a separate slice.

## Testing

Eight new tests under `createHostedTopupCheckout` in `topup.test.ts`:
success shape, request body and idempotency key, and no lifecycle
operation; `can_top_up` false without a POST; amount and return-URL
rejection without a request; 404 → `NOT_AVAILABLE`; missing or non-https
URL → `MALFORMED_RESPONSE`; optional session id and baseline omitted
when unknown; baseline handed to a balance watch that reconciles on
return; no server or provider text on the failure path. Billing core
suite 187 passing; oxlint, eslint, oxfmt, `vue-tsc` clean.

## Stack (2026-09-15)

Merge top-down. After a parent is squash-merged, rebase each child with
`git rebase --onto origin/main <parent tip>` and force-push; GitHub
retargets the base. Solid edges are code dependencies, dashed edges are
sequencing.

```mermaid
flowchart TD
  P12["Phase 1 + 2 merged<br/>#17436 · #17442 · ingest-types regen #17396"] --> C["FE-2227 Phase 3 core<br/>#17655 · base main"]
  C --> P0["PR 0 coded error bodies + 3DS driver<br/>#17656"]
  P0 --> A["FE-2214 top-up command<br/>#17657"]
  A --> A2["FE-2214 3A-2 hosted top-up checkout<br/>this PR"]
  P0 --> B1["FE-2223 B1 subscription commands<br/>#17658"]
  B1 --> B2["FE-2223 B2 eight-state projection<br/>#17659"]
  A --> I["Integration, do not merge<br/>#17660"]
  B2 --> I
  I --> V1["FE-2215 @comfyorg/account-ui composables<br/>#17662"]
  V1 --> V2["FE-2215 CheckoutSteps<br/>#17663"]
  I --> SES["core: narrowed BillingSession type<br/>#17664"]
  SES --> AD1["FE-2216 slice 1 top-up behind a flag<br/>#17665"]
  A2 -.-> WS["Workshop adapter over createHostedTopupCheckout<br/>later slice"]
  AD1 -.-> AD2["FE-2216 slice 2 subscription<br/>needs previewSubscribe (FE-2331)"]
  AD1 --> E["FE-2217 Phase 6 evidence"]
  BW["billing-web #17370 → #17574"] --> H["FE-2218 Phase 7 separate origin"]
  AD1 --> H
  H --> H8["FE-2331 Phase 8 hosted surfaces"]
```

Design: [Billing SDK implementation plan
(V2)](https://app.notion.com/p/3d86d73d36508152b92cdbdfdfe83ac8).
Linear: FE-2214.
dante01yoon added a commit that referenced this pull request Sep 15, 2026
…river (FE-2227) (#17656)

## Why

Stacked on #17655 (FE-2227); merge after it. The two Phase 3 command PRs
— top-up ([FE-2214](https://linear.app/comfyorg/issue/FE-2214)) and
subscription ([FE-2223](https://linear.app/comfyorg/issue/FE-2223)) —
both need to act on the server's coded error (`NO_PAYMENT_METHOD`,
`ALREADY_CANCELED`, …) and both need to drive an embedded 3DS challenge
through the lifecycle. FE-2223 may not depend on FE-2214, so the shared
pieces land here, on the core, and each command PR stacks on this one.

## How

- `BillingFailure.serverCode` (additive, optional):
`readValidatedBillingResponse` decodes a non-2xx body with the generated
`zErrorResponse` and carries only its `code`. The `message` is read by
the schema and dropped in `billingErrorBody.ts`, so server text still
cannot travel into the SDK. The codes are `z.string()` in the generated
contract, so each command owns a closed allowlist of the codes it acts
on.
- `driveEmbeddedChallenge(lifecycle, operationId, port)`:
`reportChallengeStarted` → `port.handleNextAction(clientSecret)` →
`reportChallengeSettled`. The port is Stripe's `handleNextAction` shape;
no provider SDK is imported in core, the host injects the object. The
unmoved-intent denylist (`requires_payment_method | requires_action |
canceled` → failed) is ported from
`billingOperationStore.runPaymentIntentAction` on this repo's `main`
(`src/platform/workspace/stores/billingOperationStore.ts:51-55`, `:555`;
landed in `a39b1ce9fa3`, 2026-09-03 — it is not in `cf-main`), and fails
toward the server: an unknown status reports completed and the next poll
corrects it.

## AS-IS / TO-BE

AS-IS: a command sees only `REQUEST_FAILED` + `httpStatus` for a 4xx and
cannot tell "no payment method" from "declined"; each command PR would
re-implement the 3DS drive over `reportChallenge*`.
TO-BE: `result.serverCode === 'NO_PAYMENT_METHOD'` is one comparison;
the challenge drive is one call. No UI surface, so no screenshots.

## Testing

`packages/account` 473/473. Named tests: coded error carried without its
message; non-contract error body yields no code; moved intent →
completed; error / unmoved intent / throw → failed; nothing driven
without a required embedded challenge.

## Stack (2026-09-14)

Merge top-down. After a parent is squash-merged, rebase each child with
`git rebase --onto origin/main <parent tip>` and force-push; GitHub
retargets the base. Solid edges are code dependencies, dashed edges are
sequencing.

```mermaid
flowchart TD
  P12["Phase 1 + 2 merged<br/>#17436 · #17442"] --> C["FE-2227 Phase 3 core<br/>#17655 · base main"]
  C --> P0["PR 0 coded error bodies + 3DS driver<br/>#17656"]
  P0 --> A["FE-2214 top-up command<br/>#17657"]
  P0 --> B1["FE-2223 B1 subscription commands<br/>#17658"]
  B1 --> B2["FE-2223 B2 eight-state projection<br/>#17659"]
  A --> I["Integration, do not merge<br/>#17660"]
  B2 --> I
  I --> V1["FE-2215 @comfyorg/account-ui composables<br/>#17662"]
  V1 --> V2["FE-2215 CheckoutSteps<br/>#17663"]
  I --> SES["core: narrowed BillingSession type<br/>#17664"]
  SES --> AD1["FE-2216 slice 1 top-up behind a flag<br/>#17665"]
  AD1 -.-> AD2["FE-2216 slice 2 subscription<br/>needs previewSubscribe + plan-change decision"]
  AD1 --> E["FE-2217 Phase 6 evidence"]
  S["FE-2211 salvage tag d059104<br/>before 2026-09-30"] -.-> E
  BW["billing-web #17370 → #17574"] --> H["FE-2218 Phase 7 separate origin"]
  AD1 --> H
  V2 -.-> H
  AD1 -.-> SPLIT["account-core / account-ui rename PR"]
  SPLIT -.-> H
```
dante01yoon added a commit that referenced this pull request Sep 15, 2026
…FE-2214) (#17689)

## Why

FE-2214's done-when says all three current top-up hosts can integrate
the top-up command. #17657 covers ComfyUI_frontend's route (`POST
/api/billing/topup`, an operation to poll). Workshop (`apps/website`)
and Platform ship on the other route, `POST
/api/billing/topup/checkout`: a provider-hosted Checkout session with no
`billing_op_id`, credits landing through a webhook. That route could not
be decoded with generated schemas until the ingest-types regen #17396
merged; it now carries `CreateTopupCheckoutRequest` /
`CreateTopupCheckoutResponse`, so this is the 3A-2 follow-up recorded on
FE-2214.

Stacked on #17657 (FE-2214 top-up command); merge after it.

## How

`createTopupCommand` gains a second method on the same surface,
`createHostedTopupCheckout({ amountCents, returnUrl, signal? })`:

- input is validated by the generated `zCreateTopupCheckoutRequest`;
`INVALID_AMOUNT` / `INVALID_RETURN_URL` are returned before anything is
sent
- the same capability gate as the in-app command (`ACCESS_DENIED`
carrying the server's denial), then the pre-purchase balance is read
- one idempotency key per attempt, in the body and on the request; a 404
maps to `NOT_AVAILABLE` so a host keeps its legacy path while
`topup_checkout_enabled` is off
- `checkout_url` must be https (`validateActionUrl`, the same rule every
lifecycle continuation obeys), otherwise `MALFORMED_RESPONSE`;
`session_id` passes through when present
- nothing is adopted on the lifecycle and no operation id is invented
(FE-2214 invariant): the result is `{ url, sessionId?, baselineMicros?
}`. The host executes its `OpenUrlMode` on `url` (Workshop pre-opens a
tab, Platform redirects) and on return arms the existing
`createBalanceWatch` with `baselineMicros`, which is how the test proves
completion

`readTopupEligibility` (from the fallow split on #17657) now returns the
two failures it can actually produce, which is what lets the hosted
result union exclude `NO_PAYMENT_METHOD`.

## AS-IS / TO-BE

AS-IS: `TopupCommand` exposes `createTopupCheckout` only; Workshop keeps
its own `createTopUpCheckout` fetch with a hand-written `zTopUpCheckout`
schema, and Platform its own.
TO-BE: `TopupCommand` exposes `createHostedTopupCheckout` over the
generated contract; a host adapter is a thin wrapper (validate → gate →
POST → open → balance watch). No UI in this PR, so no screenshots; the
consumer cutover for Workshop is a separate slice.

## Testing

Eight new tests under `createHostedTopupCheckout` in `topup.test.ts`:
success shape, request body and idempotency key, and no lifecycle
operation; `can_top_up` false without a POST; amount and return-URL
rejection without a request; 404 → `NOT_AVAILABLE`; missing or non-https
URL → `MALFORMED_RESPONSE`; optional session id and baseline omitted
when unknown; baseline handed to a balance watch that reconciles on
return; no server or provider text on the failure path. Billing core
suite 187 passing; oxlint, eslint, oxfmt, `vue-tsc` clean.

## Stack (2026-09-15)

Merge top-down. After a parent is squash-merged, rebase each child with
`git rebase --onto origin/main <parent tip>` and force-push; GitHub
retargets the base. Solid edges are code dependencies, dashed edges are
sequencing.

```mermaid
flowchart TD
  P12["Phase 1 + 2 merged<br/>#17436 · #17442 · ingest-types regen #17396"] --> C["FE-2227 Phase 3 core<br/>#17655 · base main"]
  C --> P0["PR 0 coded error bodies + 3DS driver<br/>#17656"]
  P0 --> A["FE-2214 top-up command<br/>#17657"]
  A --> A2["FE-2214 3A-2 hosted top-up checkout<br/>this PR"]
  P0 --> B1["FE-2223 B1 subscription commands<br/>#17658"]
  B1 --> B2["FE-2223 B2 eight-state projection<br/>#17659"]
  A --> I["Integration, do not merge<br/>#17660"]
  B2 --> I
  I --> V1["FE-2215 @comfyorg/account-ui composables<br/>#17662"]
  V1 --> V2["FE-2215 CheckoutSteps<br/>#17663"]
  I --> SES["core: narrowed BillingSession type<br/>#17664"]
  SES --> AD1["FE-2216 slice 1 top-up behind a flag<br/>#17665"]
  A2 -.-> WS["Workshop adapter over createHostedTopupCheckout<br/>later slice"]
  AD1 -.-> AD2["FE-2216 slice 2 subscription<br/>needs previewSubscribe (FE-2331)"]
  AD1 --> E["FE-2217 Phase 6 evidence"]
  BW["billing-web #17370 → #17574"] --> H["FE-2218 Phase 7 separate origin"]
  AD1 --> H
  H --> H8["FE-2331 Phase 8 hosted surfaces"]
```

Design: [Billing SDK implementation plan
(V2)](https://app.notion.com/p/3d86d73d36508152b92cdbdfdfe83ac8).
Linear: FE-2214.
@dante01yoon
dante01yoon force-pushed the jaewon/fe-2223-phase-3b-subscription-commands-and-eight-state-payment branch from c37c78c to 68cf988 Compare September 15, 2026 15:43
@dante01yoon
dante01yoon force-pushed the jaewon/fe-2223-phase-3b-eight-state-payment-projection branch from e926cc3 to 4001898 Compare September 15, 2026 15:43

@christian-byrne christian-byrne left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


source_url: #17659
type: github_pr_review
date_accessed: 2026-09-15
relevance: 5
note: Review + approval posted on PR 17659 (eight-state payment projection, FE-2223 B2).

Reviewed at the head of the FE-2223 B2 branch. No code findings. One item for the ADR rather than for this PR, and one thing I chased hard enough that the reasoning is worth leaving here.

The thing I went after, and why it is right

paymentCopy.ts says the safety line is the one key a host may not override — "except the safety line, which only the projection's noChargeConfirmed may ever unlock". Then projectPaymentStep sets noChargeConfirmed: false at all three construction sites and never true, so billing.safety.nothing_was_charged is unreachable through the public projection.

That reads like a dead branch, and on a declined or canceled screen "nothing was charged" is the single most valuable sentence a billing UI has. So I went looking for the missing wire.

There isn't one, and there should not be:

it('never confirms that nothing was charged, whatever the operation reports', …)
expect(projection.noChargeConfirmed).toBe(false)

It is a deliberate invariant with a test pinning it. The SDK refuses to assert that no money moved, because the operation state cannot prove it — a canceled step means this tab stopped watching, not that the provider did nothing. The key exists so something with better information can set it, and paymentCopyKeys gates the line so it can never appear by accident.

That is the right call and the conservative direction: silence over a reassurance you cannot back. Worth saying out loud because the mechanism looks broken from either file alone, and the next reader may "fix" it by wiring true into the canceled branch — which would tell users their money is safe on the exact path where the SDK knows least.

If anything, the docstring could carry the invariant rather than only the gate: "the projection never sets this; a host that can prove no charge occurred may."

For ADR-005, not for this PR

ADR-005 names the BillingStep contract states as verifying, declined, processing_error, payment_received_hold, success. Four of the five are produced here. The fifth is not:

/** Reserved: the contract cannot yet tell "paid, entitlement pending" from "needs a human". */
| 'payment_received_hold'

The comment is honest and the reservation is reasonable — but ADR-005 treats it as a state hosts can act on, and today nothing can produce it, so a host branching on it is writing dead code against a decision record that implies otherwise. That is an ADR/reality gap rather than a PR defect: either the ADR should record it as reserved pending a contract field that distinguishes the two cases, or the contract needs that field. I will raise it on the ADR side; flagging here so the two do not drift silently.

The three added states (select, preview, canceled) are host-position rather than operation states, so they extend ADR-005 rather than contradicting it.

Verified

  • The projection is pure over one operation, and the header comment's claim holds: a server verdict outranks the host's position, so someone who closed the page after a successful charge still lands on success rather than canceled.
  • stepForReason splits processing_error from declined by reason set, so all eight declared states except the reserved one are reachable — I initially miscounted this from a grep and had to read the function; stepForReason and the parked ? 'verifying' : 'preview' ternary are where three of them come from.
  • DEFAULT_PAYMENT_COPY ships English in a framework-free core, which is fine as a host-overridable default — the keys are the contract. Worth keeping an eye on only because the equivalent in billing-web needed re-homing into the locale pipeline later.

Approving. CI is green and I am taking it as the verification run; my worktree still cannot resolve zod through this package's workspace links.

@dante01yoon
dante01yoon merged commit ebab729 into jaewon/fe-2223-phase-3b-subscription-commands-and-eight-state-payment Sep 15, 2026
94 checks passed
@dante01yoon
dante01yoon deleted the jaewon/fe-2223-phase-3b-eight-state-payment-projection branch September 15, 2026 16:20
dante01yoon added a commit that referenced this pull request Sep 15, 2026
…(FE-2223) (#17658)

## Why

```mermaid
flowchart TD
  P12["Phase 1 + 2 merged<br/>#17436 · #17442"] --> C["FE-2227 Phase 3 core<br/>#17655 · base main"]
  C --> P0["PR 0 coded error bodies + 3DS driver<br/>#17656"]
  P0 --> A["FE-2214 top-up command<br/>#17657"]
  P0 --> B1["FE-2223 B1 subscription commands<br/>#17658"]
  B1 --> B2["FE-2223 B2 eight-state projection<br/>#17659"]
  A --> I["Integration, do not merge<br/>#17660"]
  B2 --> I
  I --> V1["FE-2215 @comfyorg/account-ui composables<br/>#17662"]
  V1 --> V2["FE-2215 CheckoutSteps<br/>#17663"]
  I --> SES["core: narrowed BillingSession type<br/>#17664"]
  SES --> AD1["FE-2216 slice 1 top-up behind a flag<br/>#17665"]
  AD1 -.-> AD2["FE-2216 slice 2 subscription<br/>needs previewSubscribe + plan-change decision"]
  AD1 --> E["FE-2217 Phase 6 evidence"]
  S["FE-2211 salvage tag d059104<br/>before 2026-09-30"] -.-> E
  BW["billing-web #17370 → #17574"] --> H["FE-2218 Phase 7 separate origin"]
  AD1 --> H
  V2 -.-> H
  AD1 -.-> SPLIT["account-core / account-ui rename PR"]
  SPLIT -.-> H
```


Stacked on PR 0 (`jaewon/fe-2227-core-error-codes-and-challenge-driver`,
#17656) → #17655 (FE-2227); independent of FE-2214; merge after both
parents.

Phase 3B, part 1 of 2: the subscription commands ported onto the
SDK-owned billing operation lifecycle. Part 2 (the eight-state payment
projection and copy) is stacked on this PR so each stays under the
source budget.

- Linear: https://linear.app/comfyorg/issue/FE-2223

## How

New `packages/account/src/core/billing/subscriptionCommands.ts` (+
test), export lines appended to `index.ts`. No other core file is
touched.

`createBillingCommands({ transport, lifecycle, statusReader,
capabilities, credits, idempotencyKey? })` returns `subscribe`,
`resubscribe`, `cancelSubscription`, `openPaymentPortal`.

- Every command encodes against the generated contract
(`zSubscribeRequest/Response`, `zResubscribeResponse`,
`zCancelSubscriptionResponse2` = the generated union of
`zCancelSubscriptionResponse | zCancelSubscriptionAcceptedResponse`,
`zPaymentPortalResponse`), reads through `readValidatedBillingResponse`,
and issues through `lifecycle.begin` — single-flight, the status gate,
backend-pending adoption, polling, routing, pointer, recovery, and
telemetry all stay in core. The command then awaits
`lifecycle.settled(id)` and returns the terminal state.
- Eligibility comes from the Phase 2 status snapshot's server fields
only (`is_active`, `subscription_tier`, `subscription_status`): FREE →
subscribe issues; PRO active → subscribe is a no-op success with no
request; PRO canceled → subscribe routes to the resubscribe endpoint.
- Saved payment method: `saved_payment_method_id` XOR
`confirmation_token`, empty strings dropped, both present →
`CONFLICTING_PAYMENT_METHOD` before any request (before the status read
too); a request the generated schema refuses (e.g. an id without the
`pm_` prefix) → `INVALID_REQUEST`, also before any request.
- Response mapping: `subscribed` and resubscribe `active` still adopt
the id so the first poll settles it and invalidation/telemetry are
uniform; `needs_payment_method` hands `payment_method_url` to the
lifecycle as the hosted `actionUrl` (missing →
`MISSING_PAYMENT_METHOD_URL`); `pending_payment` / `pending` / both
cancel shapes → observed to a terminal state. 3DS is driven by the host
through the existing `driveEmbeddedChallenge` while the command awaits
settlement (tested end to end through the real lifecycle).
- Server codes (via `BillingFailure.serverCode`):
`REACTIVATION_CONFIRMATION_REQUIRED` → coded result for the host to
re-preview and resend with `confirm_reactivation`; `ALREADY_CANCELED` /
`NOT_SCHEDULED_FOR_CANCELLATION` from a 4xx → already-in-requested-state
success after a status re-read (a 5xx echoing the code stays a failure,
as in `useWorkspaceBilling.isAlreadyInRequestedState`);
`NO_ACTIVE_SUBSCRIPTION` → coded error. Command-level codes live in
`SubscriptionCommandCode`; `BillingErrorCode` is untouched.
- Every succeeded outcome (settled operation or already-in-state)
invalidates the capabilities read and re-reads credits and status (so
`cancel_at` is available after a cancel). A failed credits read never
turns a success into a failure.
- `idempotency_key` goes in every subscribe/resubscribe/cancel body and
as `idempotencyKey` on the `BillingRequest` (the transport's 401 replay
gate), one key per attempt. The portal request carries neither (the
contract has no key; a portal session is not a mutation).
- `openPaymentPortal` returns `{ url }` after `validateActionUrl` (https
only); the SDK never opens it and does not refresh anything on it.
- Raw server / provider text (`message`, `error_message`) never reaches
a result; asserted in the decline, 5xx, coded-error, and resubscribe
(`message` field) tests.

Tests (32, one per ticket row): the {FREE, PRO active, PRO canceled} ×
{subscribe, resubscribe, cancel, portal} matrix including
subscribe→resubscribe routing; saved payment method (4); 3DS through
`driveEmbeddedChallenge`, hosted page, missing page; declines and
reactivation; both cancel response shapes and the 5xx echo; transport
failure, malformed 2xx, 5xx, failed eligibility read; reconciliation;
and reload/resume, poll timeout, and workspace supersession through the
real lifecycle with fake timers.

## Review focus

- Subscribe reads status once for eligibility and `lifecycle.begin`
reads it again for its own pending gate: two `GET /billing/status` per
subscribe. Avoiding it would need a core change (letting `begin` accept
a status), which this PR deliberately does not make.
- Per the eligibility doc, a PRO-active subscribe is a no-op regardless
of `plan_slug`; a plan change on an active subscription (the app's
`checkoutType: 'change'`) is therefore not reachable through this
command yet. Flagged, not silently decided.
- A `needs_payment_method` without a URL is refused without adopting the
id; the backend still reports it as pending, so the next
`begin`/`recover` adopts it rather than reissuing.

Ticket vs generated contract:
- The ticket's resubscribe "`active` → sync success without an id" is
unreachable: `zResubscribeResponse.billing_op_id` is required, so the id
is adopted uniformly.
- `zPaymentPortalRequest` has no `idempotency_key`; the portal POST is
sent without one.

## AS-IS / TO-BE

No UI surface, no screenshots.

AS-IS: subscription commands live in the cloud app (`workspaceApi`,
`useSubscriptionCheckout`, `useWorkspaceBilling`) with their own
polling, pending-checkout storage, and error-string handling.

TO-BE: `@comfyorg/account/billing` exports `createBillingCommands`;
hosts issue commands and render the lifecycle state, never own the
machine, and never see server text.

## Stack (2026-09-14)

Merge top-down. After a parent is squash-merged, rebase each child with
`git rebase --onto origin/main <parent tip>` and force-push; GitHub
retargets the base. Solid edges are code dependencies, dashed edges are
sequencing.

```mermaid
flowchart TD
  P12["Phase 1 + 2 merged<br/>#17436 · #17442"] --> C["FE-2227 Phase 3 core<br/>#17655 · base main"]
  C --> P0["PR 0 coded error bodies + 3DS driver<br/>#17656"]
  P0 --> A["FE-2214 top-up command<br/>#17657"]
  P0 --> B1["FE-2223 B1 subscription commands<br/>#17658"]
  B1 --> B2["FE-2223 B2 eight-state projection<br/>#17659"]
  A --> I["Integration, do not merge<br/>#17660"]
  B2 --> I
  I --> V1["FE-2215 @comfyorg/account-ui composables<br/>#17662"]
  V1 --> V2["FE-2215 CheckoutSteps<br/>#17663"]
  I --> SES["core: narrowed BillingSession type<br/>#17664"]
  SES --> AD1["FE-2216 slice 1 top-up behind a flag<br/>#17665"]
  AD1 -.-> AD2["FE-2216 slice 2 subscription<br/>needs previewSubscribe + plan-change decision"]
  AD1 --> E["FE-2217 Phase 6 evidence"]
  S["FE-2211 salvage tag d059104<br/>before 2026-09-30"] -.-> E
  BW["billing-web #17370 → #17574"] --> H["FE-2218 Phase 7 separate origin"]
  AD1 --> H
  V2 -.-> H
  AD1 -.-> SPLIT["account-core / account-ui rename PR"]
  SPLIT -.-> H
```
dante01yoon added a commit that referenced this pull request Sep 15, 2026
…FE-2214) (#17689)

FE-2214's done-when says all three current top-up hosts can integrate
the top-up command. #17657 covers ComfyUI_frontend's route (`POST
/api/billing/topup`, an operation to poll). Workshop (`apps/website`)
and Platform ship on the other route, `POST
/api/billing/topup/checkout`: a provider-hosted Checkout session with no
`billing_op_id`, credits landing through a webhook. That route could not
be decoded with generated schemas until the ingest-types regen #17396
merged; it now carries `CreateTopupCheckoutRequest` /
`CreateTopupCheckoutResponse`, so this is the 3A-2 follow-up recorded on
FE-2214.

Stacked on #17657 (FE-2214 top-up command); merge after it.

`createTopupCommand` gains a second method on the same surface,
`createHostedTopupCheckout({ amountCents, returnUrl, signal? })`:

- input is validated by the generated `zCreateTopupCheckoutRequest`;
`INVALID_AMOUNT` / `INVALID_RETURN_URL` are returned before anything is
sent
- the same capability gate as the in-app command (`ACCESS_DENIED`
carrying the server's denial), then the pre-purchase balance is read
- one idempotency key per attempt, in the body and on the request; a 404
maps to `NOT_AVAILABLE` so a host keeps its legacy path while
`topup_checkout_enabled` is off
- `checkout_url` must be https (`validateActionUrl`, the same rule every
lifecycle continuation obeys), otherwise `MALFORMED_RESPONSE`;
`session_id` passes through when present
- nothing is adopted on the lifecycle and no operation id is invented
(FE-2214 invariant): the result is `{ url, sessionId?, baselineMicros?
}`. The host executes its `OpenUrlMode` on `url` (Workshop pre-opens a
tab, Platform redirects) and on return arms the existing
`createBalanceWatch` with `baselineMicros`, which is how the test proves
completion

`readTopupEligibility` (from the fallow split on #17657) now returns the
two failures it can actually produce, which is what lets the hosted
result union exclude `NO_PAYMENT_METHOD`.

AS-IS: `TopupCommand` exposes `createTopupCheckout` only; Workshop keeps
its own `createTopUpCheckout` fetch with a hand-written `zTopUpCheckout`
schema, and Platform its own.
TO-BE: `TopupCommand` exposes `createHostedTopupCheckout` over the
generated contract; a host adapter is a thin wrapper (validate → gate →
POST → open → balance watch). No UI in this PR, so no screenshots; the
consumer cutover for Workshop is a separate slice.

Eight new tests under `createHostedTopupCheckout` in `topup.test.ts`:
success shape, request body and idempotency key, and no lifecycle
operation; `can_top_up` false without a POST; amount and return-URL
rejection without a request; 404 → `NOT_AVAILABLE`; missing or non-https
URL → `MALFORMED_RESPONSE`; optional session id and baseline omitted
when unknown; baseline handed to a balance watch that reconciles on
return; no server or provider text on the failure path. Billing core
suite 187 passing; oxlint, eslint, oxfmt, `vue-tsc` clean.

Merge top-down. After a parent is squash-merged, rebase each child with
`git rebase --onto origin/main <parent tip>` and force-push; GitHub
retargets the base. Solid edges are code dependencies, dashed edges are
sequencing.

```mermaid
flowchart TD
  P12["Phase 1 + 2 merged<br/>#17436 · #17442 · ingest-types regen #17396"] --> C["FE-2227 Phase 3 core<br/>#17655 · base main"]
  C --> P0["PR 0 coded error bodies + 3DS driver<br/>#17656"]
  P0 --> A["FE-2214 top-up command<br/>#17657"]
  A --> A2["FE-2214 3A-2 hosted top-up checkout<br/>this PR"]
  P0 --> B1["FE-2223 B1 subscription commands<br/>#17658"]
  B1 --> B2["FE-2223 B2 eight-state projection<br/>#17659"]
  A --> I["Integration, do not merge<br/>#17660"]
  B2 --> I
  I --> V1["FE-2215 @comfyorg/account-ui composables<br/>#17662"]
  V1 --> V2["FE-2215 CheckoutSteps<br/>#17663"]
  I --> SES["core: narrowed BillingSession type<br/>#17664"]
  SES --> AD1["FE-2216 slice 1 top-up behind a flag<br/>#17665"]
  A2 -.-> WS["Workshop adapter over createHostedTopupCheckout<br/>later slice"]
  AD1 -.-> AD2["FE-2216 slice 2 subscription<br/>needs previewSubscribe (FE-2331)"]
  AD1 --> E["FE-2217 Phase 6 evidence"]
  BW["billing-web #17370 → #17574"] --> H["FE-2218 Phase 7 separate origin"]
  AD1 --> H
  H --> H8["FE-2331 Phase 8 hosted surfaces"]
```

Design: [Billing SDK implementation plan
(V2)](https://app.notion.com/p/3d86d73d36508152b92cdbdfdfe83ac8).
Linear: FE-2214.
dante01yoon added a commit that referenced this pull request Sep 15, 2026
…4) (#17657)

## Why

Stacked on PR 0 (`jaewon/fe-2227-core-error-codes-and-challenge-driver`,
#17656) → #17655 (FE-2227); merge after both.

Phase 3A of the billing SDK: the top-up command mapped onto the shared
operation lifecycle, covering both routes cloud exposes today. Only
request/response mapping lives here — the status-read gate,
single-flight, polling, routing, the pointer, failure meaning, and
telemetry all come from the lifecycle in #17655/#17656 and are not
duplicated.

- Linear: https://linear.app/comfyorg/issue/FE-2214

## How

`packages/account/src/core/billing/topup.ts` — `createTopupCommand({
transport, lifecycle, capabilities, credits, idempotencyKey? })`
returning two commands on one surface:

**`createTopupCheckout({ amountCents, signal? })`** — the in-app route
ComfyUI_frontend uses (`POST /billing/topup`, an operation to observe):

1. `capabilities.read()` → `can_top_up === false` ⇒ `{ status: 'error',
code: 'ACCESS_DENIED', denial? }` without a POST. The server flag is the
only gate; nothing is derived.
2. Amount validated with `zCreateTopupRequest`; the plain input object
is what travels (the schema coerces to bigint, which the transport
cannot serialize).
3. One fresh key per POST attempt, in the body (`idempotency_key`) and
as `idempotencyKey` on the `BillingRequest`. Supplying that key is what
makes the POST replayable at the transport's 401 gate (`replayable =
method === 'GET' || idempotencyKey !== undefined`): the single 401
replay is safe *because* the same key travels in both places for the
backend to deduplicate on. Backend dedup is load-bearing on this route,
not incidental. A fresh key is minted per attempt, so two user-initiated
top-ups never collide.
4. POST through `lifecycle.begin('topup', issue)`; the response is
decoded with `zCreateTopupResponse` and its `billing_op_id` adopted
regardless of `status`, so the first poll settles synchronous results
and carries the coded decline.
5. Command-level `TopupResult` union: `ok` (terminal `succeeded` state
embedded + `creditsReconciled`), `declined` (terminal `failed` state
embedded: `declineReason`, `recoveryAction`, `retryable`), `unsettled`
(`timed_out` / `reconciliation_needed` embedded), plus `error` codes —
the core `BillingErrorCode`s untouched, and `NOT_AVAILABLE` (404 on the
POST), `NO_PAYMENT_METHOD` (`serverCode`, with `recoveryAction:
'replace_payment_method'`), `INVALID_AMOUNT` (below the generated
minimum; nothing sent). A `superseded` operation passes through as
`SUPERSEDED`.
6. On `succeeded`: `capabilities.invalidate()` and a credits re-read;
`creditsReconciled` compares it with the read taken before the POST.

**`createHostedTopupCheckout({ amountCents, returnUrl, signal? })`** —
the hosted route Workshop (`apps/website`) and Platform ship on (`POST
/billing/topup/checkout`, a provider-hosted Checkout session with no
operation; credits land through a webhook). Decodable since the
ingest-types regen #17396 merged:

1. Input validated by the generated `zCreateTopupCheckoutRequest`;
`INVALID_AMOUNT` / `INVALID_RETURN_URL` before anything is sent.
2. The same capability gate, then the pre-purchase balance is read.
3. One idempotency key per attempt, in the body and on the request; 404
→ `NOT_AVAILABLE` so a host keeps its legacy path while
`topup_checkout_enabled` is off.
4. `checkout_url` must be https (`validateActionUrl`, the rule every
lifecycle continuation obeys), otherwise `MALFORMED_RESPONSE`;
`session_id` passes through when present.
5. Nothing is adopted on the lifecycle and no operation id is invented:
the result is `{ url, sessionId?, baselineMicros? }`. The host executes
its `OpenUrlMode` on `url` (Workshop pre-opens a tab, Platform
redirects) and on return arms `createBalanceWatch` with
`baselineMicros`.

`packages/account/src/core/billing/balanceWatch.ts` —
`createBalanceWatch({ credits, baselineMicros? })`, the framework-free
port of `src/composables/billing/topupBalanceRefresh.ts` (gaps `[0, 2,
5, 10, 20]s`, 15-minute lifetime, 5 scheduled runs, a single read per
wake past the cap). No document listeners: the host calls `wake()` from
its own focus/visibility signals. This is the completion path for the
hosted command and the explicit fallback when no `billing_op_id` can be
observed on the in-app one; the SDK never invents one.

Raw server / Stripe text never reaches a result (asserted in the tests).

Contract findings (generated contract wins; for FE-2211's TDD-correction
list):

- The ticket's `returnUrl` and "no `billing_op_id`" rows describe the
hosted route, not `zCreateTopupRequest` (which has only `amount_cents`,
`checkout_attempt_id`, `idempotency_key`). They are served by
`createHostedTopupCheckout`.
- `zCreateTopupResponse.billing_op_id` is required, so the in-app
command's balance-watch fallback is tested against a
`MALFORMED_RESPONSE` on the POST, not an invented id.
- The plan's `credits.read({ forceRefresh })` does not exist:
`CreditsReader.read` always requests, so it is called plainly.
- `amount_cents` is `z.coerce.bigint()` on both request schemas;
validated with `safeParse`, sent as the number.
- `ErrorResponse.code` is `z.string()`, not an enum, so
`NO_PAYMENT_METHOD` is an SDK-owned allowlist entry.

Tests (`topup.test.ts`, `balanceWatch.test.ts`), one per ticket row for
the in-app command: `can_top_up` false, saved payment method, needs 3DS
(driven through PR 0's `driveEmbeddedChallenge`), no payment method,
declined, unexpected error, payment received with credits pending, 404 →
`NOT_AVAILABLE` (and a 404 while polling left to the lifecycle), fresh
idempotency key per attempt, in the body and on the request,
generated-schema rejection, invalidation on success, scope supersession
passthrough, no-`billing_op_id` balance-watch fallback. For the hosted
command: success shape with request body, idempotency key, and no
lifecycle operation; `can_top_up` false without a POST; amount and
return-URL rejection without a request; 404 → `NOT_AVAILABLE`; missing
or non-https URL → `MALFORMED_RESPONSE`; optional session id and
baseline omitted when unknown; baseline handed to a balance watch that
reconciles on return; no server text on the failure path. Reload/resume,
routing, timeout, and duplicate-poll coverage stays in the core suite.

## AS-IS / TO-BE

No UI surface, no screenshots.

- AS-IS: the SDK exposes the lifecycle but no command issues a top-up on
it; the cloud app's `workspaceApi.createTopup` + `topupBalanceRefresh`,
Workshop's `createTopUpCheckout` fetch with a hand-written schema, and
Platform's own call remain the only paths.
- TO-BE: `@comfyorg/account/billing` exports `createTopupCommand`
(in-app and hosted top-up over the generated contract) and
`createBalanceWatch`; each host adapter is a thin wrapper that reads a
coded, text-free result. Consumer cutovers are separate slices
(ComfyUI_frontend: #17665; Workshop and Platform: later).

## Stack (2026-09-15)

Merge top-down. After a parent is squash-merged, rebase each child with
`git rebase --onto origin/main <parent tip>` and force-push; GitHub
retargets the base. Solid edges are code dependencies, dashed edges are
sequencing. The hosted command (formerly #17689) is squashed into this
PR.

```mermaid
flowchart TD
  P12["Phase 1 + 2 merged<br/>#17436 · #17442 · ingest-types regen #17396"] --> C["FE-2227 Phase 3 core<br/>#17655 · base main"]
  C --> P0["PR 0 coded error bodies + 3DS driver<br/>#17656"]
  P0 --> A["FE-2214 top-up commands, in-app + hosted<br/>#17657"]
  P0 --> B1["FE-2223 B1 subscription commands<br/>#17658"]
  B1 --> B2["FE-2223 B2 eight-state projection<br/>#17659"]
  A --> I["Integration, do not merge<br/>#17660"]
  B2 --> I
  I --> V1["FE-2215 @comfyorg/account-ui composables<br/>#17662"]
  V1 --> V2["FE-2215 CheckoutSteps<br/>#17663"]
  I --> SES["core: narrowed BillingSession type<br/>#17664"]
  SES --> AD1["FE-2216 slice 1 top-up behind a flag<br/>#17665"]
  A -.-> WS["Workshop adapter over createHostedTopupCheckout<br/>consumer slice"]
  AD1 -.-> AD2["FE-2216 slice 2 subscription<br/>needs previewSubscribe (FE-2331)"]
  AD1 --> E["FE-2217 Phase 6 evidence"]
  BW["billing-web #17370 → #17574"] --> H["FE-2218 Phase 7 separate origin"]
  AD1 --> H
  V2 -.-> H
  H --> H8["FE-2331 Phase 8 hosted surfaces"]
```
pull Bot pushed a commit to Penguinjanator/ComfyUI_frontend that referenced this pull request Sep 15, 2026
…nt (FE-2227) (Comfy-Org#17655)

## Why

Phase 3 Core of the billing half of `@comfyorg/account`
([FE-2210](https://linear.app/comfyorg/issue/FE-2210) /
[FE-2227](https://linear.app/comfyorg/issue/FE-2227/phase-3-core-sdk-owned-billing-operation-lifecycle-routing-recovery)):
the one operation lifecycle the top-up (FE-2214) and subscription
(FE-2223) commands sit on, so neither implements its own poller,
reducer, routing, or recovery.

## Where this sits in the plan

Plan: [Billing SDK implementation plan
(V2)](https://app.notion.com/p/3d86d73d36508152b92cdbdfdfe83ac8). Layer
TDD: [Centralized Hosted Billing
Application](https://app.notion.com/p/3d76d73d36508181951dfaa4f71dc8e5).

| Phase | Issue | Deliverable | State |
| --- | --- | --- | --- |
| 1 | [FE-2212](https://linear.app/comfyorg/issue/FE-2212) | Billing
ports and transport on the merged session client | Merged — Comfy-Org#17436 |
| 2 | [FE-2213](https://linear.app/comfyorg/issue/FE-2213) | Read path:
status, capabilities, credits | Merged — Comfy-Org#17442 |
| 3 Core | [FE-2227](https://linear.app/comfyorg/issue/FE-2227) |
Operation lifecycle, routing, recovery, fallback | **this PR** |
| 3A | [FE-2214](https://linear.app/comfyorg/issue/FE-2214) | Top-up
command on the lifecycle | Open — Comfy-Org#17657 |
| 3B | [FE-2223](https://linear.app/comfyorg/issue/FE-2223) |
Subscription commands and the eight-state projection | Open — Comfy-Org#17658 →
Comfy-Org#17659 |

No consumer and no flag: nothing in the app imports this yet.

## How

- `operationState.ts`: `BillingOperationState`, a discriminated union
over one `billing_op_id` (`pending | succeeded | failed | timed_out |
reconciliation_needed | superseded`), and the pure
`reduceBillingOperation` transition. The identity, including
`presentation`, is fixed at adoption; switching embedded ↔ hosted is an
event on the same operation, never a replacement. The transition decodes
the generated `zBillingOpStatusResponse` and reads only the coded
`decline_reason` / `recovery_action` — `error_message` is never read, so
no Stripe or server text can reach a consumer.
- `operationPolicy.ts`: the cadence (1s × 1.5 → 8s cap; 30s flat once
parked on the customer) and the poll budgets (120s; 5 min for
subscription discovery; 23h once the customer is involved), ported from
`billingOperationStore`.
- `operationPointer.ts`: the tab-local pointer, keyed by `(userId,
workspaceId)`, over a host-supplied storage port. The Comfy-Org#16120 rule
survives: a client timeout keeps the pointer, settlement clears it.
- `presentation.ts`: `selectBillingPresentation`, the single routing
decision. Embedded only when the host reports it can drive a challenge
and `billing_rail === 'stripe'`; a command response that carries a page
and no challenge is hosted regardless.
- `operationLifecycle.ts`: `createBillingOperationLifecycle` — `begin`
(single-flight per kind; the Phase 2 status read gates every start and a
backend-pending operation of the same kind is adopted instead of issued
again), `recover` (server pending op first, then the pointer), `wake`,
`switchPresentation`, `reportChallengeStarted/Settled`, `settled`, and
the `billing.operation.*` telemetry.

## Review focus

1. **Effects are declared, not performed.** The core never opens a URL,
drives 3DS, or listens to a document. A host renders `actionUrl` /
`challenge`, performs the effect, and reports back; visibility and focus
arrive as `wake()`. This is what keeps the ticket's "no host framework
or navigation side effect" true by construction rather than by import
guard.
2. **Fail closed toward hosted, and toward not charging.** Routing falls
to hosted on every unknown (no rail, legacy rail, host cannot embed).
`begin` refuses to issue when the status read fails; `recover` falls
back to the pointer only on `REQUEST_FAILED`, since an unreachable
server is not "nothing pending".
3. **No-operation-id reconciliation.** When the status reports nothing
pending but a pointer exists, one read decides: `404` drops the pointer
without observing; a settled answer terminalizes from that single read;
a still-pending answer (a `cancel`, which status cannot report) is
observed from it rather than fetched twice.
4. **Supersession is a terminal state.** A workspace or session change
marks every pending operation `superseded`, and a response landing after
the change is discarded rather than applied. `ACCESS_DENIED` /
`NOT_AUTHENTICATED` mid-poll land there too. The pointer stays under the
old scope's key so a return recovers it.
5. **Departures from the app store, deliberately.** The "nothing was
charged" safety copy is not modelled: the generated contract has no
`no_charge_confirmed`, so the SDK cannot claim it. The eight public
states are not projected here; 3A/3B own that. The transport is the
Phase 1 `BillingTransport`, so the Layer TDD's HttpOnly-cookie transport
swaps in underneath without touching this file.

## AS-IS / TO-BE

AS-IS: no shared lifecycle — `billingOperationStore` owns polling,
recovery, and routing inside the app, and each Phase 3 command would
have to reimplement them.
TO-BE: one exported `createBillingOperationLifecycle` in
`@comfyorg/account/billing` that commands adopt an id into. No UI
surface, so no screenshots.

## Testing

`packages/account` suite 468/468 (this PR adds 44). Typecheck, oxlint,
eslint, oxfmt, knip clean.

Named tests per the ticket's done-when: resume (`recover` × server
pending / pointer / unreachable status), duplicate-poll prevention
(`wake` joins the poll in flight), scope and session supersession
(workspace change with a late response; sign-out), timeout (budget kept
with pointer; budget widened once the customer is involved),
terminalization (coded decline reason, no server text; reconciliation on
`404`), presentation switching with a stable `billing_op_id` (challenge
fails → hosted → rollback, one `issue` call), hosted fallback refused
without a URL, no-operation-id reconciliation, and telemetry (`started`
/ terminal with `presentation`, `resumed`, `failure_category`).

Manual: none, and none is meaningful — no consumer, no UI surface.

## Stack (2026-09-14)

Merge top-down. After a parent is squash-merged, rebase each child with
`git rebase --onto origin/main <parent tip>` and force-push; GitHub
retargets the base. Solid edges are code dependencies, dashed edges are
sequencing.

```mermaid
flowchart TD
  P12["Phase 1 + 2 merged<br/>Comfy-Org#17436 · Comfy-Org#17442"] --> C["FE-2227 Phase 3 core<br/>Comfy-Org#17655 · base main"]
  C --> P0["PR 0 coded error bodies + 3DS driver<br/>Comfy-Org#17656"]
  P0 --> A["FE-2214 top-up command<br/>Comfy-Org#17657"]
  P0 --> B1["FE-2223 B1 subscription commands<br/>Comfy-Org#17658"]
  B1 --> B2["FE-2223 B2 eight-state projection<br/>Comfy-Org#17659"]
  A --> I["Integration, do not merge<br/>Comfy-Org#17660"]
  B2 --> I
  I --> V1["FE-2215 @comfyorg/account-ui composables<br/>Comfy-Org#17662"]
  V1 --> V2["FE-2215 CheckoutSteps<br/>Comfy-Org#17663"]
  I --> SES["core: narrowed BillingSession type<br/>Comfy-Org#17664"]
  SES --> AD1["FE-2216 slice 1 top-up behind a flag<br/>Comfy-Org#17665"]
  AD1 -.-> AD2["FE-2216 slice 2 subscription<br/>needs previewSubscribe + plan-change decision"]
  AD1 --> E["FE-2217 Phase 6 evidence"]
  S["FE-2211 salvage tag d059104<br/>before 2026-09-30"] -.-> E
  BW["billing-web Comfy-Org#17370 → Comfy-Org#17574"] --> H["FE-2218 Phase 7 separate origin"]
  AD1 --> H
  V2 -.-> H
  AD1 -.-> SPLIT["account-core / account-ui rename PR"]
  SPLIT -.-> H
```
pull Bot pushed a commit to Penguinjanator/ComfyUI_frontend that referenced this pull request Sep 15, 2026
…y-Org#17664)

## Why

Stacked on the Phase 3 integration ref
(`jaewon/fe-2227-phase3-integration`, Comfy-Org#17660); merge after Phase 3.
Found while wiring the first in-app consumer (FE-2216): the app's
session client is `SessionClient<TUser>` for its own user type, and the
identity seam is contravariant in that user, so every billing factory
that demanded the full base `SessionClient` rejected the host's client.
Without this, Phase 5 cannot hand the merged session client to the SDK
at all.

## How

One type, `BillingSession = Pick<SessionClient, 'getSnapshot' |
'subscribe' | 'ensureFresh' | 'remint'>`, names the four members the
billing core actually reaches for. The transport, the scope tracker, the
three readers, and the lifecycle take `BillingSession` instead of
`SessionClient`. Type-only; no runtime change, no test change needed
(the existing fakes already satisfy the narrower type). Pulled out of
the FE-2216 branch so the core change is reviewed on its own and the
consumer PR stays app-only.

## AS-IS / TO-BE

AS-IS: `createSessionBillingTransport({ session:
workspaceAuthStore.getUnifiedSessionClient() })` fails to typecheck for
a host whose user type is narrower than `AccountUser`.
TO-BE: any client exposing the four members is accepted. No UI surface,
no screenshots.

## Testing

`packages/account` suite unchanged and green; typecheck, oxlint, eslint,
oxfmt clean.



## Stack (2026-09-14)

Merge top-down. After a parent is squash-merged, rebase each child with
`git rebase --onto origin/main <parent tip>` and force-push; GitHub
retargets the base. Solid edges are code dependencies, dashed edges are
sequencing.

```mermaid
flowchart TD
  P12["Phase 1 + 2 merged<br/>Comfy-Org#17436 · Comfy-Org#17442"] --> C["FE-2227 Phase 3 core<br/>Comfy-Org#17655 · base main"]
  C --> P0["PR 0 coded error bodies + 3DS driver<br/>Comfy-Org#17656"]
  P0 --> A["FE-2214 top-up command<br/>Comfy-Org#17657"]
  P0 --> B1["FE-2223 B1 subscription commands<br/>Comfy-Org#17658"]
  B1 --> B2["FE-2223 B2 eight-state projection<br/>Comfy-Org#17659"]
  A --> I["Integration, do not merge<br/>Comfy-Org#17660"]
  B2 --> I
  I --> V1["FE-2215 @comfyorg/account-ui composables<br/>Comfy-Org#17662"]
  V1 --> V2["FE-2215 CheckoutSteps<br/>Comfy-Org#17663"]
  I --> SES["core: narrowed BillingSession type<br/>Comfy-Org#17664"]
  SES --> AD1["FE-2216 slice 1 top-up behind a flag<br/>Comfy-Org#17665"]
  AD1 -.-> AD2["FE-2216 slice 2 subscription<br/>needs previewSubscribe + plan-change decision"]
  AD1 --> E["FE-2217 Phase 6 evidence"]
  S["FE-2211 salvage tag d059104<br/>before 2026-09-30"] -.-> E
  BW["billing-web Comfy-Org#17370 → Comfy-Org#17574"] --> H["FE-2218 Phase 7 separate origin"]
  AD1 --> H
  V2 -.-> H
  AD1 -.-> SPLIT["account-core / account-ui rename PR"]
  SPLIT -.-> H
```
pull Bot pushed a commit to Penguinjanator/ComfyUI_frontend that referenced this pull request Sep 15, 2026
…ience (FE-2215) (Comfy-Org#17662)

## Why

Stacked on the Phase 3 integration branch
(`jaewon/fe-2227-phase3-integration`, PR 0 + Comfy-Org#17657 + Comfy-Org#17659); retarget
`main` once Phase 3 lands.

Phase 4 of the billing SDK track: the core in
`@comfyorg/account/billing` is framework-free by construction, so the
Vue composables that present it need a package of their own. This PR
scaffolds it and ships the composables; the unstyled `CheckoutSteps`
component follows in the stacked PR
Comfy-Org#17663 to keep this
one reviewable.

- Linear: https://linear.app/comfyorg/issue/FE-2215
- Name decision: the ticket left `@comfyorg/account-ui` vs
`@comfyorg/billing-ui` open. Picked **`@comfyorg/account-ui`** — it is
the view half of `@comfyorg/account` and will also be the natural home
for the sign-in pieces if they ever leave `@comfyorg/account/vue`
(explicitly out of scope here).

## How

New package `packages/account-ui` (`@comfyorg/account-ui`, private,
`workspace:*`), entry `./billing` only. Modelled on `packages/account`:
same tsconfig, `lint`/`typecheck` scripts, `vue` + `@vueuse/core` as
peers, `@comfyorg/account` as a real dependency. `@comfyorg/account`
gains no Vue dependency and is not modified.

Registration: `knip.config.ts` workspace, root
`lint`/`lint:no-cache`/`typecheck` scripts (`typecheck:account-ui`), and
the license workflow's `--excludePackages` list (a private package
reports as UNLICENSED, same as `@comfyorg/account`). Root
`tsconfig.json` has no `references` array; the eslint resolver already
globs `./packages/*/tsconfig.json`, and vitest already globs
`packages/**`.

Contents (`src/billing/`), ported from the PoC `vue/billing.ts` and
re-seated on the merged core API:

- `billingClient.ts` — `BillingClient` (lifecycle + capabilities +
credits + topup command + subscription commands), `BILLING_CLIENT_KEY`,
`provideBillingClient`, `useBillingClient`. Every composable takes an
explicit client or falls back to the injected one.
- `useBillingOperation(selector, client?)` — subscribes to
`BillingOperationLifecycle` once, selects by `{ id }` or `{ kind }`
(newest of that kind, so a resumed operation is picked up from the
snapshot), unsubscribes on scope end via `tryOnScopeDispose`.
- `useTopUp(options)` — the headless top-up over `createTopupCommand` +
`driveEmbeddedChallenge` + `projectPaymentStep`. Exposes
`canTopUp`/`denial` read from the server's capabilities snapshot
(undefined until read, never derived locally), host-owned
`presetsCents`/`minAmountCents`/`maxAmountCents`/`creditsPerDollar` (an
amount outside the host bounds returns `INVALID_AMOUNT` without reaching
the core), `amountCents`, `submitting`, `result`, the eight-state
`projection`,
`submit`/`retry`/`preview`/`cancel`/`reset`/`continueVerification`. A
hosted continuation goes to the host's `openUrl(url, mode)` with `mode:
'new_tab' | 'redirect' | 'preopened'` (host picks the mode via
`navigationMode`); an embedded challenge is driven through the host's
`challengePort`. No router, no window, no Stripe here.
- `useCheckout(options)` — the same attempt machinery over
`createBillingCommands`: `subscribe`, `resubscribe`, `retry` (resends
the last request), `openPaymentPortal` (resolves the URL and hands it to
`openUrl`). `cancelSubscription` is not a checkout and stays on
`client.commands`.
- `useCredits(options)` — balance in micros as the core reports it,
`loading`, `failure` (a failed refresh keeps the last balance),
`refresh`.
- `usePaymentAttempt` (internal) — what top-up and checkout share: the
followed operation, the projection over it, the host-reported step, the
once-per-continuation effect. A host-reported cancel outranks a pending
operation; `reset` drops only a settled one from view, never a live one.

Copy: nothing here renders text. The projection carries coded keys only;
`CheckoutSteps` (next PR) resolves them through
`createPaymentCopy`/`paymentCopyKeys`.

Tests (vitest + @testing-library/vue, 12 tests) run the real core over a
scripted transport (`__fixtures__/billingHarness.ts`): `can_top_up`
gating with the coded denial and no POST, host bounds outside the core,
hosted continuation opened once in the configured mode and again on
`continueVerification`, embedded challenge driven through the port with
a capabilities re-read after settlement, coded decline with no provider
text in result/projection/operation, cancel/reset semantics,
provide/inject resolution, scope-end unsubscribe.

## AS-IS / TO-BE

No UI surface, no screenshots.

- AS-IS: the billing core has no Vue consumer; every host would
re-derive operation tracking, projection, continuation, and gating.
- TO-BE: `@comfyorg/account-ui/billing` exposes the headless top-up and
checkout experiences; hosts supply navigation, the challenge port,
presets, bounds, and copy.

## Notes for review

- Non-test source is ~556 lines; `CheckoutSteps` is split into the
stacked PR to stay under the ~600 guard.
- `useCredits` reads once on setup by default (`immediate: false` to opt
out).
- `useTopUp` does not gate `submit` on the cached `canTopUp`; the core
re-reads capabilities itself, and the cached value exists to disable the
CTA.



## Stack (2026-09-14)

Merge top-down. After a parent is squash-merged, rebase each child with
`git rebase --onto origin/main <parent tip>` and force-push; GitHub
retargets the base. Solid edges are code dependencies, dashed edges are
sequencing.

```mermaid
flowchart TD
  P12["Phase 1 + 2 merged<br/>Comfy-Org#17436 · Comfy-Org#17442"] --> C["FE-2227 Phase 3 core<br/>Comfy-Org#17655 · base main"]
  C --> P0["PR 0 coded error bodies + 3DS driver<br/>Comfy-Org#17656"]
  P0 --> A["FE-2214 top-up command<br/>Comfy-Org#17657"]
  P0 --> B1["FE-2223 B1 subscription commands<br/>Comfy-Org#17658"]
  B1 --> B2["FE-2223 B2 eight-state projection<br/>Comfy-Org#17659"]
  A --> I["Integration, do not merge<br/>Comfy-Org#17660"]
  B2 --> I
  I --> V1["FE-2215 @comfyorg/account-ui composables<br/>Comfy-Org#17662"]
  V1 --> V2["FE-2215 CheckoutSteps<br/>Comfy-Org#17663"]
  I --> SES["core: narrowed BillingSession type<br/>Comfy-Org#17664"]
  SES --> AD1["FE-2216 slice 1 top-up behind a flag<br/>Comfy-Org#17665"]
  AD1 -.-> AD2["FE-2216 slice 2 subscription<br/>needs previewSubscribe + plan-change decision"]
  AD1 --> E["FE-2217 Phase 6 evidence"]
  S["FE-2211 salvage tag d059104<br/>before 2026-09-30"] -.-> E
  BW["billing-web Comfy-Org#17370 → Comfy-Org#17574"] --> H["FE-2218 Phase 7 separate origin"]
  AD1 --> H
  V2 -.-> H
  AD1 -.-> SPLIT["account-core / account-ui rename PR"]
  SPLIT -.-> H
```
pull Bot pushed a commit to Mu-L/ComfyUI_frontend that referenced this pull request Sep 15, 2026
…flag (FE-2216) (Comfy-Org#17665)

## Why

Stacked on Comfy-Org#17664 (the type-only `BillingSession` core change this
consumer surfaced, split out of this PR) on top of the Phase 3
integration branch (`jaewon/fe-2227-phase3-integration`); slice 1 of
FE-2216, top-up only; flag default off, so an unflagged build sees no
behavior change.

First in-app consumer of `@comfyorg/account/billing`: with
`billing_sdk_topup_enabled` on, top-up creation, hosted/in-page
verification, resume, and the balance/capability refresh run on the
SDK's operation lifecycle instead of `billingOperationStore`'s poller.
Existing billing test suites are untouched and pass.

Linear: https://linear.app/comfyorg/issue/FE-2216

## How

- `billing_sdk_topup_enabled`: server flag resolved fail-closed,
declared exactly like `embeddedCheckoutEnabled` (enum, getter, telemetry
evaluation).
- Composition root
`src/platform/workspace/billing/sdk/createBillingSdk.ts` (ports in, SDK
out): `createSessionBillingTransport` over the auth store's one
`SessionClient` with `resolveUrl = workspaceApiUrl` and the store's own
mint target, the three Phase 2 readers,
`createBillingOperationLifecycle` with `pointerStorage: sessionStorage`,
`embeddedCheckoutAvailable = embeddedCheckoutEnabled &&
VITE_STRIPE_PUBLISHABLE_KEY`, the top-up command, and `driveChallenge`
over a lazily loaded `loadStripe` port.
- `useBillingSdkStore` (Pinia, once per app) wires it: one
`visibilitychange`/`focus` handler calling `lifecycle.wake()`, the SDK
telemetry mapped onto `trackBillingEvent`'s `operation` shape
(`billingSdkTelemetry.ts`), progress toast, one auto-driven in-page
challenge per operation, and, for an operation this tab reattached to,
the refresh / dialog close / settings open / toast the poller performs
today.
- `topupOperationView.ts` projects SDK state onto the operation record
the dialog reads and `TopupResult` onto the `CreateTopupResponse` it
handles (`ok` → `completed`, `declined` → `failed`, refusals →
`WorkspaceApiError` with the code, so the dialog's `NO_PAYMENT_METHOD`
copy still fires).
- `useWorkspaceBilling.topup()` and its pending-op recovery in
`fetchStatus()` branch on the flag; the flag-off body is unchanged. The
dialog consults `useTopupOperation()` for `isAddingCredits` /
`topupActionOperation` / retry / dismiss (6 lines in the script;
`handleBuy` untouched) — projecting into the poller's store would have
started its own polling loop on the same id.
- `workspaceAuthStore` exposes `getUnifiedSessionClient()` and
`getUnifiedMintWorkspaceId()`; no second session client.
- Package (type-only): `BillingSession = Pick<SessionClient,
'getSnapshot' | 'subscribe' | 'ensureFresh' | 'remint'>` replaces
`SessionClient` in the billing option types. The app's client is
`SessionClient<User>` and `attachIdentity` is contravariant in the user,
so the first real consumer could not be typed against the full client.
- Tests: dual-path suites for the wrapper
(`useWorkspaceBilling.sdk.test.ts`), the dialog adapter, the store, the
projections, the telemetry mapping, and the composition root over a fake
session + `fetch` (bearer, idempotency key, mint target, pointer
storage, port-driven challenge). Flag test mirrors
`embeddedCheckoutEnabled`.

Not routed through the SDK without touching call sites (listed, not
faked):

- `topup_id`: the SDK surfaces only `billing_op_id`; the projected
response carries `topup_id: ''`. Nothing reads it.
- Unsettled outcomes (`timed_out`, `reconciliation_needed`): the wrapper
resolves `undefined`, which the dialog reports as `failure_category:
'unknown'` rather than the poller's `operation.timeout` /
`reconciliation_needed`. The timeout toast still shows and the
reconciliation id stays visible through the operation view.
- Refusals without an HTTP status (`NO_PAYMENT_METHOD` — the SDK drops
the status; capability denial; invalid amount; route absent) are
bucketed `network` by `categorizeBillingApiError` instead of
`api_rejected`. Follow-up for 3C: carry `httpStatus` on
`TopupNoPaymentMethod`.
- Telemetry for a dialog-issued top-up is emitted by the dialog exactly
as before; the SDK's events are forwarded only for `resumed` operations.
If `begin` adopts a backend-pending top-up under a dialog click, both
report it.
- Resume is triggered from `fetchStatus()` only when the server reports
a pending top-up; the tab pointer alone (server unreachable) is not
probed on load.
- The rail is fixed when the dialog opens; a flag flip mid-operation
does not move a live operation between observers.
- Failure toast detail for SDK refusals is the generic
`credits.topUp.unknownError` copy (no server text, by design); an
unloadable Stripe port fails the challenge with the generic
authentication copy rather than `authenticationUnavailable`.
- The wrapper does not hold `isLoading` on the SDK path (it resolves at
settlement); the dialog locks itself.

Size: ~560 new non-test lines + ~115 modified (27 in the package). The
composition root is 115 lines; the Pinia wiring is the bulk. Splitting
root + package narrowing + auth accessors + flag into a flag-less parent
PR is possible if preferred.

## AS-IS / TO-BE

No UI surface change, no screenshots.

- AS-IS: `topup()` posts through `workspaceApi`, the dialog hands a
`pending` id to `billingOperationStore`, which polls, drives Stripe, and
refreshes.
- TO-BE (flag on): `topup()` runs
`createTopupCommand(...).createTopupCheckout` on the SDK lifecycle; the
dialog reads the same operation shape from `useTopupOperation()`; the
SDK store owns wake, challenge, toast, and resumed-operation effects.
Flag off: byte-identical call path.



## Stack (2026-09-14)

Merge top-down. After a parent is squash-merged, rebase each child with
`git rebase --onto origin/main <parent tip>` and force-push; GitHub
retargets the base. Solid edges are code dependencies, dashed edges are
sequencing.

```mermaid
flowchart TD
  P12["Phase 1 + 2 merged<br/>Comfy-Org#17436 · Comfy-Org#17442"] --> C["FE-2227 Phase 3 core<br/>Comfy-Org#17655 · base main"]
  C --> P0["PR 0 coded error bodies + 3DS driver<br/>Comfy-Org#17656"]
  P0 --> A["FE-2214 top-up command<br/>Comfy-Org#17657"]
  P0 --> B1["FE-2223 B1 subscription commands<br/>Comfy-Org#17658"]
  B1 --> B2["FE-2223 B2 eight-state projection<br/>Comfy-Org#17659"]
  A --> I["Integration, do not merge<br/>Comfy-Org#17660"]
  B2 --> I
  I --> V1["FE-2215 @comfyorg/account-ui composables<br/>Comfy-Org#17662"]
  V1 --> V2["FE-2215 CheckoutSteps<br/>Comfy-Org#17663"]
  I --> SES["core: narrowed BillingSession type<br/>Comfy-Org#17664"]
  SES --> AD1["FE-2216 slice 1 top-up behind a flag<br/>Comfy-Org#17665"]
  AD1 -.-> AD2["FE-2216 slice 2 subscription<br/>needs previewSubscribe + plan-change decision"]
  AD1 --> E["FE-2217 Phase 6 evidence"]
  S["FE-2211 salvage tag d059104<br/>before 2026-09-30"] -.-> E
  BW["billing-web Comfy-Org#17370 → Comfy-Org#17574"] --> H["FE-2218 Phase 7 separate origin"]
  AD1 --> H
  V2 -.-> H
  AD1 -.-> SPLIT["account-core / account-ui rename PR"]
  SPLIT -.-> H
```
pull Bot pushed a commit to Mu-L/ComfyUI_frontend that referenced this pull request Sep 15, 2026
…(FE-2215) (Comfy-Org#17663)

## Why

Stacked on the FE-2215 composables PR
(`jaewon/fe-2215-phase-4-new-view-package-for-billing-composables-and`),
itself stacked on the Phase 3 integration branch
(`jaewon/fe-2227-phase3-integration`, PR 0 + Comfy-Org#17657 + Comfy-Org#17659); retarget
once each parent lands.

Second half of Phase 4: the unstyled `CheckoutSteps` component, split
out of the composables PR to keep both under the size guard.

- Linear: https://linear.app/comfyorg/issue/FE-2215

## How

`packages/account-ui/src/billing/CheckoutSteps.vue`, ported from the PoC
`vue/CheckoutSteps.ts` onto the merged `PaymentProjection` +
`paymentCopyKeys`/`createPaymentCopy`:

- Takes the `projection` (eight-state, from `useTopUp`/`useCheckout`), a
`copy` prop of host-localized overrides by approved `PaymentCopyKey`,
`disabled`, and class props (`rootClass`, `headerClass`, `bodyClass`,
`reasonClass`, `safetyClass`, `actionsClass`, `actionClass`) the way
`PasswordRules`/`SocialAuthButtons` do.
- Renders header, body, the coded reason when the projection carries
one, and the safety line only when the projection's `noChargeConfirmed`
unlocks it (a host override of that line is ignored by
`createPaymentCopy`).
- Default actions per step from the approved copy: `verifying` →
continue verification, `declined`/`processing_error`/`canceled` → retry.
Emits `retry`, `cancel`, `continue-verification`;
`header`/`body`/`actions` slots receive the projection, copy key/text,
and the callbacks so a host lays out its own controls.
- Raw backend or provider text can never reach the template: every
string is looked up by key in the copy table.

Adds `@testing-library/user-event` to the package devDependencies
(lockfile updated) and the two index exports.

Tests (6): approved copy with host overrides and class props, safety
line gated by the projection only, default actions and their emits, no
action on success / nothing while disabled, slot scope and callbacks.

## AS-IS / TO-BE

No styled UI surface, no screenshots (the component is unstyled by
design; `data-billing-step` and `data-copy-key` attributes are the only
markers).

- AS-IS: hosts render the projection themselves.
- TO-BE: one shared unstyled section per projection state with the
approved coded copy, styled and laid out by each host.



## Stack (2026-09-14)

Merge top-down. After a parent is squash-merged, rebase each child with
`git rebase --onto origin/main <parent tip>` and force-push; GitHub
retargets the base. Solid edges are code dependencies, dashed edges are
sequencing.

```mermaid
flowchart TD
  P12["Phase 1 + 2 merged<br/>Comfy-Org#17436 · Comfy-Org#17442"] --> C["FE-2227 Phase 3 core<br/>Comfy-Org#17655 · base main"]
  C --> P0["PR 0 coded error bodies + 3DS driver<br/>Comfy-Org#17656"]
  P0 --> A["FE-2214 top-up command<br/>Comfy-Org#17657"]
  P0 --> B1["FE-2223 B1 subscription commands<br/>Comfy-Org#17658"]
  B1 --> B2["FE-2223 B2 eight-state projection<br/>Comfy-Org#17659"]
  A --> I["Integration, do not merge<br/>Comfy-Org#17660"]
  B2 --> I
  I --> V1["FE-2215 @comfyorg/account-ui composables<br/>Comfy-Org#17662"]
  V1 --> V2["FE-2215 CheckoutSteps<br/>Comfy-Org#17663"]
  I --> SES["core: narrowed BillingSession type<br/>Comfy-Org#17664"]
  SES --> AD1["FE-2216 slice 1 top-up behind a flag<br/>Comfy-Org#17665"]
  AD1 -.-> AD2["FE-2216 slice 2 subscription<br/>needs previewSubscribe + plan-change decision"]
  AD1 --> E["FE-2217 Phase 6 evidence"]
  S["FE-2211 salvage tag d059104<br/>before 2026-09-30"] -.-> E
  BW["billing-web Comfy-Org#17370 → Comfy-Org#17574"] --> H["FE-2218 Phase 7 separate origin"]
  AD1 --> H
  V2 -.-> H
  AD1 -.-> SPLIT["account-core / account-ui rename PR"]
  SPLIT -.-> H
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants