Repository navigation
feat(account): subscription commands on the shared billing lifecycle (FE-2223) - #17658
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 2000 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🌐 Website E2ETip All tests passed.
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-15T15:54:39.317Z",
"gitSha": "176b3f11dfb5a98f5dfb3422d836c6ef38a4da2c",
"branch": "jaewon/fe-2223-phase-3b-subscription-commands-and-eight-state-payment",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2038.6740000000145,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.992000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 394.844,
"heapDeltaBytes": -6776536,
"heapUsedBytes": 55433012,
"domNodes": -264,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 8.684000000000001,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2006.3959999999952,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.729000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 364.78400000000005,
"heapDeltaBytes": -5810532,
"heapUsedBytes": 55831448,
"domNodes": -259,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 8.676000000000004,
"eventListeners": -154,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1841.5259999999307,
"styleRecalcs": 74,
"styleRecalcDurationMs": 27.285,
"layouts": 14,
"layoutDurationMs": 4.047999999999999,
"taskDurationMs": 846.1360000000001,
"heapDeltaBytes": 16761440,
"heapUsedBytes": 78035672,
"domNodes": -264,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 165.132,
"eventListeners": -156,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1869.613999999956,
"styleRecalcs": 76,
"styleRecalcDurationMs": 32.637,
"layouts": 14,
"layoutDurationMs": 4.534,
"taskDurationMs": 889.375,
"heapDeltaBytes": 339756,
"heapUsedBytes": 62580704,
"domNodes": -264,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 174.574,
"eventListeners": -186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1723.508000000038,
"styleRecalcs": 32,
"styleRecalcDurationMs": 16.067999999999998,
"layouts": 6,
"layoutDurationMs": 1.2920000000000003,
"taskDurationMs": 337.44800000000004,
"heapDeltaBytes": 2195512,
"heapUsedBytes": 64354088,
"domNodes": 77,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 10.863999999999999,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1722.368000000074,
"styleRecalcs": 31,
"styleRecalcDurationMs": 15.630999999999998,
"layouts": 6,
"layoutDurationMs": 1.028,
"taskDurationMs": 333.76399999999995,
"heapDeltaBytes": 2164208,
"heapUsedBytes": 64413012,
"domNodes": 76,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 10.55,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 644.8730000000751,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.346999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 449.50500000000005,
"heapDeltaBytes": 17911760,
"heapUsedBytes": 79939912,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 170.859,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 626.529000000005,
"styleRecalcs": 13,
"styleRecalcDurationMs": 8.884000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 442.00899999999996,
"heapDeltaBytes": 17997232,
"heapUsedBytes": 79833840,
"domNodes": 22,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 167.104,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2032.0649999999887,
"styleRecalcs": 6,
"styleRecalcDurationMs": 7.644000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 592.4169999999999,
"heapDeltaBytes": 3595940,
"heapUsedBytes": 82965996,
"domNodes": -247,
"jsHeapTotalBytes": -794624,
"scriptDurationMs": 31.679,
"eventListeners": -154,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2041.6020000000117,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.397999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 563.6009999999999,
"heapDeltaBytes": 3692152,
"heapUsedBytes": 83796480,
"domNodes": -248,
"jsHeapTotalBytes": -1318912,
"scriptDurationMs": 33.63099999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2290.691000000038,
"styleRecalcs": 65,
"styleRecalcDurationMs": 10.025000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1660.3400000000001,
"heapDeltaBytes": 3301628,
"heapUsedBytes": 83650268,
"domNodes": -254,
"jsHeapTotalBytes": 479232,
"scriptDurationMs": 870.9449999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2309.476000000018,
"styleRecalcs": 65,
"styleRecalcDurationMs": 9.593999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1662.6239999999998,
"heapDeltaBytes": 15284252,
"heapUsedBytes": 79457596,
"domNodes": -253,
"jsHeapTotalBytes": 1273856,
"scriptDurationMs": 872.764,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3455.7799999998906,
"styleRecalcs": 60,
"styleRecalcDurationMs": 9.584999999999999,
"layouts": 60,
"layoutDurationMs": 12.684000000000001,
"taskDurationMs": 1538.7979999999998,
"heapDeltaBytes": 11184484,
"heapUsedBytes": 77895364,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 787.7160000000001,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3475.4590000000007,
"styleRecalcs": 61,
"styleRecalcDurationMs": 10.161999999999997,
"layouts": 60,
"layoutDurationMs": 12.67,
"taskDurationMs": 1639.035,
"heapDeltaBytes": 9180528,
"heapUsedBytes": 74012568,
"domNodes": -258,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 765.3570000000001,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3147.230000000036,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.842000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1923.667,
"heapDeltaBytes": 22355968,
"heapUsedBytes": 88693540,
"domNodes": 0,
"jsHeapTotalBytes": 679936,
"scriptDurationMs": 982.862,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3076.144999999997,
"styleRecalcs": 41,
"styleRecalcDurationMs": 5.411000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1894.771,
"heapDeltaBytes": 21990932,
"heapUsedBytes": 90284112,
"domNodes": 2,
"jsHeapTotalBytes": 942080,
"scriptDurationMs": 966.5610000000001,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2001.367000000073,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.8060000000000012,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 535.0599999999998,
"heapDeltaBytes": 19944040,
"heapUsedBytes": 84949108,
"domNodes": -258,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 31.742999999999995,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2029.72299999999,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.107999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 559.4350000000001,
"heapDeltaBytes": -3288216,
"heapUsedBytes": 83981720,
"domNodes": -251,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 35.43399999999999,
"eventListeners": -154,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 589.9069999999256,
"styleRecalcs": 47,
"styleRecalcDurationMs": 9.985999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 396.853,
"heapDeltaBytes": 13017328,
"heapUsedBytes": 76570140,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 139.847,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 547.7240000000165,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.347999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 367.15700000000004,
"heapDeltaBytes": 13576800,
"heapUsedBytes": 76999284,
"domNodes": 20,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 144.81,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2004.128000000037,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.537,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 455.89699999999993,
"heapDeltaBytes": 9320852,
"heapUsedBytes": 72732956,
"domNodes": -275,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 7.803000000000001,
"eventListeners": -200,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 1990.7120000000305,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.622,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 471.79400000000004,
"heapDeltaBytes": 6990676,
"heapUsedBytes": 70055624,
"domNodes": -277,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 8.649000000000001,
"eventListeners": -200,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1722.6890000000594,
"styleRecalcs": 78,
"styleRecalcDurationMs": 27.358,
"layouts": 18,
"layoutDurationMs": 4.919,
"taskDurationMs": 770.602,
"heapDeltaBytes": 9216440,
"heapUsedBytes": 72662072,
"domNodes": -275,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 106.78199999999998,
"eventListeners": -202,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1707.5979999999618,
"styleRecalcs": 77,
"styleRecalcDurationMs": 27.419,
"layouts": 18,
"layoutDurationMs": 5.641,
"taskDurationMs": 788.667,
"heapDeltaBytes": 12054120,
"heapUsedBytes": 75085892,
"domNodes": -278,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 111.80499999999999,
"eventListeners": -202,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1384.996000000001,
"styleRecalcs": 17,
"styleRecalcDurationMs": 30.119000000000007,
"layouts": 5,
"layoutDurationMs": 13.220999999999997,
"taskDurationMs": 942.8269999999999,
"heapDeltaBytes": 19323264,
"heapUsedBytes": 101246452,
"domNodes": 13587,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 30.177000000000003,
"eventListeners": 2387,
"totalBlockingTimeMs": 147,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8204.752999999982,
"styleRecalcs": 246,
"styleRecalcDurationMs": 33.074,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5172.886,
"heapDeltaBytes": 99656,
"heapUsedBytes": 79563300,
"domNodes": -250,
"jsHeapTotalBytes": -569344,
"scriptDurationMs": 2785.6389999999997,
"eventListeners": -138,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8348.123999999985,
"styleRecalcs": 246,
"styleRecalcDurationMs": 32.179,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5741.121,
"heapDeltaBytes": -3893496,
"heapUsedBytes": 74652832,
"domNodes": -249,
"jsHeapTotalBytes": 741376,
"scriptDurationMs": 2749.369,
"eventListeners": -168,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16957.00599999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16407.351,
"heapDeltaBytes": -20943728,
"heapUsedBytes": 180638876,
"domNodes": -6542,
"jsHeapTotalBytes": 2039808,
"scriptDurationMs": 272.106,
"eventListeners": -7478,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16865.737999999965,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16316.868999999997,
"heapDeltaBytes": -16205320,
"heapUsedBytes": 178845512,
"domNodes": -6542,
"jsHeapTotalBytes": -581632,
"scriptDurationMs": 263.997,
"eventListeners": -7478,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20531.967000000008,
"styleRecalcs": 165,
"styleRecalcDurationMs": 17.934000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20237.600000000002,
"heapDeltaBytes": -20126960,
"heapUsedBytes": 187287056,
"domNodes": -6542,
"jsHeapTotalBytes": -110592,
"scriptDurationMs": 886.129,
"eventListeners": -7472,
"totalBlockingTimeMs": 32,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20034.913999999957,
"styleRecalcs": 165,
"styleRecalcDurationMs": 16.762,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19622.909,
"heapDeltaBytes": -30877384,
"heapUsedBytes": 187795528,
"domNodes": -6542,
"jsHeapTotalBytes": -5218304,
"scriptDurationMs": 859.194,
"eventListeners": -7474,
"totalBlockingTimeMs": 16,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6126.220000000103,
"styleRecalcs": 20,
"styleRecalcDurationMs": 82.88900000000002,
"layouts": 20,
"layoutDurationMs": 23.99699999999999,
"taskDurationMs": 5999.217999999999,
"heapDeltaBytes": -26105608,
"heapUsedBytes": 169983472,
"domNodes": -6542,
"jsHeapTotalBytes": 14831616,
"scriptDurationMs": 109.73400000000001,
"eventListeners": -7476,
"totalBlockingTimeMs": 418,
"frameDurationMs": 17.779999999999987,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6031.43799999998,
"styleRecalcs": 20,
"styleRecalcDurationMs": 77.95699999999997,
"layouts": 20,
"layoutDurationMs": 23.114999999999995,
"taskDurationMs": 5935.104,
"heapDeltaBytes": -26155760,
"heapUsedBytes": 192684992,
"domNodes": -6542,
"jsHeapTotalBytes": 11628544,
"scriptDurationMs": 108.10099999999998,
"eventListeners": -7474,
"totalBlockingTimeMs": 393,
"frameDurationMs": 18.329999999999988,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8349.623999999949,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8116.590999999999,
"heapDeltaBytes": 20220148,
"heapUsedBytes": 194656248,
"domNodes": 0,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 126.03699999999995,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8372.598000000038,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8208.937,
"heapDeltaBytes": 15622020,
"heapUsedBytes": 188393112,
"domNodes": 0,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 150.22099999999995,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 133.88099999997394,
"styleRecalcs": 8,
"styleRecalcDurationMs": 19.077000000000005,
"layouts": 4,
"layoutDurationMs": 2.3160000000000003,
"taskDurationMs": 99.48500000000001,
"heapDeltaBytes": 3235252,
"heapUsedBytes": 65075436,
"domNodes": 136,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.409999999999998,
"eventListeners": 35,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 112.57100000000264,
"styleRecalcs": 9,
"styleRecalcDurationMs": 15.847,
"layouts": 2,
"layoutDurationMs": 1.171,
"taskDurationMs": 77.344,
"heapDeltaBytes": 2949032,
"heapUsedBytes": 64568944,
"domNodes": 127,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.096999999999999,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## jaewon/fe-2227-phase-3-core-sdk-owned-billing-operation-lifecycle-routing #17658 +/- ##
=============================================================================================================
+ Coverage 82.46% 82.73% +0.26%
=============================================================================================================
Files 2792 2790 -2
Lines 140049 140579 +530
Branches 37571 35963 -1608
=============================================================================================================
+ Hits 115496 116310 +814
+ Misses 23377 23181 -196
+ Partials 1176 1088 -88
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 91 files with indirect coverage changes 🚀 New features to boost your workflow:
|
4e6ff48 to
8c24dbc
Compare
2486008 to
3d79ffe
Compare
…FE-2214) (#17689) ## Why FE-2214's done-when says all three current top-up hosts can integrate the top-up command. #17657 covers ComfyUI_frontend's route (`POST /api/billing/topup`, an operation to poll). Workshop (`apps/website`) and Platform ship on the other route, `POST /api/billing/topup/checkout`: a provider-hosted Checkout session with no `billing_op_id`, credits landing through a webhook. That route could not be decoded with generated schemas until the ingest-types regen #17396 merged; it now carries `CreateTopupCheckoutRequest` / `CreateTopupCheckoutResponse`, so this is the 3A-2 follow-up recorded on FE-2214. Stacked on #17657 (FE-2214 top-up command); merge after it. ## How `createTopupCommand` gains a second method on the same surface, `createHostedTopupCheckout({ amountCents, returnUrl, signal? })`: - input is validated by the generated `zCreateTopupCheckoutRequest`; `INVALID_AMOUNT` / `INVALID_RETURN_URL` are returned before anything is sent - the same capability gate as the in-app command (`ACCESS_DENIED` carrying the server's denial), then the pre-purchase balance is read - one idempotency key per attempt, in the body and on the request; a 404 maps to `NOT_AVAILABLE` so a host keeps its legacy path while `topup_checkout_enabled` is off - `checkout_url` must be https (`validateActionUrl`, the same rule every lifecycle continuation obeys), otherwise `MALFORMED_RESPONSE`; `session_id` passes through when present - nothing is adopted on the lifecycle and no operation id is invented (FE-2214 invariant): the result is `{ url, sessionId?, baselineMicros? }`. The host executes its `OpenUrlMode` on `url` (Workshop pre-opens a tab, Platform redirects) and on return arms the existing `createBalanceWatch` with `baselineMicros`, which is how the test proves completion `readTopupEligibility` (from the fallow split on #17657) now returns the two failures it can actually produce, which is what lets the hosted result union exclude `NO_PAYMENT_METHOD`. ## AS-IS / TO-BE AS-IS: `TopupCommand` exposes `createTopupCheckout` only; Workshop keeps its own `createTopUpCheckout` fetch with a hand-written `zTopUpCheckout` schema, and Platform its own. TO-BE: `TopupCommand` exposes `createHostedTopupCheckout` over the generated contract; a host adapter is a thin wrapper (validate → gate → POST → open → balance watch). No UI in this PR, so no screenshots; the consumer cutover for Workshop is a separate slice. ## Testing Eight new tests under `createHostedTopupCheckout` in `topup.test.ts`: success shape, request body and idempotency key, and no lifecycle operation; `can_top_up` false without a POST; amount and return-URL rejection without a request; 404 → `NOT_AVAILABLE`; missing or non-https URL → `MALFORMED_RESPONSE`; optional session id and baseline omitted when unknown; baseline handed to a balance watch that reconciles on return; no server or provider text on the failure path. Billing core suite 187 passing; oxlint, eslint, oxfmt, `vue-tsc` clean. ## Stack (2026-09-15) Merge top-down. After a parent is squash-merged, rebase each child with `git rebase --onto origin/main <parent tip>` and force-push; GitHub retargets the base. Solid edges are code dependencies, dashed edges are sequencing. ```mermaid flowchart TD P12["Phase 1 + 2 merged<br/>#17436 · #17442 · ingest-types regen #17396"] --> C["FE-2227 Phase 3 core<br/>#17655 · base main"] C --> P0["PR 0 coded error bodies + 3DS driver<br/>#17656"] P0 --> A["FE-2214 top-up command<br/>#17657"] A --> A2["FE-2214 3A-2 hosted top-up checkout<br/>this PR"] P0 --> B1["FE-2223 B1 subscription commands<br/>#17658"] B1 --> B2["FE-2223 B2 eight-state projection<br/>#17659"] A --> I["Integration, do not merge<br/>#17660"] B2 --> I I --> V1["FE-2215 @comfyorg/account-ui composables<br/>#17662"] V1 --> V2["FE-2215 CheckoutSteps<br/>#17663"] I --> SES["core: narrowed BillingSession type<br/>#17664"] SES --> AD1["FE-2216 slice 1 top-up behind a flag<br/>#17665"] A2 -.-> WS["Workshop adapter over createHostedTopupCheckout<br/>later slice"] AD1 -.-> AD2["FE-2216 slice 2 subscription<br/>needs previewSubscribe (FE-2331)"] AD1 --> E["FE-2217 Phase 6 evidence"] BW["billing-web #17370 → #17574"] --> H["FE-2218 Phase 7 separate origin"] AD1 --> H H --> H8["FE-2331 Phase 8 hosted surfaces"] ``` Design: [Billing SDK implementation plan (V2)](https://app.notion.com/p/3d86d73d36508152b92cdbdfdfe83ac8). Linear: FE-2214.
christian-byrne
left a comment
There was a problem hiding this comment.
source_url: #17658
type: github_pr_review
date_accessed: 2026-09-15
relevance: 5
note: Review posted on PR 17658 (subscription commands, FE-2223 B1) — the non-idempotent POST finding.
Reviewed at the head of the FE-2223 B1 branch. One finding, and it is the one this stack has been walking toward since Phase 1.
openPaymentPortal is the first non-idempotent POST, and nothing reads the flag built for it
openPaymentPortal calls post() with three arguments — no key:
const response = await post(
PAYMENT_PORTAL_ROUTE,
input.returnUrl === undefined ? {} : { return_url: input.returnUrl },
(body) => zPaymentPortalResponse.safeParse(body)
)which is a deliberate and correct call: the contract has no key field and a portal session is not a mutation. The description says so.
The consequence is the problem. Follow it through the stack:
- Transport —
replayable = request.method === 'GET' || request.idempotencyKey !== undefined→false. A 401 is not retried, and the transport setsauthenticationRetrySkipped: trueon the response. readValidatedBillingResponse— maps the non-2xx throughcodeForHttpStatus(401)and drops the flag.codeForHttpStatus— returnsACCESS_DENIED, under this comment:
// A 401 only reaches here having already survived the transport's single
// re-mint and retry, so it is a real refusal rather than an expired token.That comment was true until this PR. It is now false for /billing/payment-portal, which is the only route in the codebase that reaches it without a retry.
So: a user's workspace token expires, they click through to manage their payment method, the POST 401s, nothing re-mints, and they are told they do not have permission — on the exact action that would let them fix a failing payment. ACCESS_DENIED is a permanent verdict; an expired token is the most recoverable state there is.
authenticationRetrySkipped exists precisely for this — it was added on #17436 in response to this seam, so a caller could tell "not retried" from "genuinely refused". Grepping the whole Phase 3 stack for it:
pr-17655: 0 pr-17656: 0 pr-17657: 0 pr-17658: 0
The affordance was built, the case has now arrived, and nothing connects them.
The fix I would suggest is in readValidatedBillingResponse rather than here, because it closes the class rather than this one call site: when the response carries authenticationRetrySkipped, a 401 should not become ACCESS_DENIED. REQUEST_FAILED would at least put it in the retryable bucket; a distinct code would be better if a command wants to prompt a re-auth. Either way httpStatus.ts's comment needs to stop claiming something that is no longer true.
Not asking you to add a key to the portal call — omitting it is right.
Smaller note
The two command PRs match serverCode differently: #17657 compares a named constant (NO_PAYMENT_METHOD_SERVER_CODE), this one compares inline literals ('NO_ACTIVE_SUBSCRIPTION', 'REACTIVATION_CONFIRMATION_REQUIRED'). Both are closed sets compared for equality, so the convention holds either way and this is style — but a shared constant per code would make the allowlist greppable as a set, which is the property the convention is actually trading on.
Verified
- The description describes the replay gate accurately here — "one key per attempt … the transport's 401 replay gate". Worth saying because the equivalent sentence on #17657 inverts it; this one is right.
subscribe,resubscribeandcanceleach mint a fresh key per attempt and pass it in the body and on the request, so the 401 replay stays backend-deduplicated on all three.- 888 test lines against 341 of implementation, and the server-code paths are exercised rather than asserted.
CI is green and I am taking it as the verification run; my worktree still cannot resolve zod through this package's workspace links, so I read rather than ran.
|
Valid, and you traced it exactly: the transport sets Fixed in c37c78c, in the reader as you suggested, so it closes the class:
Regression tests, both red on the previous code (
On the smaller note: the four server codes this module matches are now named constants next to the routes ( 191 tests pass across |
…river (FE-2227) (#17656) ## Why Stacked on #17655 (FE-2227); merge after it. The two Phase 3 command PRs — top-up ([FE-2214](https://linear.app/comfyorg/issue/FE-2214)) and subscription ([FE-2223](https://linear.app/comfyorg/issue/FE-2223)) — both need to act on the server's coded error (`NO_PAYMENT_METHOD`, `ALREADY_CANCELED`, …) and both need to drive an embedded 3DS challenge through the lifecycle. FE-2223 may not depend on FE-2214, so the shared pieces land here, on the core, and each command PR stacks on this one. ## How - `BillingFailure.serverCode` (additive, optional): `readValidatedBillingResponse` decodes a non-2xx body with the generated `zErrorResponse` and carries only its `code`. The `message` is read by the schema and dropped in `billingErrorBody.ts`, so server text still cannot travel into the SDK. The codes are `z.string()` in the generated contract, so each command owns a closed allowlist of the codes it acts on. - `driveEmbeddedChallenge(lifecycle, operationId, port)`: `reportChallengeStarted` → `port.handleNextAction(clientSecret)` → `reportChallengeSettled`. The port is Stripe's `handleNextAction` shape; no provider SDK is imported in core, the host injects the object. The unmoved-intent denylist (`requires_payment_method | requires_action | canceled` → failed) is ported from `billingOperationStore.runPaymentIntentAction` on this repo's `main` (`src/platform/workspace/stores/billingOperationStore.ts:51-55`, `:555`; landed in `a39b1ce9fa3`, 2026-09-03 — it is not in `cf-main`), and fails toward the server: an unknown status reports completed and the next poll corrects it. ## AS-IS / TO-BE AS-IS: a command sees only `REQUEST_FAILED` + `httpStatus` for a 4xx and cannot tell "no payment method" from "declined"; each command PR would re-implement the 3DS drive over `reportChallenge*`. TO-BE: `result.serverCode === 'NO_PAYMENT_METHOD'` is one comparison; the challenge drive is one call. No UI surface, so no screenshots. ## Testing `packages/account` 473/473. Named tests: coded error carried without its message; non-contract error body yields no code; moved intent → completed; error / unmoved intent / throw → failed; nothing driven without a required embedded challenge. ## Stack (2026-09-14) Merge top-down. After a parent is squash-merged, rebase each child with `git rebase --onto origin/main <parent tip>` and force-push; GitHub retargets the base. Solid edges are code dependencies, dashed edges are sequencing. ```mermaid flowchart TD P12["Phase 1 + 2 merged<br/>#17436 · #17442"] --> C["FE-2227 Phase 3 core<br/>#17655 · base main"] C --> P0["PR 0 coded error bodies + 3DS driver<br/>#17656"] P0 --> A["FE-2214 top-up command<br/>#17657"] P0 --> B1["FE-2223 B1 subscription commands<br/>#17658"] B1 --> B2["FE-2223 B2 eight-state projection<br/>#17659"] A --> I["Integration, do not merge<br/>#17660"] B2 --> I I --> V1["FE-2215 @comfyorg/account-ui composables<br/>#17662"] V1 --> V2["FE-2215 CheckoutSteps<br/>#17663"] I --> SES["core: narrowed BillingSession type<br/>#17664"] SES --> AD1["FE-2216 slice 1 top-up behind a flag<br/>#17665"] AD1 -.-> AD2["FE-2216 slice 2 subscription<br/>needs previewSubscribe + plan-change decision"] AD1 --> E["FE-2217 Phase 6 evidence"] S["FE-2211 salvage tag d059104<br/>before 2026-09-30"] -.-> E BW["billing-web #17370 → #17574"] --> H["FE-2218 Phase 7 separate origin"] AD1 --> H V2 -.-> H AD1 -.-> SPLIT["account-core / account-ui rename PR"] SPLIT -.-> H ```
christian-byrne
left a comment
There was a problem hiding this comment.
c37c78c905 closes it, and at the layer I hoped for.
codeForHttpStatus now takes the response rather than a bare status, and a 401 the transport had to leave alone becomes REQUEST_FAILED instead of ACCESS_DENIED:
if (status === 401 && response.authenticationRetrySkipped) {
return 'REQUEST_FAILED'
}Fixing it there rather than in openPaymentPortal means every future non-idempotent POST inherits it — which matters, because the next one will be written by someone who never read this thread. Both call sites are updated, and the comment that had quietly become false now states the distinction it is actually making: "A 401 the transport re-minted and retried is a real refusal. One it had to leave alone … says only that the token had gone stale."
The test is at the right level too — openPaymentPortal against a 401 carrying authenticationRetrySkipped: true, asserting REQUEST_FAILED. That is the user-visible scenario rather than the mapping function in isolation.
You also took the style note: NO_ACTIVE_SUBSCRIPTION_SERVER_CODE and friends are named constants now, so the allowlist is greppable as a set across both command PRs rather than only in #17657.
Worth noting for the record that this seam was opened in Phase 1 and stayed theoretical for four PRs — authenticationRetrySkipped was added on #17436 for a case that did not exist yet, and the first route to hit it was this one. The affordance being already there is why the fix was three lines.
Approving. The branch is CONFLICTING after #17656 merged, so it needs a rebase before merge; nothing there is mine to hold on. CI is otherwise clean and I am taking it as the verification run — my worktree still cannot resolve zod through this package's workspace links.
…al (FE-2223) The transport marks a 401 it could not retry with authenticationRetrySkipped, but the response reader dropped the flag and mapped the status to ACCESS_DENIED. openPaymentPortal is the first non-replayable POST, so an expired token on the way to fix a payment method read as a permission refusal. Map that case to REQUEST_FAILED with the status kept, and name the server codes the subscription commands match on.
…FE-2214) (#17689) ## Why FE-2214's done-when says all three current top-up hosts can integrate the top-up command. #17657 covers ComfyUI_frontend's route (`POST /api/billing/topup`, an operation to poll). Workshop (`apps/website`) and Platform ship on the other route, `POST /api/billing/topup/checkout`: a provider-hosted Checkout session with no `billing_op_id`, credits landing through a webhook. That route could not be decoded with generated schemas until the ingest-types regen #17396 merged; it now carries `CreateTopupCheckoutRequest` / `CreateTopupCheckoutResponse`, so this is the 3A-2 follow-up recorded on FE-2214. Stacked on #17657 (FE-2214 top-up command); merge after it. ## How `createTopupCommand` gains a second method on the same surface, `createHostedTopupCheckout({ amountCents, returnUrl, signal? })`: - input is validated by the generated `zCreateTopupCheckoutRequest`; `INVALID_AMOUNT` / `INVALID_RETURN_URL` are returned before anything is sent - the same capability gate as the in-app command (`ACCESS_DENIED` carrying the server's denial), then the pre-purchase balance is read - one idempotency key per attempt, in the body and on the request; a 404 maps to `NOT_AVAILABLE` so a host keeps its legacy path while `topup_checkout_enabled` is off - `checkout_url` must be https (`validateActionUrl`, the same rule every lifecycle continuation obeys), otherwise `MALFORMED_RESPONSE`; `session_id` passes through when present - nothing is adopted on the lifecycle and no operation id is invented (FE-2214 invariant): the result is `{ url, sessionId?, baselineMicros? }`. The host executes its `OpenUrlMode` on `url` (Workshop pre-opens a tab, Platform redirects) and on return arms the existing `createBalanceWatch` with `baselineMicros`, which is how the test proves completion `readTopupEligibility` (from the fallow split on #17657) now returns the two failures it can actually produce, which is what lets the hosted result union exclude `NO_PAYMENT_METHOD`. ## AS-IS / TO-BE AS-IS: `TopupCommand` exposes `createTopupCheckout` only; Workshop keeps its own `createTopUpCheckout` fetch with a hand-written `zTopUpCheckout` schema, and Platform its own. TO-BE: `TopupCommand` exposes `createHostedTopupCheckout` over the generated contract; a host adapter is a thin wrapper (validate → gate → POST → open → balance watch). No UI in this PR, so no screenshots; the consumer cutover for Workshop is a separate slice. ## Testing Eight new tests under `createHostedTopupCheckout` in `topup.test.ts`: success shape, request body and idempotency key, and no lifecycle operation; `can_top_up` false without a POST; amount and return-URL rejection without a request; 404 → `NOT_AVAILABLE`; missing or non-https URL → `MALFORMED_RESPONSE`; optional session id and baseline omitted when unknown; baseline handed to a balance watch that reconciles on return; no server or provider text on the failure path. Billing core suite 187 passing; oxlint, eslint, oxfmt, `vue-tsc` clean. ## Stack (2026-09-15) Merge top-down. After a parent is squash-merged, rebase each child with `git rebase --onto origin/main <parent tip>` and force-push; GitHub retargets the base. Solid edges are code dependencies, dashed edges are sequencing. ```mermaid flowchart TD P12["Phase 1 + 2 merged<br/>#17436 · #17442 · ingest-types regen #17396"] --> C["FE-2227 Phase 3 core<br/>#17655 · base main"] C --> P0["PR 0 coded error bodies + 3DS driver<br/>#17656"] P0 --> A["FE-2214 top-up command<br/>#17657"] A --> A2["FE-2214 3A-2 hosted top-up checkout<br/>this PR"] P0 --> B1["FE-2223 B1 subscription commands<br/>#17658"] B1 --> B2["FE-2223 B2 eight-state projection<br/>#17659"] A --> I["Integration, do not merge<br/>#17660"] B2 --> I I --> V1["FE-2215 @comfyorg/account-ui composables<br/>#17662"] V1 --> V2["FE-2215 CheckoutSteps<br/>#17663"] I --> SES["core: narrowed BillingSession type<br/>#17664"] SES --> AD1["FE-2216 slice 1 top-up behind a flag<br/>#17665"] A2 -.-> WS["Workshop adapter over createHostedTopupCheckout<br/>later slice"] AD1 -.-> AD2["FE-2216 slice 2 subscription<br/>needs previewSubscribe (FE-2331)"] AD1 --> E["FE-2217 Phase 6 evidence"] BW["billing-web #17370 → #17574"] --> H["FE-2218 Phase 7 separate origin"] AD1 --> H H --> H8["FE-2331 Phase 8 hosted surfaces"] ``` Design: [Billing SDK implementation plan (V2)](https://app.notion.com/p/3d86d73d36508152b92cdbdfdfe83ac8). Linear: FE-2214.
c37c78c to
68cf988
Compare
) ## Why Stacked on B1 (`jaewon/fe-2223-phase-3b-subscription-commands-and-eight-state-payment`, #17658) → PR 0 (`jaewon/fe-2227-core-error-codes-and-challenge-driver`, #17656) → #17655 (FE-2227); independent of FE-2214; merge after all parents. Phase 3B, part 2 of 2: the eight public payment states as a pure projection of one lifecycle operation, plus the copy keys behind them. Split out of B1 to keep each PR under the source budget. - Linear: https://linear.app/comfyorg/issue/FE-2223 ## How New `packages/account/src/core/billing/paymentProjection.ts` and `paymentCopy.ts` (+ tests), export lines appended to `index.ts`. No other core file is touched. `projectPaymentStep(operation | undefined, hostStep: 'select' | 'preview' | 'canceled')` → `{ step, reasonKey?, recoveryAction?, operationId?, noChargeConfirmed }` over the eight states `select | preview | verifying | canceled | declined | processing_error | payment_received_hold | success`. - No operation → the host's step. Pending: parked on the customer (`challenge` or `actionUrl`) → `verifying`; a retryable decline (`declineReason`, or this tab's failed challenge → `authentication_failed`) → `declined`; otherwise `preview`. `succeeded` → `success`; `failed` → `declined`, except `processing_error` / `generic` → `processing_error`; `timed_out` → `processing_error` (`generic`); `superseded` → `select`. - Reason keys are the generated `decline_reason` enum plus `checkout_expired` and `generic`; copy keys are `billing.reason.<key>`. No raw text can become a key. - `paymentCopy.ts` ports the PoC `copy.ts` semantics: `DEFAULT_PAYMENT_COPY`, `createPaymentCopy(overrides)` where the safety line `billing.safety.nothing_was_charged` is not host-overridable, and `paymentCopyKeys(projection)` which names the safety key only for `canceled` with `noChargeConfirmed`. - `noChargeConfirmed` is always `false`: the generated contract has no field that lets a terminal backend result guarantee no current or later charge (one short comment in code says so). Relates to the BE cancel endpoint work (BE-10064). Tests: every projection row (24 via `it.for`, including the host-cancel precedence rows and a sweep asserting `noChargeConfirmed` is never true and `payment_received_hold` is never produced) and the copy gate (3, including the PoC TP-12 port). ## Review focus Two decisions the plan left open, made here: 1. Lifecycle `reconciliation_needed` projects to `processing_error` (`generic`) with `operationId` surfaced, not to `payment_received_hold`. The contract cannot tell "paid, entitlement pending" from "needs a human"; the id is what support acts on. `payment_received_hold` stays in the public union and copy table but has no producing row until the backend distinguishes the two. 2. `canceled` is reached only through the host: `hostStep` accepts `'canceled'` for a cancel the host observed (closed page, dismissed challenge). A server verdict (`succeeded`, `failed`, `reconciliation_needed`) outranks it — a customer who backs out after the charge went through still sees the result — while pending, `timed_out`, and `superseded` yield to it. Ticket vs generated contract: - `checkout_expired` has no producing row: `BillingOpStatusResponse.status` has no `expired` value. The key and its copy are kept for the host and for the backend adding one. - `noChargeConfirmed` has no source field, so it is a `boolean` that is always `false` (a literal `false` type makes the copy gate dead by type and fails `no-unnecessary-condition`). ## AS-IS / TO-BE No UI surface, no screenshots. AS-IS: the PoC reducer derived these states from an invented operation status set (`expired`, `canceled`, `payment_received_hold`) and matched raw `error_message` text for reasons. TO-BE: a pure projection over the real `BillingOperationState`; hosts render `step`/`reasonKey`/`operationId` and localize by copy key. ## Stack (2026-09-14) Merge top-down. After a parent is squash-merged, rebase each child with `git rebase --onto origin/main <parent tip>` and force-push; GitHub retargets the base. Solid edges are code dependencies, dashed edges are sequencing. ```mermaid flowchart TD P12["Phase 1 + 2 merged<br/>#17436 · #17442"] --> C["FE-2227 Phase 3 core<br/>#17655 · base main"] C --> P0["PR 0 coded error bodies + 3DS driver<br/>#17656"] P0 --> A["FE-2214 top-up command<br/>#17657"] P0 --> B1["FE-2223 B1 subscription commands<br/>#17658"] B1 --> B2["FE-2223 B2 eight-state projection<br/>#17659"] A --> I["Integration, do not merge<br/>#17660"] B2 --> I I --> V1["FE-2215 @comfyorg/account-ui composables<br/>#17662"] V1 --> V2["FE-2215 CheckoutSteps<br/>#17663"] I --> SES["core: narrowed BillingSession type<br/>#17664"] SES --> AD1["FE-2216 slice 1 top-up behind a flag<br/>#17665"] AD1 -.-> AD2["FE-2216 slice 2 subscription<br/>needs previewSubscribe + plan-change decision"] AD1 --> E["FE-2217 Phase 6 evidence"] S["FE-2211 salvage tag d059104<br/>before 2026-09-30"] -.-> E BW["billing-web #17370 → #17574"] --> H["FE-2218 Phase 7 separate origin"] AD1 --> H V2 -.-> H AD1 -.-> SPLIT["account-core / account-ui rename PR"] SPLIT -.-> H ```
2543d7f
into
jaewon/fe-2227-phase-3-core-sdk-owned-billing-operation-lifecycle-routing
…FE-2214) (#17689) FE-2214's done-when says all three current top-up hosts can integrate the top-up command. #17657 covers ComfyUI_frontend's route (`POST /api/billing/topup`, an operation to poll). Workshop (`apps/website`) and Platform ship on the other route, `POST /api/billing/topup/checkout`: a provider-hosted Checkout session with no `billing_op_id`, credits landing through a webhook. That route could not be decoded with generated schemas until the ingest-types regen #17396 merged; it now carries `CreateTopupCheckoutRequest` / `CreateTopupCheckoutResponse`, so this is the 3A-2 follow-up recorded on FE-2214. Stacked on #17657 (FE-2214 top-up command); merge after it. `createTopupCommand` gains a second method on the same surface, `createHostedTopupCheckout({ amountCents, returnUrl, signal? })`: - input is validated by the generated `zCreateTopupCheckoutRequest`; `INVALID_AMOUNT` / `INVALID_RETURN_URL` are returned before anything is sent - the same capability gate as the in-app command (`ACCESS_DENIED` carrying the server's denial), then the pre-purchase balance is read - one idempotency key per attempt, in the body and on the request; a 404 maps to `NOT_AVAILABLE` so a host keeps its legacy path while `topup_checkout_enabled` is off - `checkout_url` must be https (`validateActionUrl`, the same rule every lifecycle continuation obeys), otherwise `MALFORMED_RESPONSE`; `session_id` passes through when present - nothing is adopted on the lifecycle and no operation id is invented (FE-2214 invariant): the result is `{ url, sessionId?, baselineMicros? }`. The host executes its `OpenUrlMode` on `url` (Workshop pre-opens a tab, Platform redirects) and on return arms the existing `createBalanceWatch` with `baselineMicros`, which is how the test proves completion `readTopupEligibility` (from the fallow split on #17657) now returns the two failures it can actually produce, which is what lets the hosted result union exclude `NO_PAYMENT_METHOD`. AS-IS: `TopupCommand` exposes `createTopupCheckout` only; Workshop keeps its own `createTopUpCheckout` fetch with a hand-written `zTopUpCheckout` schema, and Platform its own. TO-BE: `TopupCommand` exposes `createHostedTopupCheckout` over the generated contract; a host adapter is a thin wrapper (validate → gate → POST → open → balance watch). No UI in this PR, so no screenshots; the consumer cutover for Workshop is a separate slice. Eight new tests under `createHostedTopupCheckout` in `topup.test.ts`: success shape, request body and idempotency key, and no lifecycle operation; `can_top_up` false without a POST; amount and return-URL rejection without a request; 404 → `NOT_AVAILABLE`; missing or non-https URL → `MALFORMED_RESPONSE`; optional session id and baseline omitted when unknown; baseline handed to a balance watch that reconciles on return; no server or provider text on the failure path. Billing core suite 187 passing; oxlint, eslint, oxfmt, `vue-tsc` clean. Merge top-down. After a parent is squash-merged, rebase each child with `git rebase --onto origin/main <parent tip>` and force-push; GitHub retargets the base. Solid edges are code dependencies, dashed edges are sequencing. ```mermaid flowchart TD P12["Phase 1 + 2 merged<br/>#17436 · #17442 · ingest-types regen #17396"] --> C["FE-2227 Phase 3 core<br/>#17655 · base main"] C --> P0["PR 0 coded error bodies + 3DS driver<br/>#17656"] P0 --> A["FE-2214 top-up command<br/>#17657"] A --> A2["FE-2214 3A-2 hosted top-up checkout<br/>this PR"] P0 --> B1["FE-2223 B1 subscription commands<br/>#17658"] B1 --> B2["FE-2223 B2 eight-state projection<br/>#17659"] A --> I["Integration, do not merge<br/>#17660"] B2 --> I I --> V1["FE-2215 @comfyorg/account-ui composables<br/>#17662"] V1 --> V2["FE-2215 CheckoutSteps<br/>#17663"] I --> SES["core: narrowed BillingSession type<br/>#17664"] SES --> AD1["FE-2216 slice 1 top-up behind a flag<br/>#17665"] A2 -.-> WS["Workshop adapter over createHostedTopupCheckout<br/>later slice"] AD1 -.-> AD2["FE-2216 slice 2 subscription<br/>needs previewSubscribe (FE-2331)"] AD1 --> E["FE-2217 Phase 6 evidence"] BW["billing-web #17370 → #17574"] --> H["FE-2218 Phase 7 separate origin"] AD1 --> H H --> H8["FE-2331 Phase 8 hosted surfaces"] ``` Design: [Billing SDK implementation plan (V2)](https://app.notion.com/p/3d86d73d36508152b92cdbdfdfe83ac8). Linear: FE-2214.
…4) (#17657) ## Why Stacked on PR 0 (`jaewon/fe-2227-core-error-codes-and-challenge-driver`, #17656) → #17655 (FE-2227); merge after both. Phase 3A of the billing SDK: the top-up command mapped onto the shared operation lifecycle, covering both routes cloud exposes today. Only request/response mapping lives here — the status-read gate, single-flight, polling, routing, the pointer, failure meaning, and telemetry all come from the lifecycle in #17655/#17656 and are not duplicated. - Linear: https://linear.app/comfyorg/issue/FE-2214 ## How `packages/account/src/core/billing/topup.ts` — `createTopupCommand({ transport, lifecycle, capabilities, credits, idempotencyKey? })` returning two commands on one surface: **`createTopupCheckout({ amountCents, signal? })`** — the in-app route ComfyUI_frontend uses (`POST /billing/topup`, an operation to observe): 1. `capabilities.read()` → `can_top_up === false` ⇒ `{ status: 'error', code: 'ACCESS_DENIED', denial? }` without a POST. The server flag is the only gate; nothing is derived. 2. Amount validated with `zCreateTopupRequest`; the plain input object is what travels (the schema coerces to bigint, which the transport cannot serialize). 3. One fresh key per POST attempt, in the body (`idempotency_key`) and as `idempotencyKey` on the `BillingRequest`. Supplying that key is what makes the POST replayable at the transport's 401 gate (`replayable = method === 'GET' || idempotencyKey !== undefined`): the single 401 replay is safe *because* the same key travels in both places for the backend to deduplicate on. Backend dedup is load-bearing on this route, not incidental. A fresh key is minted per attempt, so two user-initiated top-ups never collide. 4. POST through `lifecycle.begin('topup', issue)`; the response is decoded with `zCreateTopupResponse` and its `billing_op_id` adopted regardless of `status`, so the first poll settles synchronous results and carries the coded decline. 5. Command-level `TopupResult` union: `ok` (terminal `succeeded` state embedded + `creditsReconciled`), `declined` (terminal `failed` state embedded: `declineReason`, `recoveryAction`, `retryable`), `unsettled` (`timed_out` / `reconciliation_needed` embedded), plus `error` codes — the core `BillingErrorCode`s untouched, and `NOT_AVAILABLE` (404 on the POST), `NO_PAYMENT_METHOD` (`serverCode`, with `recoveryAction: 'replace_payment_method'`), `INVALID_AMOUNT` (below the generated minimum; nothing sent). A `superseded` operation passes through as `SUPERSEDED`. 6. On `succeeded`: `capabilities.invalidate()` and a credits re-read; `creditsReconciled` compares it with the read taken before the POST. **`createHostedTopupCheckout({ amountCents, returnUrl, signal? })`** — the hosted route Workshop (`apps/website`) and Platform ship on (`POST /billing/topup/checkout`, a provider-hosted Checkout session with no operation; credits land through a webhook). Decodable since the ingest-types regen #17396 merged: 1. Input validated by the generated `zCreateTopupCheckoutRequest`; `INVALID_AMOUNT` / `INVALID_RETURN_URL` before anything is sent. 2. The same capability gate, then the pre-purchase balance is read. 3. One idempotency key per attempt, in the body and on the request; 404 → `NOT_AVAILABLE` so a host keeps its legacy path while `topup_checkout_enabled` is off. 4. `checkout_url` must be https (`validateActionUrl`, the rule every lifecycle continuation obeys), otherwise `MALFORMED_RESPONSE`; `session_id` passes through when present. 5. Nothing is adopted on the lifecycle and no operation id is invented: the result is `{ url, sessionId?, baselineMicros? }`. The host executes its `OpenUrlMode` on `url` (Workshop pre-opens a tab, Platform redirects) and on return arms `createBalanceWatch` with `baselineMicros`. `packages/account/src/core/billing/balanceWatch.ts` — `createBalanceWatch({ credits, baselineMicros? })`, the framework-free port of `src/composables/billing/topupBalanceRefresh.ts` (gaps `[0, 2, 5, 10, 20]s`, 15-minute lifetime, 5 scheduled runs, a single read per wake past the cap). No document listeners: the host calls `wake()` from its own focus/visibility signals. This is the completion path for the hosted command and the explicit fallback when no `billing_op_id` can be observed on the in-app one; the SDK never invents one. Raw server / Stripe text never reaches a result (asserted in the tests). Contract findings (generated contract wins; for FE-2211's TDD-correction list): - The ticket's `returnUrl` and "no `billing_op_id`" rows describe the hosted route, not `zCreateTopupRequest` (which has only `amount_cents`, `checkout_attempt_id`, `idempotency_key`). They are served by `createHostedTopupCheckout`. - `zCreateTopupResponse.billing_op_id` is required, so the in-app command's balance-watch fallback is tested against a `MALFORMED_RESPONSE` on the POST, not an invented id. - The plan's `credits.read({ forceRefresh })` does not exist: `CreditsReader.read` always requests, so it is called plainly. - `amount_cents` is `z.coerce.bigint()` on both request schemas; validated with `safeParse`, sent as the number. - `ErrorResponse.code` is `z.string()`, not an enum, so `NO_PAYMENT_METHOD` is an SDK-owned allowlist entry. Tests (`topup.test.ts`, `balanceWatch.test.ts`), one per ticket row for the in-app command: `can_top_up` false, saved payment method, needs 3DS (driven through PR 0's `driveEmbeddedChallenge`), no payment method, declined, unexpected error, payment received with credits pending, 404 → `NOT_AVAILABLE` (and a 404 while polling left to the lifecycle), fresh idempotency key per attempt, in the body and on the request, generated-schema rejection, invalidation on success, scope supersession passthrough, no-`billing_op_id` balance-watch fallback. For the hosted command: success shape with request body, idempotency key, and no lifecycle operation; `can_top_up` false without a POST; amount and return-URL rejection without a request; 404 → `NOT_AVAILABLE`; missing or non-https URL → `MALFORMED_RESPONSE`; optional session id and baseline omitted when unknown; baseline handed to a balance watch that reconciles on return; no server text on the failure path. Reload/resume, routing, timeout, and duplicate-poll coverage stays in the core suite. ## AS-IS / TO-BE No UI surface, no screenshots. - AS-IS: the SDK exposes the lifecycle but no command issues a top-up on it; the cloud app's `workspaceApi.createTopup` + `topupBalanceRefresh`, Workshop's `createTopUpCheckout` fetch with a hand-written schema, and Platform's own call remain the only paths. - TO-BE: `@comfyorg/account/billing` exports `createTopupCommand` (in-app and hosted top-up over the generated contract) and `createBalanceWatch`; each host adapter is a thin wrapper that reads a coded, text-free result. Consumer cutovers are separate slices (ComfyUI_frontend: #17665; Workshop and Platform: later). ## Stack (2026-09-15) Merge top-down. After a parent is squash-merged, rebase each child with `git rebase --onto origin/main <parent tip>` and force-push; GitHub retargets the base. Solid edges are code dependencies, dashed edges are sequencing. The hosted command (formerly #17689) is squashed into this PR. ```mermaid flowchart TD P12["Phase 1 + 2 merged<br/>#17436 · #17442 · ingest-types regen #17396"] --> C["FE-2227 Phase 3 core<br/>#17655 · base main"] C --> P0["PR 0 coded error bodies + 3DS driver<br/>#17656"] P0 --> A["FE-2214 top-up commands, in-app + hosted<br/>#17657"] P0 --> B1["FE-2223 B1 subscription commands<br/>#17658"] B1 --> B2["FE-2223 B2 eight-state projection<br/>#17659"] A --> I["Integration, do not merge<br/>#17660"] B2 --> I I --> V1["FE-2215 @comfyorg/account-ui composables<br/>#17662"] V1 --> V2["FE-2215 CheckoutSteps<br/>#17663"] I --> SES["core: narrowed BillingSession type<br/>#17664"] SES --> AD1["FE-2216 slice 1 top-up behind a flag<br/>#17665"] A -.-> WS["Workshop adapter over createHostedTopupCheckout<br/>consumer slice"] AD1 -.-> AD2["FE-2216 slice 2 subscription<br/>needs previewSubscribe (FE-2331)"] AD1 --> E["FE-2217 Phase 6 evidence"] BW["billing-web #17370 → #17574"] --> H["FE-2218 Phase 7 separate origin"] AD1 --> H V2 -.-> H H --> H8["FE-2331 Phase 8 hosted surfaces"] ```
…nt (FE-2227) (Comfy-Org#17655) ## Why Phase 3 Core of the billing half of `@comfyorg/account` ([FE-2210](https://linear.app/comfyorg/issue/FE-2210) / [FE-2227](https://linear.app/comfyorg/issue/FE-2227/phase-3-core-sdk-owned-billing-operation-lifecycle-routing-recovery)): the one operation lifecycle the top-up (FE-2214) and subscription (FE-2223) commands sit on, so neither implements its own poller, reducer, routing, or recovery. ## Where this sits in the plan Plan: [Billing SDK implementation plan (V2)](https://app.notion.com/p/3d86d73d36508152b92cdbdfdfe83ac8). Layer TDD: [Centralized Hosted Billing Application](https://app.notion.com/p/3d76d73d36508181951dfaa4f71dc8e5). | Phase | Issue | Deliverable | State | | --- | --- | --- | --- | | 1 | [FE-2212](https://linear.app/comfyorg/issue/FE-2212) | Billing ports and transport on the merged session client | Merged — Comfy-Org#17436 | | 2 | [FE-2213](https://linear.app/comfyorg/issue/FE-2213) | Read path: status, capabilities, credits | Merged — Comfy-Org#17442 | | 3 Core | [FE-2227](https://linear.app/comfyorg/issue/FE-2227) | Operation lifecycle, routing, recovery, fallback | **this PR** | | 3A | [FE-2214](https://linear.app/comfyorg/issue/FE-2214) | Top-up command on the lifecycle | Open — Comfy-Org#17657 | | 3B | [FE-2223](https://linear.app/comfyorg/issue/FE-2223) | Subscription commands and the eight-state projection | Open — Comfy-Org#17658 → Comfy-Org#17659 | No consumer and no flag: nothing in the app imports this yet. ## How - `operationState.ts`: `BillingOperationState`, a discriminated union over one `billing_op_id` (`pending | succeeded | failed | timed_out | reconciliation_needed | superseded`), and the pure `reduceBillingOperation` transition. The identity, including `presentation`, is fixed at adoption; switching embedded ↔ hosted is an event on the same operation, never a replacement. The transition decodes the generated `zBillingOpStatusResponse` and reads only the coded `decline_reason` / `recovery_action` — `error_message` is never read, so no Stripe or server text can reach a consumer. - `operationPolicy.ts`: the cadence (1s × 1.5 → 8s cap; 30s flat once parked on the customer) and the poll budgets (120s; 5 min for subscription discovery; 23h once the customer is involved), ported from `billingOperationStore`. - `operationPointer.ts`: the tab-local pointer, keyed by `(userId, workspaceId)`, over a host-supplied storage port. The Comfy-Org#16120 rule survives: a client timeout keeps the pointer, settlement clears it. - `presentation.ts`: `selectBillingPresentation`, the single routing decision. Embedded only when the host reports it can drive a challenge and `billing_rail === 'stripe'`; a command response that carries a page and no challenge is hosted regardless. - `operationLifecycle.ts`: `createBillingOperationLifecycle` — `begin` (single-flight per kind; the Phase 2 status read gates every start and a backend-pending operation of the same kind is adopted instead of issued again), `recover` (server pending op first, then the pointer), `wake`, `switchPresentation`, `reportChallengeStarted/Settled`, `settled`, and the `billing.operation.*` telemetry. ## Review focus 1. **Effects are declared, not performed.** The core never opens a URL, drives 3DS, or listens to a document. A host renders `actionUrl` / `challenge`, performs the effect, and reports back; visibility and focus arrive as `wake()`. This is what keeps the ticket's "no host framework or navigation side effect" true by construction rather than by import guard. 2. **Fail closed toward hosted, and toward not charging.** Routing falls to hosted on every unknown (no rail, legacy rail, host cannot embed). `begin` refuses to issue when the status read fails; `recover` falls back to the pointer only on `REQUEST_FAILED`, since an unreachable server is not "nothing pending". 3. **No-operation-id reconciliation.** When the status reports nothing pending but a pointer exists, one read decides: `404` drops the pointer without observing; a settled answer terminalizes from that single read; a still-pending answer (a `cancel`, which status cannot report) is observed from it rather than fetched twice. 4. **Supersession is a terminal state.** A workspace or session change marks every pending operation `superseded`, and a response landing after the change is discarded rather than applied. `ACCESS_DENIED` / `NOT_AUTHENTICATED` mid-poll land there too. The pointer stays under the old scope's key so a return recovers it. 5. **Departures from the app store, deliberately.** The "nothing was charged" safety copy is not modelled: the generated contract has no `no_charge_confirmed`, so the SDK cannot claim it. The eight public states are not projected here; 3A/3B own that. The transport is the Phase 1 `BillingTransport`, so the Layer TDD's HttpOnly-cookie transport swaps in underneath without touching this file. ## AS-IS / TO-BE AS-IS: no shared lifecycle — `billingOperationStore` owns polling, recovery, and routing inside the app, and each Phase 3 command would have to reimplement them. TO-BE: one exported `createBillingOperationLifecycle` in `@comfyorg/account/billing` that commands adopt an id into. No UI surface, so no screenshots. ## Testing `packages/account` suite 468/468 (this PR adds 44). Typecheck, oxlint, eslint, oxfmt, knip clean. Named tests per the ticket's done-when: resume (`recover` × server pending / pointer / unreachable status), duplicate-poll prevention (`wake` joins the poll in flight), scope and session supersession (workspace change with a late response; sign-out), timeout (budget kept with pointer; budget widened once the customer is involved), terminalization (coded decline reason, no server text; reconciliation on `404`), presentation switching with a stable `billing_op_id` (challenge fails → hosted → rollback, one `issue` call), hosted fallback refused without a URL, no-operation-id reconciliation, and telemetry (`started` / terminal with `presentation`, `resumed`, `failure_category`). Manual: none, and none is meaningful — no consumer, no UI surface. ## Stack (2026-09-14) Merge top-down. After a parent is squash-merged, rebase each child with `git rebase --onto origin/main <parent tip>` and force-push; GitHub retargets the base. Solid edges are code dependencies, dashed edges are sequencing. ```mermaid flowchart TD P12["Phase 1 + 2 merged<br/>Comfy-Org#17436 · Comfy-Org#17442"] --> C["FE-2227 Phase 3 core<br/>Comfy-Org#17655 · base main"] C --> P0["PR 0 coded error bodies + 3DS driver<br/>Comfy-Org#17656"] P0 --> A["FE-2214 top-up command<br/>Comfy-Org#17657"] P0 --> B1["FE-2223 B1 subscription commands<br/>Comfy-Org#17658"] B1 --> B2["FE-2223 B2 eight-state projection<br/>Comfy-Org#17659"] A --> I["Integration, do not merge<br/>Comfy-Org#17660"] B2 --> I I --> V1["FE-2215 @comfyorg/account-ui composables<br/>Comfy-Org#17662"] V1 --> V2["FE-2215 CheckoutSteps<br/>Comfy-Org#17663"] I --> SES["core: narrowed BillingSession type<br/>Comfy-Org#17664"] SES --> AD1["FE-2216 slice 1 top-up behind a flag<br/>Comfy-Org#17665"] AD1 -.-> AD2["FE-2216 slice 2 subscription<br/>needs previewSubscribe + plan-change decision"] AD1 --> E["FE-2217 Phase 6 evidence"] S["FE-2211 salvage tag d059104<br/>before 2026-09-30"] -.-> E BW["billing-web Comfy-Org#17370 → Comfy-Org#17574"] --> H["FE-2218 Phase 7 separate origin"] AD1 --> H V2 -.-> H AD1 -.-> SPLIT["account-core / account-ui rename PR"] SPLIT -.-> H ```
…y-Org#17664) ## Why Stacked on the Phase 3 integration ref (`jaewon/fe-2227-phase3-integration`, Comfy-Org#17660); merge after Phase 3. Found while wiring the first in-app consumer (FE-2216): the app's session client is `SessionClient<TUser>` for its own user type, and the identity seam is contravariant in that user, so every billing factory that demanded the full base `SessionClient` rejected the host's client. Without this, Phase 5 cannot hand the merged session client to the SDK at all. ## How One type, `BillingSession = Pick<SessionClient, 'getSnapshot' | 'subscribe' | 'ensureFresh' | 'remint'>`, names the four members the billing core actually reaches for. The transport, the scope tracker, the three readers, and the lifecycle take `BillingSession` instead of `SessionClient`. Type-only; no runtime change, no test change needed (the existing fakes already satisfy the narrower type). Pulled out of the FE-2216 branch so the core change is reviewed on its own and the consumer PR stays app-only. ## AS-IS / TO-BE AS-IS: `createSessionBillingTransport({ session: workspaceAuthStore.getUnifiedSessionClient() })` fails to typecheck for a host whose user type is narrower than `AccountUser`. TO-BE: any client exposing the four members is accepted. No UI surface, no screenshots. ## Testing `packages/account` suite unchanged and green; typecheck, oxlint, eslint, oxfmt clean. ## Stack (2026-09-14) Merge top-down. After a parent is squash-merged, rebase each child with `git rebase --onto origin/main <parent tip>` and force-push; GitHub retargets the base. Solid edges are code dependencies, dashed edges are sequencing. ```mermaid flowchart TD P12["Phase 1 + 2 merged<br/>Comfy-Org#17436 · Comfy-Org#17442"] --> C["FE-2227 Phase 3 core<br/>Comfy-Org#17655 · base main"] C --> P0["PR 0 coded error bodies + 3DS driver<br/>Comfy-Org#17656"] P0 --> A["FE-2214 top-up command<br/>Comfy-Org#17657"] P0 --> B1["FE-2223 B1 subscription commands<br/>Comfy-Org#17658"] B1 --> B2["FE-2223 B2 eight-state projection<br/>Comfy-Org#17659"] A --> I["Integration, do not merge<br/>Comfy-Org#17660"] B2 --> I I --> V1["FE-2215 @comfyorg/account-ui composables<br/>Comfy-Org#17662"] V1 --> V2["FE-2215 CheckoutSteps<br/>Comfy-Org#17663"] I --> SES["core: narrowed BillingSession type<br/>Comfy-Org#17664"] SES --> AD1["FE-2216 slice 1 top-up behind a flag<br/>Comfy-Org#17665"] AD1 -.-> AD2["FE-2216 slice 2 subscription<br/>needs previewSubscribe + plan-change decision"] AD1 --> E["FE-2217 Phase 6 evidence"] S["FE-2211 salvage tag d059104<br/>before 2026-09-30"] -.-> E BW["billing-web Comfy-Org#17370 → Comfy-Org#17574"] --> H["FE-2218 Phase 7 separate origin"] AD1 --> H V2 -.-> H AD1 -.-> SPLIT["account-core / account-ui rename PR"] SPLIT -.-> H ```
…ience (FE-2215) (Comfy-Org#17662) ## Why Stacked on the Phase 3 integration branch (`jaewon/fe-2227-phase3-integration`, PR 0 + Comfy-Org#17657 + Comfy-Org#17659); retarget `main` once Phase 3 lands. Phase 4 of the billing SDK track: the core in `@comfyorg/account/billing` is framework-free by construction, so the Vue composables that present it need a package of their own. This PR scaffolds it and ships the composables; the unstyled `CheckoutSteps` component follows in the stacked PR Comfy-Org#17663 to keep this one reviewable. - Linear: https://linear.app/comfyorg/issue/FE-2215 - Name decision: the ticket left `@comfyorg/account-ui` vs `@comfyorg/billing-ui` open. Picked **`@comfyorg/account-ui`** — it is the view half of `@comfyorg/account` and will also be the natural home for the sign-in pieces if they ever leave `@comfyorg/account/vue` (explicitly out of scope here). ## How New package `packages/account-ui` (`@comfyorg/account-ui`, private, `workspace:*`), entry `./billing` only. Modelled on `packages/account`: same tsconfig, `lint`/`typecheck` scripts, `vue` + `@vueuse/core` as peers, `@comfyorg/account` as a real dependency. `@comfyorg/account` gains no Vue dependency and is not modified. Registration: `knip.config.ts` workspace, root `lint`/`lint:no-cache`/`typecheck` scripts (`typecheck:account-ui`), and the license workflow's `--excludePackages` list (a private package reports as UNLICENSED, same as `@comfyorg/account`). Root `tsconfig.json` has no `references` array; the eslint resolver already globs `./packages/*/tsconfig.json`, and vitest already globs `packages/**`. Contents (`src/billing/`), ported from the PoC `vue/billing.ts` and re-seated on the merged core API: - `billingClient.ts` — `BillingClient` (lifecycle + capabilities + credits + topup command + subscription commands), `BILLING_CLIENT_KEY`, `provideBillingClient`, `useBillingClient`. Every composable takes an explicit client or falls back to the injected one. - `useBillingOperation(selector, client?)` — subscribes to `BillingOperationLifecycle` once, selects by `{ id }` or `{ kind }` (newest of that kind, so a resumed operation is picked up from the snapshot), unsubscribes on scope end via `tryOnScopeDispose`. - `useTopUp(options)` — the headless top-up over `createTopupCommand` + `driveEmbeddedChallenge` + `projectPaymentStep`. Exposes `canTopUp`/`denial` read from the server's capabilities snapshot (undefined until read, never derived locally), host-owned `presetsCents`/`minAmountCents`/`maxAmountCents`/`creditsPerDollar` (an amount outside the host bounds returns `INVALID_AMOUNT` without reaching the core), `amountCents`, `submitting`, `result`, the eight-state `projection`, `submit`/`retry`/`preview`/`cancel`/`reset`/`continueVerification`. A hosted continuation goes to the host's `openUrl(url, mode)` with `mode: 'new_tab' | 'redirect' | 'preopened'` (host picks the mode via `navigationMode`); an embedded challenge is driven through the host's `challengePort`. No router, no window, no Stripe here. - `useCheckout(options)` — the same attempt machinery over `createBillingCommands`: `subscribe`, `resubscribe`, `retry` (resends the last request), `openPaymentPortal` (resolves the URL and hands it to `openUrl`). `cancelSubscription` is not a checkout and stays on `client.commands`. - `useCredits(options)` — balance in micros as the core reports it, `loading`, `failure` (a failed refresh keeps the last balance), `refresh`. - `usePaymentAttempt` (internal) — what top-up and checkout share: the followed operation, the projection over it, the host-reported step, the once-per-continuation effect. A host-reported cancel outranks a pending operation; `reset` drops only a settled one from view, never a live one. Copy: nothing here renders text. The projection carries coded keys only; `CheckoutSteps` (next PR) resolves them through `createPaymentCopy`/`paymentCopyKeys`. Tests (vitest + @testing-library/vue, 12 tests) run the real core over a scripted transport (`__fixtures__/billingHarness.ts`): `can_top_up` gating with the coded denial and no POST, host bounds outside the core, hosted continuation opened once in the configured mode and again on `continueVerification`, embedded challenge driven through the port with a capabilities re-read after settlement, coded decline with no provider text in result/projection/operation, cancel/reset semantics, provide/inject resolution, scope-end unsubscribe. ## AS-IS / TO-BE No UI surface, no screenshots. - AS-IS: the billing core has no Vue consumer; every host would re-derive operation tracking, projection, continuation, and gating. - TO-BE: `@comfyorg/account-ui/billing` exposes the headless top-up and checkout experiences; hosts supply navigation, the challenge port, presets, bounds, and copy. ## Notes for review - Non-test source is ~556 lines; `CheckoutSteps` is split into the stacked PR to stay under the ~600 guard. - `useCredits` reads once on setup by default (`immediate: false` to opt out). - `useTopUp` does not gate `submit` on the cached `canTopUp`; the core re-reads capabilities itself, and the cached value exists to disable the CTA. ## Stack (2026-09-14) Merge top-down. After a parent is squash-merged, rebase each child with `git rebase --onto origin/main <parent tip>` and force-push; GitHub retargets the base. Solid edges are code dependencies, dashed edges are sequencing. ```mermaid flowchart TD P12["Phase 1 + 2 merged<br/>Comfy-Org#17436 · Comfy-Org#17442"] --> C["FE-2227 Phase 3 core<br/>Comfy-Org#17655 · base main"] C --> P0["PR 0 coded error bodies + 3DS driver<br/>Comfy-Org#17656"] P0 --> A["FE-2214 top-up command<br/>Comfy-Org#17657"] P0 --> B1["FE-2223 B1 subscription commands<br/>Comfy-Org#17658"] B1 --> B2["FE-2223 B2 eight-state projection<br/>Comfy-Org#17659"] A --> I["Integration, do not merge<br/>Comfy-Org#17660"] B2 --> I I --> V1["FE-2215 @comfyorg/account-ui composables<br/>Comfy-Org#17662"] V1 --> V2["FE-2215 CheckoutSteps<br/>Comfy-Org#17663"] I --> SES["core: narrowed BillingSession type<br/>Comfy-Org#17664"] SES --> AD1["FE-2216 slice 1 top-up behind a flag<br/>Comfy-Org#17665"] AD1 -.-> AD2["FE-2216 slice 2 subscription<br/>needs previewSubscribe + plan-change decision"] AD1 --> E["FE-2217 Phase 6 evidence"] S["FE-2211 salvage tag d059104<br/>before 2026-09-30"] -.-> E BW["billing-web Comfy-Org#17370 → Comfy-Org#17574"] --> H["FE-2218 Phase 7 separate origin"] AD1 --> H V2 -.-> H AD1 -.-> SPLIT["account-core / account-ui rename PR"] SPLIT -.-> H ```
…flag (FE-2216) (Comfy-Org#17665) ## Why Stacked on Comfy-Org#17664 (the type-only `BillingSession` core change this consumer surfaced, split out of this PR) on top of the Phase 3 integration branch (`jaewon/fe-2227-phase3-integration`); slice 1 of FE-2216, top-up only; flag default off, so an unflagged build sees no behavior change. First in-app consumer of `@comfyorg/account/billing`: with `billing_sdk_topup_enabled` on, top-up creation, hosted/in-page verification, resume, and the balance/capability refresh run on the SDK's operation lifecycle instead of `billingOperationStore`'s poller. Existing billing test suites are untouched and pass. Linear: https://linear.app/comfyorg/issue/FE-2216 ## How - `billing_sdk_topup_enabled`: server flag resolved fail-closed, declared exactly like `embeddedCheckoutEnabled` (enum, getter, telemetry evaluation). - Composition root `src/platform/workspace/billing/sdk/createBillingSdk.ts` (ports in, SDK out): `createSessionBillingTransport` over the auth store's one `SessionClient` with `resolveUrl = workspaceApiUrl` and the store's own mint target, the three Phase 2 readers, `createBillingOperationLifecycle` with `pointerStorage: sessionStorage`, `embeddedCheckoutAvailable = embeddedCheckoutEnabled && VITE_STRIPE_PUBLISHABLE_KEY`, the top-up command, and `driveChallenge` over a lazily loaded `loadStripe` port. - `useBillingSdkStore` (Pinia, once per app) wires it: one `visibilitychange`/`focus` handler calling `lifecycle.wake()`, the SDK telemetry mapped onto `trackBillingEvent`'s `operation` shape (`billingSdkTelemetry.ts`), progress toast, one auto-driven in-page challenge per operation, and, for an operation this tab reattached to, the refresh / dialog close / settings open / toast the poller performs today. - `topupOperationView.ts` projects SDK state onto the operation record the dialog reads and `TopupResult` onto the `CreateTopupResponse` it handles (`ok` → `completed`, `declined` → `failed`, refusals → `WorkspaceApiError` with the code, so the dialog's `NO_PAYMENT_METHOD` copy still fires). - `useWorkspaceBilling.topup()` and its pending-op recovery in `fetchStatus()` branch on the flag; the flag-off body is unchanged. The dialog consults `useTopupOperation()` for `isAddingCredits` / `topupActionOperation` / retry / dismiss (6 lines in the script; `handleBuy` untouched) — projecting into the poller's store would have started its own polling loop on the same id. - `workspaceAuthStore` exposes `getUnifiedSessionClient()` and `getUnifiedMintWorkspaceId()`; no second session client. - Package (type-only): `BillingSession = Pick<SessionClient, 'getSnapshot' | 'subscribe' | 'ensureFresh' | 'remint'>` replaces `SessionClient` in the billing option types. The app's client is `SessionClient<User>` and `attachIdentity` is contravariant in the user, so the first real consumer could not be typed against the full client. - Tests: dual-path suites for the wrapper (`useWorkspaceBilling.sdk.test.ts`), the dialog adapter, the store, the projections, the telemetry mapping, and the composition root over a fake session + `fetch` (bearer, idempotency key, mint target, pointer storage, port-driven challenge). Flag test mirrors `embeddedCheckoutEnabled`. Not routed through the SDK without touching call sites (listed, not faked): - `topup_id`: the SDK surfaces only `billing_op_id`; the projected response carries `topup_id: ''`. Nothing reads it. - Unsettled outcomes (`timed_out`, `reconciliation_needed`): the wrapper resolves `undefined`, which the dialog reports as `failure_category: 'unknown'` rather than the poller's `operation.timeout` / `reconciliation_needed`. The timeout toast still shows and the reconciliation id stays visible through the operation view. - Refusals without an HTTP status (`NO_PAYMENT_METHOD` — the SDK drops the status; capability denial; invalid amount; route absent) are bucketed `network` by `categorizeBillingApiError` instead of `api_rejected`. Follow-up for 3C: carry `httpStatus` on `TopupNoPaymentMethod`. - Telemetry for a dialog-issued top-up is emitted by the dialog exactly as before; the SDK's events are forwarded only for `resumed` operations. If `begin` adopts a backend-pending top-up under a dialog click, both report it. - Resume is triggered from `fetchStatus()` only when the server reports a pending top-up; the tab pointer alone (server unreachable) is not probed on load. - The rail is fixed when the dialog opens; a flag flip mid-operation does not move a live operation between observers. - Failure toast detail for SDK refusals is the generic `credits.topUp.unknownError` copy (no server text, by design); an unloadable Stripe port fails the challenge with the generic authentication copy rather than `authenticationUnavailable`. - The wrapper does not hold `isLoading` on the SDK path (it resolves at settlement); the dialog locks itself. Size: ~560 new non-test lines + ~115 modified (27 in the package). The composition root is 115 lines; the Pinia wiring is the bulk. Splitting root + package narrowing + auth accessors + flag into a flag-less parent PR is possible if preferred. ## AS-IS / TO-BE No UI surface change, no screenshots. - AS-IS: `topup()` posts through `workspaceApi`, the dialog hands a `pending` id to `billingOperationStore`, which polls, drives Stripe, and refreshes. - TO-BE (flag on): `topup()` runs `createTopupCommand(...).createTopupCheckout` on the SDK lifecycle; the dialog reads the same operation shape from `useTopupOperation()`; the SDK store owns wake, challenge, toast, and resumed-operation effects. Flag off: byte-identical call path. ## Stack (2026-09-14) Merge top-down. After a parent is squash-merged, rebase each child with `git rebase --onto origin/main <parent tip>` and force-push; GitHub retargets the base. Solid edges are code dependencies, dashed edges are sequencing. ```mermaid flowchart TD P12["Phase 1 + 2 merged<br/>Comfy-Org#17436 · Comfy-Org#17442"] --> C["FE-2227 Phase 3 core<br/>Comfy-Org#17655 · base main"] C --> P0["PR 0 coded error bodies + 3DS driver<br/>Comfy-Org#17656"] P0 --> A["FE-2214 top-up command<br/>Comfy-Org#17657"] P0 --> B1["FE-2223 B1 subscription commands<br/>Comfy-Org#17658"] B1 --> B2["FE-2223 B2 eight-state projection<br/>Comfy-Org#17659"] A --> I["Integration, do not merge<br/>Comfy-Org#17660"] B2 --> I I --> V1["FE-2215 @comfyorg/account-ui composables<br/>Comfy-Org#17662"] V1 --> V2["FE-2215 CheckoutSteps<br/>Comfy-Org#17663"] I --> SES["core: narrowed BillingSession type<br/>Comfy-Org#17664"] SES --> AD1["FE-2216 slice 1 top-up behind a flag<br/>Comfy-Org#17665"] AD1 -.-> AD2["FE-2216 slice 2 subscription<br/>needs previewSubscribe + plan-change decision"] AD1 --> E["FE-2217 Phase 6 evidence"] S["FE-2211 salvage tag d059104<br/>before 2026-09-30"] -.-> E BW["billing-web Comfy-Org#17370 → Comfy-Org#17574"] --> H["FE-2218 Phase 7 separate origin"] AD1 --> H V2 -.-> H AD1 -.-> SPLIT["account-core / account-ui rename PR"] SPLIT -.-> H ```
…(FE-2215) (Comfy-Org#17663) ## Why Stacked on the FE-2215 composables PR (`jaewon/fe-2215-phase-4-new-view-package-for-billing-composables-and`), itself stacked on the Phase 3 integration branch (`jaewon/fe-2227-phase3-integration`, PR 0 + Comfy-Org#17657 + Comfy-Org#17659); retarget once each parent lands. Second half of Phase 4: the unstyled `CheckoutSteps` component, split out of the composables PR to keep both under the size guard. - Linear: https://linear.app/comfyorg/issue/FE-2215 ## How `packages/account-ui/src/billing/CheckoutSteps.vue`, ported from the PoC `vue/CheckoutSteps.ts` onto the merged `PaymentProjection` + `paymentCopyKeys`/`createPaymentCopy`: - Takes the `projection` (eight-state, from `useTopUp`/`useCheckout`), a `copy` prop of host-localized overrides by approved `PaymentCopyKey`, `disabled`, and class props (`rootClass`, `headerClass`, `bodyClass`, `reasonClass`, `safetyClass`, `actionsClass`, `actionClass`) the way `PasswordRules`/`SocialAuthButtons` do. - Renders header, body, the coded reason when the projection carries one, and the safety line only when the projection's `noChargeConfirmed` unlocks it (a host override of that line is ignored by `createPaymentCopy`). - Default actions per step from the approved copy: `verifying` → continue verification, `declined`/`processing_error`/`canceled` → retry. Emits `retry`, `cancel`, `continue-verification`; `header`/`body`/`actions` slots receive the projection, copy key/text, and the callbacks so a host lays out its own controls. - Raw backend or provider text can never reach the template: every string is looked up by key in the copy table. Adds `@testing-library/user-event` to the package devDependencies (lockfile updated) and the two index exports. Tests (6): approved copy with host overrides and class props, safety line gated by the projection only, default actions and their emits, no action on success / nothing while disabled, slot scope and callbacks. ## AS-IS / TO-BE No styled UI surface, no screenshots (the component is unstyled by design; `data-billing-step` and `data-copy-key` attributes are the only markers). - AS-IS: hosts render the projection themselves. - TO-BE: one shared unstyled section per projection state with the approved coded copy, styled and laid out by each host. ## Stack (2026-09-14) Merge top-down. After a parent is squash-merged, rebase each child with `git rebase --onto origin/main <parent tip>` and force-push; GitHub retargets the base. Solid edges are code dependencies, dashed edges are sequencing. ```mermaid flowchart TD P12["Phase 1 + 2 merged<br/>Comfy-Org#17436 · Comfy-Org#17442"] --> C["FE-2227 Phase 3 core<br/>Comfy-Org#17655 · base main"] C --> P0["PR 0 coded error bodies + 3DS driver<br/>Comfy-Org#17656"] P0 --> A["FE-2214 top-up command<br/>Comfy-Org#17657"] P0 --> B1["FE-2223 B1 subscription commands<br/>Comfy-Org#17658"] B1 --> B2["FE-2223 B2 eight-state projection<br/>Comfy-Org#17659"] A --> I["Integration, do not merge<br/>Comfy-Org#17660"] B2 --> I I --> V1["FE-2215 @comfyorg/account-ui composables<br/>Comfy-Org#17662"] V1 --> V2["FE-2215 CheckoutSteps<br/>Comfy-Org#17663"] I --> SES["core: narrowed BillingSession type<br/>Comfy-Org#17664"] SES --> AD1["FE-2216 slice 1 top-up behind a flag<br/>Comfy-Org#17665"] AD1 -.-> AD2["FE-2216 slice 2 subscription<br/>needs previewSubscribe + plan-change decision"] AD1 --> E["FE-2217 Phase 6 evidence"] S["FE-2211 salvage tag d059104<br/>before 2026-09-30"] -.-> E BW["billing-web Comfy-Org#17370 → Comfy-Org#17574"] --> H["FE-2218 Phase 7 separate origin"] AD1 --> H V2 -.-> H AD1 -.-> SPLIT["account-core / account-ui rename PR"] SPLIT -.-> H ```
Why
Stacked on PR 0 (
jaewon/fe-2227-core-error-codes-and-challenge-driver, #17656) → #17655 (FE-2227); independent of FE-2214; merge after both parents.Phase 3B, part 1 of 2: the subscription commands ported onto the SDK-owned billing operation lifecycle. Part 2 (the eight-state payment projection and copy) is stacked on this PR so each stays under the source budget.
How
New
packages/account/src/core/billing/subscriptionCommands.ts(+ test), export lines appended toindex.ts. No other core file is touched.createBillingCommands({ transport, lifecycle, statusReader, capabilities, credits, idempotencyKey? })returnssubscribe,resubscribe,cancelSubscription,openPaymentPortal.zSubscribeRequest/Response,zResubscribeResponse,zCancelSubscriptionResponse2= the generated union ofzCancelSubscriptionResponse | zCancelSubscriptionAcceptedResponse,zPaymentPortalResponse), reads throughreadValidatedBillingResponse, and issues throughlifecycle.begin— single-flight, the status gate, backend-pending adoption, polling, routing, pointer, recovery, and telemetry all stay in core. The command then awaitslifecycle.settled(id)and returns the terminal state.is_active,subscription_tier,subscription_status): FREE → subscribe issues; PRO active → subscribe is a no-op success with no request; PRO canceled → subscribe routes to the resubscribe endpoint.saved_payment_method_idXORconfirmation_token, empty strings dropped, both present →CONFLICTING_PAYMENT_METHODbefore any request (before the status read too); a request the generated schema refuses (e.g. an id without thepm_prefix) →INVALID_REQUEST, also before any request.subscribedand resubscribeactivestill adopt the id so the first poll settles it and invalidation/telemetry are uniform;needs_payment_methodhandspayment_method_urlto the lifecycle as the hostedactionUrl(missing →MISSING_PAYMENT_METHOD_URL);pending_payment/pending/ both cancel shapes → observed to a terminal state. 3DS is driven by the host through the existingdriveEmbeddedChallengewhile the command awaits settlement (tested end to end through the real lifecycle).BillingFailure.serverCode):REACTIVATION_CONFIRMATION_REQUIRED→ coded result for the host to re-preview and resend withconfirm_reactivation;ALREADY_CANCELED/NOT_SCHEDULED_FOR_CANCELLATIONfrom a 4xx → already-in-requested-state success after a status re-read (a 5xx echoing the code stays a failure, as inuseWorkspaceBilling.isAlreadyInRequestedState);NO_ACTIVE_SUBSCRIPTION→ coded error. Command-level codes live inSubscriptionCommandCode;BillingErrorCodeis untouched.cancel_atis available after a cancel). A failed credits read never turns a success into a failure.idempotency_keygoes in every subscribe/resubscribe/cancel body and asidempotencyKeyon theBillingRequest(the transport's 401 replay gate), one key per attempt. The portal request carries neither (the contract has no key; a portal session is not a mutation).openPaymentPortalreturns{ url }aftervalidateActionUrl(https only); the SDK never opens it and does not refresh anything on it.message,error_message) never reaches a result; asserted in the decline, 5xx, coded-error, and resubscribe (messagefield) tests.Tests (32, one per ticket row): the {FREE, PRO active, PRO canceled} × {subscribe, resubscribe, cancel, portal} matrix including subscribe→resubscribe routing; saved payment method (4); 3DS through
driveEmbeddedChallenge, hosted page, missing page; declines and reactivation; both cancel response shapes and the 5xx echo; transport failure, malformed 2xx, 5xx, failed eligibility read; reconciliation; and reload/resume, poll timeout, and workspace supersession through the real lifecycle with fake timers.Review focus
lifecycle.beginreads it again for its own pending gate: twoGET /billing/statusper subscribe. Avoiding it would need a core change (lettingbeginaccept a status), which this PR deliberately does not make.plan_slug; a plan change on an active subscription (the app'scheckoutType: 'change') is therefore not reachable through this command yet. Flagged, not silently decided.needs_payment_methodwithout a URL is refused without adopting the id; the backend still reports it as pending, so the nextbegin/recoveradopts it rather than reissuing.Ticket vs generated contract:
active→ sync success without an id" is unreachable:zResubscribeResponse.billing_op_idis required, so the id is adopted uniformly.zPaymentPortalRequesthas noidempotency_key; the portal POST is sent without one.AS-IS / TO-BE
No UI surface, no screenshots.
AS-IS: subscription commands live in the cloud app (
workspaceApi,useSubscriptionCheckout,useWorkspaceBilling) with their own polling, pending-checkout storage, and error-string handling.TO-BE:
@comfyorg/account/billingexportscreateBillingCommands; hosts issue commands and render the lifecycle state, never own the machine, and never see server text.Stack (2026-09-14)
Merge top-down. After a parent is squash-merged, rebase each child with
git rebase --onto origin/main <parent tip>and force-push; GitHub retargets the base. Solid edges are code dependencies, dashed edges are sequencing.