Skip to content

PoC do not merge: consume @comfyorg/account from apps/website (stacked) - #17026

Draft
christian-byrne wants to merge 6 commits into
poc/account-layer-refactorfrom
poc/account-layer-website-local
Draft

christian-byrne wants to merge 6 commits into
poc/account-layer-refactorfrom
poc/account-layer-website-local

Conversation

@christian-byrne

@christian-byrne christian-byrne commented Sep 4, 2026 •

Copy link
Copy Markdown
Contributor

PoC do not merge: evidence review only.

  • apps/website (the Astro marketing site in this repo) consumes @comfyorg/account as a fifth consumer, on the /cloud/pricing/ page.
  • Proven so far: workspace dependency resolves, PUBLIC_ACCOUNT_LAYER_POC=1 pnpm --filter @comfyorg/website build passes (701 pages), the signed-out account island renders. Signed-in flows are not yet exercised on this consumer.
  • Pushed head is a5b74ad62c; the PoC branch will be torn down on 2026-09-30 if no release owner is named.
Full context for agent readers

What this PR shows

The concept is one account layer (session, token refresh, billing client, credits state) consumed by every Comfy web surface. The other four consumers are ComfyUI_frontend itself (#16729), platform.comfy.org (Comfy-Org/platform#923), the workflow_templates Astro site (Comfy-Org/workflow_templates#1228), and the producer package (#16639). This PR adds the fifth: the apps/website Astro app already inside the pnpm workspace.

It bases on the producer branch poc/account-layer-refactor and carries the package byte-identically. The package now initializes Firebase, owns sign-in state, and exchanges Firebase ID tokens for workspace tokens; the host supplies only storage, transport, time, and navigation adapters. Changes are limited to apps/website:

  • package.json: @comfyorg/account: workspace:*
  • src/components/account/accountHostAdapter.ts: host adapter (storage, navigation, environment) for the Astro island
  • src/components/account/AccountIsland.vue: client-only Vue island that mounts the shared session and credits state
  • src/pages/cloud/pricing.astro: mounts the island behind PUBLIC_ACCOUNT_LAYER_POC
  • PoC-only compatibility changes: the island uses client-only Vue hydration, and two Japanese fallback strings satisfy pre-commit typecheck.

After this identity refactor, local typecheck, lint, unit tests, and build passed apart from one unrelated test failure for the language-model discovery file. End-to-end login, credits, and payments flows were not rerun against real Firebase and Stripe test credentials. Before the refactor, staging validation across the consumers covered login, credits, Stripe test-mode checkout, top-up, subscription, coupon, and 3DS states.

Not proven on this consumer

  • Sign-in, token refresh, billing fetch, credits display with a signed-in user, sign-out. These were proven on the other three consumers with real Firebase test users and Stripe test mode; the website consumer so far proves only that the package installs, builds under Astro SSG, and renders its signed-out state.
  • One unrelated language-model discovery test remains red; the identity-refactor checks otherwise passed locally.

Links

Glossary

  • Consumer: An app that imports the shared account package.
  • Island: A Vue component hydrated on the client inside an otherwise static Astro page.
  • PoC: Proof of concept used to test the design.
  • Pushed head: Latest commit currently visible on GitHub.
  • SSG: Static site generation; pages are built to HTML ahead of time.

@coderabbitai

coderabbitai Bot commented Sep 4, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: 4d0653d3-1aad-4374-be3c-24a14f282c5f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 4, 2026 •

Copy link
Copy Markdown
Contributor

🌐 Website E2E

Caution

Some tests failed.

Status ❌ Failed
Report unavailable
Screenshot diffs 0
Other failures 0

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/11/2026, 12:18:40 AM UTC

Links

🎭 Playwright: ✅ 1893 passed, 0 failed · 1 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1872 / ❌ 0 / ⚠️ 1 / ⏭️ 4)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.9 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.2 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.7 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.8 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.5 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 84.0 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 74.0 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 77.1 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.8 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 79.0 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 60.2 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 58.1 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 138ms TBT · 94.8 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.9 MB heap
vue-large-graph-idle: · 56.2 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 13ms TBT · 167.8 MB heap
vue-large-graph-pan: · 56.3 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 112ms TBT · 164.0 MB heap
vue-node-resize-workload: · 56.3 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 449ms TBT · 169.1 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.4 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 9ms
canvas-idle: layout count 0
canvas-idle: style recalc count 8
canvas-idle: task duration 587ms
canvas-idle: script duration 12ms
canvas-idle: TBT 0ms
canvas-idle: heap used 66.9 MB
canvas-idle: DOM nodes -281
canvas-idle: event listeners -155
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 5ms
canvas-mouse-sweep: style recalc duration 41ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 78
canvas-mouse-sweep: task duration 931ms
canvas-mouse-sweep: script duration 167ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 69.2 MB
canvas-mouse-sweep: DOM nodes -283
canvas-mouse-sweep: event listeners -186
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 21ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 33
canvas-zoom-sweep: task duration 406ms
canvas-zoom-sweep: script duration 14ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 70.7 MB
canvas-zoom-sweep: DOM nodes 78
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 9ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 11
dom-widget-clipping: task duration 464ms
dom-widget-clipping: script duration 165ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 83.8 MB
dom-widget-clipping: DOM nodes 17
dom-widget-clipping: event listeners 2
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 7ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 6
large-graph-idle: task duration 668ms
large-graph-idle: script duration 41ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 82.5 MB
large-graph-idle: DOM nodes -268
large-graph-idle: event listeners -154
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 10ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 65
large-graph-pan: task duration 1678ms
large-graph-pan: script duration 820ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 84.0 MB
large-graph-pan: DOM nodes -275
large-graph-pan: event listeners -74
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 12ms
large-graph-zoom: style recalc duration 10ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 60
large-graph-zoom: task duration 1787ms
large-graph-zoom: script duration 807ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 74.0 MB
large-graph-zoom: DOM nodes 0
large-graph-zoom: event listeners 9
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 5ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 40
legacy-node-drag: task duration 1976ms
legacy-node-drag: script duration 973ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 77.1 MB
legacy-node-drag: DOM nodes 0
legacy-node-drag: event listeners 188
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 4ms
minimap-idle: layout count 0
minimap-idle: style recalc count 5
minimap-idle: task duration 647ms
minimap-idle: script duration 38ms
minimap-idle: TBT 0ms
minimap-idle: heap used 82.8 MB
minimap-idle: DOM nodes -271
minimap-idle: event listeners -168
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 11ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 46
subgraph-dom-widget-clipping: task duration 424ms
subgraph-dom-widget-clipping: script duration 145ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 79.0 MB
subgraph-dom-widget-clipping: DOM nodes 17
subgraph-dom-widget-clipping: event listeners 8
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 9ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 9
subgraph-idle: task duration 536ms
subgraph-idle: script duration 10ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 60.2 MB
subgraph-idle: DOM nodes -296
subgraph-idle: event listeners -201
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 6ms
subgraph-mouse-sweep: style recalc duration 40ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 78
subgraph-mouse-sweep: task duration 876ms
subgraph-mouse-sweep: script duration 117ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 58.1 MB
subgraph-mouse-sweep: DOM nodes -295
subgraph-mouse-sweep: event listeners -201
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 16ms
subgraph-transition-enter: style recalc duration 33ms
subgraph-transition-enter: layout count 13
subgraph-transition-enter: style recalc count 17
subgraph-transition-enter: task duration 989ms
subgraph-transition-enter: script duration 33ms
subgraph-transition-enter: TBT 138ms
subgraph-transition-enter: heap used 94.8 MB
subgraph-transition-enter: DOM nodes 13751
subgraph-transition-enter: event listeners 2383
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 36ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 246
viewport-pan-sweep: task duration 6051ms
viewport-pan-sweep: script duration 2731ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 82.9 MB
viewport-pan-sweep: DOM nodes -271
viewport-pan-sweep: event listeners -137
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 16885ms
vue-large-graph-idle: script duration 323ms
vue-large-graph-idle: TBT 13ms
vue-large-graph-idle: heap used 167.8 MB
vue-large-graph-idle: DOM nodes -6548
vue-large-graph-idle: event listeners -7474
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 20ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 167
vue-large-graph-pan: task duration 21132ms
vue-large-graph-pan: script duration 928ms
vue-large-graph-pan: TBT 112ms
vue-large-graph-pan: heap used 164.0 MB
vue-large-graph-pan: DOM nodes -6548
vue-large-graph-pan: event listeners -7470
vue-node-resize-workload: avg frame time 18ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 23ms
vue-node-resize-workload: style recalc duration 80ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 6177ms
vue-node-resize-workload: script duration 114ms
vue-node-resize-workload: TBT 449ms
vue-node-resize-workload: heap used 169.1 MB
vue-node-resize-workload: DOM nodes -6548
vue-node-resize-workload: event listeners -7471
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 19ms
workflow-execution: layout count 3
workflow-execution: style recalc count 11
workflow-execution: task duration 96ms
workflow-execution: script duration 8ms
workflow-execution: TBT 0ms
workflow-execution: heap used 66.4 MB
workflow-execution: DOM nodes 117
workflow-execution: event listeners 74
Raw data
{
  "timestamp": "2026-09-11T00:29:43.222Z",
  "gitSha": "3addbc4c2bfede60fa1e5ce1e658e0c1913de522",
  "branch": "poc/account-layer-website-local",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2090.3299999999945,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 7.151000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 605.188,
      "heapDeltaBytes": 13456952,
      "heapUsedBytes": 82735192,
      "domNodes": -281,
      "jsHeapTotalBytes": 4448256,
      "scriptDurationMs": 12.718000000000004,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2072.0490000001064,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 10.489999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 568.075,
      "heapDeltaBytes": -11451220,
      "heapUsedBytes": 57591596,
      "domNodes": -281,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 11.871999999999996,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1912.4289999999746,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 42.967,
      "layouts": 14,
      "layoutDurationMs": 4.492999999999999,
      "taskDurationMs": 937.4190000000001,
      "heapDeltaBytes": 8669172,
      "heapUsedBytes": 72862296,
      "domNodes": -284,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 168.93800000000002,
      "eventListeners": -187,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1867.8239999999278,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 39.45700000000001,
      "layouts": 14,
      "layoutDurationMs": 4.942,
      "taskDurationMs": 923.945,
      "heapDeltaBytes": 2102052,
      "heapUsedBytes": 72190540,
      "domNodes": -281,
      "jsHeapTotalBytes": 6545408,
      "scriptDurationMs": 165.13,
      "eventListeners": -185,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1755.3739999999607,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 19.106,
      "layouts": 6,
      "layoutDurationMs": 1.169,
      "taskDurationMs": 402.71999999999997,
      "heapDeltaBytes": 4419948,
      "heapUsedBytes": 73987320,
      "domNodes": 78,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 14.902000000000003,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1755.920999999944,
      "styleRecalcs": 33,
      "styleRecalcDurationMs": 23.285,
      "layouts": 6,
      "layoutDurationMs": 1.124,
      "taskDurationMs": 409.572,
      "heapDeltaBytes": 4307372,
      "heapUsedBytes": 74339044,
      "domNodes": 78,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 13.129999999999999,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 692.1169999999393,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 9.835,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 470.931,
      "heapDeltaBytes": 18167216,
      "heapUsedBytes": 87938656,
      "domNodes": 18,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 165.679,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 676.2220000000525,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 8.05,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 456.3670000000001,
      "heapDeltaBytes": 18449920,
      "heapUsedBytes": 87858212,
      "domNodes": 16,
      "jsHeapTotalBytes": 4456448,
      "scriptDurationMs": 164.56900000000002,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2056.5619999999853,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 8.901,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 669.9560000000001,
      "heapDeltaBytes": -13613576,
      "heapUsedBytes": 86147528,
      "domNodes": -266,
      "jsHeapTotalBytes": -1093632,
      "scriptDurationMs": 44.043,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2078.571000000011,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 4.1190000000000015,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 667.001,
      "heapDeltaBytes": -13039264,
      "heapUsedBytes": 86971288,
      "domNodes": -269,
      "jsHeapTotalBytes": -1617920,
      "scriptDurationMs": 38.66,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2284.1680000000224,
      "styleRecalcs": 63,
      "styleRecalcDurationMs": 8.547999999999996,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1672.8519999999999,
      "heapDeltaBytes": 21526912,
      "heapUsedBytes": 86965552,
      "domNodes": -278,
      "jsHeapTotalBytes": 749568,
      "scriptDurationMs": 820.6999999999999,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2389.453000000003,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 11.108999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1683.29,
      "heapDeltaBytes": -11692576,
      "heapUsedBytes": 89103196,
      "domNodes": -271,
      "jsHeapTotalBytes": -2179072,
      "scriptDurationMs": 818.499,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3719.84400000008,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 10.201000000000002,
      "layouts": 60,
      "layoutDurationMs": 12.267,
      "taskDurationMs": 1806.778,
      "heapDeltaBytes": 8061020,
      "heapUsedBytes": 75683668,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 820.6669999999999,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3687.3740000000907,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 10.116,
      "layouts": 60,
      "layoutDurationMs": 12.485,
      "taskDurationMs": 1767.0060000000003,
      "heapDeltaBytes": 11722924,
      "heapUsedBytes": 79496860,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 794.003,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3149.016999999958,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 5.151999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1987.5040000000001,
      "heapDeltaBytes": 25900780,
      "heapUsedBytes": 93608564,
      "domNodes": 0,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 983.864,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3165.758000000096,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 5.007000000000004,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1963.76,
      "heapDeltaBytes": 334508,
      "heapUsedBytes": 67990848,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 961.8510000000001,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2028.4040000000232,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 3.2720000000000007,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 635.7810000000001,
      "heapDeltaBytes": 10090112,
      "heapUsedBytes": 86654796,
      "domNodes": -272,
      "jsHeapTotalBytes": -2179072,
      "scriptDurationMs": 38.705000000000005,
      "eventListeners": -183,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2028.1290000000354,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 5.4620000000000015,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 658.4380000000001,
      "heapDeltaBytes": -14815124,
      "heapUsedBytes": 86979176,
      "domNodes": -269,
      "jsHeapTotalBytes": -831488,
      "scriptDurationMs": 36.91799999999999,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 608.4670000000187,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 11.325,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 422.789,
      "heapDeltaBytes": 14084844,
      "heapUsedBytes": 79452472,
      "domNodes": 18,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 146.356,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 630.4780000000392,
      "styleRecalcs": 45,
      "styleRecalcDurationMs": 9.743,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 425.95099999999996,
      "heapDeltaBytes": 14385680,
      "heapUsedBytes": 86234836,
      "domNodes": 16,
      "jsHeapTotalBytes": 6029312,
      "scriptDurationMs": 143.44799999999998,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2015.188999999964,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 8.198999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 541.746,
      "heapDeltaBytes": -9109464,
      "heapUsedBytes": 62570216,
      "domNodes": -297,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 9.802999999999999,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2021.7090000001008,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 10.213000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 530.777,
      "heapDeltaBytes": -8670432,
      "heapUsedBytes": 63660000,
      "domNodes": -295,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 9.799999999999999,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1708.026000000018,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 37.92100000000001,
      "layouts": 18,
      "layoutDurationMs": 5.948,
      "taskDurationMs": 865.2030000000001,
      "heapDeltaBytes": -11355780,
      "heapUsedBytes": 60642212,
      "domNodes": -295,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 116.16299999999998,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1758.1890000001295,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 41.6,
      "layouts": 18,
      "layoutDurationMs": 5.995,
      "taskDurationMs": 886.897,
      "heapDeltaBytes": -10684124,
      "heapUsedBytes": 61261016,
      "domNodes": -295,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 118.16300000000001,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1399.1610000000492,
      "styleRecalcs": 17,
      "styleRecalcDurationMs": 33.364999999999995,
      "layouts": 13,
      "layoutDurationMs": 15.834999999999999,
      "taskDurationMs": 989.0030000000003,
      "heapDeltaBytes": 26457948,
      "heapUsedBytes": 99424256,
      "domNodes": 13751,
      "jsHeapTotalBytes": 11010048,
      "scriptDurationMs": 32.714,
      "eventListeners": 2383,
      "totalBlockingTimeMs": 138,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8825.263999999948,
      "styleRecalcs": 246,
      "styleRecalcDurationMs": 34.602999999999994,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6025.842999999999,
      "heapDeltaBytes": 23921156,
      "heapUsedBytes": 88815552,
      "domNodes": -270,
      "jsHeapTotalBytes": 749568,
      "scriptDurationMs": 2737.876,
      "eventListeners": -137,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 9073.101000000179,
      "styleRecalcs": 246,
      "styleRecalcDurationMs": 37.988,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6075.959,
      "heapDeltaBytes": -15143960,
      "heapUsedBytes": 84952716,
      "domNodes": -271,
      "jsHeapTotalBytes": -1949696,
      "scriptDurationMs": 2724.177,
      "eventListeners": -137,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333338,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17565.021999999997,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16878.453999999998,
      "heapDeltaBytes": -34024404,
      "heapUsedBytes": 175779348,
      "domNodes": -6548,
      "jsHeapTotalBytes": 4448256,
      "scriptDurationMs": 279.95,
      "eventListeners": -7475,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17619.187999999893,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16890.653000000002,
      "heapDeltaBytes": -37244512,
      "heapUsedBytes": 176102348,
      "domNodes": -6548,
      "jsHeapTotalBytes": -7528448,
      "scriptDurationMs": 365.15200000000004,
      "eventListeners": -7473,
      "totalBlockingTimeMs": 26,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21678.856999999993,
      "styleRecalcs": 169,
      "styleRecalcDurationMs": 21.14100000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 21288.964999999997,
      "heapDeltaBytes": -41368172,
      "heapUsedBytes": 167666404,
      "domNodes": -6548,
      "jsHeapTotalBytes": -3846144,
      "scriptDurationMs": 946.39,
      "eventListeners": -7471,
      "totalBlockingTimeMs": 208,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21383.31500000004,
      "styleRecalcs": 164,
      "styleRecalcDurationMs": 19.204,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20974.103,
      "heapDeltaBytes": -28042736,
      "heapUsedBytes": 176252144,
      "domNodes": -6548,
      "jsHeapTotalBytes": 1826816,
      "scriptDurationMs": 910.0769999999999,
      "eventListeners": -7469,
      "totalBlockingTimeMs": 15,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6300.2970000000005,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 80.19500000000002,
      "layouts": 20,
      "layoutDurationMs": 24.333999999999996,
      "taskDurationMs": 6192.657,
      "heapDeltaBytes": -24704920,
      "heapUsedBytes": 177145896,
      "domNodes": -6548,
      "jsHeapTotalBytes": 13361152,
      "scriptDurationMs": 113.263,
      "eventListeners": -7471,
      "totalBlockingTimeMs": 455,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6294.857000000093,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 78.92400000000005,
      "layouts": 20,
      "layoutDurationMs": 22.494000000000014,
      "taskDurationMs": 6162.066999999999,
      "heapDeltaBytes": -26888356,
      "heapUsedBytes": 177568080,
      "domNodes": -6548,
      "jsHeapTotalBytes": 13099008,
      "scriptDurationMs": 114.405,
      "eventListeners": -7471,
      "totalBlockingTimeMs": 442,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "workflow-execution",
      "durationMs": 464.79500000009466,
      "styleRecalcs": 14,
      "styleRecalcDurationMs": 21.779,
      "layouts": 4,
      "layoutDurationMs": 1.579,
      "taskDurationMs": 113.08600000000001,
      "heapDeltaBytes": 5150196,
      "heapUsedBytes": 72852880,
      "domNodes": 124,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 10.938,
      "eventListeners": 99,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "workflow-execution",
      "durationMs": 109.3550000000505,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 15.880999999999998,
      "layouts": 2,
      "layoutDurationMs": 0.6980000000000001,
      "taskDurationMs": 79.011,
      "heapDeltaBytes": 3149976,
      "heapUsedBytes": 66443392,
      "domNodes": 110,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 5.436000000000002,
      "eventListeners": 49,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    }
  ]
}

🔬 E2E Coverage

Metric Covered Total Pct
Lines 48005 70491 68.1% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.1% 1188
src/LGraphNode.ts 69.3% 398
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/platform/workspace/stores/billingOperationStore.ts 8.3% 300
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/platform/workspace/stores/teamWorkspaceStore.ts 37.7% 261
src/LGraph.ts 78.4% 258
src/scripts/app.ts 71.7% 247
src/scripts/pnginfo.ts 21.4% 221
src/stores/assetsStore.ts 44.7% 204

@github-actions github-actions Bot added the risk:R3 PR risk grade (advisory shadow check; grader-owned) label Sep 4, 2026
@codecov

codecov Bot commented Sep 4, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@                      Coverage Diff                      @@
##             poc/account-layer-refactor   #17026   +/-   ##
=============================================================
  Coverage                              ?   82.25%           
=============================================================
  Files                                 ?     2033           
  Lines                                 ?   117073           
  Branches                              ?    30310           
=============================================================
  Hits                                  ?    96293           
  Misses                                ?    20604           
  Partials                              ?      176           
Flag Coverage Δ
e2e 68.12% <ø> (?)
unit 76.58% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/account/src/core/billing/client.ts 80.00% <100.00%> (ø)
packages/account/src/firebase/index.ts 94.11% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@christian-byrne christian-byrne self-assigned this Sep 4, 2026
@dante01yoon

Copy link
Copy Markdown
Collaborator

Salvage note (FE-2211): the billing subtree at d059104ac3 is retained at tag salvage/poc-account-layer-billing-d059104ac3 and branch salvage/poc-account-layer-refactor ahead of the 2026-09-30 teardown. Phase 3 of the billing SDK re-seats this behavior on the merged session client (#17655 → #17656 → #17657 / #17658 → #17659); the stack diagram is in the Billing SDK implementation plan (V2). No action requested on this PR.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:R3 PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants