Repository navigation
PoC do not merge: consume @comfyorg/account from ComfyUI_frontend itself (stacked) - #16729
christian-byrne wants to merge 50 commits into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: 🕵🏻 0 passed, 0 failed📊 Browser Reports
🎨 Storybook: ❌ FailedDetails⏰ Completed at: 09/11/2026, 07:38:40 PM UTC Links
📦 Bundle Size
⚡ Performance
🔬 E2E Coverage
🌐 Website E2ECaution Some tests failed.
|
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## poc/account-layer-refactor #16729 +/- ##
==============================================================
+ Coverage 80.75% 81.57% +0.81%
==============================================================
Files 2442 2032 -410
Lines 124678 119965 -4713
Branches 33481 30340 -3141
==============================================================
- Hits 100687 97858 -2829
+ Misses 23488 21933 -1555
+ Partials 503 174 -329
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 526 files with indirect coverage changes 🚀 New features to boost your workflow:
|
[PoC do not merge] Adds provider-neutral billing clients, state, polling, safety copy, Vue projection, and evidence tests.
…nt now identical)
d2c1f14 to
d93ebcb
Compare
…nt now identical)
|
Salvage note (FE-2211): the billing subtree at |
PoC do not merge: evidence review only.
e06e306dcb; the PoC branch will be torn down on 2026-09-30 if no release owner is named.Full context for agent readers
What this PR proves
ComfyUI_frontend consumer uses
@comfyorg/accountbehind a proof-of-concept seam. This PR bases on the producer branchpoc/account-layer-refactorand carries the package byte-identically. The package now initializes Firebase, owns sign-in state, and exchanges Firebase ID tokens for workspace tokens; the host supplies only storage, transport, time, and navigation adapters.After this identity refactor, local typecheck, lint, unit tests, and build passed. End-to-end login, credits, and payments flows were not rerun against real Firebase and Stripe test credentials. Before the refactor, staging validation across the consumers covered login, credits, Stripe test-mode checkout, top-up, subscription, coupon, and 3DS states.
Not proven
POST /customers.--workers=1; the remaining red row is a harness navigation flake, not a product defect.The pushed and current head is
e06e306dcb. The PoC branch will be torn down on 2026-09-30 if no release owner is named.Links
Glossary