Skip to content

PoC do not merge: consume @comfyorg/account from ComfyUI_frontend itself (stacked) - #16729

Draft
christian-byrne wants to merge 50 commits into
poc/account-layer-refactorfrom
poc/account-layer-frontend-consumer
Draft

christian-byrne wants to merge 50 commits into
poc/account-layer-refactorfrom
poc/account-layer-frontend-consumer

Conversation

@christian-byrne

@christian-byrne christian-byrne commented Sep 3, 2026 •

Copy link
Copy Markdown
Contributor

PoC do not merge: evidence review only.

  • ComfyUI_frontend consumer participates in the shared account layer.
  • Final matrix: 153 proven, 82 partial, no failures.
  • Pushed head is e06e306dcb; the PoC branch will be torn down on 2026-09-30 if no release owner is named.
Full context for agent readers

What this PR proves

ComfyUI_frontend consumer uses @comfyorg/account behind a proof-of-concept seam. This PR bases on the producer branch poc/account-layer-refactor and carries the package byte-identically. The package now initializes Firebase, owns sign-in state, and exchanges Firebase ID tokens for workspace tokens; the host supplies only storage, transport, time, and navigation adapters.

After this identity refactor, local typecheck, lint, unit tests, and build passed. End-to-end login, credits, and payments flows were not rerun against real Firebase and Stripe test credentials. Before the refactor, staging validation across the consumers covered login, credits, Stripe test-mode checkout, top-up, subscription, coupon, and 3DS states.

Not proven

  • Coupons: the backend exposes no coupon control; FREE subscribe opens setup-mode hosted Checkout with no promotion-code control.
  • A real checkout rendered inside the settings-dialog host: P0-13 is partial because only state-machine equivalence was proven.
  • Fixture C invoice-stage 3DS: Stripe's hosted invoice hCaptcha blocked completion.
  • Automated fixture provisioning: Cloudflare Turnstile protects POST /customers.
  • The platform payments specification with parallel workers: it must run with --workers=1; the remaining red row is a harness navigation flake, not a product defect.

The pushed and current head is e06e306dcb. The PoC branch will be torn down on 2026-09-30 if no release owner is named.

Links

Glossary

  • 3DS: Bank verification during card payment.
  • PoC: Proof of concept used to test the design.
  • Pushed head: Latest commit currently visible on GitHub.

@coderabbitai

coderabbitai Bot commented Sep 3, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: 5e733cf1-0f65-41c9-90bd-3bb53fdb9dd0

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 3, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: 🕵🏻 0 passed, 0 failed

📊 Browser Reports
  • chromium: ❌ Deployment failed
  • chromium-2x: ❌ Deployment failed
  • chromium-0.5x: ❌ Deployment failed
  • mobile-chrome: ❌ Deployment failed

🎨 Storybook: ❌ Failed

Details

⏰ Completed at: 09/11/2026, 07:38:40 PM UTC

Links

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance

⚠️ Performance tests failed. Check the CI workflow logs.

🔬 E2E Coverage

⚠️ Coverage collection failed. Check the CI workflow logs.

🌐 Website E2E

Caution

Some tests failed.

Status ❌ Failed
Report unavailable
Screenshot diffs 0
Other failures 0

@codecov

codecov Bot commented Sep 3, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 106 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/platform/account/accountClient.ts 0.00% 80 Missing ⚠️
src/main.ts 0.00% 15 Missing ⚠️
src/platform/account/AccountLayerPoc.vue 0.00% 11 Missing ⚠️
@@                      Coverage Diff                       @@
##           poc/account-layer-refactor   #16729      +/-   ##
==============================================================
+ Coverage                       80.75%   81.57%   +0.81%     
==============================================================
  Files                            2442     2032     -410     
  Lines                          124678   119965    -4713     
  Branches                        33481    30340    -3141     
==============================================================
- Hits                           100687    97858    -2829     
+ Misses                          23488    21933    -1555     
+ Partials                          503      174     -329     
Flag Coverage Δ
unit 76.48% <0.00%> (-0.23%) ⬇️
website-unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/account/src/core/index.ts 90.90% <ø> (ø)
src/App.vue 26.82% <ø> (ø)
src/platform/account/AccountLayerPoc.vue 0.00% <0.00%> (ø)
src/main.ts 28.12% <0.00%> (-11.01%) ⬇️
src/platform/account/accountClient.ts 0.00% <0.00%> (ø)

... and 526 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[PoC do not merge] Adds provider-neutral billing clients, state, polling, safety copy, Vue projection, and evidence tests.
@dante01yoon

Copy link
Copy Markdown
Collaborator

Salvage note (FE-2211): the billing subtree at d059104ac3 is retained at tag salvage/poc-account-layer-billing-d059104ac3 and branch salvage/poc-account-layer-refactor ahead of the 2026-09-30 teardown. Phase 3 of the billing SDK re-seats this behavior on the merged session client (#17655 → #17656 → #17657 / #17658 → #17659); the stack diagram is in the Billing SDK implementation plan (V2). No action requested on this PR.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:R3 PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants