Repository navigation
test: migrate composable mocks to import() - #17176
Conversation
🎭 Playwright: ✅ 1940 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle: 9.83 MB gzip ⚪ 0 BDetailsSummary
Category Glance App Entry Points — 3.73 kB (baseline 3.73 kB) • ⚪ 0 BMain entry bundles and manifests Status: 1 unchanged Graph Workspace — 1.43 MB (baseline 1.43 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration Status: 3 unchanged Views & Navigation — 128 kB (baseline 128 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 18 unchanged Panels & Settings — 622 kB (baseline 622 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 27 unchanged User & Accounts — 28.9 kB (baseline 28.9 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 11 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 8 unchanged UI Components — 118 kB (baseline 118 kB) • ⚪ 0 BReusable component library chunks Status: 15 unchanged Data & Services — 3.64 MB (baseline 3.64 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 16 unchanged Utilities & Hooks — 557 kB (baseline 557 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 36 unchanged Vendor & Third-Party — 18.2 MB (baseline 18.2 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 16.8 MB (baseline 16.8 MB) • ⚪ 0 BBundles that do not match a named category Status: 297 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-09T01:13:03.718Z",
"gitSha": "46803db5bb6a9bb31d65ff8bf000c97bf1b222dd",
"branch": "test/import-mocks-composables",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2022.3290000000134,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.662000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 474.9960000000001,
"heapDeltaBytes": 11645420,
"heapUsedBytes": 72726428,
"domNodes": -263,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 9.128,
"eventListeners": -154,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 1990.5109999999695,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.187999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 351.22200000000004,
"heapDeltaBytes": -948664,
"heapUsedBytes": 61068048,
"domNodes": -263,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 8.306000000000001,
"eventListeners": -184,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2045.9169999999745,
"styleRecalcs": 78,
"styleRecalcDurationMs": 32.351,
"layouts": 14,
"layoutDurationMs": 4.779,
"taskDurationMs": 988.034,
"heapDeltaBytes": 4947704,
"heapUsedBytes": 65913064,
"domNodes": -265,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 183.85,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1826.4189999999871,
"styleRecalcs": 75,
"styleRecalcDurationMs": 26.126000000000005,
"layouts": 14,
"layoutDurationMs": 4.35,
"taskDurationMs": 828.5989999999999,
"heapDeltaBytes": 7356724,
"heapUsedBytes": 68617976,
"domNodes": -261,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 147.764,
"eventListeners": -186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1752.787000000012,
"styleRecalcs": 31,
"styleRecalcDurationMs": 19.342,
"layouts": 6,
"layoutDurationMs": 1.563,
"taskDurationMs": 374.75800000000004,
"heapDeltaBytes": 1730768,
"heapUsedBytes": 63960100,
"domNodes": 76,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 12.678000000000003,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1739.7589999999354,
"styleRecalcs": 33,
"styleRecalcDurationMs": 15.274,
"layouts": 6,
"layoutDurationMs": 1.0160000000000002,
"taskDurationMs": 326.104,
"heapDeltaBytes": 2167980,
"heapUsedBytes": 64067956,
"domNodes": 77,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 10.794000000000002,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 614.485000000002,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.674,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 429.6599999999999,
"heapDeltaBytes": 17562044,
"heapUsedBytes": 79637704,
"domNodes": 18,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 154.86700000000002,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 611.3190000000372,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.564999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 430.92299999999994,
"heapDeltaBytes": 17941240,
"heapUsedBytes": 79655708,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 156.99,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2032.0879999999875,
"styleRecalcs": 6,
"styleRecalcDurationMs": 4.538,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 560.749,
"heapDeltaBytes": 3956736,
"heapUsedBytes": 83630604,
"domNodes": -246,
"jsHeapTotalBytes": -1056768,
"scriptDurationMs": 32.51899999999999,
"eventListeners": -154,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2011.3299999999867,
"styleRecalcs": 6,
"styleRecalcDurationMs": 4.550000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 441.50800000000004,
"heapDeltaBytes": 3097036,
"heapUsedBytes": 82283736,
"domNodes": -245,
"jsHeapTotalBytes": -794624,
"scriptDurationMs": 33.291999999999994,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2145.0249999999755,
"styleRecalcs": 63,
"styleRecalcDurationMs": 9.031999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1560.9650000000001,
"heapDeltaBytes": 14919560,
"heapUsedBytes": 79400540,
"domNodes": 2,
"jsHeapTotalBytes": 1273856,
"scriptDurationMs": 798.513,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2163.182000000006,
"styleRecalcs": 65,
"styleRecalcDurationMs": 10.219,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1479.912,
"heapDeltaBytes": 14766532,
"heapUsedBytes": 78595992,
"domNodes": -251,
"jsHeapTotalBytes": 1536000,
"scriptDurationMs": 765.721,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3463.9760000000024,
"styleRecalcs": 61,
"styleRecalcDurationMs": 10.861999999999997,
"layouts": 60,
"layoutDurationMs": 12.522000000000002,
"taskDurationMs": 1617.676,
"heapDeltaBytes": 8067068,
"heapUsedBytes": 73580220,
"domNodes": 2,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 763.9309999999999,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3420.963000000029,
"styleRecalcs": 61,
"styleRecalcDurationMs": 10.877999999999998,
"layouts": 60,
"layoutDurationMs": 12.314000000000002,
"taskDurationMs": 1599.8439999999998,
"heapDeltaBytes": 9746416,
"heapUsedBytes": 75156476,
"domNodes": 2,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 752.844,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3089.1390000000456,
"styleRecalcs": 45,
"styleRecalcDurationMs": 10.508,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1945.0720000000001,
"heapDeltaBytes": -10752640,
"heapUsedBytes": 79514604,
"domNodes": -257,
"jsHeapTotalBytes": 1495040,
"scriptDurationMs": 981.617,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3148.996000000011,
"styleRecalcs": 45,
"styleRecalcDurationMs": 10.104000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1957.314,
"heapDeltaBytes": -17536496,
"heapUsedBytes": 72404828,
"domNodes": -229,
"jsHeapTotalBytes": 1339392,
"scriptDurationMs": 993.6669999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2022.2099999999728,
"styleRecalcs": 5,
"styleRecalcDurationMs": 3.325999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 556.5989999999999,
"heapDeltaBytes": -3993176,
"heapUsedBytes": 83089788,
"domNodes": -251,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 33.467,
"eventListeners": -154,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2026.4089999999442,
"styleRecalcs": 6,
"styleRecalcDurationMs": 4.136999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 542.7850000000001,
"heapDeltaBytes": -3017912,
"heapUsedBytes": 83809968,
"domNodes": -249,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 38.951,
"eventListeners": -154,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 561.3549999999918,
"styleRecalcs": 47,
"styleRecalcDurationMs": 9.799999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 389.737,
"heapDeltaBytes": 13539956,
"heapUsedBytes": 76664860,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 140.768,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 535.7709999999543,
"styleRecalcs": 47,
"styleRecalcDurationMs": 9.844999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 348.1449999999999,
"heapDeltaBytes": 13119380,
"heapUsedBytes": 76207896,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 137.518,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2014.1040000000316,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.674000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 448.346,
"heapDeltaBytes": -8159472,
"heapUsedBytes": 54620624,
"domNodes": -278,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 7.438000000000001,
"eventListeners": -200,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2008.2079999999678,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.901000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 457.2660000000001,
"heapDeltaBytes": 11477388,
"heapUsedBytes": 74489748,
"domNodes": -276,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 7.352999999999998,
"eventListeners": -200,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1706.9060000000036,
"styleRecalcs": 77,
"styleRecalcDurationMs": 25.034,
"layouts": 18,
"layoutDurationMs": 4.8580000000000005,
"taskDurationMs": 721.289,
"heapDeltaBytes": 831516,
"heapUsedBytes": 64044596,
"domNodes": -274,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 98.61800000000001,
"eventListeners": -232,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1693.4239999999932,
"styleRecalcs": 77,
"styleRecalcDurationMs": 26.021,
"layouts": 18,
"layoutDurationMs": 5.382,
"taskDurationMs": 758.4920000000001,
"heapDeltaBytes": 9241464,
"heapUsedBytes": 72073184,
"domNodes": -274,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 103.72999999999999,
"eventListeners": -200,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 1351.1359999999968,
"styleRecalcs": 17,
"styleRecalcDurationMs": 27.410000000000004,
"layouts": 5,
"layoutDurationMs": 11.659999999999998,
"taskDurationMs": 856.803,
"heapDeltaBytes": 19334496,
"heapUsedBytes": 99466036,
"domNodes": 13587,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 27.826000000000004,
"eventListeners": 2387,
"totalBlockingTimeMs": 124,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8204.548000000046,
"styleRecalcs": 248,
"styleRecalcDurationMs": 36.954,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5475.238,
"heapDeltaBytes": -13297304,
"heapUsedBytes": 66170896,
"domNodes": -245,
"jsHeapTotalBytes": 3661824,
"scriptDurationMs": 2600.775,
"eventListeners": -138,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8311.671000000046,
"styleRecalcs": 247,
"styleRecalcDurationMs": 37.095000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5449.340999999999,
"heapDeltaBytes": -14072284,
"heapUsedBytes": 64961012,
"domNodes": -249,
"jsHeapTotalBytes": 1302528,
"scriptDurationMs": 2555.887,
"eventListeners": -168,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17456.74600000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16697.538,
"heapDeltaBytes": -20067304,
"heapUsedBytes": 174239368,
"domNodes": -6542,
"jsHeapTotalBytes": 4386816,
"scriptDurationMs": 277.40500000000003,
"eventListeners": -7476,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17017.61799999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16486.354000000003,
"heapDeltaBytes": -41050160,
"heapUsedBytes": 159440876,
"domNodes": -6542,
"jsHeapTotalBytes": -3252224,
"scriptDurationMs": 287.89799999999997,
"eventListeners": -7478,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21203.081,
"styleRecalcs": 162,
"styleRecalcDurationMs": 17.64899999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20836.904,
"heapDeltaBytes": -12702260,
"heapUsedBytes": 190091372,
"domNodes": -6542,
"jsHeapTotalBytes": -2068480,
"scriptDurationMs": 896.977,
"eventListeners": -7474,
"totalBlockingTimeMs": 321,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 16142.153000000008,
"styleRecalcs": 99,
"styleRecalcDurationMs": 13.72699999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15608.269999999999,
"heapDeltaBytes": -22271080,
"heapUsedBytes": 187115260,
"domNodes": -6542,
"jsHeapTotalBytes": 9588736,
"scriptDurationMs": 807.398,
"eventListeners": -7478,
"totalBlockingTimeMs": 24,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6179.708000000005,
"styleRecalcs": 20,
"styleRecalcDurationMs": 72.24900000000001,
"layouts": 20,
"layoutDurationMs": 23.137000000000004,
"taskDurationMs": 6110.290000000001,
"heapDeltaBytes": -27350752,
"heapUsedBytes": 172415952,
"domNodes": -6542,
"jsHeapTotalBytes": 19374080,
"scriptDurationMs": 112.70900000000002,
"eventListeners": -7478,
"totalBlockingTimeMs": 369,
"frameDurationMs": 17.779999999999987,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 6179.937999999993,
"styleRecalcs": 20,
"styleRecalcDurationMs": 71.68200000000002,
"layouts": 20,
"layoutDurationMs": 22.744,
"taskDurationMs": 6004.29,
"heapDeltaBytes": -14171816,
"heapUsedBytes": 178851704,
"domNodes": -6542,
"jsHeapTotalBytes": 16228352,
"scriptDurationMs": 113.302,
"eventListeners": -7476,
"totalBlockingTimeMs": 346,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8937.566000000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8501.837000000001,
"heapDeltaBytes": -22498768,
"heapUsedBytes": 167842576,
"domNodes": 0,
"jsHeapTotalBytes": -11534336,
"scriptDurationMs": 148.02300000000002,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8928.421000000071,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8431.468,
"heapDeltaBytes": -23139640,
"heapUsedBytes": 167682152,
"domNodes": 0,
"jsHeapTotalBytes": -10747904,
"scriptDurationMs": 140.07100000000005,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 484.862000000021,
"styleRecalcs": 19,
"styleRecalcDurationMs": 26.941999999999997,
"layouts": 5,
"layoutDurationMs": 2.429,
"taskDurationMs": 139.208,
"heapDeltaBytes": 5235260,
"heapUsedBytes": 66801192,
"domNodes": 149,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 16.911,
"eventListeners": 83,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "workflow-execution",
"durationMs": 113.27499999993051,
"styleRecalcs": 9,
"styleRecalcDurationMs": 15.512999999999998,
"layouts": 2,
"layoutDurationMs": 1.1420000000000001,
"taskDurationMs": 78.121,
"heapDeltaBytes": 3005040,
"heapUsedBytes": 64762028,
"domNodes": 128,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 5.748000000000001,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (85)
Included review availability: Your plan provides up to 10 included reviews per hour; 1 remains after this review. 📝 WalkthroughWalkthroughThe pull request updates Vitest mocks across composable tests to use typed dynamic-import references. Several tests now use real Vue I18n or Pinia instances. Mock behavior and assertions remain unchanged. ChangesVitest mock migration
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Refactor Merge Risk: ⚪ Minimal · up to This change updates test mock declarations and test harness setup without changing production behavior. The supplied validation reports indicate the updated tests remain healthy, with no current merge-blocking risk identified. Possibly related PRs
Suggested reviewers: Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 inconclusive)
✅ Passed checks (6 passed)
Full details: End-To-End Regression Coverage For FixesExplanation The changed-file information is available, but the PR title and commit subjects are not available in the review context. The check requires those metadata fields to determine whether bug-fix language is present. The description states that this is a mechanical test-mock migration and does not provide a concrete end-to-end-test rationale, but that is insufficient to establish the required bug-fix condition. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #17176 +/- ##
==========================================
+ Coverage 81.65% 83.11% +1.46%
==========================================
Files 2506 2063 -443
Lines 128206 120326 -7880
Branches 33097 33001 -96
==========================================
- Hits 104687 100013 -4674
+ Misses 22998 20132 -2866
+ Partials 521 181 -340
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
AustinMroz
left a comment
There was a problem hiding this comment.
More of the empty new lines here, but not as bad as the prior PR
| })) | ||
| vi.mock<unknown>( | ||
| import('@/renderer/core/canvas/canvasStore'), | ||
|
|
There was a problem hiding this comment.
Removed the extra blank line in 456799d.
| vi.mock('@/stores/nodeOutputStore', () => ({ | ||
| vi.mock<unknown>( | ||
| import('@/renderer/core/canvas/useCanvasInteractions'), | ||
|
|
There was a problem hiding this comment.
Removed the extra blank line in 456799d.
456799d
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
…assets flag, retire Comfy.Assets.UseAssetAPI (#18727) Manual backport of #17117 to `core/1.54`. The automated backport failed with merge conflicts (#17117 (comment)). Cherry-picked from dffad2d (`git cherry-pick -x`). ## Why #17117 retires the hidden `Comfy.Assets.UseAssetAPI` setting and the `Comfy.ToggleAssetAPI` command. The model library, sidebar tab and model store follow `useFeatureFlags().flags.assetsEnabled` (cloud, or the server advertises the `assets` feature). `Comfy.BrowseModelAssets` opens the browser through `openModelLibraryBrowser()`, and the widget asset-picker gate is renamed to `shouldUseWidgetAssetPicker` / `isWidgetAssetPickerEnabled` and fixed to `isCloud`. Without it, a stale persisted setting can still route the model library to `/api/assets` on a backend that doesn't serve it. ## Dependency check The bot flagged a possible stacking conflict with #18722, #18683, #18334 and #17872. None of the four touch any file changed by #17117, so they aren't the cause. The conflicts are real and come from main-only test refactors that aren't on `core/1.54`: the `vi.mock(import(...))` migrations (#17173, #17175, #17176, #17178, #17179) and the global-Pinia test migrations (#17231, #17234, #17235, #17236, #17237, #17270), plus #16891. All production code, locale, script and e2e changes applied cleanly. ## Conflict resolution All 7 conflicts were in unit tests. Each one keeps `core/1.54`'s mocking style (hoisted `vi.mock` stores, no global Pinia) and ports only the setting-to-flag change: - `src/components/sidebar/tabs/ModelLibrarySidebarTab.test.ts`: kept the target's store/download/setting mocks. Dropped the `Comfy.Assets.UseAssetAPI` branch and added a `useFeatureFlags` mock (`featureFlagState.assetsEnabled`) in its place. - `src/composables/useCoreCommands.test.ts`: kept the target's mocks and `createMockSettingStore`. Added the `useFeatureFlags` mock. The `BrowseModelAssets` tests toggle `assetsEnabled` instead of the setting. - `src/platform/assets/services/assetService.test.ts`: kept the target's imports and mocks. Took the rename to `shouldUseWidgetAssetPicker` and removed the setting-store mock. - `src/platform/assets/utils/assetPreviewUtil.test.ts`: kept the target's `vi.mock` style. Added the `useFeatureFlags` mock and removed the `isAssetAPIEnabled` / `getServerFeature` mocks. - `src/renderer/extensions/vueNodes/widgets/composables/useComboWidget.test.ts`: kept the target's two remote-combo tests, which are absent on main. Took the renamed test and the `shouldUseWidgetAssetPicker` mock. - `src/stores/modelStore.test.ts`: kept the target's `mockDistribution` mock. Took #17117's `remoteConfig` holder mock and reactive `serverFeatures` state, so the store's flag watcher fires and state doesn't leak between tests. - `src/stores/workspace/sidebarTabStore.test.ts`: kept the target's command/menu/setting store mocks. Added the `useFeatureFlags` and `openModelLibraryBrowser` mocks and dropped the `Comfy.Assets.UseAssetAPI` setting reads. No other changes from main are included. ## Validation - Static check: no remaining `Comfy.Assets.UseAssetAPI`, `isAssetAPIEnabled`, `shouldUseAssetBrowser`, `ToggleAssetAPI` or `usesAssetApi` references in `src`, `browser_tests`, `scripts` or `.github`. - `pnpm install --frozen-lockfile`: ok - `pnpm typecheck`: clean - `eslint`, `oxlint`, `oxfmt --check` on changed files: 0 errors - `vitest run` on the touched tests plus `src/stores`, `src/platform/assets`, `src/components/sidebar` and `src/composables/useFeatureFlags*`: 129 files, 2339 passed - `vitest run` on `scripts/checkAssetsFlagArtifact.test.ts`, `widgetInputs`, `missingModelPipeline`, `src/renderer/extensions/vueNodes/widgets` and `useCoreCommands`: 66 files, 960 passed - `vite build` followed by `EXPECTED_DISTRIBUTION=localhost EXPECTED_FRONTEND_COMMIT=<HEAD> pnpm test:assets-flag-artifact`: pass - Local e2e against a real ComfyUI backend without `--enable-assets` (`/api/features` reports `assets: false`), with a temporary request guard that is not included in this PR: - A walk of the sidebars, model library refresh, asset/model commands, missing-model workflows, upload and run, the assets sidebar, linear mode and vue-node dropdowns: 10/10 passed. This covered a user with a stale persisted `Comfy.Assets.UseAssetAPI=true`. No `/api/assets*` requests were made. - `browser_tests/tests/sidebar/modelLibrary.spec.ts`: 13/13 passed with no `/api/assets*` requests.
… assets flag, retire Comfy.Assets.UseAssetAPI (#18728) Manual backport of #17117 to `cloud/1.54`. Cherry-picked from dffad2d (`git cherry-pick -x`). ## Why Retires the hidden `Comfy.Assets.UseAssetAPI` setting and the `Comfy.ToggleAssetAPI` command. Asset surfaces (model library, sidebar routing, model store) follow `useFeatureFlags().flags.assetsEnabled`, and widget asset pickers are cloud-only under `isWidgetAssetPickerEnabled` / `shouldUseWidgetAssetPicker`. On the cloud build `assetsEnabled` is always true, so asset surfaces stay on, including for users who had set the hidden setting to `false`. That opt-out is retired on purpose. ## Dependency check The bot suggested this might be a stacking conflict with #18723 and #18644. It is not. Neither PR touches any of the conflicted files: #18723 changes agent workflow-resolver files, and #18644 changes lint/typecheck config and a few UI components. The conflict is real. All 7 conflicts are in test files, because `main` went through test-infra migrations that `cloud/1.54` doesn't have (global Pinia, `vi.mock(import())`, i18n mock cleanup: #17175, #17176, #17178, #17231, #17234–#17237, #17270, #16891). All production files, locales, e2e specs, `scripts/checkAssetsFlagArtifact.*` and `.github/actions/build-cloud-frontend/action.yaml` applied cleanly. ## Conflict resolution Test files kept the target branch's mocking style. Only the setting-to-flag change was ported. - `src/components/sidebar/tabs/ModelLibrarySidebarTab.test.ts`: kept the target's `settingState`/`modelsState`/`mockLoadModels` harness. Removed `useAssetAPI` from the settings mock, added a hoisted `featureFlagState` and a `useFeatureFlags` mock, and switched the two asset-mode tests to `featureFlagState.assetsEnabled = true`. - `src/composables/useCoreCommands.test.ts`: took #17117's `browseModelAssets()` helper. The auto-merged tests below it already use it and the existing `mockFeatureFlagState`. - `src/platform/assets/services/assetService.test.ts`: kept the target's module mocks and renamed the describe to `shouldUseWidgetAssetPicker`. Removed the now-dead `settingStore` mock, which referenced the dropped `mockSettingStoreGet`. `assetService` no longer reads settings. - `src/platform/assets/utils/assetPreviewUtil.test.ts`: added #17117's `useFeatureFlags` mock and kept the target's string-form `assetService` mock. - `src/renderer/extensions/vueNodes/widgets/composables/useComboWidget.test.ts`: kept the target's `axios` import and its two target-only tests (first-load lifecycle, loading inventory). Took #17117's renamed "widget asset picker is disabled" test. Dropped the unused `settingStore` mock, as #17117 did. - `src/stores/modelStore.test.ts`: took #17117's `remoteConfigHolder` + `featureState` mocks and the `enableMocks(assetsEnabled)` body. The auto-merged `beforeEach` depends on them, and they avoid cross-test leakage. - `src/stores/workspace/sidebarTabStore.test.ts`: kept the target's `mockGetSetting`/`registeredCommands` harness. Replaced the `commandStore.commands` / `mockBrowseModelAssets` stubs with #17117's `featureFlagState` and `openModelLibraryBrowser` mocks, and ported each routing test to set the flag instead of `Comfy.Assets.UseAssetAPI`. No remaining references to `Comfy.Assets.UseAssetAPI`, `isAssetAPIEnabled`, `shouldUseAssetBrowser`, `ToggleAssetAPI` or `usesAssetApi`. ## Validation - `pnpm typecheck`: clean - `eslint`, `oxlint`, `oxfmt --check` on changed files: clean - Vitest: touched tests plus `src/stores`, `src/platform/assets`, `src/components/sidebar`, `src/composables`, `src/renderer/extensions/vueNodes/widgets`, `src/platform/missingModel`, `src/extensions/core`, `scripts`. All pass (130 + 332 files). - `pnpm build:cloud` (`VITE_USE_LEGACY_DEFAULT_GRAPH=true`), then `EXPECTED_DISTRIBUTION=cloud pnpm test:assets-flag-artifact` against HEAD: pass. The same cloud dist checked with `EXPECTED_DISTRIBUTION=localhost` correctly fails. - `pnpm build`, then `EXPECTED_DISTRIBUTION=localhost pnpm test:assets-flag-artifact`: pass - Playwright, cloud project on the cloud dist (`browseModelAssets`, `cloud-asset-promoted-widget`, `errorsTabCloudMissingModels`, `checkoutRecovery`, `pricingTableDeepLink`): 30/30. The first run had one timing failure in `cloud-asset-promoted-widget`. It passed 3/3 in isolation and on a full rerun. - `knip` (pre-push hook): clean - Playwright, chromium project on the localhost dist (`modelLibraryAssetMode`, `modelLibraryRouting`, `browseModelAssets`): 19/19
Summary
Migrates legacy
vi.mockcalls in shared composable tests to the dynamicimport()form as an independent slice of #16174.Changes
<unknown>to preserve the string overload's existing type contract.Review Focus
This is a mechanical syntax migration. The lint rule and documentation are intentionally deferred until every domain slice has merged.
Verified with the full pre-commit lint/typecheck gates,
pnpm knip, and the combined unit suite (1,506 files; 20,337 passed).