Repository navigation
test: add second automock foundation batch - #17958
Conversation
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 2072 passed, 0 failed · 1 flaky📊 Browser Reports
📦 Bundle: 9.96 MB gzip 🔴 +1.87 MBDetailsSummary
Category Glance App Entry Points — 3.85 kB (baseline 3.64 kB) • 🔴 +208 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.46 MB (baseline 1.25 MB) • 🔴 +212 kBGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 1 removed / 1 shrank Views & Navigation — 132 kB (baseline 112 kB) • 🔴 +20 kBTop-level views, pages, and routed surfaces
Status: 17 added / 15 removed / 1 shrank Panels & Settings — 638 kB (baseline 551 kB) • 🔴 +87.6 kBConfiguration panels, inspectors, and settings screens
Status: 28 added / 26 removed User & Accounts — 37.9 kB (baseline 29.1 kB) • 🔴 +8.83 kBAuthentication, profile, and account management bundles
Status: 11 added / 10 removed Editors & Dialogs — 126 kB (baseline 121 kB) • 🔴 +4.96 kBModals, dialogs, drawers, and in-app editors
Status: 8 added / 6 removed UI Components — 123 kB (baseline 64.7 kB) • 🔴 +58.7 kBReusable component library chunks
Status: 16 added / 14 removed Data & Services — 3.87 MB (baseline 3.37 MB) • 🔴 +497 kBStores, services, APIs, and repositories
Status: 16 added / 17 removed Utilities & Hooks — 575 kB (baseline 357 kB) • 🔴 +217 kBHelpers, composables, and utility bundles
Status: 38 added / 35 removed Vendor & Third-Party — 17.4 MB (baseline 15.7 MB) • 🔴 +1.71 MBExternal libraries and shared vendor chunks
Status: 18 added / 16 removed Other — 17.8 MB (baseline 12.4 MB) • 🔴 +5.43 MBBundles that do not match a named category
Status: 190 added / 164 removed / 110 shrank / 1 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-21T19:08:58.441Z",
"gitSha": "6e419d3b25d6a7eeee102f9e41c2532021dfdf2d",
"branch": "test/automock-foundations-batch-2",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 1992.053999999996,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.448000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 357.195,
"heapDeltaBytes": 13437664,
"heapUsedBytes": 75406248,
"domNodes": -260,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 11.665999999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2005.9929999999895,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.890999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 448.6,
"heapDeltaBytes": -1698740,
"heapUsedBytes": 60336684,
"domNodes": -263,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 8.340999999999998,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1746.7629999999872,
"styleRecalcs": 73,
"styleRecalcDurationMs": 23.089000000000002,
"layouts": 14,
"layoutDurationMs": 3.875,
"taskDurationMs": 789.599,
"heapDeltaBytes": 18208008,
"heapUsedBytes": 80242168,
"domNodes": -262,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 139.471,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1744.3399999999656,
"styleRecalcs": 75,
"styleRecalcDurationMs": 25.139000000000003,
"layouts": 14,
"layoutDurationMs": 4.128,
"taskDurationMs": 805.4639999999999,
"heapDeltaBytes": 18681992,
"heapUsedBytes": 80255476,
"domNodes": -264,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 140.475,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1718.0549999999926,
"styleRecalcs": 31,
"styleRecalcDurationMs": 14.521,
"layouts": 6,
"layoutDurationMs": 1.1969999999999998,
"taskDurationMs": 335.806,
"heapDeltaBytes": 2152512,
"heapUsedBytes": 64166012,
"domNodes": 74,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 12.635999999999997,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1722.7349999999433,
"styleRecalcs": 31,
"styleRecalcDurationMs": 13.543000000000001,
"layouts": 6,
"layoutDurationMs": 0.977,
"taskDurationMs": 318.85200000000003,
"heapDeltaBytes": 2382060,
"heapUsedBytes": 63682484,
"domNodes": 75,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 12.153,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 615.4859999999758,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.15,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 434.41300000000007,
"heapDeltaBytes": 18205976,
"heapUsedBytes": 80271136,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 160.713,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 623.0409999999438,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.332999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 431.88900000000007,
"heapDeltaBytes": 18932720,
"heapUsedBytes": 86242708,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 152.955,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1148.980999999992,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 813.032,
"heapDeltaBytes": 34960152,
"heapUsedBytes": 107306768,
"domNodes": 0,
"jsHeapTotalBytes": 21393408,
"scriptDurationMs": 66.55600000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 535,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1136.743000000024,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 795.6589999999999,
"heapDeltaBytes": 34413212,
"heapUsedBytes": 102316388,
"domNodes": 0,
"jsHeapTotalBytes": 17985536,
"scriptDurationMs": 66.365,
"eventListeners": 0,
"totalBlockingTimeMs": 525,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 811.0140000000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 425.8639999999998,
"heapDeltaBytes": 14349484,
"heapUsedBytes": 90275948,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 132.262,
"eventListeners": 0,
"totalBlockingTimeMs": 193,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 813.6690000000044,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 437.0660000000002,
"heapDeltaBytes": 14018636,
"heapUsedBytes": 89255844,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 145.96399999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 188,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9566.002000000026,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8694.755000000001,
"heapDeltaBytes": -16047360,
"heapUsedBytes": 83498752,
"domNodes": -275,
"jsHeapTotalBytes": 5795840,
"scriptDurationMs": 6928.059,
"eventListeners": -174,
"totalBlockingTimeMs": 442,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 33.30000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 8146.483999999987,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7365.621,
"heapDeltaBytes": 11168500,
"heapUsedBytes": 93087804,
"domNodes": -16,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 6075.063,
"eventListeners": 0,
"totalBlockingTimeMs": 175,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9401.009999999986,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8498.135999999999,
"heapDeltaBytes": 11094336,
"heapUsedBytes": 93572228,
"domNodes": -14,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 6867.130999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 315,
"frameDurationMs": 17.779999999999987,
"p95FrameDurationMs": 33.20000000000073
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 8929.579999999987,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8062.154999999999,
"heapDeltaBytes": -3865120,
"heapUsedBytes": 71180588,
"domNodes": -6,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 6421.744,
"eventListeners": 0,
"totalBlockingTimeMs": 82,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "large-graph-idle",
"durationMs": 2020.3050000000076,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.764999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 546.061,
"heapDeltaBytes": 2034056,
"heapUsedBytes": 83411304,
"domNodes": -251,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 36.08700000000001,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2029.2650000000094,
"styleRecalcs": 6,
"styleRecalcDurationMs": 4.841000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 437.7470000000001,
"heapDeltaBytes": 1928736,
"heapUsedBytes": 82858544,
"domNodes": -248,
"jsHeapTotalBytes": -1806336,
"scriptDurationMs": 39.022,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2243.139000000042,
"styleRecalcs": 65,
"styleRecalcDurationMs": 9.114,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1531.6459999999997,
"heapDeltaBytes": -1678660,
"heapUsedBytes": 80483784,
"domNodes": -254,
"jsHeapTotalBytes": 778240,
"scriptDurationMs": 764.379,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2203.8310000000365,
"styleRecalcs": 64,
"styleRecalcDurationMs": 8.863,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1556.485,
"heapDeltaBytes": 15900232,
"heapUsedBytes": 80059420,
"domNodes": -254,
"jsHeapTotalBytes": 1011712,
"scriptDurationMs": 792.42,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3506.191000000001,
"styleRecalcs": 61,
"styleRecalcDurationMs": 9.762000000000004,
"layouts": 60,
"layoutDurationMs": 12.604999999999999,
"taskDurationMs": 1625.102,
"heapDeltaBytes": 8775616,
"heapUsedBytes": 74751808,
"domNodes": 2,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 750.846,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3533.3520000000362,
"styleRecalcs": 61,
"styleRecalcDurationMs": 9.551999999999998,
"layouts": 60,
"layoutDurationMs": 12.502999999999998,
"taskDurationMs": 1605.979,
"heapDeltaBytes": 8751832,
"heapUsedBytes": 74420688,
"domNodes": 2,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 744.121,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2988.142000000039,
"styleRecalcs": 41,
"styleRecalcDurationMs": 5.364000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1821.043,
"heapDeltaBytes": 18863900,
"heapUsedBytes": 85367416,
"domNodes": 2,
"jsHeapTotalBytes": 1728512,
"scriptDurationMs": 914.4920000000001,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "legacy-node-drag",
"durationMs": 3020.660000000021,
"styleRecalcs": 42,
"styleRecalcDurationMs": 5.683999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1841.6270000000004,
"heapDeltaBytes": 22948308,
"heapUsedBytes": 89124444,
"domNodes": 4,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 927.2640000000001,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2042.6180000000045,
"styleRecalcs": 6,
"styleRecalcDurationMs": 8.729999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 582.6339999999999,
"heapDeltaBytes": -8079308,
"heapUsedBytes": 80139356,
"domNodes": -253,
"jsHeapTotalBytes": 290816,
"scriptDurationMs": 34.428,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2023.0579999999918,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.485999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 570.293,
"heapDeltaBytes": -6963592,
"heapUsedBytes": 81865152,
"domNodes": -251,
"jsHeapTotalBytes": -233472,
"scriptDurationMs": 34.36600000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 589.5349999999553,
"styleRecalcs": 48,
"styleRecalcDurationMs": 11.739,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 399.775,
"heapDeltaBytes": 14461600,
"heapUsedBytes": 78131208,
"domNodes": 22,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 139.281,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 558.695000000057,
"styleRecalcs": 48,
"styleRecalcDurationMs": 10.305,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 346.0300000000001,
"heapDeltaBytes": 14466328,
"heapUsedBytes": 77910224,
"domNodes": 22,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 134.26399999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2008.6350000000266,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.741,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 444.75199999999995,
"heapDeltaBytes": 2325520,
"heapUsedBytes": 65869276,
"domNodes": -275,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 8.639000000000001,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2017.4260000000004,
"styleRecalcs": 9,
"styleRecalcDurationMs": 5.881999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 447.798,
"heapDeltaBytes": -1440464,
"heapUsedBytes": 62240328,
"domNodes": -277,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 8.501999999999999,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1709.9329999999782,
"styleRecalcs": 78,
"styleRecalcDurationMs": 23.529,
"layouts": 18,
"layoutDurationMs": 4.542000000000001,
"taskDurationMs": 737.636,
"heapDeltaBytes": 689544,
"heapUsedBytes": 64179240,
"domNodes": -274,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 88.31,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1690.4050000000552,
"styleRecalcs": 77,
"styleRecalcDurationMs": 24.643,
"layouts": 18,
"layoutDurationMs": 4.872999999999999,
"taskDurationMs": 786.428,
"heapDeltaBytes": 325500,
"heapUsedBytes": 63772012,
"domNodes": -275,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 102.843,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1333.925000000022,
"styleRecalcs": 17,
"styleRecalcDurationMs": 25.101,
"layouts": 5,
"layoutDurationMs": 10.852999999999998,
"taskDurationMs": 832.691,
"heapDeltaBytes": -6239452,
"heapUsedBytes": 81036560,
"domNodes": 13667,
"jsHeapTotalBytes": 11534336,
"scriptDurationMs": 30.166000000000004,
"eventListeners": 2383,
"totalBlockingTimeMs": 125,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8258.870000000003,
"styleRecalcs": 250,
"styleRecalcDurationMs": 34.662,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5665.153,
"heapDeltaBytes": -2367012,
"heapUsedBytes": 79047688,
"domNodes": -244,
"jsHeapTotalBytes": -1056768,
"scriptDurationMs": 2674.8720000000003,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8221.891999999913,
"styleRecalcs": 249,
"styleRecalcDurationMs": 33.434,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5460.618,
"heapDeltaBytes": -12780204,
"heapUsedBytes": 68205616,
"domNodes": -244,
"jsHeapTotalBytes": 4222976,
"scriptDurationMs": 2561.764,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 15071.688999999991,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14770.273,
"heapDeltaBytes": -37116220,
"heapUsedBytes": 180400428,
"domNodes": -8061,
"jsHeapTotalBytes": -14094336,
"scriptDurationMs": 250.874,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 14711.085999999908,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14273.311,
"heapDeltaBytes": -33127088,
"heapUsedBytes": 197051108,
"domNodes": -8061,
"jsHeapTotalBytes": -9424896,
"scriptDurationMs": 222.99599999999998,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.216666666666665,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 18072.102000000028,
"styleRecalcs": 138,
"styleRecalcDurationMs": 15.30999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17872.862999999998,
"heapDeltaBytes": -56377292,
"heapUsedBytes": 166933568,
"domNodes": -8061,
"jsHeapTotalBytes": -17764352,
"scriptDurationMs": 879.515,
"eventListeners": -14928,
"totalBlockingTimeMs": 137,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 18216.30700000003,
"styleRecalcs": 143,
"styleRecalcDurationMs": 14.91400000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18007.862,
"heapDeltaBytes": -27339204,
"heapUsedBytes": 190617864,
"domNodes": -8061,
"jsHeapTotalBytes": -10678272,
"scriptDurationMs": 859.474,
"eventListeners": -14928,
"totalBlockingTimeMs": 60,
"frameDurationMs": 17.223333333333237,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 5431.312000000048,
"styleRecalcs": 20,
"styleRecalcDurationMs": 72.963,
"layouts": 20,
"layoutDurationMs": 22.928000000000004,
"taskDurationMs": 5355.806,
"heapDeltaBytes": -53688836,
"heapUsedBytes": 169456312,
"domNodes": -8061,
"jsHeapTotalBytes": 4984832,
"scriptDurationMs": 93.085,
"eventListeners": -14928,
"totalBlockingTimeMs": 254,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 5371.082999999999,
"styleRecalcs": 20,
"styleRecalcDurationMs": 74.52300000000001,
"layouts": 20,
"layoutDurationMs": 22.958999999999993,
"taskDurationMs": 5304.955999999999,
"heapDeltaBytes": -27853248,
"heapUsedBytes": 188588512,
"domNodes": -8060,
"jsHeapTotalBytes": 4599808,
"scriptDurationMs": 89.583,
"eventListeners": -14928,
"totalBlockingTimeMs": 274,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 5345.056999999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5143.802000000001,
"heapDeltaBytes": -9090944,
"heapUsedBytes": 182155008,
"domNodes": 0,
"jsHeapTotalBytes": -10223616,
"scriptDurationMs": 84.95600000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333237,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7361.795000000029,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7150.151999999998,
"heapDeltaBytes": 11341032,
"heapUsedBytes": 183840652,
"domNodes": 0,
"jsHeapTotalBytes": -16252928,
"scriptDurationMs": 108.27399999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 467.98200000000634,
"styleRecalcs": 21,
"styleRecalcDurationMs": 23.563000000000002,
"layouts": 5,
"layoutDurationMs": 2.344,
"taskDurationMs": 134.18,
"heapDeltaBytes": 5369732,
"heapUsedBytes": 67312204,
"domNodes": 151,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 15.212,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "workflow-execution",
"durationMs": 462.39600000001246,
"styleRecalcs": 14,
"styleRecalcDurationMs": 19.365000000000002,
"layouts": 3,
"layoutDurationMs": 0.9079999999999999,
"taskDurationMs": 109.40999999999998,
"heapDeltaBytes": 4861232,
"heapUsedBytes": 66620268,
"domNodes": 121,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 8.979,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 010353273c44c5e65bd979cbffa0e4f71153d072
Full docs: ADR-DEVEX-LINT-0015 🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
|
Understand this PR’s impact Explore downstream dependencies and potential security impact with Blast Radius. Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
Included review availability: 4 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 10 reviews per hour. 📝 WalkthroughWalkthroughThe pull request adds shared typed Vitest mocks for composables and services. Billing, command, node, and layout tests now use automatic module mocks and shared mocked instances. ChangesVitest mock standardization
Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Other Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 7✅ Passed checks (7 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## main #17958 +/- ##
==========================================
+ Coverage 83.21% 84.21% +0.99%
==========================================
Files 2960 2271 -689
Lines 146135 129159 -16976
Branches 37738 32973 -4765
==========================================
- Hits 121612 108765 -12847
+ Misses 23246 20098 -3148
+ Partials 1277 296 -981
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 702 files with indirect coverage changes 🚀 New features to boost your workflow:
|
dante01yoon
left a comment
There was a problem hiding this comment.
Reviewed at c7b6b5d. Thanks for this — the direction is a clear improvement, and a few things are genuinely better rather than just neutral:
- The old inline mocks had drifted from production.
LGraphNode.test.tsandTransformPane.test.tswere both mockinguseTransformStatewithcanvasToScreen/isNodeInViewportkeys the real composable has never returned, andTransformPane'scamera: computed(() => …)was shaped as a ref where production returnsreadonly(reactive(…)). Typing the new mocks againstReturnType<typeof real…>turns that class of drift into a compile error. useCoreCommands.test.tswas mockingcanAccessSubscriptionFeaturesasvi.fn().mockReturnValue(true)where production exposes aComputedRef. Harmless only because the run gate reads it offuseBillingContext, but the automock removes it for good.useNodeDragToCanvasanduseCanvasInteractionsdefaults match the real module-level initial values (ref(false)/shallowRef(null)/shallowRef(), and!canvasStore.isReadOnly→truein the normal case), so adopters inherit production-faithful starting state.- The latest push is a real improvement on its own: dropping the
import * as realRemoteConfigvalue import for a type-only import removes the real module's import-timeuseStorageside effects, and annotatingremoteConfigModule: typeof realRemoteConfignow makes a missing or misnamed export a compile error instead of a silentundefined.
Validation I ran locally at c7b6b5d:
- Six converted suites: 6 files, 120 tests passed — matches your numbers.
remoteConfig/ feature-flag owner suites (refreshRemoteConfig.test.ts,useFeatureFlags.test.ts,comfyApi.test.ts): 3 files, 108 tests passed.pnpm typecheck: passes (all five projects).- Baselined
useBillingContext.test.tsagainstorigin/mainfirst to rule out local environment noise.
One blocking item — it survived the latest push unchanged, so I don't think it was the target of that edit. Details inline, with a reproduction.
Unanchored
- CI was still in flight on
c7b6b5dwhen I reviewed (unittestand most Playwright shardsin_progress, no failures yet). On the previous head756b882the only red check wasplaywright-tests-chromium-sharded (2, 16)→tests/changeTracker.spec.ts"receives undo all then redo all", failing through all 3 retries. That can't come from this diff — it touches only__mocks__modules and.test.tsfiles, and Playwright never loads Vitest__mocks__— so I'm noting it only so it isn't read as signal from this PR. src/utils/__mocks__/graphTraversalUtil.tshand-lists 35 re-exports with no type-level completeness guard, so a newly added export ingraphTraversalUtil.tswould silently beundefinedfor adopters. I checked and it is exhaustive today (36 exports: 35 re-exported +getNodeByLocatorIdmocked), and it matches the already-mergedsrc/utils/__mocks__/litegraphUtil.tsconvention, so I am explicitly not asking you to change it here. Worth a follow-up across both files, especially now thatremoteConfigshows thetypeof realModulepattern that would catch it.
| value = nextValue | ||
| trigger() | ||
|
|
||
| onTestFinished(() => { |
There was a problem hiding this comment.
issue: Calling onTestFinished from inside a customRef setter makes writing these refs unsafe outside a test body, and it throws rather than degrading.
A reactive setter can run from any context — a beforeAll / afterAll hook, a describe body, module scope, or a Vue effect flush — but onTestFinished requires an active test. A write from any of those fails hard, with an error that points into this mock rather than at the caller.
Reproduced at c7b6b5d:
// src/platform/remoteConfig/probe.test.ts
vi.mock(import('@/platform/remoteConfig/remoteConfig'))
describe('write from beforeAll', () => {
beforeAll(() => {
remoteConfig.value = { firebase_env: 'dev' }
})
it('reads the value seeded in beforeAll', () => {
expect(remoteConfig.value).toEqual({ firebase_env: 'dev' })
})
})FAIL src/platform/remoteConfig/probe.test.ts > write from beforeAll
Error: Hook onTestFinished() can only be called inside a test
❯ CustomRefImpl.set [as _set] src/platform/remoteConfig/__mocks__/remoteConfig.ts:18:7
Test Files 1 failed (1)
Tests 1 skipped (1)
I checked that beforeEach and afterEach writes are both fine, so no current adopter is broken — useBillingContext.test.ts writes in beforeEach and all 120 tests pass. This is about the contract of the foundation rather than today's behavior: seeding config once per file in beforeAll is a natural pattern for exactly these refs, and refreshRemoteConfig() writes all six of them after an await on the /features fetch (or after the 5s abort), so a late-settling or effect-flush write is reachable too. testScopedRemovableRef.remove() on line 30 routes through the same setter and inherits it.
Could we register the restore once per ref instead of once per write, so the hook never runs from the setter? A module-scope beforeEach(restoreAll) in this mock file would do it — the mock is imported during the adopter's collection, so the hook registers for that file — and it would read a bit more directly than restore-on-write. Any shape that keeps the lifecycle hook out of set works for me.
There was a problem hiding this comment.
Confirmed. The immediate failure is intentional and safer than leaking shared state. The repository guidance explicitly supports mutation in beforeEach or a test and says onTestFinished throwing from beforeAll or collection scope is intended. It also explicitly forbids beforeEach inside a mock module because cached modules and vi.resetModules() make that hook unreliable. The current adopter writes only from beforeEach and test bodies. Likewise, an asynchronous write that escapes the test that started it should fail rather than silently affect later tests. I am keeping this contract as-is.
There was a problem hiding this comment.
Tracked as FE-2628. The PR merged with this thread unresolved, so the finding is carried in Linear rather than lost here. Filed automatically; close the ticket if the finding is no longer true at main.
| isAuthenticatedConfigLoaded: computed( | ||
| () => remoteConfigStateRef.value === 'authenticated' | ||
| ), | ||
| configValueOrDefault(remoteConfig, key, defaultValue) { |
There was a problem hiding this comment.
question: The PR description says this mock "keeps the real generic configValueOrDefault", but as of c7b6b5d it is reimplemented here instead. I assume that is deliberate fallout from switching line 4 to a type-only import (you can't re-export a value from a module you no longer import, and importing it for real would bring back the two module-level useStorage() calls you just removed) — is that right?
If so, no objection to the trade-off, but two small things:
- The description is now stale on this point and will mislead the next reader of the mock.
typeof realRemoteConfigon line 38 pins the signature, so a renamed export or changed generic is caught, but not the body. Today this matches production exactly (const configValue = remoteConfig[key]; return configValue || defaultValue). If production later moves to??, or adds validation, this copy keeps the old semantics and every adopter's test keeps passing against behavior the app no longer has — the drift is invisible because nothing compares the two implementations.
Would a short comment here noting it is a deliberate copy of the real body (and why) be enough? Or, if the side-effect concern is only about the storage refs, import { configValueOrDefault } from '../remoteConfig' as a value alongside the type-only namespace import would keep one implementation — I just don't know whether re-evaluating the real module is acceptable for your adopters, hence the question rather than a request.
There was a problem hiding this comment.
Yes, the local implementation is deliberate. The PR description has been updated and now describes the contextually typed copy. A named runtime import would still evaluate the entire production module, including both module-level useStorage() calls, which defeats the side-effect-free mock. The bulk typeof realRemoteConfig annotation catches export and signature drift, but not body drift. A comment would not enforce that relationship, while extracting a production leaf module adds another file for this two-line helper. I am keeping the exact small implementation here. If the production behavior becomes more substantial, extraction becomes the clearer option.
There was a problem hiding this comment.
Tracked as FE-2629. The PR merged with this thread unresolved, so the finding is carried in Linear rather than lost here. Filed automatically; close the ticket if the finding is no longer true at main.
| isCancelled: computed(() => false), | ||
| formattedRenewalDate: computed(() => ''), | ||
| formattedEndDate: computed(() => ''), | ||
| subscriptionTier: computed(() => null), |
There was a problem hiding this comment.
suggestion (non-blocking): these derived fields are constants here, while production derives every one of them from subscriptionStatus — subscriptionTier is status?.subscription_tier ?? null, isCancelled is !!status?.cancel_at, subscriptionDuration is status?.subscription_duration ?? null, and canAccessSubscriptionFeatures is status?.is_active ?? false once subscription_required is set.
Two costs follow. First, adopters have to hand-rewire the derivation: useBillingContext.test.ts now does exactly that in beforeEach (lines 148-152) for subscriptionTier, subscriptionDuration, and isCancelled, and each future adopter repeats it. Second, an adopter who sets only subscriptionStatus.value = { is_active: false, … } and expects a gated feature to be blocked gets canAccessSubscriptionFeatures === true and a green test that proves nothing.
Would backing the object with one source ref and deriving the rest work, matching production?
const subscriptionStatus = ref<BillingStatusResponse | null>(null)
const subscription: ReturnType<typeof realUseSubscription> = {
subscriptionStatus,
subscriptionTier: computed(
() => subscriptionStatus.value?.subscription_tier ?? null
),
isCancelled: computed(() => !!subscriptionStatus.value?.cancel_at),
// …
}That would also shrink the Object.assign(subscription, reactiveDefaults()) restore on line 38 to subscriptionStatus.value = null, which removes the "replacement computed/ref fields must be configured before a consumer retains them" hazard you flag in the description: the field objects would keep stable identity for the whole run, so a consumer that destructured useSubscription() could never hold a ref a later test has already swapped out. useTransformState's reactiveDefaults() has the same shape if this seems worth doing.
There was a problem hiding this comment.
I am keeping these outputs independently configurable. This mock represents the composable boundary rather than reproducing its implementation. Deriving the fields would copy and couple production rules for status, dates, tiers, environment flags, and translations into the mock. Partial derivation would also leave an unclear mix of coupled and independent outputs. The adopted pattern is to replace a static computed field before creating the consumer, and to use a test-local reactive driver when a scenario needs live transitions. useBillingContext.test.ts configures its three required outputs before creating the consumer, so it follows that contract. The same reasoning applies to useTransformState.
There was a problem hiding this comment.
Tracked as FE-2630. The PR merged with this thread unresolved, so the finding is carried in Linear rather than lost here. Filed automatically; close the ticket if the finding is no longer true at main.
## Summary Use the real frontend `src/components/ui/button/Button.vue` in 45 component suites instead of local replacements. ## Changes - Remove five module factories, 43 component-stub registrations, and their unused fixtures. No production changes or replacement automock. - Replace stub-only IDs and data attributes with accessible-name queries, `aria-busy`, and rendered size/variant classes. Preserve all 1,287 assertion sites and all 253 call/payload assertions. - Keep website's distinct `apps/website/src/components/ui/button/Button.vue`, PrimeVue Button, and specialized buttons out of scope. Repository-wide inventory found no root Button replacements in packages/apps, manual mocks, test aliases, or shallow mounts. - Target `main` independently of Comfy-Org#17958/Comfy-Org#18010. The shared TopBarHeader deletion is coordinated with Comfy-Org#18010's owner. <details> <summary>Changed suites</summary> - BaseTerminal, CustomizationDialog, CancelSubscriptionDialogContent, ErrorOverlay, HdrViewerContent - WidgetImageCrop, Load3D, Load3dViewerContent, TopBarHeader, WidgetPainter, JobContextMenu - RightSidePanel, ErrorNodeCard, TabErrors, SectionWidgets, AssetsSidebarTab, BaseWorkflowsSidebarTab - WorkflowTab, VideoEditPanel, AssetCard, MediaAssetContextMenu, CreditsTile, SubscriptionFooterLinks - SecretFormDialog, SecretFormDialog.zindex, SecretListItem, SecretsPanel - ComfyHubDescribeStep, ComfyHubPublishFooter, ComfyHubThumbnailStep - SubscriptionAddPaymentPreviewWorkspace, SubscriptionPanelContentWorkspace, SubscriptionSuccessWorkspace, SubscriptionTransitionPreviewWorkspace - TeamWorkspacesDialogContent, BillingStatusBanner, MembersPanelContent, WorkspaceMenuButton - WidgetCompositor, BatchNavigation, ValueControlPopover, WidgetButton, FormDropdownMenuActions, FormDropdownMenuFilter, NodeConflictDialogContent All are existing `.test.ts` files under `src/`. </details> ## Review Focus - The 59-suite inventory union passed before and after migration: **742 tests**, including Button's seven owner tests. Final runs used `pnpm test:unit --maxWorkers=4` with explicit file filters, ordered and `--sequence.shuffle --sequence.seed=2343`. - Real-component checks cover enabled/disabled clicks, loading labels, slot content, navigation bounds, clear payloads, and error recovery. WidgetButton overrides variant colors, so secondary/textonly share the same rendered hover style; the table preserves both cases. - `pnpm typecheck`, `pnpm lint`, `pnpm format:check`, `pnpm knip`, and `pnpm fallow:audit` passed. Lint retains existing warnings; Fallow's changed-file gate excludes 15 inherited findings. - Deterministic AST inventory finds zero targeted replacements. The remaining `Button` registrations are two PrimeVue stubs and two `false` entries that retain real components. Assertion-count and call-payload checks pass. Full repository unit tests were not run. CI is pending. Co-authored-by: Amp <amp@ampcode.com>
I think I got everything, I can follow-up if not.
37e10da
37e10da to
2188048
Compare
2188048 to
c541feb
Compare
## Summary Adds eight typed manual automock foundations with one narrow example adopter per target. This PR is stacked on Comfy-Org#17958 at parent head `2188048802c118fadebc282c227ee14e364de3fa` and tracks [FE-2343](https://linear.app/comfyorg/issue/FE-2343) without closing it. ## Changes | Example suite | New mocks adopted | | --- | --- | | `useSharedWorkflowUrlLoader.test.ts` | `vue-router`, `workflowShareService` | | `useJobMenu.test.ts` | `src/i18n.ts`, `useMediaAssetActions` | | `MissingPackGroupRow.test.ts` | `useManagerState` | | `useServerLogs.test.ts` | `@vueuse/core` | | `api.folderPaths.test.ts` | `axios` | | `initDatadogRum.test.ts` | `@datadog/browser-rum` | Every targeted mock in the touched suites now uses factory-free registration. `TopBarHeader.test.ts` no longer mocks the root Button component and exercises the real component instead. Assertions, payloads, production behavior, and dependencies remain unchanged. Other consumers, `scripts/app`, website modules, PrimeVue, and FE-2442 remain deferred. ## Review Focus - Function signatures are derived at object boundaries rather than repeated on each `vi.fn`. Media actions and workflow sharing use `vi.mockObject<ReturnType<typeof realUseX>>(..., { spy: true })`; Axios, router, and manager state type their focused objects as a whole. - Broad packages stay narrow: `vue-router` exposes a stable route query and router `replace`; `@vueuse/core` mocks only `useEventListener`; Axios mocks only typed `get`; Datadog RUM exposes only the four methods used by its adopter and context assertions; i18n exposes only `t` and `st`. Unlisted exports remain unsupported until an adopter proves they are needed. - The Datadog mock owns global-context storage, `setGlobalContextProperty` behavior, and cleanup. Tests inspect it through Datadog's real `getGlobalContext` API instead of maintaining a parallel context object and per-test implementation. - Router query cleanup and Datadog context cleanup register from public mock APIs called inside tests, avoiding setter-time lifecycle hooks. No-isolation proofs cover both restoration paths. Router and composable/service result objects retain stable identity. - `useMediaAssetActions` and `workflowShareService` use complete production-derived result contracts and async defaults. Axios intentionally has no fake generic response default. Workflow operations that require scenario data reject by default rather than returning misleading fixtures. - `useManagerState` implements only the three outputs used by this adopter. Importing its real runtime module evaluates the manager graph and failed under the suite's unrelated partial manager-type mock, so real re-exporting is deliberately avoided. The test replaces its reactive scenario field before the component captures it. ## Validation - Baseline and final touched test set: 7 files, 129 tests passed - Shuffled touched test set (`seed=2343`): 7 files, 129 tests passed - Four production-owner suites, including the real Button: 4 files, 104 tests passed - No-isolation lifecycle/type proof: 6 tests passed - AST adoption audit: all 8 targets covered across 6 adopter suites; no targeted factory remains - `pnpm typecheck` - Targeted ESLint; commit hook typecheck and lint-staged checks - `pnpm format:check` - `pnpm knip` - `FALLOW_AUDIT_BASE=2188048802c118fadebc282c227ee14e364de3fa pnpm fallow:audit` (no issues in 13 changed files; 15 inherited dependency findings excluded by the audit gate) The full unit suite was not run. Validation is scoped to the touched tests, four production owners, and focused lifecycle/type proofs. --------- Co-authored-by: Amp <amp@ampcode.com>
Summary
Adds typed manual automock foundations for eight test boundaries and converts one narrow example suite per module. Tracks FE-2343 without closing it.
Changes
__mocks__modules forlitegraphService,remoteConfig,graphTraversalUtil,useSettingsDialog,useCanvasInteractions,useNodeDragToCanvas,useSubscription, anduseTransformState.useCoreCommands:litegraphService,useSettingsDialog,useSubscriptionuseBillingContext:useSubscriptionuseTurnstile:remoteConfigLGraphNode:graphTraversalUtil,useTransformStateuseNodeImage:useCanvasInteractionsstartModelNodeDragFromAsset:useNodeDragToCanvasTransformPane:useTransformStateReview Focus
Composable mocks return complete production-derived stable objects with stable action identity. Vitest default implementations survive configured
mockReset; mutable refs and replaceable reactive fields restore through mock-ownedonTestFinishedcleanup. Shared overrides assume sequential tests, and replacement computed/ref fields must be configured before a consumer retains them.graphTraversalUtilmocks onlygetNodeByLocatorId; its other 35 pure exports remain real.remoteConfigdefines every export in one production-typed object; its contextually typed pureconfigValueOrDefaultand test-owned refs avoid evaluating storage-backed production initialization. Its example adoption stays inuseTurnstileso unrelated Firebase startup keeps the real remote-config lifecycle. Remaining adopters are intentionally deferred; FE-2442 is out of scope. No production behavior changes.Validation
main: 7 files, 132 tests passed;pnpm typecheckpassedmainatc1bb79d845727c6df96acf4f612b090dabd7f27aseed=2343): 6 files, 120 tests passed before the compatibility-only adopter movepnpm typecheckpnpm lintpnpm format:checkpnpm knippnpm fallow:audit(no issues in the original 14 changed files; 15 inherited dependency findings excluded by the audit gate)The full unit suite was not run; validation is scoped to the converted adopters and each mocked module's owning suite.