Repository navigation
test(agent): re-enable panel keyboard lifecycle coverage - #16919
christian-byrne wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe agent panel lifecycle test is enabled. The test now runs for keyboard activation and complementary landmark behavior. ChangesAgent panel accessibility
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This change enables the agent-panel keyboard lifecycle accessibility test without altering product behavior. No merge-readiness risk remains. Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 inconclusive)
✅ Passed checks (6 passed)
Full details: End-To-End Regression Coverage For FixesExplanation The changed-file metadata is available and shows a change under ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
🎭 Playwright: ✅ 1940 passed, 0 failed📊 Browser Reports
📦 Bundle: 9.88 MB gzip ⚪ 0 BDetailsSummary
Category Glance App Entry Points — 3.73 kB (baseline 3.73 kB) • ⚪ 0 BMain entry bundles and manifests Status: 1 unchanged Graph Workspace — 1.43 MB (baseline 1.43 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration Status: 3 unchanged Views & Navigation — 128 kB (baseline 128 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 18 unchanged Panels & Settings — 622 kB (baseline 622 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 27 unchanged User & Accounts — 28.9 kB (baseline 28.9 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 11 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 8 unchanged UI Components — 118 kB (baseline 118 kB) • ⚪ 0 BReusable component library chunks Status: 15 unchanged Data & Services — 3.64 MB (baseline 3.64 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 16 unchanged Utilities & Hooks — 558 kB (baseline 558 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 36 unchanged Vendor & Third-Party — 18.2 MB (baseline 18.2 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 17 MB (baseline 17 MB) • ⚪ 0 BBundles that do not match a named category Status: 296 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-10T02:35:20.873Z",
"gitSha": "7620cf05c73767602b9973dfc4ad55e21daa018e",
"branch": "christian-byrne/evfail-72-reenable-agent-panel-lifecycle",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2005.9139999999616,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.649000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 451.182,
"heapDeltaBytes": 5531272,
"heapUsedBytes": 67620096,
"domNodes": -264,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 7.910999999999998,
"eventListeners": -154,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2003.3190000000332,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.091999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 460.883,
"heapDeltaBytes": 4937768,
"heapUsedBytes": 67000032,
"domNodes": -260,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 7.671000000000001,
"eventListeners": -154,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1968.4210000000348,
"styleRecalcs": 80,
"styleRecalcDurationMs": 35.496,
"layouts": 14,
"layoutDurationMs": 4.587000000000001,
"taskDurationMs": 953.1770000000001,
"heapDeltaBytes": -4928204,
"heapUsedBytes": 56331932,
"domNodes": -265,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 185.488,
"eventListeners": -156,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1806.7819999999983,
"styleRecalcs": 75,
"styleRecalcDurationMs": 28.419999999999998,
"layouts": 14,
"layoutDurationMs": 4.236,
"taskDurationMs": 819.8859999999999,
"heapDeltaBytes": 13225800,
"heapUsedBytes": 75097980,
"domNodes": -261,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 160.541,
"eventListeners": -156,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1721.2089999999876,
"styleRecalcs": 32,
"styleRecalcDurationMs": 16.651,
"layouts": 6,
"layoutDurationMs": 1.204,
"taskDurationMs": 356.60999999999996,
"heapDeltaBytes": 2058596,
"heapUsedBytes": 62636636,
"domNodes": 76,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 12.076000000000004,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1723.3800000000201,
"styleRecalcs": 32,
"styleRecalcDurationMs": 14.662999999999998,
"layouts": 6,
"layoutDurationMs": 0.9880000000000002,
"taskDurationMs": 340.638,
"heapDeltaBytes": 1831508,
"heapUsedBytes": 64065312,
"domNodes": 77,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 11.205,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 634.8300000000222,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.258000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 448.193,
"heapDeltaBytes": 18129300,
"heapUsedBytes": 80170112,
"domNodes": 16,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 172.70000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 695.510000000013,
"styleRecalcs": 13,
"styleRecalcDurationMs": 10.307,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 477.76800000000003,
"heapDeltaBytes": 17854548,
"heapUsedBytes": 79662976,
"domNodes": 22,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 170.603,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2053.5279999999716,
"styleRecalcs": 6,
"styleRecalcDurationMs": 8.796999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 573.376,
"heapDeltaBytes": 720700,
"heapUsedBytes": 80057584,
"domNodes": -253,
"jsHeapTotalBytes": 253952,
"scriptDurationMs": 33.75599999999999,
"eventListeners": -184,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2035.6239999999843,
"styleRecalcs": 5,
"styleRecalcDurationMs": 5.890999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 554.643,
"heapDeltaBytes": 4684376,
"heapUsedBytes": 83612164,
"domNodes": -250,
"jsHeapTotalBytes": -270336,
"scriptDurationMs": 31.487000000000002,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2178.056999999967,
"styleRecalcs": 64,
"styleRecalcDurationMs": 8.735,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1581.686,
"heapDeltaBytes": 14771116,
"heapUsedBytes": 79137928,
"domNodes": -256,
"jsHeapTotalBytes": 749568,
"scriptDurationMs": 826.6139999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2465.596000000005,
"styleRecalcs": 66,
"styleRecalcDurationMs": 10.555000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1761.251,
"heapDeltaBytes": 933924,
"heapUsedBytes": 81622568,
"domNodes": -253,
"jsHeapTotalBytes": 1527808,
"scriptDurationMs": 926.159,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3524.8679999999695,
"styleRecalcs": 61,
"styleRecalcDurationMs": 9.969,
"layouts": 60,
"layoutDurationMs": 11.478000000000002,
"taskDurationMs": 1648.71,
"heapDeltaBytes": 9710784,
"heapUsedBytes": 75011308,
"domNodes": 2,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 776.0069999999998,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3584.724999999935,
"styleRecalcs": 60,
"styleRecalcDurationMs": 9.923000000000002,
"layouts": 60,
"layoutDurationMs": 12.113999999999997,
"taskDurationMs": 1704.8190000000002,
"heapDeltaBytes": 7535932,
"heapUsedBytes": 73836272,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 777.71,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3062.833000000012,
"styleRecalcs": 43,
"styleRecalcDurationMs": 6.738999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1869.205,
"heapDeltaBytes": 18250272,
"heapUsedBytes": 83977760,
"domNodes": 6,
"jsHeapTotalBytes": 942080,
"scriptDurationMs": 942.6320000000001,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3186.851000000047,
"styleRecalcs": 44,
"styleRecalcDurationMs": 7.866000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2024.265,
"heapDeltaBytes": -12436972,
"heapUsedBytes": 77735408,
"domNodes": -270,
"jsHeapTotalBytes": 6737920,
"scriptDurationMs": 970.306,
"eventListeners": -187,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2047.126999999989,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.949000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 583.1080000000001,
"heapDeltaBytes": 1719636,
"heapUsedBytes": 81983968,
"domNodes": -259,
"jsHeapTotalBytes": -8192,
"scriptDurationMs": 33.152,
"eventListeners": -184,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2032.0649999999887,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.253,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 552.3560000000001,
"heapDeltaBytes": -3159620,
"heapUsedBytes": 83793744,
"domNodes": -252,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 32.279,
"eventListeners": -154,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 567.701999999997,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.594999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 403.864,
"heapDeltaBytes": 13545648,
"heapUsedBytes": 76765304,
"domNodes": 18,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 141.812,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 582.4669999999514,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.264,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 396.906,
"heapDeltaBytes": 13622192,
"heapUsedBytes": 76752332,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 141.46999999999997,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2000.1139999999964,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.439000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 455.178,
"heapDeltaBytes": -1807960,
"heapUsedBytes": 61470016,
"domNodes": -275,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 7.126999999999998,
"eventListeners": -230,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2021.0730000000012,
"styleRecalcs": 11,
"styleRecalcDurationMs": 10.761,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 466.83,
"heapDeltaBytes": 17856748,
"heapUsedBytes": 81024688,
"domNodes": -275,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 7.627000000000002,
"eventListeners": -200,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1721.2930000000028,
"styleRecalcs": 80,
"styleRecalcDurationMs": 27.401000000000003,
"layouts": 18,
"layoutDurationMs": 4.517,
"taskDurationMs": 683.2280000000001,
"heapDeltaBytes": 800360,
"heapUsedBytes": 64060576,
"domNodes": -273,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 107.619,
"eventListeners": -232,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1739.6529999999757,
"styleRecalcs": 78,
"styleRecalcDurationMs": 28.647999999999996,
"layouts": 18,
"layoutDurationMs": 4.898,
"taskDurationMs": 813.359,
"heapDeltaBytes": 744796,
"heapUsedBytes": 64058004,
"domNodes": -275,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 113.65,
"eventListeners": -232,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1400.9310000000141,
"styleRecalcs": 16,
"styleRecalcDurationMs": 28.093,
"layouts": 5,
"layoutDurationMs": 12.823999999999998,
"taskDurationMs": 889.0840000000002,
"heapDeltaBytes": 19726556,
"heapUsedBytes": 101109588,
"domNodes": 13587,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 30.628000000000004,
"eventListeners": 2387,
"totalBlockingTimeMs": 145,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8273.44800000003,
"styleRecalcs": 248,
"styleRecalcDurationMs": 33.813,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5639.241,
"heapDeltaBytes": -3400632,
"heapUsedBytes": 74972224,
"domNodes": -245,
"jsHeapTotalBytes": 1265664,
"scriptDurationMs": 2684.927,
"eventListeners": -138,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8631.298000000015,
"styleRecalcs": 248,
"styleRecalcDurationMs": 36.103,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6068.357,
"heapDeltaBytes": 888272,
"heapUsedBytes": 79860568,
"domNodes": -248,
"jsHeapTotalBytes": -1126400,
"scriptDurationMs": 2842.269,
"eventListeners": -166,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16780.11799999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16224.387,
"heapDeltaBytes": -40681712,
"heapUsedBytes": 167346908,
"domNodes": -6542,
"jsHeapTotalBytes": 802816,
"scriptDurationMs": 264.08799999999997,
"eventListeners": -7478,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16853.335000000014,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16469.303000000004,
"heapDeltaBytes": -14122980,
"heapUsedBytes": 194473736,
"domNodes": -6542,
"jsHeapTotalBytes": -4657152,
"scriptDurationMs": 283.13699999999994,
"eventListeners": -7478,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 19902.82000000002,
"styleRecalcs": 159,
"styleRecalcDurationMs": 16.60800000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19606.684,
"heapDeltaBytes": -34214648,
"heapUsedBytes": 165213696,
"domNodes": -6542,
"jsHeapTotalBytes": 1286144,
"scriptDurationMs": 896.976,
"eventListeners": -7474,
"totalBlockingTimeMs": 52,
"frameDurationMs": 18.330000000000048,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20303.11900000004,
"styleRecalcs": 165,
"styleRecalcDurationMs": 16.591000000000022,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19889.337,
"heapDeltaBytes": -24976112,
"heapUsedBytes": 176703048,
"domNodes": -6542,
"jsHeapTotalBytes": 2113536,
"scriptDurationMs": 935.7160000000001,
"eventListeners": -7472,
"totalBlockingTimeMs": 43,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6107.307999999989,
"styleRecalcs": 20,
"styleRecalcDurationMs": 79.62999999999998,
"layouts": 20,
"layoutDurationMs": 22.67699999999999,
"taskDurationMs": 5987.354000000001,
"heapDeltaBytes": -21030188,
"heapUsedBytes": 171812644,
"domNodes": -6542,
"jsHeapTotalBytes": 17539072,
"scriptDurationMs": 110.94300000000001,
"eventListeners": -7474,
"totalBlockingTimeMs": 387,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 6060.0259999999935,
"styleRecalcs": 20,
"styleRecalcDurationMs": 77.71899999999998,
"layouts": 20,
"layoutDurationMs": 23.150999999999993,
"taskDurationMs": 5960.081,
"heapDeltaBytes": -16363484,
"heapUsedBytes": 179772436,
"domNodes": -6542,
"jsHeapTotalBytes": 16887808,
"scriptDurationMs": 114.95700000000002,
"eventListeners": -7476,
"totalBlockingTimeMs": 385,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6349.803000000065,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5911.234,
"heapDeltaBytes": -33375148,
"heapUsedBytes": 165833336,
"domNodes": 0,
"jsHeapTotalBytes": -7602176,
"scriptDurationMs": 109.25000000000001,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8469.469000000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8276.422,
"heapDeltaBytes": -16018804,
"heapUsedBytes": 168248608,
"domNodes": 0,
"jsHeapTotalBytes": -12582912,
"scriptDurationMs": 136.385,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 133.0920000000333,
"styleRecalcs": 12,
"styleRecalcDurationMs": 23.465,
"layouts": 6,
"layoutDurationMs": 2.319,
"taskDurationMs": 107.83200000000001,
"heapDeltaBytes": 3302252,
"heapUsedBytes": 64705328,
"domNodes": 137,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 12.68,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 452.2819999999683,
"styleRecalcs": 13,
"styleRecalcDurationMs": 20.401000000000003,
"layouts": 4,
"layoutDurationMs": 2.215,
"taskDurationMs": 114.24499999999999,
"heapDeltaBytes": 4857744,
"heapUsedBytes": 66522052,
"domNodes": 119,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 10.169,
"eventListeners": 83,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #16919 +/- ##
==========================================
+ Coverage 81.82% 83.24% +1.41%
==========================================
Files 2518 2064 -454
Lines 128671 120438 -8233
Branches 33260 33045 -215
==========================================
- Hits 105290 100256 -5034
+ Misses 22847 20002 -2845
+ Partials 534 180 -354
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
A duplicated #agent-panel-title (the FE #16912 regression class) reached main unnoticed because the fast unit suite is provably blind to the id count — 76 files / 1013 tests passed identically on both the duplicate and clean heads. The only guard was the Playwright lifecycle spec, still test.fixme pending FE #16919. Mount AgentPanelRoot on the success path and assert the document-level count of #agent-panel-title is exactly 1. Verified the assertion fails on a duplicated id and passes at current main. Residual from R-193 (a11yguard-1).
Comfy-Org#16952) ## Why A duplicated `#agent-panel-title` (the FE Comfy-Org#16912 regression class) reached main unnoticed because the fast unit suite is provably blind to the id count — 76 files / 1013 tests passed identically on both the duplicate and clean heads (`reports/e2e-support/2026-09-04-0300Z-dup-id-and-branch-health.md` in the program repo). The only guard was the Playwright lifecycle spec (`browser_tests/tests/agent/agentPanelLifecycle.spec.ts:68`), still `test.fixme` pending FE Comfy-Org#16919 human approval. ## What Adds one unit assertion beside `AgentPanelRoot.vue` in `AgentPanelRoot.test.ts`: mount the panel on the success path and assert `document.querySelectorAll('#agent-panel-title')` has length exactly 1. - Document-level count on purpose, so a duplicate id anywhere in the document fails, not just one inside the panel subtree. - Does not touch `agentPanelLifecycle.spec.ts` — FE Comfy-Org#16919 owns its restore. ## Verification - New test passes at current main (`9ff3fd7f0e`): `1 passed`. - Negative control: with a second `#agent-panel-title` element injected into `PanelHeader.vue`, the test fails (`1 failed`); reverting the injection restores green. - Full `AgentPanelRoot.test.ts`: 119 passed. - `eslint` and `oxfmt --check` clean on the touched file. Residual from R-193 (todo `a11yguard-1`).
5e07fb7 to
5eaa871
Compare
DrJKL
left a comment
There was a problem hiding this comment.
Verdict: ready to approve
The original skip covered a deterministic duplicate-ID defect, and #16912 is in this branch's history. The restored cloud test passed 10/10 locally. The relevant unit suite, both typechecks, changed-file lint and formatting, knip, and all current required CI checks also pass.
I left one non-blocking test-coverage note inline. The restored test checks that the aria-labelledby target exists and is unique, but it does not yet verify the landmark's computed accessible name.
| }) | ||
|
|
||
| test.fixme('supports keyboard activation and returns one complementary landmark', async ({ | ||
| test('supports keyboard activation and returns one complementary landmark', async ({ |
There was a problem hiding this comment.
Non-blocking: please make the accessible-name check explicit. The assertions below check the aria-labelledby value and that its target is unique, but not that the target contributes the expected name. I emptied the target's text locally and this restored test still passed. Replacing the later role count with await expect(page.getByRole('complementary', { name: enMessages.agent.title })).toHaveCount(1) would make the intended coverage fail when the label is empty or wrong.
DrJKL
left a comment
There was a problem hiding this comment.
Verdict: ready to approve
I found no additional findings in the Playwright-specific follow-up. The existing accessible-name suggestion remains tracked in the original comment, so I have not repeated it here.
Checked and cleared
- I inventoried 502 helpers and assertions across 75 fixture files before reviewing the active test body.
- The interaction table covered 14 actions and readiness boundaries. The raw-page fixture cannot use
KeyboardHelper, and its locator-scoped key presses already provide deterministic targets. - Checks A through H and all 23 items in
.agents/checks/playwright-e2e.mdproduced no new findings. - The prior exact-head run passed all 10 repetitions of this test.
Coverage
This follow-up reviewed only the changed registration line and the keyboard lifecycle behavior that it activates in browser_tests/tests/agent/agentPanelLifecycle.spec.ts. It also traced the relevant setup and keyboard helpers in browser_tests/fixtures/agentPanelFixture.ts and browser_tests/fixtures/helpers/KeyboardHelper.ts.
|
Closing this as superseded. Its entire contribution is already on This pull request removes Worth flagging what merging it now would actually do, because "a one-line diff" reads harmless. The head is 440 commits behind and the file has moved on underneath it in 61 lines: #17621 moved the agent button to the far right and nested the panel, which changed the locale key from I picked this up expecting to rebase and re-verify it, since it was sitting in the never-reviewed pool where everything is blocked on nothing. Checking whether This is now the first row with hard evidence in the disposition packet at blocked-on-christian #809. Reopen if you disagree; nothing is lost by closing, because the behaviour it wanted is already enabled and running. |
…rs (Comfy-Org#19927) *PR Created by the Glary-Bot Agent* --- Follow-up to an audit of disabled Playwright/Vitest tests. This lands **only** the low-risk housekeeping subset: annotations whose factual claims have gone stale or were wrong. No marker is added, removed or re-scoped, and no product code is touched. The only non-comment line in the whole diff is one test title string: ``` git diff main -U0 | grep -E '^[+-]' | grep -vE '^(\+\+\+|---)' | grep -vE '^[+-]\s*//' - it.fails('excludes a failed-then-actually-completed task from activeDownloads so it is never reconciled (PM-1302)', () => { + it.fails('excludes a failed-then-actually-completed task from activeDownloads (PM-1302)', () => { ``` ## What changed **`src/workbench/extensions/agent/AgentPanelRoot.test.ts`** — described `agentPanelLifecycle.spec.ts` as *"still test.fixme pending FE Comfy-Org#16919"*. Comfy-Org#16919 was **closed unmerged**; Comfy-Org#17132 is what re-enabled the spec (`4a5b183249`), and it carries no `fixme` today. **`browser_tests/tests/agent/agentNestedOutputSentPreview.spec.ts`** — deferred its decision to *"open owner PRs (Comfy-Org#16985, Comfy-Org#17767)"*. Both merged (2026-09-22 / 09-23). PM-1158 then closed on a partial fix (Comfy-Org#18104, image path only) and PM-1157 on this repro, so the **non-image path this test pins is unowned**. The `test.fail()` stays. **`src/stores/assetDownloadStore.test.ts`** — labelled PM-1302 / PM-1309 an `OPEN DESIGN QUESTION`; both are `Done`. Worse, the block contradicted itself: its header says polling *"re-checks `failed` downloads too"*, while the inner comment said `pollStaleDownloads()` *"only walks activeDownloads"* so the task is *"never reconciled"*. Both are false — `pollStaleDownloads()` walks `recheckableDownloads`, which includes `failed` (`assetDownloadStore.ts:23-27, 206-208`), and the passing test at `:350` reconciles a failed download through polling. The `it.fails` marker stays (the gap it pins is still a live product decision); only the false consequence is dropped from its title. ## Why nothing else from the audit is here The audit found 82 marker sites. Everything else was checked and deliberately left alone: - **All 20 `test.fail()` sites are CI-enforced.** Each lives in a spec tagged into a running project (`@cloud` → `cloud`, `@smoke`/`@vue-nodes` → `chromium`). Playwright fails a `test.fail()` that unexpectedly passes, so **main being green proves none of them are stale**. Removing any would be unjustified. - **FE-2040 is `In Review`** with Comfy-Org#17113/Comfy-Org#17116/Comfy-Org#17122/Comfy-Org#17308 unmerged → the four `pointerGestures`/`selection` markers stay. Issues Comfy-Org#18414 and Comfy-Org#7454 are open → those markers stay. - **7 of the 20 `test.fail()` are deliberate fixture self-tests** (`networkIsolation`, `liveCloudBillingRouting`) that assert the guard fixture fails at teardown. Correct as written. I considered adding clarifying comments and dropped it — `AGENTS.md` sets a high bar against non-essential comments. - **The 35 `test.fixme()`** are bodiless placeholder rows in `crossOriginSession/**`, `testIgnore`d from the default config and gated by `expectStepsWritten`. Not removable without deleting the QA plan's tracking rows. - **The 27 conditional `skip`/`skipIf`/`ctx.skip`** are data-, shard- and env-availability guards (one was added by Comfy-Org#15150 precisely so the suite survives event data rolling over). Verified actively skipping: `LGraph.roundTrip.test.ts` reports 5 skips against real fixture shapes. ## Two findings worth a look, not fixed here 1. **PM-1157 / PM-1158 are `Done`, but the defect they describe is still pinned failing.** PM-1157 was closed by Comfy-Org#18201 — the PR that *added the repro*. PM-1158 got a partial fix (Comfy-Org#18104) covering the image path only. The non-image `preview_url` path has no open owner. cc @christian-byrne 2. **The audit's own marker grep missed `it.fails`** (`.failing(` was matched, `.fails(` was not) — 13 sites across 7 files, so the real total is 95, not 82. `assetDownloadStore.test.ts` is the only one of the 13 carrying an external ticket reference; the other 12 reference nothing that can go stale. ## Verification - `pnpm exec vitest run src/stores/assetDownloadStore.test.ts src/workbench/extensions/agent/AgentPanelRoot.test.ts` → **408 passed, 1 expected fail** (the `it.fails` still failing as designed), run in an interactive tmux session. - Pre-commit hook: `oxfmt`, type-aware `oxlint`, `eslint`, `typecheck:app`, `typecheck:browser` — all green. `typecheck:browser` covers the Playwright spec. - Three `deep-reviewer` rounds; the first caught a genuine error in my own first draft (I had misread `closed_at` as merged and written `Comfy-Org#16919` where `Comfy-Org#17132` belongs). Final verdict PASS. - **Not possible in this sandbox:** no screenshots — the change has no UI surface, and Playwright browsers are not installed (`~/.cache/ms-playwright` holds only ffmpeg) with no torch for a ComfyUI backend, so `agentNestedOutputSentPreview.spec.ts` could not be executed. It is comment-only and covered by `typecheck:browser`. Co-authored-by: Glary-Bot <glary-bot@users.noreply.github.com>
Back-references #16903 and Christian's unresolved review thread: #16903 (comment) ("nit: can use standardized data-test-id"). ## What - `PanelHeader.vue`: adds the repository-standard `data-testid="agent-panel-title"` to the panel title `<h1>` (the repo uses `data-testid` in 354 files and `data-test-id` in none), while **retaining `id="agent-panel-title"`** because `DockedAgentPanel.vue` labels the dock landmark via `aria-labelledby="agent-panel-title"`. - `PanelHeader.test.ts`: the focused heading coverage now looks the element up through the standard `screen.getByTestId('agent-panel-title')` selector and keeps asserting `id="agent-panel-title"` so the landmark reference stays covered. ## Evidence - `pnpm exec vitest run src/workbench/extensions/agent/components/agent/PanelHeader.test.ts` → **6/6 passed** at exact head `2604efccddcf1025e22068202e0a36a743bd88b8` on FE main `a39b1ce9fa`. - Red proof: with the `data-testid` attribute stashed, exactly the updated heading assertion fails (`1 failed | 5 passed`); restoring it returns 6/6 green. - `oxfmt --check` (2 files correct format), `oxlint` (0 warnings, 0 errors), `eslint` (exit 0), `vue-tsc --noEmit` (exit 0), pre-push `knip --cache` clean. - Pre-open dedupe: `gh pr list --state all` searches for `agent-panel-title`, `test-id agent`, and `data-testid agent panel` found no open carrier for this request (#16919 is unrelated keyboard-lifecycle coverage); `git ls-remote --heads` has no competing testid branch. <!-- authored-by:agent lane-evfail-71-0330 --> Co-authored-by: christian-byrne <christian@comfy.org>
Summary
Re-enables the agent panel keyboard lifecycle E2E assertion now that #16912 removed the duplicate
agent-panel-titleid introduced before #16907 merged. This restores the coverage called out in #16907 comment 5534926025.Changes
test.fixmeback totest, preserving its single-landmark, accessible-name, keyboard open, and keyboard close assertions.Review Focus
Confirm the cloud Playwright job executes and passes the restored test against the post-#16912 DOM.
Evidence
pnpm exec oxfmt --check browser_tests/tests/agent/agentPanelLifecycle.spec.ts— passedpnpm exec oxlint browser_tests/tests/agent/agentPanelLifecycle.spec.ts— 0 warnings/errorspnpm typecheckandpnpm typecheck:browser— passedpnpm knip --cache— passedplaywright-tests (cloud)— passed in 8m47s at exact head5e07fb7c756749bd9dc7eaebeb734e2bf1a37771Refs #16907
Refs #16907 (comment)
Refs #16912