Repository navigation
fix(agent): pin workflow adoption to tab instances - #16878
christian-byrne wants to merge 10 commits into
Conversation
The message ack does not distinguish a minted workflow from the thread's existing one, so an unbound tab on an existing thread was adopting the echoed id and moving that workflow's binding onto itself. Gate adoption on the id differing from the session's pre-turn binding, and in the panel refuse to bind an unbound tab to an id that already resolves to an open tab. Regression tests cover both gates.
…sage ryan-di flagged that sendMessage awaits workflow.prepare() before reading workflow.current(), tabs(), and priorWorkflowId, so a tab switch during prepare() attributes the request and later adoption to the newly active tab instead of the tab that initiated the send. Capture the originating tab path before the first await, then resolve current()/tabs() against that pinned originTabPath after prepare() completes so the cloud-id cache prepare() warms is still used, but identity resolution is pinned to the tab that started the send. Regression test: (h7) a tab switch while prepare() is pending does not reattribute the send to the new tab. It is numbered (h7) because main has since taken (h5)/(h6) for the workflow.draft() cases. Addresses: #16625 (comment)
Rebasing onto main combined two changes that are individually correct and jointly wrong. main added workflow.draft() to the turn; this branch pinned current()/tabs() to the tab that started the send. draft() was still read off whatever tab is active after prepare(), so a tab switch mid-turn shipped the new tab's canvas under the originating tab's workflow id. Verified against the pre-fix code: the turn posted tab-b's draft with workflowId wf-a. Give draft() the same optional originTabPath the other two take. captureCanvasState() folds the live canvas into whichever workflow it is called on, so it now runs only while that workflow is still the active tab; otherwise the originating tab's own serialized activeState is used. The same merge also loosened main's draft gate. An unsaved tab now yields a context carrying only its tabPath, so 'wfContext !== undefined' no longer implies the tab has a workflow the thread could own, and an unbound scratch tab leaked its canvas into an existing thread (this broke main's own 'does not send an unbound tab draft to an existing workflow thread' test). An existing thread now takes a draft only from a tab with a real workflow id. Regression test: (h8) the draft snapshot follows the originating tab, not the tab switched to during prepare().
`originTabPath` was `string | undefined`, and `undefined` meant two different
things: "no origin tab" at capture time, and "resolve whatever tab is active
now" at every post-await lookup. So when `current()` yielded nothing before
`prepare()` -- the panel detached via `onClearWorkflow`, or no workflow open --
the pin degraded into exactly the late binding this change set removes. A user
who re-attached during the up-to-3s `prepare()` window had the turn attributed
to the newly selected tab, shipping its `workflow_id`, its `current_tab` and
its canvas as the authoritative draft, including a workflow they had
explicitly detached.
Replace the overloaded parameter with an explicit `TurnOrigin` sentinel:
omitted still means "use the active tab" (`resumedTurnTabPath` relies on
that), `null` means the send had no origin tab, and `{ tabPath }` pins. The
three resolvers in `AgentPanelRoot` share one `originWorkflow()` helper so the
`null` case cannot silently fall back. `openTabsSnapshot` still reports
`open_tabs` for an origin-less turn -- those are context, not attribution --
but no longer names a `current_tab`.
(h9) fails without the fix, shipping `workflowId: wf-b` for a send that
started detached. `pathFor()` mirrors `originWorkflow()` so the (h7)/(h8)
mocks keep matching the real deps rather than drifting into a contract only
the tests implement.
Addresses:
#16840 (comment)
#16840 (comment)
|
Warning Review limit reachedNext included review available in 20 minutes. View limit detailsLimit details: You’ve used all 4 included reviews currently available. Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (4)
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1906 passed, 0 failed · 1 flaky📊 Browser Reports
📦 Bundle: 9.69 MB gzip ⚪ 0 BDetailsSummary
Category Glance App Entry Points — 3.73 kB (baseline 3.73 kB) • ⚪ 0 BMain entry bundles and manifests Status: 1 unchanged Graph Workspace — 1.43 MB (baseline 1.43 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration Status: 3 unchanged Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 17 unchanged Panels & Settings — 621 kB (baseline 621 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 27 unchanged User & Accounts — 27.8 kB (baseline 27.8 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 11 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 8 unchanged UI Components — 117 kB (baseline 117 kB) • ⚪ 0 BReusable component library chunks Status: 15 unchanged Data & Services — 3.6 MB (baseline 3.6 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 16 unchanged Utilities & Hooks — 559 kB (baseline 559 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 36 unchanged Vendor & Third-Party — 18.1 MB (baseline 18.1 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 16.4 MB (baseline 16.4 MB) • ⚪ 0 BBundles that do not match a named category Status: 296 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-04T04:48:37.260Z",
"gitSha": "edc197f16d4d032bc082a279317c5a031335ac7a",
"branch": "christian-byrne/shep-26-stable-tab-adoption",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2029.4099999999844,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.951999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 511.126,
"heapDeltaBytes": -11016072,
"heapUsedBytes": 59321132,
"domNodes": -279,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 8.536999999999999,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2039.985999999999,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.5,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 503.78200000000004,
"heapDeltaBytes": -11398684,
"heapUsedBytes": 58445512,
"domNodes": -278,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 8.988,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2105.768000000012,
"styleRecalcs": 79,
"styleRecalcDurationMs": 41.653000000000006,
"layouts": 14,
"layoutDurationMs": 4.579,
"taskDurationMs": 1045.3450000000003,
"heapDeltaBytes": 2551012,
"heapUsedBytes": 72254692,
"domNodes": -282,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 171.154,
"eventListeners": -184,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1835.965999999985,
"styleRecalcs": 75,
"styleRecalcDurationMs": 35.577999999999996,
"layouts": 14,
"layoutDurationMs": 4.428000000000001,
"taskDurationMs": 884.9619999999999,
"heapDeltaBytes": 2111584,
"heapUsedBytes": 72067164,
"domNodes": -280,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 149.07799999999997,
"eventListeners": -182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1727.0549999999503,
"styleRecalcs": 31,
"styleRecalcDurationMs": 15.510000000000003,
"layouts": 6,
"layoutDurationMs": 1.084,
"taskDurationMs": 355.939,
"heapDeltaBytes": 5113656,
"heapUsedBytes": 75754180,
"domNodes": 75,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 10.939999999999998,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1683.320999999978,
"styleRecalcs": 29,
"styleRecalcDurationMs": 15.379,
"layouts": 6,
"layoutDurationMs": 1.0730000000000002,
"taskDurationMs": 357.248,
"heapDeltaBytes": 5029760,
"heapUsedBytes": 75531488,
"domNodes": 76,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 10.927000000000003,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 679.5819999999821,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.6129999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 454.19100000000003,
"heapDeltaBytes": -7831188,
"heapUsedBytes": 62671360,
"domNodes": 16,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 153.95299999999997,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 703.8290000000416,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.132,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 468.005,
"heapDeltaBytes": -7460792,
"heapUsedBytes": 62891940,
"domNodes": 18,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 156.95000000000002,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2034.5720000000256,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.317000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 641.1640000000001,
"heapDeltaBytes": 10928012,
"heapUsedBytes": 87262604,
"domNodes": -268,
"jsHeapTotalBytes": -888832,
"scriptDurationMs": 39.821999999999996,
"eventListeners": -180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2052.3709999999937,
"styleRecalcs": 6,
"styleRecalcDurationMs": 6.340999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 620.6019999999999,
"heapDeltaBytes": -15001928,
"heapUsedBytes": 86521664,
"domNodes": -266,
"jsHeapTotalBytes": -327680,
"scriptDurationMs": 40.12400000000001,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2160.0740000000087,
"styleRecalcs": 62,
"styleRecalcDurationMs": 8.928000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1519.94,
"heapDeltaBytes": 18132240,
"heapUsedBytes": 84343280,
"domNodes": 0,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 747.6279999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2152.643000000012,
"styleRecalcs": 63,
"styleRecalcDurationMs": 9.776000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1525.643,
"heapDeltaBytes": 18148708,
"heapUsedBytes": 84373028,
"domNodes": -276,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 746.521,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3495.973999999933,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.756000000000002,
"layouts": 60,
"layoutDurationMs": 13.088,
"taskDurationMs": 1660.448,
"heapDeltaBytes": 8196400,
"heapUsedBytes": 76164688,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 752.3359999999999,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "large-graph-zoom",
"durationMs": 3478.862000000049,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.943999999999996,
"layouts": 60,
"layoutDurationMs": 13.282000000000002,
"taskDurationMs": 1663.7869999999996,
"heapDeltaBytes": 11785224,
"heapUsedBytes": 79952324,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 750.198,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3050.8930000000873,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.347999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1931.0020000000004,
"heapDeltaBytes": 25775016,
"heapUsedBytes": 93953748,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 970.314,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666636,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3118.7810000000127,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.401,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1929.806,
"heapDeltaBytes": 23228628,
"heapUsedBytes": 93018064,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 959.645,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2054.0660000000344,
"styleRecalcs": 3,
"styleRecalcDurationMs": 2.4139999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 582.7520000000002,
"heapDeltaBytes": -15581292,
"heapUsedBytes": 88094252,
"domNodes": -271,
"jsHeapTotalBytes": -1638400,
"scriptDurationMs": 36.621,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 1999.3500000000495,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.7729999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 547.6359999999999,
"heapDeltaBytes": 22407872,
"heapUsedBytes": 88746676,
"domNodes": 2,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 39.035000000000004,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 588.465000000042,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.715999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 398.482,
"heapDeltaBytes": 14921932,
"heapUsedBytes": 87843600,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 137.48499999999999,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 629.9880000000257,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.981,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 425.463,
"heapDeltaBytes": 15145788,
"heapUsedBytes": 87755244,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 148.405,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2022.6440000000139,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.700999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 481.055,
"heapDeltaBytes": -8156316,
"heapUsedBytes": 64753468,
"domNodes": -297,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 7.799,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2023.0440000000272,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.8309999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 491.5109999999999,
"heapDeltaBytes": 3347692,
"heapUsedBytes": 75839220,
"domNodes": -296,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 7.901000000000002,
"eventListeners": -226,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1731.1049999999568,
"styleRecalcs": 77,
"styleRecalcDurationMs": 36.102,
"layouts": 18,
"layoutDurationMs": 5.103,
"taskDurationMs": 804.052,
"heapDeltaBytes": -12040112,
"heapUsedBytes": 60820412,
"domNodes": -295,
"jsHeapTotalBytes": 7069696,
"scriptDurationMs": 101.27600000000001,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1741.2790000000768,
"styleRecalcs": 78,
"styleRecalcDurationMs": 37.297,
"layouts": 18,
"layoutDurationMs": 5.481,
"taskDurationMs": 829.933,
"heapDeltaBytes": 1192980,
"heapUsedBytes": 74039340,
"domNodes": -293,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 104.862,
"eventListeners": -228,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1367.6450000000386,
"styleRecalcs": 19,
"styleRecalcDurationMs": 30.50699999999999,
"layouts": 15,
"layoutDurationMs": 14.042000000000002,
"taskDurationMs": 917.2779999999998,
"heapDeltaBytes": -9272752,
"heapUsedBytes": 82396036,
"domNodes": 13751,
"jsHeapTotalBytes": 12058624,
"scriptDurationMs": 30.147999999999993,
"eventListeners": 2387,
"totalBlockingTimeMs": 122,
"frameDurationMs": 16.666666666666636,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8280.028000000017,
"styleRecalcs": 247,
"styleRecalcDurationMs": 38.940000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5605.647,
"heapDeltaBytes": -12652576,
"heapUsedBytes": 88958548,
"domNodes": -269,
"jsHeapTotalBytes": -1150976,
"scriptDurationMs": 2540.933,
"eventListeners": -134,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8398.323000000004,
"styleRecalcs": 247,
"styleRecalcDurationMs": 39.178000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5816.219,
"heapDeltaBytes": 15564784,
"heapUsedBytes": 91105624,
"domNodes": -269,
"jsHeapTotalBytes": -663552,
"scriptDurationMs": 2647.117,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 18048.52100000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17348.468999999997,
"heapDeltaBytes": -37973680,
"heapUsedBytes": 176048060,
"domNodes": -6548,
"jsHeapTotalBytes": -6856704,
"scriptDurationMs": 323.129,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.330000000000048,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 18104.454000000034,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17434.719,
"heapDeltaBytes": -40138684,
"heapUsedBytes": 176537476,
"domNodes": -6548,
"jsHeapTotalBytes": 1810432,
"scriptDurationMs": 304.743,
"eventListeners": -7471,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 22467.306000000008,
"styleRecalcs": 168,
"styleRecalcDurationMs": 20.950999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22127.575,
"heapDeltaBytes": -50617840,
"heapUsedBytes": 163056644,
"domNodes": -6548,
"jsHeapTotalBytes": -8953856,
"scriptDurationMs": 897.883,
"eventListeners": -7469,
"totalBlockingTimeMs": 306,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 22482.05399999995,
"styleRecalcs": 174,
"styleRecalcDurationMs": 21.421999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22186.609999999997,
"heapDeltaBytes": -12414436,
"heapUsedBytes": 190697444,
"domNodes": -6548,
"jsHeapTotalBytes": 2527232,
"scriptDurationMs": 918.3050000000001,
"eventListeners": -7467,
"totalBlockingTimeMs": 94,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 6511.097999999947,
"styleRecalcs": 20,
"styleRecalcDurationMs": 80.478,
"layouts": 20,
"layoutDurationMs": 37.08399999999999,
"taskDurationMs": 6374.146,
"heapDeltaBytes": -28768752,
"heapUsedBytes": 174672732,
"domNodes": -6548,
"jsHeapTotalBytes": 10752000,
"scriptDurationMs": 114.64200000000001,
"eventListeners": -7471,
"totalBlockingTimeMs": 574,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 6483.311999999955,
"styleRecalcs": 20,
"styleRecalcDurationMs": 76.38299999999998,
"layouts": 20,
"layoutDurationMs": 25.608000000000004,
"taskDurationMs": 6411.98,
"heapDeltaBytes": -17514600,
"heapUsedBytes": 196500060,
"domNodes": -6548,
"jsHeapTotalBytes": 8871936,
"scriptDurationMs": 122.667,
"eventListeners": -7469,
"totalBlockingTimeMs": 379,
"frameDurationMs": 18.33333333333327,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9093.336000000021,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8723.063999999998,
"heapDeltaBytes": 6621408,
"heapUsedBytes": 176461252,
"domNodes": 0,
"jsHeapTotalBytes": 1572864,
"scriptDurationMs": 165.59400000000002,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9229.403000000048,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8759.576,
"heapDeltaBytes": 20665164,
"heapUsedBytes": 176786736,
"domNodes": 0,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 208.89000000000001,
"eventListeners": -12,
"totalBlockingTimeMs": 19,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 107.06000000004678,
"styleRecalcs": 7,
"styleRecalcDurationMs": 12.848000000000003,
"layouts": 2,
"layoutDurationMs": 0.691,
"taskDurationMs": 66.254,
"heapDeltaBytes": 3019816,
"heapUsedBytes": 71465380,
"domNodes": 106,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 4.952,
"eventListeners": 35,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 466.04200000001583,
"styleRecalcs": 18,
"styleRecalcDurationMs": 22.240999999999996,
"layouts": 2,
"layoutDurationMs": 1.1170000000000002,
"taskDurationMs": 105.222,
"heapDeltaBytes": 4905368,
"heapUsedBytes": 73532788,
"domNodes": 144,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 8.445999999999998,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.799999999999272
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #16878 +/- ##
==========================================
+ Coverage 81.11% 82.76% +1.65%
==========================================
Files 2458 2044 -414
Lines 126457 119313 -7144
Branches 33692 30465 -3227
==========================================
- Hits 102573 98752 -3821
+ Misses 23369 20380 -2989
+ Partials 515 181 -334
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 496 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Two follow-ups from the #16840 review pass: (a) resumedTurnTabPath() fell back to activeWorkflowTurnContext()?.tabPath unconditionally once the id-less context change landed, so a turn with no workflow lit the editing spinner on whatever tab happened to be active and markModified it on completion. Only a context carrying a real workflow id may be attributed now; an id-less turn resolves to nothing. (b) The echo guard snapshotted priorWorkflowId before prepare(), so a bindWorkflow() landing in the prepare()/POST window (a late agent_active_tab frame, an overlapping send, loadThread) left the guard comparing against a stale pre-turn value: the echoed id read as freshly minted and re-bound the origin tab, clobbering the binding the mid-turn event had just established. Compare against the binding as of the ack instead. The deeper page-lifetime identity gap (a resumed thread's echo vs null) stays with the shep-25 escalation; this fixes only the race. Adoption on an existing thread minting a content-less workflow (r3929083599) is intentionally NOT changed here: sending the origin tab's draft with the turn is exactly what the shouldSendDraft guard deliberately prevents (an unbound scratch tab leaking its canvas into an existing thread), and relaxing it is a document-model/activation seam decision, not a low-tier patch. Addresses: #16840 (comment) #16840 (comment) #16840 (comment)
|
Deployment failed for project comfy-home-v1 with the following error: View Documentation: https://vercel.com/docs/accounts/team-members-and-roles |
|
Lifecycle blockers fixed at Full context for agent readersThis PR's stable Pushed fixes:
Focus-contract cross-check:
Verification at the corrected head:
The unrelated Vercel authorization status is not a required check. |
|
Superseded by #18291, which reimplements the tab-instance attribution and adoption fix on current |
Pins send/adoption identity to
ComfyWorkflow.instanceId; closed, replaced, renamed, rebound, and unresolved saved tabs cannot inherit an ack binding.This is now the behavioral consolidation endpoint for #16840: it includes stable instance identity plus #16840's later spinner-attribution and saved
.app.jsonfixes. No prerequisite landing order remains.Full context for agent readers
This PR now covers the complete frontend tab-attribution/adoption hardening:
workflowLookupor a reusable path..app.jsonname.The branch originally diverged from #16840 before its final two fixes. Commits
ddafe69e2and9a07daf35restore those fixes without giving up stableinstanceIdadoption, making this head the behavioral superset rather than a follow-up that must land second.Evidence
pnpm test:unit src/workbench/extensions/agent/AgentPanelRoot.test.ts src/workbench/extensions/agent/composables/agent/useAgentSession.test.ts— 183 passed.pnpm typecheck— passed.oxfmt --check— passed.