Repository navigation
fix(agent): drain stale credit on identified-mismatch results - #17624
christian-byrne wants to merge 1 commit into
Conversation
🎭 Playwright: ✅ 1997 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle: 10 MB gzip ⚪ 0 BDetailsSummary
Category Glance App Entry Points — 3.73 kB (baseline 3.73 kB) • ⚪ 0 BMain entry bundles and manifests Status: 1 unchanged Graph Workspace — 1.44 MB (baseline 1.44 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration Status: 3 unchanged Views & Navigation — 132 kB (baseline 132 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 18 unchanged Panels & Settings — 622 kB (baseline 622 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 27 unchanged User & Accounts — 26.2 kB (baseline 26.2 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 11 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 8 unchanged UI Components — 123 kB (baseline 123 kB) • ⚪ 0 BReusable component library chunks Status: 16 unchanged Data & Services — 3.71 MB (baseline 3.71 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 16 unchanged Utilities & Hooks — 560 kB (baseline 560 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 37 unchanged Vendor & Third-Party — 18.2 MB (baseline 18.2 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 17.5 MB (baseline 17.5 MB) • ⚪ 0 BBundles that do not match a named category Status: 296 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-14T03:13:56.877Z",
"gitSha": "302a5d47fb7b7d38e259501f78a1b857a9327fff",
"branch": "fix/agent-stale-identified-credit",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 1991.5730000000167,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.191,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 384.65099999999995,
"heapDeltaBytes": 12858452,
"heapUsedBytes": 74959612,
"domNodes": -259,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 8.187,
"eventListeners": -154,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-idle",
"durationMs": 1992.2749999999496,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.645,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 395.81899999999996,
"heapDeltaBytes": 16114752,
"heapUsedBytes": 78124136,
"domNodes": -262,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 8.498999999999999,
"eventListeners": -154,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1711.05399999999,
"styleRecalcs": 73,
"styleRecalcDurationMs": 22.435999999999996,
"layouts": 14,
"layoutDurationMs": 3.7039999999999997,
"taskDurationMs": 692.894,
"heapDeltaBytes": -1830092,
"heapUsedBytes": 60403584,
"domNodes": -261,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 122.272,
"eventListeners": -182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1710.183000000029,
"styleRecalcs": 74,
"styleRecalcDurationMs": 21.483,
"layouts": 14,
"layoutDurationMs": 3.788,
"taskDurationMs": 676.331,
"heapDeltaBytes": 540124,
"heapUsedBytes": 62756460,
"domNodes": -260,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 119.674,
"eventListeners": -182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1708.845999999994,
"styleRecalcs": 31,
"styleRecalcDurationMs": 12.163000000000002,
"layouts": 6,
"layoutDurationMs": 1.0630000000000002,
"taskDurationMs": 277.006,
"heapDeltaBytes": 2177252,
"heapUsedBytes": 64457188,
"domNodes": 75,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 10.764,
"eventListeners": 21,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1709.540000000061,
"styleRecalcs": 30,
"styleRecalcDurationMs": 12.636,
"layouts": 6,
"layoutDurationMs": 1.135,
"taskDurationMs": 278.282,
"heapDeltaBytes": 2060720,
"heapUsedBytes": 64377328,
"domNodes": 75,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 10.694,
"eventListeners": 21,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 560.7290000000376,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.305,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 364.728,
"heapDeltaBytes": 17646164,
"heapUsedBytes": 79870136,
"domNodes": 18,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 133.591,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 527.9140000000098,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.462999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 364.02500000000003,
"heapDeltaBytes": 17528116,
"heapUsedBytes": 79735704,
"domNodes": 18,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 131.95499999999998,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2058.113999999989,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.023999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 516.355,
"heapDeltaBytes": -990044,
"heapUsedBytes": 77423752,
"domNodes": -260,
"jsHeapTotalBytes": -532480,
"scriptDurationMs": 30.88699999999999,
"eventListeners": -184,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2038.7210000000096,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.117000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 505.61,
"heapDeltaBytes": -1349364,
"heapUsedBytes": 79179080,
"domNodes": -251,
"jsHeapTotalBytes": 552960,
"scriptDurationMs": 31.232999999999997,
"eventListeners": -180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2148.022000000026,
"styleRecalcs": 69,
"styleRecalcDurationMs": 13.440000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1322.073,
"heapDeltaBytes": 15351492,
"heapUsedBytes": 79402328,
"domNodes": -245,
"jsHeapTotalBytes": 1011712,
"scriptDurationMs": 676.4,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2104.372000000012,
"styleRecalcs": 68,
"styleRecalcDurationMs": 11.924999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1299.3190000000002,
"heapDeltaBytes": -1863512,
"heapUsedBytes": 79571020,
"domNodes": -241,
"jsHeapTotalBytes": 253952,
"scriptDurationMs": 642.972,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3173.1849999999895,
"styleRecalcs": 63,
"styleRecalcDurationMs": 10.938,
"layouts": 60,
"layoutDurationMs": 12.263,
"taskDurationMs": 1372.748,
"heapDeltaBytes": 9051944,
"heapUsedBytes": 74543076,
"domNodes": -252,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 633.7479999999999,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3206.5769999999816,
"styleRecalcs": 62,
"styleRecalcDurationMs": 11.361999999999997,
"layouts": 60,
"layoutDurationMs": 12.286000000000001,
"taskDurationMs": 1358.7720000000002,
"heapDeltaBytes": 8403640,
"heapUsedBytes": 74091036,
"domNodes": 6,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 631.3629999999999,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2493.1960000000117,
"styleRecalcs": 44,
"styleRecalcDurationMs": 7.109000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1551.2189999999996,
"heapDeltaBytes": 13678176,
"heapUsedBytes": 79726208,
"domNodes": 8,
"jsHeapTotalBytes": 679936,
"scriptDurationMs": 793.8870000000001,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2448.820000000012,
"styleRecalcs": 45,
"styleRecalcDurationMs": 8.733999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1646.5020000000002,
"heapDeltaBytes": -17219760,
"heapUsedBytes": 67473724,
"domNodes": -226,
"jsHeapTotalBytes": 1077248,
"scriptDurationMs": 832.455,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 1999.371999999994,
"styleRecalcs": 7,
"styleRecalcDurationMs": 4.389999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 441.88600000000014,
"heapDeltaBytes": 19792244,
"heapUsedBytes": 83704872,
"domNodes": -244,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 30.279000000000007,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2024.3369999999459,
"styleRecalcs": 6,
"styleRecalcDurationMs": 3.9660000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 468.2459999999999,
"heapDeltaBytes": -4622312,
"heapUsedBytes": 83301224,
"domNodes": -244,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 32.839999999999996,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 522.1540000000005,
"styleRecalcs": 48,
"styleRecalcDurationMs": 9.332999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 332.226,
"heapDeltaBytes": 13363624,
"heapUsedBytes": 76535312,
"domNodes": 22,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 117.39799999999998,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666665,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 513.6709999999312,
"styleRecalcs": 46,
"styleRecalcDurationMs": 8.748,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 327.18500000000006,
"heapDeltaBytes": 14084596,
"heapUsedBytes": 76831308,
"domNodes": 18,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 118.387,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666682,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 1993.0290000000355,
"styleRecalcs": 10,
"styleRecalcDurationMs": 5.984999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 376.85400000000004,
"heapDeltaBytes": 10436744,
"heapUsedBytes": 73703884,
"domNodes": -274,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 7.7200000000000015,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2005.4120000000353,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.476,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 385.831,
"heapDeltaBytes": -3760988,
"heapUsedBytes": 59642552,
"domNodes": -272,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 8.146,
"eventListeners": -230,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1709.9769999999808,
"styleRecalcs": 79,
"styleRecalcDurationMs": 22.452,
"layouts": 18,
"layoutDurationMs": 4.653,
"taskDurationMs": 660.2090000000001,
"heapDeltaBytes": 6617396,
"heapUsedBytes": 70048088,
"domNodes": -275,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 88.49,
"eventListeners": -200,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1693.71000000001,
"styleRecalcs": 77,
"styleRecalcDurationMs": 22.212000000000003,
"layouts": 18,
"layoutDurationMs": 4.531000000000001,
"taskDurationMs": 631.268,
"heapDeltaBytes": -723236,
"heapUsedBytes": 62624804,
"domNodes": -275,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 85.203,
"eventListeners": -230,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 867.4930000000245,
"styleRecalcs": 18,
"styleRecalcDurationMs": 22.660999999999994,
"layouts": 5,
"layoutDurationMs": 9.485000000000001,
"taskDurationMs": 688.92,
"heapDeltaBytes": 19612592,
"heapUsedBytes": 101058408,
"domNodes": 13587,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 22.950000000000006,
"eventListeners": 2385,
"totalBlockingTimeMs": 93,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8240.327000000036,
"styleRecalcs": 250,
"styleRecalcDurationMs": 36.189,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4684.2970000000005,
"heapDeltaBytes": 6152816,
"heapUsedBytes": 83912852,
"domNodes": -257,
"jsHeapTotalBytes": 2838528,
"scriptDurationMs": 2193.961,
"eventListeners": -166,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8179.0269999999055,
"styleRecalcs": 250,
"styleRecalcDurationMs": 38.403,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4678.161,
"heapDeltaBytes": -14319012,
"heapUsedBytes": 65822316,
"domNodes": -246,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 2179.513,
"eventListeners": -166,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 14497.488000000032,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13842.391000000001,
"heapDeltaBytes": -6396356,
"heapUsedBytes": 187368628,
"domNodes": -6543,
"jsHeapTotalBytes": 3424256,
"scriptDurationMs": 213.569,
"eventListeners": -7478,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 14585.186999999905,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13917.655999999999,
"heapDeltaBytes": -22258644,
"heapUsedBytes": 172866288,
"domNodes": -6542,
"jsHeapTotalBytes": 1253376,
"scriptDurationMs": 215.27100000000002,
"eventListeners": -7480,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 17108.379000000015,
"styleRecalcs": 139,
"styleRecalcDurationMs": 15.235,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16743.594999999998,
"heapDeltaBytes": -49657868,
"heapUsedBytes": 170932616,
"domNodes": -6542,
"jsHeapTotalBytes": 7020544,
"scriptDurationMs": 703.229,
"eventListeners": -7476,
"totalBlockingTimeMs": 19,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 17084.49799999994,
"styleRecalcs": 138,
"styleRecalcDurationMs": 15.024999999999983,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16744.967,
"heapDeltaBytes": -27880708,
"heapUsedBytes": 186228524,
"domNodes": -6542,
"jsHeapTotalBytes": 937984,
"scriptDurationMs": 720.744,
"eventListeners": -7474,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 5187.45100000001,
"styleRecalcs": 20,
"styleRecalcDurationMs": 61.85699999999999,
"layouts": 20,
"layoutDurationMs": 21.888999999999992,
"taskDurationMs": 5090.0960000000005,
"heapDeltaBytes": -25690168,
"heapUsedBytes": 168905932,
"domNodes": -6543,
"jsHeapTotalBytes": 11575296,
"scriptDurationMs": 84.699,
"eventListeners": -7476,
"totalBlockingTimeMs": 246,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 5208.407999999963,
"styleRecalcs": 20,
"styleRecalcDurationMs": 61.913,
"layouts": 20,
"layoutDurationMs": 22.263000000000005,
"taskDurationMs": 5103.661000000001,
"heapDeltaBytes": -45664296,
"heapUsedBytes": 168250244,
"domNodes": -6543,
"jsHeapTotalBytes": 12017664,
"scriptDurationMs": 85.01499999999999,
"eventListeners": -7476,
"totalBlockingTimeMs": 184,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7309.954000000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6989.256000000001,
"heapDeltaBytes": 8166348,
"heapUsedBytes": 194747324,
"domNodes": 0,
"jsHeapTotalBytes": -11010048,
"scriptDurationMs": 104.33900000000001,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.216666666666665,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7260.5519999999615,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6902.047,
"heapDeltaBytes": -21929352,
"heapUsedBytes": 175746720,
"domNodes": 0,
"jsHeapTotalBytes": -14417920,
"scriptDurationMs": 109.64199999999997,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 83.00400000001673,
"styleRecalcs": 7,
"styleRecalcDurationMs": 12.038000000000002,
"layouts": 2,
"layoutDurationMs": 1.2090000000000003,
"taskDurationMs": 66.393,
"heapDeltaBytes": 3152220,
"heapUsedBytes": 65123080,
"domNodes": 127,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 7.380000000000001,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666682,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 450.2150000000711,
"styleRecalcs": 19,
"styleRecalcDurationMs": 18.519000000000002,
"layouts": 5,
"layoutDurationMs": 1.9189999999999998,
"taskDurationMs": 98.981,
"heapDeltaBytes": 5008024,
"heapUsedBytes": 66957104,
"domNodes": 146,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.637999999999998,
"eventListeners": 83,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 10 included reviews per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe result handler now consumes stale anonymous-result credits for unrelated identified results. A test verifies that stale results do not settle the active batch and that a later anonymous failure does. ChangesStale result accounting
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The change addresses stale-result handling without introducing an identified merge-blocking risk. Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 inconclusive)
✅ Passed checks (6 passed)
Full details: End-To-End Regression Coverage For FixesExplanation The changed-file list is available, but the PR title and commit subjects are not included in the review context. The check requires those fields to identify bug-fix language and instructs that missing commit subjects or changed-file data must be marked inconclusive. The PR description alone cannot establish condition 1. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #17624 +/- ##
==========================================
+ Coverage 82.79% 83.68% +0.89%
==========================================
Files 2756 2127 -629
Lines 138976 123760 -15216
Branches 35723 31430 -4293
==========================================
- Hits 115066 103572 -11494
+ Misses 22817 20006 -2811
+ Partials 1093 182 -911
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 639 files with indirect coverage changes 🚀 New features to boost your workflow:
|
DrJKL
left a comment
There was a problem hiding this comment.
Pre-merge blocker
- P1 correctness: The new branch spends a stale credit for every identified mismatch, not only a result from the unacknowledged batch. A reproduced resend/result ordering lets a late anonymous result falsely acknowledge the current batch. The inline comment has the trace and requested invariant. This is the shipped-code correctness exception, so this review is
COMMENT, not approval.
Non-blocking follow-ups
- P2 tests, FE-2295: An unconditional decrement mutation still passes all 27 tests. Add a behavioral zero-credit case that proves the budget cannot become negative. This QA ticket is in ECS Refactor.
- P3 documentation, FE-2297: The PR says removing the new decrement fails three tests. The exact mutation produces one failed test and 26 passed tests.
Linear tickets: FE-2295, FE-2297.
Merged findings
- The maintainability lane found that
staleAnonymousBudgetand its owning comment no longer describe identified-result consumption. Fallow also reports inherited complexity in this callback, which the added branch worsens. Both share the P1 root cause: a scalar credit count cannot identify which stale batch an identified result belongs to. The fix should make that ownership explicit rather than add another broad condition.
Existing findings and unverified candidates
- CodeRabbit approved this head without a body or inline comments. There were no existing finding claims to confirm or contest.
- No candidates remain unverified.
Checked and cleared
- The guarded decrement prevents underflow in the current implementation, mismatch rejection remains intact, and the cross-workflow drain block is unchanged.
- Fallow audited both changed files and found no introduced issue. Its 15 dev-dependency findings are inherited and outside this diff:
@pinia/testing,@tailwindcss/vite,jsonc-parser,markdown-table,mixpanel-browser,monocart-coverage-reports,openai,picocolors,pretty-bytes,unplugin-icons,unplugin-vue-components,uuid,yaml,zip-dir, andzod-to-json-schema. - Type and framework idiom checks found no introduced violation. No UI or accessibility surface changed.
Coverage and verification
- Standard depth. Independent lanes: correctness, maintainability, idiomaticity, tests, and documentation. Both changed files were read fully; result parsing, adapter routing, and related invariant tests were traced as boundary evidence.
- Exact head:
72de4f960745c968ff28c21b49f6f3a863ad2314. - Local checks passed:
pnpm typecheck; focused Vitest, 27/27; scoped ESLint; scoped oxlint; scoped oxfmt;git diff --check; Fallow audit. - A focused exact-head reproduction with an older batch resent before acknowledgment fails because the current batch is incorrectly added as
acknowledged. - CI at the posting snapshot: 94 check runs completed, 79 successful and 15 skipped; no failed, cancelled, or pending check runs. Combined commit status is success.
| if (identified.length > 0) { | ||
| if (!identified.some((opId) => inFlight!.opIds.has(opId))) return | ||
| if (!identified.some((opId) => inFlight!.opIds.has(opId))) { | ||
| if (staleAnonymousBudget > 0) staleAnonymousBudget-- |
There was a problem hiding this comment.
[P1] This spends a credit for any identified mismatch, not only for a result from the unacknowledged batch. I reproduced this ordering through createOpSender: batch X resends and is acknowledged; batch A then times out after two sends; batch B starts; X's delayed second result consumes one A credit, A's identified result consumes the other, and A's anonymous result then acknowledges B. The settlements become ['acknowledged', 'unacknowledged', 'acknowledged'], but B should remain pending.
Please retain the stale batch's op IDs with its outstanding result credits and decrement only when the mismatch names one of those IDs. Unrelated identified mismatches must remain no-ops even while stale credits exist. This is a correctness defect in the shipped-code fix, so I am using the author-policy COMMENT exception.
|
Closing as superseded by #18538 (the merged sender follow-up that incorporates the stale identified-result accounting fix and its regression coverage). The current sender tests retain the behavior, so this conflicting branch no longer needs to land. |
Summary
Drain one stale anonymous credit when a late identified result arrives for an already-timed-out (unacknowledged) batch, so the credit does not later swallow a genuine anonymous failure of the next batch.
Changes
opSender.ts, the identified-mismatch early return (if (!identified.some(...)) return) now decrementsstaleAnonymousBudget(when > 0) before returning. Added a regression test inopSender.test.tscovering a late identified result from an unacknowledged batch while a new batch is in flight.Review Focus
staleAnonymousBudget > 0; unrelated duplicate identified results with no outstanding credit behave exactly as before (rejected, budget untouched).Evidence
Origin: deferred review note on #16901 (review) — "the identified-mismatch return ... also leaves stale credits outstanding when an unacknowledged batch's late result arrives identified while a new batch is in flight." Verified still present on
mainafter PR 16901 merged (2c8f128); PR 17488 and PR 16878 do not touch this path.Failure trace on
main: batch A times out twice →staleAnonymousBudget = 2, A settledunacknowledged; batch B enqueued; late identified A result (sameworkflowId, op_ids not in B) hits the identified-mismatch return with no drain → budget stays 2 → B's genuine anonymous failure is swallowed as "stale".Tests: new test
a late identified result from an unacknowledged batch drains a stale credit. Red check: removing the decrement fails 3 tests (incl. the new one). Green:vitest run src/workbench/extensions/agent/crdt/opSender.test.ts→ 27/27.oxfmtno changes;eslintexit 0.vue-tscskipped locally (symlinked node_modules makes it unreliable); relying on CI typecheck. Playwright not applicable to unit-level credit accounting.