Repository navigation
BE-11470: test(agent): record a conversation thread into a replay fixture with one command - #16782
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughAdds a CLI to record agent conversations from Redis and PostgreSQL, validate and assemble replay fixtures, persist provenance receipts, and document the recording workflow. ChangesAgent conversation recording
Priority: ⬇️ Low Estimated code review effort: 4 (Complex) | ~60 minutes Sequence Diagram(s)sequenceDiagram
participant RecorderCLI
participant Redis
participant AgentAPI
participant PostgreSQL
participant assembleConversation
RecorderCLI->>Redis: subscribe to agent frames
RecorderCLI->>AgentAPI: post seed and prompt turns
AgentAPI-->>Redis: publish response frames
RecorderCLI->>PostgreSQL: retrieve audit rows and workflow draft
RecorderCLI->>assembleConversation: provide capture and rows
assembleConversation-->>RecorderCLI: return conversation and receipt
Suggested reviewers: Merge Risk: 🟡 Moderate · up to The new recorder can produce replay fixtures with duplicated mutations or incorrect cancellation boundaries, and its troubleshooting guidance may misdirect operators. Mutable exported recording-contract values can also undermine fixture sanitization or validation in consumers. These issues should be addressed before merge. Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 inconclusive)
✅ Passed checks (6 passed)
Full details: End-To-End Regression Coverage For FixesExplanation The PR metadata does not provide the PR title or commit subjects. The required bug-fix signal cannot be verified. The available changed-file summary shows no ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
🎭 Playwright: ✅ 1957 passed, 0 failed · 2 flaky📊 Browser Reports
📦 Bundle: 9.92 MB gzip ⚪ 0 BDetailsSummary
Category Glance App Entry Points — 3.73 kB (baseline 3.73 kB) • ⚪ 0 BMain entry bundles and manifests Status: 1 unchanged Graph Workspace — 1.43 MB (baseline 1.43 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration Status: 3 unchanged Views & Navigation — 132 kB (baseline 132 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 18 unchanged Panels & Settings — 622 kB (baseline 622 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 27 unchanged User & Accounts — 26.2 kB (baseline 26.2 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 11 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 8 unchanged UI Components — 118 kB (baseline 118 kB) • ⚪ 0 BReusable component library chunks Status: 15 unchanged Data & Services — 3.7 MB (baseline 3.7 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 16 unchanged Utilities & Hooks — 558 kB (baseline 558 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 36 unchanged Vendor & Third-Party — 18.2 MB (baseline 18.2 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 17.1 MB (baseline 17.1 MB) • ⚪ 0 BBundles that do not match a named category Status: 296 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-11T01:41:01.846Z",
"gitSha": "20503f143b280434acc7f97fa0a1b167f5feade2",
"branch": "nathaniel/be-11470-recording-tooling-ts",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 1993.0400000000077,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.4339999999999975,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 350.40600000000006,
"heapDeltaBytes": -3278488,
"heapUsedBytes": 58472608,
"domNodes": -260,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 7.807000000000001,
"eventListeners": -186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2004.4010000000299,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.177,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 459.821,
"heapDeltaBytes": 6800288,
"heapUsedBytes": 68966956,
"domNodes": -264,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 8.526000000000002,
"eventListeners": -154,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2041.6250000000105,
"styleRecalcs": 78,
"styleRecalcDurationMs": 35,
"layouts": 14,
"layoutDurationMs": 5.857,
"taskDurationMs": 1018.0849999999999,
"heapDeltaBytes": 538808,
"heapUsedBytes": 61970700,
"domNodes": -266,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 194.658,
"eventListeners": -184,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1807.0229999999583,
"styleRecalcs": 77,
"styleRecalcDurationMs": 28.255000000000003,
"layouts": 14,
"layoutDurationMs": 4.1000000000000005,
"taskDurationMs": 838.219,
"heapDeltaBytes": 10703952,
"heapUsedBytes": 72803500,
"domNodes": -260,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 163.573,
"eventListeners": -156,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1734.448000000043,
"styleRecalcs": 32,
"styleRecalcDurationMs": 15.005,
"layouts": 6,
"layoutDurationMs": 1.074,
"taskDurationMs": 333.978,
"heapDeltaBytes": 1883572,
"heapUsedBytes": 64091288,
"domNodes": 75,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 10.473999999999997,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1706.8209999999908,
"styleRecalcs": 30,
"styleRecalcDurationMs": 15.936000000000002,
"layouts": 6,
"layoutDurationMs": 1.0340000000000003,
"taskDurationMs": 331.943,
"heapDeltaBytes": 1868564,
"heapUsedBytes": 64281672,
"domNodes": 76,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 10.599,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 618.7810000000127,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.621999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 437.23799999999994,
"heapDeltaBytes": 17483812,
"heapUsedBytes": 79540464,
"domNodes": 16,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 165.66500000000002,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 632.8849999999875,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.441000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 444.164,
"heapDeltaBytes": 17850052,
"heapUsedBytes": 79887116,
"domNodes": 16,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 168.99,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2070.4299999999876,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 602.8779999999999,
"heapDeltaBytes": 1261876,
"heapUsedBytes": 80245328,
"domNodes": -248,
"jsHeapTotalBytes": 778240,
"scriptDurationMs": 35.33399999999999,
"eventListeners": -184,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2002.0640000000185,
"styleRecalcs": 3,
"styleRecalcDurationMs": 2.708000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 540.337,
"heapDeltaBytes": 19659844,
"heapUsedBytes": 83384104,
"domNodes": -252,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 33.03700000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2198.4170000000063,
"styleRecalcs": 64,
"styleRecalcDurationMs": 9.194999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1607.7240000000002,
"heapDeltaBytes": 18416392,
"heapUsedBytes": 83048784,
"domNodes": -253,
"jsHeapTotalBytes": 1011712,
"scriptDurationMs": 844.242,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2236.8759999999384,
"styleRecalcs": 66,
"styleRecalcDurationMs": 11.100999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1654.6970000000001,
"heapDeltaBytes": -540856,
"heapUsedBytes": 79558480,
"domNodes": -250,
"jsHeapTotalBytes": 741376,
"scriptDurationMs": 856.162,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3531.714999999963,
"styleRecalcs": 62,
"styleRecalcDurationMs": 11.405000000000001,
"layouts": 60,
"layoutDurationMs": 11.793999999999999,
"taskDurationMs": 1673.473,
"heapDeltaBytes": 8728372,
"heapUsedBytes": 74397196,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 806.263,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3601.124000000027,
"styleRecalcs": 62,
"styleRecalcDurationMs": 10.824,
"layouts": 60,
"layoutDurationMs": 11.770000000000003,
"taskDurationMs": 1669.704,
"heapDeltaBytes": 9853536,
"heapUsedBytes": 75390384,
"domNodes": -254,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 783.315,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3023.955000000001,
"styleRecalcs": 41,
"styleRecalcDurationMs": 5.763000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1859.1240000000003,
"heapDeltaBytes": 20445604,
"heapUsedBytes": 88393816,
"domNodes": 2,
"jsHeapTotalBytes": 679936,
"scriptDurationMs": 964.825,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3207.0190000000593,
"styleRecalcs": 43,
"styleRecalcDurationMs": 8.125000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2051.083,
"heapDeltaBytes": -3334768,
"heapUsedBytes": 87653148,
"domNodes": -262,
"jsHeapTotalBytes": 2281472,
"scriptDurationMs": 1053.354,
"eventListeners": 0,
"totalBlockingTimeMs": 8,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2023.286999999982,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.805000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 429.78100000000006,
"heapDeltaBytes": -4230236,
"heapUsedBytes": 83253848,
"domNodes": -249,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 38.205000000000005,
"eventListeners": -184,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2042.3979999999347,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.698,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 606.282,
"heapDeltaBytes": -6101304,
"heapUsedBytes": 81278384,
"domNodes": -252,
"jsHeapTotalBytes": -233472,
"scriptDurationMs": 35.314,
"eventListeners": -184,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 579.851000000076,
"styleRecalcs": 45,
"styleRecalcDurationMs": 9.59,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 397.644,
"heapDeltaBytes": 13480724,
"heapUsedBytes": 76428832,
"domNodes": 16,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 144.426,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 587.680999999975,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.234,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 404.876,
"heapDeltaBytes": 13602380,
"heapUsedBytes": 76723288,
"domNodes": 20,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 141.376,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2017.7419999999984,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.579999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 450.272,
"heapDeltaBytes": -4055864,
"heapUsedBytes": 59547756,
"domNodes": -276,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 7.263999999999999,
"eventListeners": -230,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2002.9089999999314,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.518999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 451.95699999999994,
"heapDeltaBytes": -556408,
"heapUsedBytes": 62794672,
"domNodes": -275,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 6.863000000000001,
"eventListeners": -230,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1702.0930000000476,
"styleRecalcs": 77,
"styleRecalcDurationMs": 25.751,
"layouts": 18,
"layoutDurationMs": 4.478000000000001,
"taskDurationMs": 783.8530000000001,
"heapDeltaBytes": -1211724,
"heapUsedBytes": 62194344,
"domNodes": -275,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 107.353,
"eventListeners": -232,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1721.9949999999926,
"styleRecalcs": 78,
"styleRecalcDurationMs": 28.448999999999995,
"layouts": 18,
"layoutDurationMs": 4.734,
"taskDurationMs": 798.9789999999999,
"heapDeltaBytes": 6207780,
"heapUsedBytes": 69387116,
"domNodes": -275,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 112.32800000000002,
"eventListeners": -232,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1384.0830000000324,
"styleRecalcs": 16,
"styleRecalcDurationMs": 28.537999999999993,
"layouts": 5,
"layoutDurationMs": 13.055000000000001,
"taskDurationMs": 879.9970000000002,
"heapDeltaBytes": 19369584,
"heapUsedBytes": 99635688,
"domNodes": 13587,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 30.260999999999996,
"eventListeners": 2387,
"totalBlockingTimeMs": 143,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8202.094999999987,
"styleRecalcs": 247,
"styleRecalcDurationMs": 34.785999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5164.151000000001,
"heapDeltaBytes": -13145260,
"heapUsedBytes": 66177196,
"domNodes": -248,
"jsHeapTotalBytes": 3661824,
"scriptDurationMs": 2796.9739999999997,
"eventListeners": -168,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8392.227000000048,
"styleRecalcs": 248,
"styleRecalcDurationMs": 36.392999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5884.159000000001,
"heapDeltaBytes": -3497580,
"heapUsedBytes": 75422076,
"domNodes": -246,
"jsHeapTotalBytes": 1003520,
"scriptDurationMs": 2772.6879999999996,
"eventListeners": -138,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17049.661000000015,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16565.520999999997,
"heapDeltaBytes": -13983100,
"heapUsedBytes": 188462404,
"domNodes": -6542,
"jsHeapTotalBytes": -4132864,
"scriptDurationMs": 279.4,
"eventListeners": -7478,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 17066.30299999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16698.596,
"heapDeltaBytes": -7437512,
"heapUsedBytes": 192648596,
"domNodes": -6542,
"jsHeapTotalBytes": 3588096,
"scriptDurationMs": 280.1,
"eventListeners": -7476,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20765.60299999994,
"styleRecalcs": 167,
"styleRecalcDurationMs": 17.631000000000007,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20496.152,
"heapDeltaBytes": -40562204,
"heapUsedBytes": 165860096,
"domNodes": -6542,
"jsHeapTotalBytes": -565248,
"scriptDurationMs": 952.2360000000001,
"eventListeners": -7470,
"totalBlockingTimeMs": 142,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 16370.642999999973,
"styleRecalcs": 95,
"styleRecalcDurationMs": 13.60699999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15939.523000000001,
"heapDeltaBytes": -13192256,
"heapUsedBytes": 187650996,
"domNodes": -6542,
"jsHeapTotalBytes": -3584000,
"scriptDurationMs": 880.9520000000001,
"eventListeners": -7476,
"totalBlockingTimeMs": 42,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 6093.792000000008,
"styleRecalcs": 20,
"styleRecalcDurationMs": 79.88199999999998,
"layouts": 20,
"layoutDurationMs": 22.932999999999996,
"taskDurationMs": 5987.599,
"heapDeltaBytes": -23372604,
"heapUsedBytes": 172189408,
"domNodes": -6542,
"jsHeapTotalBytes": 15437824,
"scriptDurationMs": 108.792,
"eventListeners": -7474,
"totalBlockingTimeMs": 416,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 6201.434999999947,
"styleRecalcs": 20,
"styleRecalcDurationMs": 81.68700000000001,
"layouts": 20,
"layoutDurationMs": 22.98199999999999,
"taskDurationMs": 6065.072,
"heapDeltaBytes": -31353076,
"heapUsedBytes": 176584680,
"domNodes": -6542,
"jsHeapTotalBytes": 6447104,
"scriptDurationMs": 121.18099999999998,
"eventListeners": -7476,
"totalBlockingTimeMs": 517,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8481.65599999993,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8310.884999999998,
"heapDeltaBytes": -15867488,
"heapUsedBytes": 167520060,
"domNodes": 0,
"jsHeapTotalBytes": -3407872,
"scriptDurationMs": 132.01200000000003,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8624.163000000066,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8472.301000000001,
"heapDeltaBytes": -1928032,
"heapUsedBytes": 188530760,
"domNodes": 0,
"jsHeapTotalBytes": -12320768,
"scriptDurationMs": 146.895,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 463.2690000000821,
"styleRecalcs": 21,
"styleRecalcDurationMs": 25.603,
"layouts": 3,
"layoutDurationMs": 1.5530000000000002,
"taskDurationMs": 124.76000000000003,
"heapDeltaBytes": 5088276,
"heapUsedBytes": 66736328,
"domNodes": 149,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 11.811,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 440.00000000005457,
"styleRecalcs": 12,
"styleRecalcDurationMs": 17.509999999999998,
"layouts": 3,
"layoutDurationMs": 0.8350000000000001,
"taskDurationMs": 95.057,
"heapDeltaBytes": 4709424,
"heapUsedBytes": 66420344,
"domNodes": 117,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.834,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #16782 +/- ##
==========================================
+ Coverage 82.12% 83.43% +1.30%
==========================================
Files 2570 2090 -480
Lines 130596 121485 -9111
Branches 35673 32607 -3066
==========================================
- Hits 107254 101359 -5895
+ Misses 22755 19947 -2808
+ Partials 587 179 -408
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Add a request/response fixture pattern for the in-app agent: one user prompt in, an ordered agent response out (chat frames plus the semantic graph ops the doc host folds into the workflow document). - agentConversationFixture.ts drives the real composer, mocks the /api/agent routes, owns the /ws route, mints the seed workflow with the pinned comfy-multi-player applier, answers the follower's doc_subscribe with a catch-up, replays each graph_ops entry as a doc_update frame, and snapshots the rendered nodes and slot connectivity of the agent's doc. - data/agent/agentConversation.ts is the zod-typed conversation schema and loader; the two JSON conversations derive from evals agent-suite cases (agent-l4-zimage-string-node-prompt, agent-workflow-editing-05) with the response side synthesized from each case's expected outcome. - agentConversationReplay.spec.ts replays both and asserts the tool-call group, tab link, final message, CRDT status, and end graph state. - bootAgentApp accepts extra settings so Vue nodes can be enabled, which is the renderer that projects follower edits onto the canvas. Claude-Session: https://claude.ai/code/session_0181SuRew6ZZf4o47oPVdn5r
AgentConversationHarness is only constructed inside its own file (the agentConversationTest fixture); the export served no external consumer and knip flagged it as an unused export.
agent_active_tab for an unbound workflow called createTemporary(name) with no data, which seeds defaultGraph. The follower then reconciled the doc onto template nodes with the same ids (3, 8, 9); reconcileNode keeps any link it does not displace, so template link 8 (node 4 VAE to node 8 vae) survived and VAEDecode rendered [true, true]. The replay spec for agent-workflow-editing-05 caught this in CI. Pass blankGraph so the tab really is empty, as the surrounding comment and the PR describe. The "blank named tab" unit test now asserts the minted tab holds no nodes or links (fails on the old code). The fixture comment on graphSnapshot now describes the collision hazard instead of treating the template as expected.
A recorded conversation is a thread of turns (agent-conversation.v2) replayed onto the real panel and canvas: HTTP and the socket are data, the doc host is the real library in-process, and every expectation is derived from the fixture and the applier's graph. Covers recorded-gap timing, a human edit while the agent is still adding nodes, and the replay-coverage convention for agent bug fixes.
3a42b75 to
262c641
Compare
A turn may carry the entry its cancel followed. The replay presses the panel's Stop button right after sending that entry, the existing cancel route answers it, and the recorded tail streams on as recorded, so the turn still ends on the recorded done frame. The spec derives what it asserts from the fixture: the tail the panel should show is the recorded delta text, and the graph is the ops that landed before the cut.
836b544 to
86918e9
Compare
Drops the two synthesized v1 fixtures the carried commit brought along and un-exports the schema pieces only the exporter reads.
Nine single-turn cases and three multi-turn threads (a dependent two-turn edit, a three-turn add, set, delete chain, and a clarifying question), every frame with its recorded offset.
The agent was asked for three nodes and stopped after the first one, so the recorded tail says one edit was made and the graph carries exactly that node. A replay that ignored the cancel would show three.
…one command The recorder drives every turn against the local agent, keeps the socket frames with their offsets and the accepted op rows, applies the assembler gates as small pure functions behind zod boundaries, and writes the fixture through the exporter, which emits one conversation turn per recorded message. The README documents the stack, the launcher's record mode and the capture format.
…corder The launcher's record mode on the cloud repo's own local stack is the only recording base; defaults and docs no longer name private containers or the REC_* fallbacks.
The recorder can now stop the turn it is recording: --cancel-turn <k> --cancel-after-ms <n> posts the panel's own cancel endpoint n ms after turn k's ack, keeps recording to the terminal frame, and notes which frame the cancel followed. The exporter carries that point through as the response entry the cancel followed, which is not the same index: graph_ops entries are inserted ahead of their terminal tool-call frame.
DrJKL
left a comment
There was a problem hiding this comment.
Verdict: ready to approve at 54017af8da. The merge incorporates main at 8825d135ab and removes the three conflicts reported in the previous review. All eight PR-specific files remain byte-for-byte identical to the previously reviewed head, including the recorder/schema changes in the conflicted files. No new implementation finding.
The original operation-order finding r3963498354 remains fixed: the real assembler/HostDoc probe rejects the crossed-order draft while the matching-order control retains its node. The clear finding r3963498357 also remains fixed: an empty draft is accepted and replays zero nodes; a stale nonempty draft is rejected. Malformed operations, late cancellation and tool-name/outcome disagreement are still rejected, while object-key permutations and valid partial-error application pass.
After a frozen install, 76 focused assembler/schema tests passed. Frontend, scripts and browser typechecks, five-file ESLint/format checks, and type-aware oxlint exited 0. Playwright discovered 14 cloud replay scenarios; no local browser suite was executed. Current-head CI reports 74 success and 15 skipped checks. A trial merge with #16872 is conflict-free, but that does not clear its existing redaction and combined-stack type findings.
Maintainability and validation limits
This follow-up checks merge preservation across all eight net PR files. Prior correctness, test, type and documentation review evidence is reused because those files and HostDoc are unchanged. The maintainability pass found no new duplicated contract, discarded behavior or added machinery.
Fallow inspected eight changed files and exited 1 for the same eight complexity scores as the prior review, with zero dead-code issues or clone groups. The flagged functions are unchanged:
- Recorder
main, line 315. - Recorder
recordTurns, line 150. - Assembler
keepTurnFrames, line 242. - Assembler
checkDraft, line 509. - Assembler
buildResponse, line 392. - Fixture
assertOpsApply, line 239. - Recorder callback, line 131.
- Recorder
waitDone, line 218.
These scores are not new merge regressions. Fallow also warns that stored baseline paths did not match; this is not a passing audit or measured coverage result. Oxlint reports four unchanged warnings: the fixture test's second expect argument at line 163, the website declaration's triple-slash reference, and two array-sort warnings in renderStack.test.ts. The latter three are in files identical to main. No duplicate inline comments are posted.
Superseded by review 5163213631 (ready to approve after 16764 lands); 16764 merged.
christian-byrne
left a comment
There was a problem hiding this comment.
Approving at head 54017af.
Alex's latest review (#16782 (review)) reads "Verdict: ready to approve after PR 16764 lands" with no remaining inline findings. PR 16764 has landed and this PR has retargeted to main; CI is green at this head.
Per the agent-channel agreement (merge the integration test stack now, follow up immediately after), dismissing the superseded change requests and landing once CI is green against main.
Full context for agent readers
Base before retarget: nathaniel/be-11470-recorded-replay-fixtures. Children 17018, 17037, 17017 are based on this branch and retarget after it merges. CLI boundary follow-ups (flag parsing, help behavior, PLAYWRIGHT_LOCAL gating) are tracked in the test follow-up plan.
Superseded by approval 5174306254 at head 54017af; findings addressed in subsequent commits.
…rn (Comfy-Org#16764) ## Summary Replays recorded agent conversations as Playwright tests against the real chat panel and canvas, with the recordings that execute in this PR, and stops the agent's new tab from colliding with the host document. ## Changes - **What**: `agentConversationFixture.ts` types each recorded prompt into the chat panel, plays the agent side back from the recording, applies the recorded graph operations through the real multi-player library in an in-process host, and asserts the panel and the canvas after each turn. Thirteen recordings under `fixtures/data/agent/conversations/` execute here. The fixture schema is the production socket union minus the two ids the replay mints; recorded operations stay structural, and `assertOpsApply` applies them to a document minted from the recording's seed and catalog, refusing a recording the applier rejects or one whose projection is left without a value. Per turn the spec asserts the complete assistant text and the ordered tool rows (label, failure glyph, multiplicity) against the literal expectations in `agentConversationExpectations.ts`, the composer by its locale-rendered name, the added nodes visible and the deleted ones gone, the recorded widget values, the endpoint pairs of every connect with both slot rows, and, for the two-turn wiring case, a screenshot of the canvas after the connect. Production: `AgentPanelRoot.vue` opens the agent's tab with `createNewTemporary(name, blankGraph)` so it never reuses an open workflow and never starts from the default template, and the CRDT follower marks the canvas dirty after every reconciled frame so a connect-only frame paints its wire without a pan (the two-turn replay caught that). - **Breaking**: none. ## Review Focus Read `agentConversationReplay.spec.ts` first: the per-turn loop is where every assertion lands. The recorder that produces these fixtures is Comfy-Org#16782; the split-out production fix for the blank tab is Comfy-Org#17043. Known gap, tracked in Comfy-Org#17171: a node the catch-up materialized renders its class name in most replays and its display name in some, while a node the agent adds always renders the display name. The visible-title assertion is exact for added nodes and recorded titles, and accepts either spelling only for a catch-up node until the follower is fixed. --------- Co-authored-by: Christian Byrne <cbyrne@comfy.org> Co-authored-by: cheap-drain <christian@ampcode.com> Co-authored-by: github-actions <github-actions@github.com>
Summary
One command records a conversation thread on the local cloud agent and writes it as the fixture #16764 replays: it drives every turn (and can cancel one mid-flight), keeps the socket frames with their offsets and the accepted op rows, assembles them through pure gates behind zod boundaries, and writes the fixture with a receipt. Stacked on #16764. Linear: BE-11470 (contract 2).
Changes
scripts/agentConversationAssemble.ts(the boundary schemas, the gates as pure functions, the fixture and receipt builders) with its tests;scripts/agentConversationRecord.ts(the CLI: env, turns, socket and row plumbing, sidecars);browser_tests/fixtures/data/agent/README.md(the stack the recorder needs, the command, the capture format). The gates: one accepted cancel placed against timestamped frames, exactly one terminal frame per turn, one parent row and one terminal frame per tool call that agree on the tool and its outcome, one echoed operation per id, applied ops exported in the order the frames closed them and validated by replaying that exact stream through the fixture's own host, and a persisted draft that must match the replay's projection on every node's class and widget values and on every link.redis-cliandpsqlreachable as the README says.Review Focus
pnpm typecheck:scripts(scripts/tsconfig.json) covers these files. Every recording in BE-11470: test(agent): replay recorded agent conversations turn by turn #16764 was produced by this tool and replays green.