Skip to content

Merge main into be-11470-recording-tooling-ts (unblock 16782) - #17410

Closed
christian-byrne wants to merge 1 commit into
nathaniel/be-11470-recording-tooling-tsfrom
christian/16782-rebase-label-fix
Closed

christian-byrne wants to merge 1 commit into
nathaniel/be-11470-recording-tooling-tsfrom
christian/16782-rebase-label-fix

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

Merges origin/main into the head branch of #16782 so that PR becomes mergeable after #16764 landed. No functional change beyond conflict resolution.

Full context for agent readers

Why: #16782 was stacked on #16764. After 16764 merged and 16782 was retargeted to main, three files conflicted as add/add because both branches introduced them independently:

  • browser_tests/README.md
  • browser_tests/fixtures/data/agent/agentConversation.ts
  • browser_tests/fixtures/data/agent/agentConversation.test.ts

Resolution: kept the 16782 versions (--ours) because they are the superset that 16764's copy was derived from; the label-drift fix in this branch is preserved. Same helper-PR pattern as #17391 (merged), used because pushing directly to a nathaniel/* branch is out of scope for this lane.

Verification on the merge commit:

  • pnpm vitest run browser_tests/fixtures/data/agent passes (2 files, 76 tests)
  • pnpm typecheck passes

After this merges into nathaniel/be-11470-recording-tooling-ts, 16782 should show MERGEABLE and can be approved and enqueued.

…e-label-fix

# Conflicts:
#	browser_tests/README.md
#	browser_tests/fixtures/data/agent/agentConversation.test.ts
#	browser_tests/fixtures/data/agent/agentConversation.ts
@coderabbitai

coderabbitai Bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: ecc13922-e663-4943-9553-77c70eb0a718

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 11, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/11/2026, 01:35:29 AM UTC

Links

🎭 Playwright: ✅ 1959 passed, 0 failed · 1 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1938 / ❌ 0 / ⚠️ 1 / ⏭️ 13)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

@christian-byrne

Copy link
Copy Markdown
Contributor Author

Closing: redundant. #16782 already merged main after #16764 landed, so the label fix and rebase here are no longer needed.

@christian-byrne
christian-byrne deleted the christian/16782-rebase-label-fix branch September 11, 2026 01:41
@github-actions github-actions Bot added the risk:xhigh PR risk grade (advisory shadow check; grader-owned) label Sep 11, 2026
@codecov

codecov Bot commented Sep 11, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 87.09677% with 8 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...tform/workspace/composables/useWorkspaceBilling.ts 75.86% 7 Missing ⚠️
src/lib/litegraph/src/LGraph.ts 85.71% 1 Missing ⚠️
@@                             Coverage Diff                             @@
##           nathaniel/be-11470-recording-tooling-ts   #17410      +/-   ##
===========================================================================
- Coverage                                    83.42%   83.07%   -0.35%     
===========================================================================
  Files                                         2090     2094       +4     
  Lines                                       121459   122555    +1096     
  Branches                                     30769    31802    +1033     
===========================================================================
+ Hits                                        101323   101813     +490     
- Misses                                       19957    20563     +606     
  Partials                                       179      179              
Flag Coverage Δ
unit 78.30% <97.77%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/composables/graph/useSubgraphOperations.ts 89.65% <100.00%> (+12.10%) ⬆️
src/lib/litegraph/src/subgraph/subgraphUtils.ts 92.32% <100.00%> (+2.85%) ⬆️
src/stores/nodeOutputStore.ts 83.76% <100.00%> (-5.51%) ⬇️
src/lib/litegraph/src/LGraph.ts 79.06% <85.71%> (+0.14%) ⬆️
...tform/workspace/composables/useWorkspaceBilling.ts 81.31% <75.86%> (-15.14%) ⬇️

... and 43 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:xhigh PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants