Repository navigation
test(agent): cover populated LoadImage layout - #16649
Conversation
📦 Bundle: 9.41 MB gzip 🔴 +2 BDetailsSummary
Category Glance App Entry Points — 5.36 kB (baseline 5.36 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 2.16 MB (baseline 2.16 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration Status: 3 unchanged Views & Navigation — 147 kB (baseline 147 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 18 unchanged Panels & Settings — 669 kB (baseline 669 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 29 unchanged User & Accounts — 61.2 kB (baseline 61.2 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 15 unchanged Editors & Dialogs — 341 kB (baseline 341 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 12 unchanged UI Components — 211 kB (baseline 211 kB) • ⚪ 0 BReusable component library chunks Status: 24 unchanged Data & Services — 1.36 MB (baseline 1.36 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 25 unchanged Utilities & Hooks — 2.29 MB (baseline 2.29 MB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 62 unchanged Vendor & Third-Party — 14.3 MB (baseline 14.3 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 19 MB (baseline 19 MB) • ⚪ 0 BBundles that do not match a named category
Status: 1 added / 1 removed / 351 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-12T09:30:53.704Z",
"gitSha": "8af7d6a79e35b1219400517dd5e13a0bc90285b4",
"branch": "christian-byrne/ecw121-agent-conversation-replay-poc",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2026.42800000001,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.613999999999999,
"layouts": 11,
"layoutDurationMs": 2.854,
"taskDurationMs": 404.83599999999996,
"heapDeltaBytes": -4684172,
"heapUsedBytes": 63012728,
"domNodes": -162,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 10.203,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2023.3429999999544,
"styleRecalcs": 11,
"styleRecalcDurationMs": 4.661,
"layouts": 11,
"layoutDurationMs": 3.7610000000000006,
"taskDurationMs": 444.74,
"heapDeltaBytes": 1635096,
"heapUsedBytes": 69367332,
"domNodes": -162,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 12.236,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1743.1869999999776,
"styleRecalcs": 73,
"styleRecalcDurationMs": 14.529000000000002,
"layouts": 11,
"layoutDurationMs": 2.612,
"taskDurationMs": 832.3799999999999,
"heapDeltaBytes": -813672,
"heapUsedBytes": 66854172,
"domNodes": -162,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 133.288,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666666,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1760.0489999999809,
"styleRecalcs": 73,
"styleRecalcDurationMs": 15.361999999999998,
"layouts": 11,
"layoutDurationMs": 2.7260000000000004,
"taskDurationMs": 855.241,
"heapDeltaBytes": -2754920,
"heapUsedBytes": 63516128,
"domNodes": -162,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 137.339,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665094339622645,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1726.6370000000393,
"styleRecalcs": 18,
"styleRecalcDurationMs": 6.5120000000000005,
"layouts": 11,
"layoutDurationMs": 3.073,
"taskDurationMs": 285.358,
"heapDeltaBytes": 20098032,
"heapUsedBytes": 87916924,
"domNodes": 47,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 11.4,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1691.3130000000365,
"styleRecalcs": 18,
"styleRecalcDurationMs": 6.3340000000000005,
"layouts": 12,
"layoutDurationMs": 3.14,
"taskDurationMs": 304.447,
"heapDeltaBytes": 18983212,
"heapUsedBytes": 86715704,
"domNodes": 47,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 12.902000000000001,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66568627450981,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-clipping",
"durationMs": 658.9250000000106,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.7869999999999995,
"layouts": 10,
"layoutDurationMs": 2.651,
"taskDurationMs": 453.71399999999994,
"heapDeltaBytes": 758932,
"heapUsedBytes": 68446832,
"domNodes": 0,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 154.152,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 592.3579999999902,
"styleRecalcs": 15,
"styleRecalcDurationMs": 6.167000000000001,
"layouts": 11,
"layoutDurationMs": 2.8089999999999997,
"taskDurationMs": 407.82700000000006,
"heapDeltaBytes": 375256,
"heapUsedBytes": 68111324,
"domNodes": 0,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 151.175,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66388888888889,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1145.3129999999874,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 818.999,
"heapDeltaBytes": -12022688,
"heapUsedBytes": 81115980,
"domNodes": -192,
"jsHeapTotalBytes": 20979712,
"scriptDurationMs": 49.65100000000002,
"eventListeners": -106,
"totalBlockingTimeMs": 466,
"frameDurationMs": 31.078378378378368,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1147.6809999999205,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 836.452,
"heapDeltaBytes": -11927288,
"heapUsedBytes": 81456272,
"domNodes": -192,
"jsHeapTotalBytes": 20455424,
"scriptDurationMs": 49.763000000000005,
"eventListeners": -106,
"totalBlockingTimeMs": 479,
"frameDurationMs": 31.941666666666656,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 778.8499999999772,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 396.5860000000001,
"heapDeltaBytes": -5236212,
"heapUsedBytes": 74704880,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 120.281,
"eventListeners": 0,
"totalBlockingTimeMs": 147,
"frameDurationMs": 23.035294117647055,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 758.3109999999351,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 397.4229999999999,
"heapDeltaBytes": -4745496,
"heapUsedBytes": 76518640,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 117.68900000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 145,
"frameDurationMs": 22.549999999999994,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9091.211999999985,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.059000000000000025,
"layouts": 1,
"layoutDurationMs": 0.30400000000000044,
"taskDurationMs": 8004.058000000001,
"heapDeltaBytes": 15872908,
"heapUsedBytes": 95185572,
"domNodes": -258,
"jsHeapTotalBytes": 5107712,
"scriptDurationMs": 6468.886,
"eventListeners": -68,
"totalBlockingTimeMs": 323,
"frameDurationMs": 28.834920634920636,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-clean-combined-draw",
"durationMs": 8379.758999999922,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.2660000000000006,
"layouts": 1,
"layoutDurationMs": 0.5119999999999995,
"taskDurationMs": 7414.226000000001,
"heapDeltaBytes": 2554864,
"heapUsedBytes": 82602056,
"domNodes": -258,
"jsHeapTotalBytes": -135168,
"scriptDurationMs": 5704.673,
"eventListeners": -68,
"totalBlockingTimeMs": 65,
"frameDurationMs": 24.679351032448377,
"p95FrameDurationMs": 49.899999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 8768.85299999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7789.4130000000005,
"heapDeltaBytes": -10299104,
"heapUsedBytes": 85145668,
"domNodes": -258,
"jsHeapTotalBytes": 126976,
"scriptDurationMs": 5981.073,
"eventListeners": -68,
"totalBlockingTimeMs": 121,
"frameDurationMs": 25.50903790087463,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 8788.479000000052,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.18799999999999895,
"layouts": 1,
"layoutDurationMs": 0.29699999999999954,
"taskDurationMs": 7860.286999999999,
"heapDeltaBytes": 3373472,
"heapUsedBytes": 82848396,
"domNodes": -258,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 6128.1939999999995,
"eventListeners": -68,
"totalBlockingTimeMs": 87,
"frameDurationMs": 25.53168604651163,
"p95FrameDurationMs": 50
},
{
"name": "large-combo-open",
"durationMs": 196.28799999998137,
"styleRecalcs": 23,
"styleRecalcDurationMs": 14.747000000000002,
"layouts": 12,
"layoutDurationMs": 3.0080000000000005,
"taskDurationMs": 147.926,
"heapDeltaBytes": -8908380,
"heapUsedBytes": 84942180,
"domNodes": 917,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 8.197,
"eventListeners": 195,
"totalBlockingTimeMs": 0,
"frameDurationMs": 22.22222222222222,
"p95FrameDurationMs": 50
},
{
"name": "large-combo-open",
"durationMs": 222.9939999999715,
"styleRecalcs": 23,
"styleRecalcDurationMs": 15.349,
"layouts": 12,
"layoutDurationMs": 3.094,
"taskDurationMs": 170.42300000000003,
"heapDeltaBytes": -9013260,
"heapUsedBytes": 84051760,
"domNodes": 917,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 7.913,
"eventListeners": 195,
"totalBlockingTimeMs": 0,
"frameDurationMs": 23.340000000000053,
"p95FrameDurationMs": 49.90000000000009
},
{
"name": "large-graph-idle",
"durationMs": 2009.567000000004,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.8839999999999995,
"layouts": 10,
"layoutDurationMs": 2.1510000000000002,
"taskDurationMs": 450.0360000000001,
"heapDeltaBytes": 238264,
"heapUsedBytes": 84024348,
"domNodes": -258,
"jsHeapTotalBytes": 913408,
"scriptDurationMs": 29.711999999999996,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2056.0449999999264,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.6279999999999992,
"layouts": 10,
"layoutDurationMs": 2.9240000000000004,
"taskDurationMs": 618.393,
"heapDeltaBytes": -715872,
"heapUsedBytes": 82856764,
"domNodes": -258,
"jsHeapTotalBytes": -659456,
"scriptDurationMs": 33.702999999999996,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2227.0490000000223,
"styleRecalcs": 70,
"styleRecalcDurationMs": 8.462999999999997,
"layouts": 10,
"layoutDurationMs": 2.565,
"taskDurationMs": 1409.9209999999998,
"heapDeltaBytes": 2092564,
"heapUsedBytes": 86559604,
"domNodes": -258,
"jsHeapTotalBytes": 4546560,
"scriptDurationMs": 730.616,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.792424242424246,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2285.154999999918,
"styleRecalcs": 69,
"styleRecalcDurationMs": 7.531,
"layouts": 8,
"layoutDurationMs": 2.0340000000000003,
"taskDurationMs": 1548.3700000000003,
"heapDeltaBytes": 2149920,
"heapUsedBytes": 87125676,
"domNodes": -258,
"jsHeapTotalBytes": 4546560,
"scriptDurationMs": 725.5500000000001,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665441176470587,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3631.5720000000056,
"styleRecalcs": 71,
"styleRecalcDurationMs": 10.459000000000001,
"layouts": 65,
"layoutDurationMs": 13.394,
"taskDurationMs": 1764.5079999999998,
"heapDeltaBytes": -6834684,
"heapUsedBytes": 71929428,
"domNodes": -254,
"jsHeapTotalBytes": 1175552,
"scriptDurationMs": 744.183,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66589861751152,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3524.540000000002,
"styleRecalcs": 72,
"styleRecalcDurationMs": 9.742999999999999,
"layouts": 66,
"layoutDurationMs": 12.992,
"taskDurationMs": 1647.864,
"heapDeltaBytes": 21919592,
"heapUsedBytes": 101761812,
"domNodes": 24,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 708.896,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665876777251185,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3056.8140000000312,
"styleRecalcs": 46,
"styleRecalcDurationMs": 6.614,
"layouts": 7,
"layoutDurationMs": 1.8380000000000003,
"taskDurationMs": 1893.384,
"heapDeltaBytes": 3941612,
"heapUsedBytes": 82932980,
"domNodes": 0,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 906.14,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.84972375690608,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2668.5899999999947,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.889,
"layouts": 6,
"layoutDurationMs": 1.8900000000000001,
"taskDurationMs": 1650.077,
"heapDeltaBytes": 8297000,
"heapUsedBytes": 96259796,
"domNodes": 0,
"jsHeapTotalBytes": 5660672,
"scriptDurationMs": 844.81,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.878343949044588,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2046.8070000000012,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.1649999999999996,
"layouts": 9,
"layoutDurationMs": 2.463,
"taskDurationMs": 585.876,
"heapDeltaBytes": -1899412,
"heapUsedBytes": 83696792,
"domNodes": -258,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 34.26199999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2044.8669999999538,
"styleRecalcs": 6,
"styleRecalcDurationMs": 2.035,
"layouts": 6,
"layoutDurationMs": 1.6840000000000006,
"taskDurationMs": 563.7410000000001,
"heapDeltaBytes": -6672276,
"heapUsedBytes": 73790248,
"domNodes": -258,
"jsHeapTotalBytes": -659456,
"scriptDurationMs": 33.45100000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760338,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 600.0399999999786,
"styleRecalcs": 48,
"styleRecalcDurationMs": 6.496999999999999,
"layouts": 11,
"layoutDurationMs": 2.993,
"taskDurationMs": 410.814,
"heapDeltaBytes": 23028308,
"heapUsedBytes": 91033592,
"domNodes": 0,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 133.76000000000002,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 581.602000000089,
"styleRecalcs": 48,
"styleRecalcDurationMs": 6.17,
"layouts": 11,
"layoutDurationMs": 2.649,
"taskDurationMs": 416.04,
"heapDeltaBytes": 22924836,
"heapUsedBytes": 91257188,
"domNodes": 0,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 138.589,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66571428571429,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-idle",
"durationMs": 2007.9620000000205,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.8930000000000007,
"layouts": 11,
"layoutDurationMs": 3.138,
"taskDurationMs": 516.302,
"heapDeltaBytes": 5943128,
"heapUsedBytes": 74013392,
"domNodes": -180,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 9.304,
"eventListeners": -114,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2021.7179999999644,
"styleRecalcs": 12,
"styleRecalcDurationMs": 4.048999999999999,
"layouts": 12,
"layoutDurationMs": 3.0039999999999996,
"taskDurationMs": 535.308,
"heapDeltaBytes": -10698132,
"heapUsedBytes": 71609408,
"domNodes": -180,
"jsHeapTotalBytes": 9437184,
"scriptDurationMs": 9.933000000000002,
"eventListeners": -114,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1742.759000000035,
"styleRecalcs": 76,
"styleRecalcDurationMs": 17.547,
"layouts": 11,
"layoutDurationMs": 2.7779999999999996,
"taskDurationMs": 814.022,
"heapDeltaBytes": 100640,
"heapUsedBytes": 68303556,
"domNodes": -172,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 95.473,
"eventListeners": -112,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714284,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1724.9159999998938,
"styleRecalcs": 77,
"styleRecalcDurationMs": 16.83,
"layouts": 9,
"layoutDurationMs": 2.1940000000000004,
"taskDurationMs": 821.1750000000001,
"heapDeltaBytes": -2186036,
"heapUsedBytes": 66233016,
"domNodes": -192,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 103.545,
"eventListeners": -112,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666990291262135,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-transition-enter",
"durationMs": 966.513999999961,
"styleRecalcs": 19,
"styleRecalcDurationMs": 25.488000000000003,
"layouts": 5,
"layoutDurationMs": 12.320999999999998,
"taskDurationMs": 739.7960000000002,
"heapDeltaBytes": 7681804,
"heapUsedBytes": 93742744,
"domNodes": 15956,
"jsHeapTotalBytes": 16392192,
"scriptDurationMs": 24.973999999999997,
"eventListeners": 3244,
"totalBlockingTimeMs": 154,
"frameDurationMs": 21.013043478260858,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8251.661000000013,
"styleRecalcs": 251,
"styleRecalcDurationMs": 21.953,
"layouts": 10,
"layoutDurationMs": 2.3309999999999995,
"taskDurationMs": 5493.838000000001,
"heapDeltaBytes": -10488004,
"heapUsedBytes": 68183924,
"domNodes": -258,
"jsHeapTotalBytes": 651264,
"scriptDurationMs": 2445.262,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.733671399594318,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8284.31599999999,
"styleRecalcs": 251,
"styleRecalcDurationMs": 23.36,
"layouts": 10,
"layoutDurationMs": 2.694,
"taskDurationMs": 5479.49,
"heapDeltaBytes": -29532388,
"heapUsedBytes": 69748092,
"domNodes": -258,
"jsHeapTotalBytes": 4358144,
"scriptDurationMs": 2445.4120000000003,
"eventListeners": -65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665927419354837,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 14470.897999999977,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13355.352,
"heapDeltaBytes": 1175440,
"heapUsedBytes": 282917100,
"domNodes": -307,
"jsHeapTotalBytes": 10772480,
"scriptDurationMs": 226.74500000000003,
"eventListeners": -7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 24.560271646859082,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "vue-large-graph-idle",
"durationMs": 19127.777999999922,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18742.675000000003,
"heapDeltaBytes": -13115764,
"heapUsedBytes": 264014360,
"domNodes": -3330,
"jsHeapTotalBytes": 9687040,
"scriptDurationMs": 285.81500000000005,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 32.73287671232877,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "vue-large-graph-pan",
"durationMs": 23405.121000000006,
"styleRecalcs": 180,
"styleRecalcDurationMs": 19.313999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23119.876,
"heapDeltaBytes": -24682332,
"heapUsedBytes": 273641816,
"domNodes": -3330,
"jsHeapTotalBytes": 1507328,
"scriptDurationMs": 843.05,
"eventListeners": -651,
"totalBlockingTimeMs": 4,
"frameDurationMs": 43.8498127340824,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "vue-large-graph-pan",
"durationMs": 23814.779000000046,
"styleRecalcs": 181,
"styleRecalcDurationMs": 21.175,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23520.547000000002,
"heapDeltaBytes": -23471164,
"heapUsedBytes": 270378108,
"domNodes": -3330,
"jsHeapTotalBytes": 4775936,
"scriptDurationMs": 834.994,
"eventListeners": -651,
"totalBlockingTimeMs": 0,
"frameDurationMs": 46.12209302325582,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-node-resize-workload",
"durationMs": 5233.450000000004,
"styleRecalcs": 20,
"styleRecalcDurationMs": 59.45700000000001,
"layouts": 20,
"layoutDurationMs": 23.233000000000004,
"taskDurationMs": 5103.187,
"heapDeltaBytes": -26029112,
"heapUsedBytes": 265593188,
"domNodes": -3330,
"jsHeapTotalBytes": 26202112,
"scriptDurationMs": 92.145,
"eventListeners": -653,
"totalBlockingTimeMs": 13,
"frameDurationMs": 29.903428571428574,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "vue-node-resize-workload",
"durationMs": 7005.367999999976,
"styleRecalcs": 20,
"styleRecalcDurationMs": 60.62600000000001,
"layouts": 20,
"layoutDurationMs": 23.904999999999994,
"taskDurationMs": 6903.89,
"heapDeltaBytes": 2148084,
"heapUsedBytes": 288394736,
"domNodes": -307,
"jsHeapTotalBytes": 9199616,
"scriptDurationMs": 107.04899999999999,
"eventListeners": -7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.32471910112359,
"p95FrameDurationMs": 83.30000000000109
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9342.335999999932,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9025.202,
"heapDeltaBytes": -27471696,
"heapUsedBytes": 246498816,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 131.23299999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 31.853242320819113,
"p95FrameDurationMs": 66.69999999999709
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9373.76400000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9186.704,
"heapDeltaBytes": -8363248,
"heapUsedBytes": 272826120,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 131.88400000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 31.91496598639456,
"p95FrameDurationMs": 66.69999999999709
},
{
"name": "workflow-execution",
"durationMs": 475.8749999999736,
"styleRecalcs": 21,
"styleRecalcDurationMs": 14.623,
"layouts": 14,
"layoutDurationMs": 4.532,
"taskDurationMs": 139.43499999999997,
"heapDeltaBytes": 6969704,
"heapUsedBytes": 79987764,
"domNodes": 124,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 13.314,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668965517241382,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 466.7379999999639,
"styleRecalcs": 11,
"styleRecalcDurationMs": 11.116,
"layouts": 11,
"layoutDurationMs": 3.752,
"taskDurationMs": 118.76299999999998,
"heapDeltaBytes": 6564512,
"heapUsedBytes": 73772100,
"domNodes": 95,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.037,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66428571428573,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 434.8850000000084,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.116,
"layouts": 76,
"layoutDurationMs": 15.052,
"taskDurationMs": 385.623,
"heapDeltaBytes": 11078244,
"heapUsedBytes": 84127216,
"domNodes": 4,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 174.35600000000002,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 406.1870000000454,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.177,
"layouts": 76,
"layoutDurationMs": 15.225999999999999,
"taskDurationMs": 348.189,
"heapDeltaBytes": 10489000,
"heapUsedBytes": 100944784,
"domNodes": 4,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 152.76899999999998,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663999999999977,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 558.4739999999329,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.148,
"layouts": 76,
"layoutDurationMs": 15.218,
"taskDurationMs": 514.5730000000001,
"heapDeltaBytes": 771924,
"heapUsedBytes": 125154584,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 195.241,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664705882352926,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 576.9419999999172,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.2039999999999997,
"layouts": 76,
"layoutDurationMs": 16.074,
"taskDurationMs": 537.453,
"heapDeltaBytes": 790880,
"heapUsedBytes": 122235624,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 199.947,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66571428571429,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2260 passed, 0 failed · 2 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since ae3afc4705a12efcaecde072e5299be0befc4767
Full docs: ADR-DEVEX-LINT-0015 |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #16649 +/- ##
==========================================
+ Coverage 86.09% 86.88% +0.79%
==========================================
Files 3651 2601 -1050
Lines 174174 145961 -28213
Branches 48040 39522 -8518
==========================================
- Hits 149949 126825 -23124
+ Misses 22215 18749 -3466
+ Partials 2010 387 -1623
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
CI red on head, deterministic. Product bug, not a flake: agent tab is the default template, not empty. Co-author trailer check also red.
Full context for agent readers
playwright-tests (cloud) fails test 2 ("evals agent-workflow-editing-05") at the graphSnapshot() expectation: node 8 VAEDecode inputs read [true, true], expected [true, false]. Run 33632296160, 4/4 attempts. Test 1 passes.
Root cause, verified by reading the code rather than the test: AgentPanelRoot.vue says a new agent workflow "opens as an EMPTY tab", but workflowStore.createTemporary(name) with no data seeds defaultGraph (workflowStore.ts L277). The follower then overlays doc nodes onto template nodes with the same ids (3, 8, 9). reconcileNode (graphMutations.ts L589-606) updates the node, clears widgets and layout, but never drops linkStore entries touching the reconciled node. Each doc connect displaces a template link only when the link id or the target slot collides. Doc 05 uses link ids 1-7 and targets 9:0, so template links 1-7 and 9 go away and template link 8 (node 4 VAE to node 8 vae, slot 1) survives. NodeSlots.vue reads lg-slot--connected from linkStore.isInputSlotConnected, so node 8 input 1 renders connected. Test 1 is not load-bearing for this hazard because its seed already wires 4.VAE to 8.vae and 8 to 9.
The test caught a real product gap. I am pushing the smallest fix, in AgentPanelRoot.vue: pass blankGraph to createTemporary so the minted tab really is empty, matching the comment and the PR body. The follower side (reconcileNode leaving foreign links in place when it overlays onto a non-empty tab) stays as a question below rather than a change in this PR.
Check for AI agent co-author trailers fails on 7017d697ef (Co-Authored-By: Claude Fable 5.1). Fixing that needs a history rewrite, which I will not do; it needs the author.
Seq semantics checked and fine: HostDoc.seq starts at 1, doc_subscribed.seq=1 plus catch-up doc_update seq=1 is accepted through catchUpPending, first apply sends seq 2. graphSnapshot sorts by Number(id), all fixture ids are numeric. @cloud runs under --project=cloud; the walkthrough job correctly skips it.
Reviewer: HPS fleet role, round 33. Standing authorization: comment reviews, fix pushes to the author's own branches, resolve own threads. No approve, no merge, no history rewrite.
|
Pushed 7554341: agent tab now minted from Full context for agent readersRound 33 of the HPS review loop. Review 5090183535 has the full root cause: Commit
Gates run locally: oxfmt, oxlint, eslint clean on the three files; Not done by me: Threads: the |
|
Severity: Note What: Why this is an issue: Once #16484 lands every fixture frame is dropped and the replay stops updating the graph. Proposed Fix: |
|
Recorded-response exporter landed; exact case captures still needed. Full context for agent readersCommit
The two existing fixtures remain labeled Verification: |
|
Severity: Minor What: The conversation fixture never sends Why this is an issue: Human-minted batches settle Proposed Fix: Ack each |
DrJKL
left a comment
There was a problem hiding this comment.
The blank-tab regression is fixed and the replay suite is distinct from #16643: this PR supplies a mock-backed browser replay fixture, while #16643 supplies the live local launcher. Three repository-rule violations remain in the new fixture and capture boundary. The co-author trailer check is also still red. Typecheck, browser typecheck, scoped lint/format, Knip, 118 targeted tests, and Playwright discovery for both cloud cases pass.
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 10 finding(s).
| Severity | Count |
|---|---|
| 🟠 High | 1 |
| 🟡 Medium | 4 |
| 🟢 Low | 4 |
| ⚪ Nit | 1 |
Panel: 8/8 reviewers contributed findings.
createTemporary reuses a same-named workflow outside workflows/ whenever the incoming data carries no id, which blankGraph does not. A subgraph blueprint named like the agent tab would be reset to blank and bound to the agent doc. createNewTemporary always mints its own tab. Addresses review feedback: #16649 (comment)
…t and foreign zAgentActiveTabData marks thread_id and message_id optional, so a valid agent_active_tab frame aborted the export. Addresses review feedback: #16649 (comment)
Playwright videos for new testsDownload the recorded videos and HTML report Recorded projects: cloud Recorded test titles:
|
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Round 2 — ledger: 10 prior finding(s) across 1 round(s) (0 never answered).
Found 10 finding(s).
| Severity | Count |
|---|---|
| 🟠 High | 4 |
| 🟡 Medium | 6 |
Panel: 3/8 reviewers contributed findings.
Reviewers that did not contribute: gemini-3.1-pro:adversarial (error), gpt-5.6-sol-max:adversarial (error), claude-opus-5-thinking-max:edge-case (error), gemini-3.1-pro:edge-case (error), gpt-5.6-sol-max:edge-case (error)
The finding(s) below could not be anchored to a line the reviewed diff carries, so they are reported here instead of inline:
.github/workflows/model-page-discovery.yaml:55— 🟠 High — Therun: |block is a YAML literal, so bash receives>> \$GITHUB_OUTPUTand"\$COUNT"verbatim: the step outputs are appended to a file literally named$GITHUB_OUTPUTand never set, and[ "\$COUNT" -eq 0 ]errors with "integer expression expected" (swallowed insideif). Downstreamsteps.compare.outputs.new_countis then'', so'' != '0'is always true — the issue step runs with zero new models,node -e "const slugs = ;"throws a swallowed SyntaxError, and a spurious empty "New models detected" issue is filed, after which every later run skips creation and real detections are never reported. Remove the backslashes; nothing in a literal block needs escaping.Raised by the review panel.
.github/workflows/pr-backport.yaml:354— 🟠 High — This step'sif:contains no status-check function, so GitHub implicitly prependssuccess()and the step is skipped wheneverBackport commitsexits 1 — even thoughsteps.backport.outputs.successnames branches that pushed cleanly.Cleanup stranded backport branches(if: ... && failure()) then deletes every branch inCREATED_BRANCHES_FILE, so a PR labeled for two targets where one conflicts loses the successfully pushed branch from origin with no PR ever opened for it. Add&& (success() || failure())to this step, and/or have cleanup delete only branches that got no PR.Raised by the review panel.
apps/billing-web/src/views/CheckoutView.vue:248— 🟠 High — When the server answersREACTIVATION_CONFIRMATION_REQUIRED, this re-quote callsquote({ planSlug: planSlug.value })and dropsteamCreditStopId, unlikequotePlan()which forwards it asteam_credit_stop_id. For a team checkout carrying a credit stop, the preview shown inCheckoutSubmit(and thequote_id/quote_version/proration_atcaptured inpreview.value) is priced without the stop while the followingsubscribeRequest()re-addsteam_credit_stop_id, so the customer confirms an amount that need not match the charge and a quote-validating server can reject the resubmission. Pass the stop id through on the re-quote.Raised by the review panel.
.github/actions/tool-cache-save/action.yml:19— 🟡 Medium — The cache key ends in-${GITHUB_SHA}(tool-cache-restore/action.yml:38) andactions/cache/save@v5hard-fails when the key already exists, yet the restore half never exposes acache-hitoutput and no call site setscontinue-on-error— they all useif: always()(e.g.ci-lint-format.yaml:107-112). A job that saves its cache and then fails a later step therefore goes red again on "re-run failed jobs" with "Cache already exists", so re-runs at the same commit can never pass; skip the save on an exact restore hit or mark the save stepcontinue-on-error: true.Raised by the review panel.
.github/workflows/pr-update-playwright-expectations.yaml:64— 🟡 Medium — Checkout uses the PR'sheadRefName, which for a fork PR names a branch in the fork rather than the base repo, soactions/checkoutfails with "ref not found" and this workflow can never run for forks. Worse, if the fork's branch name collides with an existing base-repo branch, checkout silently resolves to that branch andCommit updated expectationspushes regenerated snapshots onto it viagit push origin HEAD:refs/heads/$TARGET_BRANCH— testing and overwriting the wrong branch. Userefs/pull/<n>/headand retarget or block the push for forks;pr-update-website-screenshots.yaml:76-80has the same defect.Raised by the review panel.
apps/website/scripts/python-source-parser.ts:6— 🟡 Medium — The hand-rolled scanner has no concept of#comments and recognizes only""", not''', so a comment containing a quote (# Recraft's own category,# don't) flipsinStringfor the rest of the buffer and one with an unbalanced bracket miscountsdepth. InsliceBalancedthat throwsUnbalancedand loudly blocks the build, but in the duplicatedsplitTopLevel(apps/website/scripts/generate-workshop-models.ts:127-157) it silently mis-splits kwargs, sokwarg()/parseInputList()extract wrong or dropped inputs that ship inworkshop-models.generated.json. Since the input is realcomfy_api_nodesPython, strip#-to-EOL outside strings before scanning and handle'''.Raised by the review panel.
apps/website/scripts/generate-workshop-models.ts:221— 🟡 Medium — The dict-keys regex is line-anchored (/^\s*"..."\s*:/gm), so a single-line dict such asASPECTS = {"1:1": ..., "16:9": ...}yields only its first key and silently truncates a Combo to one option, while a single-quoted dict ({'512x512': 'Small'}) matches nothing and falls through tostringItems(body)at line 226, which harvests the dict's values too and produces options like['512x512', 'Small']. Both failure modes are silent and ship into the select fields on public model pages; match keys anywhere at the dict's top level and don't fall back to value extraction when the assignment is a dict.Raised by the review panel.
apps/website/scripts/generate-models.ts:485— 🟡 Medium — There is no slug-uniqueness check on the combined output, unlikegenerate-workshop-catalog.tswhich throws on duplicate slugs.makeSlug('Wan2_1_FP8.safetensors')andmakeSlug('wan2.1-fp8.ckpt')both yieldwan2-1-fp8, so two local models differing only in separator, case, or extension — or a local model colliding with an API slug or aLEGACY_SLUG_REDIRECTSentry — land as duplicates ingenerated-models.jsonand/models/<slug>routing silently shadows one of them. Assert uniqueness overcombinedbefore writing.Raised by the review panel.
| snapshot | status | changed pixels | | --- | --- | --- | | `tests/agent/agentConversationReplay.spec.ts-snapshots/agent-load-image-layout-cloud-linux.png` | new | n/a | Screenshot capture is not bit-deterministic; small pixel deltas are usually text rasterization noise. Confirm each rewrite corresponds to a test expected to change.
Swarmhost agentic reviewThe detailed evaluation is available to employees in the internal Slack review thread. Evaluation budget remaining for this pull request: 98 automatic and 99 manual. Updated by Swarmhost's agentic review process. |
comfy-greenlight-bot
left a comment
There was a problem hiding this comment.
This pull request at head commit aaedb8d has been reviewed and approved by Swarmhost's agentic review process.
The detailed evaluation is available to employees in the internal Slack review thread.
|
@christian-byrne Successfully backported to #21340 |
Summary
Adds a Node 2.0 Playwright regression for the five populated LoadImage rows produced by the comfy-cli layout fix.
The branch was rebuilt on current main because the original conversation replay infrastructure from this PR has already landed and evolved upstream.
Test plan
The targeted Playwright test passes locally. The New Browser Test Expectations label is present so CI can generate the Linux baseline.