Repository navigation
test(agent): replay every turn of a recorded thread - #16786
CodeJuggernaut wants to merge 67 commits into
Conversation
Add a request/response fixture pattern for the in-app agent: one user prompt in, an ordered agent response out (chat frames plus the semantic graph ops the doc host folds into the workflow document). - agentConversationFixture.ts drives the real composer, mocks the /api/agent routes, owns the /ws route, mints the seed workflow with the pinned comfy-multi-player applier, answers the follower's doc_subscribe with a catch-up, replays each graph_ops entry as a doc_update frame, and snapshots the rendered nodes and slot connectivity of the agent's doc. - data/agent/agentConversation.ts is the zod-typed conversation schema and loader; the two JSON conversations derive from evals agent-suite cases (agent-l4-zimage-string-node-prompt, agent-workflow-editing-05) with the response side synthesized from each case's expected outcome. - agentConversationReplay.spec.ts replays both and asserts the tool-call group, tab link, final message, CRDT status, and end graph state. - bootAgentApp accepts extra settings so Vue nodes can be enabled, which is the renderer that projects follower edits onto the canvas. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0181SuRew6ZZf4o47oPVdn5r
AgentConversationHarness is only constructed inside its own file (the agentConversationTest fixture); the export served no external consumer and knip flagged it as an unused export.
agent_active_tab for an unbound workflow called createTemporary(name) with no data, which seeds defaultGraph. The follower then reconciled the doc onto template nodes with the same ids (3, 8, 9); reconcileNode keeps any link it does not displace, so template link 8 (node 4 VAE to node 8 vae) survived and VAEDecode rendered [true, true]. The replay spec for agent-workflow-editing-05 caught this in CI. Pass blankGraph so the tab really is empty, as the surrounding comment and the PR describe. The "blank named tab" unit test now asserts the minted tab holds no nodes or links (fails on the old code). The fixture comment on graphSnapshot now describes the collision hazard instead of treating the template as expected.
Capture the turn from the standalone agent's local store, convert it to a recorded conversation fixture, add a replay case asserting the canvas-observable outcome, and prove red-on-parent/green-on-fix in the PR.
Conversation binds the follower to a doc seeded with a subgraph definition and instance; the edits under test are human canvas deletes (definition-free, so the mocked empty object_info cannot starve them). A root delete must mint (positive control); an interior delete must not, bounded by an ordering anchor (deleting the instance itself) and pinned by node id. Adds an additive outbound-frame capture (clientFrames/outboundOps) to the conversation fixture.
… frame (#16653) ## Summary Resolves an unresolved review question from [#16612](#16612 (comment)) that merged before the author answered it. `parseAwarenessState` folded a `state: null` value into the same branch as any other invalid, non-record shape (arrays, strings, numbers), rejecting the *entire* awareness frame including `actor` and `expires_at`. But the Go server's `State map[string]any` has `omitempty` and can never actually emit `null` on the wire — so this was defence-in-depth for a value the server cannot send, and it silently changed behavior from pre-#16612 `main` (where `parseRecord(null)` returned `null` and the field was dropped, but the frame was still accepted). This PR folds `null` into the same branch as `undefined` (no state present) instead of rejecting the frame. A genuinely malformed non-record shape (array, string, number) is still rejected. ## Why treat null as absent, not reject Awareness is ephemeral presence data (cursor/selection), not part of the shared CRDT doc. Dropping a best-effort state update should not also discard the actor's `expires_at`, which is the signal a consumer would use to clear stale presence for that actor. Rejecting the whole frame is strictly more destructive than necessary for a value that, per the server's own schema, means "no state." ## Evidence ``` $ pnpm exec vitest run src/workbench/extensions/agent/crdt/docFrameClient.awareness.test.ts Test Files 1 passed (1) Tests 10 passed (10) $ pnpm exec vitest run src/workbench/extensions/agent/crdt Test Files 19 passed (19) Tests 207 passed (207) $ pnpm typecheck $ vue-tsc --noEmit [exited with code 0] $ pnpm exec eslint src/workbench/extensions/agent/crdt/docFrameClient.ts src/workbench/extensions/agent/crdt/docFrameClient.awareness.test.ts (no output, 0 errors) ``` <!-- authored-by:agent lane-act-fe-16612-followup-05334ef0 -->
The conversation fixture reproduces the host's exact ordering (doc_subscribed(seq=N) then the catch-up doc_update(seq=N)); pre-fix the bridge dropped that catch-up as stale and a fresh follower rendered empty. The seeded graph projecting at all is the regression surface. The base carries an evolved form of the fix, so the red recipe is a recorded three-line patch restoring the pre-fix baseline write, noted in the spec header.
…porter The recorded-conversation exporter and its capture format landed upstream; the convention now points at them instead of allowing interim hand-assembly, matching the data README's no-hand-written-ops rule.
Select via the node header (selectNode helper) with keyboard Delete - body clicks select nothing; seed positions moved clear of the floating action bar, which intercepted the header click at [0,0]. The mint assertion itself still reds: no delete_node op is observed on the wire and no refusal is logged - under diagnosis whether the human delete-mint path is live in the replay environment at all.
The UI-path deletes the previous revision drove cannot see ECS-only replay seeds (litegraph-first selection), so the human edits now apply layout operations directly with the session's local user actor, exercising the 0a20384 scope contract exactly: root deletes mint, subgraph-interior creates and deletes never do. The conversation host now acknowledges doc_ops batches (versioned doc_ops_result) - the client's one-in-flight op sender stalls after the first mint without the ack, as the real host always sends one.
Eight conversations recorded against the local agent (six with graph operations applied through the doc host, one text-only answer, one tool error), exported with the conversation exporter unchanged, and replayed with a full graph snapshot and response-panel assertions each. The fixtures carry response_side "recorded" and a capture block (thread and message ids, parent row ids, raw capture hash) so any case can be re-exported from the same source.
The regression specs and fixtures were named after their fix PR numbers; they now carry the behavior they protect (catch-up baseline, subgraph mint scope) with the PR cited in the spec header and the fixture note. The README convention follows.
sendPrompt returned as soon as the browser's POST was captured, before the page had applied the acknowledgement from the mocked response. The replay frames are stamped with the fixture's thread id and the active-tab handler drops them until the session's thread id matches, so a slow response (seen under tracing) left the follower unsubscribed and the case timed out. The fixture now waits for the id the session persists right after applying it.
The two eval prompts (stitch the output beside the input; add a text node feeding the prompt and run) replayed from hand-written agent responses. They are now recorded on the local agent behind the tab switch the replay binds on and exported with the conversation exporter unchanged; the committed synthesized fixtures stay untouched. The second recording also added the sampler's missing negative encoder and empty latent, so its seed catalog carries EmptyLatentImage.
The two eval-suite cases now carry the conversation the local agent actually produced for their prompts (exported with the conversation exporter unchanged) under the same case ids, and their replays assert that recording. The hand-written PoC responses and their describes are gone; no fixture is labelled synthesized any more except the two constructed regression seeds, which say so.
…ecorded timing Every recorded conversation now runs through one replay that reads its expectations from the fixture: tool groups (split where thinking or text interrupts the calls), the update count, the added nodes, the widget values set, and the graph snapshot computed from the seed plus the ops. Re-recording a case no longer needs hand-pinned values. Recorded frames carry at_ms; the exporter emits each entry's offset from the turn's first frame and the fixture can replay those gaps (replayTiming, or AGENT_REPLAY_TIMING=recorded). Comments cut to one-line whys.
The twelve recorded conversation fixtures land in their own PR on top of this one so the replay code and the data review separately.
Recorded on the local agent stack (six graph-editing cases, a text-only answer, a tool error, and the two eval-suite prompts), exported with the conversation exporter unchanged, every frame carrying its recorded offset. The timing spec replays one of them at its recorded gaps.
…mentation The replay's expected graph now comes from readGraph on the host doc the pinned applier built, so link replacement and node deletion follow the real rules instead of a copy of them. Block comments in the carried harness cut to one-line whys.
…efined only when their recording exists
…esced row multiplier Drops the record widening over typed ops, asserts the xN badge per same-tool run, matches row labels exactly, and word-bounds the update count so 1 no longer matches 11.
The two throwaway scripts behind the recorded fixtures become one TypeScript command that drives both turns, applies the assembler gates and writes the fixture through the existing exporter. The gates are a pure function, so the colocated test covers each refusal without opening a socket or touching the filesystem, and the intermediate capture, rows and receipt land in a recordings/ directory beside the fixture rather than in conversations/, which the replay scans for cases.
assembleCapture was one long function that hand-checked the shape of every value it touched. Its three inputs, the seed fixture, the rows dump and the socket frame, now parse through zod once, so each gate that follows is a small named function over typed data and a shape mismatch refuses at the boundary that owns it. The receipt keeps provenance, paths, hashes, ids and counts, instead of copying rows that the capture and the rows file already hold. The replay coverage steps told the next author to capture against the standalone harness and its SQLite store, which has no doc host and so can never produce the audit rows a replay asserts. They now point at the recorder and the local stack.
The standalone agent never writes the per-op audit rows the exporter reads, so the capture step names the mode that does.
…el/be-11470-recording-tooling-ts # Conflicts: # browser_tests/README.md
A conversation is now a list of turns on one thread, each with its own message id, request and response entries. The exporter emits one turn per recorded message, the harness answers each prompt with that turn's ack and stamps its frames, and every expectation folds over all turns. The nine recordings are rewritten to the new shape.
The recorder took a single prompt and emitted a one-turn capture. It now takes --prompt once per turn, opens the thread on the first and posts the rest to it the way the panel does, buckets frames by the message id of the turn that owns them, reads one audit row set per turn, and emits the turns array agent-backend-capture.v2 expects. The gates that belong to a turn run per turn and name it; the draft check runs once at the end over every applied op of the thread, because only the final draft can witness them, and the active tab frame is required on the opening turn alone since the replay subscribes once. agent-rec-two-turn-dependent-edit is the first case whose second turn depends on its first: turn 1 adds a CLIPTextEncode fed from the checkpoint loader, turn 2 wires that same node into the sampler's negative input.
Readonly literals from as const rejected the per-test overrides under a typecheck that includes scripts/.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 1916 passed, 0 failed📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-03T16:34:10.593Z",
"gitSha": "a3db1fc2b11ad6636a18188b170cec99489ac2bc",
"branch": "nathaniel/be-11470-multi-turn-replay",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2076.6360000000077,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.570999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 513.5719999999999,
"heapDeltaBytes": -13181584,
"heapUsedBytes": 56701644,
"domNodes": -278,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 10.145000000000001,
"eventListeners": -180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2035.0170000001526,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.351,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 572.0930000000001,
"heapDeltaBytes": -13908380,
"heapUsedBytes": 56804324,
"domNodes": -281,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 11.343000000000002,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2126.4449999999897,
"styleRecalcs": 82,
"styleRecalcDurationMs": 49.57900000000001,
"layouts": 14,
"layoutDurationMs": 4.784,
"taskDurationMs": 1057.608,
"heapDeltaBytes": -5338768,
"heapUsedBytes": 65434552,
"domNodes": -276,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 167.223,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1869.5960000000014,
"styleRecalcs": 77,
"styleRecalcDurationMs": 38.053000000000004,
"layouts": 14,
"layoutDurationMs": 4.688,
"taskDurationMs": 888.1640000000001,
"heapDeltaBytes": -8786904,
"heapUsedBytes": 61621652,
"domNodes": -279,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 145.874,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1708.33099999993,
"styleRecalcs": 31,
"styleRecalcDurationMs": 16.320999999999998,
"layouts": 6,
"layoutDurationMs": 1.103,
"taskDurationMs": 373.21099999999996,
"heapDeltaBytes": 4705484,
"heapUsedBytes": 74574432,
"domNodes": 76,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 12.302000000000003,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1688.9109999999619,
"styleRecalcs": 30,
"styleRecalcDurationMs": 17.632,
"layouts": 6,
"layoutDurationMs": 1.228,
"taskDurationMs": 376.00100000000003,
"heapDeltaBytes": 5077292,
"heapUsedBytes": 75735996,
"domNodes": 78,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 12.213000000000001,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 654.9860000000081,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.353999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 447.70400000000006,
"heapDeltaBytes": -7887884,
"heapUsedBytes": 62827416,
"domNodes": 18,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 152.53699999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 659.1009999999642,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.506999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 443.417,
"heapDeltaBytes": -7809132,
"heapUsedBytes": 62618932,
"domNodes": 16,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 155.173,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2034.926999999925,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.310000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 616.443,
"heapDeltaBytes": -14075272,
"heapUsedBytes": 87652632,
"domNodes": -266,
"jsHeapTotalBytes": -851968,
"scriptDurationMs": 34.746,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2049.2369999999482,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.9419999999999975,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 612.9409999999999,
"heapDeltaBytes": -14716988,
"heapUsedBytes": 87046976,
"domNodes": -272,
"jsHeapTotalBytes": -65536,
"scriptDurationMs": 35.021,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2156.0699999999997,
"styleRecalcs": 64,
"styleRecalcDurationMs": 12.326999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1617.734,
"heapDeltaBytes": 20776580,
"heapUsedBytes": 87119460,
"domNodes": 4,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 777.069,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2158.995999999888,
"styleRecalcs": 65,
"styleRecalcDurationMs": 10.844,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1545.9150000000002,
"heapDeltaBytes": 18557680,
"heapUsedBytes": 84392244,
"domNodes": -272,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 754.3230000000001,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3445.2079999999796,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.967999999999995,
"layouts": 60,
"layoutDurationMs": 13.169,
"taskDurationMs": 1652.993,
"heapDeltaBytes": 8167496,
"heapUsedBytes": 75679044,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 740.283,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3585.2840000000015,
"styleRecalcs": 60,
"styleRecalcDurationMs": 11.013000000000002,
"layouts": 60,
"layoutDurationMs": 13.371,
"taskDurationMs": 1731.8729999999998,
"heapDeltaBytes": 11753184,
"heapUsedBytes": 79927252,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 788.877,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3039.6050000000514,
"styleRecalcs": 41,
"styleRecalcDurationMs": 6.2509999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1908.611,
"heapDeltaBytes": 21557744,
"heapUsedBytes": 89689972,
"domNodes": 2,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 954.0200000000001,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3129.206999999951,
"styleRecalcs": 41,
"styleRecalcDurationMs": 6.0440000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1936.0680000000002,
"heapDeltaBytes": 26335668,
"heapUsedBytes": 93940056,
"domNodes": 2,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 955.353,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2034.306000000015,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.7160000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 625.076,
"heapDeltaBytes": 21965960,
"heapUsedBytes": 87490840,
"domNodes": -271,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 39.23599999999999,
"eventListeners": -180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2012.6900000000205,
"styleRecalcs": 2,
"styleRecalcDurationMs": 1.7780000000000018,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 572.807,
"heapDeltaBytes": 22284536,
"heapUsedBytes": 88034052,
"domNodes": -275,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 33.946000000000005,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 594.1179999999804,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.122,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 419.121,
"heapDeltaBytes": 14891868,
"heapUsedBytes": 87859548,
"domNodes": 20,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 140.14499999999998,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 591.2390000000869,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.368,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 392.33699999999993,
"heapDeltaBytes": 15107092,
"heapUsedBytes": 87944064,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 138.41699999999997,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2014.1250000000355,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.954999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 496.63900000000007,
"heapDeltaBytes": -6836456,
"heapUsedBytes": 66021104,
"domNodes": -296,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 8.335000000000003,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2016.7109999999866,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.421999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 490.88899999999995,
"heapDeltaBytes": -11334892,
"heapUsedBytes": 61303440,
"domNodes": -296,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 8.259000000000002,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1756.9730000000163,
"styleRecalcs": 76,
"styleRecalcDurationMs": 37.431,
"layouts": 18,
"layoutDurationMs": 6.079,
"taskDurationMs": 830.5219999999999,
"heapDeltaBytes": -11647944,
"heapUsedBytes": 61153972,
"domNodes": -295,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 106.42999999999999,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1730.3430000001754,
"styleRecalcs": 78,
"styleRecalcDurationMs": 38.265,
"layouts": 18,
"layoutDurationMs": 5.553,
"taskDurationMs": 846.6579999999999,
"heapDeltaBytes": -14658912,
"heapUsedBytes": 58162880,
"domNodes": -295,
"jsHeapTotalBytes": 6807552,
"scriptDurationMs": 105.77399999999999,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1400.8589999998549,
"styleRecalcs": 19,
"styleRecalcDurationMs": 31.389,
"layouts": 15,
"layoutDurationMs": 14.956000000000001,
"taskDurationMs": 962.3819999999998,
"heapDeltaBytes": -7218576,
"heapUsedBytes": 84021760,
"domNodes": 13751,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 32.883,
"eventListeners": 2387,
"totalBlockingTimeMs": 127,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8532.96499999999,
"styleRecalcs": 246,
"styleRecalcDurationMs": 39.649,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5962.542,
"heapDeltaBytes": 25154372,
"heapUsedBytes": 90448720,
"domNodes": -269,
"jsHeapTotalBytes": 487424,
"scriptDurationMs": 2740.485,
"eventListeners": -134,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8420.560000000023,
"styleRecalcs": 248,
"styleRecalcDurationMs": 39.315000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5773.0109999999995,
"heapDeltaBytes": -16633708,
"heapUsedBytes": 85276772,
"domNodes": -265,
"jsHeapTotalBytes": -626688,
"scriptDurationMs": 2597.998,
"eventListeners": -134,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 18264.28199999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17644.687,
"heapDeltaBytes": -27555480,
"heapUsedBytes": 183036708,
"domNodes": -6548,
"jsHeapTotalBytes": -7032832,
"scriptDurationMs": 301.695,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 18078.07600000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17603.074999999997,
"heapDeltaBytes": -20899112,
"heapUsedBytes": 184219652,
"domNodes": -6548,
"jsHeapTotalBytes": -3887104,
"scriptDurationMs": 341.286,
"eventListeners": -7471,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.773333333333238,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 22631.806999999866,
"styleRecalcs": 169,
"styleRecalcDurationMs": 23.652000000000008,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22408.321,
"heapDeltaBytes": -14771740,
"heapUsedBytes": 190545972,
"domNodes": -6548,
"jsHeapTotalBytes": 2527232,
"scriptDurationMs": 956.364,
"eventListeners": -7467,
"totalBlockingTimeMs": 152,
"frameDurationMs": 17.773333333333238,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 22562.194999999974,
"styleRecalcs": 170,
"styleRecalcDurationMs": 21.612999999999992,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22311.254999999997,
"heapDeltaBytes": -25300264,
"heapUsedBytes": 188477872,
"domNodes": -6548,
"jsHeapTotalBytes": -8761344,
"scriptDurationMs": 988.7769999999999,
"eventListeners": -7469,
"totalBlockingTimeMs": 245,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6611.883000000034,
"styleRecalcs": 20,
"styleRecalcDurationMs": 76.225,
"layouts": 20,
"layoutDurationMs": 25.578000000000003,
"taskDurationMs": 6543.1900000000005,
"heapDeltaBytes": -33824904,
"heapUsedBytes": 180337652,
"domNodes": -6548,
"jsHeapTotalBytes": 8966144,
"scriptDurationMs": 124.80599999999998,
"eventListeners": -7469,
"totalBlockingTimeMs": 431,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6557.4880000001485,
"styleRecalcs": 20,
"styleRecalcDurationMs": 86.68999999999998,
"layouts": 20,
"layoutDurationMs": 31.14299999999999,
"taskDurationMs": 6510.151,
"heapDeltaBytes": -61326012,
"heapUsedBytes": 172307020,
"domNodes": -6548,
"jsHeapTotalBytes": -1519616,
"scriptDurationMs": 140.343,
"eventListeners": -7469,
"totalBlockingTimeMs": 484,
"frameDurationMs": 18.33666666666674,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9228.53299999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8838.54,
"heapDeltaBytes": -7862004,
"heapUsedBytes": 175808248,
"domNodes": 0,
"jsHeapTotalBytes": -17301504,
"scriptDurationMs": 194.12800000000007,
"eventListeners": -14,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9305.846999999858,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9141.813,
"heapDeltaBytes": 12468296,
"heapUsedBytes": 176094776,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 149.05200000000008,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 479.95799999989686,
"styleRecalcs": 17,
"styleRecalcDurationMs": 23.487000000000002,
"layouts": 4,
"layoutDurationMs": 2.039,
"taskDurationMs": 119.28899999999999,
"heapDeltaBytes": 5004272,
"heapUsedBytes": 73474040,
"domNodes": 145,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 11.925,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 113.19299999991017,
"styleRecalcs": 7,
"styleRecalcDurationMs": 16.323999999999998,
"layouts": 3,
"layoutDurationMs": 1.7029999999999998,
"taskDurationMs": 75.46199999999999,
"heapDeltaBytes": 3030188,
"heapUsedBytes": 71833516,
"domNodes": 108,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 5.430999999999998,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## nathaniel/be-11470-recording-tooling-ts #16786 +/- ##
===========================================================================
- Coverage 82.67% 82.67% -0.01%
===========================================================================
Files 2040 2040
Lines 118978 118979 +1
Branches 30279 30279
===========================================================================
- Hits 98371 98369 -2
- Misses 20427 20430 +3
Partials 180 180
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
3a42b75 to
262c641
Compare
Summary
A recorded conversation is now a thread of turns, replayed in order on the same graph.
agent-conversation.v2carriesturns[](per-turn message id, request, response entries); the exporter emits one turn per recorded message; the harness sends each prompt, answers it with that turn's ack, streams that turn's frames and folds every expectation over all turns; the recorder drives N prompts in one command. Proof: a two-turn recording where turn 2 connects the node turn 1 minted. Stacked on #16782. Linear: BE-11470 (contract 2).Changes
agentConversation.ts(turns[],source.capturewithoutmessage_id, recorded turns must carry theirs);exportTurnin the exporter withagent-backend-capture.v2input (turns[]); harnesssendPrompt(turn),replayResponse(turn, afterEntry),runTurns(), per-turn acks and frame stamping, expectations over all turns, exact recorded-gap waits; recorder--promptrepeatable (turn 1 posts tothreads/new/messages, later turns to the thread's messages endpoint, gates per turn,agent_active_tabrequired on the opening turn only, draft check once over the whole thread); the nine recordings rewritten to v2; one new recordingagent-rec-two-turn-dependent-edit.Review Focus
add_nodemints the node whose id turn 2'sconnectcarries into the sampler's negative input.scripts/is outsidetsconfig.json's include, sopnpm typecheckdoes not see the recorder or the exporter; a scoped tsconfig overscripts/agentConversation*.tsis clean on this head.