Repository navigation
test: remove transient top-up assertion - #16725
Conversation
🎭 Playwright: ✅ 1907 passed, 0 failed · 3 flaky📊 Browser Reports
📦 Bundle: 9.68 MB gzip ⚪ 0 BDetailsSummary
Category Glance App Entry Points — 3.74 kB (baseline 3.74 kB) • ⚪ 0 BMain entry bundles and manifests Status: 1 unchanged Graph Workspace — 1.42 MB (baseline 1.42 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration Status: 3 unchanged Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 17 unchanged Panels & Settings — 621 kB (baseline 621 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 27 unchanged User & Accounts — 27.8 kB (baseline 27.8 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 11 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 8 unchanged UI Components — 117 kB (baseline 117 kB) • ⚪ 0 BReusable component library chunks Status: 15 unchanged Data & Services — 3.59 MB (baseline 3.59 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 16 unchanged Utilities & Hooks — 560 kB (baseline 560 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 36 unchanged Vendor & Third-Party — 18.1 MB (baseline 18.1 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 16.4 MB (baseline 16.4 MB) • ⚪ 0 BBundles that do not match a named category Status: 295 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-03T00:31:32.359Z",
"gitSha": "c09ec749c25bcdf0d76e3e527ab28b2c3b0b7298",
"branch": "fix/cloud-topup-3ds-flake",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2038.5080000000357,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.676999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 476.827,
"heapDeltaBytes": -543812,
"heapUsedBytes": 69234896,
"domNodes": -280,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 7.218999999999999,
"eventListeners": -180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2056.6700000000537,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.521,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 504.8349999999999,
"heapDeltaBytes": -347808,
"heapUsedBytes": 69492828,
"domNodes": -278,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 9.608000000000002,
"eventListeners": -180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1983.760000000018,
"styleRecalcs": 80,
"styleRecalcDurationMs": 42.937999999999995,
"layouts": 14,
"layoutDurationMs": 4.333,
"taskDurationMs": 961.6510000000001,
"heapDeltaBytes": -8181668,
"heapUsedBytes": 61529800,
"domNodes": -280,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 171.552,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1848.57199999999,
"styleRecalcs": 76,
"styleRecalcDurationMs": 35.292,
"layouts": 14,
"layoutDurationMs": 4.138,
"taskDurationMs": 895.764,
"heapDeltaBytes": 5692812,
"heapUsedBytes": 75809568,
"domNodes": -278,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 158.655,
"eventListeners": -180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1707.4179999999615,
"styleRecalcs": 30,
"styleRecalcDurationMs": 15.728,
"layouts": 6,
"layoutDurationMs": 0.9250000000000003,
"taskDurationMs": 347.39200000000005,
"heapDeltaBytes": 4726312,
"heapUsedBytes": 74481260,
"domNodes": 76,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 9.989,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1723.6660000000938,
"styleRecalcs": 31,
"styleRecalcDurationMs": 17.482999999999997,
"layouts": 6,
"layoutDurationMs": 1.128,
"taskDurationMs": 374.86600000000004,
"heapDeltaBytes": 4817316,
"heapUsedBytes": 75425332,
"domNodes": 76,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 11.162999999999998,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 613.4480000000053,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.970000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 444.32899999999995,
"heapDeltaBytes": -7786748,
"heapUsedBytes": 62657268,
"domNodes": 16,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 165.088,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 650.8729999999332,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.985999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 447.8139999999999,
"heapDeltaBytes": 18192060,
"heapUsedBytes": 88353672,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 157.352,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2027.744000000041,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.584999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 569.0799999999999,
"heapDeltaBytes": -13753264,
"heapUsedBytes": 87368644,
"domNodes": -268,
"jsHeapTotalBytes": -1372160,
"scriptDurationMs": 31.431000000000008,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2006.0009999999693,
"styleRecalcs": 3,
"styleRecalcDurationMs": 2.717000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 641.488,
"heapDeltaBytes": 22291868,
"heapUsedBytes": 87513092,
"domNodes": -272,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 40.24700000000001,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2220.404999999971,
"styleRecalcs": 64,
"styleRecalcDurationMs": 9.135000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1584.869,
"heapDeltaBytes": 22884000,
"heapUsedBytes": 89084416,
"domNodes": 4,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 801.562,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2412.3879999999644,
"styleRecalcs": 62,
"styleRecalcDurationMs": 7.942000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1691.4669999999999,
"heapDeltaBytes": 25725564,
"heapUsedBytes": 91562280,
"domNodes": -279,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 824.229,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3447.638999999981,
"styleRecalcs": 60,
"styleRecalcDurationMs": 9.130000000000003,
"layouts": 60,
"layoutDurationMs": 11.229000000000003,
"taskDurationMs": 1597.6380000000004,
"heapDeltaBytes": 11432024,
"heapUsedBytes": 79384780,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 724.582,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3550.3210000000536,
"styleRecalcs": 60,
"styleRecalcDurationMs": 9.344999999999999,
"layouts": 60,
"layoutDurationMs": 11.416,
"taskDurationMs": 1658.4460000000001,
"heapDeltaBytes": 11733732,
"heapUsedBytes": 79686960,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 757.374,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2933.3460000000287,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.650999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1846.1509999999998,
"heapDeltaBytes": 22875624,
"heapUsedBytes": 89808716,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 925.54,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "legacy-node-drag",
"durationMs": 3014.2759999999953,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.712999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1911.645,
"heapDeltaBytes": 18208104,
"heapUsedBytes": 85127568,
"domNodes": 0,
"jsHeapTotalBytes": 2252800,
"scriptDurationMs": 925.6750000000002,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2010.575000000017,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.980999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 553.056,
"heapDeltaBytes": 21895188,
"heapUsedBytes": 87268436,
"domNodes": -270,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 32.87899999999999,
"eventListeners": -180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 1995.7980000000362,
"styleRecalcs": 2,
"styleRecalcDurationMs": 1.972999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 552.987,
"heapDeltaBytes": 21449852,
"heapUsedBytes": 87009752,
"domNodes": -276,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 34.07599999999999,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 590.3840000000287,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.346000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 396.63599999999997,
"heapDeltaBytes": 14865408,
"heapUsedBytes": 87602612,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 135.817,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 572.5419999999986,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.739,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 397.77799999999996,
"heapDeltaBytes": 14416508,
"heapUsedBytes": 86424344,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 136.744,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2023.1069999999818,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.364,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 474.143,
"heapDeltaBytes": -14747700,
"heapUsedBytes": 57530208,
"domNodes": -295,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 6.569999999999999,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2022.4019999999427,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.086999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 561.294,
"heapDeltaBytes": -14528912,
"heapUsedBytes": 57658544,
"domNodes": -296,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 10.807,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1717.679999999973,
"styleRecalcs": 77,
"styleRecalcDurationMs": 33.848000000000006,
"layouts": 18,
"layoutDurationMs": 4.353,
"taskDurationMs": 771.591,
"heapDeltaBytes": -12073072,
"heapUsedBytes": 60788500,
"domNodes": -295,
"jsHeapTotalBytes": 7069696,
"scriptDurationMs": 101.949,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1802.096000000006,
"styleRecalcs": 78,
"styleRecalcDurationMs": 41.812000000000005,
"layouts": 18,
"layoutDurationMs": 6.449000000000001,
"taskDurationMs": 926.258,
"heapDeltaBytes": 261504,
"heapUsedBytes": 71892896,
"domNodes": -294,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 116.75599999999999,
"eventListeners": -226,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1401.112000000012,
"styleRecalcs": 20,
"styleRecalcDurationMs": 34.03800000000001,
"layouts": 16,
"layoutDurationMs": 16.747999999999998,
"taskDurationMs": 1017.0979999999998,
"heapDeltaBytes": 19967232,
"heapUsedBytes": 104434880,
"domNodes": 13751,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 34.575,
"eventListeners": 2383,
"totalBlockingTimeMs": 147,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8316.997000000014,
"styleRecalcs": 248,
"styleRecalcDurationMs": 34.245,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5555.686000000001,
"heapDeltaBytes": -11598900,
"heapUsedBytes": 89066032,
"domNodes": -267,
"jsHeapTotalBytes": -884736,
"scriptDurationMs": 2556.379,
"eventListeners": -134,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8694.75,
"styleRecalcs": 248,
"styleRecalcDurationMs": 34.805,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5757.3550000000005,
"heapDeltaBytes": -11642508,
"heapUsedBytes": 89323612,
"domNodes": -268,
"jsHeapTotalBytes": -655360,
"scriptDurationMs": 2610.1420000000003,
"eventListeners": -132,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16807.098999999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16261.919999999996,
"heapDeltaBytes": -22384332,
"heapUsedBytes": 179101136,
"domNodes": -6548,
"jsHeapTotalBytes": 9949184,
"scriptDurationMs": 271.17100000000005,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17134.25700000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16681.657000000003,
"heapDeltaBytes": -34456388,
"heapUsedBytes": 175777428,
"domNodes": -6548,
"jsHeapTotalBytes": -6070272,
"scriptDurationMs": 322.922,
"eventListeners": -7471,
"totalBlockingTimeMs": 1,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20415.023999999903,
"styleRecalcs": 171,
"styleRecalcDurationMs": 17.259000000000025,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19997.346999999998,
"heapDeltaBytes": -27950112,
"heapUsedBytes": 176477268,
"domNodes": -6548,
"jsHeapTotalBytes": 1814528,
"scriptDurationMs": 895.198,
"eventListeners": -7469,
"totalBlockingTimeMs": 85,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20920.048000000064,
"styleRecalcs": 170,
"styleRecalcDurationMs": 18.23600000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20519.142000000003,
"heapDeltaBytes": -39515872,
"heapUsedBytes": 162575060,
"domNodes": -6548,
"jsHeapTotalBytes": 2871296,
"scriptDurationMs": 901.758,
"eventListeners": -7467,
"totalBlockingTimeMs": 86,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6105.6599999999435,
"styleRecalcs": 20,
"styleRecalcDurationMs": 81.204,
"layouts": 20,
"layoutDurationMs": 23.419999999999995,
"taskDurationMs": 5990.402,
"heapDeltaBytes": -27277832,
"heapUsedBytes": 183043044,
"domNodes": -6548,
"jsHeapTotalBytes": 3035136,
"scriptDurationMs": 115.77699999999999,
"eventListeners": -7469,
"totalBlockingTimeMs": 345,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6151.798999999983,
"styleRecalcs": 20,
"styleRecalcDurationMs": 79.13399999999999,
"layouts": 20,
"layoutDurationMs": 21.629999999999995,
"taskDurationMs": 6009.9980000000005,
"heapDeltaBytes": -25695652,
"heapUsedBytes": 179289212,
"domNodes": -6548,
"jsHeapTotalBytes": 14135296,
"scriptDurationMs": 108.077,
"eventListeners": -7469,
"totalBlockingTimeMs": 421,
"frameDurationMs": 17.779999999999987,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8535.859000000073,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8348.328,
"heapDeltaBytes": 15378804,
"heapUsedBytes": 175500544,
"domNodes": 0,
"jsHeapTotalBytes": -786432,
"scriptDurationMs": 131.857,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8730.293999999958,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8499.702,
"heapDeltaBytes": -422816,
"heapUsedBytes": 174294480,
"domNodes": 0,
"jsHeapTotalBytes": -11010048,
"scriptDurationMs": 167.25400000000002,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 500.12299999991683,
"styleRecalcs": 19,
"styleRecalcDurationMs": 22.856,
"layouts": 4,
"layoutDurationMs": 1.849,
"taskDurationMs": 122.581,
"heapDeltaBytes": 5103088,
"heapUsedBytes": 73556244,
"domNodes": 147,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 13.706999999999999,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "workflow-execution",
"durationMs": 87.0190000000548,
"styleRecalcs": 6,
"styleRecalcDurationMs": 10.719000000000001,
"layouts": 1,
"layoutDurationMs": 0.7329999999999999,
"taskDurationMs": 62.363,
"heapDeltaBytes": 3048108,
"heapUsedBytes": 71525068,
"domNodes": 124,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.274,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
} |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 1 remains after this review. 📝 WalkthroughWalkthroughThe 3DS top-up browser test removes the assertion that the confirmation dialog’s Back button becomes disabled after payment submission. Polling and verification-link checks remain. ChangesCredits top-up test
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This localized test-only change removes a flaky intermediate-state assertion while preserving the test’s substantive payment verification checks; no actionable merge-blocking risk remains after normal checks and review. 🚥 Pre-merge checks | ✅ 7✅ Passed checks (7 passed)
Full details: Description checkExplanation The description explains the flaky assertion removal, identifies the affected 3DS top-up test behavior, records the review focus, and reports validation results. The optional Screenshots section is not needed for this test-only change. Full details: End-To-End Regression Coverage For FixesExplanation The PR changes only Full details: Adr Compliance For Entity/Litegraph ChangesExplanation The changed-file list contains only ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #16725 +/- ##
==========================================
+ Coverage 80.89% 82.47% +1.58%
==========================================
Files 2450 2032 -418
Lines 125020 117547 -7473
Branches 31558 31544 -14
==========================================
- Hits 101133 96948 -4185
+ Misses 23374 20421 -2953
+ Partials 513 178 -335
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Backport of #16725 to `cloud/1.53` Automatically created by backport workflow. Co-authored-by: Alexander Brown <drjkl@comfy.org> Co-authored-by: Amp <amp@ampcode.com>
Backport of #16725 to `core/1.53` Automatically created by backport workflow. Co-authored-by: Alexander Brown <drjkl@comfy.org> Co-authored-by: Amp <amp@ampcode.com>
|
|
|
… which PR_GH_TOKEN lacks (Comfy-Org#17011) ## Summary Every `gh pr edit` call in `PR Backport` runs under `PR_GH_TOKEN`, which carries `repo`/`workflow` but not `read:org`. `gh pr edit` resolves `author`, `assignees`, `labels` and team `slug`/`name` over GraphQL, and GitHub requires `read:org` for those fields, so the calls fail unconditionally. This swaps them for the equivalent REST endpoints, which need only `repo`. ## Changes - **`.github/workflows/pr-backport.yaml`** — replaces `gh pr edit --add-assignee` with `POST repos/{repo}/issues/{n}/assignees`, and `gh pr edit --remove-label` with a `GET` of the issue labels followed by `DELETE repos/{repo}/issues/{n}/labels/needs-backport`. - The label step now runs under `set -euo pipefail` and reads the label list into a variable before matching it, rather than piping `gh api` straight into `grep` — under a pipe a failed read is indistinguishable from a PR that simply does not carry the label, and would exit 0. It exits early when the label is already absent, so the step is idempotent. - **`scripts/cicd/backport-token-scopes.test.ts`** (new) — parses the workflow and asserts no step running under `PR_GH_TOKEN` uses an org-scoped `gh pr edit` flag (`--add-assignee`, `--remove-assignee`, `--add-label`, `--remove-label`), so the scope requirement cannot creep back in. ## Impact The two call sites failed differently, which is why only one of them was visible: - `--add-assignee` was guarded by `|| echo "::warning::..."`, so backport PRs silently went unassigned for as long as the token lacked the scope. - `--remove-label` was unguarded, so it failed the whole job *after* the backport PRs had already been created, and left `needs-backport` on the source PR — which re-arms the workflow's own `labeled` trigger. ## Review Focus Whether the early-exit branch in the label step is the behavior we want when `needs-backport` is already absent (it exits 0 rather than attempting the `DELETE` and tolerating a 404). ## Evidence Failing run [33894812018](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/33894812018) (job `101095073415`, step `Remove needs-backport label`), on source PR [Comfy-Org#16725](Comfy-Org#16725): ``` Run gh pr edit 16725 --remove-label "needs-backport" GraphQL: Your token has not been granted the required scopes to execute this query. The 'login' field requires one of the following scopes: ['read:org'], but your token has only been granted the: ['codespace', 'delete:packages', 'delete_repo', 'project', 'repo', 'user', 'workflow', 'write:packages'] scopes. ##[error]Process completed with exit code 1. ``` The same run shows the guarded `--add-assignee` calls emitting the identical GraphQL scope error earlier in the job without failing it. Reproduced on run [33892334363](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/33892334363), same failing step.
Summary
Remove a transient assertion that made the cloud 3DS top-up test flaky after the dialog had already advanced to verification.
Changes
Review Focus
The failing assertion appeared in 5 of 11 previous cloud runs. In each failure artifact, the dialog had already reached "Verify your payment," so the missing Back button was the expected next state.
Tested with 10 consecutive targeted cloud-project passes. ESLint, formatting, browser type checking, and project type checking pass.