Repository navigation
[backport cloud/1.53] test: remove transient top-up assertion - #17004
Conversation
## Summary Remove a transient assertion that made the cloud 3DS top-up test flaky after the dialog had already advanced to verification. ## Changes - **What**: Stop expecting the confirmation step's Back button after payment polling starts. The test still verifies the poll request, verification UI, and popup parameters. ## Review Focus The failing assertion appeared in 5 of 11 previous cloud runs. In each failure artifact, the dialog had already reached "Verify your payment," so the missing Back button was the expected next state. Tested with 10 consecutive targeted cloud-project passes. ESLint, formatting, browser type checking, and project type checking pass. Co-authored-by: Amp <amp@ampcode.com>
🎭 Playwright: ✅ 1890 passed, 0 failed · 2 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-04T16:38:26.178Z",
"gitSha": "8cab80e97ee37cd2d1b6af8348af1266a6672cb8",
"branch": "backport-16725-to-cloud-1.53",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2072.7899999999977,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.219000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 558.6940000000001,
"heapDeltaBytes": 4146828,
"heapUsedBytes": 73910624,
"domNodes": -278,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 8.543999999999999,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2038.9010000000098,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.897999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 496.614,
"heapDeltaBytes": -11787460,
"heapUsedBytes": 57589840,
"domNodes": -278,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 9.378,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1817.6479999999628,
"styleRecalcs": 76,
"styleRecalcDurationMs": 35.132,
"layouts": 14,
"layoutDurationMs": 4.4510000000000005,
"taskDurationMs": 861.4399999999999,
"heapDeltaBytes": 2647816,
"heapUsedBytes": 73367904,
"domNodes": -276,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 139.2,
"eventListeners": -187,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1832.1500000000697,
"styleRecalcs": 76,
"styleRecalcDurationMs": 36.596999999999994,
"layouts": 14,
"layoutDurationMs": 4.534,
"taskDurationMs": 891.138,
"heapDeltaBytes": -7502840,
"heapUsedBytes": 62978356,
"domNodes": -281,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 147.48600000000002,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1740.528999999981,
"styleRecalcs": 31,
"styleRecalcDurationMs": 17.019,
"layouts": 6,
"layoutDurationMs": 1.1699999999999997,
"taskDurationMs": 350.071,
"heapDeltaBytes": 4401916,
"heapUsedBytes": 74870868,
"domNodes": 77,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 10.472000000000001,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1730.7670000000144,
"styleRecalcs": 30,
"styleRecalcDurationMs": 16.869,
"layouts": 6,
"layoutDurationMs": 1.2619999999999998,
"taskDurationMs": 353.93,
"heapDeltaBytes": 4741592,
"heapUsedBytes": 74825016,
"domNodes": 76,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 11.33,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 715.3940000000034,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.715999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 463.54200000000003,
"heapDeltaBytes": 17854428,
"heapUsedBytes": 87989892,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 160.578,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 694.8580000000675,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.401,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 448.007,
"heapDeltaBytes": 17824280,
"heapUsedBytes": 88054196,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 151.81699999999998,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2013.1679999999506,
"styleRecalcs": 3,
"styleRecalcDurationMs": 3.4929999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 557.521,
"heapDeltaBytes": 22105328,
"heapUsedBytes": 87153404,
"domNodes": -272,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 31.985000000000007,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2011.8519999999762,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.396000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 575.1120000000001,
"heapDeltaBytes": 22260632,
"heapUsedBytes": 87190972,
"domNodes": -270,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 32.61600000000001,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2220.3290000000493,
"styleRecalcs": 66,
"styleRecalcDurationMs": 11.352,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1587.4350000000002,
"heapDeltaBytes": -16627036,
"heapUsedBytes": 84786964,
"domNodes": -271,
"jsHeapTotalBytes": -868352,
"scriptDurationMs": 769.181,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2173.082000000022,
"styleRecalcs": 65,
"styleRecalcDurationMs": 11.106000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1560.29,
"heapDeltaBytes": 19069236,
"heapUsedBytes": 84382988,
"domNodes": -274,
"jsHeapTotalBytes": 1536000,
"scriptDurationMs": 755.55,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3501.1539999999854,
"styleRecalcs": 61,
"styleRecalcDurationMs": 11.272000000000004,
"layouts": 60,
"layoutDurationMs": 12.981000000000002,
"taskDurationMs": 1671.214,
"heapDeltaBytes": 8570920,
"heapUsedBytes": 75832288,
"domNodes": -278,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 745.7360000000001,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3492.3649999999498,
"styleRecalcs": 62,
"styleRecalcDurationMs": 11.648000000000001,
"layouts": 60,
"layoutDurationMs": 12.841,
"taskDurationMs": 1638.312,
"heapDeltaBytes": 8030392,
"heapUsedBytes": 74998408,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 744.6129999999999,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3147.9760000000283,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.471,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1947.0280000000002,
"heapDeltaBytes": 25723896,
"heapUsedBytes": 93382000,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 976.899,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666636,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3097.761999999989,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.299999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1900.0629999999999,
"heapDeltaBytes": 18253716,
"heapUsedBytes": 85374348,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 943.9499999999998,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2013.4199999999964,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 532.2940000000001,
"heapDeltaBytes": 21986468,
"heapUsedBytes": 88729824,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 29.043,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2004.9980000000005,
"styleRecalcs": 3,
"styleRecalcDurationMs": 2.3779999999999983,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 546.4590000000001,
"heapDeltaBytes": 21818948,
"heapUsedBytes": 87032724,
"domNodes": -277,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 31.124000000000006,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 644.5889999999963,
"styleRecalcs": 48,
"styleRecalcDurationMs": 13.119999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 413.805,
"heapDeltaBytes": 14805440,
"heapUsedBytes": 87047736,
"domNodes": 22,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 145.279,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 630.1929999999629,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.632000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 418.786,
"heapDeltaBytes": 15154564,
"heapUsedBytes": 87722808,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 143.073,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2006.6919999999868,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.330999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 484.24999999999994,
"heapDeltaBytes": 3177660,
"heapUsedBytes": 75577372,
"domNodes": -297,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 7.698,
"eventListeners": -231,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2007.2229999999536,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.801000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 500.988,
"heapDeltaBytes": -9049072,
"heapUsedBytes": 63255132,
"domNodes": -296,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 8.299999999999999,
"eventListeners": -199,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1690.7439999999951,
"styleRecalcs": 78,
"styleRecalcDurationMs": 35.107,
"layouts": 18,
"layoutDurationMs": 4.9350000000000005,
"taskDurationMs": 784.1709999999999,
"heapDeltaBytes": -10226016,
"heapUsedBytes": 62116284,
"domNodes": -294,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 96.517,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1709.090999999944,
"styleRecalcs": 78,
"styleRecalcDurationMs": 39.157,
"layouts": 18,
"layoutDurationMs": 6.079000000000001,
"taskDurationMs": 846.3859999999999,
"heapDeltaBytes": -11286332,
"heapUsedBytes": 61254612,
"domNodes": -295,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 107.24000000000001,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1368.0800000000772,
"styleRecalcs": 18,
"styleRecalcDurationMs": 30.310999999999996,
"layouts": 14,
"layoutDurationMs": 14.398000000000001,
"taskDurationMs": 906.171,
"heapDeltaBytes": -5369380,
"heapUsedBytes": 87129104,
"domNodes": 13751,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 30.074999999999992,
"eventListeners": 2381,
"totalBlockingTimeMs": 123,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8519.894000000022,
"styleRecalcs": 247,
"styleRecalcDurationMs": 40.928999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5863.657,
"heapDeltaBytes": 10745924,
"heapUsedBytes": 86651988,
"domNodes": -273,
"jsHeapTotalBytes": -905216,
"scriptDurationMs": 2718.647,
"eventListeners": -169,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8302.17899999991,
"styleRecalcs": 249,
"styleRecalcDurationMs": 38.344,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5595.215999999999,
"heapDeltaBytes": -19747180,
"heapUsedBytes": 80720236,
"domNodes": -265,
"jsHeapTotalBytes": -1916928,
"scriptDurationMs": 2517.257,
"eventListeners": -139,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999952,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17822.686000000034,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17200.021,
"heapDeltaBytes": -36069516,
"heapUsedBytes": 177378628,
"domNodes": -6548,
"jsHeapTotalBytes": -5787648,
"scriptDurationMs": 283.66400000000004,
"eventListeners": -7471,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17501.786999999924,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16864.277000000002,
"heapDeltaBytes": -37533308,
"heapUsedBytes": 175863284,
"domNodes": -6548,
"jsHeapTotalBytes": -7622656,
"scriptDurationMs": 295.99199999999996,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 22422.46700000004,
"styleRecalcs": 175,
"styleRecalcDurationMs": 21.94800000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22045.782,
"heapDeltaBytes": -42423656,
"heapUsedBytes": 167442576,
"domNodes": -6548,
"jsHeapTotalBytes": -4059136,
"scriptDurationMs": 974.4460000000001,
"eventListeners": -7467,
"totalBlockingTimeMs": 142,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21553.86699999997,
"styleRecalcs": 166,
"styleRecalcDurationMs": 20.26300000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21254.522,
"heapDeltaBytes": -25547720,
"heapUsedBytes": 176031080,
"domNodes": -6548,
"jsHeapTotalBytes": 2871296,
"scriptDurationMs": 912.006,
"eventListeners": -7471,
"totalBlockingTimeMs": 88,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6312.584000000015,
"styleRecalcs": 20,
"styleRecalcDurationMs": 72.35999999999999,
"layouts": 20,
"layoutDurationMs": 24.371000000000002,
"taskDurationMs": 6213.616999999999,
"heapDeltaBytes": -29103728,
"heapUsedBytes": 181204848,
"domNodes": -6548,
"jsHeapTotalBytes": 11931648,
"scriptDurationMs": 117.37599999999999,
"eventListeners": -7471,
"totalBlockingTimeMs": 379,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 6356.794000000036,
"styleRecalcs": 20,
"styleRecalcDurationMs": 77.291,
"layouts": 20,
"layoutDurationMs": 30.293,
"taskDurationMs": 6291.2559999999985,
"heapDeltaBytes": -13603300,
"heapUsedBytes": 189573720,
"domNodes": -6548,
"jsHeapTotalBytes": 9433088,
"scriptDurationMs": 110.416,
"eventListeners": -7469,
"totalBlockingTimeMs": 452,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 450.81900000002406,
"styleRecalcs": 14,
"styleRecalcDurationMs": 19.484,
"layouts": 3,
"layoutDurationMs": 0.944,
"taskDurationMs": 102.346,
"heapDeltaBytes": 5079412,
"heapUsedBytes": 73619364,
"domNodes": 126,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 9.293999999999999,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 99.90000000004784,
"styleRecalcs": 7,
"styleRecalcDurationMs": 10.663000000000002,
"layouts": 1,
"layoutDurationMs": 0.46900000000000003,
"taskDurationMs": 63.652999999999984,
"heapDeltaBytes": 3155784,
"heapUsedBytes": 70916412,
"domNodes": 108,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 4.937,
"eventListeners": 49,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.53 #17004 +/- ##
=============================================
Coverage ? 83.36%
=============================================
Files ? 2023
Lines ? 117183
Branches ? 32506
=============================================
Hits ? 97684
Misses ? 19141
Partials ? 358
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Backport of #16725 to
cloud/1.53Automatically created by backport workflow.