Repository navigation
[backport core/1.53] test: remove transient top-up assertion - #17003
Conversation
## Summary Remove a transient assertion that made the cloud 3DS top-up test flaky after the dialog had already advanced to verification. ## Changes - **What**: Stop expecting the confirmation step's Back button after payment polling starts. The test still verifies the poll request, verification UI, and popup parameters. ## Review Focus The failing assertion appeared in 5 of 11 previous cloud runs. In each failure artifact, the dialog had already reached "Verify your payment," so the missing Back button was the expected next state. Tested with 10 consecutive targeted cloud-project passes. ESLint, formatting, browser type checking, and project type checking pass. Co-authored-by: Amp <amp@ampcode.com>
🎭 Playwright: ✅ 1891 passed, 0 failed · 1 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-04T16:38:15.853Z",
"gitSha": "ef9ef09e11b61c23a02513dc3d81beafbe93c5af",
"branch": "backport-16725-to-core-1.53",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2037.0779999999797,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.006999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 580.482,
"heapDeltaBytes": 13522888,
"heapUsedBytes": 83230040,
"domNodes": -279,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 7.611,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2035.032000000001,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.91,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 530.169,
"heapDeltaBytes": -5282696,
"heapUsedBytes": 63325332,
"domNodes": -280,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 10.268000000000002,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1801.6830000000255,
"styleRecalcs": 74,
"styleRecalcDurationMs": 34.83,
"layouts": 14,
"layoutDurationMs": 4.373,
"taskDurationMs": 862.8500000000001,
"heapDeltaBytes": -8541204,
"heapUsedBytes": 61711316,
"domNodes": -281,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 158.67399999999998,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1906.855999999948,
"styleRecalcs": 78,
"styleRecalcDurationMs": 42.172999999999995,
"layouts": 14,
"layoutDurationMs": 4.257000000000001,
"taskDurationMs": 924.6859999999999,
"heapDeltaBytes": 4481348,
"heapUsedBytes": 74197688,
"domNodes": -280,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 165.365,
"eventListeners": -187,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1718.691999999976,
"styleRecalcs": 31,
"styleRecalcDurationMs": 17.016000000000002,
"layouts": 6,
"layoutDurationMs": 1.239,
"taskDurationMs": 346.086,
"heapDeltaBytes": 4442732,
"heapUsedBytes": 74888888,
"domNodes": 78,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 10.374,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1666.9059999999263,
"styleRecalcs": 32,
"styleRecalcDurationMs": 17.23,
"layouts": 6,
"layoutDurationMs": 1.0690000000000002,
"taskDurationMs": 383.177,
"heapDeltaBytes": 4636048,
"heapUsedBytes": 75232220,
"domNodes": 76,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 11.963999999999999,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 634.5190000000116,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.026,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 448.74899999999997,
"heapDeltaBytes": 18115416,
"heapUsedBytes": 87915632,
"domNodes": 20,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 162.216,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 637.1900000000323,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.8320000000000025,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 448.33299999999997,
"heapDeltaBytes": -7764456,
"heapUsedBytes": 62855900,
"domNodes": 18,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 159.62199999999999,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2040.2109999999993,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.445000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 586.719,
"heapDeltaBytes": -14055012,
"heapUsedBytes": 86636792,
"domNodes": -269,
"jsHeapTotalBytes": -831488,
"scriptDurationMs": 37.12500000000001,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2053.0169999999544,
"styleRecalcs": 6,
"styleRecalcDurationMs": 6.06,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 653.1690000000001,
"heapDeltaBytes": -13608916,
"heapUsedBytes": 87166524,
"domNodes": -267,
"jsHeapTotalBytes": -1355776,
"scriptDurationMs": 35.727999999999994,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2183.8189999999713,
"styleRecalcs": 65,
"styleRecalcDurationMs": 9.811,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1593.9889999999996,
"heapDeltaBytes": 12762600,
"heapUsedBytes": 88818384,
"domNodes": -276,
"jsHeapTotalBytes": -643072,
"scriptDurationMs": 795.037,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2736.8529999999964,
"styleRecalcs": 63,
"styleRecalcDurationMs": 9.338,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1797.622,
"heapDeltaBytes": 19851788,
"heapUsedBytes": 85246756,
"domNodes": -279,
"jsHeapTotalBytes": 2060288,
"scriptDurationMs": 879.756,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3460.423999999989,
"styleRecalcs": 60,
"styleRecalcDurationMs": 9.372000000000002,
"layouts": 60,
"layoutDurationMs": 11.620000000000001,
"taskDurationMs": 1658.2559999999999,
"heapDeltaBytes": 7725060,
"heapUsedBytes": 74883312,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 762.8040000000001,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3666.3790000000063,
"styleRecalcs": 61,
"styleRecalcDurationMs": 11.207000000000003,
"layouts": 60,
"layoutDurationMs": 12.085,
"taskDurationMs": 1789.6899999999998,
"heapDeltaBytes": 9541792,
"heapUsedBytes": 75903996,
"domNodes": -279,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 787.3330000000001,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3010.0720000000365,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.981999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1880.9059999999997,
"heapDeltaBytes": 21226756,
"heapUsedBytes": 88541740,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 961.068,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666636,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "legacy-node-drag",
"durationMs": 3175.6639999999834,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.349999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2076.443,
"heapDeltaBytes": 21115732,
"heapUsedBytes": 88298744,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 1025.15,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2059.8940000000425,
"styleRecalcs": 5,
"styleRecalcDurationMs": 3.8960000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 571.3869999999998,
"heapDeltaBytes": -15146188,
"heapUsedBytes": 87267640,
"domNodes": -270,
"jsHeapTotalBytes": -1355776,
"scriptDurationMs": 35.556999999999995,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2041.5980000000218,
"styleRecalcs": 3,
"styleRecalcDurationMs": 3.197000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 646.616,
"heapDeltaBytes": -14801204,
"heapUsedBytes": 87734220,
"domNodes": -272,
"jsHeapTotalBytes": -1093632,
"scriptDurationMs": 38.336000000000006,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 600.825000000043,
"styleRecalcs": 48,
"styleRecalcDurationMs": 11.940999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 404.213,
"heapDeltaBytes": 14874528,
"heapUsedBytes": 87147108,
"domNodes": 22,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 139.56799999999998,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 606.8360000000439,
"styleRecalcs": 46,
"styleRecalcDurationMs": 11.350999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 423.9120000000001,
"heapDeltaBytes": 14843784,
"heapUsedBytes": 87471880,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 148.481,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2021.6350000000034,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.888,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 474.927,
"heapDeltaBytes": -10049864,
"heapUsedBytes": 62633180,
"domNodes": -296,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 7.183999999999999,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2022.9610000000093,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.835999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 556.054,
"heapDeltaBytes": 143736,
"heapUsedBytes": 71801552,
"domNodes": -297,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 10.692,
"eventListeners": -231,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1705.9849999999983,
"styleRecalcs": 77,
"styleRecalcDurationMs": 34.742,
"layouts": 18,
"layoutDurationMs": 4.944999999999999,
"taskDurationMs": 784.1450000000001,
"heapDeltaBytes": -12504492,
"heapUsedBytes": 59858320,
"domNodes": -295,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 104.53000000000002,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1716.1820000000034,
"styleRecalcs": 77,
"styleRecalcDurationMs": 38.108000000000004,
"layouts": 18,
"layoutDurationMs": 5.043000000000001,
"taskDurationMs": 877.1139999999999,
"heapDeltaBytes": -11062344,
"heapUsedBytes": 61513144,
"domNodes": -297,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 116.29499999999999,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1383.2069999999703,
"styleRecalcs": 18,
"styleRecalcDurationMs": 32.84799999999999,
"layouts": 14,
"layoutDurationMs": 15.666999999999996,
"taskDurationMs": 949.8469999999999,
"heapDeltaBytes": -7135468,
"heapUsedBytes": 82534312,
"domNodes": 13751,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 32.125,
"eventListeners": 2383,
"totalBlockingTimeMs": 138,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8411.493000000008,
"styleRecalcs": 247,
"styleRecalcDurationMs": 33.113,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5696.023999999999,
"heapDeltaBytes": -15962340,
"heapUsedBytes": 84483560,
"domNodes": -269,
"jsHeapTotalBytes": -1392640,
"scriptDurationMs": 2662.1459999999997,
"eventListeners": -139,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 9407.838999999967,
"styleRecalcs": 246,
"styleRecalcDurationMs": 36.464,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6267.714,
"heapDeltaBytes": 13179952,
"heapUsedBytes": 88472272,
"domNodes": -276,
"jsHeapTotalBytes": -151552,
"scriptDurationMs": 2788.9220000000005,
"eventListeners": -165,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16646.235999999986,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15889.313999999998,
"heapDeltaBytes": -39770108,
"heapUsedBytes": 175423000,
"domNodes": -6548,
"jsHeapTotalBytes": 2899968,
"scriptDurationMs": 252.96799999999996,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333237,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17693.494999999984,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17023.175000000003,
"heapDeltaBytes": -35108644,
"heapUsedBytes": 174986192,
"domNodes": -6548,
"jsHeapTotalBytes": 1851392,
"scriptDurationMs": 301.951,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20640.443000000007,
"styleRecalcs": 171,
"styleRecalcDurationMs": 16.912000000000038,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20216.273999999998,
"heapDeltaBytes": -23201772,
"heapUsedBytes": 179755120,
"domNodes": -6548,
"jsHeapTotalBytes": 958464,
"scriptDurationMs": 906.8830000000002,
"eventListeners": -7467,
"totalBlockingTimeMs": 61,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21904.322999999975,
"styleRecalcs": 172,
"styleRecalcDurationMs": 20.662000000000013,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21610.869000000002,
"heapDeltaBytes": -25222540,
"heapUsedBytes": 177272928,
"domNodes": -6548,
"jsHeapTotalBytes": -3887104,
"scriptDurationMs": 944.408,
"eventListeners": -7469,
"totalBlockingTimeMs": 104,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 5970.7980000000025,
"styleRecalcs": 20,
"styleRecalcDurationMs": 77.791,
"layouts": 20,
"layoutDurationMs": 21.99100000000001,
"taskDurationMs": 5859.938,
"heapDeltaBytes": -33329084,
"heapUsedBytes": 168928920,
"domNodes": -6548,
"jsHeapTotalBytes": 17559552,
"scriptDurationMs": 105.06999999999998,
"eventListeners": -7471,
"totalBlockingTimeMs": 389,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 6298.306000000025,
"styleRecalcs": 20,
"styleRecalcDurationMs": 82.449,
"layouts": 20,
"layoutDurationMs": 24.62299999999999,
"taskDurationMs": 6220.653,
"heapDeltaBytes": -46599044,
"heapUsedBytes": 162719276,
"domNodes": -6548,
"jsHeapTotalBytes": 5959680,
"scriptDurationMs": 116.868,
"eventListeners": -7471,
"totalBlockingTimeMs": 435,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 118.9679999999953,
"styleRecalcs": 8,
"styleRecalcDurationMs": 17.04,
"layouts": 2,
"layoutDurationMs": 1.443,
"taskDurationMs": 86.316,
"heapDeltaBytes": 3148688,
"heapUsedBytes": 71963168,
"domNodes": 132,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 7.811,
"eventListeners": 25,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 103.25799999998253,
"styleRecalcs": 5,
"styleRecalcDurationMs": 18.269000000000002,
"layouts": 3,
"layoutDurationMs": 1.554,
"taskDurationMs": 79.265,
"heapDeltaBytes": 3101316,
"heapUsedBytes": 71405900,
"domNodes": 123,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 6.493999999999998,
"eventListeners": 25,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.53 #17003 +/- ##
=============================================
+ Coverage 83.31% 83.33% +0.01%
=============================================
Files 2023 2023
Lines 117048 117083 +35
Branches 33053 33065 +12
=============================================
+ Hits 97520 97566 +46
+ Misses 19172 19159 -13
- Partials 356 358 +2
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Backport of #16725 to
core/1.53Automatically created by backport workflow.