Repository navigation
[backport cloud/1.52] test: remove transient top-up assertion - #17002
Conversation
## Summary Remove a transient assertion that made the cloud 3DS top-up test flaky after the dialog had already advanced to verification. ## Changes - **What**: Stop expecting the confirmation step's Back button after payment polling starts. The test still verifies the poll request, verification UI, and popup parameters. ## Review Focus The failing assertion appeared in 5 of 11 previous cloud runs. In each failure artifact, the dialog had already reached "Verify your payment," so the missing Back button was the expected next state. Tested with 10 consecutive targeted cloud-project passes. ESLint, formatting, browser type checking, and project type checking pass. Co-authored-by: Amp <amp@ampcode.com>
🎭 Playwright: ✅ 1989 passed, 0 failed📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-04T16:36:33.571Z",
"gitSha": "415302d56fdb5bc6c0c07b5b3d8eda9e51319090",
"branch": "backport-16725-to-cloud-1.52",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2055.9179999999915,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.329999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 510.498,
"heapDeltaBytes": 15829684,
"heapUsedBytes": 77369760,
"domNodes": -280,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 8.745,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2048.5199999999395,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.404000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 518.054,
"heapDeltaBytes": 15916400,
"heapUsedBytes": 78550776,
"domNodes": -281,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 8.427999999999997,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1837.0749999999987,
"styleRecalcs": 72,
"styleRecalcDurationMs": 34.18300000000001,
"layouts": 12,
"layoutDurationMs": 3.7520000000000002,
"taskDurationMs": 871.1539999999999,
"heapDeltaBytes": -4959104,
"heapUsedBytes": 57498312,
"domNodes": -280,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 112.102,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1814.0809999999874,
"styleRecalcs": 72,
"styleRecalcDurationMs": 33.473000000000006,
"layouts": 12,
"layoutDurationMs": 3.209,
"taskDurationMs": 851.563,
"heapDeltaBytes": 18777096,
"heapUsedBytes": 81861728,
"domNodes": -281,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 108.097,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1672.8019999999901,
"styleRecalcs": 32,
"styleRecalcDurationMs": 16.857000000000003,
"layouts": 6,
"layoutDurationMs": 0.5640000000000001,
"taskDurationMs": 353.148,
"heapDeltaBytes": 3296304,
"heapUsedBytes": 66305284,
"domNodes": 77,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 9.165000000000001,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1670.1689999999871,
"styleRecalcs": 32,
"styleRecalcDurationMs": 16.429,
"layouts": 6,
"layoutDurationMs": 0.5469999999999999,
"taskDurationMs": 352.143,
"heapDeltaBytes": 3640812,
"heapUsedBytes": 66583472,
"domNodes": 77,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 9.359,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 666.9069999999806,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.712000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 411.83799999999997,
"heapDeltaBytes": 11164252,
"heapUsedBytes": 72756220,
"domNodes": 14,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 59.009,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 545.9160000000338,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.534000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 355.981,
"heapDeltaBytes": 10522880,
"heapUsedBytes": 73821828,
"domNodes": 18,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 53.217,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2054.0079999999534,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.729999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 598.289,
"heapDeltaBytes": -4736816,
"heapUsedBytes": 72344516,
"domNodes": -279,
"jsHeapTotalBytes": -1581056,
"scriptDurationMs": 13.274999999999999,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2056.997000000024,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.841999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 602.699,
"heapDeltaBytes": -4600300,
"heapUsedBytes": 72720624,
"domNodes": -281,
"jsHeapTotalBytes": -1318912,
"scriptDurationMs": 15.741999999999999,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2198.556999999994,
"styleRecalcs": 70,
"styleRecalcDurationMs": 19.28,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1225.8519999999999,
"heapDeltaBytes": -5363340,
"heapUsedBytes": 72659252,
"domNodes": -276,
"jsHeapTotalBytes": -569344,
"scriptDurationMs": 349.548,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2197.125000000028,
"styleRecalcs": 68,
"styleRecalcDurationMs": 13.478,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1219.218,
"heapDeltaBytes": -14166688,
"heapUsedBytes": 64001456,
"domNodes": -285,
"jsHeapTotalBytes": 2088960,
"scriptDurationMs": 319.62600000000003,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3160.9300000000076,
"styleRecalcs": 63,
"styleRecalcDurationMs": 13.066,
"layouts": 60,
"layoutDurationMs": 7.319999999999999,
"taskDurationMs": 1398.616,
"heapDeltaBytes": -14262248,
"heapUsedBytes": 65271184,
"domNodes": -287,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 388.96400000000006,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666636,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3197.9730000000473,
"styleRecalcs": 65,
"styleRecalcDurationMs": 14.885000000000002,
"layouts": 60,
"layoutDurationMs": 7.441000000000002,
"taskDurationMs": 1433.813,
"heapDeltaBytes": -11548736,
"heapUsedBytes": 68159436,
"domNodes": -287,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 381.33299999999997,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2238.8220000000274,
"styleRecalcs": 45,
"styleRecalcDurationMs": 8.928000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1430.9460000000001,
"heapDeltaBytes": -15322708,
"heapUsedBytes": 70014148,
"domNodes": 10,
"jsHeapTotalBytes": 8949760,
"scriptDurationMs": 453.092,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "legacy-node-drag",
"durationMs": 2201.385000000073,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.250999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1443.8509999999999,
"heapDeltaBytes": 11244428,
"heapUsedBytes": 91200752,
"domNodes": 14,
"jsHeapTotalBytes": 6746112,
"scriptDurationMs": 448.84000000000003,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2011.148999999989,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.084000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 593.1070000000001,
"heapDeltaBytes": -12490916,
"heapUsedBytes": 65653012,
"domNodes": -285,
"jsHeapTotalBytes": 2875392,
"scriptDurationMs": 14.686000000000002,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2044.4799999999077,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.145,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 605.577,
"heapDeltaBytes": -11920432,
"heapUsedBytes": 73414232,
"domNodes": -279,
"jsHeapTotalBytes": 3923968,
"scriptDurationMs": 15.231000000000002,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 595.7970000000046,
"styleRecalcs": 45,
"styleRecalcDurationMs": 9.827,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 411.3829999999999,
"heapDeltaBytes": 11853044,
"heapUsedBytes": 74851972,
"domNodes": 16,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 131.59300000000002,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 607.8750000000355,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.370999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 392.68100000000004,
"heapDeltaBytes": 11902372,
"heapUsedBytes": 74576812,
"domNodes": 20,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 117.10600000000001,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2017.423000000008,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.609,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 482.36500000000007,
"heapDeltaBytes": 17832648,
"heapUsedBytes": 80917328,
"domNodes": -283,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 6.228999999999998,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2021.8830000000025,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.375,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 482.4630000000001,
"heapDeltaBytes": 19363572,
"heapUsedBytes": 82112580,
"domNodes": -283,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 6.264000000000002,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1715.0350000000003,
"styleRecalcs": 74,
"styleRecalcDurationMs": 34.304,
"layouts": 16,
"layoutDurationMs": 3.7439999999999993,
"taskDurationMs": 797.618,
"heapDeltaBytes": 19972152,
"heapUsedBytes": 83009412,
"domNodes": -282,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 85.56099999999999,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1706.5650000000687,
"styleRecalcs": 76,
"styleRecalcDurationMs": 35.884,
"layouts": 16,
"layoutDurationMs": 4.22,
"taskDurationMs": 801.9920000000001,
"heapDeltaBytes": 17771748,
"heapUsedBytes": 80766528,
"domNodes": -281,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 85.73,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1367.4230000000307,
"styleRecalcs": 18,
"styleRecalcDurationMs": 31.541,
"layouts": 13,
"layoutDurationMs": 14.211000000000002,
"taskDurationMs": 896.169,
"heapDeltaBytes": -4078220,
"heapUsedBytes": 87172952,
"domNodes": 13673,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 16.613999999999997,
"eventListeners": 2373,
"totalBlockingTimeMs": 140,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8344.966,
"styleRecalcs": 250,
"styleRecalcDurationMs": 36.87,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4229.616,
"heapDeltaBytes": 1054924,
"heapUsedBytes": 78492076,
"domNodes": -278,
"jsHeapTotalBytes": 217088,
"scriptDurationMs": 1050.094,
"eventListeners": -135,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8261.870000000044,
"styleRecalcs": 250,
"styleRecalcDurationMs": 38.359,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4184.49,
"heapDeltaBytes": 3259356,
"heapUsedBytes": 80260628,
"domNodes": -273,
"jsHeapTotalBytes": -602112,
"scriptDurationMs": 1009.854,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17002.789000000008,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16483.277000000002,
"heapDeltaBytes": -50268972,
"heapUsedBytes": 181450784,
"domNodes": -8312,
"jsHeapTotalBytes": -20385792,
"scriptDurationMs": 107.86000000000001,
"eventListeners": -16391,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16970.166000000063,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16468.847,
"heapDeltaBytes": -31095168,
"heapUsedBytes": 181112320,
"domNodes": -8312,
"jsHeapTotalBytes": -11575296,
"scriptDurationMs": 112.358,
"eventListeners": -16393,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 20586.26099999998,
"styleRecalcs": 173,
"styleRecalcDurationMs": 17.10800000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20042.318,
"heapDeltaBytes": -22175996,
"heapUsedBytes": 194051576,
"domNodes": -8312,
"jsHeapTotalBytes": -20021248,
"scriptDurationMs": 434.16099999999994,
"eventListeners": -16389,
"totalBlockingTimeMs": 78,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20747.214999999982,
"styleRecalcs": 172,
"styleRecalcDurationMs": 16.69699999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20149.059999999998,
"heapDeltaBytes": -33863684,
"heapUsedBytes": 191822292,
"domNodes": -8312,
"jsHeapTotalBytes": -19742720,
"scriptDurationMs": 457.21799999999996,
"eventListeners": -16385,
"totalBlockingTimeMs": 83,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 452.58799999999155,
"styleRecalcs": 12,
"styleRecalcDurationMs": 20.249,
"layouts": 4,
"layoutDurationMs": 1.272,
"taskDurationMs": 109.64800000000002,
"heapDeltaBytes": 5011264,
"heapUsedBytes": 67839224,
"domNodes": 122,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.466999999999999,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 125.64499999996315,
"styleRecalcs": 8,
"styleRecalcDurationMs": 17.853,
"layouts": 2,
"layoutDurationMs": 1.177,
"taskDurationMs": 91.03900000000002,
"heapDeltaBytes": 3063208,
"heapUsedBytes": 65664764,
"domNodes": 128,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.954000000000001,
"eventListeners": 25,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.52 #17002 +/- ##
==============================================
+ Coverage 79.65% 82.05% +2.40%
==============================================
Files 2242 1912 -330
Lines 115127 110127 -5000
Branches 32913 32208 -705
==============================================
- Hits 91706 90367 -1339
+ Misses 22926 19407 -3519
+ Partials 495 353 -142
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Backport of #16725 to
cloud/1.52Automatically created by backport workflow.