Skip to content

[backport cloud/1.52] test(e2e): cover Run through the real button on an unsubscribed Local workspace - #16059

Merged
comfy-pr-bot merged 3 commits into
cloud/1.52from
backport-16041-to-cloud-1.52
Sep 1, 2026
Merged

comfy-pr-bot merged 3 commits into
cloud/1.52from
backport-16041-to-cloud-1.52

Conversation

@comfy-pr-bot

Copy link
Copy Markdown
Member

Backport of #16041 to cloud/1.52

Automatically created by backport workflow.

… workspace (#16041)

## Summary

Adds the E2E regression test for #16032 (Run silently doing nothing on
Local at 0 credits), driven through the real Run button.

## Why this was missed by E2E

`workspaceSwitcherFixture` already models the exact failing state
(`is_active: false`, balance 0, Local), but the existing queue test
calls `window.app.queuePrompt(0)` directly — bypassing the
`Comfy.QueuePrompt` command where the subscribe-to-run gate lives. The
QA-reported bug (thread: 1.51 local workspace switcher QA) lived
precisely in that skipped layer.

## Changes

- **What**: New test in `localWorkspaceSwitcher.spec.ts` that loads the
default workflow on an unsubscribed/zero-balance Local workspace, clicks
the actual Run button, and asserts `POST /api/prompt` is issued.

## Verification

- Passes against current main (real ComfyUI backend + dev server).
- Fails against the pre-#16032 gate (`if
(!canAccessSubscriptionFeatures.value)` reverted locally): Run click
produces no prompt request, test times out — reproducing the QA report.
- Full `localWorkspaceSwitcher.spec.ts` (3 tests) green.

## Review Focus

- Coverage audit of this QA round: every other reported case already has
unit + E2E coverage (race condition → `localWorkspaceSwitcher.spec.ts`;
API-key billing → `apiKeyLoginBilling.spec.ts`; Add credits on Local →
`localCreditsWorkspaceRail.spec.ts`; billing routes →
`localCreditsNoSubscribeUi.spec.ts` / `cloud.spec.ts`; Cloud
subscribe-to-run → `subscription.spec.ts` + unit gate tests in
`useCoreCommands.test.ts`). This was the last gap.
@comfy-pr-bot comfy-pr-bot added the backport Backporting a PR onto a release candidate label Aug 26, 2026
@comfy-pr-bot
comfy-pr-bot enabled auto-merge (squash) August 26, 2026 21:29
@vercel

vercel Bot commented Aug 26, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
comfy-ui-frontend-desktop-ui Ready Ready Preview Aug 26, 2026 9:30pm

Request Review

@github-actions

github-actions Bot commented Aug 26, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ❌ 1980 passed, 1 failed · 3 flaky

❌ Failed Tests

📊 Browser Reports
  • chromium: View Report (✅ 1959 / ❌ 1 / ⚠️ 3 / ⏭️ 5)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 59.2 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 59.7 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 62.8 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.5 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.9 MB heap
large-graph-pan: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.8 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.0 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 77.9 MB heap
minimap-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 62.4 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.2 MB heap
subgraph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.2 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 78.4 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 154ms TBT · 82.3 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.9 MB heap
vue-large-graph-idle: · 55.4 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 168.1 MB heap
vue-large-graph-pan: · 54.6 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 47ms TBT · 174.6 MB heap
workflow-execution: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.6 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 8ms
canvas-idle: layout count 0
canvas-idle: style recalc count 8
canvas-idle: task duration 646ms
canvas-idle: script duration 12ms
canvas-idle: TBT 0ms
canvas-idle: heap used 59.2 MB
canvas-idle: DOM nodes -283
canvas-idle: event listeners -183
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 40ms
canvas-mouse-sweep: layout count 12
canvas-mouse-sweep: style recalc count 73
canvas-mouse-sweep: task duration 953ms
canvas-mouse-sweep: script duration 120ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 59.7 MB
canvas-mouse-sweep: DOM nodes -285
canvas-mouse-sweep: event listeners -166
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 20ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 31
canvas-zoom-sweep: task duration 440ms
canvas-zoom-sweep: script duration 14ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 62.8 MB
canvas-zoom-sweep: DOM nodes 77
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 7ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 10
dom-widget-clipping: task duration 388ms
dom-widget-clipping: script duration 59ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 70.5 MB
dom-widget-clipping: DOM nodes 15
dom-widget-clipping: event listeners 1
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 8ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 8
large-graph-idle: task duration 758ms
large-graph-idle: script duration 20ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 64.9 MB
large-graph-idle: DOM nodes -281
large-graph-idle: event listeners -165
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 16ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 69
large-graph-pan: task duration 1340ms
large-graph-pan: script duration 372ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 63.8 MB
large-graph-pan: DOM nodes -280
large-graph-pan: event listeners -150
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 8ms
large-graph-zoom: style recalc duration 15ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 64
large-graph-zoom: task duration 1497ms
large-graph-zoom: script duration 419ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 68.0 MB
large-graph-zoom: DOM nodes -289
large-graph-zoom: event listeners -154
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 10ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 45
legacy-node-drag: task duration 1573ms
legacy-node-drag: script duration 501ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 77.9 MB
legacy-node-drag: DOM nodes 10
legacy-node-drag: event listeners 186
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 8ms
minimap-idle: layout count 0
minimap-idle: style recalc count 7
minimap-idle: task duration 734ms
minimap-idle: script duration 18ms
minimap-idle: TBT 0ms
minimap-idle: heap used 62.4 MB
minimap-idle: DOM nodes -285
minimap-idle: event listeners -181
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 11ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 46
subgraph-dom-widget-clipping: task duration 423ms
subgraph-dom-widget-clipping: script duration 125ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 71.2 MB
subgraph-dom-widget-clipping: DOM nodes 17
subgraph-dom-widget-clipping: event listeners 8
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 9ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 9
subgraph-idle: task duration 594ms
subgraph-idle: script duration 10ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 65.2 MB
subgraph-idle: DOM nodes -283
subgraph-idle: event listeners -151
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 5ms
subgraph-mouse-sweep: style recalc duration 43ms
subgraph-mouse-sweep: layout count 16
subgraph-mouse-sweep: style recalc count 75
subgraph-mouse-sweep: task duration 892ms
subgraph-mouse-sweep: script duration 95ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 78.4 MB
subgraph-mouse-sweep: DOM nodes -284
subgraph-mouse-sweep: event listeners -151
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 16ms
subgraph-transition-enter: style recalc duration 34ms
subgraph-transition-enter: layout count 15
subgraph-transition-enter: style recalc count 20
subgraph-transition-enter: task duration 1014ms
subgraph-transition-enter: script duration 20ms
subgraph-transition-enter: TBT 154ms
subgraph-transition-enter: heap used 82.3 MB
subgraph-transition-enter: DOM nodes 13673
subgraph-transition-enter: event listeners 2375
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 41ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 250
viewport-pan-sweep: task duration 4692ms
viewport-pan-sweep: script duration 1137ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 72.9 MB
viewport-pan-sweep: DOM nodes -280
viewport-pan-sweep: event listeners -148
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 17239ms
vue-large-graph-idle: script duration 133ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 168.1 MB
vue-large-graph-idle: DOM nodes -8312
vue-large-graph-idle: event listeners -16393
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 21ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 171
vue-large-graph-pan: task duration 20874ms
vue-large-graph-pan: script duration 421ms
vue-large-graph-pan: TBT 47ms
vue-large-graph-pan: heap used 174.6 MB
vue-large-graph-pan: DOM nodes -8312
vue-large-graph-pan: event listeners -16384
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 20ms
workflow-execution: layout count 3
workflow-execution: style recalc count 13
workflow-execution: task duration 107ms
workflow-execution: script duration 10ms
workflow-execution: TBT 0ms
workflow-execution: heap used 63.6 MB
workflow-execution: DOM nodes 128
workflow-execution: event listeners 74
Raw data
{
  "timestamp": "2026-08-27T04:22:00.978Z",
  "gitSha": "f4c8b40d84dda55e899884cf31589e6cc01bb97b",
  "branch": "backport-16041-to-cloud-1.52",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2096.492000000012,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 6.815999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 693.907,
      "heapDeltaBytes": 1178868,
      "heapUsedBytes": 62827100,
      "domNodes": -283,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 12.755000000000003,
      "eventListeners": -183,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-idle",
      "durationMs": 2056.080999999949,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.647000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 597.854,
      "heapDeltaBytes": -390552,
      "heapUsedBytes": 61244032,
      "domNodes": -282,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 10.294,
      "eventListeners": -183,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1919.648000000052,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 41.235,
      "layouts": 12,
      "layoutDurationMs": 3.575,
      "taskDurationMs": 965.149,
      "heapDeltaBytes": 6574720,
      "heapUsedBytes": 68571816,
      "domNodes": -284,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 121.07900000000001,
      "eventListeners": -181,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1881.45499999996,
      "styleRecalcs": 72,
      "styleRecalcDurationMs": 38.971000000000004,
      "layouts": 12,
      "layoutDurationMs": 3.641,
      "taskDurationMs": 941.289,
      "heapDeltaBytes": -5733148,
      "heapUsedBytes": 56625476,
      "domNodes": -285,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 118.27799999999999,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1739.7429999999758,
      "styleRecalcs": 30,
      "styleRecalcDurationMs": 19.584999999999997,
      "layouts": 6,
      "layoutDurationMs": 0.7699999999999998,
      "taskDurationMs": 434.08200000000005,
      "heapDeltaBytes": 3318324,
      "heapUsedBytes": 65900308,
      "domNodes": 76,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 14.045000000000002,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1740.9119999999803,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 20.180999999999997,
      "layouts": 6,
      "layoutDurationMs": 0.6459999999999999,
      "taskDurationMs": 446.684,
      "heapDeltaBytes": 3348196,
      "heapUsedBytes": 65889872,
      "domNodes": 77,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 14.119,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 613.962000000015,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 6.482999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 394.14300000000003,
      "heapDeltaBytes": 10998320,
      "heapUsedBytes": 73966584,
      "domNodes": 14,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 58.349000000000004,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 577.5610000000597,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 7.1480000000000015,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 381.3930000000001,
      "heapDeltaBytes": 10817804,
      "heapUsedBytes": 73982744,
      "domNodes": 16,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 58.805,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2038.503999999989,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 9.490000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 758.9619999999999,
      "heapDeltaBytes": -12428684,
      "heapUsedBytes": 64236304,
      "domNodes": -280,
      "jsHeapTotalBytes": 3661824,
      "scriptDurationMs": 17.709000000000003,
      "eventListeners": -181,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2052.5780000000395,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 7.4289999999999985,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 756.0409999999999,
      "heapDeltaBytes": -5198376,
      "heapUsedBytes": 71905952,
      "domNodes": -282,
      "jsHeapTotalBytes": -1581056,
      "scriptDurationMs": 21.609,
      "eventListeners": -149,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2285.2340000000595,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 14.485000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1335.029,
      "heapDeltaBytes": -14223728,
      "heapUsedBytes": 63677632,
      "domNodes": -283,
      "jsHeapTotalBytes": 1564672,
      "scriptDurationMs": 371.344,
      "eventListeners": -149,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2268.827999999985,
      "styleRecalcs": 70,
      "styleRecalcDurationMs": 17.86,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1345.3970000000002,
      "heapDeltaBytes": -7940832,
      "heapUsedBytes": 70163736,
      "domNodes": -276,
      "jsHeapTotalBytes": 1527808,
      "scriptDurationMs": 372.20399999999995,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3280.153000000041,
      "styleRecalcs": 63,
      "styleRecalcDurationMs": 13.981,
      "layouts": 60,
      "layoutDurationMs": 8.166,
      "taskDurationMs": 1498.8700000000001,
      "heapDeltaBytes": -8281828,
      "heapUsedBytes": 71294252,
      "domNodes": -290,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 415.163,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3279.9790000001394,
      "styleRecalcs": 64,
      "styleRecalcDurationMs": 15.875000000000004,
      "layouts": 60,
      "layoutDurationMs": 8.116,
      "taskDurationMs": 1495.019,
      "heapDeltaBytes": -8144980,
      "heapUsedBytes": 71394588,
      "domNodes": -288,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 421.981,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2778.9260000000695,
      "styleRecalcs": 45,
      "styleRecalcDurationMs": 9.920000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1582.813,
      "heapDeltaBytes": -17359224,
      "heapUsedBytes": 70111888,
      "domNodes": 10,
      "jsHeapTotalBytes": 10260480,
      "scriptDurationMs": 503.2030000000001,
      "eventListeners": 186,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2677.146999999877,
      "styleRecalcs": 45,
      "styleRecalcDurationMs": 9.815000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1562.4959999999999,
      "heapDeltaBytes": 13172136,
      "heapUsedBytes": 93240748,
      "domNodes": 10,
      "jsHeapTotalBytes": 6483968,
      "scriptDurationMs": 497.842,
      "eventListeners": 186,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2041.6889999999057,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 6.954999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 728.275,
      "heapDeltaBytes": -12454264,
      "heapUsedBytes": 65730548,
      "domNodes": -284,
      "jsHeapTotalBytes": 3661824,
      "scriptDurationMs": 18.366,
      "eventListeners": -181,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2040.124999999989,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 8.278999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 740.184,
      "heapDeltaBytes": -13187520,
      "heapUsedBytes": 65052688,
      "domNodes": -286,
      "jsHeapTotalBytes": 3661824,
      "scriptDurationMs": 18.486999999999995,
      "eventListeners": -181,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 628.4259999999904,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 11.925999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 417.36800000000005,
      "heapDeltaBytes": 11900900,
      "heapUsedBytes": 74534872,
      "domNodes": 20,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 121.461,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 636.8190000000595,
      "styleRecalcs": 44,
      "styleRecalcDurationMs": 9.272000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 428.2509999999999,
      "heapDeltaBytes": 11966812,
      "heapUsedBytes": 74824076,
      "domNodes": 14,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 129.395,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2035.129999999981,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 9.865,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 606.733,
      "heapDeltaBytes": -7688924,
      "heapUsedBytes": 55233808,
      "domNodes": -283,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 10.273000000000001,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2055.33000000014,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 8.012,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 581.4140000000001,
      "heapDeltaBytes": 18408808,
      "heapUsedBytes": 81542028,
      "domNodes": -282,
      "jsHeapTotalBytes": 4448256,
      "scriptDurationMs": 10.077,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1757.2320000000445,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 44.233999999999995,
      "layouts": 16,
      "layoutDurationMs": 4.892,
      "taskDurationMs": 881.5959999999999,
      "heapDeltaBytes": 19546504,
      "heapUsedBytes": 82552184,
      "domNodes": -282,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 93.456,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1740.8030000001418,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 41.374,
      "layouts": 16,
      "layoutDurationMs": 5.548,
      "taskDurationMs": 903.2750000000001,
      "heapDeltaBytes": 19242060,
      "heapUsedBytes": 81816580,
      "domNodes": -285,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 95.804,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1400.6839999999556,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 34.458000000000006,
      "layouts": 15,
      "layoutDurationMs": 15.827999999999998,
      "taskDurationMs": 1014.3399999999998,
      "heapDeltaBytes": -6093484,
      "heapUsedBytes": 86252092,
      "domNodes": 13673,
      "jsHeapTotalBytes": 11796480,
      "scriptDurationMs": 19.635000000000005,
      "eventListeners": 2375,
      "totalBlockingTimeMs": 154,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8778.223000000025,
      "styleRecalcs": 251,
      "styleRecalcDurationMs": 41.775999999999996,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4686.781,
      "heapDeltaBytes": 766196,
      "heapUsedBytes": 78076816,
      "domNodes": -277,
      "jsHeapTotalBytes": -569344,
      "scriptDurationMs": 1141.654,
      "eventListeners": -133,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 9031.527000000096,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 40.342000000000006,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4696.359,
      "heapDeltaBytes": -2661068,
      "heapUsedBytes": 74761964,
      "domNodes": -282,
      "jsHeapTotalBytes": 4935680,
      "scriptDurationMs": 1132.579,
      "eventListeners": -163,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17887.94999999993,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17055.08,
      "heapDeltaBytes": -35810784,
      "heapUsedBytes": 176281452,
      "domNodes": -8312,
      "jsHeapTotalBytes": -17604608,
      "scriptDurationMs": 121.51200000000001,
      "eventListeners": -16393,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 18.333333333333332,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 18323.147000000063,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17422.184999999998,
      "heapDeltaBytes": -39594004,
      "heapUsedBytes": 176212228,
      "domNodes": -8312,
      "jsHeapTotalBytes": -21487616,
      "scriptDurationMs": 143.60399999999998,
      "eventListeners": -16393,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.779999999999927,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21531.192000000032,
      "styleRecalcs": 172,
      "styleRecalcDurationMs": 21.019999999999982,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20842.461,
      "heapDeltaBytes": -58396024,
      "heapUsedBytes": 173048448,
      "domNodes": -8312,
      "jsHeapTotalBytes": -24563712,
      "scriptDurationMs": 403.912,
      "eventListeners": -16385,
      "totalBlockingTimeMs": 70,
      "frameDurationMs": 18.333333333333332,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21490.637000000104,
      "styleRecalcs": 170,
      "styleRecalcDurationMs": 21.30599999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20904.951,
      "heapDeltaBytes": -18961900,
      "heapUsedBytes": 193143616,
      "domNodes": -8312,
      "jsHeapTotalBytes": -14004224,
      "scriptDurationMs": 437.65,
      "eventListeners": -16383,
      "totalBlockingTimeMs": 23,
      "frameDurationMs": 18.329999999999927,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 491.78299999994124,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 22.199000000000005,
      "layouts": 3,
      "layoutDurationMs": 1.3729999999999998,
      "taskDurationMs": 129.549,
      "heapDeltaBytes": 5294688,
      "heapUsedBytes": 67485132,
      "domNodes": 150,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 14.738999999999999,
      "eventListeners": 99,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 112.56699999989905,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 18.705,
      "layouts": 3,
      "layoutDurationMs": 0.6180000000000001,
      "taskDurationMs": 85.27799999999999,
      "heapDeltaBytes": 3163560,
      "heapUsedBytes": 65890248,
      "domNodes": 106,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 6.26,
      "eventListeners": 49,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    }
  ]
}

@codecov

codecov Bot commented Aug 26, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@              Coverage Diff              @@
##             cloud/1.52   #16059   +/-   ##
=============================================
  Coverage              ?   81.97%           
=============================================
  Files                 ?     1910           
  Lines                 ?   109656           
  Branches              ?    31033           
=============================================
  Hits                  ?    89889           
  Misses                ?    19430           
  Partials              ?      337           
Flag Coverage Δ
e2e 66.25% <ø> (?)
unit 73.93% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

dante01yoon added a commit that referenced this pull request Aug 27, 2026
…#16085)

`cloud/1.52` does not typecheck. Every PR opened against it is red on a
diff it does not own.

```
packages/ingest-types/src/index.ts(237,3):       error TS2300: Duplicate identifier 'CurrentWorkspaceResponse'.
packages/ingest-types/src/index.ts(240,3):       error TS2300: Duplicate identifier 'CurrentWorkspaceResponse'.
packages/ingest-types/src/types.gen.ts(3263,13): error TS2300: Duplicate identifier 'CurrentWorkspaceResponse'.
packages/ingest-types/src/types.gen.ts(3280,13): error TS2300: Duplicate identifier 'CurrentWorkspaceResponse'.
```

Confirmed blocked: #16080 and #16084 are both red solely on this.

## Root cause

A semantic conflict between two backports — clean for git, broken for
TypeScript.

| commit | PR | merged (UTC) | `CurrentWorkspaceResponse` declarations
after |
| --- | --- | --- | --- |
| `c143e62b5` | #15953 — establish workspace context for API-key
sessions | 8/26 04:43 | 1 |
| `d9e00f921` | #15939 — ENTERPRISE tier + `ingest-types` regeneration |
8/26 23:36 | **2** |

#15953 introduced the type. #15939 regenerated the package from the
cloud OpenAPI spec and added it again. Neither touched the same lines,
so git reported no conflict and the duplicate landed silently.

CI did not catch it because **#15939's checks last ran 8/25 23:33 —
roughly 24 hours before it merged, and before #15953 was on the
branch.** It was green against a merge ref that no longer described
reality.

The second block also swallowed the JSDoc belonging to
`CreateWorkspaceRequest`, leaving that type undocumented:

```ts
/**
 * Request body for creating a new workspace.
 */
export type CurrentWorkspaceResponse = {   // <- stray
```

In `index.ts` the stray re-export is visible as a break in the otherwise
alphabetical list (`CreateWorkspaceResponse, CurrentWorkspaceResponse,
CreateWorkspaceResponses`).

## Changes

Pure deletion, 15 lines, no additions:

- `types.gen.ts` — remove the duplicated `CurrentWorkspaceResponse`
block; the `Request body for creating a new workspace.` JSDoc returns to
`CreateWorkspaceRequest`
- `index.ts` — remove the duplicated re-export

Both files are generated, so the target was not a judgement call: **both
edited regions are now byte-identical to `main`**, which carries exactly
one declaration. This restores the generator's real output rather than
hand-authoring it. Re-running `pnpm --filter @comfyorg/ingest-types
generate` against the spec is the alternative and should produce the
same result — happy to swap to that if the team prefers a regeneration
commit, though it would pull in unrelated spec drift on a release
branch.

## Verification

`tsc` on the package, before and after:

```
### BASE (cloud/1.52)          exit=2   TS2300 x4   <- reproduces the CI failure exactly
### THIS PR                    exit=0   TS2300 x0   total errors 0
```

Also verified `CurrentWorkspaceResponse` is the only duplicated
identifier in either file, so this is the whole breakage and not the
first of several.

## Follow-ups (not in this PR)

1. **The stale-merge-base gap.** A PR merging on day-old checks is how
this shipped. Requiring branches be up to date before merge on
`cloud/*`, or re-running checks on merge, would close it.
2. **`pr-backport.yaml` discards partial success.** Separately, one
failing target aborts the whole step, so succeeding targets never get a
PR and their pushed branches are deleted in cleanup. That is why #16032
never reached `cloud/1.52` and why #16084 had to be made by hand.

## Merge order

This → #16084 (backport of #16032, *Run silently does nothing on Local
at 0 credits*) → #16059 (its E2E regression test).
@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Aug 27, 2026
dante01yoon added a commit that referenced this pull request Aug 27, 2026
…gh server capabilities (#16094)

Backport of #16067 to `cloud/1.52`.

## Merge order — this PR is stacked

Base is deliberately `backport-16046-to-cloud-1.52`, not `cloud/1.52`.
GitHub retargets this PR to `cloud/1.52` once its parent merges.

`cloud/1.52` → #15799 → #15803 → #15804 → #15675 → #15967 → #16043 →
#16046 → #16067

Every commit in this chain cherry-picks cleanly; there are no
hand-resolved conflicts anywhere in the stack.

## Verification

Run at the tip of the full stack: 93 unit test files, 1745 tests, 0
failures (`src/platform/workspace`, `src/platform/cloud/subscription`,
`src/composables/useCoreCommands.test.ts`, `src/components/actionbar`).

## Also carries #16032 and #16041

#16067's unit tests need mocks (`app.queuePrompt`,
`trackWorkflowExecution`, `useQueueSettingsStore`) that #16032
introduced, and its run-gate coverage comes from #16041. Both are
already backported independently as #16084 and #16059. This branch
therefore contains them; whichever lands first makes the other's patch a
no-op. Without #16032 the `useCoreCommands` hunks conflict and 8 tests
fail.

---------

Co-authored-by: comfydesigner <247099495+comfydesigner@users.noreply.github.com>
@comfy-pr-bot
comfy-pr-bot added this pull request to the merge queue Sep 1, 2026
@github-actions github-actions Bot added risk:R1 PR risk grade (advisory shadow check; grader-owned) and removed risk:R2 PR risk grade (advisory shadow check; grader-owned) labels Sep 1, 2026
Merged via the queue into cloud/1.52 with commit 6951c25 Sep 1, 2026
46 checks passed
@comfy-pr-bot
comfy-pr-bot deleted the backport-16041-to-cloud-1.52 branch September 1, 2026 02:49
@huang47 huang47 added the risk:medium PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026 — with ChatGPT Codex Connector
@huang47 huang47 removed the risk:R1 PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate risk:medium PR risk grade (advisory shadow check; grader-owned) size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants