Repository navigation
test(e2e): cover Run through the real button on an unsubscribed Local workspace - #16041
Conversation
… workspace The existing queue test drives window.app.queuePrompt directly, which skips the Comfy.QueuePrompt command where the subscribe-to-run gate lives — exactly the layer that silently blocked Run at 0 credits (#16032). Click the actual Run button so the command path stays covered.
🎭 Playwright: ✅ 2012 passed, 0 failed · 1 flaky📊 Browser Reports
📦 Bundle: 9.4 MB gzip ⚪ 0 BDetailsSummary
Category Glance App Entry Points — 3.78 kB (baseline 3.78 kB) • ⚪ 0 BMain entry bundles and manifests Status: 1 unchanged Graph Workspace — 1.4 MB (baseline 1.4 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration Status: 3 unchanged Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 17 unchanged Panels & Settings — 592 kB (baseline 592 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 27 unchanged User & Accounts — 27.5 kB (baseline 27.5 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 11 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 8 unchanged UI Components — 115 kB (baseline 115 kB) • ⚪ 0 BReusable component library chunks Status: 15 unchanged Data & Services — 3.53 MB (baseline 3.53 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 17 unchanged Utilities & Hooks — 555 kB (baseline 555 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 37 unchanged Vendor & Third-Party — 18.1 MB (baseline 18.1 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 15.3 MB (baseline 15.3 MB) • ⚪ 0 BBundles that do not match a named category Status: 292 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-08-26T13:40:12.423Z",
"gitSha": "8386e0df442be17fd261df2f980c6e94bcfd8d69",
"branch": "dante01yoon/test-local-run-gate-e2e",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2054.824999999994,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.599000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 505.31000000000006,
"heapDeltaBytes": 10785864,
"heapUsedBytes": 82057188,
"domNodes": -278,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 8.483,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2049.7810000000527,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.941000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 501.52400000000006,
"heapDeltaBytes": -15022896,
"heapUsedBytes": 56192604,
"domNodes": -282,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 8.213000000000001,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2423.1720000000223,
"styleRecalcs": 82,
"styleRecalcDurationMs": 50.12199999999999,
"layouts": 12,
"layoutDurationMs": 4.2589999999999995,
"taskDurationMs": 1419.786,
"heapDeltaBytes": -11163184,
"heapUsedBytes": 61187676,
"domNodes": -282,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 180.863,
"eventListeners": -187,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2140.1840000000902,
"styleRecalcs": 80,
"styleRecalcDurationMs": 43.34,
"layouts": 12,
"layoutDurationMs": 4.056,
"taskDurationMs": 1164.7350000000001,
"heapDeltaBytes": 5385820,
"heapUsedBytes": 77226312,
"domNodes": -279,
"jsHeapTotalBytes": 6807552,
"scriptDurationMs": 140.65800000000002,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1753.567999999973,
"styleRecalcs": 32,
"styleRecalcDurationMs": 17.902,
"layouts": 6,
"layoutDurationMs": 0.7699999999999999,
"taskDurationMs": 373.55899999999997,
"heapDeltaBytes": 4167836,
"heapUsedBytes": 76371048,
"domNodes": 77,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 11.837,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1740.0099999999838,
"styleRecalcs": 31,
"styleRecalcDurationMs": 17.222,
"layouts": 6,
"layoutDurationMs": 0.748,
"taskDurationMs": 356.66099999999994,
"heapDeltaBytes": 4569168,
"heapUsedBytes": 76353020,
"domNodes": 76,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 11.679000000000002,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 944.1640000000007,
"styleRecalcs": 12,
"styleRecalcDurationMs": 6.414,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 686.6020000000001,
"heapDeltaBytes": 6435836,
"heapUsedBytes": 78570608,
"domNodes": 16,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 144.176,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 927.3930000000519,
"styleRecalcs": 13,
"styleRecalcDurationMs": 6.568,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 674.833,
"heapDeltaBytes": 6501060,
"heapUsedBytes": 78314052,
"domNodes": 18,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 140.631,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2057.3210000000017,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.478999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 589.644,
"heapDeltaBytes": -4522584,
"heapUsedBytes": 74560728,
"domNodes": -276,
"jsHeapTotalBytes": 217088,
"scriptDurationMs": 38.79,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2023.0349999999362,
"styleRecalcs": 3,
"styleRecalcDurationMs": 1.871000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 525.82,
"heapDeltaBytes": -1410996,
"heapUsedBytes": 77407464,
"domNodes": -273,
"jsHeapTotalBytes": -2142208,
"scriptDurationMs": 35.376000000000005,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 3145.49599999998,
"styleRecalcs": 62,
"styleRecalcDurationMs": 9.614,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2340.2419999999997,
"heapDeltaBytes": -53104,
"heapUsedBytes": 65856788,
"domNodes": 0,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 843.329,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 3215.4349999999567,
"styleRecalcs": 62,
"styleRecalcDurationMs": 9.711,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2388.8930000000005,
"heapDeltaBytes": -23668,
"heapUsedBytes": 65882708,
"domNodes": 0,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 872.501,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 4240.505999999982,
"styleRecalcs": 66,
"styleRecalcDurationMs": 12.765999999999996,
"layouts": 60,
"layoutDurationMs": 8.178,
"taskDurationMs": 2413.518,
"heapDeltaBytes": -3993864,
"heapUsedBytes": 66782856,
"domNodes": 24,
"jsHeapTotalBytes": 2097152,
"scriptDurationMs": 824.2909999999999,
"eventListeners": 12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 4205.367000000024,
"styleRecalcs": 66,
"styleRecalcDurationMs": 12.968999999999998,
"layouts": 60,
"layoutDurationMs": 8.383999999999999,
"taskDurationMs": 2403.071,
"heapDeltaBytes": -3351680,
"heapUsedBytes": 67055328,
"domNodes": 24,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 834.11,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 4706.097999999997,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.033000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3563.4940000000006,
"heapDeltaBytes": 23984468,
"heapUsedBytes": 91663036,
"domNodes": 0,
"jsHeapTotalBytes": 1204224,
"scriptDurationMs": 977.8760000000001,
"eventListeners": 192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 4820.546000000036,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.242,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3537.099,
"heapDeltaBytes": 22310092,
"heapUsedBytes": 90230448,
"domNodes": 0,
"jsHeapTotalBytes": 2514944,
"scriptDurationMs": 968.4979999999999,
"eventListeners": 192,
"totalBlockingTimeMs": 10,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2043.109999999956,
"styleRecalcs": 3,
"styleRecalcDurationMs": 3.199999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 558.5190000000001,
"heapDeltaBytes": -3095576,
"heapUsedBytes": 77698660,
"domNodes": -274,
"jsHeapTotalBytes": -1355776,
"scriptDurationMs": 36.794,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2015.9630000000561,
"styleRecalcs": 2,
"styleRecalcDurationMs": 1.806000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 521.976,
"heapDeltaBytes": -3724816,
"heapUsedBytes": 77451432,
"domNodes": -276,
"jsHeapTotalBytes": -1617920,
"scriptDurationMs": 35.96,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 763.7499999999591,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.440000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 517.208,
"heapDeltaBytes": -7716292,
"heapUsedBytes": 64181692,
"domNodes": 18,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 139.33200000000002,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 711.9099999999889,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.676,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 506.21799999999996,
"heapDeltaBytes": -7277148,
"heapUsedBytes": 65073968,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 136.77499999999998,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2022.9049999999233,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.7509999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 491.029,
"heapDeltaBytes": -13838428,
"heapUsedBytes": 59031860,
"domNodes": -297,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 8.164000000000001,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2038.5890000000018,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.051000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 500.56199999999995,
"heapDeltaBytes": -15395888,
"heapUsedBytes": 56473672,
"domNodes": -297,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 7.824000000000001,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1840.9269999999651,
"styleRecalcs": 77,
"styleRecalcDurationMs": 36.513000000000005,
"layouts": 16,
"layoutDurationMs": 4.626,
"taskDurationMs": 1089.8569999999997,
"heapDeltaBytes": -4904444,
"heapUsedBytes": 66930824,
"domNodes": -296,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 106.562,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1893.6069999999745,
"styleRecalcs": 77,
"styleRecalcDurationMs": 37.937,
"layouts": 16,
"layoutDurationMs": 4.4479999999999995,
"taskDurationMs": 1121.653,
"heapDeltaBytes": 7515872,
"heapUsedBytes": 80024084,
"domNodes": -296,
"jsHeapTotalBytes": 6807552,
"scriptDurationMs": 111.767,
"eventListeners": -231,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-transition-enter",
"durationMs": 1384.5700000000534,
"styleRecalcs": 19,
"styleRecalcDurationMs": 30.809000000000005,
"layouts": 14,
"layoutDurationMs": 13.423,
"taskDurationMs": 936.2949999999998,
"heapDeltaBytes": -7410448,
"heapUsedBytes": 87881840,
"domNodes": 13671,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 31.719000000000012,
"eventListeners": 2381,
"totalBlockingTimeMs": 121,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 12307.367999999997,
"styleRecalcs": 247,
"styleRecalcDurationMs": 40.961999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8428.063,
"heapDeltaBytes": 782164,
"heapUsedBytes": 79123480,
"domNodes": -268,
"jsHeapTotalBytes": 1458176,
"scriptDurationMs": 2861.721,
"eventListeners": -129,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 12230.401000000029,
"styleRecalcs": 245,
"styleRecalcDurationMs": 40.729,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8385.41,
"heapDeltaBytes": -11033340,
"heapUsedBytes": 67985132,
"domNodes": -272,
"jsHeapTotalBytes": 1527808,
"scriptDurationMs": 2874.364,
"eventListeners": -129,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 18713.81199999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18225.098,
"heapDeltaBytes": -33727180,
"heapUsedBytes": 175544776,
"domNodes": -6548,
"jsHeapTotalBytes": -1482752,
"scriptDurationMs": 392.847,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 18631.517999999916,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18055.977,
"heapDeltaBytes": -50663540,
"heapUsedBytes": 171493556,
"domNodes": -6548,
"jsHeapTotalBytes": -1056768,
"scriptDurationMs": 389.87300000000005,
"eventListeners": -7471,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 23905.49299999998,
"styleRecalcs": 181,
"styleRecalcDurationMs": 24.171,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23617.324000000004,
"heapDeltaBytes": -41214684,
"heapUsedBytes": 167253104,
"domNodes": -6548,
"jsHeapTotalBytes": -1478656,
"scriptDurationMs": 977.372,
"eventListeners": -7467,
"totalBlockingTimeMs": 236,
"frameDurationMs": 17.77666666666652,
"p95FrameDurationMs": 16.700000000004366
},
{
"name": "vue-large-graph-pan",
"durationMs": 23900.987999999983,
"styleRecalcs": 182,
"styleRecalcDurationMs": 23.57799999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23573.011000000002,
"heapDeltaBytes": 3719144,
"heapUsedBytes": 196479728,
"domNodes": -6548,
"jsHeapTotalBytes": 4898816,
"scriptDurationMs": 967.8620000000001,
"eventListeners": -7467,
"totalBlockingTimeMs": 275,
"frameDurationMs": 18.329999999999806,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 453.20399999991423,
"styleRecalcs": 15,
"styleRecalcDurationMs": 22.712,
"layouts": 3,
"layoutDurationMs": 0.8350000000000001,
"taskDurationMs": 124.32300000000002,
"heapDeltaBytes": 5717684,
"heapUsedBytes": 74183400,
"domNodes": 126,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 7.711000000000001,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 496.0959999998522,
"styleRecalcs": 17,
"styleRecalcDurationMs": 26.094,
"layouts": 4,
"layoutDurationMs": 1.519,
"taskDurationMs": 140.21000000000004,
"heapDeltaBytes": 5815944,
"heapUsedBytes": 74361156,
"domNodes": 145,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 8.296000000000001,
"eventListeners": 97,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
}
]
} |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughAdds an end-to-end test for clicking Run in a local workspace without an active subscription. The test loads the default workflow and verifies that the action sends a prompt payload to ChangesLocal workspace Run flow
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This adds a focused end-to-end regression test for running an unsubscribed Local workspace through the real Run button; no actionable merge-blocking risk remains beyond normal checks and review. Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 inconclusive)
✅ Passed checks (6 passed)
Full details: Description checkExplanation The description includes the required Summary, Changes, and Review Focus sections. It also explains the missed coverage, verification results, and regression scenario. Breaking changes and dependencies are correctly omitted because none are indicated. Screenshots are not applicable to this test-only change. Full details: End-To-End Regression Coverage For FixesExplanation The check cannot determine the required bug-fix signal because the PR title and actual commit subjects are not available in the review context. The available metadata shows a change under Resolution Provide the PR title and the actual commit subjects. Then verify whether any contains the specified bug-fix language; if none does, pass the check. If one does, the existing Full details: Adr Compliance For Entity/Litegraph ChangesExplanation PASS — The only changed file is
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #16041 +/- ##
==========================================
+ Coverage 80.33% 82.61% +2.28%
==========================================
Files 2275 1941 -334
Lines 116776 111712 -5064
Branches 33859 32164 -1695
==========================================
- Hits 93810 92296 -1514
+ Misses 22466 19079 -3387
+ Partials 500 337 -163
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
@dante01yoon Successfully backported to #16057 |
|
@dante01yoon Successfully backported to #16058 |
|
@dante01yoon Successfully backported to #16059 |
… workspace (#16041) ## Summary Adds the E2E regression test for #16032 (Run silently doing nothing on Local at 0 credits), driven through the real Run button. ## Why this was missed by E2E `workspaceSwitcherFixture` already models the exact failing state (`is_active: false`, balance 0, Local), but the existing queue test calls `window.app.queuePrompt(0)` directly — bypassing the `Comfy.QueuePrompt` command where the subscribe-to-run gate lives. The QA-reported bug (thread: 1.51 local workspace switcher QA) lived precisely in that skipped layer. ## Changes - **What**: New test in `localWorkspaceSwitcher.spec.ts` that loads the default workflow on an unsubscribed/zero-balance Local workspace, clicks the actual Run button, and asserts `POST /api/prompt` is issued. ## Verification - Passes against current main (real ComfyUI backend + dev server). - Fails against the pre-#16032 gate (`if (!canAccessSubscriptionFeatures.value)` reverted locally): Run click produces no prompt request, test times out — reproducing the QA report. - Full `localWorkspaceSwitcher.spec.ts` (3 tests) green. ## Review Focus - Coverage audit of this QA round: every other reported case already has unit + E2E coverage (race condition → `localWorkspaceSwitcher.spec.ts`; API-key billing → `apiKeyLoginBilling.spec.ts`; Add credits on Local → `localCreditsWorkspaceRail.spec.ts`; billing routes → `localCreditsNoSubscribeUi.spec.ts` / `cloud.spec.ts`; Cloud subscribe-to-run → `subscription.spec.ts` + unit gate tests in `useCoreCommands.test.ts`). This was the last gap. (cherry picked from commit 2ab204c)
… workspace (#16041) ## Summary Adds the E2E regression test for #16032 (Run silently doing nothing on Local at 0 credits), driven through the real Run button. ## Why this was missed by E2E `workspaceSwitcherFixture` already models the exact failing state (`is_active: false`, balance 0, Local), but the existing queue test calls `window.app.queuePrompt(0)` directly — bypassing the `Comfy.QueuePrompt` command where the subscribe-to-run gate lives. The QA-reported bug (thread: 1.51 local workspace switcher QA) lived precisely in that skipped layer. ## Changes - **What**: New test in `localWorkspaceSwitcher.spec.ts` that loads the default workflow on an unsubscribed/zero-balance Local workspace, clicks the actual Run button, and asserts `POST /api/prompt` is issued. ## Verification - Passes against current main (real ComfyUI backend + dev server). - Fails against the pre-#16032 gate (`if (!canAccessSubscriptionFeatures.value)` reverted locally): Run click produces no prompt request, test times out — reproducing the QA report. - Full `localWorkspaceSwitcher.spec.ts` (3 tests) green. ## Review Focus - Coverage audit of this QA round: every other reported case already has unit + E2E coverage (race condition → `localWorkspaceSwitcher.spec.ts`; API-key billing → `apiKeyLoginBilling.spec.ts`; Add credits on Local → `localCreditsWorkspaceRail.spec.ts`; billing routes → `localCreditsNoSubscribeUi.spec.ts` / `cloud.spec.ts`; Cloud subscribe-to-run → `subscription.spec.ts` + unit gate tests in `useCoreCommands.test.ts`). This was the last gap. (cherry picked from commit 2ab204c)
…gh server capabilities (#16094) Backport of #16067 to `cloud/1.52`. ## Merge order — this PR is stacked Base is deliberately `backport-16046-to-cloud-1.52`, not `cloud/1.52`. GitHub retargets this PR to `cloud/1.52` once its parent merges. `cloud/1.52` → #15799 → #15803 → #15804 → #15675 → #15967 → #16043 → #16046 → #16067 Every commit in this chain cherry-picks cleanly; there are no hand-resolved conflicts anywhere in the stack. ## Verification Run at the tip of the full stack: 93 unit test files, 1745 tests, 0 failures (`src/platform/workspace`, `src/platform/cloud/subscription`, `src/composables/useCoreCommands.test.ts`, `src/components/actionbar`). ## Also carries #16032 and #16041 #16067's unit tests need mocks (`app.queuePrompt`, `trackWorkflowExecution`, `useQueueSettingsStore`) that #16032 introduced, and its run-gate coverage comes from #16041. Both are already backported independently as #16084 and #16059. This branch therefore contains them; whichever lands first makes the other's patch a no-op. Without #16032 the `useCoreCommands` hunks conflict and 8 tests fail. --------- Co-authored-by: comfydesigner <247099495+comfydesigner@users.noreply.github.com>
… workspace (#16041) ## Summary Adds the E2E regression test for #16032 (Run silently doing nothing on Local at 0 credits), driven through the real Run button. ## Why this was missed by E2E `workspaceSwitcherFixture` already models the exact failing state (`is_active: false`, balance 0, Local), but the existing queue test calls `window.app.queuePrompt(0)` directly — bypassing the `Comfy.QueuePrompt` command where the subscribe-to-run gate lives. The QA-reported bug (thread: 1.51 local workspace switcher QA) lived precisely in that skipped layer. ## Changes - **What**: New test in `localWorkspaceSwitcher.spec.ts` that loads the default workflow on an unsubscribed/zero-balance Local workspace, clicks the actual Run button, and asserts `POST /api/prompt` is issued. ## Verification - Passes against current main (real ComfyUI backend + dev server). - Fails against the pre-#16032 gate (`if (!canAccessSubscriptionFeatures.value)` reverted locally): Run click produces no prompt request, test times out — reproducing the QA report. - Full `localWorkspaceSwitcher.spec.ts` (3 tests) green. ## Review Focus - Coverage audit of this QA round: every other reported case already has unit + E2E coverage (race condition → `localWorkspaceSwitcher.spec.ts`; API-key billing → `apiKeyLoginBilling.spec.ts`; Add credits on Local → `localCreditsWorkspaceRail.spec.ts`; billing routes → `localCreditsNoSubscribeUi.spec.ts` / `cloud.spec.ts`; Cloud subscribe-to-run → `subscription.spec.ts` + unit gate tests in `useCoreCommands.test.ts`). This was the last gap.
|
|
|
|
|
|
|
|
|
Summary
Adds the E2E regression test for #16032 (Run silently doing nothing on Local at 0 credits), driven through the real Run button.
Why this was missed by E2E
workspaceSwitcherFixturealready models the exact failing state (is_active: false, balance 0, Local), but the existing queue test callswindow.app.queuePrompt(0)directly — bypassing theComfy.QueuePromptcommand where the subscribe-to-run gate lives. The QA-reported bug (thread: 1.51 local workspace switcher QA) lived precisely in that skipped layer.Changes
localWorkspaceSwitcher.spec.tsthat loads the default workflow on an unsubscribed/zero-balance Local workspace, clicks the actual Run button, and assertsPOST /api/promptis issued.Verification
if (!canAccessSubscriptionFeatures.value)reverted locally): Run click produces no prompt request, test times out — reproducing the QA report.localWorkspaceSwitcher.spec.ts(3 tests) green.Review Focus
localWorkspaceSwitcher.spec.ts; API-key billing →apiKeyLoginBilling.spec.ts; Add credits on Local →localCreditsWorkspaceRail.spec.ts; billing routes →localCreditsNoSubscribeUi.spec.ts/cloud.spec.ts; Cloud subscribe-to-run →subscription.spec.ts+ unit gate tests inuseCoreCommands.test.ts). This was the last gap.