Skip to content

fix(types): drop duplicate CurrentWorkspaceResponse from ingest types - #16085

Merged
dante01yoon merged 1 commit into
cloud/1.52from
fix-ingest-types-dup
Aug 27, 2026
Merged

dante01yoon merged 1 commit into
cloud/1.52from
fix-ingest-types-dup

Conversation

@dante01yoon

Copy link
Copy Markdown
Collaborator

cloud/1.52 does not typecheck. Every PR opened against it is red on a diff it does not own.

packages/ingest-types/src/index.ts(237,3):       error TS2300: Duplicate identifier 'CurrentWorkspaceResponse'.
packages/ingest-types/src/index.ts(240,3):       error TS2300: Duplicate identifier 'CurrentWorkspaceResponse'.
packages/ingest-types/src/types.gen.ts(3263,13): error TS2300: Duplicate identifier 'CurrentWorkspaceResponse'.
packages/ingest-types/src/types.gen.ts(3280,13): error TS2300: Duplicate identifier 'CurrentWorkspaceResponse'.

Confirmed blocked: #16080 and #16084 are both red solely on this.

Root cause

A semantic conflict between two backports — clean for git, broken for TypeScript.

commit PR merged (UTC) CurrentWorkspaceResponse declarations after
c143e62b5 #15953 — establish workspace context for API-key sessions 8/26 04:43 1
d9e00f921 #15939 — ENTERPRISE tier + ingest-types regeneration 8/26 23:36 2

#15953 introduced the type. #15939 regenerated the package from the cloud OpenAPI spec and added it again. Neither touched the same lines, so git reported no conflict and the duplicate landed silently.

CI did not catch it because #15939's checks last ran 8/25 23:33 — roughly 24 hours before it merged, and before #15953 was on the branch. It was green against a merge ref that no longer described reality.

The second block also swallowed the JSDoc belonging to CreateWorkspaceRequest, leaving that type undocumented:

/**
 * Request body for creating a new workspace.
 */
export type CurrentWorkspaceResponse = {   // <- stray

In index.ts the stray re-export is visible as a break in the otherwise alphabetical list (CreateWorkspaceResponse, CurrentWorkspaceResponse, CreateWorkspaceResponses).

Changes

Pure deletion, 15 lines, no additions:

  • types.gen.ts — remove the duplicated CurrentWorkspaceResponse block; the Request body for creating a new workspace. JSDoc returns to CreateWorkspaceRequest
  • index.ts — remove the duplicated re-export

Both files are generated, so the target was not a judgement call: both edited regions are now byte-identical to main, which carries exactly one declaration. This restores the generator's real output rather than hand-authoring it. Re-running pnpm --filter @comfyorg/ingest-types generate against the spec is the alternative and should produce the same result — happy to swap to that if the team prefers a regeneration commit, though it would pull in unrelated spec drift on a release branch.

Verification

tsc on the package, before and after:

### BASE (cloud/1.52)          exit=2   TS2300 x4   <- reproduces the CI failure exactly
### THIS PR                    exit=0   TS2300 x0   total errors 0

Also verified CurrentWorkspaceResponse is the only duplicated identifier in either file, so this is the whole breakage and not the first of several.

Follow-ups (not in this PR)

  1. The stale-merge-base gap. A PR merging on day-old checks is how this shipped. Requiring branches be up to date before merge on cloud/*, or re-running checks on merge, would close it.
  2. pr-backport.yaml discards partial success. Separately, one failing target aborts the whole step, so succeeding targets never get a PR and their pushed branches are deleted in cleanup. That is why fix(billing): gate subscribe-to-run only on Cloud #16032 never reached cloud/1.52 and why [backport cloud/1.52] fix(billing): gate subscribe-to-run only on Cloud #16084 had to be made by hand.

Merge order

This → #16084 (backport of #16032, Run silently does nothing on Local at 0 credits) → #16059 (its E2E regression test).

Two backports each added CurrentWorkspaceResponse to the generated
ingest-types package. #15953 introduced it; #15939 regenerated the
package and added it a second time. Git merged both cleanly, so
cloud/1.52 has carried a duplicate identifier since 15939 landed and
no longer typechecks.

Restores both files to the generator output already on main.
@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Aug 27, 2026
@coderabbitai

coderabbitai Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: bb4c33ee-1f87-4a91-bf48-1f319823b570

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 27, 2026 •

Copy link
Copy Markdown
Contributor

🌐 Website E2E

Caution

Some tests failed.

Status ❌ Failed
Report View Report
Screenshot diffs 0
Other failures 2

Warning

2 non-screenshot failures — these require manual review.

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 08/27/2026, 03:24:31 AM UTC

Links

🎭 Playwright: ✅ 1983 passed, 0 failed · 2 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1962 / ❌ 0 / ⚠️ 2 / ⏭️ 5)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 59.6 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.9 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.0 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.2 MB heap
large-graph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.8 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.9 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.5 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 80.0 MB heap
minimap-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.0 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.5 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.2 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.9 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 139ms TBT · 84.5 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 76.5 MB heap
vue-large-graph-idle: · 57.1 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 172.5 MB heap
vue-large-graph-pan: · 56.2 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 56ms TBT · 180.9 MB heap
workflow-execution: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.6 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 8ms
canvas-idle: layout count 0
canvas-idle: style recalc count 9
canvas-idle: task duration 514ms
canvas-idle: script duration 7ms
canvas-idle: TBT 0ms
canvas-idle: heap used 59.6 MB
canvas-idle: DOM nodes -282
canvas-idle: event listeners -181
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 36ms
canvas-mouse-sweep: layout count 12
canvas-mouse-sweep: style recalc count 74
canvas-mouse-sweep: task duration 893ms
canvas-mouse-sweep: script duration 111ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 65.9 MB
canvas-mouse-sweep: DOM nodes -282
canvas-mouse-sweep: event listeners -152
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 15ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 31
canvas-zoom-sweep: task duration 344ms
canvas-zoom-sweep: script duration 8ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 63.0 MB
canvas-zoom-sweep: DOM nodes 76
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 7ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 12
dom-widget-clipping: task duration 348ms
dom-widget-clipping: script duration 54ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 70.2 MB
dom-widget-clipping: DOM nodes 19
dom-widget-clipping: event listeners 2
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 9ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 10
large-graph-idle: task duration 610ms
large-graph-idle: script duration 14ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 65.8 MB
large-graph-idle: DOM nodes -277
large-graph-idle: event listeners -165
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 15ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 70
large-graph-pan: task duration 1185ms
large-graph-pan: script duration 337ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 68.9 MB
large-graph-pan: DOM nodes -275
large-graph-pan: event listeners -147
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 7ms
large-graph-zoom: style recalc duration 15ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 66
large-graph-zoom: task duration 1372ms
large-graph-zoom: script duration 401ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 63.5 MB
large-graph-zoom: DOM nodes -287
large-graph-zoom: event listeners -154
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 9ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 45
legacy-node-drag: task duration 1384ms
legacy-node-drag: script duration 454ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 80.0 MB
legacy-node-drag: DOM nodes 10
legacy-node-drag: event listeners 185
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 7ms
minimap-idle: layout count 0
minimap-idle: style recalc count 8
minimap-idle: task duration 589ms
minimap-idle: script duration 13ms
minimap-idle: TBT 0ms
minimap-idle: heap used 69.0 MB
minimap-idle: DOM nodes -281
minimap-idle: event listeners -148
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 9ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 46
subgraph-dom-widget-clipping: task duration 376ms
subgraph-dom-widget-clipping: script duration 114ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 71.5 MB
subgraph-dom-widget-clipping: DOM nodes 18
subgraph-dom-widget-clipping: event listeners 7
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 9ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 10
subgraph-idle: task duration 474ms
subgraph-idle: script duration 6ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 65.2 MB
subgraph-idle: DOM nodes -281
subgraph-idle: event listeners -151
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 4ms
subgraph-mouse-sweep: style recalc duration 34ms
subgraph-mouse-sweep: layout count 16
subgraph-mouse-sweep: style recalc count 76
subgraph-mouse-sweep: task duration 780ms
subgraph-mouse-sweep: script duration 84ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 67.9 MB
subgraph-mouse-sweep: DOM nodes -281
subgraph-mouse-sweep: event listeners -167
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 14ms
subgraph-transition-enter: style recalc duration 31ms
subgraph-transition-enter: layout count 15
subgraph-transition-enter: style recalc count 20
subgraph-transition-enter: task duration 881ms
subgraph-transition-enter: script duration 16ms
subgraph-transition-enter: TBT 139ms
subgraph-transition-enter: heap used 84.5 MB
subgraph-transition-enter: DOM nodes 13673
subgraph-transition-enter: event listeners 2375
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 37ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 252
viewport-pan-sweep: task duration 4049ms
viewport-pan-sweep: script duration 1031ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 76.5 MB
viewport-pan-sweep: DOM nodes -271
viewport-pan-sweep: event listeners -134
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 15825ms
vue-large-graph-idle: script duration 106ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 172.5 MB
vue-large-graph-idle: DOM nodes -8312
vue-large-graph-idle: event listeners -16392
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 16ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 172
vue-large-graph-pan: task duration 19781ms
vue-large-graph-pan: script duration 397ms
vue-large-graph-pan: TBT 56ms
vue-large-graph-pan: heap used 180.9 MB
vue-large-graph-pan: DOM nodes -8312
vue-large-graph-pan: event listeners -16388
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 18ms
workflow-execution: layout count 3
workflow-execution: style recalc count 14
workflow-execution: task duration 94ms
workflow-execution: script duration 7ms
workflow-execution: TBT 0ms
workflow-execution: heap used 63.6 MB
workflow-execution: DOM nodes 129
workflow-execution: event listeners 74
Raw data
{
  "timestamp": "2026-08-27T03:35:35.179Z",
  "gitSha": "bd12baf6ab53161144f57e0be1be2c9fc85c3d50",
  "branch": "fix-ingest-types-dup",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2055.078999999978,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.308000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 545.945,
      "heapDeltaBytes": 832740,
      "heapUsedBytes": 62975772,
      "domNodes": -281,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 8.287,
      "eventListeners": -181,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2015.7489999999143,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 7.226000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 482.49800000000005,
      "heapDeltaBytes": -155988,
      "heapUsedBytes": 62109788,
      "domNodes": -282,
      "jsHeapTotalBytes": 4186112,
      "scriptDurationMs": 6.322000000000001,
      "eventListeners": -181,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 2037.3799999999846,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 38.055,
      "layouts": 12,
      "layoutDurationMs": 3.5590000000000006,
      "taskDurationMs": 948.9130000000001,
      "heapDeltaBytes": 20109416,
      "heapUsedBytes": 82006884,
      "domNodes": -284,
      "jsHeapTotalBytes": 4448256,
      "scriptDurationMs": 115.40799999999999,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1806.308999999942,
      "styleRecalcs": 73,
      "styleRecalcDurationMs": 33.09,
      "layouts": 12,
      "layoutDurationMs": 3.604,
      "taskDurationMs": 836.8059999999999,
      "heapDeltaBytes": -6761032,
      "heapUsedBytes": 56237908,
      "domNodes": -280,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 106.298,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1682.4630000000411,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 15.703000000000001,
      "layouts": 6,
      "layoutDurationMs": 0.503,
      "taskDurationMs": 341.068,
      "heapDeltaBytes": 3240240,
      "heapUsedBytes": 66325592,
      "domNodes": 76,
      "jsHeapTotalBytes": 4718592,
      "scriptDurationMs": 8.347999999999999,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1724.7029999999768,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 15.190999999999999,
      "layouts": 6,
      "layoutDurationMs": 0.5790000000000001,
      "taskDurationMs": 347.63899999999995,
      "heapDeltaBytes": 3031572,
      "heapUsedBytes": 65792724,
      "domNodes": 75,
      "jsHeapTotalBytes": 4456448,
      "scriptDurationMs": 8.307,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 579.3209999999931,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 8.166999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 349.815,
      "heapDeltaBytes": 10995340,
      "heapUsedBytes": 73468140,
      "domNodes": 20,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 53.60399999999999,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 568.9609999999448,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 6.612000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 346.56399999999996,
      "heapDeltaBytes": 10774940,
      "heapUsedBytes": 73807116,
      "domNodes": 18,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 53.9,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2040.3009999999995,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.972999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 603.553,
      "heapDeltaBytes": -12152668,
      "heapUsedBytes": 64118444,
      "domNodes": -281,
      "jsHeapTotalBytes": 4186112,
      "scriptDurationMs": 14.150000000000002,
      "eventListeners": -179,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2058.8089999999966,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 9.586,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 617.4139999999999,
      "heapDeltaBytes": -3582904,
      "heapUsedBytes": 73904616,
      "domNodes": -272,
      "jsHeapTotalBytes": -1843200,
      "scriptDurationMs": 13.952999999999996,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2182.1620000000053,
      "styleRecalcs": 70,
      "styleRecalcDurationMs": 15.971999999999996,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1177.804,
      "heapDeltaBytes": -5544292,
      "heapUsedBytes": 72456968,
      "domNodes": -275,
      "jsHeapTotalBytes": -45056,
      "scriptDurationMs": 337.23600000000005,
      "eventListeners": -147,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2187.196999999969,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 14.373000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1191.2589999999998,
      "heapDeltaBytes": -5935240,
      "heapUsedBytes": 72114712,
      "domNodes": -275,
      "jsHeapTotalBytes": -307200,
      "scriptDurationMs": 337.09299999999996,
      "eventListeners": -147,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3182.169999999985,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 15.585,
      "layouts": 60,
      "layoutDurationMs": 7.248,
      "taskDurationMs": 1388.371,
      "heapDeltaBytes": -10860312,
      "heapUsedBytes": 67924276,
      "domNodes": -287,
      "jsHeapTotalBytes": 6545408,
      "scriptDurationMs": 410.78999999999996,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3130.5019999999786,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 13.822000000000001,
      "layouts": 60,
      "layoutDurationMs": 7.268000000000001,
      "taskDurationMs": 1355.0469999999998,
      "heapDeltaBytes": -14003772,
      "heapUsedBytes": 65199000,
      "domNodes": -287,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 391.356,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2180.4860000000303,
      "styleRecalcs": 45,
      "styleRecalcDurationMs": 9.153999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1375.8089999999997,
      "heapDeltaBytes": 12008892,
      "heapUsedBytes": 97388964,
      "domNodes": 10,
      "jsHeapTotalBytes": 9105408,
      "scriptDurationMs": 453.348,
      "eventListeners": 186,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2137.7080000000888,
      "styleRecalcs": 45,
      "styleRecalcDurationMs": 8.756,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1391.206,
      "heapDeltaBytes": -14310828,
      "heapUsedBytes": 70398664,
      "domNodes": 10,
      "jsHeapTotalBytes": 6852608,
      "scriptDurationMs": 455.221,
      "eventListeners": 184,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "minimap-idle",
      "durationMs": 2045.754000000045,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 7.451,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 598.835,
      "heapDeltaBytes": -10666020,
      "heapUsedBytes": 72938084,
      "domNodes": -280,
      "jsHeapTotalBytes": 3923968,
      "scriptDurationMs": 13.752999999999998,
      "eventListeners": -147,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2044.3740000000616,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 5.568,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 580.0490000000001,
      "heapDeltaBytes": -11793852,
      "heapUsedBytes": 71838292,
      "domNodes": -282,
      "jsHeapTotalBytes": 4186112,
      "scriptDurationMs": 12.34,
      "eventListeners": -149,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 572.6160000000391,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 9.299999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 376.985,
      "heapDeltaBytes": 11755756,
      "heapUsedBytes": 74962056,
      "domNodes": 18,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 113.21400000000001,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 578.6930000000439,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 9.637,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 375.42999999999995,
      "heapDeltaBytes": 11869552,
      "heapUsedBytes": 74893564,
      "domNodes": 18,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 114.773,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2007.6350000000502,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 8.372,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 472.904,
      "heapDeltaBytes": 18147008,
      "heapUsedBytes": 80713976,
      "domNodes": -279,
      "jsHeapTotalBytes": 4448256,
      "scriptDurationMs": 5.568,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 1998.2760000000326,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 8.765,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 474.4200000000001,
      "heapDeltaBytes": -6565936,
      "heapUsedBytes": 55964628,
      "domNodes": -282,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 5.889999999999998,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1722.59200000002,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 33.401,
      "layouts": 16,
      "layoutDurationMs": 3.999,
      "taskDurationMs": 785.342,
      "heapDeltaBytes": 2512508,
      "heapUsedBytes": 65561820,
      "domNodes": -281,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 85.264,
      "eventListeners": -183,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1737.8130000000738,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 34.811,
      "layouts": 16,
      "layoutDurationMs": 3.838,
      "taskDurationMs": 774.5340000000001,
      "heapDeltaBytes": 13917292,
      "heapUsedBytes": 76738780,
      "domNodes": -281,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 82.419,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1399.6400000000904,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 31.262000000000004,
      "layouts": 15,
      "layoutDurationMs": 14.155000000000001,
      "taskDurationMs": 881.3220000000001,
      "heapDeltaBytes": -6130328,
      "heapUsedBytes": 88607264,
      "domNodes": 13673,
      "jsHeapTotalBytes": 12845056,
      "scriptDurationMs": 15.876999999999995,
      "eventListeners": 2375,
      "totalBlockingTimeMs": 139,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8220.687999999995,
      "styleRecalcs": 251,
      "styleRecalcDurationMs": 37.339999999999996,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4070.341,
      "heapDeltaBytes": 3078956,
      "heapUsedBytes": 80031540,
      "domNodes": -271,
      "jsHeapTotalBytes": -45056,
      "scriptDurationMs": 1029.992,
      "eventListeners": -135,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8277.899999999932,
      "styleRecalcs": 252,
      "styleRecalcDurationMs": 37.431,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4028.645,
      "heapDeltaBytes": 3182508,
      "heapUsedBytes": 80327444,
      "domNodes": -270,
      "jsHeapTotalBytes": -45056,
      "scriptDurationMs": 1031.191,
      "eventListeners": -133,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 16748.38600000004,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16044.342,
      "heapDeltaBytes": -31387620,
      "heapUsedBytes": 181068036,
      "domNodes": -8312,
      "jsHeapTotalBytes": -15818752,
      "scriptDurationMs": 109.058,
      "eventListeners": -16389,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 16635.063999999944,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 15606.616,
      "heapDeltaBytes": -44885044,
      "heapUsedBytes": 180662524,
      "domNodes": -8312,
      "jsHeapTotalBytes": -18391040,
      "scriptDurationMs": 102.89899999999999,
      "eventListeners": -16395,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 20639.178000000073,
      "styleRecalcs": 171,
      "styleRecalcDurationMs": 16.61499999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20035.08,
      "heapDeltaBytes": -32000812,
      "heapUsedBytes": 193103828,
      "domNodes": -8312,
      "jsHeapTotalBytes": -17149952,
      "scriptDurationMs": 397.331,
      "eventListeners": -16389,
      "totalBlockingTimeMs": 93,
      "frameDurationMs": 17.776666666666763,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 19985.20300000007,
      "styleRecalcs": 172,
      "styleRecalcDurationMs": 16.367999999999995,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 19527.299,
      "heapDeltaBytes": -39560632,
      "heapUsedBytes": 186284024,
      "domNodes": -8312,
      "jsHeapTotalBytes": -19513344,
      "scriptDurationMs": 396.77099999999996,
      "eventListeners": -16387,
      "totalBlockingTimeMs": 18,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "workflow-execution",
      "durationMs": 110.13300000001891,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 15.231000000000002,
      "layouts": 2,
      "layoutDurationMs": 0.9579999999999999,
      "taskDurationMs": 80.13199999999998,
      "heapDeltaBytes": 3233984,
      "heapUsedBytes": 65749420,
      "domNodes": 114,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 5.929999999999998,
      "eventListeners": 49,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "workflow-execution",
      "durationMs": 472.1509999999398,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 21.726999999999997,
      "layouts": 3,
      "layoutDurationMs": 1.3880000000000001,
      "taskDurationMs": 108.69199999999998,
      "heapDeltaBytes": 5117876,
      "heapUsedBytes": 67669912,
      "domNodes": 143,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 7.463999999999999,
      "eventListeners": 99,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    }
  ]
}

@codecov

codecov Bot commented Aug 27, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@              Coverage Diff              @@
##             cloud/1.52   #16085   +/-   ##
=============================================
  Coverage              ?   79.58%           
=============================================
  Files                 ?     2240           
  Lines                 ?   114659           
  Branches              ?    31730           
=============================================
  Hits                  ?    91246           
  Misses                ?    22932           
  Partials              ?      481           
Flag Coverage Δ
e2e 66.24% <ø> (?)
unit 73.93% <ø> (?)
website-unit 27.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot added the risk:R2 PR risk grade (advisory shadow check; grader-owned) label Aug 27, 2026
@dante01yoon
dante01yoon merged commit d14bb0d into cloud/1.52 Aug 27, 2026
81 of 82 checks passed
@dante01yoon
dante01yoon deleted the fix-ingest-types-dup branch August 27, 2026 03:41
@dante01yoon

Copy link
Copy Markdown
Collaborator Author

Diagnosis of the one remaining red (website-e2e): a second, unrelated pre-existing breakage on cloud/1.52. Fixed in #16086.

apps/website/e2e/events.spec.ts — past events gallery / mobile stack
Expected: 11   Received: 10

PastEventsSection.vue drops past events with no artwork (if (!media) return []), but the spec asserts toHaveCount(pastEvents.length) — the unfiltered count. The local-mcp livestream ended 2026-08-26T18:00:00Z and has no media on this branch (it does on main), so from that moment the page renders 10 cards against 11 past events.

It surfaced here rather than on #16084 or #16059 because website-e2e is path-filtered: those PRs touch neither apps/website nor packages/**, so the job was SKIPPED on both. This PR touches packages/ingest-types, which is inside the filter, so it is the first cloud/1.52 PR since 18:00 UTC to actually run it.

Nothing to change here — this PR touches only packages/ingest-types/**, and #16086 restores the missing entry.

The two fixes are mutually blocked: this PR is red on #16086's breakage, #16086 is red on this one's. They are independent, so either can merge first; the second then just needs its branch updated to go green.

Full order once both land: #16085 + #16086 → #16084 → #16059.

pull Bot pushed a commit to Mu-L/ComfyUI_frontend that referenced this pull request Aug 27, 2026
## Summary

Prevent release branches from accepting merge-skew type failures without
ownership.

## Changes

- run the application typecheck in the shared PR, merge-queue, and
post-merge verification path
- alert `#frontend-releases` when that check fails after a
release-branch push
- document that ingest types must be generated from the Cloud contract,
never hand-written during backports

## Review Focus

The alert is limited to failed push runs on `cloud/**` and `core/**`; PR
and merge-queue failures do not notify Slack.

## Verification

- `pnpm typecheck`
- oxfmt check on changed files
- actionlint on the new workflow

Related: Comfy-Org#16085
mattmillerai pushed a commit that referenced this pull request Aug 29, 2026
## Summary

Prevent release branches from accepting merge-skew type failures without
ownership.

## Changes

- run the application typecheck in the shared PR, merge-queue, and
post-merge verification path
- alert `#frontend-releases` when that check fails after a
release-branch push
- document that ingest types must be generated from the Cloud contract,
never hand-written during backports

## Review Focus

The alert is limited to failed push runs on `cloud/**` and `core/**`; PR
and merge-queue failures do not notify Slack.

## Verification

- `pnpm typecheck`
- oxfmt check on changed files
- actionlint on the new workflow

Related: #16085
@huang47 huang47 added the risk:high PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026 — with ChatGPT Codex Connector
@huang47 huang47 removed the risk:R2 PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:high PR risk grade (advisory shadow check; grader-owned) size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants