Repository navigation
fix(website): restore card art for the Local MCP past event - #16086
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🌐 Website E2ETip All tests passed.
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.52 #16086 +/- ##
=============================================
Coverage ? 79.54%
=============================================
Files ? 2235
Lines ? 113629
Branches ? 31062
=============================================
Hits ? 90386
Misses ? 22764
Partials ? 479
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
This PR touches one file, These two PRs are mutually blocked
They are independent, so either can merge first; the second just needs its branch updated to pick up the first, and it goes green. No stacking or retargeting required. Not pushing anything here — the diff is correct and verified, and a retrigger would only reproduce the same base failure. |
The past-events gallery drops any event without media, since a card cannot render without it. local-mcp ended 2026-08-26T18:00Z and carries no media on this branch, so the section renders 10 cards while the page data lists 11 past events, failing the events e2e on cloud/1.52. Adds the media entry already present on main.
769e2d4 to
5e6fcc5
Compare
website-e2ehas been failing oncloud/1.52since 2026-08-26 18:00 UTC. Two tests inapps/website/e2e/events.spec.ts:Root cause
PastEventsSection.vuedrops any past event that has no artwork — a card cannot render without media:The spec asserts against the unfiltered list instead:
expect(cards).toHaveCount(pastEvents.length). The two agree only while every past event has media.The
local-mcplivestream ended2026-08-26T18:00:00Zand carries nomediaon this branch, so from that moment the page rendered 10 cards against 11 past events.mainalready has the entry;cloud/1.52does not.Why it surfaced only now
website-e2eis path-filtered. The cloud PRs that merged after 18:00 UTC (#16084, #16059) touch neitherapps/websitenorpackages/**, so the job wasSKIPPEDon both. #16085 touchespackages/ingest-types, which is inside the filter — it is the first PR since 18:00 UTC to actually run the job, so it inherited the red.Changes
Adds the
mediaentrymainalready carries, verbatim.eventImageresolves tohttps://media.comfy.org/website/events/…, so no asset is added to the repo.Verification
Replaying the component's own derivation (past events, then media filter) at the failing run's timestamp:
Follow-up for
main(not this PR)The spec is load-bearing on content: any livestream that ends before its card art is added breaks CI, which is precisely the case
PastEventsSection.vuecomments about ("events that became past before dedicated card art was added"). Asserting against the media-bearing subset the component actually renders would remove the whole class of failure. That belongs onmainand should flow down rather than be invented on a release branch.Related
cloud/1.52is also failing typecheck on a duplicate identifier in the generated ingest types — separate breakage, fixed in #16085. This PR and that one are independent; both targetcloud/1.52.