Skip to content

fix(website): restore card art for the Local MCP past event - #16086

Merged
christian-byrne merged 1 commit into
cloud/1.52from
fix-website-local-mcp-media
Sep 27, 2026
Merged

christian-byrne merged 1 commit into
cloud/1.52from
fix-website-local-mcp-media

Conversation

@dante01yoon

Copy link
Copy Markdown
Collaborator

website-e2e has been failing on cloud/1.52 since 2026-08-26 18:00 UTC. Two tests in apps/website/e2e/events.spec.ts:

past events gallery renders one card per event with WATCH NOW links  [desktop]
past event cards stack in a single column at mobile width            [mobile]

Expected: 11
Received: 10

Root cause

PastEventsSection.vue drops any past event that has no artwork — a card cannot render without media:

const media = event.media ?? event.featured?.media
if (!media) return []

The spec asserts against the unfiltered list instead: expect(cards).toHaveCount(pastEvents.length). The two agree only while every past event has media.

The local-mcp livestream ended 2026-08-26T18:00:00Z and carries no media on this branch, so from that moment the page rendered 10 cards against 11 past events. main already has the entry; cloud/1.52 does not.

Why it surfaced only now

website-e2e is path-filtered. The cloud PRs that merged after 18:00 UTC (#16084, #16059) touch neither apps/website nor packages/**, so the job was SKIPPED on both. #16085 touches packages/ingest-types, which is inside the filter — it is the first PR since 18:00 UTC to actually run the job, so it inherited the red.

Changes

Adds the media entry main already carries, verbatim. eventImage resolves to https://media.comfy.org/website/events/…, so no asset is added to the repo.

Verification

Replaying the component's own derivation (past events, then media filter) at the failing run's timestamp:

cloud/1.52 (base)      test expects 11 | page renders 10 | FAIL   <- reproduces CI exactly
this fix               test expects 11 | page renders 11 | PASS
main (reference)       test expects 11 | page renders 11 | PASS

Follow-up for main (not this PR)

The spec is load-bearing on content: any livestream that ends before its card art is added breaks CI, which is precisely the case PastEventsSection.vue comments about ("events that became past before dedicated card art was added"). Asserting against the media-bearing subset the component actually renders would remove the whole class of failure. That belongs on main and should flow down rather than be invented on a release branch.

Related

cloud/1.52 is also failing typecheck on a duplicate identifier in the generated ingest types — separate breakage, fixed in #16085. This PR and that one are independent; both target cloud/1.52.

@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Aug 27, 2026
@coderabbitai

coderabbitai Bot commented Aug 27, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 342fb521-35de-4876-b325-bcb6866ac3ab

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 27, 2026 •

Copy link
Copy Markdown
Contributor

🌐 Website E2E

Tip

All tests passed.

Status ✅ Passed
Report View Report

@codecov

codecov Bot commented Aug 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@              Coverage Diff              @@
##             cloud/1.52   #16086   +/-   ##
=============================================
  Coverage              ?   79.54%           
=============================================
  Files                 ?     2235           
  Lines                 ?   113629           
  Branches              ?    31062           
=============================================
  Hits                  ?    90386           
  Misses                ?    22764           
  Partials              ?      479           
Flag Coverage Δ
website-unit 27.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
apps/website/src/data/events.ts 88.88% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot added the risk:R2 PR risk grade (advisory shadow check; grader-owned) label Aug 27, 2026
@dante01yoon

Copy link
Copy Markdown
Collaborator Author

website-e2e is green here — that was the point of this PR. The one remaining red, lint-and-format, is inherited from cloud/1.52 and is fixed by #16085.

packages/ingest-types/src/types.gen.ts:3263:13:
  Identifier `CurrentWorkspaceResponse` has already been declared

This PR touches one file, apps/website/src/data/events.ts (+5/-1). Nothing under packages/.

These two PRs are mutually blocked

PR fixes only failing check fixed by
#16085 duplicate identifier in generated ingest types website-e2e this PR
this PR missing card art for a past event lint-and-format #16085

cloud/1.52 broke twice yesterday, in unrelated subsystems, and each fix trips over the other's breakage. Neither can go fully green on its own branch.

They are independent, so either can merge first; the second just needs its branch updated to pick up the first, and it goes green. No stacking or retargeting required.

Not pushing anything here — the diff is correct and verified, and a retrigger would only reproduce the same base failure.

The past-events gallery drops any event without media, since a card
cannot render without it. local-mcp ended 2026-08-26T18:00Z and carries
no media on this branch, so the section renders 10 cards while the page
data lists 11 past events, failing the events e2e on cloud/1.52.

Adds the media entry already present on main.
@jtydhr88 jtydhr88 removed their assignment Aug 28, 2026
@huang47 huang47 added the risk:high PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026 — with ChatGPT Codex Connector
@huang47 huang47 removed the risk:R2 PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026
@christian-byrne
christian-byrne added this pull request to the merge queue Sep 27, 2026
Merged via the queue into cloud/1.52 with commit ebc9009 Sep 27, 2026
61 checks passed
@christian-byrne
christian-byrne deleted the fix-website-local-mcp-media branch September 27, 2026 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:high PR risk grade (advisory shadow check; grader-owned) size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants