Repository navigation
[backport core/1.52] test(e2e): cover Run through the real button on an unsubscribed Local workspace - #16058
Conversation
… workspace (#16041) ## Summary Adds the E2E regression test for #16032 (Run silently doing nothing on Local at 0 credits), driven through the real Run button. ## Why this was missed by E2E `workspaceSwitcherFixture` already models the exact failing state (`is_active: false`, balance 0, Local), but the existing queue test calls `window.app.queuePrompt(0)` directly — bypassing the `Comfy.QueuePrompt` command where the subscribe-to-run gate lives. The QA-reported bug (thread: 1.51 local workspace switcher QA) lived precisely in that skipped layer. ## Changes - **What**: New test in `localWorkspaceSwitcher.spec.ts` that loads the default workflow on an unsubscribed/zero-balance Local workspace, clicks the actual Run button, and asserts `POST /api/prompt` is issued. ## Verification - Passes against current main (real ComfyUI backend + dev server). - Fails against the pre-#16032 gate (`if (!canAccessSubscriptionFeatures.value)` reverted locally): Run click produces no prompt request, test times out — reproducing the QA report. - Full `localWorkspaceSwitcher.spec.ts` (3 tests) green. ## Review Focus - Coverage audit of this QA round: every other reported case already has unit + E2E coverage (race condition → `localWorkspaceSwitcher.spec.ts`; API-key billing → `apiKeyLoginBilling.spec.ts`; Add credits on Local → `localCreditsWorkspaceRail.spec.ts`; billing routes → `localCreditsNoSubscribeUi.spec.ts` / `cloud.spec.ts`; Cloud subscribe-to-run → `subscription.spec.ts` + unit gate tests in `useCoreCommands.test.ts`). This was the last gap.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🎭 Playwright: ✅ 1984 passed, 0 failed · 2 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-08-26T21:42:52.271Z",
"gitSha": "44f3aa6b70b94ae532cbf8151682a1e51be280d3",
"branch": "backport-16041-to-core-1.52",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2017.2929999999951,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.000000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 526.374,
"heapDeltaBytes": 11802568,
"heapUsedBytes": 74065456,
"domNodes": -283,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 8.238999999999997,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2052.85200000003,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.770999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 606.939,
"heapDeltaBytes": 17890484,
"heapUsedBytes": 80005412,
"domNodes": -286,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 11.040999999999999,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2091.015999999968,
"styleRecalcs": 78,
"styleRecalcDurationMs": 44.867999999999995,
"layouts": 12,
"layoutDurationMs": 3.742,
"taskDurationMs": 1022.0859999999998,
"heapDeltaBytes": -1295132,
"heapUsedBytes": 61056304,
"domNodes": -280,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 123.79,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1906.4620000000332,
"styleRecalcs": 76,
"styleRecalcDurationMs": 42.24999999999999,
"layouts": 12,
"layoutDurationMs": 3.538,
"taskDurationMs": 959.7860000000001,
"heapDeltaBytes": -4871828,
"heapUsedBytes": 57617616,
"domNodes": -282,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 126.19999999999997,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1723.8419999999905,
"styleRecalcs": 30,
"styleRecalcDurationMs": 17.156,
"layouts": 6,
"layoutDurationMs": 0.5419999999999999,
"taskDurationMs": 377.136,
"heapDeltaBytes": 3202388,
"heapUsedBytes": 65917412,
"domNodes": 75,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 11.312,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1731.002999999987,
"styleRecalcs": 30,
"styleRecalcDurationMs": 19.130000000000003,
"layouts": 6,
"layoutDurationMs": 0.6759999999999999,
"taskDurationMs": 436.644,
"heapDeltaBytes": 3314584,
"heapUsedBytes": 65682252,
"domNodes": 76,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 13.943000000000001,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 600.9070000000065,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.384999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 385.74399999999997,
"heapDeltaBytes": 10879484,
"heapUsedBytes": 73848632,
"domNodes": 16,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 57.83200000000001,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 598.9699999998948,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.063999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 365.026,
"heapDeltaBytes": 10942752,
"heapUsedBytes": 73101912,
"domNodes": 18,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 63.08499999999999,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2088.37699999998,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.333,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 693.267,
"heapDeltaBytes": -5043680,
"heapUsedBytes": 72095740,
"domNodes": -280,
"jsHeapTotalBytes": -1052672,
"scriptDurationMs": 17.601,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2069.7059999999965,
"styleRecalcs": 7,
"styleRecalcDurationMs": 8.062999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 739.436,
"heapDeltaBytes": -4065088,
"heapUsedBytes": 73175388,
"domNodes": -278,
"jsHeapTotalBytes": -1839104,
"scriptDurationMs": 19.107,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2283.555999999976,
"styleRecalcs": 69,
"styleRecalcDurationMs": 15.368,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1315.184,
"heapDeltaBytes": -5735884,
"heapUsedBytes": 72005152,
"domNodes": -281,
"jsHeapTotalBytes": -565248,
"scriptDurationMs": 359.32499999999993,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2503.347000000076,
"styleRecalcs": 69,
"styleRecalcDurationMs": 16.596999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1392.696,
"heapDeltaBytes": -7884852,
"heapUsedBytes": 70131400,
"domNodes": -277,
"jsHeapTotalBytes": 221184,
"scriptDurationMs": 392.87100000000004,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-zoom",
"durationMs": 3329.9309999999878,
"styleRecalcs": 65,
"styleRecalcDurationMs": 16.058000000000003,
"layouts": 60,
"layoutDurationMs": 7.719,
"taskDurationMs": 1488.2790000000002,
"heapDeltaBytes": -4442944,
"heapUsedBytes": 73957804,
"domNodes": -289,
"jsHeapTotalBytes": 6287360,
"scriptDurationMs": 420.988,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3250.222000000008,
"styleRecalcs": 64,
"styleRecalcDurationMs": 14.107000000000001,
"layouts": 60,
"layoutDurationMs": 7.312000000000001,
"taskDurationMs": 1478.546,
"heapDeltaBytes": -1876676,
"heapUsedBytes": 77472112,
"domNodes": -274,
"jsHeapTotalBytes": -1576960,
"scriptDurationMs": 405.354,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2321.5070000000537,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.212999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1472.7259999999999,
"heapDeltaBytes": 11826176,
"heapUsedBytes": 91848280,
"domNodes": 12,
"jsHeapTotalBytes": 7532544,
"scriptDurationMs": 482.55,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2646.93699999998,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.209,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1559.155,
"heapDeltaBytes": -15461188,
"heapUsedBytes": 69912764,
"domNodes": 12,
"jsHeapTotalBytes": 8425472,
"scriptDurationMs": 484.569,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2074.09100000001,
"styleRecalcs": 8,
"styleRecalcDurationMs": 9.163,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 697.199,
"heapDeltaBytes": -11379528,
"heapUsedBytes": 73808364,
"domNodes": -278,
"jsHeapTotalBytes": 3141632,
"scriptDurationMs": 17.871,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2058.7130000000116,
"styleRecalcs": 8,
"styleRecalcDurationMs": 9.341999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 739.082,
"heapDeltaBytes": -12427372,
"heapUsedBytes": 72969256,
"domNodes": -279,
"jsHeapTotalBytes": 4190208,
"scriptDurationMs": 19.942999999999998,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 628.2720000000381,
"styleRecalcs": 46,
"styleRecalcDurationMs": 11.887,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 425.67699999999996,
"heapDeltaBytes": 11840336,
"heapUsedBytes": 74473144,
"domNodes": 18,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 127.998,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 634.9599999999782,
"styleRecalcs": 44,
"styleRecalcDurationMs": 9.697000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 426.435,
"heapDeltaBytes": 11912132,
"heapUsedBytes": 74703332,
"domNodes": 14,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 124.431,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2015.3020000000197,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.657000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 571.066,
"heapDeltaBytes": -6828224,
"heapUsedBytes": 55631524,
"domNodes": -280,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 9.216000000000001,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2017.1960000000126,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.377999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 594.668,
"heapDeltaBytes": -4474880,
"heapUsedBytes": 58207464,
"domNodes": -282,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 10.146,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1779.1789999999992,
"styleRecalcs": 77,
"styleRecalcDurationMs": 42.494,
"layouts": 16,
"layoutDurationMs": 8.1,
"taskDurationMs": 871.267,
"heapDeltaBytes": 3368016,
"heapUsedBytes": 65926768,
"domNodes": -281,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 94.567,
"eventListeners": -181,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1739.953000000014,
"styleRecalcs": 75,
"styleRecalcDurationMs": 40.332,
"layouts": 16,
"layoutDurationMs": 4.869,
"taskDurationMs": 894.3030000000001,
"heapDeltaBytes": 17628916,
"heapUsedBytes": 80632976,
"domNodes": -280,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 97.26799999999999,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1417.5020000000131,
"styleRecalcs": 19,
"styleRecalcDurationMs": 34.142,
"layouts": 14,
"layoutDurationMs": 15.618,
"taskDurationMs": 1047.378,
"heapDeltaBytes": -8020068,
"heapUsedBytes": 84298232,
"domNodes": 13673,
"jsHeapTotalBytes": 11534336,
"scriptDurationMs": 20.310999999999996,
"eventListeners": 2375,
"totalBlockingTimeMs": 156,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8414.702000000034,
"styleRecalcs": 249,
"styleRecalcDurationMs": 37.39099999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4369.248,
"heapDeltaBytes": -5060096,
"heapUsedBytes": 72252232,
"domNodes": -282,
"jsHeapTotalBytes": 4677632,
"scriptDurationMs": 1066.9759999999999,
"eventListeners": -163,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8949.114000000009,
"styleRecalcs": 250,
"styleRecalcDurationMs": 40.503,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4639.669,
"heapDeltaBytes": 745848,
"heapUsedBytes": 78059432,
"domNodes": -276,
"jsHeapTotalBytes": 221184,
"scriptDurationMs": 1118.705,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 18142.55400000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17231.177,
"heapDeltaBytes": -49763180,
"heapUsedBytes": 181775188,
"domNodes": -8312,
"jsHeapTotalBytes": -15757312,
"scriptDurationMs": 132.34500000000003,
"eventListeners": -16393,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17860.22300000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16984.483,
"heapDeltaBytes": -34115728,
"heapUsedBytes": 177963928,
"domNodes": -8312,
"jsHeapTotalBytes": -13717504,
"scriptDurationMs": 128.35000000000002,
"eventListeners": -16389,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 21707.611999999983,
"styleRecalcs": 165,
"styleRecalcDurationMs": 20.57600000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21072.755,
"heapDeltaBytes": -35081500,
"heapUsedBytes": 196703444,
"domNodes": -8312,
"jsHeapTotalBytes": -20176896,
"scriptDurationMs": 509.78999999999996,
"eventListeners": -16383,
"totalBlockingTimeMs": 159,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21191.287999999986,
"styleRecalcs": 177,
"styleRecalcDurationMs": 19.865000000000023,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20659.705,
"heapDeltaBytes": -37356356,
"heapUsedBytes": 193047852,
"domNodes": -8312,
"jsHeapTotalBytes": -18493440,
"scriptDurationMs": 503.994,
"eventListeners": -16383,
"totalBlockingTimeMs": 143,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 112.31799999995928,
"styleRecalcs": 10,
"styleRecalcDurationMs": 16.285,
"layouts": 2,
"layoutDurationMs": 0.33900000000000013,
"taskDurationMs": 84.612,
"heapDeltaBytes": 3209364,
"heapUsedBytes": 65718836,
"domNodes": 113,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.091000000000002,
"eventListeners": 49,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 113.933999999972,
"styleRecalcs": 8,
"styleRecalcDurationMs": 16.765,
"layouts": 3,
"layoutDurationMs": 1.453,
"taskDurationMs": 82.539,
"heapDeltaBytes": 3097188,
"heapUsedBytes": 65391928,
"domNodes": 110,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 5.475000000000002,
"eventListeners": 49,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
} |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.52 #16058 +/- ##
=============================================
- Coverage 81.98% 81.98% -0.01%
=============================================
Files 1905 1905
Lines 108794 108793 -1
Branches 30151 29683 -468
=============================================
- Hits 89197 89195 -2
- Misses 19259 19263 +4
+ Partials 338 335 -3
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Backport of #16041 to
core/1.52Automatically created by backport workflow.