Repository navigation
[backport core/1.51] test(e2e): cover Run through the real button on an unsubscribed Local workspace - #16057
Conversation
… workspace (#16041) ## Summary Adds the E2E regression test for #16032 (Run silently doing nothing on Local at 0 credits), driven through the real Run button. ## Why this was missed by E2E `workspaceSwitcherFixture` already models the exact failing state (`is_active: false`, balance 0, Local), but the existing queue test calls `window.app.queuePrompt(0)` directly — bypassing the `Comfy.QueuePrompt` command where the subscribe-to-run gate lives. The QA-reported bug (thread: 1.51 local workspace switcher QA) lived precisely in that skipped layer. ## Changes - **What**: New test in `localWorkspaceSwitcher.spec.ts` that loads the default workflow on an unsubscribed/zero-balance Local workspace, clicks the actual Run button, and asserts `POST /api/prompt` is issued. ## Verification - Passes against current main (real ComfyUI backend + dev server). - Fails against the pre-#16032 gate (`if (!canAccessSubscriptionFeatures.value)` reverted locally): Run click produces no prompt request, test times out — reproducing the QA report. - Full `localWorkspaceSwitcher.spec.ts` (3 tests) green. ## Review Focus - Coverage audit of this QA round: every other reported case already has unit + E2E coverage (race condition → `localWorkspaceSwitcher.spec.ts`; API-key billing → `apiKeyLoginBilling.spec.ts`; Add credits on Local → `localCreditsWorkspaceRail.spec.ts`; billing routes → `localCreditsNoSubscribeUi.spec.ts` / `cloud.spec.ts`; Cloud subscribe-to-run → `subscription.spec.ts` + unit gate tests in `useCoreCommands.test.ts`). This was the last gap.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🎭 Playwright: ✅ 1830 passed, 0 failed · 2 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
✅ No regressions detected. All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-08-26T21:39:08.457Z",
"gitSha": "83bd213a3f88f09869002da1a0adf48c522b1489",
"branch": "backport-16041-to-core-1.51",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2019.455999999991,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.277000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 339.59099999999995,
"heapDeltaBytes": 5124700,
"heapUsedBytes": 70156996,
"domNodes": 22,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 7.704000000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2005.9940000000438,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.942999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 336.343,
"heapDeltaBytes": 5011504,
"heapUsedBytes": 70593884,
"domNodes": 20,
"jsHeapTotalBytes": 24117248,
"scriptDurationMs": 7.308,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1732.4369999999476,
"styleRecalcs": 71,
"styleRecalcDurationMs": 32.858,
"layouts": 12,
"layoutDurationMs": 3.3880000000000003,
"taskDurationMs": 599.802,
"heapDeltaBytes": -1421728,
"heapUsedBytes": 63263636,
"domNodes": 53,
"jsHeapTotalBytes": 25694208,
"scriptDurationMs": 86.005,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1703.3400000000256,
"styleRecalcs": 71,
"styleRecalcDurationMs": 27.448,
"layouts": 12,
"layoutDurationMs": 3.05,
"taskDurationMs": 580.62,
"heapDeltaBytes": -261884,
"heapUsedBytes": 65040032,
"domNodes": 55,
"jsHeapTotalBytes": 25169920,
"scriptDurationMs": 78.005,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666682,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1667.3359999999775,
"styleRecalcs": 29,
"styleRecalcDurationMs": 14.306999999999999,
"layouts": 6,
"layoutDurationMs": 0.634,
"taskDurationMs": 282.115,
"heapDeltaBytes": 6990988,
"heapUsedBytes": 71780128,
"domNodes": 77,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 10.337999999999997,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1661.5090000000237,
"styleRecalcs": 29,
"styleRecalcDurationMs": 14.736,
"layouts": 6,
"layoutDurationMs": 0.5790000000000001,
"taskDurationMs": 275.716,
"heapDeltaBytes": 8319296,
"heapUsedBytes": 73789384,
"domNodes": 77,
"jsHeapTotalBytes": 23592960,
"scriptDurationMs": 9.896,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 411.75500000002785,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.098,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 260.41400000000004,
"heapDeltaBytes": -11439184,
"heapUsedBytes": 54132136,
"domNodes": 20,
"jsHeapTotalBytes": 23855104,
"scriptDurationMs": 41.123999999999995,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 473.33500000002005,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.278,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 288.34700000000004,
"heapDeltaBytes": -11846960,
"heapUsedBytes": 53670408,
"domNodes": 20,
"jsHeapTotalBytes": 25952256,
"scriptDurationMs": 43.638,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-idle",
"durationMs": 2000.5859999999984,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.814000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 478.84099999999995,
"heapDeltaBytes": 6753292,
"heapUsedBytes": 69413204,
"domNodes": -282,
"jsHeapTotalBytes": 3244032,
"scriptDurationMs": 15.466999999999999,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 1997.6489999999671,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.8130000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 444.53000000000003,
"heapDeltaBytes": 9164356,
"heapUsedBytes": 69440628,
"domNodes": -281,
"jsHeapTotalBytes": 2719744,
"scriptDurationMs": 13.849999999999998,
"eventListeners": -177,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2084.114999999997,
"styleRecalcs": 69,
"styleRecalcDurationMs": 16.842000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 966.4019999999999,
"heapDeltaBytes": 3895468,
"heapUsedBytes": 65161192,
"domNodes": -282,
"jsHeapTotalBytes": 3960832,
"scriptDurationMs": 270.397,
"eventListeners": -177,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2084.4730000000027,
"styleRecalcs": 69,
"styleRecalcDurationMs": 16.381,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 987.228,
"heapDeltaBytes": -851248,
"heapUsedBytes": 62310636,
"domNodes": -281,
"jsHeapTotalBytes": 3960832,
"scriptDurationMs": 260.325,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3219.980000000021,
"styleRecalcs": 67,
"styleRecalcDurationMs": 17.813999999999997,
"layouts": 60,
"layoutDurationMs": 9.008000000000001,
"taskDurationMs": 1065.4859999999999,
"heapDeltaBytes": -2697036,
"heapUsedBytes": 60024316,
"domNodes": -283,
"jsHeapTotalBytes": 4030464,
"scriptDurationMs": 288.588,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3044.1230000000132,
"styleRecalcs": 66,
"styleRecalcDurationMs": 16.580000000000002,
"layouts": 60,
"layoutDurationMs": 8.520999999999999,
"taskDurationMs": 938.8000000000001,
"heapDeltaBytes": 16228236,
"heapUsedBytes": 80672692,
"domNodes": 18,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 253.523,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 1992.8010000000427,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.649,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 419.4990000000001,
"heapDeltaBytes": 13217012,
"heapUsedBytes": 76172716,
"domNodes": -280,
"jsHeapTotalBytes": 3244032,
"scriptDurationMs": 13.830999999999996,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 1995.217000000025,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.051000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 474.16499999999996,
"heapDeltaBytes": 13220448,
"heapUsedBytes": 73904204,
"domNodes": -283,
"jsHeapTotalBytes": 2719744,
"scriptDurationMs": 15.221000000000002,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 494.8009999999954,
"styleRecalcs": 48,
"styleRecalcDurationMs": 10.57,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 301.374,
"heapDeltaBytes": -10150728,
"heapUsedBytes": 55588664,
"domNodes": 22,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 81.06200000000001,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 438.9129999999568,
"styleRecalcs": 48,
"styleRecalcDurationMs": 10.899000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 283.793,
"heapDeltaBytes": -11422828,
"heapUsedBytes": 54163668,
"domNodes": 22,
"jsHeapTotalBytes": 26214400,
"scriptDurationMs": 79.81,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 1989.3539999999916,
"styleRecalcs": 13,
"styleRecalcDurationMs": 8.406,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 338.372,
"heapDeltaBytes": 5424464,
"heapUsedBytes": 71245192,
"domNodes": 24,
"jsHeapTotalBytes": 23855104,
"scriptDurationMs": 7.124999999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2004.788000000019,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.295,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 347.79,
"heapDeltaBytes": 5113868,
"heapUsedBytes": 70667776,
"domNodes": 22,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 7.832999999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1675.4930000000172,
"styleRecalcs": 78,
"styleRecalcDurationMs": 33.862,
"layouts": 16,
"layoutDurationMs": 4.412,
"taskDurationMs": 602.926,
"heapDeltaBytes": -3654444,
"heapUsedBytes": 61858548,
"domNodes": 64,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 77.5,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666682,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1690.3239999999755,
"styleRecalcs": 77,
"styleRecalcDurationMs": 32.014,
"layouts": 16,
"layoutDurationMs": 4.149,
"taskDurationMs": 582.2360000000001,
"heapDeltaBytes": -3875248,
"heapUsedBytes": 61938620,
"domNodes": 63,
"jsHeapTotalBytes": 23592960,
"scriptDurationMs": 73.03099999999999,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 819.5789999999761,
"styleRecalcs": 20,
"styleRecalcDurationMs": 21.232999999999993,
"layouts": 15,
"layoutDurationMs": 8.445,
"taskDurationMs": 616.1289999999999,
"heapDeltaBytes": -5905960,
"heapUsedBytes": 77129328,
"domNodes": 13673,
"jsHeapTotalBytes": 9699328,
"scriptDurationMs": 11.269000000000002,
"eventListeners": 2373,
"totalBlockingTimeMs": 63,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8089.909000000034,
"styleRecalcs": 249,
"styleRecalcDurationMs": 44.812999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3153.795,
"heapDeltaBytes": 24984152,
"heapUsedBytes": 85660368,
"domNodes": -283,
"jsHeapTotalBytes": 3436544,
"scriptDurationMs": 754.7570000000001,
"eventListeners": -163,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8083.684000000005,
"styleRecalcs": 249,
"styleRecalcDurationMs": 43.619,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3145.2360000000003,
"heapDeltaBytes": 19993248,
"heapUsedBytes": 82631404,
"domNodes": -280,
"jsHeapTotalBytes": 5533696,
"scriptDurationMs": 730.39,
"eventListeners": -163,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 12454.173000000026,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11619.883,
"heapDeltaBytes": -38082152,
"heapUsedBytes": 173562192,
"domNodes": -8313,
"jsHeapTotalBytes": -12521472,
"scriptDurationMs": 86.72500000000001,
"eventListeners": -16389,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 12559.393,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11761.44,
"heapDeltaBytes": -29491112,
"heapUsedBytes": 169219332,
"domNodes": -8312,
"jsHeapTotalBytes": -16453632,
"scriptDurationMs": 89.59000000000002,
"eventListeners": -16393,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 14722.651999999982,
"styleRecalcs": 69,
"styleRecalcDurationMs": 14.93,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14094.726999999999,
"heapDeltaBytes": -34888660,
"heapUsedBytes": 190144100,
"domNodes": -8312,
"jsHeapTotalBytes": -8134656,
"scriptDurationMs": 339.202,
"eventListeners": -16389,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 14643.095000000016,
"styleRecalcs": 71,
"styleRecalcDurationMs": 15.064999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14037.293000000001,
"heapDeltaBytes": -12293316,
"heapUsedBytes": 186697828,
"domNodes": -8312,
"jsHeapTotalBytes": -12066816,
"scriptDurationMs": 339.43100000000004,
"eventListeners": -16387,
"totalBlockingTimeMs": 89,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 436.49799999997185,
"styleRecalcs": 16,
"styleRecalcDurationMs": 19.427,
"layouts": 2,
"layoutDurationMs": 0.446,
"taskDurationMs": 88.507,
"heapDeltaBytes": 5001596,
"heapUsedBytes": 69589752,
"domNodes": 130,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 6.079,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 448.0150000000549,
"styleRecalcs": 17,
"styleRecalcDurationMs": 15.543,
"layouts": 2,
"layoutDurationMs": 0.8409999999999997,
"taskDurationMs": 85.484,
"heapDeltaBytes": 5131412,
"heapUsedBytes": 69885424,
"domNodes": 149,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 6.957000000000001,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000273
}
]
} |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.51 #16057 +/- ##
==========================================
Coverage 81.71% 81.71%
==========================================
Files 1885 1885
Lines 107292 107292
Branches 30088 30088
==========================================
Hits 87675 87675
Misses 19270 19270
Partials 347 347
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Backport of #16041 to
core/1.51Automatically created by backport workflow.